Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(cymbal): report sourcemap-resolved js frame positions 1-based (#127444)

posthog[bot]a428e0d0e749
diff --git a/rust/cymbal/src/core/types/langs/hermes.rs b/rust/cymbal/src/core/types/langs/hermes.rs
index 710e57a89251..8a8d98128f9b 100644
--- a/rust/cymbal/src/core/types/langs/hermes.rs
+++ b/rust/cymbal/src/core/types/langs/hermes.rs
@@ -88,6 +88,7 @@ impl RawHermesFrame {
return Ok(self.into());
}
+ // Hermes prints the bytecode offset as the column, and it is 0-based, unlike JS columns
let column = self.column.unwrap();
let Some(token) = sourcemap.lookup_token(0, column) else {
return Err(HermesError::NoTokenForColumn(column, r.to_string()).into());
@@ -191,8 +192,8 @@ impl From<(&RawHermesFrame, Token<'_>, Option<String>, usize)> for Frame {
let mut res = Self {
frame_id: FrameId::placeholder(),
mangled_name: frame.fn_name.clone(),
- line: Some(token.get_src_line()),
- column: Some(token.get_src_col()),
+ line: Some(token.get_src_line().saturating_add(1)),
+ column: Some(token.get_src_col().saturating_add(1)),
source,
in_app,
resolved_name,
@@ -325,8 +326,8 @@ mod test {
resolved.source.as_deref(),
Some("./build/android/index.android.bundle")
);
- assert_eq!(resolved.line, Some(49));
- assert_eq!(resolved.column, Some(26));
+ assert_eq!(resolved.line, Some(50));
+ assert_eq!(resolved.column, Some(27));
assert_eq!(resolved.resolved_name, None);
assert_eq!(resolved.resolve_failure, None);
}
diff --git a/rust/cymbal/src/core/types/langs/js.rs b/rust/cymbal/src/core/types/langs/js.rs
index 4dc7dc89d6ee..deb6c7053c1b 100644
--- a/rust/cymbal/src/core/types/langs/js.rs
+++ b/rust/cymbal/src/core/types/langs/js.rs
@@ -86,8 +86,11 @@ impl RawJSFrame {
let sourcemap = catalog.lookup(team_id, r).await?;
let smc = sourcemap.get_smc();
- // Note: javascript stack frame lines are 1-indexed, so we have to subtract 1
- let generated_position = SourcePosition::new(location.line - 1, location.column);
+ // JS stack frame lines and columns are 1-based, but the sourcemap cache is 0-based
+ let generated_position = SourcePosition::new(
+ location.line.saturating_sub(1),
+ location.column.saturating_sub(1),
+ );
let Some(location) = smc.lookup(generated_position) else {
return Err(JsResolveErr::TokenNotFound(
self.fn_name.clone(),
@@ -237,8 +240,8 @@ impl From<(&RawJSFrame, SourceLocation<'_>, usize)> for Frame {
let mut res = Self {
frame_id: FrameId::placeholder(), // We use placeholders here, as they're overriden at the RawFrame level
mangled_name: raw_frame.fn_name.clone(),
- line: Some(token.line()),
- column: Some(token.column()),
+ line: Some(token.line() + 1),
+ column: Some(token.column() + 1),
source,
in_app,
resolved_name,
@@ -387,7 +390,7 @@ mod test {
async fn source_map_ignore_list_demotes_only_ignored_sources() {
let catalog = source_map_catalog();
- let vendor = resolvable_frame(0)
+ let vendor = resolvable_frame(1)
.resolve_frame(1, &catalog, 0)
.await
.unwrap();
@@ -395,7 +398,7 @@ mod test {
assert_eq!(vendor.source.as_deref(), Some("vendor.js"));
assert!(!vendor.in_app);
- let app = resolvable_frame(10)
+ let app = resolvable_frame(11)
.resolve_frame(1, &catalog, 0)
.await
.unwrap();
@@ -404,6 +407,22 @@ mod test {
assert!(app.in_app);
}
+ #[tokio::test]
+ async fn resolves_1_based_frame_positions_to_1_based_source_positions() {
+ let catalog = source_map_catalog();
+
+ // The map starts app.js at 0-based minified column 10, which is 1-based column 11.
+ for (column, expected_source) in [(10, "vendor.js"), (11, "app.js")] {
+ let frame = resolvable_frame(column)
+ .resolve_frame(1, &catalog, 1)
+ .await
+ .unwrap();
+ assert_eq!(frame.source.as_deref(), Some(expected_source), "{column}");
+ assert_eq!((frame.line, frame.column), (Some(1), Some(1)), "{column}");
+ assert_eq!(frame.context.as_ref().unwrap().line.number, 1, "{column}");
+ }
+ }
+
#[test]
fn detects_dependency_sources() {
let cases = [
diff --git a/rust/cymbal/src/core/types/langs/node.rs b/rust/cymbal/src/core/types/langs/node.rs
index 0926f4dbe98a..80352a4be221 100644
--- a/rust/cymbal/src/core/types/langs/node.rs
+++ b/rust/cymbal/src/core/types/langs/node.rs
@@ -87,8 +87,11 @@ impl RawNodeFrame {
let chunk_ref = OrChunkId::ChunkId(chunk_id);
let sourcemap = catalog.lookup(team_id, chunk_ref).await?;
let smc = sourcemap.get_smc();
- // Note: javascript stack frame lines are 1-indexed, so we have to subtract 1
- let generated_position = SourcePosition::new(location.line - 1, location.column);
+ // JS stack frame lines and columns are 1-based, but the sourcemap cache is 0-based
+ let generated_position = SourcePosition::new(
+ location.line.saturating_sub(1),
+ location.column.saturating_sub(1),
+ );
if let Some(location) = smc.lookup(generated_position) {
let mut frame = Frame::from((self, location, context_lines));
if sourcemap.is_source_ignored(generated_position) {
@@ -228,8 +231,8 @@ impl From<(&RawNodeFrame, SourceLocation<'_>, usize)> for Frame {
let mut res = Self {
frame_id: FrameId::placeholder(),
mangled_name: raw_frame.function.clone(),
- line: Some(location.line()),
- column: Some(location.column()),
+ line: Some(location.line() + 1),
+ column: Some(location.column() + 1),
source: location
.file()
.and_then(|f| f.name())
@@ -350,7 +353,7 @@ mod test {
async fn source_map_ignore_list_demotes_only_ignored_sources() {
let catalog = source_map_catalog();
- let vendor = resolvable_frame(0)
+ let vendor = resolvable_frame(1)
.resolve_frame(1, &catalog, 0)
.await
.unwrap();
@@ -358,7 +361,7 @@ mod test {
assert_eq!(vendor.source.as_deref(), Some("vendor.js"));
assert!(!vendor.in_app);
- let app = resolvable_frame(10)
+ let app = resolvable_frame(11)
.resolve_frame(1, &catalog, 0)
.await
.unwrap();
@@ -367,6 +370,40 @@ mod test {
assert!(app.in_app);
}
+ #[tokio::test]
+ async fn resolves_1_based_frame_positions_to_1_based_source_positions() {
+ let catalog = source_map_catalog();
+
+ for (column, expected_source) in [(10, "vendor.js"), (11, "app.js")] {
+ let frame = resolvable_frame(column)
+ .resolve_frame(1, &catalog, 1)
+ .await
+ .unwrap();
+ assert_eq!(frame.source.as_deref(), Some(expected_source), "{column}");
+ assert_eq!((frame.line, frame.column), (Some(1), Some(1)), "{column}");
+ assert_eq!(frame.context.as_ref().unwrap().line.number, 1, "{column}");
+ }
+ }
+
+ #[tokio::test]
+ async fn frames_without_a_chunk_id_keep_their_captured_line() {
+ let catalog = source_map_catalog();
+ let raw: RawNodeFrame = serde_json::from_value(serde_json::json!({
+ "filename": "dist/widget.js",
+ "function": "renderWidget",
+ "lineno": 42,
+ "colno": 7,
+ "context_line": "renderWidget()",
+ }))
+ .unwrap();
+
+ let frame = raw.resolve_frame(1, &catalog, 1).await.unwrap();
+ assert_eq!(frame.line, Some(42));
+ assert_eq!(frame.column, None);
+ assert_eq!(frame.source.as_deref(), Some("dist/widget.js"));
+ assert_eq!(frame.context.as_ref().unwrap().line.number, 42);
+ }
+
#[test]
fn frame_id_distinguishes_columns_on_the_same_line() {
// Minified bundles put every frame on line 1 of the same file with an anonymized
diff --git a/rust/cymbal/tests/snapshots/event__resolves_javascript_with_sourcemaps.snap b/rust/cymbal/tests/snapshots/event__resolves_javascript_with_sourcemaps.snap
index d024780e33c0..88702bff4429 100644
--- a/rust/cymbal/tests/snapshots/event__resolves_javascript_with_sourcemaps.snap
+++ b/rust/cymbal/tests/snapshots/event__resolves_javascript_with_sourcemaps.snap
@@ -13,11 +13,11 @@ expression: exception_list.0
{
"raw_id": "a95875fcfec1a69333fd83d0ae05bd3606754a0fdfc780a1714603973bb055748391a1f49aa8af42d5aafaaea883819678452d916cb63760c2f1309d47cc1b51/0",
"mangled_name": "onClick",
- "line": 98,
- "column": 52,
+ "line": 99,
+ "column": 40,
"source": "../../node_modules/.pnpm/[email protected]/node_modules/monaco-editor/esm/vs/editor/browser/widget/diffEditor/components/diffEditorViewZones/inlineDiffDeletedCodeMargin.js",
"in_app": false,
- "resolved_name": "<anonymous>",
+ "resolved_name": "new InlineDiffDeletedCodeMargin",
"lang": "javascript",
"resolved": true,
"synthetic": false,
@@ -37,8 +37,8 @@ expression: exception_list.0
{
"raw_id": "297df7e7a72cd11679d8a970ae431a6e43ed068d0131470ad0d4e48e754ae62b19df3e720de7b9b60c04c59eedc6d2390073d7d66c6aa90a71c19e00dac258da/0",
"mangled_name": "onClick",
- "line": 296,
- "column": 73,
+ "line": 297,
+ "column": 74,
"source": "../../node_modules/.pnpm/[email protected]/node_modules/monaco-editor/esm/vs/editor/browser/widget/codeEditor/codeEditorWidget.js",
"in_app": false,
"resolved_name": "CodeEditorWidget_1.getValue",
@@ -61,8 +61,8 @@ expression: exception_list.0
{
"raw_id": "cceb91e8a17ce28158fe4f61c161f3da3bd47eee7ee58d7433a48bbff1ffaa5c1a8040b46b61658c9840865658d2c711e9f6f3ef52b9ad54e95cc19b1790181c/0",
"mangled_name": "onClick",
- "line": 36,
- "column": 21,
+ "line": 37,
+ "column": 22,
"source": "../../node_modules/.pnpm/[email protected]/node_modules/monaco-editor/esm/vs/editor/common/languages/supports/characterPair.js",
"in_app": false,
"resolved_name": "init_characterPair",