Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(bi): apply conditional formatting to pivot measures (#124717)

Marius Andraa648903a3e60
diff --git a/docs/published/handbook/engineering/data-warehouse.md b/docs/published/handbook/engineering/data-warehouse.md
index 7cfc992971cd..81e130f8127e 100644
--- a/docs/published/handbook/engineering/data-warehouse.md
+++ b/docs/published/handbook/engineering/data-warehouse.md
@@ -434,3 +434,7 @@ inside expanded connections, and a failed field load has a Retry button.
Aliases load any intermediate tables automatically. Loading and failed connections stay visible during search.
Virtual connections expose the field names provided by the existing schema as dimensions. The schema does
not include their field types or nested link definitions, so these connections do not infer measures or further links.
+
+### Pivot conditional formatting
+
+BI pivot tables use the same saved conditional formatting rules as ordinary tables. Open **Conditional formatting** to select a measure and a rule. The rule applies to that measure across column groups, including displayed subtotals, grand totals, and collapsed groups. Rules evaluate raw aggregate values before display formatting. Empty intersections and hidden parent values remain uncolored.
diff --git a/frontend/snapshots.yml b/frontend/snapshots.yml
index 929fe233d0ad..ab1001b9d932 100644
--- a/frontend/snapshots.yml
+++ b/frontend/snapshots.yml
@@ -6900,6 +6900,10 @@ snapshots:
hash: v1.k794b7964.685e595b2d82e74d28e617318f7ab37134911236fe466774afd1d226973032c8.W4MK1HnWdy6MWAiwx5r9tbBjfoDjCeHmfEBHofnhsYc
products-business-intelligence-dashboard-filter-bar--quill--light:
hash: v1.k794b7964.c62c158d76af1654b660d3d06e658d279edbc27a2c4887574d2c94206ce8eca7.1bXevOAdN31g-PzyVyWxCY5d8UwJKMv5T2FJ6Sv12K8
+ products-business-intelligence-pivot-table--conditional-formatting--dark:
+ hash: v1.k794b7964.8647a315842a7e58e16b9597686a037f51fca27b39cc31a86364531342f0de2d.KI6_i9LRgw64b1jPz_P-_1ghk-QlxGRt8OphgQTyh6o
+ products-business-intelligence-pivot-table--conditional-formatting--light:
+ hash: v1.k794b7964.3cbbadacb98d1e07b58dc31fdd88e3e69bfe7c74d8512c0cf96afa81092bd4c8.Nk8eKH-PHZdZqcSCV7DoYEjwNNX8DL9nArAgYohDblU
products-business-intelligence-pivot-table--multiple-measures-and-hierarchies--dark:
hash: v1.k794b7964.26ebc58171eb340426f9fe220739132bca02f59b8489cb5a0b8a6411f99bb34d.oNv5X9sNKiPmhC_sE607b5P0yHAJju-hcC7higWxX9g
products-business-intelligence-pivot-table--multiple-measures-and-hierarchies--light:
diff --git a/frontend/src/queries/nodes/DataVisualization/Components/SideBar.tsx b/frontend/src/queries/nodes/DataVisualization/Components/SideBar.tsx
index 28d0e89377f1..8391b073b987 100644
--- a/frontend/src/queries/nodes/DataVisualization/Components/SideBar.tsx
+++ b/frontend/src/queries/nodes/DataVisualization/Components/SideBar.tsx
@@ -3,8 +3,11 @@ import { useMemo } from 'react'
import { LemonTab, LemonTabs } from '@posthog/lemon-ui'
+import { NodeKind } from '~/queries/schema/schema-general'
import { ChartDisplayType } from '~/types'
+import { isBIPivotTable } from 'products/business_intelligence/frontend/biTableLayout'
+
import { SideBarTab, dataVisualizationLogic } from '../dataVisualizationLogic'
import { ConditionalFormattingTab } from './ConditionalFormatting/ConditionalFormattingTab'
import { DisplayTab } from './DisplayTab'
@@ -40,18 +43,23 @@ const TABS_TO_CONTENT: Record<SideBarTab, TabContent> = {
}
export const SideBar = ({ className = 'w-72 max-w-[50%] shrink-0' }: { className?: string }): JSX.Element => {
- const { activeSideBarTab, effectiveVisualizationType } = useValues(dataVisualizationLogic)
+ const { activeSideBarTab, effectiveVisualizationType, query } = useValues(dataVisualizationLogic)
const { setSideBarTab } = useActions(dataVisualizationLogic)
+ const isPivot = query.kind === NodeKind.BIVisualizationNode && isBIPivotTable(query.config)
const tabs: LemonTab<string>[] = useMemo(
() =>
Object.entries(TABS_TO_CONTENT)
- .filter(([_, tab]) => tab.shouldShow(effectiveVisualizationType))
+ .filter(
+ ([key, tab]) =>
+ tab.shouldShow(effectiveVisualizationType) ||
+ (key === SideBarTab.ConditionalFormatting && isPivot)
+ )
.map(([key, tab]) => ({
label: tab.label,
key,
})),
- [effectiveVisualizationType]
+ [effectiveVisualizationType, isPivot]
)
const activeTab = tabs.some((tab) => tab.key === activeSideBarTab) ? activeSideBarTab : SideBarTab.Series
diff --git a/frontend/src/queries/nodes/DataVisualization/Components/Table.tsx b/frontend/src/queries/nodes/DataVisualization/Components/Table.tsx
index 894972305d69..40ba03c6af81 100644
--- a/frontend/src/queries/nodes/DataVisualization/Components/Table.tsx
+++ b/frontend/src/queries/nodes/DataVisualization/Components/Table.tsx
@@ -1,14 +1,12 @@
import '../../DataTable/DataTable.scss'
import { useActions, useValues } from 'kea'
-import posthog from 'posthog-js'
import React, { useCallback, useLayoutEffect, useMemo, useRef, useState } from 'react'
import { IconPin, IconPinFilled } from '@posthog/icons'
import { LemonBanner, LemonButton, LemonTable, LemonTableColumn, Tooltip } from '@posthog/lemon-ui'
import { dayjs } from 'lib/dayjs'
-import { lightenDarkenColor } from 'lib/utils/colors'
import { InsightEmptyState, InsightErrorState } from 'scenes/insights/EmptyStates'
import { themeLogic } from '~/layout/navigation-3000/themeLogic'
@@ -19,7 +17,8 @@ import { LoadNext } from '../../DataNode/LoadNext'
import { renderColumn } from '../../DataTable/renderColumn'
import { renderColumnMeta } from '../../DataTable/renderColumnMeta'
import { getContrastingTextClass } from '../colorUtils'
-import { TableDataCell, TableRow, convertTableValue, dataVisualizationLogic } from '../dataVisualizationLogic'
+import { conditionalFormattingColor } from '../conditionalFormatting'
+import { TableDataCell, TableRow, dataVisualizationLogic } from '../dataVisualizationLogic'
import { ColumnScalar } from '../types'
interface TableProps {
@@ -284,50 +283,14 @@ export const Table = (props: TableProps): JSX.Element => {
const sourceColumnName = cell.sourceColumnName ?? column.name
const sourceColumnType = sourceTabularColumnsByName.get(sourceColumnName)?.column.type.name ?? cell.type
- const conditionalFormattingMatches = conditionalFormattingRules
- .filter((n) => n.columnName === sourceColumnName)
- .filter((n) => {
- const isValidHog = !!n.bytecode && n.bytecode.length > 0 && n.bytecode[0] === '_H'
- if (!isValidHog) {
- posthog.captureException(new Error('Invalid hog bytecode for conditional formatting'), {
- formatRule: n,
- })
- }
-
- return isValidHog
- })
- .map((n) => ({
- rule: n,
- result: hogVm.execHog(n.bytecode, {
- globals: {
- value: cell.value,
- input: convertTableValue(n.input, sourceColumnType),
- },
- functions: {},
- maxAsyncSteps: 0,
- }).result,
- }))
- .find((n) => Boolean(n.result))
-
- if (!conditionalFormattingMatches) {
- return undefined
- }
-
- const ruleColor = conditionalFormattingMatches.rule.color
- const colorMode = conditionalFormattingMatches.rule.colorMode ?? 'light'
-
- // If the color mode matches the current theme, use the color as it was saved
- if ((colorMode === 'dark' && isDarkModeOn) || (colorMode === 'light' && !isDarkModeOn)) {
- return ruleColor
- }
-
- // If the color mode is dark, but we're in light mode - then lighten the color
- if (colorMode === 'dark' && !isDarkModeOn) {
- return lightenDarkenColor(ruleColor, 30)
- }
-
- // If the color mode is light, but we're in dark mode - then darken the color
- return lightenDarkenColor(ruleColor, -30)
+ return conditionalFormattingColor(
+ conditionalFormattingRules,
+ hogVm.execHog,
+ sourceColumnName,
+ sourceColumnType,
+ cell.value,
+ isDarkModeOn
+ )
}
// The style and class callbacks run separately. Cache the last row to avoid a second HogVM call
diff --git a/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx b/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx
index 4372da7ec6de..5a5bb6db01ad 100644
--- a/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx
+++ b/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx
@@ -18,6 +18,7 @@ import { insightLogic } from 'scenes/insights/insightLogic'
import { teamLogic } from 'scenes/teamLogic'
import { urls } from 'scenes/urls'
+import { themeLogic } from '~/layout/navigation-3000/themeLogic'
import { insightVizDataCollectionId, insightVizDataNodeKey } from '~/queries/nodes/InsightViz/insightVizKeys'
import {
AnyResponseType,
@@ -71,6 +72,7 @@ import { AddVariableButton } from './Components/Variables/AddVariableButton'
import { variableModalLogic } from './Components/Variables/variableModalLogic'
import { VariablesForInsight } from './Components/Variables/Variables'
import { VariablesLogicProps, variablesLogic } from './Components/Variables/variablesLogic'
+import { conditionalFormattingColor } from './conditionalFormatting'
import { DataVisualizationLogicProps, SideBarTab, dataVisualizationLogic } from './dataVisualizationLogic'
import { displayLogic } from './displayLogic'
import { applyDataVisualizationQueryUpdate } from './queryUpdateUtils'
@@ -223,11 +225,17 @@ function InternalDataTableVisualization(props: DataTableVisualizationProps): JSX
yData,
columns,
chartSettings,
+ conditionalFormattingRules,
+ hogVm,
+ hogVmLoadFailed,
dashboardId,
dataVisualizationProps,
presetChartHeight: scenePresetChartHeight,
} = useValues(dataVisualizationLogic)
+ const { isDarkModeOn } = useValues(themeLogic)
+ const columnTypes = useMemo(() => new Map(columns.map((column) => [column.name, column.type.name])), [columns])
+
const presetChartHeight =
!props.embedded &&
scenePresetChartHeight &&
@@ -478,7 +486,21 @@ function InternalDataTableVisualization(props: DataTableVisualizationProps): JSX
onInspect: canDrill ? inspect : undefined,
}
component = isBIPivotTable(query.config) ? (
- <BIPivotTable {...resultProps} embedded={props.embedded} />
+ <BIPivotTable
+ {...resultProps}
+ embedded={props.embedded}
+ formattingLoadFailed={hogVmLoadFailed}
+ cellBackground={(record, column) =>
+ conditionalFormattingColor(
+ conditionalFormattingRules,
+ hogVm?.execHog,
+ column,
+ columnTypes.get(column) ?? 'UNKNOWN',
+ record[column],
+ isDarkModeOn
+ )
+ }
+ />
) : (
<BIComparisonSummary {...resultProps} card={effectiveVisualizationType !== ChartDisplayType.ActionsTable} />
)
@@ -780,8 +802,8 @@ function InternalDataTableVisualization(props: DataTableVisualizationProps): JSX
/>
{query.kind === NodeKind.BIVisualizationNode &&
- effectiveVisualizationType === ChartDisplayType.ActionsTable &&
- !isBIPivotTable(query.config) && (
+ (effectiveVisualizationType === ChartDisplayType.ActionsTable ||
+ isBIPivotTable(query.config)) && (
<LemonButton
size={controlSize}
type="secondary"
diff --git a/frontend/src/queries/nodes/DataVisualization/conditionalFormatting.ts b/frontend/src/queries/nodes/DataVisualization/conditionalFormatting.ts
new file mode 100644
index 000000000000..de1c851555bc
--- /dev/null
+++ b/frontend/src/queries/nodes/DataVisualization/conditionalFormatting.ts
@@ -0,0 +1,66 @@
+import posthog from 'posthog-js'
+
+import type { execHog } from 'lib/hog'
+import { lightenDarkenColor } from 'lib/utils/colors'
+
+import { ConditionalFormattingRule } from '~/queries/schema/schema-general'
+
+import { convertTableValue } from './dataVisualizationLogic'
+import { ColumnScalar } from './types'
+
+export function conditionalFormattingColor(
+ rules: ConditionalFormattingRule[],
+ execute: typeof execHog | undefined,
+ columnName: string,
+ columnType: ColumnScalar,
+ value: unknown,
+ isDarkModeOn: boolean
+): string | undefined {
+ if (!execute) {
+ return undefined
+ }
+ const conditionalFormattingMatches = rules
+ .filter((n) => n.columnName === columnName)
+ .filter((n) => {
+ const isValidHog = !!n.bytecode && n.bytecode.length > 0 && n.bytecode[0] === '_H'
+ if (!isValidHog) {
+ posthog.captureException(new Error('Invalid hog bytecode for conditional formatting'), {
+ formatRule: n,
+ })
+ }
+
+ return isValidHog
+ })
+ .map((n) => ({
+ rule: n,
+ result: execute(n.bytecode, {
+ globals: {
+ value: typeof value === 'string' ? convertTableValue(value, columnType) : value,
+ input: convertTableValue(n.input, columnType),
+ },
+ functions: {},
+ maxAsyncSteps: 0,
+ }).result,
+ }))
+ .find((n) => Boolean(n.result))
+
+ if (!conditionalFormattingMatches) {
+ return undefined
+ }
+
+ const ruleColor = conditionalFormattingMatches.rule.color
+ const colorMode = conditionalFormattingMatches.rule.colorMode ?? 'light'
+
+ // If the color mode matches the current theme, use the color as it was saved
+ if ((colorMode === 'dark' && isDarkModeOn) || (colorMode === 'light' && !isDarkModeOn)) {
+ return ruleColor
+ }
+
+ // If the color mode is dark, but we're in light mode - then lighten the color
+ if (colorMode === 'dark' && !isDarkModeOn) {
+ return lightenDarkenColor(ruleColor, 30)
+ }
+
+ // If the color mode is light, but we're in dark mode - then darken the color
+ return lightenDarkenColor(ruleColor, -30)
+}
diff --git a/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.test.ts b/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.test.ts
index f2e1054ed170..08ef3786ebe6 100644
--- a/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.test.ts
+++ b/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.test.ts
@@ -968,6 +968,13 @@ describe('dataVisualizationLogic', () => {
rules: [equalsRule],
hogVm: expect.anything(),
},
+ {
+ name: 'loads the Hog VM for a BI hierarchy pivot with formatting rules',
+ display: ChartDisplayType.TwoDimensionalHeatmap,
+ rules: [equalsRule],
+ hogVm: expect.anything(),
+ pivot: true,
+ },
{
name: 'does not load the Hog VM for a table without formatting rules',
display: ChartDisplayType.ActionsTable,
@@ -986,10 +993,28 @@ describe('dataVisualizationLogic', () => {
rules: [equalsRule],
hogVm: null,
},
- ])('$name', async ({ display, rules, hogVm }) => {
+ ])('$name', async ({ display, rules, hogVm, pivot }) => {
const tableLogic = dataVisualizationLogic({
key: 'hog-vm-loading',
- query: { ...defaultQuery, display, tableSettings: { conditionalFormatting: rules } },
+ query: {
+ ...defaultQuery,
+ ...(pivot
+ ? {
+ kind: NodeKind.BIVisualizationNode,
+ config: {
+ source: null,
+ chartType: display,
+ rows: [],
+ columns: [],
+ values: [],
+ filters: [],
+ limit: 100,
+ },
+ }
+ : {}),
+ display,
+ tableSettings: { conditionalFormatting: rules },
+ },
dataNodeCollectionId,
} as DataVisualizationLogicProps)
tableLogic.mount()
diff --git a/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts b/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts
index de900f2736f6..c17df9911538 100644
--- a/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts
+++ b/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts
@@ -57,6 +57,7 @@ import {
getBIVisualizationResponse,
getBIVisualizationSource,
} from 'products/business_intelligence/frontend/biQueryResults'
+import { isBIPivotTable } from 'products/business_intelligence/frontend/biTableLayout'
import type {
DataNode,
@@ -966,7 +967,8 @@ export interface dataVisualizationLogicMeta {
visualizationType: ChartDisplayType,
effectiveVisualizationType: ChartDisplayType,
columns: Column[],
- conditionalFormattingRules: ConditionalFormattingRule[]
+ conditionalFormattingRules: ConditionalFormattingRule[],
+ query: VisualizationNode
) => boolean
hogVmLoadFailed: (needsHogVm: boolean, hogVmLoadError: unknown) => boolean
isTableVisualization: (effectiveVisualizationType: ChartDisplayType) => boolean
@@ -1928,15 +1930,23 @@ export const dataVisualizationLogic = kea<dataVisualizationLogicType>([
// The Hog VM and its crypto polyfills are large, so only a table that shows formatting rules loads them.
// Auto resolves to a table until columns arrive, so it waits for them before it decides.
needsHogVm: [
- (s) => [s.visualizationType, s.effectiveVisualizationType, s.columns, s.conditionalFormattingRules],
+ (s) => [
+ s.visualizationType,
+ s.effectiveVisualizationType,
+ s.columns,
+ s.conditionalFormattingRules,
+ s.query,
+ ],
(
visualizationType: ChartDisplayType,
effectiveVisualizationType: ChartDisplayType,
columns: Column[],
- rules: ConditionalFormattingRule[]
+ rules: ConditionalFormattingRule[],
+ query: VisualizationNode
): boolean =>
(visualizationType !== ChartDisplayType.Auto || columns.length > 0) &&
- effectiveVisualizationType === ChartDisplayType.ActionsTable &&
+ (effectiveVisualizationType === ChartDisplayType.ActionsTable ||
+ (query.kind === NodeKind.BIVisualizationNode && isBIPivotTable(query.config))) &&
rules.length > 0,
],
hogVmLoadFailed: [
diff --git a/products/business_intelligence/frontend/BIPivotTable.stories.tsx b/products/business_intelligence/frontend/BIPivotTable.stories.tsx
index ffd2bad626e3..914c1c15412c 100644
--- a/products/business_intelligence/frontend/BIPivotTable.stories.tsx
+++ b/products/business_intelligence/frontend/BIPivotTable.stories.tsx
@@ -1,5 +1,10 @@
import { Meta, StoryObj } from '@storybook/react'
+import { useValues } from 'kea'
+import { execHog } from 'lib/hog'
+
+import { themeLogic } from '~/layout/navigation-3000/themeLogic'
+import { conditionalFormattingColor } from '~/queries/nodes/DataVisualization/conditionalFormatting'
import { BIConfig, BIField } from '~/queries/schema/schema-business-intelligence'
import { ChartDisplayType } from '~/types'
@@ -87,3 +92,35 @@ const meta: Meta<typeof BIPivotTable> = {
}
export default meta
export const MultipleMeasuresAndHierarchies: StoryObj<typeof BIPivotTable> = {}
+
+export const ConditionalFormatting: StoryObj<typeof BIPivotTable> = {
+ render: function Render(args) {
+ const { isDarkModeOn } = useValues(themeLogic)
+ return (
+ <BIPivotTable
+ {...args}
+ onInspect={() => {}}
+ cellBackground={(record, column) =>
+ conditionalFormattingColor(
+ [
+ {
+ id: 'revenue',
+ templateId: 'greater_than',
+ columnName: 'sum_revenue',
+ input: '1500',
+ color: '#CAFFBF',
+ colorMode: 'light',
+ bytecode: ['_H', 1, 32, 'input', 1, 1, 32, 'value', 1, 1, 13, 38],
+ },
+ ],
+ execHog,
+ column,
+ 'INTEGER',
+ record[column],
+ isDarkModeOn
+ )
+ }
+ />
+ )
+ },
+}
diff --git a/products/business_intelligence/frontend/BIPivotTable.test.tsx b/products/business_intelligence/frontend/BIPivotTable.test.tsx
index 6c8d9eb18d11..d5b19cb0334d 100644
--- a/products/business_intelligence/frontend/BIPivotTable.test.tsx
+++ b/products/business_intelligence/frontend/BIPivotTable.test.tsx
@@ -2,7 +2,12 @@ import '@testing-library/jest-dom'
import { cleanup, fireEvent, render, screen } from '@testing-library/react'
+import { execHog } from 'lib/hog'
+
+import { conditionalFormattingColor } from '~/queries/nodes/DataVisualization/conditionalFormatting'
+import { ColumnScalar } from '~/queries/nodes/DataVisualization/types'
import { BIConfig, BIField } from '~/queries/schema/schema-business-intelligence'
+import { ConditionalFormattingRule } from '~/queries/schema/schema-general'
import { initKeaTests } from '~/test/init'
import { ChartDisplayType } from '~/types'
@@ -24,6 +29,65 @@ describe('BIPivotTable', () => {
jest.restoreAllMocks()
})
+ it.each<[boolean, string | number, string | number, ColumnScalar]>([
+ [false, 10, 20, 'INTEGER'],
+ [true, 10, 20, 'INTEGER'],
+ [false, '10', '20', 'INTEGER'],
+ [true, '10', '20', 'INTEGER'],
+ [false, '2026-01-10', '2026-01-20', 'DATE'],
+ [false, '2026-01-10T12:00:00Z', '2026-01-20T12:00:00Z', 'DATETIME'],
+ ])(
+ 'formats raw measure values across pivot columns and updates rules, dark=%s, first=%s, second=%s, type=%s',
+ (dark, first, second, type) => {
+ jest.spyOn(HTMLElement.prototype, 'offsetHeight', 'get').mockReturnValue(400)
+ jest.spyOn(HTMLElement.prototype, 'offsetWidth', 'get').mockReturnValue(800)
+ const config: BIConfig = {
+ ...DEFAULT_BI_CONFIG,
+ chartType: ChartDisplayType.ActionsTable,
+ rows: [field('region')],
+ columns: [field('channel')],
+ values: [{ field: field('amount'), aggregation: 'sum', formatting: { style: 'number', prefix: '$' } }],
+ }
+ const rule: ConditionalFormattingRule = {
+ id: 'equals',
+ templateId: 'equals',
+ columnName: 'sum_amount',
+ input: String(first),
+ color: '#FFADAD',
+ colorMode: 'light',
+ bytecode: ['_H', 1, 32, 'input', 1, 1, 32, 'value', 1, 1, 11, 38],
+ }
+ const props = {
+ config,
+ columns: ['bi_row_region', 'bi_column_channel', 'sum_amount'],
+ results: [
+ ['East', 'Email', first],
+ ['East', 'Search', second],
+ ['West', 'Search', first],
+ ],
+ }
+ const background = (record: Record<string, unknown>, column: string): string | undefined =>
+ conditionalFormattingColor([rule], execHog, column, type, record[column], dark)
+ const { container, rerender } = render(<BIPivotTable {...props} cellBackground={background} />)
+ const coloredCells = (): HTMLElement[] =>
+ Array.from(container.querySelectorAll<HTMLElement>('tbody td')).filter(
+ (cell) => !!cell.style.backgroundColor
+ )
+ expect(coloredCells()).toHaveLength(2)
+ expect(
+ coloredCells().every((cell) => cell.textContent === `${type === 'INTEGER' ? '$' : ''}${first}`)
+ ).toBe(true)
+ const firstColor = coloredCells()[0].style.backgroundColor
+ rule.input = String(second)
+ rerender(<BIPivotTable {...props} cellBackground={background} />)
+ expect(coloredCells()).toHaveLength(1)
+ expect(coloredCells()[0]).toHaveTextContent(`${type === 'INTEGER' ? '$' : ''}${second}`)
+ expect(coloredCells()[0].style.backgroundColor).toBe(firstColor)
+ rerender(<BIPivotTable {...props} cellBackground={() => undefined} />)
+ expect(coloredCells()).toHaveLength(0)
+ }
+ )
+
it('windows a large sparse pivot on both axes and inspects the last cell', () => {
jest.spyOn(HTMLElement.prototype, 'offsetHeight', 'get').mockImplementation(
function (this: HTMLElement): number {
diff --git a/products/business_intelligence/frontend/BIPivotTable.tsx b/products/business_intelligence/frontend/BIPivotTable.tsx
index 2bde00bf4a33..ea803ce07741 100644
--- a/products/business_intelligence/frontend/BIPivotTable.tsx
+++ b/products/business_intelligence/frontend/BIPivotTable.tsx
@@ -3,6 +3,7 @@ import { useMemo, useState } from 'react'
import { IconChevronDown, IconChevronRight } from '@posthog/icons'
import { LemonBanner, LemonButton, LemonTable } from '@posthog/lemon-ui'
+import { getContrastingTextClass } from '~/queries/nodes/DataVisualization/colorUtils'
import { BIConfig } from '~/queries/schema/schema-business-intelligence'
import { ChartSettings } from '~/queries/schema/schema-general'
@@ -21,8 +22,12 @@ export function BIPivotTable({
chartSettings,
onInspect,
embedded,
+ cellBackground,
+ formattingLoadFailed,
}: {
embedded?: boolean
+ cellBackground?: (record: Record<string, unknown>, column: string) => string | undefined
+ formattingLoadFailed?: boolean
config: BIConfig
columns: string[]
results: unknown[][]
@@ -110,7 +115,12 @@ export function BIPivotTable({
return cells
})
return (
- <div className="h-full w-full min-h-0 min-w-0 flex" data-attr="bi-pivot-table">
+ <div className="h-full w-full min-h-0 min-w-0 flex flex-col" data-attr="bi-pivot-table">
+ {formattingLoadFailed && (
+ <LemonBanner type="warning">
+ Couldn't load conditional formatting. Reload the page to try again.
+ </LemonBanner>
+ )}
<LemonTable<BIPivotMember>
className="DataVisualizationTable"
embedded={embedded}
@@ -138,35 +148,59 @@ export function BIPivotTable({
),
},
...visibleColumns.flatMap((column) =>
- measures.map((measure) => ({
- key: `${column.key}:${measure.column}`,
- title: measure.label,
- align: 'right' as const,
- render: (_: unknown, row: BIPivotMember) => {
- const record = model.cells.get(biPivotCellKey(row.path, column.path))
- const showValue =
- !row.children.length || collapsedRows.has(row.key) || config.totals?.subtotals
- const label = formatBIMeasure(
- showValue ? record?.[measure.column] : null,
- measure.settings
- )
- return record && showValue && onInspect ? (
- <LemonButton
- size="xsmall"
- type="tertiary"
- fullWidth
- noPadding
- data-attr="bi-pivot-inspect"
- onClick={() => onInspect(record)}
- tooltip="Explore this result"
- >
- <span className="w-full text-right">{label}</span>
- </LemonButton>
- ) : (
- label
- )
- },
- }))
+ measures.map((measure) => {
+ let cachedRow: BIPivotMember | undefined
+ let background: string | undefined
+ const getBackground = (row: BIPivotMember): string | undefined => {
+ if (cachedRow !== row) {
+ const record = model.cells.get(biPivotCellKey(row.path, column.path))
+ const showValue =
+ !row.children.length || collapsedRows.has(row.key) || config.totals?.subtotals
+ background =
+ record && showValue ? cellBackground?.(record, measure.column) : undefined
+ cachedRow = row
+ }
+ return background
+ }
+ return {
+ key: `${column.key}:${measure.column}`,
+ title: measure.label,
+ align: 'right' as const,
+ style: (_: unknown, row: BIPivotMember) => ({ backgroundColor: getBackground(row) }),
+ className: (_: unknown, row: BIPivotMember) => {
+ const color = getBackground(row)
+ return color ? getContrastingTextClass(color) : ''
+ },
+ render: (_: unknown, row: BIPivotMember) => {
+ const record = model.cells.get(biPivotCellKey(row.path, column.path))
+ const showValue =
+ !row.children.length || collapsedRows.has(row.key) || config.totals?.subtotals
+ const label = formatBIMeasure(
+ showValue ? record?.[measure.column] : null,
+ measure.settings
+ )
+ return record && showValue && onInspect ? (
+ <LemonButton
+ size="xsmall"
+ type="tertiary"
+ fullWidth
+ noPadding
+ data-attr="bi-pivot-inspect"
+ onClick={() => onInspect(record)}
+ tooltip="Explore this result"
+ >
+ <span
+ className={`w-full text-right ${getBackground(row) ? getContrastingTextClass(getBackground(row)!) : ''}`}
+ >
+ {label}
+ </span>
+ </LemonButton>
+ ) : (
+ label
+ )
+ },
+ }
+ })
),
]}
/>