Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(error-tracking): reject oversized symbol set uploads before reading (#128193)

James Gilla7d61b219aa4
diff --git a/products/error_tracking/backend/facade/symbol_sets.py b/products/error_tracking/backend/facade/symbol_sets.py
index 12b5f5d99ae7..10e322f03738 100644
--- a/products/error_tracking/backend/facade/symbol_sets.py
+++ b/products/error_tracking/backend/facade/symbol_sets.py
@@ -78,6 +78,10 @@ def get_download(team_id: int, symbol_set_id: str) -> contracts.ErrorTrackingSym
return contracts.ErrorTrackingSymbolSetDownload(has_file=has_file, url=url)
+def check_upload_size(size: int) -> None:
+ _logic.check_upload_size(size)
+
+
def create_deprecated_symbol_set(team: Any, chunk_id: str, release_id: str | None, data: bytearray) -> None:
_logic.create_deprecated_symbol_set(team, chunk_id, release_id, data)
diff --git a/products/error_tracking/backend/logic/symbol_sets.py b/products/error_tracking/backend/logic/symbol_sets.py
index 5d59b4164b40..bdf60b47da97 100644
--- a/products/error_tracking/backend/logic/symbol_sets.py
+++ b/products/error_tracking/backend/logic/symbol_sets.py
@@ -129,19 +129,22 @@ def generate_symbol_set_upload_presigned_urls(file_key: str, content_length: int
return urls
-def upload_content(content: bytearray) -> tuple[str, str]:
- content_hash = hashlib.sha512(content).hexdigest()
+def check_upload_size(size: int) -> None:
+ if size > ONE_HUNDRED_MEGABYTES:
+ raise ValidationError(
+ code="file_too_large", detail="Combined source map and symbol set must be less than 100MB"
+ )
+
+def upload_content(content: bytearray) -> tuple[str, str]:
if not settings.OBJECT_STORAGE_ENABLED:
raise ValidationError(
code="object_storage_required",
detail="Object storage must be available to allow source map uploads.",
)
- if len(content) > ONE_HUNDRED_MEGABYTES:
- raise ValidationError(
- code="file_too_large", detail="Combined source map and symbol set must be less than 100MB"
- )
+ check_upload_size(len(content))
+ content_hash = hashlib.sha512(content).hexdigest()
upload_path = generate_symbol_set_file_key()
object_storage.write(upload_path, bytes(content))
diff --git a/products/error_tracking/backend/presentation/views/symbol_sets.py b/products/error_tracking/backend/presentation/views/symbol_sets.py
index e8a3bc2fa49e..0657c0bfbdc0 100644
--- a/products/error_tracking/backend/presentation/views/symbol_sets.py
+++ b/products/error_tracking/backend/presentation/views/symbol_sets.py
@@ -19,6 +19,7 @@ from products.error_tracking.backend.facade import (
)
BULK_CHECK_UPLOAD_MAX_SYMBOL_SETS = 1000
+MULTIPART_OVERHEAD_BYTES = 1024 * 1024
class ErrorTrackingSymbolSetSerializer(DataclassSerializer):
@@ -227,6 +228,17 @@ class ErrorTrackingSymbolSetViewSet(TeamAndOrgViewSetMixin, viewsets.GenericView
"create",
]
+ def initial(self, request: Request, *args, **kwargs) -> None:
+ # Authentication and permission checks read the request body, which makes DRF parse a raw upload, so check
+ # the declared length before them. Middleware has already parsed a multipart body by this point.
+ if self.action == "create":
+ try:
+ declared_size = int(request.META.get("CONTENT_LENGTH") or 0)
+ except ValueError:
+ declared_size = 0
+ symbol_sets_facade.check_upload_size(declared_size - MULTIPART_OVERHEAD_BYTES)
+ super().initial(request, *args, **kwargs)
+
@extend_schema(parameters=[ErrorTrackingSymbolSetListQuerySerializer])
def list(self, request: Request, *args, **kwargs) -> Response:
query = ErrorTrackingSymbolSetListQuerySerializer(data=request.query_params)
@@ -303,7 +315,6 @@ class ErrorTrackingSymbolSetViewSet(TeamAndOrgViewSetMixin, viewsets.GenericView
@extend_schema(exclude=True) # deprecated; serializer has no settable fields, hidden from typed clients
def create(self, request: Request, *args, **kwargs) -> Response:
chunk_id = request.query_params.get("chunk_id", None)
- multipart = request.query_params.get("multipart", False)
release_id = request.query_params.get("release_id", None)
posthoganalytics.capture(
@@ -315,16 +326,19 @@ class ErrorTrackingSymbolSetViewSet(TeamAndOrgViewSetMixin, viewsets.GenericView
if not chunk_id:
return Response({"detail": "chunk_id query parameter is required"}, status=status.HTTP_400_BAD_REQUEST)
- if multipart:
- data = bytearray()
- for chunk in request.FILES["file"].chunks():
- data.extend(chunk)
- else:
- # legacy: older versions of the CLI did not use multipart uploads
- # file added to the request data by the FileUploadParser
- data = request.data["file"].read()
+ # MultiPartParser and the legacy FileUploadParser both put the upload in request.FILES.
+ upload = request.FILES.get("file")
+ if upload is None:
+ return Response({"detail": "file is required"}, status=status.HTTP_400_BAD_REQUEST)
+
+ # The upload handler has already counted the bytes, so check the size before reading them into memory.
+ symbol_sets_facade.check_upload_size(upload.size or 0)
+
+ data = bytearray()
+ for chunk in upload.chunks():
+ data.extend(chunk)
- symbol_sets_facade.create_deprecated_symbol_set(self.team, chunk_id, release_id, bytearray(data))
+ symbol_sets_facade.create_deprecated_symbol_set(self.team, chunk_id, release_id, data)
return Response({"ok": True}, status=status.HTTP_201_CREATED)
diff --git a/products/error_tracking/backend/tests/api/test_error_tracking_api.py b/products/error_tracking/backend/tests/api/test_error_tracking_api.py
index 9f5cadf0664e..13dd20f6c826 100644
--- a/products/error_tracking/backend/tests/api/test_error_tracking_api.py
+++ b/products/error_tracking/backend/tests/api/test_error_tracking_api.py
@@ -1,5 +1,6 @@
import os
import json
+import hashlib
from collections.abc import Callable
from datetime import UTC, datetime, timedelta
from typing import Any
@@ -9,6 +10,8 @@ import time_machine
from posthog.test.base import APIBaseTest
from unittest.mock import ANY, Mock, patch
+from django.core.files.uploadedfile import SimpleUploadedFile, UploadedFile
+from django.core.files.uploadhandler import MemoryFileUploadHandler
from django.db import OperationalError, connection
from django.test import SimpleTestCase
from django.test.utils import CaptureQueriesContext
@@ -19,6 +22,7 @@ from boto3 import resource
from botocore.config import Config
from parameterized import parameterized
from rest_framework import status
+from rest_framework.parsers import FileUploadParser
from posthog.models import Team, User
from posthog.models.activity_logging.activity_log import ActivityLog
@@ -58,6 +62,14 @@ from products.error_tracking.backend.presentation.views.symbol_sets import (
TEST_BUCKET = "test_storage_bucket-TestErrorTracking"
+class OversizedReportingUploadHandler(MemoryFileUploadHandler):
+ def file_complete(self, file_size: int) -> UploadedFile | None:
+ uploaded = super().file_complete(file_size)
+ if uploaded is not None:
+ uploaded.size = symbol_sets_logic.ONE_HUNDRED_MEGABYTES + 1
+ return uploaded
+
+
def get_path_to(fixture_file: str) -> str:
file_dir = os.path.dirname(__file__)
return os.path.join(file_dir, "fixtures", fixture_file)
@@ -1244,6 +1256,58 @@ class TestErrorTracking(APIBaseTest):
assert response.status_code == status.HTTP_400_BAD_REQUEST
assert response.json()["code"] == "file_too_large"
+ def _post_deprecated_upload(self, body: str, content: bytes, **extra: Any) -> Any:
+ url = f"/api/environments/{self.team.id}/error_tracking/symbol_sets?chunk_id={uuid7()}"
+ if body == "multipart":
+ return self.client.post(
+ f"{url}&multipart=true", data={"file": SimpleUploadedFile("a.map", content)}, format="multipart"
+ )
+ return self.client.post(
+ url,
+ data=content,
+ content_type="application/octet-stream",
+ HTTP_CONTENT_DISPOSITION="attachment; filename=a.map",
+ **extra,
+ )
+
+ @parameterized.expand([("multipart",), ("raw",)])
+ def test_deprecated_create_rejects_oversized_file(self, body: str) -> None:
+ with self.settings(FILE_UPLOAD_HANDLERS=[f"{__name__}.{OversizedReportingUploadHandler.__name__}"]):
+ response = self._post_deprecated_upload(body, b"{}")
+
+ assert response.status_code == status.HTTP_400_BAD_REQUEST, response.json()
+ assert response.json()["code"] == "file_too_large"
+ assert not ErrorTrackingSymbolSet.objects.filter(team=self.team).exists()
+
+ def test_deprecated_create_rejects_oversized_declared_length_without_parsing(self) -> None:
+ with patch.object(FileUploadParser, "parse") as parse:
+ response = self._post_deprecated_upload(
+ "raw", b"{}", CONTENT_LENGTH=str(symbol_sets_logic.ONE_HUNDRED_MEGABYTES * 2)
+ )
+
+ assert response.status_code == status.HTTP_400_BAD_REQUEST, response.json()
+ assert response.json()["code"] == "file_too_large"
+ parse.assert_not_called()
+
+ def test_deprecated_create_requires_file(self) -> None:
+ url = f"/api/environments/{self.team.id}/error_tracking/symbol_sets?chunk_id={uuid7()}&multipart=true"
+ response = self.client.post(url, data={}, format="multipart")
+
+ assert response.status_code == status.HTTP_400_BAD_REQUEST, response.json()
+ assert response.json()["detail"] == "file is required"
+
+ @parameterized.expand([("multipart",), ("raw",)])
+ @patch("posthog.storage.object_storage._client")
+ def test_deprecated_create_stores_valid_upload(self, body: str, patched_s3_client: Mock) -> None:
+ content = b'{"version":3,"sources":["a.js"]}'
+ with self.settings(OBJECT_STORAGE_ENABLED=True):
+ response = self._post_deprecated_upload(body, content)
+
+ assert response.status_code == status.HTTP_201_CREATED, response.json()
+ symbol_set = ErrorTrackingSymbolSet.objects.get(team=self.team)
+ assert symbol_set.content_hash == hashlib.sha512(content).hexdigest()
+ assert patched_s3_client.write.call_args.kwargs["content"] == content
+
@patch("posthog.storage.object_storage._client")
def test_finish_upload_updates_the_content_hash(self, patched_s3_client):
patched_s3_client.head_object.return_value = {"ContentLength": 1048576} # 1MB