Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(replay-vision): delete feed history and anchor similarities with a recording (#124024)

Tue Haulunda9da3af0735b
diff --git a/nodejs/src/session-replay/recording-api/recording-cleanup.integration.test.ts b/nodejs/src/session-replay/recording-api/recording-cleanup.integration.test.ts
index a995c31b6d2f..0ac1900953de 100644
--- a/nodejs/src/session-replay/recording-api/recording-cleanup.integration.test.ts
+++ b/nodejs/src/session-replay/recording-api/recording-cleanup.integration.test.ts
@@ -132,6 +132,30 @@ describe('recording cleanup (integration)', () => {
[randomUUID(), targetObservationId, thumbnail.rows[0].id, teamId],
'fixtureMedia'
)
+ await postgres.query(
+ PostgresUse.COMMON_WRITE,
+ `INSERT INTO replay_vision_replayobservationanchorsimilarity
+ (observation_id, team_id, anchor_version, similarities)
+ VALUES ($1, $2, 1, '{}'::jsonb)`,
+ [targetObservationId, teamId],
+ 'fixtureAnchorSimilarity'
+ )
+ await postgres.query(
+ PostgresUse.COMMON_WRITE,
+ `INSERT INTO replay_vision_replayobservationfeeddismissal
+ (id, observation_id, team_id, user_id, created_at)
+ VALUES ($1, $2, $3, $4, now())`,
+ [randomUUID(), targetObservationId, teamId, userId],
+ 'fixtureDismissal'
+ )
+ await postgres.query(
+ PostgresUse.COMMON_WRITE,
+ `INSERT INTO replay_vision_replayobservationfeedimpression
+ (id, observation_id, team_id, user_id, shown_count, last_shown_at)
+ VALUES ($1, $2, $3, $4, 1, now())`,
+ [randomUUID(), targetObservationId, teamId, userId],
+ 'fixtureImpression'
+ )
// Of the deleted recording: a system render, a person's own gif export, and an event screenshot frame.
// Of a kept recording: one export, which must stay.
for (const [format, isSystem, sessionId] of [
@@ -166,26 +190,19 @@ describe('recording cleanup (integration)', () => {
expect(
await count(`SELECT count(*) FROM replay_vision_replayobservation WHERE id = $1`, [targetObservationId])
).toBe(0)
- expect(
- await count(`SELECT count(*) FROM replay_vision_replayobservationlabel WHERE observation_id = $1`, [
- targetObservationId,
- ])
- ).toBe(0)
- expect(
- await count(`SELECT count(*) FROM replay_vision_replayobservationview WHERE observation_id = $1`, [
- targetObservationId,
- ])
- ).toBe(0)
- expect(
- await count(`SELECT count(*) FROM replay_vision_visionalertmatch WHERE observation_id = $1`, [
- targetObservationId,
- ])
- ).toBe(0)
- expect(
- await count(`SELECT count(*) FROM replay_vision_replayobservationmedia WHERE observation_id = $1`, [
- targetObservationId,
- ])
- ).toBe(0)
+ for (const table of [
+ 'replay_vision_replayobservationlabel',
+ 'replay_vision_replayobservationview',
+ 'replay_vision_visionalertmatch',
+ 'replay_vision_replayobservationmedia',
+ 'replay_vision_replayobservationfeeddismissal',
+ 'replay_vision_replayobservationfeedimpression',
+ 'replay_vision_replayobservationanchorsimilarity',
+ ]) {
+ expect(await count(`SELECT count(*) FROM ${table} WHERE observation_id = $1`, [targetObservationId])).toBe(
+ 0
+ )
+ }
// An observation of a different recording is untouched.
expect(
diff --git a/nodejs/src/session-replay/recording-api/recording-service.ts b/nodejs/src/session-replay/recording-api/recording-service.ts
index e8970e118490..463d9fe598fa 100644
--- a/nodejs/src/session-replay/recording-api/recording-service.ts
+++ b/nodejs/src/session-replay/recording-api/recording-service.ts
@@ -539,6 +539,15 @@ export class RecordingService {
), deleted_media AS (
DELETE FROM replay_vision_replayobservationmedia
WHERE observation_id IN (SELECT id FROM observations)
+ ), deleted_dismissals AS (
+ DELETE FROM replay_vision_replayobservationfeeddismissal
+ WHERE observation_id IN (SELECT id FROM observations)
+ ), deleted_impressions AS (
+ DELETE FROM replay_vision_replayobservationfeedimpression
+ WHERE observation_id IN (SELECT id FROM observations)
+ ), deleted_similarities AS (
+ DELETE FROM replay_vision_replayobservationanchorsimilarity
+ WHERE observation_id IN (SELECT id FROM observations)
)
DELETE FROM replay_vision_replayobservation
WHERE id IN (SELECT id FROM observations)`,