:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
chore(devex): move review_hog and engineering_analytics onto the signals facade (#125844)
Julian Bezaa0dd9556872
diff --git a/products/engineering_analytics/backend/logic/ci_signals_config.py b/products/engineering_analytics/backend/logic/ci_signals_config.pyindex 6a5719d4210a..3dc5850356ec 100644--- a/products/engineering_analytics/backend/logic/ci_signals_config.py+++ b/products/engineering_analytics/backend/logic/ci_signals_config.py@@ -19,7 +19,7 @@ from products.engineering_analytics.backend.logic.sources import (list_github_sources,)from products.signals.backend.facade.api import set_signal_source_types_enabled, signal_source_types_state-from products.signals.backend.models import SignalSourceConfig+from products.signals.backend.facade.source_configs import get_source_config, latest_enabled_source_configfrom products.warehouse_sources.backend.facade.models import ExternalDataSchemafrom products.warehouse_sources.backend.facade.sources import github_schema_repo_endpointfrom products.warehouse_sources.backend.facade.types import ExternalDataSchemaStatus@@ -37,12 +37,8 @@ DRY_RUN_CONFIG_KEY = "dry_run"def is_dry_run(*, team: Team) -> bool:- row = (- SignalSourceConfig.objects.filter(team=team, source_product=SOURCE_PRODUCT, source_type=SOURCE_TYPE_FLAKY_CHECK)- .only("config")- .first()- )- if row is None or not isinstance(row.config, dict):+ row = get_source_config(team_id=team.id, source_product=SOURCE_PRODUCT, source_type=SOURCE_TYPE_FLAKY_CHECK)+ if row is None:return Falsereturn bool(row.config.get(DRY_RUN_CONFIG_KEY, False))@@ -111,19 +107,12 @@ def list_authorized_ci_signal_sources(*, team: Team) -> list[AuthorizedCISignalS"""The sources the coordinator may scan: the enabled snapshot re-filtered through the enablinguser's *current* access. Every edge fails closed (deleted/revoked source, missing snapshot,deactivated authorizer) and never widens to all of the team's sources."""- row = (- SignalSourceConfig.objects.filter(- team_id=team.id,- source_product=SOURCE_PRODUCT,- source_type__in=CI_SIGNAL_SOURCE_TYPES,- enabled=True,- )- .order_by("-updated_at")- .first()+ row = latest_enabled_source_config(+ team_id=team.id, source_product=SOURCE_PRODUCT, source_types=CI_SIGNAL_SOURCE_TYPES)if row is None or row.created_by_id is None:return []- snapshot = row.config.get(AUTHORIZED_SOURCES_CONFIG_KEY) if isinstance(row.config, dict) else None+ snapshot = row.config.get(AUTHORIZED_SOURCES_CONFIG_KEY)if not isinstance(snapshot, list) or not snapshot:return []user = resolve_authorizer(team=team, user_id=row.created_by_id)diff --git a/products/engineering_analytics/backend/logic/signals/contracts.py b/products/engineering_analytics/backend/logic/signals/contracts.pyindex 40d21b6e2afc..08986f8f7946 100644--- a/products/engineering_analytics/backend/logic/signals/contracts.py+++ b/products/engineering_analytics/backend/logic/signals/contracts.py@@ -3,8 +3,7 @@ is the ``SignalInput`` variant in ``products/signals/backend/contracts.py``."""from dataclasses import dataclass, field-from products.signals.backend.contracts import SignalRemediation-from products.signals.backend.enums import SignalSourceProduct, SignalSourceType+from products.signals.backend.facade.taxonomy import SignalRemediation, SignalSourceProduct, SignalSourceType# Taken straight from the signals taxonomy so the pair can't drift from emit-time validation.SOURCE_PRODUCT = SignalSourceProduct.ENGINEERING_ANALYTICS.valuediff --git a/products/engineering_analytics/backend/logic/signals/coordinator.py b/products/engineering_analytics/backend/logic/signals/coordinator.pyindex ab112d6768e4..08767d5f83e6 100644--- a/products/engineering_analytics/backend/logic/signals/coordinator.py+++ b/products/engineering_analytics/backend/logic/signals/coordinator.py@@ -12,8 +12,6 @@ from dataclasses import dataclassfrom datetime import timedeltafrom typing import TYPE_CHECKING, Any-from django.utils import timezone-import structlogimport posthoganalyticsfrom temporalio import activity, workflow@@ -37,7 +35,7 @@ from products.signals.backend.facade.api import (is_signal_source_enabled,team_ids_with_source_product_enabled,)-from products.signals.backend.models import SignalEmissionRecord+from products.signals.backend.facade.emission_ledger import EmissionKey, emitted_keys, record_emissionif TYPE_CHECKING:from posthog.models.user import User@@ -105,14 +103,16 @@ def _unemitted(team: Team, findings: list[CISignalFinding]) -> list[CISignalFindthis is what stops it re-emitting them."""if not findings:return []- emitted_keys = set(- SignalEmissionRecord.objects.filter(- team=team,- source_product=SOURCE_PRODUCT,- source_id__in=[finding.source_id for finding in findings],- ).values_list("source_type", "source_id")+ already_emitted = emitted_keys(+ team_id=team.id,+ source_product=SOURCE_PRODUCT,+ source_ids=[finding.source_id for finding in findings],)- return [finding for finding in findings if (finding.source_type, finding.source_id) not in emitted_keys]+ return [+ finding+ for finding in findings+ if EmissionKey(source_type=finding.source_type, source_id=finding.source_id) not in already_emitted+ ]def _record_emitted(team: Team, finding: CISignalFinding) -> None:@@ -120,17 +120,11 @@ def _record_emitted(team: Team, finding: CISignalFinding) -> None:so a finding whose emit raised is retried next sweep instead of being suppressed for the rest ofits dedupe window. The org AI-approval gate, which emit_signal enforces by silently returning,is checked up front in the activity so an unapproved sweep never reaches here."""- SignalEmissionRecord.objects.bulk_create(- [- SignalEmissionRecord(- team=team,- source_product=SOURCE_PRODUCT,- source_type=finding.source_type,- source_id=finding.source_id,- emitted_at=timezone.now(),- )- ],- ignore_conflicts=True,+ record_emission(+ team_id=team.id,+ source_product=SOURCE_PRODUCT,+ source_type=finding.source_type,+ source_id=finding.source_id,)diff --git a/products/engineering_analytics/backend/logic/signals/detectors.py b/products/engineering_analytics/backend/logic/signals/detectors.pyindex 1fbd5b43c632..ef6e8fd63c40 100644--- a/products/engineering_analytics/backend/logic/signals/detectors.py+++ b/products/engineering_analytics/backend/logic/signals/detectors.py@@ -28,13 +28,12 @@ from products.engineering_analytics.backend.logic.signals.contracts import (SOURCE_TYPE_FLAKY_CHECK,CISignalFinding,)-from products.signals.backend.contracts import (+from products.signals.backend.facade.signal_extras import (EngineeringAnalyticsCIBrokenDefaultBranchSignalExtra,EngineeringAnalyticsCIDurationRegressionSignalExtra,EngineeringAnalyticsCIFlakyCheckSignalExtra,- SignalRemediation,)-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.taxonomy import ReportPriority, SignalRemediationlogger = structlog.get_logger(__name__)diff --git a/products/engineering_analytics/backend/tests/test_ci_signals.py b/products/engineering_analytics/backend/tests/test_ci_signals.pyindex 478d8b7472d5..29674be2b585 100644--- a/products/engineering_analytics/backend/tests/test_ci_signals.py+++ b/products/engineering_analytics/backend/tests/test_ci_signals.py@@ -61,9 +61,9 @@ from products.engineering_analytics.backend.tests._github_fixtures import (create_warehouse_table_row,seeding_object_storage,)-from products.signals.backend.contracts import SIGNAL_VARIANT_LOOKUP, SignalRemediation-from products.signals.backend.enums import ReportPriority+from products.signals.backend.contracts import SIGNAL_VARIANT_LOOKUPfrom products.signals.backend.facade.api import set_signal_source_types_enabled, validate_signal_input+from products.signals.backend.facade.taxonomy import ReportPriority, SignalRemediationfrom products.signals.backend.models import SignalEmissionRecord, SignalSourceConfigfrom products.warehouse_sources.backend.facade.models import (DataWarehouseCredential,diff --git a/products/review_hog/backend/automatic_reviews.py b/products/review_hog/backend/automatic_reviews.pyindex aba160d5e526..231c3b76e8aa 100644--- a/products/review_hog/backend/automatic_reviews.py+++ b/products/review_hog/backend/automatic_reviews.py@@ -66,9 +66,7 @@ def plan_automatic_review() -> AutomaticDispatch:"""Whether a push gets an automatic Flash review, in which project, and as which user."""# These clients pull in the signals product; planning a webhook must not load it at import.- from products.signals.backend.report_generation.resolve_reviewers import ( # noqa: PLC0415- resolve_org_github_login_to_users,- )+ from products.signals.backend.facade.report_reviewers import org_user_ids_by_github_login # noqa: PLC0415if owner is None:return AutomaticDispatch(outcome="repository_not_added")@@ -82,10 +80,14 @@ def plan_automatic_review(repository.full_name,)return AutomaticDispatch(outcome="installation_mismatch", team_id=team_id)- author = resolve_org_github_login_to_users(team_id, [author_login]).get(author_login.strip().lower())+ author_id = org_user_ids_by_github_login(team_id=team_id, github_logins=[author_login]).get(+ author_login.strip().lower()+ )# An inactive user cannot act: every user-scoped sandbox credential of the run would fail. So an# inactive author counts as unmapped, and unmapped authors follow the project's bot rule.- author_user_id = author.id if author is not None and is_active_member(team_id=team_id, user_id=author.id) else None+ author_user_id = (+ author_id if author_id is not None and is_active_member(team_id=team_id, user_id=author_id) else None+ )decision = decide_automatic_review(team_id, repository, owner.row, author_user_id=author_user_id, author_login=author_login)diff --git a/products/review_hog/backend/models.py b/products/review_hog/backend/models.pyindex e1e7a4e13c16..c989c5c8c24d 100644--- a/products/review_hog/backend/models.py+++ b/products/review_hog/backend/models.py@@ -31,7 +31,7 @@ from products.review_hog.backend.reviewer.artefact_content import (ValidationVerdict,artefact_type_for,)-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttributionclass ReviewReport(UUIDModel, TeamScopedRootMixin):diff --git a/products/review_hog/backend/pr_owner.py b/products/review_hog/backend/pr_owner.pyindex e07b2c36ceba..4f0d28ea1daa 100644--- a/products/review_hog/backend/pr_owner.py+++ b/products/review_hog/backend/pr_owner.py@@ -47,18 +47,16 @@ class PullRequestOwnerResolver:@staticmethoddef active_author_id(team_id: int, author_login: str) -> int | None:# Pulls in the signals product, which a webhook must not load at import.- from products.signals.backend.report_generation.resolve_reviewers import ( # noqa: PLC0415- resolve_org_github_login_to_users,- )+ from products.signals.backend.facade.report_reviewers import org_user_ids_by_github_login # noqa: PLC0415login = author_login.strip().lower()if not login:return None- user = resolve_org_github_login_to_users(team_id, [login]).get(login)+ user_id = org_user_ids_by_github_login(team_id=team_id, github_logins=[login]).get(login)# An inactive user cannot act and cannot opt in, so they own nothing.- if user is None or not is_active_member(team_id=team_id, user_id=user.id):+ if user_id is None or not is_active_member(team_id=team_id, user_id=user_id):return None- return user.id+ return user_id@staticmethoddef inbox_reviewer_id(team_id: int, *, repository: str, head_branch: str | None) -> int | None:@@ -70,9 +68,9 @@ class PullRequestOwnerResolver:return None# An inactive reviewer cannot act or opt in, so ownership falls to the next active one.reviewers = [- user- for user in resolve_assigned_reviewers(team_id, run.signal_report_id)- if is_active_member(team_id=team_id, user_id=user.id)+ user_id+ for user_id in resolve_assigned_reviewers(team_id, run.signal_report_id)+ if is_active_member(team_id=team_id, user_id=user_id)]return pick_reviewer(reviewers, run.task_created_by_id) if reviewers else Nonediff --git a/products/review_hog/backend/receivers.py b/products/review_hog/backend/receivers.pyindex e23d286dda1a..0e8a1cdc0c9b 100644--- a/products/review_hog/backend/receivers.py+++ b/products/review_hog/backend/receivers.py@@ -35,7 +35,6 @@ the agent server later overwrites it with the work branch, so its meaning depend"""-import jsonimport loggingfrom typing import Any@@ -43,9 +42,8 @@ from django.db import transactionfrom products.review_hog.backend.models import ReviewUserSettingsfrom products.review_hog.backend.preferences import ReviewPreferences-from products.signals.backend.enums import ReportPriority-from products.signals.backend.models import SignalReportArtefact-from products.signals.backend.report_generation.priority import persisted_report_priority+from products.signals.backend.facade.report_artefacts import persisted_report_priority+from products.signals.backend.facade.taxonomy import ReportPriorityfrom products.stamphog.backend.facade.finished_review_hooks import (FinishedReviewRun,register_finished_review_hook as register_stamphog_finished_review_hook,@@ -159,7 +157,7 @@ def handle_task_run_saved(sender: type, instance: Any, created: bool, **kwargs:resolved = resolve_assigned_reviewers(instance.team_id, task.signal_report_id)if not resolved:return- settings_by_user = ReviewUserSettings.load_preferences_many(instance.team_id, [user.id for user in resolved])+ settings_by_user = ReviewUserSettings.load_preferences_many(instance.team_id, resolved)acting_user_id = pick_reviewer(resolved, task.created_by_id)stamphog_user_id = _pick_stamphog_reviewer(resolved, settings_by_user, task.created_by_id)# robust=True on both: the two dispatches are independent but share one commit-hook queue, so@@ -213,12 +211,12 @@ def resolve_stamphog_acting_reviewer(team_id: int, signal_report_id: str, preferresolved = resolve_assigned_reviewers(team_id, signal_report_id)if not resolved:return None- settings_by_user = ReviewUserSettings.load_preferences_many(team_id, [user.id for user in resolved])+ settings_by_user = ReviewUserSettings.load_preferences_many(team_id, resolved)return _pick_stamphog_reviewer(resolved, settings_by_user, preferred_user_id)def _pick_stamphog_reviewer(- resolved: list[Any], settings_by_user: dict[int, ReviewPreferences], preferred_user_id: int | None+ resolved: list[int], settings_by_user: dict[int, ReviewPreferences], preferred_user_id: int | None) -> int | None:"""The user id to attribute a stamphog inbox review to, or None when nobody is opted in.@@ -229,11 +227,11 @@ def _pick_stamphog_reviewer(on the first review and on later re-reviews. Either way there is one review per head: thisreturns a single id however many are opted in, and stamphog dedupes on (pull request, head sha)."""- opted_in = [user for user in resolved if settings_by_user[user.id].stamphog_review_inbox_prs]+ opted_in = [user_id for user_id in resolved if settings_by_user[user_id].stamphog_review_inbox_prs]return pick_reviewer(opted_in, preferred_user_id) if opted_in else None-def pick_reviewer(resolved: list[Any], task_created_by_id: int | None) -> int:+def pick_reviewer(resolved: list[int], task_created_by_id: int | None) -> int:"""The canonical reviewer out of a non-empty resolved list: the task's own user, else the first.The task's user (`created_by`: the auto-start assignee, or whoever clicked "Create PR") wins when@@ -242,11 +240,13 @@ def pick_reviewer(resolved: list[Any], task_created_by_id: int | None) -> int:decisions, 2026-07-02/03): a background task whose creator carries no assignment meaning, or anon-assigned clicker, follows the primary assignee's rules."""- return next((user.id for user in resolved if user.id == task_created_by_id), resolved[0].id)+ if task_created_by_id is not None and task_created_by_id in resolved:+ return task_created_by_id+ return resolved[0]-def resolve_assigned_reviewers(team_id: int, signal_report_id: Any) -> list[Any]:- """The report's assigned reviewers, in assignment order (no opt-in toggles checked here).+def resolve_assigned_reviewers(team_id: int, signal_report_id: Any) -> list[int]:+ """The user ids of the report's assigned reviewers, in assignment order (no opt-in toggles checked here).Assignment means the report's latest `suggested_reviewers` artefact, the same set the Inbox "Foryou" filter matches and Slack notifications fan out to, with logins resolved to org members the@@ -255,37 +255,18 @@ def resolve_assigned_reviewers(team_id: int, signal_report_id: Any) -> list[Any]urgency threshold drive the review), stamphog under any who opted in (`_pick_stamphog_reviewer`).Empty when the report has no reviewers or none resolve to an org member."""- artefact = (- SignalReportArtefact.objects.filter(- team_id=team_id,- report_id=signal_report_id,- type=SignalReportArtefact.ArtefactType.SUGGESTED_REVIEWERS,- )- .order_by("-created_at")- .first()- )- if artefact is None:- return []- try:- reviewers = json.loads(artefact.content)- except (json.JSONDecodeError, TypeError, ValueError):- return []- if not isinstance(reviewers, list):- return []- logins = [- str(r["github_login"]).strip().lower() for r in reviewers if isinstance(r, dict) and r.get("github_login")- ]- if not logins:- return []-# Function-local: pulls the signals contracts module (pydantic dataclasses), which the# startup-import-budget test forbids at django.setup() — see the module-top comment.- from products.signals.backend.report_generation.resolve_reviewers import ( # noqa: PLC0415- resolve_org_github_login_to_users,+ from products.signals.backend.facade.report_reviewers import ( # noqa: PLC0415+ org_user_ids_by_github_login,+ suggested_reviewer_logins,)- login_to_user = resolve_org_github_login_to_users(team_id, logins)- return [login_to_user[login] for login in logins if login in login_to_user]+ logins = suggested_reviewer_logins(team_id=team_id, report_id=str(signal_report_id))+ if not logins:+ return []+ user_id_by_login = org_user_ids_by_github_login(team_id=team_id, github_logins=logins)+ return [user_id_by_login[login] for login in logins if login in user_id_by_login]def _start_stamphog_review(diff --git a/products/review_hog/backend/reviewer/artefact_content.py b/products/review_hog/backend/reviewer/artefact_content.pyindex 86d006a913ae..9981a0a6f655 100644--- a/products/review_hog/backend/reviewer/artefact_content.py+++ b/products/review_hog/backend/reviewer/artefact_content.py@@ -29,7 +29,7 @@ from products.review_hog.backend.reviewer.models.issues_review import (from products.review_hog.backend.reviewer.models.perspective_selection import PerspectiveSelectionfrom products.review_hog.backend.reviewer.models.split_pr_into_chunks import Chunkfrom products.review_hog.backend.reviewer.review_design import REVIEW_DESIGN_PIPELINE-from products.signals.backend.artefact_schemas import (+from products.signals.backend.facade.report_artefacts import (ArtefactContentValidationError,CodeReference,Commit,diff --git a/products/review_hog/backend/reviewer/constants.py b/products/review_hog/backend/reviewer/constants.pyindex 8e0f0f165b65..f99618121804 100644--- a/products/review_hog/backend/reviewer/constants.py+++ b/products/review_hog/backend/reviewer/constants.py@@ -16,7 +16,7 @@ from products.review_hog.backend.reviewer.review_design import (REVIEW_DESIGN_REASON_KILL_SWITCH,REVIEW_DESIGN_SINGLE_AGENT,)-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.taxonomy import ReportPriorityfrom products.tasks.backend.facade.run_config import (ReasoningEffort,RuntimeAdapter,diff --git a/products/review_hog/backend/reviewer/fingerprint.py b/products/review_hog/backend/reviewer/fingerprint.pyindex ebbef333a928..108b47058beb 100644--- a/products/review_hog/backend/reviewer/fingerprint.py+++ b/products/review_hog/backend/reviewer/fingerprint.py@@ -70,7 +70,7 @@ from products.review_hog.backend.reviewer.tools.issues_review import REVIEW_SYSTfrom products.review_hog.backend.reviewer.tools.select_perspectives import SELECTION_SYSTEM_PROMPTfrom products.review_hog.backend.reviewer.tools.single_agent_review import SINGLE_AGENT_PROMPT_PATHfrom products.review_hog.backend.reviewer.tools.split_pr_into_chunks import CHUNKING_SYSTEM_PROMPT-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttributionfrom products.skills.backend.models.skills import LLMSkill, LLMSkillFile# The prompt directories a review turn renders. `thread_resolution` is left out: the resolutiondiff --git a/products/review_hog/backend/reviewer/outcomes/classify.py b/products/review_hog/backend/reviewer/outcomes/classify.pyindex 3c937c0b2267..a2cfedeb695d 100644--- a/products/review_hog/backend/reviewer/outcomes/classify.py+++ b/products/review_hog/backend/reviewer/outcomes/classify.py@@ -72,7 +72,7 @@ from products.review_hog.backend.reviewer.outcomes.line_proximity import parse_cfrom products.review_hog.backend.reviewer.persistence import load_findings_bundlefrom products.review_hog.backend.reviewer.telemetry import finding_routing_propertiesfrom products.review_hog.backend.reviewer.tools.github_client import GitHubAPIError-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttributionlogger = logging.getLogger(__name__)diff --git a/products/review_hog/backend/reviewer/persistence.py b/products/review_hog/backend/reviewer/persistence.pyindex e0c4a90cac75..741e61f221b9 100644--- a/products/review_hog/backend/reviewer/persistence.py+++ b/products/review_hog/backend/reviewer/persistence.py@@ -71,9 +71,8 @@ from products.review_hog.backend.reviewer.models.issues_review import DroppedIssfrom products.review_hog.backend.reviewer.models.perspective_selection import PerspectiveSelectionfrom products.review_hog.backend.reviewer.models.split_pr_into_chunks import ChunksListfrom products.review_hog.backend.reviewer.review_design import REVIEW_DESIGN_PIPELINE, REVIEW_DESIGN_SINGLE_AGENT-from products.signals.backend.artefact_attribution import ArtefactAttribution-from products.signals.backend.artefact_schemas import Commit-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.report_artefacts import Commit+from products.signals.backend.facade.taxonomy import ArtefactAttribution, ReportPrioritylogger = logging.getLogger(__name__)diff --git a/products/review_hog/backend/reviewer/progress.py b/products/review_hog/backend/reviewer/progress.pyindex fdbc98d21bf4..fe6ca969b388 100644--- a/products/review_hog/backend/reviewer/progress.py+++ b/products/review_hog/backend/reviewer/progress.py@@ -66,7 +66,7 @@ from products.review_hog.backend.reviewer.skill_loader import (CANONICAL_PERSPECTIVE_SKILL_NAMES,REVIEW_HOG_PERSPECTIVE_PREFIX,)-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttributionlogger = logging.getLogger(__name__)diff --git a/products/review_hog/backend/reviewer/tests/test_constants.py b/products/review_hog/backend/reviewer/tests/test_constants.pyindex dc2cc4cac02c..30d772677787 100644--- a/products/review_hog/backend/reviewer/tests/test_constants.py+++ b/products/review_hog/backend/reviewer/tests/test_constants.py@@ -38,7 +38,7 @@ from products.review_hog.backend.reviewer.constants import (validation_arm_for_mode,)from products.review_hog.backend.temporal.types import TRIGGER_AUTOMATIC, TRIGGER_INBOX-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.taxonomy import ReportPriorityfrom products.tasks.backend.facade.run_config import (LLMProvider,ReasoningEffort,diff --git a/products/review_hog/backend/temporal/activities.py b/products/review_hog/backend/temporal/activities.pyindex 41c2bf462cba..977ceebb5edb 100644--- a/products/review_hog/backend/temporal/activities.py+++ b/products/review_hog/backend/temporal/activities.py@@ -239,11 +239,14 @@ from products.review_hog.backend.temporal.types import (TRIGGER_MANUAL,TRIGGER_STAMPHOG,)-from products.signals.backend.artefact_attribution import ArtefactAttribution-from products.signals.backend.artefact_schemas import CodeReview, CodeReviewCounts-from products.signals.backend.enums import ReportPriority-from products.signals.backend.models import SignalReport, SignalReportArtefact-from products.signals.backend.report_generation.resolve_reviewers import resolve_org_github_login_to_users+from products.signals.backend.facade.report_artefacts import (+ CodeReview,+ CodeReviewCounts,+ append_code_review,+ report_exists,+)+from products.signals.backend.facade.report_reviewers import org_user_ids_by_github_login+from products.signals.backend.facade.taxonomy import ArtefactAttribution, ReportPriorityfrom products.stamphog.backend.facade.tasks import request_rereview_after_external_reviewfrom products.tasks.backend.facade.agents import AgentTurnFailedfrom products.tasks.backend.facade.contracts import SessionFile@@ -1003,9 +1006,7 @@ async def fetch_pr_data_activity(input: FetchPRDataInput) -> ReviewMeta:def _login_to_user_id(team_id: int, login: str | None) -> int | None:if not login:return None- matches = resolve_org_github_login_to_users(team_id, [login])- user = matches.get(login.strip().lower())- return user.id if user is not None else None+ return org_user_ids_by_github_login(team_id=team_id, github_logins=[login]).get(login.strip().lower())def _automatic_review_allowed(input: ResolveActingUserInput, acting_user_id: int | None) -> bool:@@ -2950,7 +2951,7 @@ def _append_code_review_artefact(input: AppendCodeReviewArtefactInput) -> None:return# The signals report may be gone by now (deleted/reingested) — the review must not fail over its# own receipt, and the plain-UUID provenance on the ReviewReport row keeps the durable link.- if not SignalReport.objects.filter(team_id=input.team_id, id=input.signal_report_id).exists():+ if not report_exists(team_id=input.team_id, report_id=input.signal_report_id):logger.warning("Signal report %s missing; skipping the code_review artefact", input.signal_report_id)returncounts = CodeReviewCounts()@@ -2972,7 +2973,7 @@ def _append_code_review_artefact(input: AppendCodeReviewArtefactInput) -> None:outcome=input.outcome,counts=counts,)- SignalReportArtefact.add_log(+ append_code_review(team_id=input.team_id,report_id=input.signal_report_id,content=content,diff --git a/products/review_hog/backend/temporal/client.py b/products/review_hog/backend/temporal/client.pyindex 32d89e2f614a..556386b787ef 100644--- a/products/review_hog/backend/temporal/client.py+++ b/products/review_hog/backend/temporal/client.py@@ -53,7 +53,7 @@ from products.review_hog.backend.temporal.types import (review_branch_workflow_id,review_pr_workflow_id,)-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.taxonomy import ReportPrioritylogger = logging.getLogger(__name__)diff --git a/products/review_hog/backend/temporal/resolution.py b/products/review_hog/backend/temporal/resolution.pyindex 086fb04a677a..513b4f9628b7 100644--- a/products/review_hog/backend/temporal/resolution.py+++ b/products/review_hog/backend/temporal/resolution.py@@ -113,8 +113,8 @@ from products.review_hog.backend.temporal.activities import (validate_github_integration_activity,)from products.review_hog.backend.temporal.types import TRIGGER_MANUAL, ResolvePRWorkflowInputs-from products.signals.backend.artefact_attribution import ArtefactAttribution-from products.signals.backend.artefact_schemas import Commit, NoteArtefact, TaskRunArtefact+from products.signals.backend.facade.report_artefacts import Commit, NoteArtefact, TaskRunArtefact+from products.signals.backend.facade.taxonomy import ArtefactAttributionlogger = logging.getLogger(__name__)diff --git a/products/review_hog/backend/tests/test_head_review_status.py b/products/review_hog/backend/tests/test_head_review_status.pyindex d6674a1aefe8..c6677ae554d6 100644--- a/products/review_hog/backend/tests/test_head_review_status.py+++ b/products/review_hog/backend/tests/test_head_review_status.py@@ -27,7 +27,7 @@ from products.review_hog.backend.reviewer.models.split_pr_into_chunks import Chufrom products.review_hog.backend.reviewer.persistence import persist_chunk_set, persist_perspective_resultsfrom products.review_hog.backend.reviewer.progress import record_run_outcomefrom products.review_hog.backend.temporal.client import QueuedReviewHeads-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttributionfrom products.stamphog.backend.facade.review_evidence import ReviewEvidenceState, get_review_evidence_providersREPOSITORY = "PostHog/posthog"diff --git a/products/review_hog/backend/tests/test_inbox_trigger.py b/products/review_hog/backend/tests/test_inbox_trigger.pyindex 907180c5ebf8..fd114ec4c705 100644--- a/products/review_hog/backend/tests/test_inbox_trigger.py+++ b/products/review_hog/backend/tests/test_inbox_trigger.py@@ -16,7 +16,7 @@ from posthog.models.user import Userimport products.review_hog.backend.temporal.client # noqa: F401from products.review_hog.backend.models import ReviewUserSettingsfrom products.review_hog.backend.receivers import resolve_stamphog_acting_reviewer-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.taxonomy import ReportPriorityfrom products.signals.backend.models import SignalReport, SignalReportArtefactfrom products.tasks.backend.models import Task, TaskRundiff --git a/products/review_hog/backend/tests/test_models.py b/products/review_hog/backend/tests/test_models.pyindex d9b0a7fa1b5a..f29db3ec8ccc 100644--- a/products/review_hog/backend/tests/test_models.py+++ b/products/review_hog/backend/tests/test_models.py@@ -14,8 +14,8 @@ from products.review_hog.backend.reviewer.artefact_content import ()from products.review_hog.backend.reviewer.models.issues_review import IssuePriority, IssuesReview, LineRangefrom products.review_hog.backend.reviewer.models.split_pr_into_chunks import Chunk, FileInfo-from products.signals.backend.artefact_attribution import ArtefactAttribution-from products.signals.backend.artefact_schemas import ArtefactContentValidationError, TaskRunArtefact+from products.signals.backend.facade.report_artefacts import ArtefactContentValidationError, TaskRunArtefact+from products.signals.backend.facade.taxonomy import ArtefactAttributiondef _finding(issue_key: str = "r1:f.py:10:logic") -> ReviewIssueFinding:diff --git a/products/review_hog/backend/tests/test_outcome_classify.py b/products/review_hog/backend/tests/test_outcome_classify.pyindex 469dc9b925c9..80a4fb914506 100644--- a/products/review_hog/backend/tests/test_outcome_classify.py+++ b/products/review_hog/backend/tests/test_outcome_classify.py@@ -52,7 +52,7 @@ from products.review_hog.backend.reviewer.outcomes.classify import ()from products.review_hog.backend.reviewer.outcomes.discovery import unclassified_published_reportsfrom products.review_hog.backend.reviewer.outcomes.judge import OutcomeJudgeVerdict-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttribution_CLASSIFY = "products.review_hog.backend.reviewer.outcomes.classify"# Touches the finding's line 10 → a line-proximity candidate the judge then rules on.diff --git a/products/review_hog/backend/tests/test_persistence.py b/products/review_hog/backend/tests/test_persistence.pyindex 0a1a6984bdae..07aba74bbd8c 100644--- a/products/review_hog/backend/tests/test_persistence.py+++ b/products/review_hog/backend/tests/test_persistence.py@@ -67,9 +67,8 @@ from products.review_hog.backend.reviewer.persistence import (from products.review_hog.backend.reviewer.review_design import REVIEW_DESIGN_PIPELINE, REVIEW_DESIGN_SINGLE_AGENTfrom products.review_hog.backend.temporal.activities import SandboxStageInput, _prepare_single_agent_promptfrom products.review_hog.backend.temporal.types import TRIGGER_INBOX, TRIGGER_STAMPHOG, TRIGGER_UI-from products.signals.backend.artefact_attribution import ArtefactAttribution-from products.signals.backend.artefact_schemas import Commit-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.report_artefacts import Commit+from products.signals.backend.facade.taxonomy import ArtefactAttribution, ReportPriorityfrom products.tasks.backend.facade.run_config import ReasoningEffort_ContentT = TypeVar("_ContentT")diff --git a/products/review_hog/backend/tests/test_pr_status_api.py b/products/review_hog/backend/tests/test_pr_status_api.pyindex 1bd01490f99d..91768570805b 100644--- a/products/review_hog/backend/tests/test_pr_status_api.py+++ b/products/review_hog/backend/tests/test_pr_status_api.py@@ -20,8 +20,8 @@ from products.review_hog.backend.reviewer.constants import REVIEW_MODE_FLASH, REfrom products.review_hog.backend.reviewer.models.issues_review import IssuePriority, LineRangefrom products.review_hog.backend.reviewer.progress import RESOLUTION_RUN_NOTE_AUTHOR, record_run_outcomefrom products.review_hog.backend.temporal.client import WorkflowProbe-from products.signals.backend.artefact_attribution import ArtefactAttribution-from products.signals.backend.artefact_schemas import NoteArtefact+from products.signals.backend.facade.report_artefacts import NoteArtefact+from products.signals.backend.facade.taxonomy import ArtefactAttributionPR_URL = "https://github.com/PostHog/posthog/pull/5"REQUESTED_AT = datetime(2026, 7, 1, 12, 0, tzinfo=UTC)diff --git a/products/review_hog/backend/tests/test_publish_review_command.py b/products/review_hog/backend/tests/test_publish_review_command.pyindex 701bd35b9f62..f67843aaea1c 100644--- a/products/review_hog/backend/tests/test_publish_review_command.py+++ b/products/review_hog/backend/tests/test_publish_review_command.py@@ -20,7 +20,7 @@ from products.review_hog.backend.reviewer.models.github_meta import PRMetadatafrom products.review_hog.backend.reviewer.models.issues_review import IssuePriorityfrom products.review_hog.backend.reviewer.persistence import upsert_review_reportfrom products.review_hog.backend.reviewer.tools.publish_review import PublishOutcome-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttribution_PUBLISH = "products.review_hog.backend.management.commands.publish_review.publish_persisted_review"_INTEGRATION = (diff --git a/products/review_hog/backend/tests/test_reset_command.py b/products/review_hog/backend/tests/test_reset_command.pyindex d1ed04afb5cc..7f4698b21290 100644--- a/products/review_hog/backend/tests/test_reset_command.py+++ b/products/review_hog/backend/tests/test_reset_command.py@@ -8,7 +8,7 @@ from django.test import override_settingsfrom products.review_hog.backend.models import ReviewReport, ReviewReportArtefact, ReviewSkillConfig, ReviewUserSettingsfrom products.review_hog.backend.reviewer.artefact_content import ReviewIssueFindingfrom products.review_hog.backend.reviewer.models.issues_review import IssuePriority, LineRange-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttributionclass TestResetReviewHog(BaseTest):diff --git a/products/review_hog/backend/tests/test_resolution_activity.py b/products/review_hog/backend/tests/test_resolution_activity.pyindex c52586d20513..304c89cf7e73 100644--- a/products/review_hog/backend/tests/test_resolution_activity.py+++ b/products/review_hog/backend/tests/test_resolution_activity.py@@ -42,7 +42,7 @@ from products.review_hog.backend.temporal.resolution import (_verification_section,resolve_threads_activity,)-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttributionfrom products.skills.backend.models.skills import LLMSkillfrom products.tasks.backend.models import Taskdiff --git a/products/review_hog/backend/tests/test_review_completed_tracking.py b/products/review_hog/backend/tests/test_review_completed_tracking.pyindex 429850472425..6b579efbb3e2 100644--- a/products/review_hog/backend/tests/test_review_completed_tracking.py+++ b/products/review_hog/backend/tests/test_review_completed_tracking.py@@ -53,7 +53,7 @@ from products.review_hog.backend.temporal.activities import (_track_review_started,)from products.review_hog.backend.temporal.types import TRIGGER_INBOX, TRIGGER_STAMPHOG-from products.signals.backend.enums import ReportPriority+from products.signals.backend.facade.taxonomy import ReportPriority_PR_URL = "https://github.com/o/r/pull/7"diff --git a/products/review_hog/backend/tests/test_reviews_api.py b/products/review_hog/backend/tests/test_reviews_api.pyindex 49e4a327d02e..99cee3b7acdf 100644--- a/products/review_hog/backend/tests/test_reviews_api.py+++ b/products/review_hog/backend/tests/test_reviews_api.py@@ -58,8 +58,8 @@ from products.review_hog.backend.reviewer.progress import ()from products.review_hog.backend.reviewer.review_design import REVIEW_DESIGN_PIPELINE, REVIEW_DESIGN_SINGLE_AGENTfrom products.review_hog.backend.temporal.heartbeat import ReviewActivityHeartbeater-from products.signals.backend.artefact_attribution import ArtefactAttribution-from products.signals.backend.artefact_schemas import NoteArtefact+from products.signals.backend.facade.report_artefacts import NoteArtefact+from products.signals.backend.facade.taxonomy import ArtefactAttributiondef _pr_metadata(head_sha: str, title: str) -> PRMetadata:diff --git a/products/review_hog/backend/tests/test_status_comment.py b/products/review_hog/backend/tests/test_status_comment.pyindex 33ee088c305d..908d7ed7fd27 100644--- a/products/review_hog/backend/tests/test_status_comment.py+++ b/products/review_hog/backend/tests/test_status_comment.py@@ -54,7 +54,7 @@ from products.review_hog.backend.reviewer.status_comment import (from products.review_hog.backend.reviewer.tools.github_client import GitHubAPIErrorfrom products.review_hog.backend.reviewer.tools.issue_deduplicator import AlreadyRaisedfrom products.review_hog.backend.temporal.activities import _fail_run-from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.facade.taxonomy import ArtefactAttribution_MODULE = "products.review_hog.backend.reviewer.status_comment"_REQUEST = f"{_MODULE}.github_api_request"diff --git a/products/signals/backend/facade/emission_ledger.py b/products/signals/backend/facade/emission_ledger.pynew file mode 100644index 000000000000..8fdad2cc4c51--- /dev/null+++ b/products/signals/backend/facade/emission_ledger.py@@ -0,0 +1,41 @@+"""The emission ledger that a product's own scheduled emitter uses to skip source records it already emitted."""++from collections.abc import Sequence++from django.utils import timezone++from posthog.dataclasses import frozen++from products.signals.backend.models import SignalEmissionRecord+++@frozen+class EmissionKey:+ source_type: str+ source_id: str+++def emitted_keys(*, team_id: int, source_product: str, source_ids: Sequence[str]) -> set[EmissionKey]:+ """The ledger keys already recorded for `source_ids`, across every source type of `source_product`."""+ rows = SignalEmissionRecord.objects.filter(+ team_id=team_id,+ source_product=source_product,+ source_id__in=source_ids,+ ).values_list("source_type", "source_id")+ return {EmissionKey(source_type=source_type, source_id=source_id) for source_type, source_id in rows}+++def record_emission(*, team_id: int, source_product: str, source_type: str, source_id: str) -> None:+ """Record one emitted source record. A record that is already in the ledger is left as it is."""+ SignalEmissionRecord.objects.bulk_create(+ [+ SignalEmissionRecord(+ team_id=team_id,+ source_product=source_product,+ source_type=source_type,+ source_id=source_id,+ emitted_at=timezone.now(),+ )+ ],+ ignore_conflicts=True,+ )diff --git a/products/signals/backend/facade/report_artefacts.py b/products/signals/backend/facade/report_artefacts.pynew file mode 100644index 000000000000..86707f466908--- /dev/null+++ b/products/signals/backend/facade/report_artefacts.py@@ -0,0 +1,30 @@+"""Report artefact content types, and the artefact reads and writes other products make on a report."""++from datetime import datetime++from products.signals.backend.artefact_attribution import ArtefactAttribution+from products.signals.backend.artefact_schemas import (+ ArtefactContentValidationError as ArtefactContentValidationError,+ CodeReference as CodeReference,+ CodeReview as CodeReview,+ CodeReviewCounts as CodeReviewCounts,+ Commit as Commit,+ NoteArtefact as NoteArtefact,+ TaskRunArtefact as TaskRunArtefact,+)+from products.signals.backend.enums import ReportPriority+from products.signals.backend.models import SignalReport, SignalReportArtefact+from products.signals.backend.report_generation.priority import persisted_report_priority as _persisted_report_priority+++def report_exists(*, team_id: int, report_id: str) -> bool:+ return SignalReport.objects.filter(team_id=team_id, id=report_id).exists()+++def append_code_review(*, team_id: int, report_id: str, content: CodeReview, attribution: ArtefactAttribution) -> None:+ SignalReportArtefact.add_log(team_id=team_id, report_id=report_id, content=content, attribution=attribution)+++def persisted_report_priority(*, team_id: int, report_id: str, before: datetime) -> ReportPriority | None:+ """The priority from the report's latest `priority_judgment` written before `before`, or None."""+ return _persisted_report_priority(team_id=team_id, report_id=report_id, before=before)diff --git a/products/signals/backend/facade/report_reviewers.py b/products/signals/backend/facade/report_reviewers.pynew file mode 100644index 000000000000..29b5d5022dbb--- /dev/null+++ b/products/signals/backend/facade/report_reviewers.py@@ -0,0 +1,22 @@+"""A report's suggested reviewers and the org members behind GitHub logins, as plain ids."""++from collections.abc import Iterable++from products.signals.backend.report_generation.resolve_reviewers import (+ latest_suggested_reviewer_logins,+ resolve_org_github_login_to_users,+)+++def suggested_reviewer_logins(*, team_id: int, report_id: str) -> list[str]:+ """Normalized GitHub logins from the report's latest `suggested_reviewers` artefact, in assignment order."""+ return latest_suggested_reviewer_logins(team_id, report_id)+++def org_user_ids_by_github_login(*, team_id: int, github_logins: Iterable[str]) -> dict[str, int]:+ """Map each normalized (stripped, lowercase) GitHub login to the id of the org member it belongs to.++ A login that matches no member of the team's organization is absent from the result.+ """+ users = resolve_org_github_login_to_users(team_id, github_logins)+ return {login: user.id for login, user in users.items()}diff --git a/products/signals/backend/facade/signal_extras.py b/products/signals/backend/facade/signal_extras.pynew file mode 100644index 000000000000..62aa5065876e--- /dev/null+++ b/products/signals/backend/facade/signal_extras.py@@ -0,0 +1,7 @@+"""Per-source `extra` payload contracts that an emitting product builds for `emit_signal`."""++from products.signals.backend.contracts import (+ EngineeringAnalyticsCIBrokenDefaultBranchSignalExtra as EngineeringAnalyticsCIBrokenDefaultBranchSignalExtra,+ EngineeringAnalyticsCIDurationRegressionSignalExtra as EngineeringAnalyticsCIDurationRegressionSignalExtra,+ EngineeringAnalyticsCIFlakyCheckSignalExtra as EngineeringAnalyticsCIFlakyCheckSignalExtra,+)diff --git a/products/signals/backend/facade/source_configs.py b/products/signals/backend/facade/source_configs.pynew file mode 100644index 000000000000..23a02f915c56--- /dev/null+++ b/products/signals/backend/facade/source_configs.py@@ -0,0 +1,53 @@+"""Reads of a team's per-source signal config rows, for products that own a signal source."""++from collections.abc import Sequence++from posthog.dataclasses import frozen++from products.signals.backend.models import SignalSourceConfig+++@frozen+class SignalSourceConfigSnapshot:+ enabled: bool+ created_by_id: int | None+ # The row's JSON config. A stored value that is not a JSON object reads as empty.+ config: dict[str, object]+++def _to_snapshot(row: SignalSourceConfig) -> SignalSourceConfigSnapshot:+ return SignalSourceConfigSnapshot(+ enabled=row.enabled,+ created_by_id=row.created_by_id,+ config=row.config if isinstance(row.config, dict) else {},+ )+++def get_source_config(*, team_id: int, source_product: str, source_type: str) -> SignalSourceConfigSnapshot | None:+ row = (+ SignalSourceConfig.objects.filter(team_id=team_id, source_product=source_product, source_type=source_type)+ .only("enabled", "created_by_id", "config")+ .first()+ )+ if row is None:+ return None+ return _to_snapshot(row)+++def latest_enabled_source_config(+ *, team_id: int, source_product: str, source_types: Sequence[str]+) -> SignalSourceConfigSnapshot | None:+ """The most recently updated enabled row among `source_types`, or None when none is enabled."""+ row = (+ SignalSourceConfig.objects.filter(+ team_id=team_id,+ source_product=source_product,+ source_type__in=source_types,+ enabled=True,+ )+ .order_by("-updated_at")+ .first()+ )+ if row is None:+ return None+ return _to_snapshot(row)diff --git a/products/signals/backend/report_generation/resolve_reviewers.py b/products/signals/backend/report_generation/resolve_reviewers.pyindex a11d59722425..1922249cd005 100644--- a/products/signals/backend/report_generation/resolve_reviewers.py+++ b/products/signals/backend/report_generation/resolve_reviewers.py@@ -368,6 +368,31 @@ def source_skills_from_suggested_reviewer_artefacts(artefacts: Iterable[SignalRereturn frozenset(skills)+def latest_suggested_reviewer_logins(team_id: int, report_id: str) -> list[str]:+ """Normalized GitHub logins from the report's latest `suggested_reviewers` artefact, in assignment order.++ Empty when the report has no such artefact or its content does not parse as a list.+ """+ artefact = (+ SignalReportArtefact.objects.filter(+ team_id=team_id,+ report_id=report_id,+ type=SignalReportArtefact.ArtefactType.SUGGESTED_REVIEWERS,+ )+ .order_by("-created_at")+ .first()+ )+ if artefact is None:+ return []+ try:+ reviewers = json.loads(artefact.content)+ except (json.JSONDecodeError, TypeError, ValueError):+ return []+ if not isinstance(reviewers, list):+ return []+ return [str(r["github_login"]).strip().lower() for r in reviewers if isinstance(r, dict) and r.get("github_login")]++def normalized_github_logins_from_reviewer_payloads(rows: Iterable[object]) -> frozenset[str]:logins: set[str] = set()for row in rows: