:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(quill): freeze clock in DateTimePicker stories (#117992)
posthog[bot]af7c01ee3e84
diff --git a/packages/quill/apps/storybook/.storybook/preview.tsx b/packages/quill/apps/storybook/.storybook/preview.tsxindex 179fbc7baadf..62f74d131dd5 100644--- a/packages/quill/apps/storybook/.storybook/preview.tsx+++ b/packages/quill/apps/storybook/.storybook/preview.tsx@@ -2,10 +2,12 @@ import './storybook.css'import { DocsContainer } from '@storybook/addon-docs/blocks'import type { Preview } from '@storybook/react'-import { themes } from 'storybook/theming'+import MockDate from 'mockdate'import React, { useEffect, useState } from 'react'import { useDarkMode } from 'storybook-dark-mode'+import { themes } from 'storybook/theming'+// The Docs container renders outside Storybook's preview-hooks context, so// `useDarkMode()` (a preview hook) can't be used here. Track the `<html>.dark`// class the story decorator sets via a MutationObserver instead.@@ -74,6 +76,17 @@ const preview: Preview = {},},decorators: [+ // Freezes the clock for stories that set `parameters.mockDate`, so+ // date-dependent snapshots do not change from day to day.+ (Story, { parameters }) => {+ if (parameters.mockDate) {+ MockDate.set(parameters.mockDate)+ } else {+ MockDate.reset()+ }++ return <Story />+ },// Mirrors the `desktop` toolbar global onto `<body class="is-desktop">`,// matching how the Electron app tags its shell — lets the cursor reset// (and any future desktop-only styling) be previewed live.diff --git a/packages/quill/apps/storybook/package.json b/packages/quill/apps/storybook/package.jsonindex 39bb77341492..311009a4412f 100644--- a/packages/quill/apps/storybook/package.json+++ b/packages/quill/apps/storybook/package.json@@ -16,6 +16,7 @@"@posthog/quill-charts": "workspace:^","@posthog/quill-tokens": "workspace:^","lucide-react": "^0.577.0",+ "mockdate": "^3.0.5","react": "^19.2.0","react-dom": "^19.2.0","tailwindcss": "^4.1.17",diff --git a/packages/quill/packages/components/src/date-time-picker.stories.tsx b/packages/quill/packages/components/src/date-time-picker.stories.tsxindex ddd023055799..72228db6be48 100644--- a/packages/quill/packages/components/src/date-time-picker.stories.tsx+++ b/packages/quill/packages/components/src/date-time-picker.stories.tsx@@ -15,8 +15,8 @@ import * as React from 'react'import { Button, Popover, PopoverContent, PopoverTrigger } from '@posthog/quill-primitives'-import { CUSTOM_RANGE, type DateTimeRange } from './date-time-ranges'import { DateTimePicker, type DateTimeValue } from './date-time-picker'+import { CUSTOM_RANGE, type DateTimeRange } from './date-time-ranges'import { quickRanges } from './date-time-ranges'import { Day } from './use-calendar'@@ -30,30 +30,36 @@ function formatTriggerLabel(value: DateTimeValue): string {return `${startStr} to ${endStr}`}+const MOCK_DATE = '2026-01-15T12:00:00Z'+const meta = {title: 'Components/DateTimePicker',component: DateTimePicker,tags: ['autodocs'],+ parameters: { mockDate: MOCK_DATE },} satisfies Meta<typeof DateTimePicker>export default metatype Story = StoryObj<typeof meta>-const initialValue: DateTimeValue = {- start: subDays(new Date(), 7),- end: new Date(),- range: quickRanges.find((r) => r.name === 'Last 7 days')!,+// Module scope runs before the mockDate decorator, so build values at render time.+function getInitialValue(now: Date = new Date()): DateTimeValue {+ return {+ start: subDays(now, 7),+ end: now,+ range: quickRanges.find((r) => r.name === 'Last 7 days')!,+ }}const baseArgs = {- value: initialValue,+ value: getInitialValue(new Date(MOCK_DATE)),onApply: () => undefined,}export const Default: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return <DateTimePicker value={value} onApply={setValue} />},}@@ -68,7 +74,7 @@ export const THIS_COMPONENT_IS_EXPERIMENTAL: Story = {export const InPopover: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())const [open, setOpen] = React.useState(false)return (<Popover open={open} onOpenChange={setOpen}>@@ -110,7 +116,7 @@ export const CustomMaxDate: Story = {export const CustomMinDate: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return <DateTimePicker value={value} onApply={setValue} minDate={subDays(new Date(), 2)} />},}@@ -118,7 +124,7 @@ export const CustomMinDate: Story = {export const MinDateAndMaxDate: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return (<DateTimePickervalue={value}@@ -133,7 +139,7 @@ export const MinDateAndMaxDate: Story = {export const EuropeanDateFormat: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return <DateTimePicker value={value} onApply={setValue} dateFormat="DMY" />},}@@ -141,7 +147,7 @@ export const EuropeanDateFormat: Story = {export const ISODateFormat: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return <DateTimePicker value={value} onApply={setValue} dateFormat="YMD" />},}@@ -149,7 +155,7 @@ export const ISODateFormat: Story = {export const WithSettingsLink: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return (<DateTimePickervalue={value}@@ -162,9 +168,19 @@ export const WithSettingsLink: Story = {const calendarRanges: DateTimeRange[] = [{ id: 1, name: 'This month', rangeSetter: (d) => startOfMonth(d) },- { id: 2, name: 'Last month', rangeSetter: (d) => startOfMonth(subMonths(d, 1)), endSetter: (d) => endOfMonth(subMonths(d, 1)) },+ {+ id: 2,+ name: 'Last month',+ rangeSetter: (d) => startOfMonth(subMonths(d, 1)),+ endSetter: (d) => endOfMonth(subMonths(d, 1)),+ },{ id: 3, name: 'This quarter', rangeSetter: (d) => startOfQuarter(d) },- { id: 4, name: 'Last quarter', rangeSetter: (d) => startOfQuarter(subQuarters(d, 1)), endSetter: (d) => endOfQuarter(subQuarters(d, 1)) },+ {+ id: 4,+ name: 'Last quarter',+ rangeSetter: (d) => startOfQuarter(subQuarters(d, 1)),+ endSetter: (d) => endOfQuarter(subQuarters(d, 1)),+ },{ id: 5, name: 'Year to date', rangeSetter: (d) => startOfYear(d) },]@@ -204,7 +220,7 @@ export const EmbeddedDayGranular: Story = {export const WeekStartsThursday: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return <DateTimePicker value={value} onApply={setValue} weekStartsOn={Day.THURSDAY} />},}@@ -212,7 +228,7 @@ export const WeekStartsThursday: Story = {export const NarrowContainer: Story = {args: baseArgs,render: () => {- const [value, setValue] = React.useState<DateTimeValue>(initialValue)+ const [value, setValue] = React.useState<DateTimeValue>(() => getInitialValue())return <DateTimePicker value={value} onApply={setValue} compact />},}diff --git a/pnpm-lock.yaml b/pnpm-lock.yamlindex 342868d7f34b..79acac4a51d0 100644--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -1981,6 +1981,9 @@ importers:lucide-react:specifier: ^0.577.0version: 0.577.0([email protected])+ mockdate:+ specifier: ^3.0.5+ version: 3.0.5react:specifier: 18.3.1version: 18.3.1