:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(posthog-ai): stop showing finished interactive tasks as working (#121279)
Peter Kirkhamafd98498157e
diff --git a/frontend/src/layout/today/TodaySessionIcon.tsx b/frontend/src/layout/today/TodaySessionIcon.tsxindex 329f5317d871..0ced25bd282a 100644--- a/frontend/src/layout/today/TodaySessionIcon.tsx+++ b/frontend/src/layout/today/TodaySessionIcon.tsx@@ -12,7 +12,7 @@ export function TodaySessionIcon({item,unread = false,}: {- item: Pick<TodayWorkItem, 'kind' | 'status' | 'runEnvironment'>+ item: Pick<TodayWorkItem, 'kind' | 'status' | 'runEnvironment' | 'runMode'>unread?: boolean}): JSX.Element {if (item.kind === 'chat') {diff --git a/frontend/src/layout/today/todaySessionDot.test.ts b/frontend/src/layout/today/todaySessionDot.test.tsindex b28a39f30795..796a078345b4 100644--- a/frontend/src/layout/today/todaySessionDot.test.ts+++ b/frontend/src/layout/today/todaySessionDot.test.ts@@ -1,17 +1,27 @@import { TodaySessionDot, todaySessionDot } from './todaySessionDot'describe('todaySessionDot', () => {- it.each<[string, string | null, string | null, boolean, Omit<TodaySessionDot, 'faint'> & { faint?: boolean }]>([+ it.each<+ [string, string | null, string | null, boolean, Omit<TodaySessionDot, 'faint'> & { faint?: boolean }, string?]+ >([['a failed run, even when unread', 'failed', 'cloud', true, { mark: 'failed', label: 'Failed' }],['a queued cloud run', 'queued', 'cloud', false, { mark: 'spinner', label: 'Queued' }],['a cloud run that has not started', 'not_started', 'cloud', true, { mark: 'spinner', label: 'Starting' }],['a queued local run', 'queued', 'local', false, { mark: 'hollow', label: 'Queued' }],['a running session, even when unread', 'in_progress', 'cloud', true, { mark: 'spinner', label: 'Working' }],+ [+ 'an interactive session between turns',+ 'in_progress',+ 'cloud',+ false,+ { mark: 'hollow', label: 'Idle' },+ 'interactive',+ ],['an unread finished session', 'completed', 'cloud', true, { mark: 'solid', label: 'Unread' }],['a finished session', 'completed', 'cloud', false, { mark: 'hollow', label: 'Completed' }],['a stopped session', 'cancelled', 'cloud', false, { mark: 'hollow', faint: true, label: 'Stopped' }],['a session with no run', null, null, false, { mark: 'hollow', label: 'Idle' }],- ])('shows %s', (_, status, runEnvironment, unread, expected) => {- expect(todaySessionDot({ status, runEnvironment }, unread)).toEqual({ faint: false, ...expected })+ ])('shows %s', (_, status, runEnvironment, unread, expected, runMode = 'background') => {+ expect(todaySessionDot({ status, runEnvironment, runMode }, unread)).toEqual({ faint: false, ...expected })})})diff --git a/frontend/src/layout/today/todaySessionDot.ts b/frontend/src/layout/today/todaySessionDot.tsindex 4009e4a5c157..860e96afed9d 100644--- a/frontend/src/layout/today/todaySessionDot.ts+++ b/frontend/src/layout/today/todaySessionDot.ts@@ -15,7 +15,7 @@ const STARTING_LABELS: Record<string, string> = { not_started: 'Starting', queue* so every settled state shares the same quiet ring.*/export function todaySessionDot(- item: Pick<TodayWorkItem, 'status' | 'runEnvironment'>,+ item: Pick<TodayWorkItem, 'status' | 'runEnvironment' | 'runMode'>,unread: boolean): TodaySessionDot {const { status } = item@@ -27,7 +27,8 @@ export function todaySessionDot(if (startingLabel && item.runEnvironment === 'cloud') {return { mark: 'spinner', faint: false, label: startingLabel }}- if (status === 'in_progress') {+ // An interactive run stays `in_progress` between turns, so only a background run shows the spinner.+ if (status === 'in_progress' && item.runMode !== 'interactive') {return { mark: 'spinner', faint: false, label: 'Working' }}if (unread) {diff --git a/frontend/src/layout/today/todayWorkItems.ts b/frontend/src/layout/today/todayWorkItems.tsindex 5fa661e34b9a..16f094eed674 100644--- a/frontend/src/layout/today/todayWorkItems.ts+++ b/frontend/src/layout/today/todayWorkItems.ts@@ -30,6 +30,8 @@ export interface TodayWorkItem {latestRunId: string | nullruntime?: string | nullrunEnvironment: string | null+ /** The latest run's execution mode, `interactive` or `background`. */+ runMode?: string | nulloriginProduct: string | null/** What filed it: a session's origin product, or PostHog AI for a chat. */source: string | null@@ -124,11 +126,23 @@ function finalMessage(output: TaskRunDetailDTOApi['output'] | undefined): stringreturn typeof message === 'string' && message.trim() ? message.trim() : null}+function runMode(state: TaskRunDetailDTOApi['state'] | null | undefined): string | null {+ return typeof state?.mode === 'string' ? state.mode : null+}+/** What the session icon reads, from a task's latest run, for a page that has the task but not its work item. */export function sessionIconFields(- latestRun: { status?: string | null; environment?: string | null } | null | undefined-): Pick<TodayWorkItem, 'kind' | 'status' | 'runEnvironment'> {- return { kind: 'session', status: latestRun?.status ?? null, runEnvironment: latestRun?.environment ?? null }+ latestRun:+ | { status?: string | null; environment?: string | null; state?: TaskRunDetailDTOApi['state'] | null }+ | null+ | undefined+): Pick<TodayWorkItem, 'kind' | 'status' | 'runEnvironment' | 'runMode'> {+ return {+ kind: 'session',+ status: latestRun?.status ?? null,+ runEnvironment: latestRun?.environment ?? null,+ runMode: runMode(latestRun?.state),+ }}export function sessionItem(task: TaskListItemApi): TodayWorkItem {@@ -145,6 +159,7 @@ export function sessionItem(task: TaskListItemApi): TodayWorkItem {latestRunId: task.latest_run?.id ?? null,runtime: task.runtime ?? null,runEnvironment: task.latest_run?.environment ?? null,+ runMode: runMode(task.latest_run?.state),originProduct: task.origin_product ?? null,source: task.origin_product || null,repository: task.repository || null,diff --git a/products/posthog_ai/frontend/scenes/TaskTracker/components/taskHistoryUtils.ts b/products/posthog_ai/frontend/scenes/TaskTracker/components/taskHistoryUtils.tsindex 6892417a968d..6af4318bdcd8 100644--- a/products/posthog_ai/frontend/scenes/TaskTracker/components/taskHistoryUtils.ts+++ b/products/posthog_ai/frontend/scenes/TaskTracker/components/taskHistoryUtils.ts@@ -15,5 +15,10 @@ export function compactTimeAgo(iso: string): string {}export function isTaskInProgress(task: Task): boolean {- return task.latest_run ? IN_PROGRESS_STATUSES.has(task.latest_run.status) : false+ const run = task.latest_run+ if (!run || !IN_PROGRESS_STATUSES.has(run.status)) {+ return false+ }+ // An interactive run stays `in_progress` between turns, so that status alone does not mean the agent works.+ return !(run.status === TaskRunStatus.IN_PROGRESS && run.state?.mode === 'interactive')}diff --git a/products/tasks/frontend/spaces/spaceFeedStatus.test.ts b/products/tasks/frontend/spaces/spaceFeedStatus.test.tsindex 6efccda2764b..8f2657074459 100644--- a/products/tasks/frontend/spaces/spaceFeedStatus.test.ts+++ b/products/tasks/frontend/spaces/spaceFeedStatus.test.ts@@ -1,13 +1,18 @@import { TaskRunDetailDTOApi } from '../generated/api.schemas'import { spaceFeedStatus } from './spaceFeedStatus'-const run = (status: string, environment: string, output: TaskRunDetailDTOApi['output'] = null): TaskRunDetailDTOApi =>- ({ status, environment, output }) as TaskRunDetailDTOApi+const run = (+ status: string,+ environment: string,+ output: TaskRunDetailDTOApi['output'] = null,+ mode = 'background'+): TaskRunDetailDTOApi => ({ status, environment, output, state: { mode } }) as unknown as TaskRunDetailDTOApidescribe('spaceFeedStatus', () => {it.each([['no run', null, 'Draft'],['a cloud run in progress', run('in_progress', 'cloud'), 'In progress'],+ ['an interactive cloud run between turns', run('in_progress', 'cloud', null, 'interactive'), 'Ready'],['a local run in progress', run('in_progress', 'local'), null],['a local run that completed', run('completed', 'local'), 'Ready'],[diff --git a/products/tasks/frontend/spaces/spaceFeedStatus.ts b/products/tasks/frontend/spaces/spaceFeedStatus.tsindex b6a491b16d8b..d4fc01833853 100644--- a/products/tasks/frontend/spaces/spaceFeedStatus.ts+++ b/products/tasks/frontend/spaces/spaceFeedStatus.ts@@ -50,5 +50,9 @@ export function spaceFeedStatus(if (run.environment !== 'cloud' && !TERMINAL_STATUSES.has(run.status)) {return null}+ // An interactive run stays `in_progress` between turns, so its turn output is ready for the reader.+ if (run.status === 'in_progress' && run.state?.mode === 'interactive') {+ return RUN_STATUSES.completed+ }return RUN_STATUSES[run.status] ?? null}