Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(today): hide the floating ai button until the panel is undocked (#123467)

Adam Leithb00fa78f52d6
diff --git a/frontend/snapshots.yml b/frontend/snapshots.yml
index d3f5167edbc4..a5459cadd6b5 100644
--- a/frontend/snapshots.yml
+++ b/frontend/snapshots.yml
@@ -11247,9 +11247,9 @@ snapshots:
scenes-app-errortracking--group-page-releases-stacked--light:
hash: v1.k794b7964.bbd7d8f861510cc79188ecbe20e6af110f08f96a53ef27ac75ce28bbd704f48c.bBi7jDw0DwllpcX_pkQJi-DdiBG_XAmTwS_GzqDEoRw
scenes-app-errortracking--group-page-today-rail-nav--dark:
- hash: v1.k794b7964.45333b8ac34d1969ce924ac944fd203f5f894b77bd648b1ddabd334e358a84a9.idoJ_9mN1DW6iaTAberGn3zMxARWpVZq9OqWE5lDDQU
+ hash: v1.k794b7964.44bec3bc5d0ee4ef65f548012c4ec6e4cc65ddb94d6251f4cd9563bdc90f16bf.iSE4tmNbkJFoeG6DCM5k-F8hXt0cFQUPYkcOfbamQUk
scenes-app-errortracking--group-page-today-rail-nav--light:
- hash: v1.k794b7964.16e1cb61689aeecacd7d21e8cf97ff33760cc6b77a140faeec4e67e4acd03440.G88NZldjGRM_wNvECGEPrOTyyyJgpS1p4HJ7gzWR7Fs
+ hash: v1.k794b7964.e74f7ba76b28c0803dcd71ec276c0774cc236ead25cbcd7c5e911775e1b2391c.Utp2DqgtqoD_iT_VmejgjPgCsR1YJYhZAAmyrqE_dkA
scenes-app-errortracking--group-page-with-many-self-driving-reports--dark:
hash: v1.k794b7964.80a2533ac0237e1c88e747da106127fb7f335c4dfbda4dcd9acc58d5fad4133d.-bwvh6NUGPl4apMtIctBlqZHzMtXaDazhCLw-q4AUtM
scenes-app-errortracking--group-page-with-many-self-driving-reports--light:
diff --git a/frontend/src/layout/today/todayContextPanelLogic.test.ts b/frontend/src/layout/today/todayContextPanelLogic.test.ts
new file mode 100644
index 000000000000..1d8986332a41
--- /dev/null
+++ b/frontend/src/layout/today/todayContextPanelLogic.test.ts
@@ -0,0 +1,44 @@
+import { initKeaTests } from '~/test/init'
+import { SidePanelTab } from '~/types'
+
+import { todayContextPanelLogic } from './todayContextPanelLogic'
+
+describe('todayContextPanelLogic', () => {
+ let logic: ReturnType<typeof todayContextPanelLogic.build>
+
+ beforeEach(() => {
+ initKeaTests()
+ logic = todayContextPanelLogic()
+ logic.mount()
+ })
+
+ afterEach(() => {
+ logic.unmount()
+ })
+
+ it('keeps the floating button away until the user undocks the panel', () => {
+ expect(logic.values.launcherHidden).toBe(true)
+
+ logic.actions.openSidePanel(SidePanelTab.Max)
+ logic.actions.undock()
+ expect(logic.values.launcherHidden).toBe(false)
+
+ logic.actions.setFloatingOpen(false)
+ expect(logic.values.launcherHidden).toBe(false)
+ })
+
+ it.each([
+ ['docks the panel', (): void => logic.actions.dock()],
+ ['dismisses the button', (): void => logic.actions.hideLauncher()],
+ ])('takes the floating button away again once the user %s', (_, takeAway) => {
+ logic.actions.openSidePanel(SidePanelTab.Max)
+ logic.actions.undock()
+ logic.actions.setFloatingOpen(false)
+ takeAway()
+ if (logic.values.docked) {
+ logic.actions.closeSidePanel()
+ }
+
+ expect(logic.values.launcherHidden).toBe(true)
+ })
+})
diff --git a/frontend/src/layout/today/todayContextPanelLogic.ts b/frontend/src/layout/today/todayContextPanelLogic.ts
index c513ea1b0df3..ef04ef786655 100644
--- a/frontend/src/layout/today/todayContextPanelLogic.ts
+++ b/frontend/src/layout/today/todayContextPanelLogic.ts
@@ -74,8 +74,8 @@ export interface todayContextPanelLogicValues {
fullScreenUrl: string | null
launcherAlign: TodayLauncherAlign
launcherHidden: boolean
- launcherHiddenByUser: boolean
launcherHintVisible: boolean
+ launcherShown: boolean
panelTabs: SidePanelTab[]
}
@@ -143,7 +143,7 @@ export interface todayContextPanelLogicMeta {
) => TodayFloatingSession | null
launcherHidden: (
docked: boolean,
- launcherHiddenByUser: boolean,
+ launcherShown: boolean,
floatingOpen: boolean,
panelTabs: SidePanelTab[]
) => boolean
@@ -239,13 +239,15 @@ export const todayContextPanelLogic = kea<todayContextPanelLogicType>([
setLauncherAlign: (_, { align }) => align,
},
],
- launcherHiddenByUser: [
+ launcherShown: [
false,
{ persist: true },
{
- hideLauncher: () => true,
- // The card closes back into the floating button, so closing it brings the button back.
- setFloatingOpen: (state, { open }) => (open ? state : false),
+ undock: () => true,
+ // The card closes back into the floating button, so opening it floating counts as undocking.
+ setFloatingOpen: (state, { open }) => open || state,
+ dock: () => false,
+ hideLauncher: () => false,
},
],
launcherHintVisible: [
@@ -277,17 +279,13 @@ export const todayContextPanelLogic = kea<todayContextPanelLogicType>([
floatingOpen ? { tab: floatingActiveTab, offset: floatingOffset } : null,
],
/**
- * The button sinks away while docked and where the scene has no PostHog AI. The open card hangs off it, so it
- * shows for as long as the card is open, even after the user dismissed it.
+ * The button sinks away while docked, until the user undocks, and where the scene has no PostHog AI. The
+ * open card hangs off it, so it shows for as long as the card is open.
*/
launcherHidden: [
- (s) => [s.docked, s.launcherHiddenByUser, s.floatingOpen, s.panelTabs],
- (
- docked: boolean,
- launcherHiddenByUser: boolean,
- floatingOpen: boolean,
- panelTabs: SidePanelTab[]
- ): boolean => docked || (launcherHiddenByUser && !floatingOpen) || !panelTabs.includes(SidePanelTab.Max),
+ (s) => [s.docked, s.launcherShown, s.floatingOpen, s.panelTabs],
+ (docked: boolean, launcherShown: boolean, floatingOpen: boolean, panelTabs: SidePanelTab[]): boolean =>
+ docked || !(launcherShown || floatingOpen) || !panelTabs.includes(SidePanelTab.Max),
],
panelTabs: [
(s) => [s.enabledTabs],