:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
refactor(insights): move kernel-only insight helpers to lib/insights (#126847)
Paul D'Ambrab08b4ca0bab3
diff --git a/frontend/bin/layer-baseline.txt b/frontend/bin/layer-baseline.txtindex a160e3155f26..7194f3f69b36 100644--- a/frontend/bin/layer-baseline.txt+++ b/frontend/bin/layer-baseline.txt@@ -75,7 +75,6 @@ frontend/src/layout/today/todayContextPanelLogic.ts -> frontend/src/scenes/notebfrontend/src/layout/today/todayContextPanelLogic.ts -> products/conversations/frontend/components/SidePanel/sidepanelTicketsLogic.tsfrontend/src/layout/today/todayObjectGlanceLogic.ts -> frontend/src/scenes/library/libraryUtils.tsfrontend/src/layout/today/todayObjectGlances.ts -> frontend/src/queries/utils.ts-frontend/src/layout/today/todayObjectGlances.ts -> frontend/src/scenes/insights/aggregationAxisFormat.tsfrontend/src/layout/today/todayObjectGlances.ts -> frontend/src/scenes/library/libraryUtils.tsfrontend/src/layout/today/todayObjectGlances.ts -> frontend/src/scenes/project-homepage/today/todayNumbers.tsfrontend/src/layout/today/todayObjectGlances.ts -> products/experiments/frontend/experimentStatus.ts@@ -102,7 +101,6 @@ frontend/src/lib/components/ActivityLog/ActivityLogSubscribeMenu.tsx -> frontendfrontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts -> frontend/src/scenes/dashboard/liveDashboardIds.tsfrontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts -> frontend/src/scenes/dashboard/newDashboardLogic.tsfrontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts -> frontend/src/scenes/insights/insightLogic.tsx-frontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts -> frontend/src/scenes/insights/sharedUtils.tsfrontend/src/lib/components/Alerting/AlertWizard/alertWizardLogic.ts -> frontend/src/scenes/health/healthCategories.tsxfrontend/src/lib/components/Alerting/AlertWizard/alertWizardLogic.ts -> frontend/src/scenes/hog-functions/configuration/sampleGlobalsContexts.tsfrontend/src/lib/components/Alerting/AlertWizard/alertWizardLogic.ts -> frontend/src/scenes/hog-functions/sub-templates/sub-templates.ts@@ -128,7 +126,6 @@ frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> frontend/src/qufrontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> frontend/src/scenes/insights/EmptyStates/index.tsfrontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> frontend/src/scenes/insights/insightDataLogic.tsxfrontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> frontend/src/scenes/insights/insightLogic.tsx-frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> frontend/src/scenes/insights/sharedUtils.tsfrontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> products/business_intelligence/frontend/BIDashboardFilterStatus.tsxfrontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> products/business_intelligence/frontend/BIDashboardTile.tsxfrontend/src/lib/components/Cards/InsightCard/InsightCard.tsx -> products/business_intelligence/frontend/biDashboardCrossFilters.ts@@ -217,7 +214,6 @@ frontend/src/lib/components/InsightLabel/index.tsx -> frontend/src/scenes/insighfrontend/src/lib/components/InsightLabel/index.tsx -> products/product_analytics/frontend/insights/trends/mathsLogic.tsxfrontend/src/lib/components/InsightLegend/InsightLegend.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/lib/components/InsightLegend/InsightLegend.tsx -> products/product_analytics/frontend/insights/trends/trendsDataLogic.ts-frontend/src/lib/components/InsightLegend/InsightLegendRow.tsx -> frontend/src/scenes/insights/aggregationAxisFormat.tsfrontend/src/lib/components/InsightLegend/InsightLegendRow.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/lib/components/InsightLegend/InsightLegendRow.tsx -> frontend/src/scenes/insights/utils.tsxfrontend/src/lib/components/InsightLegend/InsightLegendRow.tsx -> frontend/src/scenes/insights/utils/resultSeries.ts@@ -302,7 +298,6 @@ frontend/src/lib/components/TerraformExporter/alertHclExporter.ts -> products/alfrontend/src/lib/components/TerraformExporter/insightHclExporter.ts -> frontend/src/scenes/dashboard/liveDashboardIds.tsfrontend/src/lib/components/TerraformExporter/useTerraformExport.ts -> products/alerts/frontend/logic/alertNotifications.tsfrontend/src/lib/components/TimeSensitiveAuthentication/timeSensitiveAuthenticationLogic.ts -> frontend/src/scenes/authentication/shared/loginErrorMessages.tsx-frontend/src/lib/components/UnitPicker/UnitPicker.tsx -> frontend/src/scenes/insights/aggregationAxisFormat.tsfrontend/src/lib/components/UnitPicker/UnitPicker.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/lib/components/UnitPicker/UnitPicker.tsx -> frontend/src/scenes/insights/insightVizDataLogic.tsfrontend/src/lib/components/UniversalFilters/universalFiltersLogic.ts -> frontend/src/scenes/session-recordings/filters/sessionRecordingSavedFiltersLogic.ts@@ -409,7 +404,6 @@ frontend/src/queries/nodes/DataTable/renderColumn.tsx -> products/persons/frontefrontend/src/queries/nodes/DataVisualization/Components/Charts/SqlMetricCard.tsx -> frontend/src/scenes/insights/EmptyStates/index.tsfrontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.ts -> products/product_analytics/frontend/insights/trends/shared/goalLinesAdapter.tsfrontend/src/queries/nodes/DataVisualization/Components/Heatmap/TwoDimensionalHeatmap.tsx -> frontend/src/scenes/insights/EmptyStates/index.ts-frontend/src/queries/nodes/DataVisualization/Components/SeriesTab.tsx -> frontend/src/scenes/insights/aggregationAxisFormat.tsfrontend/src/queries/nodes/DataVisualization/Components/SideBar.tsx -> products/business_intelligence/frontend/biTableLayout.tsfrontend/src/queries/nodes/DataVisualization/Components/Table.tsx -> frontend/src/scenes/insights/EmptyStates/index.tsfrontend/src/queries/nodes/DataVisualization/Components/Variables/NewVariableModal.tsx -> frontend/src/scenes/data-management/variables/insightColumns.tsx@@ -468,7 +462,6 @@ frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> frontend/src/scenfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> frontend/src/scenes/insights/insightDataLogic.tsxfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> frontend/src/scenes/insights/insightVizDataLogic.ts-frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> frontend/src/scenes/insights/sharedUtils.tsfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> frontend/src/scenes/insights/utils/queryUtils.tsfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/InsightNav/insightNavLogic.tsxfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/chartAlternatives/ChartAlternatives.tsx@@ -495,9 +488,7 @@ frontend/src/queries/nodes/InsightViz/ResultCustomizationsModal.tsx -> frontend/frontend/src/queries/nodes/InsightViz/ResultCustomizationsModal.tsx -> frontend/src/scenes/insights/utils/resultSeries.tsfrontend/src/queries/nodes/InsightViz/ResultCustomizationsModal.tsx -> products/product_analytics/frontend/insights/trends/trendsDataLogic.tsfrontend/src/queries/nodes/InsightViz/exportAdapters.ts -> frontend/src/scenes/insights/utils/resultSeries.ts-frontend/src/queries/nodes/InsightViz/insightVizKeys.ts -> frontend/src/scenes/insights/sharedUtils.tsfrontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts -> frontend/src/scenes/insights/insightVizDataLogic.ts-frontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts -> frontend/src/scenes/insights/sharedUtils.tsfrontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts -> frontend/src/scenes/insights/utils.tsxfrontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts -> products/product_analytics/frontend/insights/funnels/funnelDataLogic.tsfrontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts -> products/product_analytics/frontend/insights/trends/trendsDataLogic.tsdiff --git a/frontend/src/layout/today/todayObjectGlances.ts b/frontend/src/layout/today/todayObjectGlances.tsindex f925277ff8fc..3141c6c23208 100644--- a/frontend/src/layout/today/todayObjectGlances.ts+++ b/frontend/src/layout/today/todayObjectGlances.ts@@ -1,6 +1,6 @@import { dayjs } from 'lib/dayjs'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { pluralize } from 'lib/utils/strings'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { baseObjectType } from 'scenes/library/libraryUtils'import { todayNumber } from 'scenes/project-homepage/today/todayNumbers'diff --git a/frontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts b/frontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.tsindex da1ad146fefb..a85d2c6fa088 100644--- a/frontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts+++ b/frontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts@@ -2,13 +2,13 @@ import FuseClass, { FuseResult } from 'fuse.js'import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'import { router } from 'kea-router'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { eventUsageLogic } from 'lib/utils/eventUsageLogic'import { createFuse } from 'lib/utils/fuseSearch'import { liveDashboardIds } from 'scenes/dashboard/liveDashboardIds'import { newDashboardLogic } from 'scenes/dashboard/newDashboardLogic'import { insightLogic } from 'scenes/insights/insightLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { urls } from 'scenes/urls'import { userLogic } from 'scenes/userLogic'diff --git a/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx b/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsxindex a9ccdb863982..00d87c0dfd59 100644--- a/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx+++ b/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx@@ -11,6 +11,7 @@ import { ApiError } from 'lib/api'import { Resizeable } from 'lib/components/Cards/CardMeta'import { useInterval } from 'lib/hooks/useInterval'import { usePageVisibility } from 'lib/hooks/usePageVisibility'+import { getCapacityRetryAt, getRetryCooldown } from 'lib/insights/sharedUtils'import { SpinnerOverlay } from 'lib/lemon-ui/Spinner/Spinner'import { themeLogic } from 'lib/logic/themeLogic'import { accessLevelSatisfied, getAccessControlDisabledReason } from 'lib/utils/accessControlUtils'@@ -25,7 +26,6 @@ import {} from 'scenes/insights/EmptyStates'import { insightDataLogic } from 'scenes/insights/insightDataLogic'import { insightLogic } from 'scenes/insights/insightLogic'-import { getCapacityRetryAt, getRetryCooldown } from 'scenes/insights/sharedUtils'import { isSharedView } from '~/exporter/exporterViewLogic'import { ErrorBoundary } from '~/layout/ErrorBoundary'diff --git a/frontend/src/lib/components/InsightLegend/InsightLegendRow.tsx b/frontend/src/lib/components/InsightLegend/InsightLegendRow.tsxindex fb027ff357bb..9316f5fe46cf 100644--- a/frontend/src/lib/components/InsightLegend/InsightLegendRow.tsx+++ b/frontend/src/lib/components/InsightLegend/InsightLegendRow.tsx@@ -6,8 +6,8 @@ import { captureLegendMenuAction } from 'lib/components/ChartLegendSeriesMenu/caimport { ChartLegendSeriesMenu } from 'lib/components/ChartLegendSeriesMenu/ChartLegendSeriesMenu'import { InsightLabel } from 'lib/components/InsightLabel'import { PART_OF_WHOLE_DISPLAY_TYPES } from 'lib/constants'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { LemonCheckbox } from 'lib/lemon-ui/LemonCheckbox'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { insightLogic } from 'scenes/insights/insightLogic'import { formatBreakdownLabel, getTrendResultCustomizationKey } from 'scenes/insights/utils'import { getResultSeries } from 'scenes/insights/utils/resultSeries'diff --git a/frontend/src/lib/components/UnitPicker/UnitPicker.tsx b/frontend/src/lib/components/UnitPicker/UnitPicker.tsxindex 6b0de7137a33..21c40dc338a3 100644--- a/frontend/src/lib/components/UnitPicker/UnitPicker.tsx+++ b/frontend/src/lib/components/UnitPicker/UnitPicker.tsx@@ -2,15 +2,15 @@ import { useActions, useValues } from 'kea'import { useMemo, useState } from 'react'import { useKeyboardHotkeys } from 'lib/hooks/useKeyboardHotkeys'-import { LemonButton, LemonButtonWithDropdown } from 'lib/lemon-ui/LemonButton'-import { LemonDivider } from 'lib/lemon-ui/LemonDivider'-import { eventUsageLogic } from 'lib/utils/eventUsageLogic'import {AggregationAxisFormat,defaultAggregationAxisFormatForDisplay,INSIGHT_UNIT_OPTIONS,INSIGHT_UNIT_OPTIONS_SHORT,-} from 'scenes/insights/aggregationAxisFormat'+} from 'lib/insights/aggregationAxisFormat'+import { LemonButton, LemonButtonWithDropdown } from 'lib/lemon-ui/LemonButton'+import { LemonDivider } from 'lib/lemon-ui/LemonDivider'+import { eventUsageLogic } from 'lib/utils/eventUsageLogic'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'diff --git a/frontend/src/scenes/insights/aggregationAxisFormat.ts b/frontend/src/lib/insights/aggregationAxisFormat.tssimilarity index 100%rename from frontend/src/scenes/insights/aggregationAxisFormat.tsrename to frontend/src/lib/insights/aggregationAxisFormat.tsdiff --git a/frontend/src/scenes/insights/aggregationAxisFormats.test.ts b/frontend/src/lib/insights/aggregationAxisFormats.test.tssimilarity index 99%rename from frontend/src/scenes/insights/aggregationAxisFormats.test.tsrename to frontend/src/lib/insights/aggregationAxisFormats.test.tsindex 0422a629516c..b66b4e80c5df 100644--- a/frontend/src/scenes/insights/aggregationAxisFormats.test.ts+++ b/frontend/src/lib/insights/aggregationAxisFormats.test.ts@@ -3,7 +3,7 @@ import {defaultAggregationAxisFormatForDisplay,formatAggregationAxisValue,formatAggregationAxisValueWithShareOfTotal,-} from 'scenes/insights/aggregationAxisFormat'+} from 'lib/insights/aggregationAxisFormat'import { CurrencyCode } from '~/queries/schema/schema-general'import { ChartDisplayType, FilterType } from '~/types'diff --git a/frontend/src/scenes/insights/sharedUtils.test.ts b/frontend/src/lib/insights/sharedUtils.test.tssimilarity index 93%rename from frontend/src/scenes/insights/sharedUtils.test.tsrename to frontend/src/lib/insights/sharedUtils.test.tsindex ca2922d95406..651a7fb01358 100644--- a/frontend/src/scenes/insights/sharedUtils.test.ts+++ b/frontend/src/lib/insights/sharedUtils.test.ts@@ -1,4 +1,4 @@-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { InsightShortId } from '~/types'diff --git a/frontend/src/scenes/insights/sharedUtils.ts b/frontend/src/lib/insights/sharedUtils.tssimilarity index 95%rename from frontend/src/scenes/insights/sharedUtils.tsrename to frontend/src/lib/insights/sharedUtils.tsindex 2d1fe6e18720..14f4387cde35 100644--- a/frontend/src/scenes/insights/sharedUtils.ts+++ b/frontend/src/lib/insights/sharedUtils.ts@@ -1,4 +1,3 @@-// This is separate from utils.ts because here we don't include `funnelLogic`, `retentionLogic`, etcimport { ApiError } from 'lib/api-error'import { FilterType, InsightLogicProps, InsightType, TrendsFilterType } from '~/types'diff --git a/frontend/src/queries/nodes/DataVisualization/Components/SeriesTab.tsx b/frontend/src/queries/nodes/DataVisualization/Components/SeriesTab.tsxindex 1097e99155ef..b516c077febc 100644--- a/frontend/src/queries/nodes/DataVisualization/Components/SeriesTab.tsx+++ b/frontend/src/queries/nodes/DataVisualization/Components/SeriesTab.tsx@@ -20,9 +20,9 @@ import {import { DataColorToken, getSeriesColor, getSeriesColorPalette } from 'lib/colors'import { PART_OF_WHOLE_DISPLAY_TYPES } from 'lib/constants'+import { INSIGHT_UNIT_OPTIONS_SHORT } from 'lib/insights/aggregationAxisFormat'import { LemonField } from 'lib/lemon-ui/LemonField'import { dataThemeLogic } from 'scenes/dataThemeLogic'-import { INSIGHT_UNIT_OPTIONS_SHORT } from 'scenes/insights/aggregationAxisFormat'import { ResultCustomizationBy } from '~/queries/schema/schema-general'import { ChartDisplayType } from '~/types'diff --git a/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx b/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsxindex de9b95c25553..5e75962c1bc3 100644--- a/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx+++ b/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx@@ -6,6 +6,7 @@ import { LemonButton, Spinner } from '@posthog/lemon-ui'import { ExportButton } from 'lib/components/ExportButton/ExportButton'import { InsightLegend } from 'lib/components/InsightLegend/InsightLegend'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { Tooltip } from 'lib/lemon-ui/Tooltip'import { lazyWithRetry } from 'lib/utils/retryImport'import { ChunkLoadErrorBoundary } from 'scenes/ChunkLoadErrorBoundary'@@ -28,7 +29,6 @@ import {import { insightDataLogic } from 'scenes/insights/insightDataLogic'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { isBoxPlotMissingProperty } from 'scenes/insights/utils/queryUtils'import { SceneSection } from '~/layout/scenes/components/SceneSection'diff --git a/frontend/src/queries/nodes/InsightViz/insightVizKeys.ts b/frontend/src/queries/nodes/InsightViz/insightVizKeys.tsindex 95adbd14fa1f..bd3587fab450 100644--- a/frontend/src/queries/nodes/InsightViz/insightVizKeys.ts+++ b/frontend/src/queries/nodes/InsightViz/insightVizKeys.ts@@ -1,4 +1,4 @@-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { InsightLogicProps } from '~/types'diff --git a/frontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts b/frontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.tsindex 51ae6ae72c8f..93ffbb0d436e 100644--- a/frontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts+++ b/frontend/src/queries/nodes/InsightViz/resultCustomizationsModalLogic.ts@@ -1,8 +1,8 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'import { DataColorToken } from 'lib/colors'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import {getFunnelDatasetKey,getFunnelResultCustomization,diff --git a/frontend/src/queries/schema/schema-assistant-queries.ts b/frontend/src/queries/schema/schema-assistant-queries.tsindex bf22de37a4de..bd51de891947 100644--- a/frontend/src/queries/schema/schema-assistant-queries.ts+++ b/frontend/src/queries/schema/schema-assistant-queries.ts@@ -1,5 +1,5 @@import type { FunnelLayout } from 'lib/constants'-import type { AggregationAxisFormat } from 'scenes/insights/aggregationAxisFormat'+import type { AggregationAxisFormat } from 'lib/insights/aggregationAxisFormat'import {BehavioralPropertyFilter,diff --git a/frontend/src/queries/schema/schema-general.ts b/frontend/src/queries/schema/schema-general.tsindex 155822a245e7..58e609e05182 100644--- a/frontend/src/queries/schema/schema-general.ts+++ b/frontend/src/queries/schema/schema-general.ts@@ -2,7 +2,7 @@ import { DataColorToken } from 'lib/colors'// eslint-disable-next-line import/no-cycleimport { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'import type { FunnelLayout } from 'lib/constants'-import type { AggregationAxisFormat } from 'scenes/insights/aggregationAxisFormat'+import type { AggregationAxisFormat } from 'lib/insights/aggregationAxisFormat'import { ConversionGoalSchema } from '~/taxonomy/marketingAnalytics'import {diff --git a/frontend/src/scenes/insights/EmptyStates/EmptyStates.tsx b/frontend/src/scenes/insights/EmptyStates/EmptyStates.tsxindex b4f72e73e687..422104f8e8e5 100644--- a/frontend/src/scenes/insights/EmptyStates/EmptyStates.tsx+++ b/frontend/src/scenes/insights/EmptyStates/EmptyStates.tsx@@ -22,6 +22,7 @@ import { dayjs } from 'lib/dayjs'import { useInterval } from 'lib/hooks/useInterval'import { useOnMountEffect } from 'lib/hooks/useOnMountEffect'import { usePageVisibility } from 'lib/hooks/usePageVisibility'+import { getRetryCooldown } from 'lib/insights/sharedUtils'import { IconChristmasOrnament, IconErrorOutline } from 'lib/lemon-ui/icons'import { LemonMenuOverlay } from 'lib/lemon-ui/LemonMenu/LemonMenu'import { Link } from 'lib/lemon-ui/Link'@@ -57,7 +58,6 @@ import { funnelDataLogic } from 'products/product_analytics/frontend/insights/fuimport { insightDataLogic } from '../insightDataLogic'import { insightVizDataLogic } from '../insightVizDataLogic'-import { getRetryCooldown } from '../sharedUtils'import { InsightErrorLayout } from './InsightErrorLayout'import { SampleDataState, SampleDataVariant } from './SampleDataState'import { sampleDataStateLogic } from './sampleDataStateLogic'diff --git a/frontend/src/scenes/insights/filters/ActionFilter/ActionFilter.tsx b/frontend/src/scenes/insights/filters/ActionFilter/ActionFilter.tsxindex 754475c066a3..d570880a7d40 100644--- a/frontend/src/scenes/insights/filters/ActionFilter/ActionFilter.tsx+++ b/frontend/src/scenes/insights/filters/ActionFilter/ActionFilter.tsx@@ -16,11 +16,11 @@ import {} from 'lib/components/TaxonomicFilter/types'import { TaxonomicPopoverProps } from 'lib/components/TaxonomicPopover/TaxonomicPopover'import { DISPLAY_TYPES_TO_CATEGORIES as DISPLAY_TYPES_TO_CATEGORY } from 'lib/constants'+import { isTrendsFilter } from 'lib/insights/sharedUtils'import { LemonButton, LemonButtonProps } from 'lib/lemon-ui/LemonButton'import { verticalSortableListCollisionDetection } from 'lib/sortable'import { eventUsageLogic } from 'lib/utils/eventUsageLogic'import { RenameModal } from 'scenes/insights/filters/ActionFilter/RenameModal'-import { isTrendsFilter } from 'scenes/insights/sharedUtils'import { ChartDisplayCategory, ChartDisplayType, FilterType, InsightType, PropertyOperator } from '~/types'diff --git a/frontend/src/scenes/insights/insightDataLogic.tsx b/frontend/src/scenes/insights/insightDataLogic.tsxindex e504d2fb2876..1334bb81eedb 100644--- a/frontend/src/scenes/insights/insightDataLogic.tsx+++ b/frontend/src/scenes/insights/insightDataLogic.tsx@@ -18,10 +18,10 @@ import { actionToUrl, router } from 'kea-router'import posthog from 'posthog-js'import api from 'lib/api'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { PromiseTimeoutError, withTimeout } from 'lib/utils/async'import { objectsEqual } from 'lib/utils/objects'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { insightsApi } from 'scenes/insights/utils/api'import { sceneLogic } from 'scenes/sceneLogic'import { Scene } from 'scenes/sceneTypes'diff --git a/frontend/src/scenes/insights/insightDataTimingLogic.ts b/frontend/src/scenes/insights/insightDataTimingLogic.tsindex 9f02a7ddc688..31dead74c75d 100644--- a/frontend/src/scenes/insights/insightDataTimingLogic.ts+++ b/frontend/src/scenes/insights/insightDataTimingLogic.ts@@ -1,5 +1,6 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers } from 'kea'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { eventUsageLogic } from 'lib/utils/eventUsageLogic'import { teamLogic } from 'scenes/teamLogic'@@ -24,7 +25,6 @@ import type {TraceSpansQueryResponse,} from '../../queries/schema/schema-general'import type { TraceSpansTreeQueryResponse } from '../../queries/schema/schema-general'-import { keyForInsightLogicProps } from './sharedUtils'// Generated by kea-typegen. Update if you're an agent, ignore if you're human.export interface insightDataTimingLogicValues {diff --git a/frontend/src/scenes/insights/insightLogic.tsx b/frontend/src/scenes/insights/insightLogic.tsxindex 44f5f9e748fa..52b9ccb03aff 100644--- a/frontend/src/scenes/insights/insightLogic.tsx+++ b/frontend/src/scenes/insights/insightLogic.tsx@@ -23,6 +23,7 @@ import { isTransientServerError, shouldReportApiFailure } from 'lib/api-error'import { tryShowMCPHint } from 'lib/components/MCPHint/mcpHintLogic'import { SetupTaskId, globalSetupLogic } from 'lib/components/ProductSetup'import { getInsightId } from 'lib/insights/getInsightId'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { LemonField } from 'lib/lemon-ui/LemonField'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'@@ -37,7 +38,6 @@ import { withBackLink } from 'scenes/analytics/analyticsBackLink'import { isDashboardFilterOverrideEmpty } from 'scenes/dashboard/dashboardFilterEmpty'import { liveDashboardIds } from 'scenes/dashboard/liveDashboardIds'import { insightSceneLogic } from 'scenes/insights/insightSceneLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { summarizeInsight } from 'scenes/insights/summarizeInsight'import { savedInsightsLogic } from 'scenes/saved-insights/savedInsightsLogic'import { sceneLogic } from 'scenes/sceneLogic'diff --git a/frontend/src/scenes/insights/insightUsageLogic.ts b/frontend/src/scenes/insights/insightUsageLogic.tsindex 71c112cbed80..fdbdaaa7ab14 100644--- a/frontend/src/scenes/insights/insightUsageLogic.ts+++ b/frontend/src/scenes/insights/insightUsageLogic.ts@@ -3,6 +3,7 @@ import { subscriptions } from 'kea-subscriptions'import posthog from 'posthog-js'import api from 'lib/api'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { sanitizeInsight, sanitizeQuery } from 'lib/utils/eventUsageLogic'import { objectClean, objectsEqual } from 'lib/utils/objects'import { projectLogic } from 'scenes/projectLogic'@@ -19,7 +20,6 @@ import type { DataNode } from '../../queries/schema/schema-general'import type { InsightModel } from '../../types'import { insightLogic } from './insightLogic'import { insightSceneLogic } from './insightSceneLogic'-import { keyForInsightLogicProps } from './sharedUtils'function reportInsightViewed(insightModel: Partial<InsightModel>,diff --git a/frontend/src/scenes/insights/insightVizDataLogic.ts b/frontend/src/scenes/insights/insightVizDataLogic.tsindex 83ddaf0705ab..6e62610f1946 100644--- a/frontend/src/scenes/insights/insightVizDataLogic.ts+++ b/frontend/src/scenes/insights/insightVizDataLogic.ts@@ -17,6 +17,7 @@ import {PIE_DISPLAY_TYPES,} from 'lib/constants'import { dayjs } from 'lib/dayjs'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import { dateMapping, is12HoursOrLess, isLessThan2Days } from 'lib/utils/dateFilters'import { objectsEqual } from 'lib/utils/objects'@@ -41,7 +42,6 @@ import {import type { SeriesNode } from 'scenes/insights/filters/ActionFilter/seriesNode'import { insightDataLogic } from 'scenes/insights/insightDataLogic'import { insightLogic } from 'scenes/insights/insightLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { trendsResultsMatchQuery } from 'scenes/insights/utils/queryUtils'import { sceneLogic } from 'scenes/sceneLogic'import { filterTestAccountsDefaultsLogic } from 'scenes/settings/environment/filterTestAccountDefaultsLogic'diff --git a/frontend/src/scenes/insights/utils.test.ts b/frontend/src/scenes/insights/utils.test.tsindex e6d6bda998dd..8eb36a86966b 100644--- a/frontend/src/scenes/insights/utils.test.ts+++ b/frontend/src/scenes/insights/utils.test.ts@@ -1,4 +1,4 @@-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import {compareInsightTopLevelSections,extractObjectDiffKeys,diff --git a/frontend/src/scenes/project-homepage/today/TodayPulse.tsx b/frontend/src/scenes/project-homepage/today/TodayPulse.tsxindex 138ede5ea0a4..4b7fb8d9e0e6 100644--- a/frontend/src/scenes/project-homepage/today/TodayPulse.tsx+++ b/frontend/src/scenes/project-homepage/today/TodayPulse.tsx@@ -2,10 +2,10 @@ import { useActions, useValues } from 'kea'import { type RefObject, Suspense, lazy, useLayoutEffect, useRef } from 'react'import { dayjs } from 'lib/dayjs'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { LinkPrimitive } from 'lib/lemon-ui/Link'import { humanFriendlyNumber } from 'lib/utils/numbers'import { retryImport } from 'lib/utils/retryImport'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { teamLogic } from 'scenes/teamLogic'import type { CurrencyCode, TrendsFilter } from '~/queries/schema/schema-general'diff --git a/frontend/src/types.ts b/frontend/src/types.tsindex 467d6a8857b2..153b245f8747 100644--- a/frontend/src/types.ts+++ b/frontend/src/types.ts@@ -31,11 +31,11 @@ import {TeamMembershipLevel,} from 'lib/constants'import { Dayjs, dayjs } from 'lib/dayjs'+import { AggregationAxisFormat } from 'lib/insights/aggregationAxisFormat'import { PopoverProps } from 'lib/lemon-ui/Popover/Popover'import type { ProjectSecretAPIKeyAllowedScope } from 'lib/scopes'import { BehavioralFilterKey, BehavioralFilterType } from 'scenes/cohorts/CohortFilters/types'import { BreakdownColorConfig } from 'scenes/dashboard/dashboardBreakdownColors'-import { AggregationAxisFormat } from 'scenes/insights/aggregationAxisFormat'import { Params, Scene, SceneConfig, SceneTab } from 'scenes/sceneTypes'import { SessionRecordingPlayerMode } from 'scenes/session-recordings/player/sessionRecordingPlayerLogic'import { SurveyRatingScaleValue, WEB_SAFE_FONTS } from 'scenes/surveys/constants'diff --git a/products/alerts/backend/evaluation/formatting.py b/products/alerts/backend/evaluation/formatting.pyindex fcae0dc8e00b..f1e478f6a89b 100644--- a/products/alerts/backend/evaluation/formatting.py+++ b/products/alerts/backend/evaluation/formatting.py@@ -1,7 +1,7 @@"""Format alert-breach values and breakdown labels the way the insight itself displays them.This is a backend port of the frontend `formatAggregationAxisValue`-(`frontend/src/scenes/insights/aggregationAxisFormat.ts`): given a trends insight's axis config+(`frontend/src/lib/insights/aggregationAxisFormat.ts`): given a trends insight's axis config(`aggregationAxisFormat`, prefix/postfix, decimal places) plus the team's base currency, render araw metric value as the user sees it on the chart — so notification messages read "($803.77)" and"(Other (i.e. all remaining values))" instead of "(803.7740196999998)" and a raw breakdown sentinel.diff --git a/products/product_analytics/backend/tests/api/__snapshots__/test_insight.ambr b/products/product_analytics/backend/tests/api/__snapshots__/test_insight.ambrindex ce8c1acde297..c02a9a570272 100644--- a/products/product_analytics/backend/tests/api/__snapshots__/test_insight.ambr+++ b/products/product_analytics/backend/tests/api/__snapshots__/test_insight.ambr@@ -3968,551 +3968,6 @@5 /* ... */))'''# ----# name: TestInsight.test_listing_insights_does_not_nplus1.181- '''- SELECT "posthog_organization"."id",- "posthog_organization"."name",- "posthog_organization"."slug",- "posthog_organization"."logo_media_id",- "posthog_organization"."created_at",- "posthog_organization"."updated_at",- "posthog_organization"."is_active",- "posthog_organization"."is_not_active_reason",- "posthog_organization"."session_cookie_age",- "posthog_organization"."is_member_join_email_enabled",- "posthog_organization"."is_ai_data_processing_approved",- "posthog_organization"."is_ai_training_opted_in",- "posthog_organization"."is_ai_training_locked",- "posthog_organization"."is_ai_training_cta_shown",- "posthog_organization"."enforce_2fa",- "posthog_organization"."enforce_verified_domains",- "posthog_organization"."members_can_invite",- "posthog_organization"."members_can_create_projects",- "posthog_organization"."members_can_use_personal_api_keys",- "posthog_organization"."members_can_see_org_members",- "posthog_organization"."uses_most_specific_access_resolution",- "posthog_organization"."allow_publicly_shared_resources",- "posthog_organization"."member_notice",- "posthog_organization"."read_only_mcp_access",- "posthog_organization"."default_role_id",- "posthog_organization"."plugins_access_level",- "posthog_organization"."for_internal_metrics",- "posthog_organization"."default_anonymize_ips",- "posthog_organization"."is_pending_deletion",- "posthog_organization"."customer_id",- "posthog_organization"."available_product_features",- "posthog_organization"."usage",- "posthog_organization"."never_drop_data",- "posthog_organization"."customer_trust_scores",- "posthog_organization"."has_active_subscription",- "posthog_organization"."setup_section_2_completed",- "posthog_organization"."personalization",- "posthog_organization"."domain_whitelist",- "posthog_organization"."is_platform"- FROM "posthog_organization"- WHERE "posthog_organization"."id" = '00000000-0000-0000-0000-000000000000'::uuid- LIMIT 21- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.182- '''- SELECT "posthog_team"."id",- "posthog_team"."uuid",- "posthog_team"."organization_id",- "posthog_team"."parent_team_id",- "posthog_team"."project_id",- "posthog_team"."api_token",- "posthog_team"."app_urls",- "posthog_team"."name",- "posthog_team"."slack_incoming_webhook",- "posthog_team"."created_at",- "posthog_team"."updated_at",- "posthog_team"."anonymize_ips",- "posthog_team"."completed_snippet_onboarding",- "posthog_team"."has_completed_onboarding_for",- "posthog_team"."onboarding_tasks",- "posthog_team"."ingested_event",- "posthog_team"."ingested_production_event",- "posthog_team"."ingested_production_event_last_checked_at",- "posthog_team"."person_processing_opt_out",- "posthog_team"."secret_api_token",- "posthog_team"."secret_api_token_backup",- "posthog_team"."session_recording_opt_in",- "posthog_team"."session_recording_sample_rate",- "posthog_team"."session_recording_minimum_duration_milliseconds",- "posthog_team"."session_recording_linked_flag",- "posthog_team"."session_recording_network_payload_capture_config",- "posthog_team"."session_recording_masking_config",- "posthog_team"."session_recording_url_trigger_config",- "posthog_team"."session_recording_url_blocklist_config",- "posthog_team"."session_recording_event_trigger_config",- "posthog_team"."session_recording_trigger_match_type_config",- "posthog_team"."session_recording_trigger_groups",- "posthog_team"."session_replay_config",- "posthog_team"."session_recording_retention_period",- "posthog_team"."event_retention_months",- "posthog_team"."conversations_enabled",- "posthog_team"."conversations_settings",- "posthog_team"."proactive_tasks_enabled",- "posthog_team"."survey_config",- "posthog_team"."surveys_opt_in",- "posthog_team"."product_tours_opt_in",- "posthog_team"."capture_console_log_opt_in",- "posthog_team"."capture_performance_opt_in",- "posthog_team"."capture_dead_clicks",- "posthog_team"."autocapture_opt_out",- "posthog_team"."autocapture_web_vitals_opt_in",- "posthog_team"."autocapture_web_vitals_allowed_metrics",- "posthog_team"."autocapture_exceptions_opt_in",- "posthog_team"."autocapture_exceptions_errors_to_ignore",- "posthog_team"."logs_settings",- "posthog_team"."llm_gateway_enabled_at",- "posthog_team"."llm_gateway_revoked_at",- "posthog_team"."llm_gateway_overspend_allowance_usd",- "posthog_team"."heatmaps_opt_in",- "posthog_team"."receive_org_level_activity_logs",- "posthog_team"."web_analytics_pre_aggregated_tables_enabled",- "posthog_team"."web_analytics_pre_aggregated_tables_version",- "posthog_team"."flags_persistence_default",- "posthog_team"."feature_flag_confirmation_enabled",- "posthog_team"."feature_flag_confirmation_message",- "posthog_team"."default_evaluation_environments_enabled",- "posthog_team"."require_evaluation_environment_tags",- "posthog_team"."default_evaluation_contexts_enabled",- "posthog_team"."require_evaluation_contexts",- "posthog_team"."session_recording_version",- "posthog_team"."signup_token",- "posthog_team"."is_demo",- "posthog_team"."access_control",- "posthog_team"."week_start_day",- "posthog_team"."inject_web_apps",- "posthog_team"."test_account_filters",- "posthog_team"."test_account_filters_default_checked",- "posthog_team"."path_cleaning_filters",- "posthog_team"."timezone",- "posthog_team"."data_attributes",- "posthog_team"."person_display_name_properties",- "posthog_team"."live_events_columns",- "posthog_team"."recording_domains",- "posthog_team"."human_friendly_comparison_periods",- "posthog_team"."cookieless_server_hash_mode",- "posthog_team"."primary_dashboard_id",- "posthog_team"."default_data_theme",- "posthog_team"."extra_settings",- "posthog_team"."modifiers",- "posthog_team"."session_recording_retention_period_days",- "posthog_team"."external_data_workspace_id",- "posthog_team"."external_data_workspace_last_synced_at",- "posthog_team"."api_query_rate_limit",- "posthog_team"."drop_events_older_than",- "posthog_team"."base_currency",- "posthog_team"."business_model",- "posthog_organization"."id",- "posthog_organization"."name",- "posthog_organization"."slug",- "posthog_organization"."logo_media_id",- "posthog_organization"."created_at",- "posthog_organization"."updated_at",- "posthog_organization"."is_active",- "posthog_organization"."is_not_active_reason",- "posthog_organization"."session_cookie_age",- "posthog_organization"."is_member_join_email_enabled",- "posthog_organization"."is_ai_data_processing_approved",- "posthog_organization"."is_ai_training_opted_in",- "posthog_organization"."is_ai_training_locked",- "posthog_organization"."is_ai_training_cta_shown",- "posthog_organization"."enforce_2fa",- "posthog_organization"."enforce_verified_domains",- "posthog_organization"."members_can_invite",- "posthog_organization"."members_can_create_projects",- "posthog_organization"."members_can_use_personal_api_keys",- "posthog_organization"."members_can_see_org_members",- "posthog_organization"."uses_most_specific_access_resolution",- "posthog_organization"."allow_publicly_shared_resources",- "posthog_organization"."member_notice",- "posthog_organization"."read_only_mcp_access",- "posthog_organization"."default_role_id",- "posthog_organization"."plugins_access_level",- "posthog_organization"."for_internal_metrics",- "posthog_organization"."default_anonymize_ips",- "posthog_organization"."is_pending_deletion",- "posthog_organization"."customer_id",- "posthog_organization"."available_product_features",- "posthog_organization"."usage",- "posthog_organization"."never_drop_data",- "posthog_organization"."customer_trust_scores",- "posthog_organization"."has_active_subscription",- "posthog_organization"."setup_section_2_completed",- "posthog_organization"."personalization",- "posthog_organization"."domain_whitelist",- "posthog_organization"."is_platform"- FROM "posthog_team"- INNER JOIN "posthog_organization" ON ("posthog_team"."organization_id" = "posthog_organization"."id")- WHERE "posthog_team"."id" = 99999- LIMIT 21- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.183- '''- SELECT "posthog_organizationmembership"."id",- "posthog_organizationmembership"."organization_id",- "posthog_organizationmembership"."user_id",- "posthog_organizationmembership"."level",- "posthog_organizationmembership"."joined_at",- "posthog_organizationmembership"."updated_at",- "posthog_organizationmembership"."invited_by_id",- "posthog_organization"."id",- "posthog_organization"."name",- "posthog_organization"."slug",- "posthog_organization"."logo_media_id",- "posthog_organization"."created_at",- "posthog_organization"."updated_at",- "posthog_organization"."is_active",- "posthog_organization"."is_not_active_reason",- "posthog_organization"."session_cookie_age",- "posthog_organization"."is_member_join_email_enabled",- "posthog_organization"."is_ai_data_processing_approved",- "posthog_organization"."is_ai_training_opted_in",- "posthog_organization"."is_ai_training_locked",- "posthog_organization"."is_ai_training_cta_shown",- "posthog_organization"."enforce_2fa",- "posthog_organization"."enforce_verified_domains",- "posthog_organization"."members_can_invite",- "posthog_organization"."members_can_create_projects",- "posthog_organization"."members_can_use_personal_api_keys",- "posthog_organization"."members_can_see_org_members",- "posthog_organization"."uses_most_specific_access_resolution",- "posthog_organization"."allow_publicly_shared_resources",- "posthog_organization"."member_notice",- "posthog_organization"."read_only_mcp_access",- "posthog_organization"."default_role_id",- "posthog_organization"."plugins_access_level",- "posthog_organization"."for_internal_metrics",- "posthog_organization"."default_anonymize_ips",- "posthog_organization"."is_pending_deletion",- "posthog_organization"."customer_id",- "posthog_organization"."available_product_features",- "posthog_organization"."usage",- "posthog_organization"."never_drop_data",- "posthog_organization"."customer_trust_scores",- "posthog_organization"."has_active_subscription",- "posthog_organization"."setup_section_2_completed",- "posthog_organization"."personalization",- "posthog_organization"."domain_whitelist",- "posthog_organization"."is_platform"- FROM "posthog_organizationmembership"- INNER JOIN "posthog_organization" ON ("posthog_organizationmembership"."organization_id" = "posthog_organization"."id")- WHERE ("posthog_organizationmembership"."organization_id" = '00000000-0000-0000-0000-000000000000'::uuid- AND "posthog_organizationmembership"."user_id" = 99999)- LIMIT 21- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.184- '''- SELECT "ee_accesscontrol"."id",- "ee_accesscontrol"."team_id",- "ee_accesscontrol"."access_level",- "ee_accesscontrol"."resource",- "ee_accesscontrol"."resource_id",- "ee_accesscontrol"."organization_member_id",- "ee_accesscontrol"."role_id",- "ee_accesscontrol"."created_by_id",- "ee_accesscontrol"."created_at",- "ee_accesscontrol"."updated_at"- FROM "ee_accesscontrol"- LEFT OUTER JOIN "posthog_organizationmembership" ON ("ee_accesscontrol"."organization_member_id" = "posthog_organizationmembership"."id")- WHERE (("ee_accesscontrol"."organization_member_id" IS NULL- AND "ee_accesscontrol"."role_id" IS NULL- AND "ee_accesscontrol"."team_id" = 99999)- OR ("posthog_organizationmembership"."organization_id" = '00000000-0000-0000-0000-000000000000'::uuid- AND "posthog_organizationmembership"."user_id" = 99999- AND "ee_accesscontrol"."role_id" IS NULL- AND "ee_accesscontrol"."team_id" = 99999))- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.185- '''- SELECT "posthog_organizationmembership"."id",- "posthog_organizationmembership"."organization_id",- "posthog_organizationmembership"."user_id",- "posthog_organizationmembership"."level",- "posthog_organizationmembership"."joined_at",- "posthog_organizationmembership"."updated_at",- "posthog_organizationmembership"."invited_by_id",- "posthog_organization"."id",- "posthog_organization"."name",- "posthog_organization"."slug",- "posthog_organization"."logo_media_id",- "posthog_organization"."created_at",- "posthog_organization"."updated_at",- "posthog_organization"."is_active",- "posthog_organization"."is_not_active_reason",- "posthog_organization"."session_cookie_age",- "posthog_organization"."is_member_join_email_enabled",- "posthog_organization"."is_ai_data_processing_approved",- "posthog_organization"."is_ai_training_opted_in",- "posthog_organization"."is_ai_training_locked",- "posthog_organization"."is_ai_training_cta_shown",- "posthog_organization"."enforce_2fa",- "posthog_organization"."enforce_verified_domains",- "posthog_organization"."members_can_invite",- "posthog_organization"."members_can_create_projects",- "posthog_organization"."members_can_use_personal_api_keys",- "posthog_organization"."members_can_see_org_members",- "posthog_organization"."uses_most_specific_access_resolution",- "posthog_organization"."allow_publicly_shared_resources",- "posthog_organization"."member_notice",- "posthog_organization"."read_only_mcp_access",- "posthog_organization"."default_role_id",- "posthog_organization"."plugins_access_level",- "posthog_organization"."for_internal_metrics",- "posthog_organization"."default_anonymize_ips",- "posthog_organization"."is_pending_deletion",- "posthog_organization"."customer_id",- "posthog_organization"."available_product_features",- "posthog_organization"."usage",- "posthog_organization"."never_drop_data",- "posthog_organization"."customer_trust_scores",- "posthog_organization"."has_active_subscription",- "posthog_organization"."setup_section_2_completed",- "posthog_organization"."personalization",- "posthog_organization"."domain_whitelist",- "posthog_organization"."is_platform"- FROM "posthog_organizationmembership"- INNER JOIN "posthog_organization" ON ("posthog_organizationmembership"."organization_id" = "posthog_organization"."id")- WHERE "posthog_organizationmembership"."user_id" = 99999- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.186- '''- SELECT COUNT(*) AS "__count"- FROM "posthog_dashboarditem"- INNER JOIN "posthog_team" ON ("posthog_dashboarditem"."team_id" = "posthog_team"."id")- WHERE ("posthog_team"."project_id" = 99999- AND NOT ("posthog_dashboarditem"."deleted"))- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.187- '''- SELECT "posthog_dashboarditem"."id",- "posthog_dashboarditem"."name",- "posthog_dashboarditem"."derived_name",- "posthog_dashboarditem"."description",- "posthog_dashboarditem"."team_id",- "posthog_dashboarditem"."filters",- "posthog_dashboarditem"."filters_hash",- "posthog_dashboarditem"."query",- "posthog_dashboarditem"."query_metadata",- "posthog_dashboarditem"."order",- "posthog_dashboarditem"."deleted",- "posthog_dashboarditem"."saved",- "posthog_dashboarditem"."created_at",- "posthog_dashboarditem"."refreshing",- "posthog_dashboarditem"."created_by_id",- "posthog_dashboarditem"."is_sample",- "posthog_dashboarditem"."short_id",- "posthog_dashboarditem"."favorited",- "posthog_dashboarditem"."refresh_attempt",- "posthog_dashboarditem"."last_modified_at",- "posthog_dashboarditem"."last_modified_by_id",- "posthog_dashboarditem"."dashboard_id",- "posthog_dashboarditem"."last_refresh",- "posthog_dashboarditem"."layouts",- "posthog_dashboarditem"."color",- "posthog_dashboarditem"."dive_dashboard_id",- "posthog_dashboarditem"."updated_at",- "posthog_dashboarditem"."deprecated_tags",- "posthog_dashboarditem"."tags",-- (SELECT "U0"."last_viewed_at" AS "last_viewed_at"- FROM "posthog_insightviewed" "U0"- WHERE "U0"."insight_id" = ("posthog_dashboarditem"."id")- ORDER BY 1 DESC- LIMIT 1) AS "last_viewed_at",- "posthog_team"."id",- "posthog_team"."uuid",- "posthog_team"."organization_id",- "posthog_team"."parent_team_id",- "posthog_team"."project_id",- "posthog_team"."api_token",- "posthog_team"."app_urls",- "posthog_team"."name",- "posthog_team"."slack_incoming_webhook",- "posthog_team"."created_at",- "posthog_team"."updated_at",- "posthog_team"."anonymize_ips",- "posthog_team"."completed_snippet_onboarding",- "posthog_team"."has_completed_onboarding_for",- "posthog_team"."onboarding_tasks",- "posthog_team"."ingested_event",- "posthog_team"."ingested_production_event",- "posthog_team"."ingested_production_event_last_checked_at",- "posthog_team"."person_processing_opt_out",- "posthog_team"."secret_api_token",- "posthog_team"."secret_api_token_backup",- "posthog_team"."session_recording_opt_in",- "posthog_team"."session_recording_sample_rate",- "posthog_team"."session_recording_minimum_duration_milliseconds",- "posthog_team"."session_recording_linked_flag",- "posthog_team"."session_recording_network_payload_capture_config",- "posthog_team"."session_recording_masking_config",- "posthog_team"."session_recording_url_trigger_config",- "posthog_team"."session_recording_url_blocklist_config",- "posthog_team"."session_recording_event_trigger_config",- "posthog_team"."session_recording_trigger_match_type_config",- "posthog_team"."session_recording_trigger_groups",- "posthog_team"."session_replay_config",- "posthog_team"."session_recording_retention_period",- "posthog_team"."event_retention_months",- "posthog_team"."conversations_enabled",- "posthog_team"."conversations_settings",- "posthog_team"."proactive_tasks_enabled",- "posthog_team"."survey_config",- "posthog_team"."surveys_opt_in",- "posthog_team"."product_tours_opt_in",- "posthog_team"."capture_console_log_opt_in",- "posthog_team"."capture_performance_opt_in",- "posthog_team"."capture_dead_clicks",- "posthog_team"."autocapture_opt_out",- "posthog_team"."autocapture_web_vitals_opt_in",- "posthog_team"."autocapture_web_vitals_allowed_metrics",- "posthog_team"."autocapture_exceptions_opt_in",- "posthog_team"."autocapture_exceptions_errors_to_ignore",- "posthog_team"."logs_settings",- "posthog_team"."llm_gateway_enabled_at",- "posthog_team"."llm_gateway_revoked_at",- "posthog_team"."llm_gateway_overspend_allowance_usd",- "posthog_team"."heatmaps_opt_in",- "posthog_team"."receive_org_level_activity_logs",- "posthog_team"."web_analytics_pre_aggregated_tables_enabled",- "posthog_team"."web_analytics_pre_aggregated_tables_version",- "posthog_team"."flags_persistence_default",- "posthog_team"."feature_flag_confirmation_enabled",- "posthog_team"."feature_flag_confirmation_message",- "posthog_team"."default_evaluation_environments_enabled",- "posthog_team"."require_evaluation_environment_tags",- "posthog_team"."default_evaluation_contexts_enabled",- "posthog_team"."require_evaluation_contexts",- "posthog_team"."session_recording_version",- "posthog_team"."signup_token",- "posthog_team"."is_demo",- "posthog_team"."access_control",- "posthog_team"."week_start_day",- "posthog_team"."inject_web_apps",- "posthog_team"."test_account_filters",- "posthog_team"."test_account_filters_default_checked",- "posthog_team"."path_cleaning_filters",- "posthog_team"."timezone",- "posthog_team"."data_attributes",- "posthog_team"."person_display_name_properties",- "posthog_team"."live_events_columns",- "posthog_team"."recording_domains",- "posthog_team"."human_friendly_comparison_periods",- "posthog_team"."cookieless_server_hash_mode",- "posthog_team"."primary_dashboard_id",- "posthog_team"."default_data_theme",- "posthog_team"."extra_settings",- "posthog_team"."modifiers",- "posthog_team"."session_recording_retention_period_days",- "posthog_team"."plugins_opt_in",- "posthog_team"."opt_out_capture",- "posthog_team"."event_names",- "posthog_team"."event_names_with_usage",- "posthog_team"."event_properties",- "posthog_team"."event_properties_with_usage",- "posthog_team"."event_properties_numerical",- "posthog_team"."external_data_workspace_id",- "posthog_team"."external_data_workspace_last_synced_at",- "posthog_team"."api_query_rate_limit",- "posthog_team"."revenue_tracking_config",- "posthog_team"."drop_events_older_than",- "posthog_team"."base_currency",- "posthog_team"."business_model",- "posthog_user"."id",- "posthog_user"."password",- "posthog_user"."last_login",- "posthog_user"."first_name",- "posthog_user"."last_name",- "posthog_user"."is_staff",- "posthog_user"."date_joined",- "posthog_user"."uuid",- "posthog_user"."current_organization_id",- "posthog_user"."current_team_id",- "posthog_user"."email",- "posthog_user"."pending_email",- "posthog_user"."distinct_id",- "posthog_user"."is_email_verified",- "posthog_user"."credentials_reviewed_at",- "posthog_user"."requested_password_reset_at",- "posthog_user"."requested_2fa_reset_at",- "posthog_user"."has_seen_product_intro_for",- "posthog_user"."strapi_id",- "posthog_user"."is_active",- "posthog_user"."role_at_organization",- "posthog_user"."theme_mode",- "posthog_user"."partial_notification_settings",- "posthog_user"."anonymize_data",- "posthog_user"."allow_impersonation",- "posthog_user"."toolbar_mode",- "posthog_user"."hedgehog_config",- "posthog_user"."allow_sidebar_suggestions",- "posthog_user"."shortcut_position",- "posthog_user"."passkeys_enabled_for_2fa",- "posthog_user"."hide_mcp_hints",- "posthog_user"."ui_configuration",- "posthog_user"."onboarding_skipped_at",- "posthog_user"."onboarding_skipped_reason",- "posthog_user"."onboarding_skipped_organization_id",- "posthog_user"."onboarding_delegated_to_invite_id",- "posthog_user"."onboarding_delegated_to_organization_id",- "posthog_user"."onboarding_delegation_accepted_at",- "posthog_user"."events_column_config",- "posthog_user"."email_opt_in"- FROM "posthog_dashboarditem"- INNER JOIN "posthog_team" ON ("posthog_dashboarditem"."team_id" = "posthog_team"."id")- LEFT OUTER JOIN "posthog_user" ON ("posthog_dashboarditem"."created_by_id" = "posthog_user"."id")- WHERE ("posthog_team"."project_id" = 99999- AND NOT ("posthog_dashboarditem"."deleted"))- ORDER BY "posthog_dashboarditem"."last_modified_at" DESC,- "posthog_dashboarditem"."id" DESC- LIMIT 100- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.188- '''- SELECT "posthog_dashboardtile"."id",- "posthog_dashboardtile"."dashboard_id",- "posthog_dashboardtile"."insight_id",- "posthog_dashboardtile"."deleted"- FROM "posthog_dashboardtile"- INNER JOIN "posthog_dashboard" ON ("posthog_dashboardtile"."dashboard_id" = "posthog_dashboard"."id")- WHERE (NOT ("posthog_dashboardtile"."deleted"- AND "posthog_dashboardtile"."deleted" IS NOT NULL)- AND NOT ("posthog_dashboard"."deleted")- AND "posthog_dashboardtile"."insight_id" IN (1,- 2,- 3,- 4,- 5 /* ... */))- '''-# ----# name: TestInsight.test_listing_insights_does_not_nplus1.189- '''- SELECT "posthog_taggeditem"."id",- "posthog_taggeditem"."tag_id",- "posthog_taggeditem"."content_type_id",- "posthog_taggeditem"."object_id",- "posthog_taggeditem"."object_uuid",- "posthog_taggeditem"."team_id"- FROM "posthog_taggeditem"- WHERE ("posthog_taggeditem"."content_type_id" = 99999- AND "posthog_taggeditem"."object_id" IN (1,- 2,- 3,- 4,- 5 /* ... */))- '''-# ---# name: TestInsight.test_listing_insights_does_not_nplus1.19'''SELECT "posthog_dashboardtile"."id",@@ -4542,27 +3997,6 @@AND "posthog_dashboardtile"."insight_id" = 99999)'''# ----# name: TestInsight.test_listing_insights_does_not_nplus1.190- '''- SELECT "posthog_taggeditem"."id",- "posthog_taggeditem"."tag_id",- "posthog_taggeditem"."content_type_id",- "posthog_taggeditem"."object_id",- "posthog_taggeditem"."object_uuid",- "posthog_taggeditem"."team_id",- "posthog_tag"."id",- "posthog_tag"."name",- "posthog_tag"."team_id"- FROM "posthog_taggeditem"- INNER JOIN "posthog_tag" ON ("posthog_taggeditem"."tag_id" = "posthog_tag"."id")- WHERE ("posthog_taggeditem"."content_type_id" = 99999- AND "posthog_taggeditem"."object_id" IN (1,- 2,- 3,- 4,- 5 /* ... */))- '''-# ---# name: TestInsight.test_listing_insights_does_not_nplus1.2'''SELECT "posthog_team"."id" AS "id"diff --git a/products/product_analytics/frontend/insights/InsightNav/insightNavLogic.tsx b/products/product_analytics/frontend/insights/InsightNav/insightNavLogic.tsxindex e6b9261c88cf..f9a0df1f2058 100644--- a/products/product_analytics/frontend/insights/InsightNav/insightNavLogic.tsx+++ b/products/product_analytics/frontend/insights/InsightNav/insightNavLogic.tsx@@ -2,6 +2,7 @@ import { MakeLogicType, actions, afterMount, connect, kea, key, listeners, path,import { router } from 'kea-router'import { FEATURE_FLAGS } from 'lib/constants'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { LemonTag } from 'lib/lemon-ui/LemonTag'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import type { FeatureFlagsSet } from 'lib/logic/featureFlagLogic'@@ -14,7 +15,6 @@ import {withFlagCallsAggregationTarget,} from 'scenes/insights/filters/ActionFilter/flagCallsSeries'import { insightDataLogic } from 'scenes/insights/insightDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { filterTestAccountsDefaultsLogic } from 'scenes/settings/environment/filterTestAccountDefaultsLogic'import { urls } from 'scenes/urls'diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.ts b/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.tsindex dc3e15792fb2..17df19e7d66a 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.ts+++ b/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.ts@@ -8,11 +8,11 @@ import {} from 'lib/components/ChartFilter/chartDisplayOptions'import type { ChartDisplayOption, ChartDisplayOptionGroup } from 'lib/components/ChartFilter/chartDisplayOptions'import { FEATURE_FLAGS } from 'lib/constants'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import { insightDataLogic } from 'scenes/insights/insightDataLogic'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { isBoxPlotMissingProperty } from 'scenes/insights/utils/queryUtils'import type { FeatureFlagsSet } from '~/lib/logic/featureFlagLogic'diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.ts b/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.tsindex 493b3c6a4226..1e0143dfadec 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.ts+++ b/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.ts@@ -3,8 +3,8 @@ import posthog from 'posthog-js'import { applyChartDisplay } from 'lib/components/ChartFilter/chartDisplayOptions'import type { ChartDisplayOption, ChartDisplayOptionGroup } from 'lib/components/ChartFilter/chartDisplayOptions'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import type { AnyResponseType, InsightVizNode, TrendsQuery } from '~/queries/schema/schema-general'import { NodeKind } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/dataChecks/insightDataChecksLogic.ts b/products/product_analytics/frontend/insights/dataChecks/insightDataChecksLogic.tsindex 6c03cb8b242c..404af159828d 100644--- a/products/product_analytics/frontend/insights/dataChecks/insightDataChecksLogic.ts+++ b/products/product_analytics/frontend/insights/dataChecks/insightDataChecksLogic.ts@@ -6,6 +6,7 @@ import posthog from 'posthog-js'import { ApiError } from 'lib/api-error'import { FEATURE_FLAGS } from 'lib/constants'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import type { FeatureFlagsSet } from 'lib/logic/featureFlagLogic'import { uuid } from 'lib/utils/dom'@@ -14,7 +15,6 @@ import { objectsEqual } from 'lib/utils/objects'import { insightDataLogic } from 'scenes/insights/insightDataLogic'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { autoRunMaxPrompt } from 'scenes/max/maxPrompt'import { teamLogic } from 'scenes/teamLogic'diff --git a/products/product_analytics/frontend/insights/editor/EditorFiltersShell.tsx b/products/product_analytics/frontend/insights/editor/EditorFiltersShell.tsxindex c4fb48b5b024..74890e871577 100644--- a/products/product_analytics/frontend/insights/editor/EditorFiltersShell.tsx+++ b/products/product_analytics/frontend/insights/editor/EditorFiltersShell.tsx@@ -2,11 +2,11 @@ import clsx from 'clsx'import { useActions, useValues } from 'kea'import { useMemo, useRef } from 'react'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { Resizer } from 'lib/lemon-ui/Resizer/Resizer'import { resizerLogic } from 'lib/lemon-ui/Resizer/resizerLogic'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import MaxTool from 'scenes/max/MaxTool'import { castAssistantQuery } from 'scenes/max/utils'import { QUERY_TYPES_METADATA } from 'scenes/saved-insights/insightTypesMetadata'diff --git a/products/product_analytics/frontend/insights/editor/GlobalAndOrFilters.tsx b/products/product_analytics/frontend/insights/editor/GlobalAndOrFilters.tsxindex d10362e07ce9..7f3b0f68d9b9 100644--- a/products/product_analytics/frontend/insights/editor/GlobalAndOrFilters.tsx+++ b/products/product_analytics/frontend/insights/editor/GlobalAndOrFilters.tsx@@ -1,8 +1,8 @@import { useActions, useValues } from 'kea'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { getProjectEventExistence } from 'lib/utils/getAppContext'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { actionsModel } from '~/models/actionsModel'import { groupsModel } from '~/models/groupsModel'diff --git a/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.tsx b/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.tsxindex c5796e0ae81b..060972efc622 100644--- a/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.tsx+++ b/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.tsx@@ -12,8 +12,8 @@ import { PropertyFilters } from 'lib/components/PropertyFilters/PropertyFilters'import { inlineEquivalentPropertyGroups, isPropertyGroupFilterLike } from 'lib/components/PropertyFilters/utils'import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'import { FEATURE_FLAGS } from 'lib/constants'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { AndOrFilterSelect } from '~/queries/nodes/InsightViz/PropertyGroupFilters/AndOrFilterSelect'import { InsightQueryNode, ProductAnalyticsInsightQueryNode } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/editor/TrendsSeries.tsx b/products/product_analytics/frontend/insights/editor/TrendsSeries.tsxindex 3e6170f0ca0f..07a289714729 100644--- a/products/product_analytics/frontend/insights/editor/TrendsSeries.tsx+++ b/products/product_analytics/frontend/insights/editor/TrendsSeries.tsx@@ -4,12 +4,12 @@ import { LemonSwitch } from '@posthog/lemon-ui'import { DataWarehousePopoverField, TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'import { DISPLAY_TYPES_TO_CATEGORIES, SINGLE_SERIES_DISPLAY_TYPES } from 'lib/constants'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { getProjectEventExistence } from 'lib/utils/getAppContext'import { alphabet } from 'lib/utils/strings'import { SeriesActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFilter'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { groupsModel } from '~/models/groupsModel'import { NodeKind } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/breakdownTagLogic.ts b/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/breakdownTagLogic.tsindex 6ff45784b6fe..df75a4f2f805 100644--- a/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/breakdownTagLogic.ts+++ b/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/breakdownTagLogic.ts@@ -7,7 +7,7 @@ import {} from 'lib/components/PropertyFilters/utils'import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'import type { TaxonomicFilterValue } from 'lib/components/TaxonomicFilter/types'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { teamLogic } from 'scenes/teamLogic'import { userLogic } from 'scenes/userLogic'diff --git a/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/taxonomicBreakdownFilterLogic.ts b/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/taxonomicBreakdownFilterLogic.tsindex 5110a747f475..a0cfa498d018 100644--- a/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/taxonomicBreakdownFilterLogic.ts+++ b/products/product_analytics/frontend/insights/editor/filters/BreakdownFilter/taxonomicBreakdownFilterLogic.ts@@ -10,11 +10,11 @@ import {TaxonomicFilterGroupType,TaxonomicFilterValue,} from 'lib/components/TaxonomicFilter/types'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import type { FeatureFlagsSet } from 'lib/logic/featureFlagLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { propertyDefinitionsModel } from '~/models/propertyDefinitionsModel'import { Breakdown, BreakdownFilter } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/editor/filters/goalLinesLogic.ts b/products/product_analytics/frontend/insights/editor/filters/goalLinesLogic.tsindex 7d327a085b5e..259b68da627e 100644--- a/products/product_analytics/frontend/insights/editor/filters/goalLinesLogic.ts+++ b/products/product_analytics/frontend/insights/editor/filters/goalLinesLogic.ts@@ -1,9 +1,9 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers } from 'kea'import { subscriptions } from 'kea-subscriptions'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import {FunnelsQuery,diff --git a/products/product_analytics/frontend/insights/editor/filters/poeFilterLogic.ts b/products/product_analytics/frontend/insights/editor/filters/poeFilterLogic.tsindex b7cf317c1a6f..68ba8726bc4f 100644--- a/products/product_analytics/frontend/insights/editor/filters/poeFilterLogic.ts+++ b/products/product_analytics/frontend/insights/editor/filters/poeFilterLogic.ts@@ -1,9 +1,9 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers } from 'kea'import { subscriptions } from 'kea-subscriptions'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { HogQLQueryModifiers } from '~/queries/schema/schema-general'import type {diff --git a/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelFlowGraphLogic.ts b/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelFlowGraphLogic.tsindex f7937d934b7d..2344adac7c75 100644--- a/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelFlowGraphLogic.ts+++ b/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelFlowGraphLogic.ts@@ -4,7 +4,7 @@ import { MakeLogicType, actions, connect, kea, key, path, props, reducers, selecimport { subscriptions } from 'kea-subscriptions'import { getElk } from 'lib/elk'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import type { PathsLink } from '~/queries/schema/schema-general'import { InsightLogicProps } from '~/types'diff --git a/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelPathsExpansionLogic.ts b/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelPathsExpansionLogic.tsindex 0f56b021704d..a6880cf201c1 100644--- a/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelPathsExpansionLogic.ts+++ b/products/product_analytics/frontend/insights/funnels/FunnelFlowGraph/funnelPathsExpansionLogic.ts@@ -3,7 +3,7 @@ import posthog from 'posthog-js'import { lemonToast } from '@posthog/lemon-ui'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { performQuery } from '~/queries/query'import { PathsLink, PathsQuery } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsx b/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsxindex 9058ada23e1b..c35a1c90312f 100644--- a/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsx+++ b/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsx@@ -3,10 +3,10 @@ import './FunnelsQuerySteps.scss'import { useActions, useValues } from 'kea'import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { getProjectEventExistence } from 'lib/utils/getAppContext'import { SeriesActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFilter'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { groupsModel } from '~/models/groupsModel'import { NodeKind } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/funnels/filters/FunnelExclusionsFilter/FunnelExclusionsFilter.tsx b/products/product_analytics/frontend/insights/funnels/filters/FunnelExclusionsFilter/FunnelExclusionsFilter.tsxindex 8c10dc9b4315..9d2c84667f78 100644--- a/products/product_analytics/frontend/insights/funnels/filters/FunnelExclusionsFilter/FunnelExclusionsFilter.tsx+++ b/products/product_analytics/frontend/insights/funnels/filters/FunnelExclusionsFilter/FunnelExclusionsFilter.tsx@@ -2,10 +2,10 @@ import { useActions, useValues } from 'kea'import { useRef } from 'react'import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { SeriesActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFilter'import { MathAvailability } from 'scenes/insights/filters/ActionFilter/ActionFilterRow/types'import { insightLogic } from 'scenes/insights/insightLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { funnelDataLogic } from 'products/product_analytics/frontend/insights/funnels/funnelDataLogic'diff --git a/products/product_analytics/frontend/insights/funnels/funnelDataLogic.ts b/products/product_analytics/frontend/insights/funnels/funnelDataLogic.tsindex aa5bee068042..a52d79eba39a 100644--- a/products/product_analytics/frontend/insights/funnels/funnelDataLogic.ts+++ b/products/product_analytics/frontend/insights/funnels/funnelDataLogic.ts@@ -4,6 +4,7 @@ import { DataColorTheme, DataColorToken } from 'lib/colors'import { BIN_COUNT_AUTO } from 'lib/constants'import { dayjs } from 'lib/dayjs'import { formatEventName } from 'lib/insights/entityFilterNames'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import type { FeatureFlagsSet } from 'lib/logic/featureFlagLogic'import { average, percentage, sum } from 'lib/utils/numbers'@@ -22,7 +23,6 @@ import type { SeriesNode } from 'scenes/insights/filters/ActionFilter/seriesNodeimport { insightDataLogic } from 'scenes/insights/insightDataLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import {getFunnelDatasetKey,getFunnelDatasetPosition,diff --git a/products/product_analytics/frontend/insights/funnels/funnelPersonsModalLogic.ts b/products/product_analytics/frontend/insights/funnels/funnelPersonsModalLogic.tsindex e69940b7232d..8cf65c8f07cb 100644--- a/products/product_analytics/frontend/insights/funnels/funnelPersonsModalLogic.ts+++ b/products/product_analytics/frontend/insights/funnels/funnelPersonsModalLogic.ts@@ -1,7 +1,7 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, selectors } from 'kea'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightLogic } from 'scenes/insights/insightLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { funnelTitle } from 'scenes/trends/persons-modal/persons-modal-utils'import { openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'diff --git a/products/product_analytics/frontend/insights/insightScene/banners/insightRetentionBannerLogic.ts b/products/product_analytics/frontend/insights/insightScene/banners/insightRetentionBannerLogic.tsindex 947f59e822ee..be106a2a648a 100644--- a/products/product_analytics/frontend/insights/insightScene/banners/insightRetentionBannerLogic.ts+++ b/products/product_analytics/frontend/insights/insightScene/banners/insightRetentionBannerLogic.ts@@ -1,8 +1,8 @@import { MakeLogicType, connect, kea, key, path, props, selectors } from 'kea'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightDataLogic } from 'scenes/insights/insightDataLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import type { DateRange, Node } from '~/queries/schema/schema-general'import { InsightLogicProps } from '~/types'diff --git a/products/product_analytics/frontend/insights/insightScene/insightModalsLogic.ts b/products/product_analytics/frontend/insights/insightScene/insightModalsLogic.tsindex 0b8d5a53d96f..035a50de9426 100644--- a/products/product_analytics/frontend/insights/insightScene/insightModalsLogic.ts+++ b/products/product_analytics/frontend/insights/insightScene/insightModalsLogic.ts@@ -1,7 +1,7 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers } from 'kea'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightLogic } from 'scenes/insights/insightLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { InsightLogicProps } from '~/types'diff --git a/products/product_analytics/frontend/insights/journeys/journeysDataLogic.ts b/products/product_analytics/frontend/insights/journeys/journeysDataLogic.tsindex 82e6ecffdb0b..f454e6a0ec79 100644--- a/products/product_analytics/frontend/insights/journeys/journeysDataLogic.ts+++ b/products/product_analytics/frontend/insights/journeys/journeysDataLogic.ts@@ -3,10 +3,10 @@ import type { ReactNode } from 'react'import { ApiConfig } from 'lib/api'import type { DataColorTheme } from 'lib/colors'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { newInternalTab } from 'lib/utils/newInternalTab'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'import { urls } from 'scenes/urls'diff --git a/products/product_analytics/frontend/insights/paths/editor/PathsExclusions.tsx b/products/product_analytics/frontend/insights/paths/editor/PathsExclusions.tsxindex 3c5434c56df5..ab17d1133768 100644--- a/products/product_analytics/frontend/insights/paths/editor/PathsExclusions.tsx+++ b/products/product_analytics/frontend/insights/paths/editor/PathsExclusions.tsx@@ -1,7 +1,7 @@import { useActions, useValues } from 'kea'import { PathItemFilters } from 'lib/components/PropertyFilters/PathItemFilters'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { EditorFilterProps, EventPropertyFilter, PropertyFilterType, PropertyOperator } from '~/types'diff --git a/products/product_analytics/frontend/insights/paths/pathsDataLogic.ts b/products/product_analytics/frontend/insights/paths/pathsDataLogic.tsindex 7871b13cdc78..b25439aa27d3 100644--- a/products/product_analytics/frontend/insights/paths/pathsDataLogic.ts+++ b/products/product_analytics/frontend/insights/paths/pathsDataLogic.ts@@ -2,12 +2,12 @@ import { MakeLogicType, actions, connect, kea, key, listeners, path, props, seleimport type { DataColorTheme } from 'lib/colors'import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import type { FeatureFlagsSet } from 'lib/logic/featureFlagLogic'import { newInternalTab } from 'lib/utils/newInternalTab'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { pathsTitle } from 'scenes/trends/persons-modal/persons-modal-utils'import { OpenPersonsModalProps, openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'import { urls } from 'scenes/urls'diff --git a/products/product_analytics/frontend/insights/paths/pathsInteractionLogic.ts b/products/product_analytics/frontend/insights/paths/pathsInteractionLogic.tsindex 6959aa336f3d..d60f9aa5083e 100644--- a/products/product_analytics/frontend/insights/paths/pathsInteractionLogic.ts+++ b/products/product_analytics/frontend/insights/paths/pathsInteractionLogic.ts@@ -1,6 +1,6 @@import { MakeLogicType, actions, kea, key, listeners, path, props, reducers, selectors } from 'kea'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { InsightLogicProps } from '~/types'diff --git a/products/product_analytics/frontend/insights/retention/RetentionHeatmap/retentionHeatmapLogic.ts b/products/product_analytics/frontend/insights/retention/RetentionHeatmap/retentionHeatmapLogic.tsindex b71410b19bea..3102586187b6 100644--- a/products/product_analytics/frontend/insights/retention/RetentionHeatmap/retentionHeatmapLogic.ts+++ b/products/product_analytics/frontend/insights/retention/RetentionHeatmap/retentionHeatmapLogic.ts@@ -1,9 +1,9 @@import { MakeLogicType, actions, afterMount, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'import type { DataColorTheme } from 'lib/colors'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { capitalizeFirstLetter } from 'lib/utils/strings'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { InsightQueryNode } from '~/queries/schema/schema-general'import type { DataNode, DateRange, RetentionFilter, VizSpecificOptions } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsx b/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsxindex fc6fc1246b1e..b6e07be0e49e 100644--- a/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsx+++ b/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsx@@ -6,11 +6,11 @@ import { IconInfo, IconPlusSmall, IconTrash } from '@posthog/icons'import { LemonButton, LemonCheckbox, LemonInput, LemonSelect } from '@posthog/lemon-ui'import { DataWarehousePopoverField, TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { Tooltip } from 'lib/lemon-ui/Tooltip'import { getOrdinalSuffix } from 'lib/utils/strings'import { ActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFilter'import { MathAvailability } from 'scenes/insights/filters/ActionFilter/ActionFilterRow/types'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { groupsModel } from '~/models/groupsModel'import { EditorFilterProps, EntityTypes, FilterType, RetentionPeriod, RetentionType } from '~/types'diff --git a/products/product_analytics/frontend/insights/retention/retentionGraphLogic.ts b/products/product_analytics/frontend/insights/retention/retentionGraphLogic.tsindex 21a206133299..02097fcb5c91 100644--- a/products/product_analytics/frontend/insights/retention/retentionGraphLogic.ts+++ b/products/product_analytics/frontend/insights/retention/retentionGraphLogic.ts@@ -1,8 +1,8 @@import { MakeLogicType, connect, kea, key, path, props, selectors } from 'kea'import { dayjs } from 'lib/dayjs'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { teamLogic } from 'scenes/teamLogic'import { DateRange, RetentionFilter, RetentionQuery } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/retention/retentionLogic.ts b/products/product_analytics/frontend/insights/retention/retentionLogic.tsindex 5a3161a445cf..10ccdf85832a 100644--- a/products/product_analytics/frontend/insights/retention/retentionLogic.ts+++ b/products/product_analytics/frontend/insights/retention/retentionLogic.ts@@ -4,6 +4,7 @@ import { MakeLogicType, actions, connect, events, kea, key, listeners, path, proimport { DataColorTheme, DataColorToken } from 'lib/colors'import { CUSTOM_OPTION_KEY } from 'lib/components/DateFilter/types'import { dayjs } from 'lib/dayjs'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { formatDateRange } from 'lib/utils/datetime'import {BreakdownColorConfig,@@ -15,7 +16,6 @@ import { dashboardLogic } from 'scenes/dashboard/dashboardLogic'import { getColorFromToken } from 'scenes/dataThemeLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { BREAKDOWN_OTHER_DISPLAY, BREAKDOWN_OTHER_STRING_LABEL, formatBreakdownLabel } from 'scenes/insights/utils'import { teamLogic } from 'scenes/teamLogic'diff --git a/products/product_analytics/frontend/insights/retention/retentionModalLogic.ts b/products/product_analytics/frontend/insights/retention/retentionModalLogic.tsindex c317d879db0e..1e5fa3502f90 100644--- a/products/product_analytics/frontend/insights/retention/retentionModalLogic.ts+++ b/products/product_analytics/frontend/insights/retention/retentionModalLogic.ts@@ -4,11 +4,11 @@ import { subscriptions } from 'kea-subscriptions'import api from 'lib/api'import type { DataColorTheme } from 'lib/colors'import { consumePersonsModalClick } from 'lib/components/ResultMenu/personsModalCapture'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import type { FeatureFlagsSet } from 'lib/logic/featureFlagLogic'import { cohortSavedToast } from 'scenes/cohorts/cohortSavedToast'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { urls } from 'scenes/urls'import { cohortsModel } from '~/models/cohortsModel'diff --git a/products/product_analytics/frontend/insights/retention/retentionPeopleLogic.ts b/products/product_analytics/frontend/insights/retention/retentionPeopleLogic.tsindex a80452a31578..bf3e1cbf1c0b 100644--- a/products/product_analytics/frontend/insights/retention/retentionPeopleLogic.ts+++ b/products/product_analytics/frontend/insights/retention/retentionPeopleLogic.ts@@ -2,8 +2,8 @@ import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reduimport { loaders } from 'kea-loaders'import api from 'lib/api'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { NodeKind, RetentionQuery } from '~/queries/schema/schema-general'import type {diff --git a/products/product_analytics/frontend/insights/shared/BoldNumber/BoldNumber.tsx b/products/product_analytics/frontend/insights/shared/BoldNumber/BoldNumber.tsxindex bafb159100bb..a08d718c4eaf 100644--- a/products/product_analytics/frontend/insights/shared/BoldNumber/BoldNumber.tsx+++ b/products/product_analytics/frontend/insights/shared/BoldNumber/BoldNumber.tsx@@ -9,9 +9,9 @@ import React from 'react'import { IconTrending } from '@posthog/icons'import { LemonRow, Link } from '@posthog/lemon-ui'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { IconFlare, IconTrendingDown, IconTrendingFlat } from 'lib/lemon-ui/icons'import { percentage } from 'lib/utils/numbers'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { InsightEmptyState } from 'scenes/insights/EmptyStates'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'diff --git a/products/product_analytics/frontend/insights/shared/InsightSeriesTooltip.tsx b/products/product_analytics/frontend/insights/shared/InsightSeriesTooltip.tsxindex 64cb407c601c..27d4bb4ceadb 100644--- a/products/product_analytics/frontend/insights/shared/InsightSeriesTooltip.tsx+++ b/products/product_analytics/frontend/insights/shared/InsightSeriesTooltip.tsx@@ -4,11 +4,11 @@ import { useCallback, useMemo } from 'react'import { DefaultTooltip, type TooltipContext } from '@posthog/quill-charts'import { SeriesGlyph } from 'lib/components/SeriesGlyph'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { parseDateInTimezone } from 'lib/utils/datetime'import { percentage } from 'lib/utils/numbers'import { alphabet } from 'lib/utils/strings'import { shortTimeZone } from 'lib/utils/timezones'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { formatAggregationValue } from 'scenes/insights/utils'import type { ResultSeries } from 'scenes/insights/utils/resultSeries'import { teamLogic } from 'scenes/teamLogic'diff --git a/products/product_analytics/frontend/insights/shared/InsightsTable/InsightsTable.tsx b/products/product_analytics/frontend/insights/shared/InsightsTable/InsightsTable.tsxindex b429b7df0249..dfef485e714f 100644--- a/products/product_analytics/frontend/insights/shared/InsightsTable/InsightsTable.tsx+++ b/products/product_analytics/frontend/insights/shared/InsightsTable/InsightsTable.tsx@@ -4,11 +4,11 @@ import { useActions, useValues } from 'kea'import { compare as compareFn } from 'natural-orderby'import { ReactNode, useCallback, useMemo, useState } from 'react'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { LemonButton } from 'lib/lemon-ui/LemonButton'import { LemonTable, LemonTableColumn } from 'lib/lemon-ui/LemonTable'import { COUNTRY_CODE_TO_LONG_NAME } from 'lib/utils/country'import { percentage } from 'lib/utils/numbers'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { entityFilterLogic } from 'scenes/insights/filters/ActionFilter/entityFilterLogic'import { insightLogic } from 'scenes/insights/insightLogic'import { formatBreakdownLabel } from 'scenes/insights/utils'diff --git a/products/product_analytics/frontend/insights/shared/InsightsTable/columns/AggregationColumn.tsx b/products/product_analytics/frontend/insights/shared/InsightsTable/columns/AggregationColumn.tsxindex 19d57b4b2ae1..caf5378c25f5 100644--- a/products/product_analytics/frontend/insights/shared/InsightsTable/columns/AggregationColumn.tsx+++ b/products/product_analytics/frontend/insights/shared/InsightsTable/columns/AggregationColumn.tsx@@ -6,8 +6,8 @@ import { ReactNode } from 'react'import { IconChevronDown } from '@posthog/icons'import { LemonMenu, LemonMenuItem } from '@posthog/lemon-ui'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { eventUsageLogic } from 'lib/utils/eventUsageLogic'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { formatAggregationValue } from 'scenes/insights/utils'import { teamLogic } from 'scenes/teamLogic'diff --git a/products/product_analytics/frontend/insights/shared/InsightsTable/insightsTableDataLogic.ts b/products/product_analytics/frontend/insights/shared/InsightsTable/insightsTableDataLogic.tsindex f4cf1177570b..a0ac1d54bae5 100644--- a/products/product_analytics/frontend/insights/shared/InsightsTable/insightsTableDataLogic.ts+++ b/products/product_analytics/frontend/insights/shared/InsightsTable/insightsTableDataLogic.ts@@ -1,10 +1,10 @@import { MakeLogicType, actions, afterMount, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'import { loaders } from 'kea-loaders'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { uuid } from 'lib/utils/dom'import { average, median } from 'lib/utils/numbers'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { isOtherBreakdown } from 'scenes/insights/utils'import { compareDataNodeQuery } from 'scenes/insights/utils/queryUtils'import { ResultSeriesRow, getResultOrder, hasFormulaResults } from 'scenes/insights/utils/resultSeries'diff --git a/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotChart.tsx b/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotChart.tsxindex 7f973786e6c9..f5bf82074fcd 100644--- a/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotChart.tsx+++ b/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotChart.tsx@@ -7,7 +7,7 @@ import type { BoxPlotClickData, BoxPlotConfig, BoxPlotSeries } from '@posthog/quimport { useChartConfig, useChartTheme } from 'lib/charts/hooks'import { getSeriesColor } from 'lib/colors'import { DateDisplay } from 'lib/components/DateDisplay'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { insightLogic } from 'scenes/insights/insightLogic'import { teamLogic } from 'scenes/teamLogic'import { openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'diff --git a/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotResultsTable.tsx b/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotResultsTable.tsxindex 958828f526b0..78e774d7c4fe 100644--- a/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotResultsTable.tsx+++ b/products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotResultsTable.tsx@@ -1,8 +1,8 @@import { useValues } from 'kea'import { getSeriesColor } from 'lib/colors'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { LemonTable } from 'lib/lemon-ui/LemonTable'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { insightLogic } from 'scenes/insights/insightLogic'import { BoxPlotDatum } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/trends/BoxPlot/boxPlotChartLogic.tsx b/products/product_analytics/frontend/insights/trends/BoxPlot/boxPlotChartLogic.tsxindex c9bd22fdecb2..e3d8b2abb914 100644--- a/products/product_analytics/frontend/insights/trends/BoxPlot/boxPlotChartLogic.tsx+++ b/products/product_analytics/frontend/insights/trends/BoxPlot/boxPlotChartLogic.tsx@@ -1,7 +1,7 @@import { MakeLogicType, connect, kea, key, path, props, selectors } from 'kea'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { BoxPlotDatum } from '~/queries/schema/schema-general'import type {diff --git a/products/product_analytics/frontend/insights/trends/CalendarHeatMap/calendarHeatMapLogic.tsx b/products/product_analytics/frontend/insights/trends/CalendarHeatMap/calendarHeatMapLogic.tsxindex 680714c6d006..46957c5e9e28 100644--- a/products/product_analytics/frontend/insights/trends/CalendarHeatMap/calendarHeatMapLogic.tsx+++ b/products/product_analytics/frontend/insights/trends/CalendarHeatMap/calendarHeatMapLogic.tsx@@ -1,8 +1,8 @@import { MakeLogicType, actions, connect, kea, key, path, props, reducers, selectors } from 'kea'import type { DataColorTheme } from 'lib/colors'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { teamLogic } from 'scenes/teamLogic'import type {diff --git a/products/product_analytics/frontend/insights/trends/Metric/Metric.tsx b/products/product_analytics/frontend/insights/trends/Metric/Metric.tsxindex 59e52b41b706..098c7ab976b4 100644--- a/products/product_analytics/frontend/insights/trends/Metric/Metric.tsx+++ b/products/product_analytics/frontend/insights/trends/Metric/Metric.tsx@@ -11,11 +11,8 @@ import {MetricValue,} from '@posthog/quill-components/metric'+import { defaultAggregationAxisFormatForDisplay, formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { hexToRGBA } from 'lib/utils/colors'-import {- defaultAggregationAxisFormatForDisplay,- formatAggregationAxisValue,-} from 'scenes/insights/aggregationAxisFormat'import { InsightEmptyState } from 'scenes/insights/EmptyStates'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'diff --git a/products/product_analytics/frontend/insights/trends/RegionMap/RegionMap.tsx b/products/product_analytics/frontend/insights/trends/RegionMap/RegionMap.tsxindex 7e09383b96d8..df683aadf112 100644--- a/products/product_analytics/frontend/insights/trends/RegionMap/RegionMap.tsx+++ b/products/product_analytics/frontend/insights/trends/RegionMap/RegionMap.tsx@@ -4,9 +4,9 @@ import { useActions, useValues } from 'kea'import React, { useEffect, useRef } from 'react'import { ComposableMap, Geographies, Geography } from 'react-simple-maps'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { gradateColor } from 'lib/utils/colors'import { COUNTRY_CODE_TO_LONG_NAME, countryCodeToFlag } from 'lib/utils/country'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { insightLogic } from 'scenes/insights/insightLogic'import { teamLogic } from 'scenes/teamLogic'import { openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'diff --git a/products/product_analytics/frontend/insights/trends/RegionMap/regionMapLogic.tsx b/products/product_analytics/frontend/insights/trends/RegionMap/regionMapLogic.tsxindex 35f554a661ba..846c1acc4e2a 100644--- a/products/product_analytics/frontend/insights/trends/RegionMap/regionMapLogic.tsx+++ b/products/product_analytics/frontend/insights/trends/RegionMap/regionMapLogic.tsx@@ -1,8 +1,8 @@import { MakeLogicType, actions, connect, kea, key, path, props, reducers, selectors } from 'kea'import type { DataColorTheme } from 'lib/colors'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import type {AnyDataWarehouseNode,diff --git a/products/product_analytics/frontend/insights/trends/TrendsBarChart/TrendsBarChart.tsx b/products/product_analytics/frontend/insights/trends/TrendsBarChart/TrendsBarChart.tsxindex 00656d8a4fbd..51388abb9040 100644--- a/products/product_analytics/frontend/insights/trends/TrendsBarChart/TrendsBarChart.tsx+++ b/products/product_analytics/frontend/insights/trends/TrendsBarChart/TrendsBarChart.tsx@@ -15,8 +15,8 @@ import type { BarChartConfig, PointClickData, TimeSeriesBarChartConfig, TooltipCimport { makeChartErrorHandler } from 'lib/charts/chartErrorHandler'import { useChartTheme, useChartConfig, useDateRangeZoom } from 'lib/charts/hooks'import { AnnotationsLayer } from 'lib/components/AnnotationsOverlay/AnnotationsLayer'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { percentage } from 'lib/utils/numbers'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { InsightEmptyState } from 'scenes/insights/EmptyStates'import { insightLogic } from 'scenes/insights/insightLogic'import { teamLogic } from 'scenes/teamLogic'diff --git a/products/product_analytics/frontend/insights/trends/TrendsLifecycleChart/TrendsLifecycleChart.tsx b/products/product_analytics/frontend/insights/trends/TrendsLifecycleChart/TrendsLifecycleChart.tsxindex c40ec440e27e..2227a9c7047d 100644--- a/products/product_analytics/frontend/insights/trends/TrendsLifecycleChart/TrendsLifecycleChart.tsx+++ b/products/product_analytics/frontend/insights/trends/TrendsLifecycleChart/TrendsLifecycleChart.tsx@@ -9,7 +9,7 @@ import { useChartConfig, useChartTheme, useDateRangeZoom } from 'lib/charts/hookimport { getBarColorFromStatus } from 'lib/colors'import { AnnotationsLayer } from 'lib/components/AnnotationsOverlay/AnnotationsLayer'import { useChartLegendSeriesMenu } from 'lib/components/ChartLegendSeriesMenu/useChartLegendSeriesMenu'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { InsightEmptyState } from 'scenes/insights/EmptyStates'import { insightLogic } from 'scenes/insights/insightLogic'import { teamLogic } from 'scenes/teamLogic'diff --git a/products/product_analytics/frontend/insights/trends/TrendsLineChart/TrendsLineChart.tsx b/products/product_analytics/frontend/insights/trends/TrendsLineChart/TrendsLineChart.tsxindex 2e03c65cedad..92f79e666f23 100644--- a/products/product_analytics/frontend/insights/trends/TrendsLineChart/TrendsLineChart.tsx+++ b/products/product_analytics/frontend/insights/trends/TrendsLineChart/TrendsLineChart.tsx@@ -10,10 +10,10 @@ import { chartStyleCurve } from 'lib/charts/chartStyleAdapter'import { useChartTheme, useChartConfig, useDateRangeZoom } from 'lib/charts/hooks'import { AnnotationsLayer } from 'lib/components/AnnotationsOverlay/AnnotationsLayer'import { dayjs } from 'lib/dayjs'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { ciRanges } from 'lib/statistics'import { percentage } from 'lib/utils/numbers'import { isMultiSeriesFormula } from 'lib/utils/strings'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { InsightEmptyState } from 'scenes/insights/EmptyStates'import { insightLogic } from 'scenes/insights/insightLogic'import { teamLogic } from 'scenes/teamLogic'diff --git a/products/product_analytics/frontend/insights/trends/TrendsSlopeChart/TrendsSlopeChart.tsx b/products/product_analytics/frontend/insights/trends/TrendsSlopeChart/TrendsSlopeChart.tsxindex 4186b8176bde..adf03845406a 100644--- a/products/product_analytics/frontend/insights/trends/TrendsSlopeChart/TrendsSlopeChart.tsx+++ b/products/product_analytics/frontend/insights/trends/TrendsSlopeChart/TrendsSlopeChart.tsx@@ -6,7 +6,7 @@ import type { Series, SlopeChartConfig, SlopeSeriesMeta } from '@posthog/quill-cimport { makeChartErrorHandler } from 'lib/charts/chartErrorHandler'import { useChartTheme } from 'lib/charts/hooks'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { InsightEmptyState } from 'scenes/insights/EmptyStates'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'diff --git a/products/product_analytics/frontend/insights/trends/WorldMap/WorldMap.tsx b/products/product_analytics/frontend/insights/trends/WorldMap/WorldMap.tsxindex 340a7ca29052..cdeacc9279aa 100644--- a/products/product_analytics/frontend/insights/trends/WorldMap/WorldMap.tsx+++ b/products/product_analytics/frontend/insights/trends/WorldMap/WorldMap.tsx@@ -4,9 +4,9 @@ import { style } from 'd3'import { props, useActions, useValues } from 'kea'import React, { useEffect, useRef } from 'react'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { gradateColor } from 'lib/utils/colors'import { COUNTRY_CODE_TO_LONG_NAME, countryCodeToFlag } from 'lib/utils/country'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { insightLogic } from 'scenes/insights/insightLogic'import { teamLogic } from 'scenes/teamLogic'import { openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'diff --git a/products/product_analytics/frontend/insights/trends/WorldMap/worldMapLogic.tsx b/products/product_analytics/frontend/insights/trends/WorldMap/worldMapLogic.tsxindex 649f28b81c0b..999bb1c7d169 100644--- a/products/product_analytics/frontend/insights/trends/WorldMap/worldMapLogic.tsx+++ b/products/product_analytics/frontend/insights/trends/WorldMap/worldMapLogic.tsx@@ -1,8 +1,8 @@import { MakeLogicType, actions, connect, kea, key, path, props, reducers, selectors } from 'kea'import type { DataColorTheme } from 'lib/colors'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import type {AnyDataWarehouseNode,diff --git a/products/product_analytics/frontend/insights/trends/shared/TrendsTooltip.tsx b/products/product_analytics/frontend/insights/trends/shared/TrendsTooltip.tsxindex 009502e27b14..2a966f7461c7 100644--- a/products/product_analytics/frontend/insights/trends/shared/TrendsTooltip.tsx+++ b/products/product_analytics/frontend/insights/trends/shared/TrendsTooltip.tsx@@ -3,9 +3,9 @@ import { useCallback, useMemo } from 'react'import type { TooltipContext } from '@posthog/quill-charts'import { SeriesLetter } from 'lib/components/SeriesGlyph'+import { formatAggregationAxisValue } from 'lib/insights/aggregationAxisFormat'import { toOpaqueHex } from 'lib/utils/colors'import { percentage } from 'lib/utils/numbers'-import { formatAggregationAxisValue } from 'scenes/insights/aggregationAxisFormat'import { BreakdownFilter, CurrencyCode, DateRange, TrendsFilter } from '~/queries/schema/schema-general'import { IntervalType } from '~/types'diff --git a/products/product_analytics/frontend/insights/trends/shared/trendsAxisFormat.test.ts b/products/product_analytics/frontend/insights/trends/shared/trendsAxisFormat.test.tsindex 56fce9793c94..e77defecaea0 100644--- a/products/product_analytics/frontend/insights/trends/shared/trendsAxisFormat.test.ts+++ b/products/product_analytics/frontend/insights/trends/shared/trendsAxisFormat.test.ts@@ -1,6 +1,6 @@import { buildYTickFormatter } from '@posthog/quill-charts'-import { AggregationAxisFormat } from 'scenes/insights/aggregationAxisFormat'+import { AggregationAxisFormat } from 'lib/insights/aggregationAxisFormat'import { CurrencyCode, TrendsFilter } from '~/queries/schema/schema-general'diff --git a/products/product_analytics/frontend/insights/trends/shared/useTrendsPartOfWholeChart.tsx b/products/product_analytics/frontend/insights/trends/shared/useTrendsPartOfWholeChart.tsxindex e0f6c959190f..cae606946a59 100644--- a/products/product_analytics/frontend/insights/trends/shared/useTrendsPartOfWholeChart.tsx+++ b/products/product_analytics/frontend/insights/trends/shared/useTrendsPartOfWholeChart.tsx@@ -7,7 +7,7 @@ import { useChartTheme } from 'lib/charts/hooks'import {formatAggregationAxisValue,formatAggregationAxisValueWithShareOfTotal,-} from 'scenes/insights/aggregationAxisFormat'+} from 'lib/insights/aggregationAxisFormat'import { insightLogic } from 'scenes/insights/insightLogic'import { teamLogic } from 'scenes/teamLogic'import { openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'diff --git a/products/product_analytics/frontend/insights/trends/trendsDataLogic.ts b/products/product_analytics/frontend/insights/trends/trendsDataLogic.tsindex de60741a90a3..b72aa1d414ec 100644--- a/products/product_analytics/frontend/insights/trends/trendsDataLogic.ts+++ b/products/product_analytics/frontend/insights/trends/trendsDataLogic.ts@@ -4,6 +4,7 @@ import { DataColorTheme, DataColorToken } from 'lib/colors'import type { Intervals } from 'lib/components/IntervalFilter/intervals'import { PART_OF_WHOLE_DISPLAY_TYPES } from 'lib/constants'import { dayjs } from 'lib/dayjs'+import { keyForInsightLogicProps } from 'lib/insights/sharedUtils'import { isMultiSeriesFormula } from 'lib/utils/strings'import {BreakdownColorConfig,@@ -15,7 +16,6 @@ import { dashboardLogic } from 'scenes/dashboard/dashboardLogic'import { getColorFromToken } from 'scenes/dataThemeLogic'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import {BREAKDOWN_NULL_NUMERIC_LABEL,BREAKDOWN_NULL_STRING_LABEL,diff --git a/products/subscriptions/backend/temporal/insight_snapshot.py b/products/subscriptions/backend/temporal/insight_snapshot.pyindex 8f608116191c..4612569914e8 100644--- a/products/subscriptions/backend/temporal/insight_snapshot.py+++ b/products/subscriptions/backend/temporal/insight_snapshot.py@@ -138,7 +138,7 @@ def _extract_value_format(query_json: Any) -> dict[str, Any] | None:The summarizer uses this to render metric values the way the chart does, so the AIsummary reads "4d 4h" instead of a raw "360000". Returns None when no non-defaultformat is configured. Mirrors the trendsFilter fields read by- frontend/src/scenes/insights/aggregationAxisFormat.ts.+ frontend/src/lib/insights/aggregationAxisFormat.ts."""if not isinstance(query_json, dict):return Nonediff --git a/products/subscriptions/backend/temporal/results_summarizer.py b/products/subscriptions/backend/temporal/results_summarizer.pyindex 34e9bb80bedd..4e88c03da746 100644--- a/products/subscriptions/backend/temporal/results_summarizer.py+++ b/products/subscriptions/backend/temporal/results_summarizer.py@@ -304,7 +304,7 @@ def _sanitize_value_format(value_format: dict[str, Any] | None) -> dict[str, Anydef _fmt_value(value: float | int | None, value_format: dict[str, Any] | None) -> str:"""Render a metric value the way the insight's Y-axis does, so summary numbers matchthe chart the user sees (a duration insight reads "4d 4h", not "360000"). Mirrors- frontend/src/scenes/insights/aggregationAxisFormat.ts. Falls back to plain numeric+ frontend/src/lib/insights/aggregationAxisFormat.ts. Falls back to plain numericformatting when no axis format is configured."""if not value_format: