:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
refactor(signals): split activity summary enrollment into generation and read checks (#122721)
posthog[bot]b0930f344e5d
diff --git a/products/signals/backend/activity_summary/queue.py b/products/signals/backend/activity_summary/queue.pyindex ad5d7499c20c..0f999d2b7dfa 100644--- a/products/signals/backend/activity_summary/queue.py+++ b/products/signals/backend/activity_summary/queue.py@@ -170,8 +170,16 @@ def enrolled_team_ids(config: ActivitySummaryConfig) -> list[int]:return list(teams.exclude(id__in=config.skip_team_ids).values_list("id", flat=True))-def is_team_enrolled(config: ActivitySummaryConfig, team: Team) -> bool:- """The single-team form of `enrolled_team_ids`. A disabled config enrolls no team."""+def is_team_enrolled_for_generation(config: ActivitySummaryConfig, team: Team) -> bool:+ """The tick may generate summaries for the team. It is the read check for now."""+ return is_team_enrolled_for_read(config, team)+++def is_team_enrolled_for_read(config: ActivitySummaryConfig, team: Team) -> bool:+ """The single-team form of `enrolled_team_ids`. The API and MCP tools read summaries only for these teams.++ A disabled config enrolls no team.+ """if not config.enabled or team.id in config.skip_team_ids:return Falseif team.organization.is_ai_data_processing_approved is not True:diff --git a/products/signals/backend/activity_summary/read.py b/products/signals/backend/activity_summary/read.pyindex 8826225de6ad..73ff24f57ecd 100644--- a/products/signals/backend/activity_summary/read.py+++ b/products/signals/backend/activity_summary/read.py@@ -14,7 +14,7 @@ from posthog.models import Teamfrom products.signals.backend.activity_summary.config import ActivitySummaryConfig, read_configfrom products.signals.backend.activity_summary.logic import is_stale-from products.signals.backend.activity_summary.queue import is_team_enrolled+from products.signals.backend.activity_summary.queue import is_team_enrolled_for_readfrom products.signals.backend.models import UserActivitySummary, UserActivitySummaryVersionDEFAULT_VERSIONS_LIMIT = 5@@ -86,7 +86,7 @@ def _products(value: Any) -> tuple[str, ...]:def _readable_config(team: Team) -> ActivitySummaryConfig | None:config = read_config()- return config if is_team_enrolled(config, team) else None+ return config if is_team_enrolled_for_read(config, team) else Nonedef get_summary(team: Team, user_id: int) -> ActivitySummaryView | None:diff --git a/products/signals/backend/test/test_activity_summary_api.py b/products/signals/backend/test/test_activity_summary_api.pyindex 4302c4cac617..c95ab2b57cb9 100644--- a/products/signals/backend/test/test_activity_summary_api.py+++ b/products/signals/backend/test/test_activity_summary_api.py@@ -92,6 +92,16 @@ class TestActivitySummaryAPI(APIBaseTest):assert self._get().status_code == 404assert self._get("versions/").status_code == 404+ def test_read_access_does_not_follow_the_generation_check(self) -> None:+ self._versions(1)+ self.config = dataclasses.replace(self.config, skip_team_ids=(self.team.id,))++ with patch(+ "products.signals.backend.activity_summary.queue.is_team_enrolled_for_generation", return_value=True+ ):+ assert self._get().status_code == 404+ assert self._get("versions/").status_code == 404+def test_enroll_all_approved_enrolls_an_unlisted_organization(self) -> None:self.config = ActivitySummaryConfig(enabled=True, enroll_all_approved=True)self._summary()diff --git a/products/signals/backend/test/test_activity_summary_tick.py b/products/signals/backend/test/test_activity_summary_tick.pyindex 99e1cea3c93a..1b98fd3fa968 100644--- a/products/signals/backend/test/test_activity_summary_tick.py+++ b/products/signals/backend/test/test_activity_summary_tick.py@@ -34,6 +34,8 @@ from products.signals.backend.activity_summary.queue import (daily_usage,enrolled_team_ids,feed_queue,+ is_team_enrolled_for_generation,+ is_team_enrolled_for_read,max_update_cost_usd,seed_queue,select_pairs,@@ -340,6 +342,32 @@ class TestActivitySummaryQueue(BaseTest):assert self._select() == []+ @parameterized.expand(+ [+ ("listed", {}, True, True),+ ("disabled", {"enabled": False}, True, False),+ ("not_listed", {"organization_ids": ("00000000-0000-0000-0000-000000000001",)}, True, False),+ ("invalid_listed_id", {"organization_ids": ("not-a-uuid",)}, True, False),+ ("team_skipped", {"skip_team_ids": ("own",)}, True, False),+ ("not_approved", {}, False, False),+ ("all_approved", {"organization_ids": (), "enroll_all_approved": True}, True, True),+ ("all_approved_not_approved", {"organization_ids": (), "enroll_all_approved": True}, False, False),+ ("all_approved_team_skipped", {"enroll_all_approved": True, "skip_team_ids": ("own",)}, True, False),+ ]+ )+ def test_read_and_generation_checks_enroll_the_same_teams(+ self, _name: str, overrides: dict[str, Any], approved: bool, expected: bool+ ) -> None:+ self.organization.is_ai_data_processing_approved = approved+ self.organization.save()+ if overrides.get("skip_team_ids") == ("own",):+ overrides = {**overrides, "skip_team_ids": (self.team.id,)}+ config = dataclasses.replace(self._config(), **overrides)+ team = Team.objects.get(id=self.team.id)++ assert is_team_enrolled_for_read(config, team) is expected+ assert is_team_enrolled_for_generation(config, team) is expected+def test_daily_usage_counts_model_calls_and_prices_a_missing_cost_at_the_bound(self) -> None:priced, unpriced, skipped = (self._user(f"{name}@example.com") for name in ("priced", "unpriced", "skipped"))self._summary(priced, cost_usd=0.25)