Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(provisioning): link existing stripe users only when stripe verified the email (#119795)

Matt Brookerbda6c1d7ef33
diff --git a/ee/partners/stripe/api/provisioning/core.py b/ee/partners/stripe/api/provisioning/core.py
index e0bb64783426..7ba79f3b9e24 100644
--- a/ee/partners/stripe/api/provisioning/core.py
+++ b/ee/partners/stripe/api/provisioning/core.py
@@ -52,6 +52,13 @@ logger = structlog.get_logger(__name__)
# Label used in the welcome email and default organization name.
PARTNER_LABEL = "Stripe"
+EMAIL_NOT_VERIFIED_MESSAGE = (
+ "Stripe hasn't verified this email address. Verify it with Stripe to link an existing PostHog account."
+)
+ACCOUNT_NOT_LINKABLE_MESSAGE = (
+ "PostHog can't link this account. If you think this is a mistake, contact PostHog support."
+)
+
# ---------------------------------------------------------------------------
# Stripe Projects OAuth app
@@ -212,8 +219,21 @@ def handle_existing_user(
requested_team_id: int | None,
code_challenge: str,
code_challenge_method: str,
+ kyc_email_verified: bool | None,
) -> dict[str, Any]:
- """Silently mint an auth code for an existing account."""
+ """Silently mint an auth code for an existing account.
+
+ The refusals run before team resolution because resolving a team can create a project.
+ """
+ if kyc_email_verified is False:
+ capture_provisioning_event("account_request", "email_not_verified", region=region, kyc_email_verified=False)
+ raise SpecError("requires_kyc", EMAIL_NOT_VERIFIED_MESSAGE, request_id=request_id, status=403)
+ if not user.is_active:
+ capture_provisioning_event(
+ "account_request", "user_inactive", region=region, kyc_email_verified=kyc_email_verified
+ )
+ raise SpecError("forbidden", ACCOUNT_NOT_LINKABLE_MESSAGE, request_id=request_id, status=403)
+
team = resolve_team_for_existing_user(user, requested_team_id)
if team is None:
capture_provisioning_event("account_request", "error", error_code="team_resolution_failed")
@@ -230,7 +250,9 @@ def handle_existing_user(
code_challenge_method=code_challenge_method,
)
- capture_provisioning_event("account_request", "existing_user", region=region, team_id=team.id)
+ capture_provisioning_event(
+ "account_request", "existing_user", region=region, team_id=team.id, kyc_email_verified=kyc_email_verified
+ )
return {"id": request_id, "type": "oauth", "oauth": {"code": code}}
@@ -293,11 +315,14 @@ def handle_new_user(
None,
code_challenge,
code_challenge_method,
+ data["kyc_email_verified"],
)
capture_provisioning_event("account_request", "creation_failed", region=region)
raise SpecError("account_creation_failed", "Failed to create account", request_id=request_id, status=500)
- capture_provisioning_event("account_request", "new_user", region=region, team_id=team.id)
+ capture_provisioning_event(
+ "account_request", "new_user", region=region, team_id=team.id, kyc_email_verified=data["kyc_email_verified"]
+ )
# Emit the standard signup event so provisioned accounts flow into the shared
# signup / activation / billing analyses, segmentable by client.
diff --git a/ee/partners/stripe/api/provisioning/serializers.py b/ee/partners/stripe/api/provisioning/serializers.py
index a5542d2184d0..9e91fd1a0e6f 100644
--- a/ee/partners/stripe/api/provisioning/serializers.py
+++ b/ee/partners/stripe/api/provisioning/serializers.py
@@ -82,6 +82,16 @@ class AccountRequestSerializer(serializers.Serializer):
default=dict,
help_text="Provider-specific configuration: region (US/EU), organization_name, team_id.",
)
+ kyc = serializers.JSONField(
+ required=False,
+ allow_null=True,
+ default=None,
+ help_text=(
+ 'Stripe\'s verification status for the account request fields: {"verified_fields": [...]}, any of '
+ '"name", "email", "phone" and "country". When sent, linking an existing PostHog account requires '
+ '"email" in verified_fields.'
+ ),
+ )
orchestrator = serializers.JSONField(
required=False,
allow_null=True,
@@ -141,6 +151,12 @@ class AccountRequestSerializer(serializers.Serializer):
if not isinstance(attrs.get("orchestrator"), dict):
attrs["orchestrator"] = {}
+ kyc = attrs.pop("kyc", None)
+ verified_fields = kyc.get("verified_fields") if isinstance(kyc, dict) else None
+ attrs["kyc_email_verified"] = (
+ None if kyc is None else isinstance(verified_fields, list) and "email" in verified_fields
+ )
+
return attrs
diff --git a/ee/partners/stripe/api/provisioning/test/test_account_requests.py b/ee/partners/stripe/api/provisioning/test/test_account_requests.py
index 593c0daa991e..4cab84807393 100644
--- a/ee/partners/stripe/api/provisioning/test/test_account_requests.py
+++ b/ee/partners/stripe/api/provisioning/test/test_account_requests.py
@@ -1,6 +1,7 @@
-from contextlib import AbstractContextManager
+from contextlib import AbstractContextManager, nullcontext
+from typing import Any
-from unittest.mock import patch
+from unittest.mock import MagicMock, patch
from django.core.cache import cache
from django.db import IntegrityError
@@ -13,9 +14,19 @@ from posthog.models.organization_provisioning import OrganizationProvisioning
from posthog.models.user import User
from ee.partners.stripe.api.provisioning import AUTH_CODE_CACHE_PREFIX
+from ee.partners.stripe.api.provisioning.core import ACCOUNT_NOT_LINKABLE_MESSAGE, EMAIL_NOT_VERIFIED_MESSAGE
from ee.partners.stripe.api.provisioning.test.base import BASE_PATH, StripeProvisioningTestBase
URL = f"{BASE_PATH}/provisioning/account_requests"
+CAPTURE = "ee.partners.stripe.api.provisioning.analytics.posthoganalytics.capture"
+
+
+def _account_request_events(capture: MagicMock) -> list[dict[str, Any]]:
+ return [
+ call.kwargs["properties"]
+ for call in capture.call_args_list
+ if call.args[:1] == ("agentic_provisioning account_request",)
+ ]
def _account_request(email: str, **overrides) -> dict:
@@ -34,9 +45,15 @@ def _account_request(email: str, **overrides) -> dict:
class TestAccountRequests(StripeProvisioningTestBase):
- def test_new_user_gets_auth_code_and_welcome_email(self):
+ @parameterized.expand(
+ [
+ ("without_kyc", {}),
+ ("with_malformed_kyc", {"kyc": "email"}),
+ ]
+ )
+ def test_new_user_gets_auth_code_and_welcome_email(self, _name: str, kyc_fields: dict[str, Any]) -> None:
with patch("ee.partners.stripe.api.provisioning.core.send_provisioning_welcome") as welcome:
- res = self._post_signed(URL, data=_account_request("[email protected]"))
+ res = self._post_signed(URL, data=_account_request("[email protected]", **kyc_fields))
assert res.status_code == 200
body = res.json()
assert body["id"] == "acctreq_test"
@@ -88,16 +105,113 @@ class TestAccountRequests(StripeProvisioningTestBase):
assert not User.objects.filter(email="[email protected]").exists()
assert Organization.objects.count() == organization_count
- def test_existing_user_gets_silent_code_for_requested_team(self):
- res = self._post_signed(
- URL, data=_account_request(self.user.email, configuration={"region": "US", "team_id": self.team.id})
- )
+ @parameterized.expand(
+ [
+ ("without_kyc", {}, None),
+ ("with_verified_email", {"kyc": {"verified_fields": ["name", "email"]}}, True),
+ ]
+ )
+ def test_existing_user_gets_silent_code_for_requested_team(
+ self, _name: str, kyc_fields: dict[str, Any], kyc_email_verified: bool | None
+ ) -> None:
+ with patch(CAPTURE) as capture:
+ res = self._post_signed(
+ URL,
+ data=_account_request(
+ self.user.email, configuration={"region": "US", "team_id": self.team.id}, **kyc_fields
+ ),
+ )
assert res.status_code == 200
body = res.json()
assert body["type"] == "oauth"
code_data = cache.get(f"{AUTH_CODE_CACHE_PREFIX}{body['oauth']['code']}")
assert code_data["user_id"] == self.user.id
assert code_data["team_id"] == self.team.id
+ assert [(event["outcome"], event["kyc_email_verified"]) for event in _account_request_events(capture)] == [
+ ("existing_user", kyc_email_verified)
+ ]
+
+ @parameterized.expand(
+ [
+ (
+ "kyc_without_email",
+ {"verified_fields": ["name", "phone"]},
+ True,
+ False,
+ "requires_kyc",
+ EMAIL_NOT_VERIFIED_MESSAGE,
+ ["email_not_verified"],
+ ),
+ (
+ "kyc_without_verified_fields",
+ {},
+ True,
+ False,
+ "requires_kyc",
+ EMAIL_NOT_VERIFIED_MESSAGE,
+ ["email_not_verified"],
+ ),
+ (
+ "kyc_with_verified_fields_not_a_list",
+ {"verified_fields": "email"},
+ True,
+ False,
+ "requires_kyc",
+ EMAIL_NOT_VERIFIED_MESSAGE,
+ ["email_not_verified"],
+ ),
+ (
+ "deactivated_user",
+ {"verified_fields": ["email"]},
+ False,
+ False,
+ "forbidden",
+ ACCOUNT_NOT_LINKABLE_MESSAGE,
+ ["user_inactive"],
+ ),
+ (
+ "concurrent_signup_with_kyc_without_email",
+ {"verified_fields": ["name"]},
+ True,
+ True,
+ "requires_kyc",
+ EMAIL_NOT_VERIFIED_MESSAGE,
+ ["race_condition_existing_user", "email_not_verified"],
+ ),
+ ]
+ )
+ def test_existing_user_is_not_linked(
+ self,
+ _name: str,
+ kyc: Any,
+ user_is_active: bool,
+ concurrent_signup: bool,
+ error_code: str,
+ message: str,
+ outcomes: list[str],
+ ) -> None:
+ self.user.is_active = user_is_active
+ self.user.save()
+ view_lookup_misses_user: AbstractContextManager[object] = (
+ patch(
+ "ee.partners.stripe.api.provisioning.views.EmailLookupHandler",
+ MagicMock(**{"get_user_by_email.return_value": None}),
+ )
+ if concurrent_signup
+ else nullcontext()
+ )
+
+ with (
+ view_lookup_misses_user,
+ patch("ee.partners.stripe.api.provisioning.core.cache") as auth_code_cache,
+ patch(CAPTURE) as capture,
+ ):
+ res = self._post_signed(URL, data=_account_request(self.user.email, kyc=kyc))
+
+ assert res.status_code == 403
+ assert res.json() == {"id": "acctreq_test", "type": "error", "error": {"code": error_code, "message": message}}
+ auth_code_cache.set.assert_not_called()
+ assert [event["outcome"] for event in _account_request_events(capture)] == outcomes
def test_optional_fields_accept_explicit_null(self):
# Spec JSON tolerance: an explicit null on an optional field is treated
@@ -113,6 +227,7 @@ class TestAccountRequests(StripeProvisioningTestBase):
code_challenge=None,
code_challenge_method=None,
configuration=None,
+ kyc=None,
),
)
assert res.status_code == 200
diff --git a/ee/partners/stripe/api/provisioning/views.py b/ee/partners/stripe/api/provisioning/views.py
index a8faedc494a3..7ad68f672fed 100644
--- a/ee/partners/stripe/api/provisioning/views.py
+++ b/ee/partners/stripe/api/provisioning/views.py
@@ -255,6 +255,7 @@ class AccountRequestsView(StripeProvisioningAPIView):
requested_team_id,
code_challenge,
code_challenge_method,
+ data["kyc_email_verified"],
)
)