:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(signals): request the pr owner's review (#122191)
posthog[bot]be985b1118f0
diff --git a/docs/internal/signals-pr-lifecycle.md b/docs/internal/signals-pr-lifecycle.mdindex 264661381bf5..a620b6a8acc9 100644--- a/docs/internal/signals-pr-lifecycle.md+++ b/docs/internal/signals-pr-lifecycle.md@@ -204,7 +204,13 @@ The same access rule applies when a reviewer is added later.If no suggested reviewer has access, the ready report still goes to the configured team channel without reviewer mentions.The notification activity retries transient ClickHouse reads before it claims the report for delivery.-When an implementation pull request reaches the report, the worker requests reviews from suggested reviewers with connected GitHub accounts. It sends up to 15 reviewers per request. It skips the pull request author, existing assignees, the DRI it assigns, people with pending requests, and people who submitted a review. If GitHub rejects one reviewer, the worker continues with the other reviewers. Under the DRI rule, one assignee remains responsible for the pull request.+When an implementation pull request has one assignee, the worker requests that person's review, even when another person or team request exists.+This makes the owner's work visible in both GitHub assignment and review-request lists.+Without a single owner, it requests the highest-ranked eligible report reviewer only when no person or team request exists.+Each attempt requests at most one person. It never removes existing requests.+The worker skips the author, pending recipients, completed reviewers, and people whose review request was removed.+Incomplete review or removal history prevents a new request.+Personal assignment settings control ownership; they do not disable review requests.## Assignment decisionsdiff --git a/posthog/models/github_integration_base.py b/posthog/models/github_integration_base.pyindex 6aeca753b99d..a0398e8d3f25 100644--- a/posthog/models/github_integration_base.py+++ b/posthog/models/github_integration_base.py@@ -1302,6 +1302,11 @@ class GitHubIntegrationBase:for entry in (pr.get("requested_reviewers") or [])if isinstance(entry, dict) and entry.get("login")],+ "requested_teams": [+ entry["slug"]+ for entry in (pr.get("requested_teams") or [])+ if isinstance(entry, dict) and entry.get("slug")+ ],"created_at": pr.get("created_at"),"updated_at": pr.get("updated_at"),"merged_at": pr.get("merged_at"),@@ -1544,6 +1549,33 @@ class GitHubIntegrationBase:)return {"success": True, "requested_reviewers": list(dict.fromkeys(requested_reviewers))}+ def get_removed_pull_request_reviewers(self, repository: str, pr_number: int) -> set[str] | None:+ """Return removed review recipients, or None when the history is incomplete."""+ repo_path = repository if "/" in repository else f"{self.organization()}/{repository}"+ responses, complete = self._installation_authenticated_get_pages(+ f"https://api.github.com/repos/{repo_path}/issues/{pr_number}/timeline",+ endpoint="/repos/{owner}/{repo}/issues/{issue_number}/timeline",+ params={"per_page": 100},+ )+ if not complete:+ return None++ removed: set[str] = set()+ for response in responses:+ try:+ events = response.json()+ except Exception:+ return None+ if not isinstance(events, list):+ return None+ for event in events:+ if not isinstance(event, dict) or event.get("event") != "review_request_removed":+ continue+ reviewer = event.get("requested_reviewer")+ if isinstance(reviewer, dict) and isinstance(reviewer.get("login"), str):+ removed.add(reviewer["login"].lower())+ return removed+def list_submitted_pull_request_reviewers(self, repository: str, pr_number: int) -> dict[str, Any]:repo_path = repository if "/" in repository else f"{self.organization()}/{repository}"responses, complete = self._installation_authenticated_get_pages(diff --git a/posthog/models/test/integration/test_github.py b/posthog/models/test/integration/test_github.pyindex 34a771e92e63..99a81b1eda74 100644--- a/posthog/models/test/integration/test_github.py+++ b/posthog/models/test/integration/test_github.py@@ -1193,7 +1193,7 @@ class TestGitHubIntegrationModel(BaseTest):assert mock_post.call_args.args[0] == "https://api.github.com/repos/PostHog/posthog/issues/123/comments"assert mock_post.call_args.kwargs["json_body"] == {"body": "hello"}- def test_get_pull_request_includes_requested_reviewers(self):+ def test_get_pull_request_includes_requested_reviewers_and_teams(self):integration = self.create_integration(config={"account": {"name": "PostHog"}}, sensitive_config={"access_token": "ACCESS_TOKEN"})@@ -1203,6 +1203,7 @@ class TestGitHubIntegrationModel(BaseTest):"number": 123,"assignees": [{"login": "alice"}],"requested_reviewers": [{"login": "bob"}],+ "requested_teams": [{"slug": "team-signals"}],}with patch.object(github, "_installation_authenticated_get", return_value=mock_response):@@ -1210,6 +1211,36 @@ class TestGitHubIntegrationModel(BaseTest):assert result["assignees"] == ["alice"]assert result["requested_reviewers"] == ["bob"]+ assert result["requested_teams"] == ["team-signals"]++ @parameterized.expand(+ [+ (+ "removed_on_later_page",+ True,+ [{"event": "review_request_removed", "requested_reviewer": {"login": "Alice"}}],+ {"alice"},+ ),+ ("team_removal", True, [{"event": "review_request_removed", "requested_team": {"slug": "owners"}}], set()),+ ("incomplete_history", False, [], None),+ ("invalid_history", True, {"message": "Moved"}, None),+ ]+ )+ def test_removed_reviewers_require_complete_history(+ self, _name: str, complete: bool, last_page: object, expected: set[str] | None+ ) -> None:+ integration = self.create_integration(sensitive_config={"access_token": "ACCESS_TOKEN"})+ github = GitHubIntegration(integration, source="test", priority=Priority.CRITICAL)+ first = MagicMock(status_code=200)+ first.links = {"next": {"url": "https://api.github.com/repos/PostHog/posthog/issues/123/timeline?page=2"}}+ first.json.return_value = [{"event": "review_requested", "requested_reviewer": {"login": "bob"}}]+ second = MagicMock(status_code=200) if complete else None+ if second is not None:+ second.links = {}+ second.json.return_value = last_page+ with patch.object(github, "_installation_authenticated_get", side_effect=[first, second]) as mock_get:+ assert github.get_removed_pull_request_reviewers("PostHog/posthog", 123) == expected+ assert mock_get.call_args_list[0].args[0] == "https://api.github.com/repos/PostHog/posthog/issues/123/timeline"def test_list_submitted_pull_request_reviewers_reads_every_page(self):integration = self.create_integration(sensitive_config={"access_token": "ACCESS_TOKEN"})diff --git a/products/signals/ARCHITECTURE.md b/products/signals/ARCHITECTURE.mdindex e9b738ba5475..949628779e9a 100644--- a/products/signals/ARCHITECTURE.md+++ b/products/signals/ARCHITECTURE.md@@ -1383,7 +1383,13 @@ Every self-driving pull request opens with no assignee, so it never reaches a GiThis governs what the rule adds. Nobody is ever unassigned, so a person can still assign three people by hand.-"Assignee" here means GitHub's assignee, the person responsible. Each suggested reviewer with a connected GitHub account also receives an individual review request, in bounded batches of 15. The worker does not request a review from the pull request author, an assignee, or an existing requested reviewer. A separate app can still request the owning team for review.+"Assignee" here means GitHub's assignee, the person responsible.+A single assignee receives a review request even when another person or team request exists.+Without a single owner, the worker requests the highest-ranked eligible report reviewer only when no request exists.+Each attempt requests at most one person and preserves other requests.+The worker skips the author, pending recipients, completed reviewers, and people whose review request was removed.+Incomplete review or removal history prevents a new request.+A separate app can still request the owning team for review.Under the `signals-pr-dri-assignee` flag, the candidates are, most responsible first:diff --git a/products/signals/backend/reviewer_pr_assignment.py b/products/signals/backend/reviewer_pr_assignment.pyindex 28e0bfc5dcaf..bc3837f5758a 100644--- a/products/signals/backend/reviewer_pr_assignment.py+++ b/products/signals/backend/reviewer_pr_assignment.py@@ -352,12 +352,14 @@ def _request_reviews(pr: dict[str, Any],reviewers: list[str],) -> list[str]:- existing = {- str(login).lower()- for login in [pr.get("author"), *(pr.get("assignees") or []), *(pr.get("requested_reviewers") or [])]- if login- }- wanted = [login for login in reviewers if login.lower() not in existing]+ assignees = list(dict.fromkeys(str(login).lower() for login in (pr.get("assignees") or []) if login))+ owner = assignees[0] if len(assignees) == 1 else None+ if owner is None and (pr.get("requested_reviewers") or pr.get("requested_teams")):+ return []++ existing = {str(login).lower() for login in [pr.get("author"), *(pr.get("requested_reviewers") or [])] if login}+ candidates = [owner] if owner else reviewers+ wanted = [login for login in candidates if login.lower() not in existing]if not wanted:return []@@ -372,6 +374,17 @@ def _request_reviews(return []existing.update(str(login).lower() for login in (reviews.get("reviewed_by") or []) if login)wanted = [login for login in wanted if login.lower() not in existing]+ if not wanted:+ return []+ try:+ removed = github.get_removed_pull_request_reviewers(parsed.repository, parsed.number)+ except Exception:+ log.exception("signals.reviewer_pr_assignment.removed_reviews_fetch_failed")+ return []+ if removed is None:+ log.warning("signals.reviewer_pr_assignment.removed_reviews_fetch_failed")+ return []+ wanted = [login for login in wanted if login.lower() not in removed][:1]if not wanted:return []diff --git a/products/signals/backend/test/test_reviewer_pr_assignment.py b/products/signals/backend/test/test_reviewer_pr_assignment.pyindex 10aa912d7475..98db4d4e4ada 100644--- a/products/signals/backend/test/test_reviewer_pr_assignment.py+++ b/products/signals/backend/test/test_reviewer_pr_assignment.py@@ -89,6 +89,7 @@ def _open_pr_github() -> MagicMock:"merged": False,"assignees": [],"requested_reviewers": [],+ "requested_teams": [],}github.add_pull_request_assignees.return_value = {"success": True, "assignees": ["opted-in"]}github.request_pull_request_reviews.return_value = {@@ -96,6 +97,7 @@ def _open_pr_github() -> MagicMock:"requested_reviewers": ["opted-in"],}github.list_submitted_pull_request_reviewers.return_value = {"success": True, "reviewed_by": []}+ github.get_removed_pull_request_reviewers.return_value = set()return github@@ -192,19 +194,44 @@ class TestAssignReviewersToPullRequest:mock_lookup.assert_not_called()@pytest.mark.django_db- def test_suggested_reviewers_receive_review_requests(self, org_and_team):+ @pytest.mark.parametrize(+ ("assignees", "reviewed_by", "expected_reviewer"),+ [+ (["Assigned"], ["Completed"], "assigned"),+ (["Lower-Ranked"], ["Completed"], "lower-ranked"),+ (["Assigned", "Lower-Ranked"], ["Completed", "Assigned"], "new-reviewer"),+ (["outside-report"], ["Completed"], "outside-report"),+ (["Assigned"], ["Assigned"], None),+ ([], ["Completed"], "assigned"),+ (["Author"], [], None),+ ],+ ids=[+ "top-ranked-assignee",+ "lower-ranked-assignee",+ "multiple-assignees",+ "unlisted-assignee",+ "owner-reviewed",+ "no-owner",+ "owner-is-author",+ ],+ )+ def test_suggested_reviewers_receive_review_requests(+ self,+ org_and_team: tuple[Organization, Team],+ assignees: list[str],+ reviewed_by: list[str],+ expected_reviewer: str | None,+ ) -> None:org, team = org_and_team- for login in ("author", "assigned", "requested", "completed", "new-reviewer"):+ for login in ("author", "assigned", "completed", "new-reviewer", "lower-ranked"):_make_reviewer(org, login, opted_in=False)- report = _make_report(team, ["author", "assigned", "requested", "completed", "new-reviewer"])+ report = _make_report(team, ["author", "assigned", "completed", "new-reviewer", "lower-ranked"])github = _open_pr_github()- github.get_pull_request.return_value.update(- {"author": "Author", "assignees": ["Assigned"], "requested_reviewers": ["Requested"]}- )- github.list_submitted_pull_request_reviewers.return_value = {"success": True, "reviewed_by": ["Completed"]}+ github.get_pull_request.return_value.update({"author": "Author", "assignees": assignees})+ github.list_submitted_pull_request_reviewers.return_value = {"success": True, "reviewed_by": reviewed_by}github.request_pull_request_reviews.return_value = {"success": True,- "requested_reviewers": ["requested", "new-reviewer"],+ "requested_reviewers": [expected_reviewer] if expected_reviewer else [],}with patch(@@ -214,10 +241,70 @@ class TestAssignReviewersToPullRequest:assigned = assign_reviewers_to_pull_request(team_id=team.id, report_id=str(report.id), pr_url=PR_URL)assert assigned == []- github.list_submitted_pull_request_reviewers.assert_called_once_with("PostHog/posthog", 123)- github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, ["new-reviewer"])+ if expected_reviewer:+ github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, [expected_reviewer])+ else:+ github.request_pull_request_reviews.assert_not_called()github.add_pull_request_assignees.assert_not_called()+ @pytest.mark.django_db+ @pytest.mark.parametrize(+ ("existing_field", "existing_value"),+ [+ ("requested_reviewers", ["human-choice"]),+ ("requested_teams", ["owning-team"]),+ ("requested_reviewers", ["Suggested"]),+ ],+ )+ @pytest.mark.parametrize("owner", [None, "suggested"])+ def test_an_existing_review_request_only_allows_the_owner(+ self, org_and_team: tuple[Organization, Team], existing_field: str, existing_value: list[str], owner: str | None+ ) -> None:+ org, team = org_and_team+ _make_reviewer(org, "suggested", opted_in=False)+ report = _make_report(team, ["suggested"])+ github = _open_pr_github()+ github.get_pull_request.return_value[existing_field] = existing_value+ github.get_pull_request.return_value["assignees"] = [owner] if owner else []++ with patch(+ "products.signals.backend.reviewer_pr_assignment.GitHubIntegration.first_for_team_repository",+ return_value=github,+ ):+ assign_reviewers_to_pull_request(team_id=team.id, report_id=str(report.id), pr_url=PR_URL)++ if owner and existing_value != ["Suggested"]:+ github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, [owner])+ else:+ github.list_submitted_pull_request_reviewers.assert_not_called()+ github.request_pull_request_reviews.assert_not_called()+ assert github.get_pull_request.return_value[existing_field] == existing_value++ @pytest.mark.django_db+ @pytest.mark.parametrize("owner", [None, "selected"])+ @pytest.mark.parametrize("removed", [{"selected"}, None])+ def test_removed_requests_and_unavailable_history_are_not_overridden(+ self, org_and_team: tuple[Organization, Team], owner: str | None, removed: set[str] | None+ ) -> None:+ org, team = org_and_team+ for login in ["selected", "other"]:+ _make_reviewer(org, login, opted_in=False)+ report = _make_report(team, ["selected", "other"])+ github = _open_pr_github()+ github.get_pull_request.return_value["assignees"] = [owner] if owner else []+ github.get_removed_pull_request_reviewers.return_value = removed++ with patch(+ "products.signals.backend.reviewer_pr_assignment.GitHubIntegration.first_for_team_repository",+ return_value=github,+ ):+ assign_reviewers_to_pull_request(team_id=team.id, report_id=str(report.id), pr_url=PR_URL)++ if owner is None and removed is not None:+ github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, ["other"])+ else:+ github.request_pull_request_reviews.assert_not_called()+@pytest.mark.django_db@pytest.mark.parametrize("pr",@@ -300,7 +387,7 @@ class TestAssignReviewersToPullRequest:github.list_submitted_pull_request_reviewers.assert_called_once_with("PostHog/posthog", 123)github.add_pull_request_assignees.assert_called_once_with("PostHog/posthog", 123, ["opted-in"])if failing_call == "request_pull_request_reviews":- github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, ["opted-out"])+ github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, ["opted-in"])@pytest.mark.django_dbdef test_a_url_that_is_not_a_pull_request_is_not_assigned(self, org_and_team):@@ -613,13 +700,18 @@ class TestDirectlyResponsibleIndividual:assert calls == ([[expected_owner]] if expected_owner else [])@pytest.mark.django_db- def test_the_dri_does_not_receive_a_review_request(self, org_and_team):+ @pytest.mark.parametrize("claimant", [None, "bob", "carol"])+ def test_assigning_the_dri_requests_their_review(+ self, org_and_team: tuple[Organization, Team], claimant: str | None+ ) -> None:org, team = org_and_team- report, _ = self._setup(org, team, ["alice", "bob"])+ report, users = self._setup(org, team, ["alice", "bob"])+ if claimant:+ self._claim(team, report, users, kind="user", login=claimant)github = self._github(existing_assignees=[], assignable=None)- assert self._assign(team, report, github) == [["alice"]]- github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, ["bob"])+ assert self._assign(team, report, github) == [[claimant or "alice"]]+ github.request_pull_request_reviews.assert_called_once_with("PostHog/posthog", 123, [claimant or "alice"])@pytest.mark.django_db@pytest.mark.parametrize(