:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(slack-app): render unsaved edits in insight link unfurl charts (#123928)
Vojta Bartošc021381f5ac4
diff --git a/products/slack_app/backend/slack_link_unfurl.py b/products/slack_app/backend/slack_link_unfurl.pyindex 288c82a1a24f..3d954ee1f818 100644--- a/products/slack_app/backend/slack_link_unfurl.py+++ b/products/slack_app/backend/slack_link_unfurl.py@@ -416,6 +416,8 @@ class _UnfurlCard:timestamp_label: str = "Updated"button: _CardButton | None = Nonechart_insight_id: int | None = None+ # Set for a saved insight link with unsaved edits. The chart renders this query instead of the saved one.+ chart_edited_query: dict | None = None# Set for an ad hoc insight. Its card goes out only together with its chart.chart_query: dict | None = Noneartifact_image: bool = False@@ -752,13 +754,19 @@ def _insight_card(ctx: _UnfurlContext, ref: str, url: str) -> _UnfurlCard | _Skilevel = ctx.uac.get_user_access_level(insight)if not level or not access_level_satisfied_for_resource("insight", level, "viewer"):return "no_access"+ # A link copied from the insight editor carries unsaved edits in `#q`, such as another date+ # range or hidden series. The person who opens the link sees these edits, so the card shows them too.+ edited_query = adhoc_insight_query(url)+ if edited_query == insight.query:+ edited_query = Nonereturn _UnfurlCard(label=_insight_resource_label(insight),title=insight.name or insight.derived_name or "Untitled",- details=(*filter(None, [_date_range(insight.query)]), *_by(insight.created_by)),+ details=(*filter(None, [_date_range(edited_query or insight.query)]), *_by(insight.created_by)),body=insight.description,timestamp=insight.last_modified_at,chart_insight_id=insight.id,+ chart_edited_query=edited_query,)@@ -1489,7 +1497,9 @@ def handle_posthog_link_unfurl(event: dict, integration: Integration) -> None:returnchart_requests = [- SlackUnfurlChartRequest(url=url, insight_id=card.chart_insight_id, title=card.title)+ SlackUnfurlChartRequest(url=url, query=card.chart_edited_query, title=card.title)+ if card.chart_edited_query is not None+ else SlackUnfurlChartRequest(url=url, insight_id=card.chart_insight_id, title=card.title)for url, (_, card) in cards.items()if card.chart_insight_id is not None and not compact]diff --git a/products/slack_app/backend/tests/test_link_unfurl.py b/products/slack_app/backend/tests/test_link_unfurl.pyindex 25cdad2f365d..782222ddba15 100644--- a/products/slack_app/backend/tests/test_link_unfurl.py+++ b/products/slack_app/backend/tests/test_link_unfurl.py@@ -338,8 +338,15 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):@parameterized.expand([- ("allowed", True, True),- ("public_sharing_off", False, False),+ ("allowed", True, None, True),+ ("public_sharing_off", False, None, False),+ (+ "edited_in_editor",+ True,+ {"kind": "InsightVizNode", "source": {"kind": "TrendsQuery", "dateRange": {"date_from": "-90d"}}},+ True,+ ),+ ("unchanged_in_editor", True, {"kind": "InsightVizNode", "source": {"kind": "TrendsQuery"}}, True),])@patch("products.slack_app.backend.tasks.start_slack_unfurl_charts.delay")@@ -350,6 +357,7 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):self,_name: str,public_sharing: bool,+ link_query: dict | None,expect_started: bool,mock_slack_integration_class: MagicMock,mock_resolve: MagicMock,@@ -363,6 +371,8 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):mock_resolve.return_value = MagicMock(user=self.user)mock_sync_connect.return_value.start_workflow = AsyncMock()url = f"http://testserver/project/{self.team.pk}/insights/{self.insight.short_id}"+ if link_query is not None:+ url += f"/edit?dashboard=1#q={quote(json.dumps(link_query))}"handle_posthog_link_unfurl({"channel": "C1", "message_ts": "123.456", "user": "U1", "links": [{"url": url}]},@@ -374,7 +384,10 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):start_workflow.assert_not_called()returninputs = start_workflow.call_args.args[1]- assert [chart.insight_id for chart in inputs.charts] == [self.insight.id]+ edited = link_query is not None and link_query != self.insight.query+ assert [(chart.insight_id, chart.query) for chart in inputs.charts] == [+ (None, link_query) if edited else (self.insight.id, None)+ ]assert (inputs.unfurls == mock_slack_integration_class.return_value.client.chat_unfurl.call_args.kwargs["unfurls"])