:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(replay-vision): warn legacy experiment-targeted scanners (#119887)
Kim Svatos Duganc1e3175ff713
diff --git a/frontend/snapshots.yml b/frontend/snapshots.ymlindex 509e3917b45d..67bc8c2c71bd 100644--- a/frontend/snapshots.yml+++ b/frontend/snapshots.yml@@ -14078,6 +14078,10 @@ snapshots:hash: v1.k794b7964.938b0069da1eb943fdd15aadb01c142603111292859bc34fea0f93bce95f7ac8.qVQYF7Gy-ISCeG-RjVYnDXF_HcEzaHxpM8A1atMZBdEscenes-app-replay-vision--monitor-overview-dashboard-offer--light:hash: v1.k794b7964.cc0d32580736768a2944ed90c09ef78ffac5e8c3ffc15d51307d7529f8a9a606.vEM-tv6APY-YhgbYYYe4LREOHBxr1SvVvsXVouNLnxE+ scenes-app-replay-vision--monitor-overview-legacy-targeting--dark:+ hash: v1.k794b7964.5062ecdc77418ef6fb6ee4f0b2f4a89075b217fe4b18bbf2e9f9702482536a21.sYIm3tZsa8lhwnFWbzGbYAFEkPIhLwrUbZcs2NyWorE+ scenes-app-replay-vision--monitor-overview-legacy-targeting--light:+ hash: v1.k794b7964.ddaeb347cb376bd08f18b8cc5b441d98bcf9d23d8559baf6074e94546360f55d.AOi3CJpuDX3KmGQ_AhntLEMEVR61w_AMz0khoNN-DIgscenes-app-replay-vision--monitor-overview-with-root-cause--dark:hash: v1.k794b7964.95eb50d69e46376f28de8821b0d1dfa356c08db91249e14f900cb54e7d58c278.oCAAFUd8iCTVgaeYB6ogtIxzaALytcTJ7tuCFgqEED8scenes-app-replay-vision--monitor-overview-with-root-cause--light:diff --git a/products/replay_vision/frontend/replay_scanners/ReplayScanner.tsx b/products/replay_vision/frontend/replay_scanners/ReplayScanner.tsxindex 569c0cbebeb2..6877344d3e35 100644--- a/products/replay_vision/frontend/replay_scanners/ReplayScanner.tsx+++ b/products/replay_vision/frontend/replay_scanners/ReplayScanner.tsx@@ -19,6 +19,7 @@ import { visionQuotaLogic } from '../logics/visionQuotaLogic'import { getReplayVisionEditDisabledReason } from '../utils/accessControl'import { formatCreditsRange } from '../utils/credits'import { quotaBannerState } from '../utils/quotaProjection'+import { LegacyExperimentTargetingBanner } from './components/LegacyExperimentTargetingBanner'import { ScannerObservationsTable } from './components/ScannerObservationsTable'import { ScannerOverview } from './components/ScannerOverview'import { replayScannerLogic } from './replayScannerLogic'@@ -96,6 +97,7 @@ export function ReplayScannerSceneComponent(): JSX.Element {<IngestionLimitBanner /><QuotaBanner />+ {experimentScanners && <LegacyExperimentTargetingBanner scanner={scanner} />}<LemonTabs// Only an experiment scanner has a Variants tab, so a stale ?tab=variants falls back.diff --git a/products/replay_vision/frontend/replay_scanners/ReplayScannersScene.stories.tsx b/products/replay_vision/frontend/replay_scanners/ReplayScannersScene.stories.tsxindex d8de7f161eb3..dba9eb91e8b9 100644--- a/products/replay_vision/frontend/replay_scanners/ReplayScannersScene.stories.tsx+++ b/products/replay_vision/frontend/replay_scanners/ReplayScannersScene.stories.tsx@@ -1247,6 +1247,15 @@ export const MonitorOverview: StoryObj = {decorators: [overviewDecorator(monitorOverviewScanner, monitorOverviewStats, activeSelfDrivingStats)],}+// A scanner with legacy experiment targeting points its owner to an experiment scanner.+export const MonitorOverviewLegacyTargeting: StoryObj = {+ parameters: {+ pageUrl: urls.replayVision(monitorOverviewScanner.id),+ featureFlags: { [FEATURE_FLAGS.VISION_EXPERIMENT_SCANNER]: true },+ },+ decorators: [overviewDecorator(monitorOverviewScanner, monitorOverviewStats, activeSelfDrivingStats)],+}+// Expensive filters stretch the sweep to its hourly ceiling, so the status strip reports it as throttled.export const ScannerStatusThrottled: StoryObj = {parameters: { pageUrl: urls.replayVision(summarizerScanner.id) },diff --git a/products/replay_vision/frontend/replay_scanners/components/LegacyExperimentTargetingBanner.tsx b/products/replay_vision/frontend/replay_scanners/components/LegacyExperimentTargetingBanner.tsxnew file mode 100644index 000000000000..fa7af7932180--- /dev/null+++ b/products/replay_vision/frontend/replay_scanners/components/LegacyExperimentTargetingBanner.tsx@@ -0,0 +1,49 @@+import { combineUrl } from 'kea-router'+import posthog from 'posthog-js'++import { useOnMountEffect } from 'lib/hooks/useOnMountEffect'+import { LemonBanner } from 'lib/lemon-ui/LemonBanner'+import { urls } from 'scenes/urls'++import { getReplayVisionEditDisabledReason } from '../../utils/accessControl'+import { legacyTargetingUpgradeParams } from '../experimentTargeting'+import type { ReplayScanner } from '../types'++export function LegacyExperimentTargetingBanner({ scanner }: { scanner: ReplayScanner }): JSX.Element | null {+ const params = legacyTargetingUpgradeParams(scanner)+ if (!params) {+ return null+ }+ return <VisibleLegacyExperimentTargetingBanner scanner={scanner} params={params} />+}++function VisibleLegacyExperimentTargetingBanner({+ scanner,+ params,+}: {+ scanner: ReplayScanner+ params: Record<string, string>+}): JSX.Element {+ const eventProperties = { scanner_id: scanner.id, scanner_type: scanner.scanner_type, enabled: scanner.enabled }+ useOnMountEffect(() => {+ posthog.capture('replay_vision_legacy_targeting_banner_shown', eventProperties)+ })++ return (+ <LemonBanner+ type="warning"+ action={{+ children: 'Create experiment scanner',+ to: combineUrl(urls.replayVisionScannerDetails('new'), params).url,+ onClick: () => posthog.capture('replay_vision_legacy_targeting_upgrade_clicked', eventProperties),+ // Creating a scanner needs resource-level edit access, not this scanner's own level.+ disabledReason: getReplayVisionEditDisabledReason(),+ 'data-attr': 'vision-legacy-targeting-upgrade',+ }}+ >+ We added experiment scanners, and they are now the only scanners that can watch an experiment. The+ experiment targeting on this scanner will stop working soon. To keep watching this experiment, create an+ experiment scanner with the same experiment and filters.+ </LemonBanner>+ )+}diff --git a/products/replay_vision/frontend/replay_scanners/experimentTargeting.test.ts b/products/replay_vision/frontend/replay_scanners/experimentTargeting.test.tsindex 7ea25ea5d1fe..39895e4c4511 100644--- a/products/replay_vision/frontend/replay_scanners/experimentTargeting.test.ts+++ b/products/replay_vision/frontend/replay_scanners/experimentTargeting.test.ts@@ -3,6 +3,7 @@ import { Experiment } from '~/types'import {experimentScannerName,experimentScannerParams,+ legacyTargetingUpgradeParams,parseExperimentScannerParams,prefillScannerForExperiment,reconcileVariantKey,@@ -108,4 +109,28 @@ describe('experimentTargeting', () => {])('experimentScannerName(%j, …) fits the 255-char model limit', (base, experimentName, expected) => {expect(experimentScannerName(base, experimentName)).toEqual(expected)})++ it.each([['test'], [null]])(+ 'rebuilds a legacy-targeted scanner as an experiment scanner on the same variant (%j) and filters',+ (variant) => {+ const query = { kind: 'RecordingsQuery', filter_test_accounts: true, properties: [{ key: 'plan' }] }+ const scanner = {+ scanner_type: 'classifier',+ experiment_targeting: { experiment_id: 7, variant },+ query,+ } as unknown as ReplayScanner++ const params = legacyTargetingUpgradeParams(scanner)++ expect(parseExperimentScannerParams(params ?? {})).toEqual({ experimentId: 7, variantKey: variant })+ expect(JSON.parse(params?.filters ?? 'null')).toEqual(query)+ }+ )++ it.each([+ [{ scanner_type: 'classifier', experiment_targeting: null }],+ [{ scanner_type: 'experiment', scanner_config: { experiment_id: 7 }, experiment_targeting: null }],+ ])('offers no rebuild for a scanner without legacy targeting: %j', (scanner) => {+ expect(legacyTargetingUpgradeParams(scanner as unknown as ReplayScanner)).toBeNull()+ })})diff --git a/products/replay_vision/frontend/replay_scanners/experimentTargeting.ts b/products/replay_vision/frontend/replay_scanners/experimentTargeting.tsindex 78b92efadfba..27e9614e4454 100644--- a/products/replay_vision/frontend/replay_scanners/experimentTargeting.ts+++ b/products/replay_vision/frontend/replay_scanners/experimentTargeting.ts@@ -76,6 +76,22 @@ export function scannerExperimentScope(scanner: ReplayScanner | null | undefinedreturn { experimentId: targeting.experiment_id, variants: targeting.variant ? [targeting.variant] : null }}+/**+ * New-scanner wizard params that rebuild a legacy-targeted scanner as an experiment scanner, with the+ * same experiment, variant, and recording filters. The prompt stays behind: a monitor or classifier+ * question is not a useful focus for variant summaries. Null when the scanner has no legacy targeting.+ */+export function legacyTargetingUpgradeParams(scanner: ReplayScanner): Record<string, string> | null {+ const targeting = scanner.experiment_targeting+ if (scanner.scanner_type === 'experiment' || !targeting?.experiment_id) {+ return null+ }+ return {+ ...experimentScannerParams({ experimentId: targeting.experiment_id, variantKey: targeting.variant ?? null }),+ ...(scanner.query ? { filters: JSON.stringify(scanner.query) } : {}),+ }+}+/** The variants a scope watches, as a short phrase: "test variant", "a, b variants", or the fallback. */export function scopeVariantsLabel(scope: ScannerExperimentScope, everyVariant: string): string {if (!scope.variants?.length) {diff --git a/products/replay_vision/frontend/replay_scanners/replayScannerLogic.test.ts b/products/replay_vision/frontend/replay_scanners/replayScannerLogic.test.tsindex 4501a16d3f67..87a288dd276d 100644--- a/products/replay_vision/frontend/replay_scanners/replayScannerLogic.test.ts+++ b/products/replay_vision/frontend/replay_scanners/replayScannerLogic.test.ts@@ -171,6 +171,7 @@ describe('replayScannerLogic', () => {experiment_targeting: null,})expect(logic.values.scanner?.query).toMatchObject({ events: query.events })+ expect(logic.values.scanner?.name).toMatch(/experiment: Checkout redesign$/)// The experiment fixes the type, so the wizard offers no other type and no goal step.expect(logic.values.lockedToExperimentScanner).toBe(true)})diff --git a/products/replay_vision/frontend/replay_scanners/replayScannerLogic.ts b/products/replay_vision/frontend/replay_scanners/replayScannerLogic.tsindex 280e2bc6c8b3..a70e4dc2cae5 100644--- a/products/replay_vision/frontend/replay_scanners/replayScannerLogic.ts+++ b/products/replay_vision/frontend/replay_scanners/replayScannerLogic.ts@@ -2070,9 +2070,15 @@ export const replayScannerLogic = kea<replayScannerLogicType>([// The two deep links combine rather than compete: the replay filters entry// point sends targeting and filters together, because exposure can't ride// inside `query` and dropping either one silently rescopes the scanner.- const experimentBase = prefillQuery- ? { ...newScanner(teamName), query: prefillQuery }- : newScanner(teamName)+ // A blank start carries the monitor's default name, which reads wrong once the+ // prefill turns it into an experiment scanner.+ const experimentBase = {+ ...newScanner(teamName),+ ...(experimentScannersEnabled()+ ? { name: defaultScannerName(teamName, 'experiment') }+ : {}),+ ...(prefillQuery ? { query: prefillQuery } : {}),+ }// An experiment deep link expresses fresh intent, so it outranks a saved// draft; restoringDraft guards persistDraft so the prefill can't clobber the// draft this user may already have for the next plain entry.