Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(desktop): stop the compaction spinner after a repeated start (#125385)

Shy Alterc252b376dcf0
diff --git a/packages/agent/packages/agent/src/adapters/claude/claude-agent.ts b/packages/agent/packages/agent/src/adapters/claude/claude-agent.ts
index 4f5fd13c7f65..1b1c36aa7fd5 100644
--- a/packages/agent/packages/agent/src/adapters/claude/claude-agent.ts
+++ b/packages/agent/packages/agent/src/adapters/claude/claude-agent.ts
@@ -1235,6 +1235,7 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
}
session.turnQueue = session.turnQueue.filter((t) => t !== turn);
session.activeTurn = null;
+ session.compacting = false;
this.dispatchQueuedInput(session);
// Attach the turn's gateway trace id (from the traceparent hook) so the
// server can stamp it on `_posthog/turn_complete`. Cleared here so a
@@ -1423,6 +1424,7 @@ export class ClaudeAcpAgent extends BaseAcpAgent {
// dedupe the duplicate terminal status the SDK emits for failed
// compactions.
if (message.status === "compacting") {
+ if (session.compacting) break;
session.compacting = true;
// Fall through to handleSystemMessage so the COMPACTING
// extNotification still fires.
diff --git a/packages/agent/packages/agent/src/adapters/claude/claude-agent.turn-queue.test.ts b/packages/agent/packages/agent/src/adapters/claude/claude-agent.turn-queue.test.ts
index 0caa441202d8..d6022b94c6a9 100644
--- a/packages/agent/packages/agent/src/adapters/claude/claude-agent.turn-queue.test.ts
+++ b/packages/agent/packages/agent/src/adapters/claude/claude-agent.turn-queue.test.ts
@@ -234,6 +234,101 @@ describe("ClaudeAcpAgent turn queue input dispatch", () => {
await expect(first).resolves.toBeDefined();
});
+ it("sends one compacting status when the SDK repeats the compacting signal", async () => {
+ const sessionId = "s-compacting-repeat";
+ const harness = installHarness(sessionId);
+ const first = harness.agent.prompt({
+ sessionId,
+ prompt: [{ type: "text", text: "first" }],
+ });
+ await tick();
+ echoTurn(harness.query, sessionOf(harness.agent).turnQueue[0].promptUuid);
+ await tick();
+ for (let i = 0; i < 3; i++) {
+ harness.query._mockHelpers.sendMessage({
+ type: "system",
+ subtype: "status",
+ status: "compacting",
+ } as unknown as SDKMessage);
+ await tick();
+ }
+
+ const extNotification = (
+ harness.agent as unknown as {
+ client: { extNotification: ReturnType<typeof vi.fn> };
+ }
+ ).client.extNotification;
+ const compactingStarts = extNotification.mock.calls.filter(
+ ([method, params]) =>
+ method === "_posthog/status" &&
+ params.status === "compacting" &&
+ !params.isComplete,
+ );
+ expect(compactingStarts).toHaveLength(1);
+
+ harness.query._mockHelpers.sendMessage(createSuccessResult());
+ await tick();
+ harness.query._mockHelpers.complete();
+ await expect(first).resolves.toBeDefined();
+ });
+
+ it("sends a new compacting status after a turn was cancelled during compaction", async () => {
+ const sessionId = "s-compacting-after-cancel";
+ const harness = installHarness(sessionId);
+ const extNotification = (
+ harness.agent as unknown as {
+ client: { extNotification: ReturnType<typeof vi.fn> };
+ }
+ ).client.extNotification;
+ const compactingStarts = () =>
+ extNotification.mock.calls.filter(
+ ([method, params]) =>
+ method === "_posthog/status" &&
+ params.status === "compacting" &&
+ !params.isComplete,
+ ).length;
+ const compacting = {
+ type: "system",
+ subtype: "status",
+ status: "compacting",
+ } as unknown as SDKMessage;
+
+ const first = harness.agent.prompt({
+ sessionId,
+ prompt: [{ type: "text", text: "first" }],
+ });
+ await tick();
+ echoTurn(harness.query, sessionOf(harness.agent).turnQueue[0].promptUuid);
+ await tick();
+ harness.query._mockHelpers.sendMessage(compacting);
+ await tick();
+ harness.query.interrupt.mockImplementation(async () => {});
+ await harness.agent.cancel({ sessionId });
+ harness.query._mockHelpers.sendMessage({
+ type: "system",
+ subtype: "session_state_changed",
+ state: "idle",
+ } as unknown as SDKMessage);
+ await tick();
+ await expect(first).resolves.toMatchObject({ stopReason: "cancelled" });
+
+ const compact = harness.agent.prompt({
+ sessionId,
+ prompt: [{ type: "text", text: "/compact" }],
+ });
+ await tick();
+ await tick();
+ harness.query._mockHelpers.sendMessage(compacting);
+ await tick();
+
+ expect(compactingStarts()).toBe(2);
+
+ harness.query._mockHelpers.sendMessage(createSuccessResult());
+ await tick();
+ harness.query._mockHelpers.complete();
+ await compact.catch(() => undefined);
+ });
+
it("resends a declined budget steer while the turn keeps working", async () => {
const sessionId = "s-steer-retry";
const guard = budgetGuard();
diff --git a/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.test.ts b/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.test.ts
index 7bf61eb6b951..5a3c3f2b337d 100644
--- a/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.test.ts
+++ b/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.test.ts
@@ -349,27 +349,68 @@ describe("buildConversationItems", () => {
},
);
- it("clears the compacting spinner on a successful completion status, without duplicating the row", () => {
- // A successful compaction sends a terminal `status: compacting, isComplete:
- // true`. It must flip the existing status row, not append a second one.
+ it.each([
+ { name: "one start signal", starts: 1 },
+ { name: "a repeated start signal", starts: 3 },
+ ])(
+ "clears the compacting spinner on a successful completion status, without duplicating the row, for $name",
+ ({ starts }) => {
+ // A successful compaction sends a terminal `status: compacting, isComplete:
+ // true`. It must flip the existing status row, not append a second one.
+ const result = buildConversationItems(
+ [
+ userPromptMsg(1, 1, "hi"),
+ ...Array.from({ length: starts }, (_, i) =>
+ statusMsg(2 + i, "compacting"),
+ ),
+ statusMsg(10, "compacting", true),
+ ],
+ null,
+ );
+
+ const statusItems = result.items.filter(
+ (i): i is Extract<ConversationItem, { type: "session_update" }> =>
+ i.type === "session_update" && i.update.sessionUpdate === "status",
+ );
+ expect(statusItems).toHaveLength(1);
+ expect(
+ (statusItems[0].update as { isComplete?: boolean }).isComplete,
+ ).toBe(true);
+ expect(result.isCompacting).toBe(false);
+ },
+ );
+
+ it("shows a new compaction after a turn was cancelled during compaction", () => {
+ const cancelledResponse: AcpMessage = {
+ type: "acp_message",
+ ts: 3,
+ message: { jsonrpc: "2.0", id: 1, result: { stopReason: "cancelled" } },
+ };
const result = buildConversationItems(
[
- userPromptMsg(1, 1, "hi"),
+ userPromptMsg(1, 1, "first"),
statusMsg(2, "compacting"),
- statusMsg(3, "compacting", true),
+ cancelledResponse,
+ userPromptMsg(4, 2, "second"),
+ statusMsg(5, "compacting"),
],
null,
);
- const statusItems = result.items.filter(
- (i): i is Extract<ConversationItem, { type: "session_update" }> =>
- i.type === "session_update" && i.update.sessionUpdate === "status",
- );
- expect(statusItems).toHaveLength(1);
- expect((statusItems[0].update as { isComplete?: boolean }).isComplete).toBe(
- true,
- );
- expect(result.isCompacting).toBe(false);
+ const statusRows = result.items
+ .filter(
+ (i): i is Extract<ConversationItem, { type: "session_update" }> =>
+ i.type === "session_update" && i.update.sessionUpdate === "status",
+ )
+ .map((i) => ({
+ turn: i.id.split("-item-")[0],
+ isComplete: (i.update as { isComplete?: boolean }).isComplete,
+ }));
+ expect(statusRows).toEqual([
+ { turn: "turn-1-1", isComplete: true },
+ { turn: "turn-4-2", isComplete: undefined },
+ ]);
+ expect(result.isCompacting).toBe(true);
});
it("builds a compact boundary without optional metadata", () => {
diff --git a/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.ts b/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.ts
index b26c5457334e..42d2982221a1 100644
--- a/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.ts
+++ b/products/desktop/packages/ui/src/features/sessions/components/buildConversationItems.ts
@@ -716,6 +716,8 @@ function completePromptTurn(
const wasCancelled = turn.stopReason === "cancelled";
turn.context.turnCancelled = wasCancelled;
+ if (b.isCompacting) markRuntimeStatusComplete(b, "compacting");
+
if (turn.gitAction.isGitAction && turn.gitAction.actionType) {
b.items.push({
type: "git_action_result",
@@ -958,6 +960,7 @@ function handleRuntimeStatus(
markRuntimeStatusComplete(b, "compacting");
return;
}
+ if (b.isCompacting) return;
b.isCompacting = true;
} else if (status.status === "compacting_failed") {
markRuntimeStatusComplete(b, "compacting");