:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(data-viz): sum sql chart rows that share an x value (#116856)
Sam Penningtonc9c228bc7f86
diff --git a/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.test.ts b/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.test.tsindex 0505a0d60280..f86dcc8c6d18 100644--- a/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.test.ts+++ b/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.test.ts@@ -13,7 +13,7 @@ import { ChartSettings, GoalLine } from '~/queries/schema/schema-general'import { ChartDisplayType } from '~/types'import { AxisSeries, AxisSeriesSettings } from '../../dataVisualizationLogic'-import { AxisBreakdownSeries } from '../seriesBreakdownLogic'+import { AxisBreakdownSeries, EmptyBreakdownSeries } from '../seriesBreakdownLogic'import { SqlChartProps } from './SqlChart'import {AREA_FILL_OPACITY,@@ -34,6 +34,7 @@ import {hasAxisTickFormatting,hasMixedSeriesTypes,seriesDisplayType,+ sqlChartData,sqlChartKind,} from './sqlLineGraphAdapter'@@ -311,6 +312,39 @@ describe('sqlLineGraphAdapter', () => {})})+ describe('sqlChartData', () => {+ const xData = (data: string[]): AxisSeries<string> => ({+ column: { name: 'week', type: { name: 'DATE', isNumerical: false }, label: 'week', dataIndex: 0 },+ data,+ })++ it('sums rows that share an x value so they do not overlap in one slot', () => {+ const result = sqlChartData(+ EmptyBreakdownSeries,+ xData(['2026-10-05', '2026-10-05', '2026-10-12', '2026-10-12']),+ [ySeries('rows_written', [100, 300, null, 400])],+ ChartDisplayType.ActionsBar+ )+ expect(result.xData?.data).toEqual(['2026-10-05', '2026-10-12'])+ expect(result.yData.map((series) => series.data)).toEqual([[400, 400]])+ })++ it('keeps the data unchanged when x values are unique', () => {+ const x = xData(['2026-10-05', '2026-10-12'])+ const yData = [ySeries('rows_written', [100, 300])]+ expect(sqlChartData(EmptyBreakdownSeries, x, yData, ChartDisplayType.ActionsBar)).toEqual({+ xData: x,+ yData,+ })+ })++ it('keeps one bar per row on a bar value chart', () => {+ const x = xData(['a', 'a'])+ const yData = [ySeries('count', [1, 2])]+ expect(sqlChartData(EmptyBreakdownSeries, x, yData, ChartDisplayType.ActionsBarValue).xData).toBe(x)+ })+ })+describe('capYSeriesData', () => {it('returns null for missing data', () => {expect(capYSeriesData(undefined as unknown as SqlChartProps['yData'])).toBeNull()diff --git a/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.ts b/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.tsindex 3e0d214a66b6..b6be54278d16 100644--- a/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.ts+++ b/frontend/src/queries/nodes/DataVisualization/Components/Charts/sqlLineGraphAdapter.ts@@ -30,11 +30,45 @@ import {} from 'products/product_analytics/frontend/insights/trends/shared/goalLinesAdapter'import { AxisSeries, AxisSeriesSettings, formatDataWithSettings } from '../../dataVisualizationLogic'-import { AxisBreakdownSeries } from '../seriesBreakdownLogic'+import { AxisBreakdownSeries, BreakdownSeriesData } from '../seriesBreakdownLogic'import { type SqlChartProps } from './SqlChart'export const MAX_SERIES = 200+/** Without a breakdown, rows that share an x value would draw on top of each other in one slot, so they+ * are summed per x value like the breakdown path does. A bar value chart draws one bar per row, so it keeps them. */+export const sqlChartData = (+ breakdown: BreakdownSeriesData<number | null>,+ xData: AxisSeries<string> | null,+ yData: AxisSeries<number | null>[],+ visualizationType: ChartDisplayType+): Pick<SqlChartProps, 'xData' | 'yData'> => {+ if (breakdown.xData.data.length) {+ return { xData: breakdown.xData, yData: breakdown.seriesData }+ }+ const uniqueX = Array.from(new Set(xData?.data))+ if (!xData || visualizationType === ChartDisplayType.ActionsBarValue || uniqueX.length === xData.data.length) {+ return { xData, yData }+ }+ const slotByX = new Map(uniqueX.map((x, index) => [x, index]))+ return {+ xData: { ...xData, data: uniqueX },+ yData: yData.map((series) => {+ if (!series.data.length) {+ return series+ }+ const data: (number | null)[] = uniqueX.map(() => null)+ series.data.forEach((value, index) => {+ const slot = slotByX.get(xData.data[index])+ if (value !== null && slot !== undefined) {+ data[slot] = (data[slot] ?? 0) + value+ }+ })+ return { ...series, data }+ }),+ }+}+/** Matches the legacy path's `hexToRGBA(seriesColor, 0.5)` area fill. */export const AREA_FILL_OPACITY = 0.5diff --git a/frontend/src/queries/nodes/DataVisualization/Components/seriesBreakdownLogic.ts b/frontend/src/queries/nodes/DataVisualization/Components/seriesBreakdownLogic.tsindex 7a0eabbf859c..026f123133fd 100644--- a/frontend/src/queries/nodes/DataVisualization/Components/seriesBreakdownLogic.ts+++ b/frontend/src/queries/nodes/DataVisualization/Components/seriesBreakdownLogic.ts@@ -4,6 +4,7 @@ import { DataColorTheme } from 'lib/colors'import { dataThemeLogic, getColorFromToken } from 'scenes/dataThemeLogic'import { NodeKind } from '~/queries/schema/schema-general'+import { ChartDisplayType } from '~/types'import { getBIResultDimensions } from 'products/business_intelligence/frontend/biEditorTypes'import { createBIMemberDisplayLookup } from 'products/business_intelligence/frontend/biMemberAliases'@@ -13,6 +14,8 @@ import type { AnyResponseType, ChartSettings, VisualizationNode } from '../../..import { AxisSeries, AxisSeriesSettings, SelectedYAxis, dataVisualizationLogic } from '../dataVisualizationLogic'import type { Column } from '../dataVisualizationLogic'import { humanizeEventColumnValue } from '../eventColumnLabels'+import type { SqlChartProps } from './Charts/SqlChart'+import { sqlChartData } from './Charts/sqlLineGraphAdapter'/*** Sentinel used to key result customizations for null / undefined breakdown values.@@ -90,11 +93,15 @@ export interface seriesBreakdownLogicValues {getTheme: (themeId: number | string | null | undefined) => DataColorTheme | null // dataThemeLogicchartSettings: ChartSettings // dataVisualizationLogiccolumns: Column[] // dataVisualizationLogic+ effectiveVisualizationType: ChartDisplayType // dataVisualizationLogicquery: VisualizationNode // dataVisualizationLogicresponse: AnyResponseType | null // dataVisualizationLogicselectedXAxis: string | null // dataVisualizationLogicselectedYAxis: (SelectedYAxis | null)[] | null // dataVisualizationLogic+ xData: AxisSeries<string> | null // dataVisualizationLogic+ yData: AxisSeries<number | null>[] // dataVisualizationLogicbreakdownColumnValues: string[]+ chartData: Pick<SqlChartProps, 'xData' | 'yData'>selectedSeriesBreakdownColumn: string | null | undefinedseriesBreakdownData: BreakdownSeriesData<number | null>showSeriesBreakdown: boolean@@ -137,6 +144,12 @@ export interface seriesBreakdownLogicMeta {getTheme: (themeId: number | string | null | undefined) => DataColorTheme | null, // dataThemeLogicquery: VisualizationNode) => BreakdownSeriesData<number | null>+ chartData: (+ seriesBreakdownData: BreakdownSeriesData<number | null>,+ xData: AxisSeries<string> | null, // dataVisualizationLogic+ yData: AxisSeries<number | null>[], // dataVisualizationLogic+ effectiveVisualizationType: ChartDisplayType // dataVisualizationLogic+ ) => Pick<SqlChartProps, 'xData' | 'yData'>}}@@ -155,7 +168,17 @@ export const seriesBreakdownLogic = kea<seriesBreakdownLogicType>([actions: [dataVisualizationLogic, ['clearAxis', 'setQuery']],values: [dataVisualizationLogic,- ['query', 'response', 'columns', 'selectedXAxis', 'selectedYAxis', 'chartSettings'],+ [+ 'query',+ 'response',+ 'columns',+ 'selectedXAxis',+ 'selectedYAxis',+ 'chartSettings',+ 'xData',+ 'yData',+ 'effectiveVisualizationType',+ ],dataThemeLogic,['getTheme'],],@@ -419,6 +442,16 @@ export const seriesBreakdownLogic = kea<seriesBreakdownLogicType>([}},],+ chartData: [+ (s) => [s.seriesBreakdownData, s.xData, s.yData, s.effectiveVisualizationType],+ (+ seriesBreakdownData: BreakdownSeriesData<number | null>,+ xData: AxisSeries<string> | null,+ yData: AxisSeries<number | null>[],+ effectiveVisualizationType: ChartDisplayType+ ): Pick<SqlChartProps, 'xData' | 'yData'> =>+ sqlChartData(seriesBreakdownData, xData, yData, effectiveVisualizationType),+ ],}),listeners(({ actions }) => ({addSeriesBreakdown: ({ columnName }) => {diff --git a/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx b/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsxindex e79f6b2a5045..b569068f9485 100644--- a/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx+++ b/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx@@ -237,7 +237,7 @@ function InternalDataTableVisualization(props: DataTableVisualizationProps): JSXconst isQuerySnapshot = query.kind === NodeKind.BIVisualizationNode && !!query.config.querySnapshotconst canDrill = query.kind === NodeKind.BIVisualizationNode && !isQuerySnapshot && !props.inSharedMode- const { seriesBreakdownData } = useValues(seriesBreakdownLogic({ key: dataVisualizationProps.key }))+ const { seriesBreakdownData, chartData } = useValues(seriesBreakdownLogic({ key: dataVisualizationProps.key }))const { goalLines } = useValues(displayLogic)// Overlay alert threshold bounds on the chart, like trends does — only when rendering a saved@@ -307,8 +307,7 @@ function InternalDataTableVisualization(props: DataTableVisualizationProps): JSXif (!isSqlChartVisualizationType(effectiveVisualizationType)) {return null}- const chartXData = seriesBreakdownData.xData.data.length ? seriesBreakdownData.xData : xData- const chartYData = seriesBreakdownData.xData.data.length ? seriesBreakdownData.seriesData : yData+ const { xData: chartXData, yData: chartYData } = chartDataconst xDimension = biConfig? getBIResultDimensions(biConfig).find(({ column }) => column === chartXData?.column.name): undefined@@ -337,17 +336,7 @@ function InternalDataTableVisualization(props: DataTableVisualizationProps): JSX}: dateAxis,}- }, [- effectiveVisualizationType,- seriesBreakdownData,- xData,- yData,- biConfig,- dateAxis,- isDateXAxis,- timezone,- dateBucket,- ])+ }, [effectiveVisualizationType, chartData, biConfig, dateAxis, isDateXAxis, timezone, dateBucket])const pieDisplayData = useMemo(() => {if (!PART_OF_WHOLE_DISPLAY_TYPES.includes(effectiveVisualizationType)) {diff --git a/frontend/src/scenes/data-warehouse/editor/OutputPane.tsx b/frontend/src/scenes/data-warehouse/editor/OutputPane.tsxindex 877ae4a8aa61..a1d4844c3205 100644--- a/frontend/src/scenes/data-warehouse/editor/OutputPane.tsx+++ b/frontend/src/scenes/data-warehouse/editor/OutputPane.tsx@@ -1043,7 +1043,10 @@ function InternalDataTableVisualization(presetChartHeight,} = useValues(dataVisualizationLogic)- const { seriesBreakdownData } = useValues(seriesBreakdownLogic({ key: dataVisualizationProps.key }))+ const {+ seriesBreakdownData,+ chartData: { xData: _xData, yData: _yData },+ } = useValues(seriesBreakdownLogic({ key: dataVisualizationProps.key }))const { goalLines } = useValues(displayLogic)const { editingInsight } = useValues(sqlEditorLogic)@@ -1069,8 +1072,6 @@ function InternalDataTableVisualization(/>)} else if (isSqlChartVisualizationType(effectiveVisualizationType)) {- const _xData = seriesBreakdownData.xData.data.length ? seriesBreakdownData.xData : xData- const _yData = seriesBreakdownData.xData.data.length ? seriesBreakdownData.seriesData : yDatacomponent = (<BindLogic logic={insightLogic} props={{ dashboardItemId: editingInsight?.short_id, doNotLoad: true }}><SqlChart