:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(signals): cap available reviewer searches (#124361)
posthog[bot]d120491a1661
diff --git a/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.test.tsx b/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.test.tsxindex 775aaa8cd55f..e365e1498441 100644--- a/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.test.tsx+++ b/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.test.tsx@@ -1,5 +1,5 @@import type { SignalReport } from "@posthog/shared/types";-import { render, screen } from "@testing-library/react";+import { act, fireEvent, render, screen } from "@testing-library/react";import userEvent from "@testing-library/user-event";import { beforeEach, describe, expect, it, vi } from "vitest";@@ -9,6 +9,7 @@ const mocks = vi.hoisted(() => ({trackResult: vi.fn(),refetchAvailable: vi.fn(),availableError: false,+ reviewerQueries: [] as string[],}));vi.mock("@posthog/ui/features/auth/authClient", () => ({@@ -26,24 +27,27 @@ vi.mock("@posthog/ui/features/inbox/hooks/useInboxReports", () => ({isError: false,refetch: vi.fn(),}),- useInboxAvailableSuggestedReviewers: () => ({- data: mocks.availableError- ? undefined- : {- count: 1,- results: [- {- uuid: "reviewer-1",- name: "Ada Lovelace",- email: "[email protected]",- github_login: "ada",- },- ],- },- isFetching: false,- isError: mocks.availableError,- refetch: mocks.refetchAvailable,- }),+ useInboxAvailableSuggestedReviewers: (options: { query: string }) => {+ mocks.reviewerQueries.push(options.query);+ return {+ data: mocks.availableError+ ? undefined+ : {+ count: 1,+ results: [+ {+ uuid: "reviewer-1",+ name: "Ada Lovelace",+ email: "[email protected]",+ github_login: "ada",+ },+ ],+ },+ isFetching: false,+ isError: mocks.availableError,+ refetch: mocks.refetchAvailable,+ };+ },useUpdateSuggestedReviewers: () => ({mutate: mocks.updateReviewers,isPending: false,@@ -73,6 +77,7 @@ describe("ReviewerSearchList", () => {beforeEach(() => {vi.clearAllMocks();mocks.availableError = false;+ mocks.reviewerQueries = [];});it("assigns the first reviewer when the report has no reviewer artefact", async () => {@@ -122,4 +127,21 @@ describe("ReviewerSearchList", () => {expect(mocks.refetchAvailable).toHaveBeenCalledOnce();expect(screen.queryByText("No users found.")).toBeNull();});++ it("debounces server-side reviewer searches", () => {+ vi.useFakeTimers();+ try {+ render(<ReviewerSearchList report={report} surface="context_menu" />);++ fireEvent.change(screen.getByLabelText("Search users"), {+ target: { value: "Ada" },+ });+ expect(mocks.reviewerQueries).not.toContain("Ada");++ act(() => vi.advanceTimersByTime(300));+ expect(mocks.reviewerQueries).toContain("Ada");+ } finally {+ vi.useRealTimers();+ }+ });});diff --git a/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.tsx b/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.tsxindex 7ba8db4aa700..576f074d4feb 100644--- a/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.tsx+++ b/products/desktop/packages/ui/src/features/inbox/components/ReviewerSearchList.tsx@@ -24,8 +24,9 @@ import {useReportActionResultTracker,useReportActionTracker,} from "@posthog/ui/features/inbox/hooks/useReportActionTracker";+import { useDebounce } from "@posthog/ui/primitives/hooks/useDebounce";import { LoadingState } from "@posthog/ui/primitives/LoadingState";-import { useDeferredValue, useMemo, useState } from "react";+import { useMemo, useState } from "react";function reviewerMatchesAvailable(reviewer: SuggestedReviewer,@@ -61,7 +62,7 @@ export function ReviewerSearchList({const artefact = selectSuggestedReviewersArtefact(data?.results ?? []);const reviewers = useMemo(() => artefact?.content ?? [], [artefact]);const [query, setQuery] = useState("");- const deferredQuery = useDeferredValue(query);+ const debouncedQuery = useDebounce(query, 300);const { mutate: updateReviewers, isPending } = useUpdateSuggestedReviewers(report.id,);@@ -72,14 +73,14 @@ export function ReviewerSearchList({refetch: refetchAvailableReviewers,} = useInboxAvailableSuggestedReviewers({enabled: !!client && enabled,- query: deferredQuery,+ query: debouncedQuery,});const options = useMemo(() => {const built = buildSuggestedReviewerFilterOptions(availableReviewers?.results ?? [],currentUser,);- const normalizedQuery = deferredQuery.trim().toLowerCase();+ const normalizedQuery = debouncedQuery.trim().toLowerCase();if (!normalizedQuery) return built;return built.filter((option) =>@@ -87,7 +88,7 @@ export function ReviewerSearchList({option.email.toLowerCase().includes(normalizedQuery) ||option.github_login.toLowerCase().includes(normalizedQuery),);- }, [availableReviewers?.results, currentUser, deferredQuery]);+ }, [availableReviewers?.results, currentUser, debouncedQuery]);const toggleReviewer = (option: AvailableSuggestedReviewer): void => {const existing = reviewers.find((reviewer) =>diff --git a/products/signals/backend/report_generation/resolve_reviewers.py b/products/signals/backend/report_generation/resolve_reviewers.pyindex 6c797ac89d3b..4f41384f62f8 100644--- a/products/signals/backend/report_generation/resolve_reviewers.py+++ b/products/signals/backend/report_generation/resolve_reviewers.py@@ -13,7 +13,7 @@ from uuid import UUIDfrom django.db.models import Expression, Prefetch, Q, QuerySet, Subquery, Valuefrom django.db.models.fields.json import KeyTextTransform, KeyTransform-from django.db.models.functions import Concat, Lower+from django.db.models.functions import Coalesce, Concat, Lowerfrom django.utils import timezonefrom social_django.models import UserSocialAuth@@ -914,20 +914,34 @@ def resolve_org_users_by_uuid(team_id: int, user_uuids: Iterable[str]) -> dict[sreturn {str(user.uuid): user for user in users}-def get_org_member_users_by_uuid(team_id: int) -> dict[str, User] | None:- """Every active org member on the team's organization, keyed by user UUID.-- Backs the inbox reviewer picker. A linked GitHub identity is not required, so a member who- never connected GitHub can be picked (and can pick themselves). Returns None if the team doesn't- exist, otherwise a dict (possibly empty).- """+def search_org_member_users_by_uuid(team_id: int, *, query: str = "", limit: int) -> dict[str, User] | None:+ """Search active org members for the inbox reviewer picker, keyed by user UUID."""try:org_id = str(Team.objects.values_list("organization_id", flat=True).get(id=team_id))except Team.DoesNotExist:return Nonemember_ids = OrganizationMembership.objects.filter(organization_id=org_id).values_list("user_id", flat=True)- users = User.objects.filter(id__in=member_ids, is_active=True).order_by("id")+ users = User.objects.filter(id__in=member_ids, is_active=True)+ if query:+ users = users.annotate(+ _full_name=Concat(+ Coalesce("first_name", Value("")),+ Value(" "),+ Coalesce("last_name", Value("")),+ )+ ).filter(+ Q(first_name__icontains=query)+ | Q(last_name__icontains=query)+ | Q(email__icontains=query)+ | Q(_full_name__icontains=query)+ )+ users = users.order_by(+ Lower(Coalesce("first_name", Value(""))),+ Lower(Coalesce("last_name", Value(""))),+ Lower(Coalesce("email", Value(""))),+ "uuid",+ )[:limit]return {str(user.uuid): user for user in users}diff --git a/products/signals/backend/test/test_signal_report_api.py b/products/signals/backend/test/test_signal_report_api.pyindex 427074aff1a4..30cc9b6d2f0c 100644--- a/products/signals/backend/test/test_signal_report_api.py+++ b/products/signals/backend/test/test_signal_report_api.py@@ -4543,12 +4543,7 @@ class TestSignalReportMergeAPI(APIBaseTest):class TestAvailableReviewersAPI(APIBaseTest):- """GET signals/reports/available_reviewers/: returns every eligible org member (no cap), with server-side search."""-- def setUp(self):- super().setUp()- # The over-threshold report is throttled via the cache; clear it so each test starts fresh.- cache.clear()+ """GET signals/reports/available_reviewers/: returns a capped, searchable org-member list."""def _url(self, **query) -> str:base = f"/api/projects/{self.team.id}/signals/reports/available_reviewers/"@@ -4556,79 +4551,52 @@ class TestAvailableReviewersAPI(APIBaseTest):return basereturn f"{base}?{urlencode(query)}"- def _fake_user(self, n: int) -> SimpleNamespace:- return SimpleNamespace(- uuid=uuid.UUID(int=n),- first_name=f"User{n:04d}",- last_name="Tester",- email=f"user{n:04d}@example.com",- )-- def _member_map(self, count: int) -> dict[str, SimpleNamespace]:- return {str(uuid.UUID(int=n)): self._fake_user(n) for n in range(count)}+ @patch("products.signals.backend.views.AVAILABLE_REVIEWERS_LIMIT", 2)+ def test_caps_unfiltered_members(self):+ for first_name in ("Alice", "Bob", "Carol"):+ User.objects.create_and_join(+ self.organization,+ f"{first_name.lower()}@example.com",+ None,+ first_name=first_name,+ last_name="Tester",+ )- @patch("products.signals.backend.views.get_org_member_users_by_uuid")- def test_returns_all_members_without_cap(self, mock_map):- # 250 > the old hard cap of 100: every member must come back now.- mock_map.return_value = self._member_map(250)response = self.client.get(self._url())- assert response.status_code == status.HTTP_200_OK- assert len(response.json()) == 250- @patch("products.signals.backend.views.get_org_member_users_by_uuid")- def test_search_query_filters_server_side(self, mock_map):- mock_map.return_value = self._member_map(250)- response = self.client.get(self._url(query="User0123"))assert response.status_code == status.HTTP_200_OK- body = response.json()- assert len(body) == 1- assert next(iter(body.values()))["email"] == "[email protected]"+ emails = [reviewer["email"] for reviewer in response.json().values()]+ assert len(emails) == 2+ assert "[email protected]" in emails+ assert "[email protected]" not in emails++ @patch("products.signals.backend.views.AVAILABLE_REVIEWERS_LIMIT", 2)+ def test_search_query_filters_before_applying_the_cap(self):+ for first_name, last_name in (("Alice", "Zephyr"), ("Bob", "Yellow"), ("Carol", "Xavier")):+ User.objects.create_and_join(+ self.organization,+ f"{first_name.lower()}@example.com",+ None,+ first_name=first_name,+ last_name=last_name,+ )- @patch("products.signals.backend.views.capture_exception")- @patch("products.signals.backend.views.get_org_member_users_by_uuid")- def test_no_exception_captured_under_threshold(self, mock_map, mock_capture):- mock_map.return_value = self._member_map(50)- response = self.client.get(self._url())- assert response.status_code == status.HTTP_200_OK- mock_capture.assert_not_called()+ response = self.client.get(self._url(query="Carol Xavier"))- @patch("products.signals.backend.views.capture_exception")- @patch("products.signals.backend.views.get_org_member_users_by_uuid")- def test_exception_captured_over_threshold(self, mock_map, mock_capture):- mock_map.return_value = self._member_map(1201)- response = self.client.get(self._url())- assert response.status_code == status.HTTP_200_OK- assert len(response.json()) == 1201- mock_capture.assert_called_once()-- @patch("products.signals.backend.views.capture_exception")- @patch("products.signals.backend.views.get_org_member_users_by_uuid")- def test_threshold_capture_deduplicated_across_requests(self, mock_map, mock_capture):- # Repeated popover opens for the same over-threshold org must report at most once.- mock_map.return_value = self._member_map(1201)- for _ in range(3):- assert self.client.get(self._url()).status_code == status.HTTP_200_OK- mock_capture.assert_called_once()-- @patch("products.signals.backend.views.capture_exception")- @patch("products.signals.backend.views.get_org_member_users_by_uuid")- def test_threshold_not_triggered_by_search_requests(self, mock_map, mock_capture):- # A search-as-you-type request must not spam the threshold capture.- mock_map.return_value = self._member_map(1201)- response = self.client.get(self._url(query="User0001"))assert response.status_code == status.HTTP_200_OK- mock_capture.assert_not_called()+ body = response.json()+ assert len(body) == 1+ assert next(iter(body.values()))["email"] == "[email protected]"- @patch("products.signals.backend.views.get_org_member_users_by_uuid")+ @patch("products.signals.backend.views.search_org_member_users_by_uuid")def test_empty_org_returns_empty(self, mock_map):mock_map.return_value = {}response = self.client.get(self._url())assert response.status_code == status.HTTP_200_OKassert response.json() == {}- @patch("products.signals.backend.views.get_org_member_users_by_uuid")+ @patch("products.signals.backend.views.search_org_member_users_by_uuid")def test_missing_team_map_returns_empty(self, mock_map):- # The helper returns None for an unknown team; the view coalesces it to an empty result.mock_map.return_value = Noneresponse = self.client.get(self._url())assert response.status_code == status.HTTP_200_OKdiff --git a/products/signals/backend/views.py b/products/signals/backend/views.pyindex 8e833cea7b49..82ffb60eebba 100644--- a/products/signals/backend/views.py+++ b/products/signals/backend/views.py@@ -67,7 +67,6 @@ from posthog.dataclasses import frozenfrom posthog.egress.github.transport import GitHubEgressBudgetExhausted, GitHubRateLimitErrorfrom posthog.egress.limiter.policies import Priorityfrom posthog.event_usage import report_user_action-from posthog.exceptions_capture import capture_exceptionfrom posthog.models import Team, Userfrom posthog.models.activity_logging.activity_log import Change, Detail, log_activityfrom posthog.models.activity_logging.model_activity import is_impersonated_session@@ -192,11 +191,11 @@ from products.signals.backend.report_generation.resolve_reviewers import (ReviewerPayloadIndex,bounded_reviewer_reason,get_org_member_github_logins_by_user_uuid,- get_org_member_users_by_uuid,normalized_github_logins_from_suggested_reviewer_artefacts,normalized_user_uuids_from_suggested_reviewer_artefacts,resolve_org_github_login_to_users,resolve_org_users_by_uuid,+ search_org_member_users_by_uuid,source_skills_from_suggested_reviewer_artefacts,)from products.signals.backend.report_generation.reviewer_telemetry import capture_suggested_reviewers_resolved@@ -323,12 +322,7 @@ from products.warehouse_sources.backend.facade.models import ExternalDataSchemalogger = structlog.get_logger(__name__)tracer = trace.get_tracer(__name__)-# `available_reviewers` returns every eligible org member in a single unpaginated payload.-# Org membership is tiny in practice, so even the biggest-# org today serialises to well under 100 KB. If an org ever exceeds this threshold we want a-# signal that it's time to add real pagination, rather than silently truncating the list (the-# old behaviour, which capped at 100 and dropped everyone alphabetically after ~"M").-REVIEWER_PAGINATION_THRESHOLD = 1200+AVAILABLE_REVIEWERS_LIMIT = 100PR_GITHUB_CACHE_SECONDS = 15_PULL_REQUEST_ID_PARAMETER = OpenApiParameter("pull_request_id",@@ -2953,7 +2947,7 @@ class SignalReportViewSet(type=OpenApiTypes.STR,location=OpenApiParameter.QUERY,required=False,- description="Case-insensitive filter on name or email.",+ description="Case-insensitive filter on name or email. Use search to find members outside the first 100 results.",)],# A map keyed by user UUID, so there is no serializer shape to declare.@@ -2970,66 +2964,31 @@ class SignalReportViewSet("required": ["name", "email"],},},- description="Candidate reviewers keyed by user UUID.",+ description="Up to 100 candidate reviewers keyed by user UUID.",)},)@action(detail=False, methods=["get"], url_path="available_reviewers", required_scopes=["task:read"])def available_reviewers(self, request, **kwargs):with tracer.start_as_current_span("signals.available_reviewers") as span:- # Every org member, not only the GitHub-linked ones: a reviewer is a PostHog user, so a- # teammate who never connected GitHub is still pickable — and can pick themselves.- users_by_uuid = get_org_member_users_by_uuid(self.team.id) or {}+ # Search all org members, not only the GitHub-linked ones: a reviewer is a PostHog user,+ # so a teammate who never connected GitHub is still pickable — and can pick themselves.query = (request.query_params.get("query") or "").strip().lower()-- candidate_count = len(users_by_uuid)- span.set_attribute("signals.available_reviewers.candidate_count", candidate_count)-- # The full candidate list is returned unpaginated. If an org grows past the threshold,- # report it (non-blocking) so we know to add pagination before the payload gets large.- # `capture_exception` logs an exception and is not deduplicated, so we throttle to at- # most one report per org per day via the cache — otherwise a >threshold org would log- # on every popover open. (The span's candidate_count attribute is recorded every request- # regardless, if a metric-based alert is preferred later.)- if (- not query- and candidate_count > REVIEWER_PAGINATION_THRESHOLD- and cache.add(f"signals:available_reviewers_over_threshold:{self.team.id}", True, 60 * 60 * 24)- ):- capture_exception(- Exception(- f"available_reviewers exceeded pagination threshold: {candidate_count} "- f"candidates > {REVIEWER_PAGINATION_THRESHOLD}; this endpoint should be paginated."- ),- additional_properties={- "team_id": self.team.id,- "candidate_count": candidate_count,- "threshold": REVIEWER_PAGINATION_THRESHOLD,- },+ users_by_uuid = (+ search_org_member_users_by_uuid(+ self.team.id,+ query=query,+ limit=AVAILABLE_REVIEWERS_LIMIT,)-- filtered_users = [- (user_uuid, user)- for user_uuid, user in users_by_uuid.items()- if not query- or query in f"{user.first_name} {user.last_name}".strip().lower()- or query in (user.email or "").lower()- ]+ or {}+ )reviewers = {user_uuid: {"name": f"{user.first_name} {user.last_name}".strip(),"email": user.email or "",}- for user_uuid, user in sorted(- filtered_users,- key=lambda item: (- (item[1].first_name or "").lower(),- (item[1].last_name or "").lower(),- (item[1].email or "").lower(),- item[0],- ),- )+ for user_uuid, user in users_by_uuid.items()}span.set_attribute("signals.available_reviewers.result_count", len(reviewers))diff --git a/products/signals/frontend/generated/api.schemas.ts b/products/signals/frontend/generated/api.schemas.tsindex 7964334c3a77..b90a9f54d49f 100644--- a/products/signals/frontend/generated/api.schemas.ts+++ b/products/signals/frontend/generated/api.schemas.ts@@ -10553,7 +10553,7 @@ export type SignalsReportChecksListParams = {export type SignalsReportsAvailableReviewersRetrieveParams = {/**- * Case-insensitive filter on name or email.+ * Case-insensitive filter on name or email. Use search to find members outside the first 100 results.*/query?: string}diff --git a/services/mcp/src/api/generated.ts b/services/mcp/src/api/generated.tsindex 2c2418779cf0..b42087763173 100644--- a/services/mcp/src/api/generated.ts+++ b/services/mcp/src/api/generated.ts@@ -139375,7 +139375,7 @@ export namespace Schemas {export type SignalsReportsAvailableReviewersRetrieveParams = {/**- * Case-insensitive filter on name or email.+ * Case-insensitive filter on name or email. Use search to find members outside the first 100 results.*/query?: string;};