:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
refactor(insights): stop backend reads of the results action field (#124128)
Thomas Obermüllerd236e88ab834
diff --git a/products/product_analytics/backend/hogql_queries/trends/test/test_trends_query_runner.py b/products/product_analytics/backend/hogql_queries/trends/test/test_trends_query_runner.pyindex 842f5493c51c..67c5b0acdf1c 100644--- a/products/product_analytics/backend/hogql_queries/trends/test/test_trends_query_runner.py+++ b/products/product_analytics/backend/hogql_queries/trends/test/test_trends_query_runner.py@@ -4054,7 +4054,7 @@ class TestTrendsQueryRunner(ClickhouseTestMixin, APIBaseTest):event="$pageview",distinct_id=f"person_{value}",timestamp="2020-01-11T12:00:00Z",- properties={"breakdown_value": f"{value}"},+ properties={"breakdown_value": f"{value}", "amount": 7},)# line graph@@ -4085,6 +4085,19 @@ class TestTrendsQueryRunner(ClickhouseTestMixin, APIBaseTest):# 10% of 30 is 3, so check we're adjusting the results back upassert response.results[0]["aggregated_value"] > 5 and response.results[0]["aggregated_value"] < 30+ # property math is not scaled up+ runner = self._create_query_runner(+ "2020-01-01",+ "2020-01-31",+ IntervalType.MONTH,+ [EventsNode(event="$pageview", math=PropertyMathType.MAX, math_property="amount")],+ TrendsFilter(display=ChartDisplayType.BOLD_NUMBER),+ )+ runner.query.samplingFactor = 0.1+ response = runner.calculate()+ assert len(response.results) == 1+ assert response.results[0]["aggregated_value"] == 7+def test_trends_multiple_event_breakdowns(self):self._create_test_events()flush_persons_and_events()diff --git a/products/product_analytics/backend/hogql_queries/trends/trends_query_runner.py b/products/product_analytics/backend/hogql_queries/trends/trends_query_runner.pyindex b3930d87e090..225763a6a824 100644--- a/products/product_analytics/backend/hogql_queries/trends/trends_query_runner.py+++ b/products/product_analytics/backend/hogql_queries/trends/trends_query_runner.py@@ -587,9 +587,6 @@ class TrendsQueryRunner(AnalyticsQueryRunner[TrendsQueryResponse]):final_result.extend(formula_results)else:for series_results in returned_results:- for item in series_results:- item["order"] = item.get("action", {}).get("order", 0)-final_result.extend(series_results)has_more = False@@ -770,7 +767,7 @@ class TrendsQueryRunner(AnalyticsQueryRunner[TrendsQueryResponse]):if self.query.samplingFactor and self.query.samplingFactor != 1:factor = self.query.samplingFactor- math = series_object.get("action", {}).get("math")+ math = series.series.mathif "count" in series_object:series_object["count"] = correct_result_for_sampling(series_object["count"], factor, math)if "aggregated_value" in series_object:@@ -782,6 +779,7 @@ class TrendsQueryRunner(AnalyticsQueryRunner[TrendsQueryResponse]):correct_result_for_sampling(value, factor, math) for value in series_object["data"]]+ series_object["order"] = series.series_orderres.append(series_object)return resdiff --git a/products/product_analytics/skills/investigate-metric/scripts/compare_to_prior_periods.py b/products/product_analytics/skills/investigate-metric/scripts/compare_to_prior_periods.pyindex adb09c6203f6..ef23a63e30d8 100644--- a/products/product_analytics/skills/investigate-metric/scripts/compare_to_prior_periods.py+++ b/products/product_analytics/skills/investigate-metric/scripts/compare_to_prior_periods.py@@ -58,9 +58,7 @@ def extract_series(payload: dict) -> tuple[list[str], list[float], str, str]:data = series.get("data") or []label = series.get("label") or series.get("custom_name") or "metric"- interval = (series.get("filter") or {}).get("interval")- if not interval:- interval = (payload.get("query") or {}).get("interval")+ interval = (payload.get("query") or {}).get("interval")if not interval:interval = infer_interval_from_days(days)diff --git a/products/signals/backend/anomaly_scores/scoring.py b/products/signals/backend/anomaly_scores/scoring.pyindex 6099f6f9dfea..6b96eecd35a7 100644--- a/products/signals/backend/anomaly_scores/scoring.py+++ b/products/signals/backend/anomaly_scores/scoring.py@@ -709,7 +709,7 @@ def _series_definition(query: TrendsQuery, result: dict[str, Any]) -> dict[str,"formula": formulas[order] if order < len(formulas) else None,"series": [_series_node_definition(node) for node in query.series],}- order = (result.get("action") or {}).get("order")+ order = result.get("order")if order is None or order >= len(query.series):return {"label": result.get("label")}return _series_node_definition(query.series[order])diff --git a/products/signals/backend/test/test_anomaly_scores.py b/products/signals/backend/test/test_anomaly_scores.pyindex 4d292d24550f..d903e47143e6 100644--- a/products/signals/backend/test/test_anomaly_scores.py+++ b/products/signals/backend/test/test_anomaly_scores.py@@ -215,7 +215,7 @@ def _insight(series: list[EventsNode], **query: Any) -> Insight:def _result(order: int, label: str) -> dict[str, Any]:days = [f"2026-01-{day:02d}" for day in range(1, 6)]- return {"action": {"order": order}, "label": label, "days": days, "data": [1.0] * 5, "breakdown_value": None}+ return {"order": order, "label": label, "days": days, "data": [1.0] * 5, "breakdown_value": None}class TestScoreInsight(SimpleTestCase):@@ -297,7 +297,7 @@ class TestScoreInsight(SimpleTestCase):def result(breakdown: str, first_day: datetime, days: int) -> dict[str, Any]:return {- "action": {"order": 0},+ "order": 0,"label": "pageview","breakdown_value": breakdown,"days": [(first_day + timedelta(days=day)).strftime("%Y-%m-%d") for day in range(days)],@@ -389,7 +389,7 @@ class TestScoreInsight(SimpleTestCase):steps = np.linspace(1, 40, len(buckets)) * (1 + rng.normal(0, 0.3, size=len(buckets)))values = list(1000 + np.cumsum(steps))result = {- "action": {"order": 0},+ "order": 0,"label": "pageview","breakdown_value": None,"days": [bucket.strftime("%Y-%m-%d %H:%M:%S") for bucket in buckets],diff --git a/products/signals/backend/test/test_anomaly_scoring_tick.py b/products/signals/backend/test/test_anomaly_scoring_tick.pyindex f0b79a165e43..42c2c43e643e 100644--- a/products/signals/backend/test/test_anomaly_scoring_tick.py+++ b/products/signals/backend/test/test_anomaly_scoring_tick.py@@ -562,7 +562,7 @@ class TestTrainScoreSplit(BaseTest):self, insight: Insight, pick: InsightPick, now: datetime, data: list[float]) -> tuple[ScoreInsightResult, list[dict[str, Any]]]:days = [(now - timedelta(days=len(data) - 1 - day)).strftime("%Y-%m-%d") for day in range(len(data))]- results = [{"action": {"order": 0}, "label": "pageview", "days": days, "data": data, "breakdown_value": None}]+ results = [{"order": 0, "label": "pageview", "days": days, "data": data, "breakdown_value": None}]with (patch("products.signals.backend.anomaly_scores.scoring.TrendsQueryRunner") as runner,patch("products.signals.backend.anomaly_scores.tick.emit") as emit,