:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
chore(experiments): share one stub for the exposure-event flag in tests (#124527)
Phil Haackd3ecde0a4e60
diff --git a/products/experiments/backend/hogql_queries/test/experiment_query_runner/test_experiment_exposures_query_runner.py b/products/experiments/backend/hogql_queries/test/experiment_query_runner/test_experiment_exposures_query_runner.pyindex 87ed58b53529..a70be1fb0220 100644--- a/products/experiments/backend/hogql_queries/test/experiment_query_runner/test_experiment_exposures_query_runner.py+++ b/products/experiments/backend/hogql_queries/test/experiment_query_runner/test_experiment_exposures_query_runner.py@@ -3,7 +3,6 @@ from zoneinfo import ZoneInfoimport time_machinefrom posthog.test.base import _create_event, _create_person, flush_persons_and_events, snapshot_clickhouse_queries-from unittest.mock import patchfrom django.forms.models import model_to_dictfrom django.test import override_settings@@ -36,12 +35,12 @@ from products.experiments.backend.hogql_queries.experiment_exposures_query_runnefrom products.experiments.backend.hogql_queries.exposure_query_logic import (EXPERIMENT_EXPOSURE_EVENT,EXPERIMENT_EXPOSURE_EVENT_CUTOFF,- EXPERIMENT_EXPOSURE_EVENT_FLAG,)from products.experiments.backend.hogql_queries.test.experiment_query_runner.base import ExperimentQueryRunnerBaseTestfrom products.experiments.backend.hogql_queries.test.experiment_query_runner.utils import (create_standard_group_test_events,)+from products.experiments.backend.test.utils import patch_exposure_event_flagfrom products.feature_flags.backend.models.feature_flag import FeatureFlag@@ -257,12 +256,7 @@ class TestExperimentExposuresQueryRunner(ExperimentQueryRunnerBaseTest):exposure_criteria=experiment.exposure_criteria,)- # Only answer for the exposure-event flag; returning True for every flag would flip- # unrelated HogQL query modifiers on and break the query under test.- def fake_feature_enabled(flag_key: str, *args, **kwargs) -> bool:- return new_event_enabled if flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG else False-- with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ with patch_exposure_event_flag(enabled=new_event_enabled):response = ExperimentExposuresQueryRunner(team=self.team, query=query).calculate()self.assertEqual(response.total_exposures, expected_exposures)diff --git a/products/experiments/backend/hogql_queries/test/test_experiment_actors_query.py b/products/experiments/backend/hogql_queries/test/test_experiment_actors_query.pyindex 86721de5bf68..2a554d8f6f8d 100644--- a/products/experiments/backend/hogql_queries/test/test_experiment_actors_query.py+++ b/products/experiments/backend/hogql_queries/test/test_experiment_actors_query.py@@ -16,7 +16,6 @@ from posthog.test.base import (flush_persons_and_events,snapshot_clickhouse_queries,)-from unittest.mock import patchfrom django.test import override_settings@@ -44,6 +43,7 @@ from products.cohorts.backend.models.cohort import Cohortfrom products.cohorts.backend.models.util import print_cohort_hogql_queryfrom products.experiments.backend.hogql_queries.exposure_query_logic import EXPERIMENT_EXPOSURE_EVENT_CUTOFFfrom products.experiments.backend.hogql_queries.test.experiment_query_runner.base import ExperimentQueryRunnerBaseTest+from products.experiments.backend.test.utils import patch_exposure_event_flag@override_settings(IN_UNIT_TESTING=True)@@ -285,7 +285,7 @@ class TestExperimentActorsQuery(ExperimentQueryRunnerBaseTest, ClickhouseTestMixselect=["id", "person"],)- with patch("posthoganalytics.feature_enabled", return_value=True):+ with patch_exposure_event_flag(enabled=True):response = ActorsQueryRunner(query=actors_query, team=self.team).calculate()assert [row[1]["distinct_ids"][0] for row in response.results] == [distinct_id]diff --git a/products/experiments/backend/test/test_experiment_service.py b/products/experiments/backend/test/test_experiment_service.pyindex bd0739bbd801..36f4c6b820d2 100644--- a/products/experiments/backend/test/test_experiment_service.py+++ b/products/experiments/backend/test/test_experiment_service.py@@ -49,10 +49,7 @@ from products.experiments.backend.experiment_service import (_merge_saved_metric_links,_resolve_scalar_updates,)-from products.experiments.backend.hogql_queries.exposure_query_logic import (- EXPERIMENT_EXPOSURE_EVENT_CUTOFF,- EXPERIMENT_EXPOSURE_EVENT_FLAG,-)+from products.experiments.backend.hogql_queries.exposure_query_logic import EXPERIMENT_EXPOSURE_EVENT_CUTOFFfrom products.experiments.backend.metric_calculation.config import get_metric_calculation_configfrom products.experiments.backend.metric_calculation.results import _recalc_fingerprintfrom products.experiments.backend.metric_resolution import METRIC_BUILDERS@@ -72,6 +69,7 @@ from products.experiments.backend.models.experiment import (ExperimentTimeseriesRecalculation,)from products.experiments.backend.models.team_experiments_config import TeamExperimentsConfig+from products.experiments.backend.test.utils import patch_exposure_event_flagfrom products.feature_flags.backend.facade.api import set_flag_active, update_flagfrom products.feature_flags.backend.models.feature_flag import FeatureFlagfrom products.surveys.backend.models import Survey@@ -5418,10 +5416,7 @@ class TestExperimentService(APIBaseTest):),)- def fake_feature_enabled(key: str, *args: Any, **kwargs: Any) -> bool:- return flag_enabled if key == EXPERIMENT_EXPOSURE_EVENT_FLAG else False-- with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ with patch_exposure_event_flag(enabled=flag_enabled):cohort = service.create_exposure_cohort(experiment)assert cohort.filters is not Nonediff --git a/products/experiments/backend/test/test_freeze_exposure_clickhouse.py b/products/experiments/backend/test/test_freeze_exposure_clickhouse.pyindex 7841c8b58eea..70506f2f4128 100644--- a/products/experiments/backend/test/test_freeze_exposure_clickhouse.py+++ b/products/experiments/backend/test/test_freeze_exposure_clickhouse.py@@ -1,5 +1,4 @@from datetime import datetime, timedelta-from typing import Anyimport time_machinefrom posthog.test.base import APIBaseTest, ClickhouseTestMixin, _create_event, _create_person, flush_persons_and_events@@ -16,9 +15,9 @@ from products.experiments.backend.experiment_service import ExperimentServicefrom products.experiments.backend.hogql_queries.exposure_query_logic import (EXPERIMENT_EXPOSURE_EVENT,EXPERIMENT_EXPOSURE_EVENT_CUTOFF,- EXPERIMENT_EXPOSURE_EVENT_FLAG,)from products.experiments.backend.models.experiment import Experiment+from products.experiments.backend.test.utils import patch_exposure_event_flagfrom products.feature_flags.backend.models.feature_flag import FeatureFlag@@ -157,12 +156,7 @@ class TestFreezeExposureClickhouse(ClickhouseTestMixin, APIBaseTest):legacy_event_person = self._expose_person("legacy-event-user", "freeze-rollout-flag", exposed_at)flush_persons_and_events()- # Only answer for the exposure-event flag; returning True for every flag would flip- # unrelated flag-gated behavior on and change what's under test.- def fake_feature_enabled(flag_key: str, *args: Any, **kwargs: Any) -> bool:- return flag_enabled if flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG else False-- with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ with patch_exposure_event_flag(enabled=flag_enabled):uuids = self._service()._fetch_exposed_person_uuids(experiment)# The snapshot decides who keeps being served a variant, so it must count exposures ondiff --git a/products/experiments/backend/test/test_presentation_api.py b/products/experiments/backend/test/test_presentation_api.pyindex 084ecb668111..6f3db84e3c94 100644--- a/products/experiments/backend/test/test_presentation_api.py+++ b/products/experiments/backend/test/test_presentation_api.py@@ -47,10 +47,7 @@ from products.cohorts.backend.models.cohort import Cohortfrom products.event_definitions.backend.models.event_definition import EventDefinitionfrom products.experiments.backend.experiment_service import ExperimentServicefrom products.experiments.backend.health.context import ConditionSetTraffic-from products.experiments.backend.hogql_queries.exposure_query_logic import (- EXPERIMENT_EXPOSURE_EVENT_CUTOFF,- EXPERIMENT_EXPOSURE_EVENT_FLAG,-)+from products.experiments.backend.hogql_queries.exposure_query_logic import EXPERIMENT_EXPOSURE_EVENT_CUTOFFfrom products.experiments.backend.metric_calculation.config import (build_primary_calculation_configs,get_metric_calculation_config,@@ -69,6 +66,7 @@ from products.experiments.backend.models.web_experiment import WebExperimentfrom products.experiments.backend.presentation.serializers import ExperimentSerializerfrom products.experiments.backend.presentation.views import LIST_DEFERRED_FIELDS, EnterpriseExperimentsViewSetfrom products.experiments.backend.setup_context import EXPERIMENT_SETUP_CONTEXT_FLAG+from products.experiments.backend.test.utils import patch_exposure_event_flagfrom products.feature_flags.backend.facade.enums import FlagEvaluationsModefrom products.feature_flags.backend.models.evaluation_context import EvaluationContext, FeatureFlagEvaluationContextfrom products.feature_flags.backend.models.feature_flag import FeatureFlag@@ -734,10 +732,7 @@ class TestExperimentCRUD(_HoistFlagConfigClientMixin, APILicensedTest):start_date=EXPERIMENT_EXPOSURE_EVENT_CUTOFF + timedelta(days=start_offset_days),)- def fake_feature_enabled(flag_key: str, *args: Any, **kwargs: Any) -> bool:- return flag_enabled if flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG else False-- with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ with patch_exposure_event_flag(enabled=flag_enabled):response = self.client.get(f"/api/projects/{self.team.id}/experiments/{experiment.id}")self.assertEqual(response.status_code, status.HTTP_200_OK)@@ -1261,7 +1256,7 @@ class TestExperimentCRUD(_HoistFlagConfigClientMixin, APILicensedTest):with (time_machine.travel(EXPERIMENT_EXPOSURE_EVENT_CUTOFF + timedelta(days=now_offset_days), tick=False),- patch("posthoganalytics.feature_enabled", return_value=True),+ patch_exposure_event_flag(enabled=True),):serialized = ExperimentSerializer(experiment, context={"team_id": self.team.id, "get_team": lambda: self.team}@@ -7402,10 +7397,7 @@ class TestExperimentAuxiliaryEndpoints(_HoistFlagConfigClientMixin, ClickhouseTe)flush_persons_and_events()- def fake_feature_enabled(flag_key: str, *args: Any, **kwargs: Any) -> bool:- return flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG-- with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ with patch_exposure_event_flag(enabled=True):response = self.client.post(f"/api/projects/{self.team.id}/experiments/{created_experiment}/create_exposure_cohort_for_experiment/",{},diff --git a/products/experiments/backend/test/test_session_buckets_api.py b/products/experiments/backend/test/test_session_buckets_api.pyindex 84b2b7958a48..7b68fea8b7bf 100644--- a/products/experiments/backend/test/test_session_buckets_api.py+++ b/products/experiments/backend/test/test_session_buckets_api.py@@ -26,12 +26,12 @@ from products.experiments.backend import session_bucketsfrom products.experiments.backend.hogql_queries.exposure_query_logic import (EXPERIMENT_EXPOSURE_EVENT,EXPERIMENT_EXPOSURE_EVENT_CUTOFF,- EXPERIMENT_EXPOSURE_EVENT_FLAG,)from products.experiments.backend.models.experiment import Experimentfrom products.experiments.backend.models.team_experiments_config import TeamExperimentsConfigfrom products.experiments.backend.session_buckets import MAX_BUCKET_METRICS, MAX_BUCKET_SCAN_DAYS, MAX_BUCKET_SOURCESfrom products.experiments.backend.session_exposure import MAX_SESSION_DURATION_HOURS+from products.experiments.backend.test.utils import patch_exposure_event_flagfrom products.feature_flags.backend.models.feature_flag import FeatureFlagfrom ee.api.test.base import APILicensedTest@@ -570,12 +570,7 @@ class TestExperimentSessionBuckets(ClickhouseTestMixin, APILicensedTest):)flush_persons_and_events()- # Only answer for the exposure-event flag; returning True for every flag would flip- # unrelated HogQL query modifiers on and break the query under test.- def fake_feature_enabled(flag_key: str, *args: Any, **kwargs: Any) -> bool:- return flag_enabled if flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG else False-- with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ with patch_exposure_event_flag(enabled=flag_enabled):response = self._post_bucket(experiment, bucket="fired_any", metric_uuids=[PURCHASE_METRIC["uuid"]])# The bucket must hold the population the analysis queries count. An experiment on@@ -612,10 +607,7 @@ class TestExperimentSessionBuckets(ClickhouseTestMixin, APILicensedTest):)flush_persons_and_events()- def fake_feature_enabled(flag_key: str, *args: Any, **kwargs: Any) -> bool:- return flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG-- with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ with patch_exposure_event_flag(enabled=True):response = self._post_bucket(experiment, bucket="fired_any", metric_uuids=[PURCHASE_METRIC["uuid"]])# Under the rollout $experiment_exposure is the default exposure, not a custom choice, sodiff --git a/products/experiments/backend/test/test_session_exposure.py b/products/experiments/backend/test/test_session_exposure.pyindex e660aa28c9e6..4d13c4e725c2 100644--- a/products/experiments/backend/test/test_session_exposure.py+++ b/products/experiments/backend/test/test_session_exposure.py@@ -1,9 +1,7 @@import dataclassesfrom datetime import UTC, datetime-from typing import Anyfrom posthog.test.base import BaseTest-from unittest.mock import patchfrom parameterized import parameterizedfrom rest_framework.exceptions import ValidationError@@ -20,7 +18,6 @@ from products.experiments.backend.hogql_queries.exposure_query_logic import (DEFAULT_EXPOSURE_EVENT,EXPERIMENT_EXPOSURE_EVENT,EXPERIMENT_EXPOSURE_EVENT_CUTOFF,- EXPERIMENT_EXPOSURE_EVENT_FLAG,)from products.experiments.backend.models.experiment import Experimentfrom products.experiments.backend.replay_linkage import (@@ -32,6 +29,7 @@ from products.experiments.backend.replay_linkage import (resolve_in_session_exposure_semantics,)from products.experiments.backend.session_exposure import resolve_session_exposure+from products.experiments.backend.test.utils import patch_exposure_event_flagfrom products.feature_flags.backend.models.feature_flag import FeatureFlag@@ -178,11 +176,7 @@ class TestResolveInSessionExposureSemantics(BaseTest):team=self.team, project_id=self.team.project_id, event=EXPERIMENT_EXPOSURE_EVENT, property="$session_id")- # Only answer for the rollout flag; a blanket True would flip unrelated rollouts on too.- def rollout_only(flag_key: str, *args: Any, **kwargs: Any) -> bool:- return flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG-- with patch("posthoganalytics.feature_enabled", side_effect=rollout_only):+ with patch_exposure_event_flag(enabled=True):semantics = resolve_in_session_exposure_semantics(self.team, experiment)assert semantics.session_exposure is not Nonediff --git a/products/experiments/backend/test/utils.py b/products/experiments/backend/test/utils.pynew file mode 100644index 000000000000..aa42059ab748--- /dev/null+++ b/products/experiments/backend/test/utils.py@@ -0,0 +1,19 @@+from contextlib import AbstractContextManager+from typing import Any++from unittest.mock import patch++from products.experiments.backend.hogql_queries.exposure_query_logic import EXPERIMENT_EXPOSURE_EVENT_FLAG+++def patch_exposure_event_flag(*, enabled: bool) -> AbstractContextManager[Any]:+ """Patch posthoganalytics.feature_enabled to return `enabled` for EXPERIMENT_EXPOSURE_EVENT_FLAG.++ Every other flag returns False. A blanket True would also turn on unrelated flag-gated+ behavior, such as HogQL query modifiers, and change what the test exercises.+ """++ def fake_feature_enabled(flag_key: str, *args: Any, **kwargs: Any) -> bool:+ return enabled and flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG++ return patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled)