Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(tasks): stop a run planning when it has no repository checkout (#117823)

posthog[bot]d526e4ca9f2b
diff --git a/products/tasks/backend/facade/api.py b/products/tasks/backend/facade/api.py
index d274eb82ef4d..d7e1092c13ab 100644
--- a/products/tasks/backend/facade/api.py
+++ b/products/tasks/backend/facade/api.py
@@ -48,6 +48,7 @@ from django.utils import timezone as django_timezone
from django.utils.http import content_disposition_header
import posthoganalytics
+from rest_framework.exceptions import ValidationError
from posthog.api.tagged_item import cleanup_orphan_tags, set_tags_on_object
from posthog.clickhouse.query_tagging import tag_queries
@@ -7669,6 +7670,20 @@ def _capture_no_repo_selection_override(
logger.warning("signal_report_no_repo_selection_overridden capture failed for report %s: %s", report_id, e)
+def _capture_report_task_refused_without_repository(*, team: Team, report_id: str) -> None:
+ try:
+ posthoganalytics.capture(
+ distinct_id=str(team.uuid),
+ event="signal_report_implementation_refused_no_repository",
+ properties={"report_id": report_id, "team_id": team.id},
+ groups=groups(team=team),
+ )
+ except Exception as e:
+ logger.warning(
+ "signal_report_implementation_refused_no_repository capture failed for report %s: %s", report_id, e
+ )
+
+
def create_task_and_run(
team_id: int,
user_id: int | None,
@@ -7954,6 +7969,7 @@ def create_task(
if warm_retry_token is not None:
raise WarmRunActivationUnavailable("target_unavailable")
+ refuse_without_repository = False
# Inbox "Create PR" doesn't pre-select a repo, so resolve one here rather than creating a
# report-linked task that can never open a PR. "Implementation" (Create PR) and legacy clients
# (no relationship) always resolve one. "Discuss" (and any other non-implementation label)
@@ -7996,6 +8012,9 @@ def create_task(
)
if resolved_repository:
validated_data["repository"] = resolved_repository
+ refuse_without_repository = (
+ not resolved_repository and client_provenance != TaskClientProvenance.POSTHOG_DESKTOP
+ )
# The credential follows the entitlement, not the repository: an entitled report task carries
# the team's GitHub integration even when nothing resolved, so the agent can still clone what
@@ -8057,6 +8076,9 @@ def create_task(
# open a PR that billing never counts. That is an accepted risk of a sales trial.
if signal_report_task_relationship in (None, "implementation"):
enforce_self_driving_free_trial(team, report_id=signal_report_id)
+ if refuse_without_repository and signal_report is not None:
+ _capture_report_task_refused_without_repository(team=team, report_id=str(signal_report.id))
+ raise ValidationError({"repository": REPORT_IMPLEMENTATION_REPOSITORY_UNRESOLVED})
logger.info("Creating task with data: %s", validated_data)
with transaction.atomic():
@@ -8691,6 +8713,10 @@ def _attach_staged_artifacts_to_run(
REPORT_WARM_RUN_NOT_ACTIVATED = "This sandbox is waiting for the report's Ask AI question. Send it from the report."
+REPORT_IMPLEMENTATION_REPOSITORY_UNRESOLVED = (
+ "Couldn't tell which GitHub repository this report is about, so there is nowhere to open a PR. "
+ "Name the repository in the instructions for the PostHog agent (for example, owner/repo) and try again."
+)
class WarmRunActivationUnavailable(Exception):
diff --git a/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py b/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py
index 8c8e2abef39e..e08f45ee5a49 100644
--- a/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py
+++ b/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py
@@ -1226,7 +1226,7 @@ def clone_repository_in_sandbox(input: CloneRepositoryInSandboxInput) -> CloneRe
if clone_result.exit_code != 0:
error_output = clone_result.stderr or clone_result.stdout or clone_result.error or "No output captured"
raise RepositoryCloneError(
- f"Git clone failed with exit code {clone_result.exit_code}",
+ f"Could not clone {input.repository} (git exited with code {clone_result.exit_code})",
{
"repository": input.repository,
"sandbox_id": input.sandbox_id,
diff --git a/products/tasks/backend/temporal/process_task/activities/start_agent_server.py b/products/tasks/backend/temporal/process_task/activities/start_agent_server.py
index 71355ca6e410..c74bf1e0ad3a 100644
--- a/products/tasks/backend/temporal/process_task/activities/start_agent_server.py
+++ b/products/tasks/backend/temporal/process_task/activities/start_agent_server.py
@@ -184,13 +184,17 @@ def _ensure_repository_on_disk(ctx: TaskProcessingContext, sandbox: SandboxBase)
"""
if not ctx.repositories:
return
- for repository in ctx.repositories:
+ for index, repository in enumerate(ctx.repositories):
repo_path = sandbox_repo_path(repository)
- result = sandbox.execute(f"test -d {shlex.quote(repo_path)}", timeout_seconds=10)
+ if index == 0:
+ probe = f"test -e {shlex.quote(f'{repo_path}/.git')}"
+ else:
+ probe = f"test -d {shlex.quote(repo_path)}"
+ result = sandbox.execute(probe, timeout_seconds=10)
if result.exit_code != 0:
raise SandboxMissingRepositoryError(
- f"Repository {repository} is not present in the sandbox at {repo_path} — it was never "
- "cloned (no snapshot restored and no usable GitHub credentials for this task)",
+ f"Repository {repository} has no checkout in the sandbox at {repo_path} (no snapshot "
+ "restored, no usable GitHub credentials, or the clone failed)",
{
"task_id": ctx.task_id,
"run_id": ctx.run_id,
diff --git a/products/tasks/backend/temporal/process_task/activities/tests/test_provision_sandbox.py b/products/tasks/backend/temporal/process_task/activities/tests/test_provision_sandbox.py
index e3ddcae00896..ccf6d04e303c 100644
--- a/products/tasks/backend/temporal/process_task/activities/tests/test_provision_sandbox.py
+++ b/products/tasks/backend/temporal/process_task/activities/tests/test_provision_sandbox.py
@@ -587,7 +587,7 @@ def test_clone_failure_records_failed_latency_and_captures_command_result(mocker
),
)
- assert "exit code 124" in str(error.value)
+ assert "Could not clone posthog/posthog (git exited with code 124)" in str(error.value)
assert error.value.context == {
"repository": "posthog/posthog",
"sandbox_id": "sandbox-id",
diff --git a/products/tasks/backend/temporal/process_task/activities/tests/test_start_agent_server.py b/products/tasks/backend/temporal/process_task/activities/tests/test_start_agent_server.py
index 34320302c33a..7b01e7602271 100644
--- a/products/tasks/backend/temporal/process_task/activities/tests/test_start_agent_server.py
+++ b/products/tasks/backend/temporal/process_task/activities/tests/test_start_agent_server.py
@@ -829,7 +829,7 @@ def test_ensure_every_repository_is_on_disk(mocker) -> None:
)
assert [call.args[0] for call in sandbox.execute.call_args_list] == [
- f"test -d {sandbox_repo_path('PostHog/posthog')}",
+ f"test -e {sandbox_repo_path('PostHog/posthog')}/.git",
f"test -d {sandbox_repo_path('PostHog/posthog-js')}",
]
@@ -847,7 +847,7 @@ def test_ensure_repository_on_disk_fails_non_retryably_when_repo_missing(mocker)
_ensure_repository_on_disk(_context(repository="PostHog/posthog"), sandbox)
assert exc_info.value.non_retryable is True
- assert "never" in str(exc_info.value)
+ assert "no checkout" in str(exc_info.value)
def test_ensure_repository_on_disk_skips_repo_less_runs(mocker) -> None:
diff --git a/products/tasks/backend/temporal/process_task/tests/test_workflow.py b/products/tasks/backend/temporal/process_task/tests/test_workflow.py
index 8561e9f77993..84c8b3468303 100644
--- a/products/tasks/backend/temporal/process_task/tests/test_workflow.py
+++ b/products/tasks/backend/temporal/process_task/tests/test_workflow.py
@@ -3468,7 +3468,8 @@ class TestProcessTaskWorkflowUnit:
assert ready_inputs[1].failed_repositories == ["posthog/code"]
assert ready_inputs[1].release_barrier is False
- async def test_overlap_releases_agent_and_continues_when_primary_clone_fails(self, monkeypatch):
+ @pytest.mark.parametrize("fail_on_primary_clone_failure", [True, False])
+ async def test_overlap_primary_clone_failure(self, monkeypatch, fail_on_primary_clone_failure):
workflow = ProcessTaskWorkflow()
workflow._context = _build_context(
github_integration_id=123,
@@ -3517,9 +3518,23 @@ class TestProcessTaskWorkflowUnit:
raise AssertionError(f"Unexpected activity call: {activity_fn}")
monkeypatch.setattr(process_task_workflow_module.workflow, "execute_activity", fake_execute_activity)
- monkeypatch.setattr(process_task_workflow_module.workflow, "patched", lambda _: True)
+ monkeypatch.setattr(
+ process_task_workflow_module.workflow,
+ "patched",
+ lambda patch_id: (
+ fail_on_primary_clone_failure
+ or patch_id != process_task_workflow_module._PATCH_ID_FAIL_RUN_ON_PRIMARY_CLONE_FAILURE
+ ),
+ )
monkeypatch.setattr(process_task_workflow_module.workflow, "logger", Mock())
+ if fail_on_primary_clone_failure:
+ with pytest.raises(RuntimeError, match="clone timed out"):
+ await workflow._get_sandbox_for_repository()
+ assert mark_repo_ready not in calls
+ assert checkout_branch_in_sandbox not in calls
+ return
+
result = await workflow._get_sandbox_for_repository()
assert result.agent_server_launched is True
diff --git a/products/tasks/backend/temporal/process_task/workflow.py b/products/tasks/backend/temporal/process_task/workflow.py
index f2e2553cbcf5..1525c404304e 100644
--- a/products/tasks/backend/temporal/process_task/workflow.py
+++ b/products/tasks/backend/temporal/process_task/workflow.py
@@ -159,6 +159,7 @@ DEAD_SANDBOX_ERROR_TYPES = ("SandboxNotRunningError", "SandboxNotFoundError")
MAX_ACCEPTED_MESSAGE_IDS = 500
_PATCH_ID_CANCEL_SANDBOX_CREATION_ON_COMPLETION = "tasks-cancel-sandbox-creation-on-completion"
_PATCH_ID_CONTINUE_AFTER_REPOSITORY_CLONE_FAILURE = "tasks-continue-after-repository-clone-failure"
+_PATCH_ID_FAIL_RUN_ON_PRIMARY_CLONE_FAILURE = "tasks-fail-run-on-primary-clone-failure"
_PATCH_ID_ASYNC_AGENT_SHADOW_RESULT = "tasks-async-agent-shadow-result"
_PATCH_ID_AGENT_BOOT_INTERACTION_TELEMETRY = "tasks-agent-boot-interaction-telemetry"
_PATCH_ID_SHARED_STARTUP_TIMING = "tasks-shared-startup-timing"
@@ -2328,6 +2329,7 @@ class ProcessTaskWorkflow(PostHogWorkflow):
if will_clone:
await self._emit_progress("clone", "in_progress", "Cloning repository", "setup", wait=False)
continue_after_clone_failure = workflow.patched(_PATCH_ID_CONTINUE_AFTER_REPOSITORY_CLONE_FAILURE)
+ fail_on_primary_clone_failure = workflow.patched(_PATCH_ID_FAIL_RUN_ON_PRIMARY_CLONE_FAILURE)
async def clone_repository(
repository: str,
@@ -2348,6 +2350,8 @@ class ProcessTaskWorkflow(PostHogWorkflow):
except Exception as error:
if _is_dead_sandbox_failure(error) or not continue_after_clone_failure:
raise
+ if fail_on_primary_clone_failure and repository == repositories_to_clone[0]:
+ raise
workflow.logger.warning(
"repository_clone_failed_continuing_without_repository",
extra={
diff --git a/products/tasks/backend/tests/test_api.py b/products/tasks/backend/tests/test_api.py
index 6d87d8f6f05e..c0277cb53dad 100644
--- a/products/tasks/backend/tests/test_api.py
+++ b/products/tasks/backend/tests/test_api.py
@@ -2837,17 +2837,20 @@ class TestTaskAPI(BaseTaskAPITest):
from products.signals.backend.task_run_artefacts import TASK_RUN_TYPE_IMPLEMENTATION, signals_task_ids
report = SignalReport.objects.create(team=self.team)
- response = self.client.post(
- "/api/projects/@current/tasks/",
- {
- "title": "Signal Task",
- "description": "From a signal report",
- "origin_product": "signal_report",
- "signal_report": str(report.id),
- "signal_report_task_relationship": "implementation",
- },
- format="json",
- )
+ with patch(
+ "products.tasks.backend.logic.repo_selection.cascade.cascade_select_repository", return_value="acme/web"
+ ):
+ response = self.client.post(
+ "/api/projects/@current/tasks/",
+ {
+ "title": "Signal Task",
+ "description": "From a signal report",
+ "origin_product": "signal_report",
+ "signal_report": str(report.id),
+ "signal_report_task_relationship": "implementation",
+ },
+ format="json",
+ )
self.assertEqual(response.status_code, status.HTTP_201_CREATED)
data = response.json()
self.assertEqual(data["signal_report"], str(report.id))
@@ -3041,17 +3044,20 @@ class TestTaskAPI(BaseTaskAPITest):
from products.signals.backend.models import SignalReport, SignalScoutNote
report = SignalReport.objects.create(team=self.team, title="Checkout errors spiked")
- response = self.client.post(
- "/api/projects/@current/tasks/",
- {
- "title": "Discuss report",
- "description": _DISCUSS_PROMPT,
- "origin_product": "signal_report",
- "signal_report": str(report.id),
- "signal_report_task_relationship": relationship,
- },
- format="json",
- )
+ with patch(
+ "products.tasks.backend.logic.repo_selection.cascade.cascade_select_repository", return_value="acme/web"
+ ):
+ response = self.client.post(
+ "/api/projects/@current/tasks/",
+ {
+ "title": "Discuss report",
+ "description": _DISCUSS_PROMPT,
+ "origin_product": "signal_report",
+ "signal_report": str(report.id),
+ "signal_report_task_relationship": relationship,
+ },
+ format="json",
+ )
self.assertEqual(response.status_code, status.HTTP_201_CREATED)
notes = SignalScoutNote.objects.for_team(self.team.id).filter(origin=SignalScoutNote.Origin.REPORT_DISCUSSION)
if should_forward:
@@ -3238,17 +3244,20 @@ class TestTaskAPI(BaseTaskAPITest):
self.assertFalse(SignalReportTask.objects.filter(report=report, task_id=data["id"]).exists())
def _post_signal_report_task(self, report_id, relationship, title="Report task"):
- return self.client.post(
- "/api/projects/@current/tasks/",
- {
- "title": title,
- "description": "From a signal report",
- "origin_product": "signal_report",
- "signal_report": str(report_id),
- "signal_report_task_relationship": relationship,
- },
- format="json",
- )
+ with patch(
+ "products.tasks.backend.logic.repo_selection.cascade.cascade_select_repository", return_value="acme/web"
+ ):
+ return self.client.post(
+ "/api/projects/@current/tasks/",
+ {
+ "title": title,
+ "description": "From a signal report",
+ "origin_product": "signal_report",
+ "signal_report": str(report_id),
+ "signal_report_task_relationship": relationship,
+ },
+ format="json",
+ )
def _create_implementation_task_with_runs(self, report, run_specs, deleted=False):
from products.signals.backend.models import SignalReportTask
@@ -16997,8 +17006,14 @@ class TestCloudUsageGate(BaseTaskAPITest):
self.assertEqual(tasks_facade.task_exempt_from_code_access(task.id, self.team.id), expected)
- def test_create_signal_report_task_ignores_channel_repository(self):
- from products.signals.backend.models import SignalReport
+ @parameterized.expand(
+ [
+ ("web", None, status.HTTP_400_BAD_REQUEST),
+ ("desktop", TaskClientProvenance.POSTHOG_DESKTOP, status.HTTP_201_CREATED),
+ ]
+ )
+ def test_create_pr_without_resolvable_repository(self, _name, client_provenance, expected_status):
+ from products.signals.backend.models import SignalReport, SignalReportTask
from products.tasks.backend.models import Channel
report = SignalReport.objects.create(team=self.team)
@@ -17006,6 +17021,10 @@ class TestCloudUsageGate(BaseTaskAPITest):
with (
patch("products.signals.backend.facade.api.persisted_repo_selection", return_value=None),
patch("products.tasks.backend.logic.repo_selection.cascade.cascade_select_repository", return_value=None),
+ patch(
+ "products.tasks.backend.presentation.views.api.get_task_client_provenance",
+ return_value=client_provenance,
+ ),
):
response = self.client.post(
"/api/projects/@current/tasks/",
@@ -17019,7 +17038,12 @@ class TestCloudUsageGate(BaseTaskAPITest):
format="json",
)
- self.assertEqual(response.status_code, status.HTTP_201_CREATED)
+ self.assertEqual(response.status_code, expected_status, response.json())
+ if expected_status == status.HTTP_400_BAD_REQUEST:
+ self.assertEqual(response.json()["detail"], tasks_facade.REPORT_IMPLEMENTATION_REPOSITORY_UNRESOLVED)
+ self.assertFalse(Task.objects.filter(signal_report=report).exists())
+ self.assertFalse(SignalReportTask.objects.filter(report=report).exists())
+ return
task = Task.objects.get(id=response.json()["id"])
self.assertIsNone(task.repository)
self.assertNotIn("attacker/repo", task.repositories)