:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(inbox): make the waiting empty state permanent (#119825)
Georgiy Tarasovd68e9d52ac41
diff --git a/frontend/snapshots.yml b/frontend/snapshots.ymlindex fad723b041db..22b7a2fbdf87 100644--- a/frontend/snapshots.yml+++ b/frontend/snapshots.yml@@ -11654,10 +11654,6 @@ snapshots:hash: v1.k794b7964.84ca5122b26e214bb2ea40b015f0bf55afd75cd6abec7e6d6cfe00de3b5ad8ea._GlqfH7tjBLXdxhchkhBD2clKmbEeDZULIdtixR_jFsscenes-app-inbox-scene--empty--light:hash: v1.k794b7964.4cee88bf59c8c1b370ff46b4736e633840efa59c3838ffc2786cb93de6dbd243.W6FHb5RbypUEu_iic0_kjWiIn_nGVrGkrPBnMHmHAVk- scenes-app-inbox-scene--empty-control--dark:- hash: v1.k794b7964.5e28f5af2e473353cabf39d86622329c32e5915319a81dd01903b51993624c54.494fGxNe7_4yzWNIBi-5tznI-vpk9xe9xFyRvFwy1q4- scenes-app-inbox-scene--empty-control--light:- hash: v1.k794b7964.431f125fea9dc6821a2b6aa2fe4a6048a062f2cea5b1b00bf9514dfd09d73d94.qHtjAAbwC3PJIjqfcS2E448V78OIM4tz30bKu77Omdwscenes-app-inbox-scene--empty-with-many-scouts--dark:hash: v1.k794b7964.f317ce431f7683d0d3f243cce6a7431ccaace370e74c3d25c93339c00c9bad63.yDLBiHj337vJez3JG8kG__Fg6XNWkVyA8tGu9nPtn-Iscenes-app-inbox-scene--empty-with-many-scouts--light:diff --git a/frontend/src/lib/constants.tsx b/frontend/src/lib/constants.tsxindex 509fe1e2346a..0713b22965c0 100644--- a/frontend/src/lib/constants.tsx+++ b/frontend/src/lib/constants.tsx@@ -353,7 +353,6 @@ export const FEATURE_FLAGS = {INBOX_MODEL_SORT: 'inbox-model-sort', // owner: #team-self-driving, gates the ranking model sort options and the score tag on inbox cardsINBOX_REDESIGN: 'inbox-redesign', // owner: #team-self-driving, gates the inbox redesign: report sections, triage mode, the Settings tab, and scout cardsINBOX_REPORT_FEEDBACK_BANG: 'inbox-report-feedback-bang', // owner: #team-self-driving, gates the party hog that pops on a report thumbs-up in the inbox and on the Today home page- INBOX_SELF_DRIVING_EMPTY_STATE: 'inbox-self-driving-empty-state',INBOX_SLACK_NOTIFICATIONS: 'inbox-slack-notifications', // owner: #team-self-driving, gates the Slack notifications config card in the inboxINBOX_TIME_WINDOW: 'inbox-time-window', // owner: #team-self-driving, gates the created-in window filter on the inbox report listINBOX_UI_ONBOARDING: 'inbox-ui-onboarding', // owner: #team-self-driving, multivariate control/test-ui/test-githubdiff --git a/products/signals/frontend/inbox/InboxScene.stories.tsx b/products/signals/frontend/inbox/InboxScene.stories.tsxindex 901a71f159bf..107a3e0892f6 100644--- a/products/signals/frontend/inbox/InboxScene.stories.tsx+++ b/products/signals/frontend/inbox/InboxScene.stories.tsx@@ -92,7 +92,6 @@ const meta: Meta = {mockDate: '2026-06-11',featureFlags: {[FEATURE_FLAGS.PRODUCT_AUTONOMY]: true,- [FEATURE_FLAGS.INBOX_SELF_DRIVING_EMPTY_STATE]: 'empty-state',[FEATURE_FLAGS.INBOX_REDESIGN]: true,[FEATURE_FLAGS.SIGNALS_REPORT_METRICS]: true,},@@ -197,7 +196,6 @@ export const Settings: Story = {// setup rail. Story parameters replace the meta's, so the meta-level flags are re-listed.const LEGACY_FLAGS = {[FEATURE_FLAGS.PRODUCT_AUTONOMY]: true,- [FEATURE_FLAGS.INBOX_SELF_DRIVING_EMPTY_STATE]: 'empty-state',[FEATURE_FLAGS.INBOX_REDESIGN]: false,}@@ -245,26 +243,6 @@ export const Empty: Story = {],}-export const EmptyControl: Story = {- parameters: {- featureFlags: {- [FEATURE_FLAGS.PRODUCT_AUTONOMY]: true,- [FEATURE_FLAGS.INBOX_SELF_DRIVING_EMPTY_STATE]: 'control',- [FEATURE_FLAGS.INBOX_REDESIGN]: true,- [FEATURE_FLAGS.SIGNALS_REPORT_METRICS]: true,- },- },- decorators: [- mswDecorator({- get: {- '/api/projects/:id/signals/reports': () => [200, { results: [], count: 0, next: null, previous: null }],- '/api/projects/:id/signals/source_configs': () => [200, mockSourceConfigs],- '/api/projects/:id/signals/scout/configs': () => [200, mockScoutConfigs],- },- }),- ],-}-export const EmptyWithManyScouts: Story = {decorators: [mswDecorator({diff --git a/products/signals/frontend/inbox/components/tabs/PullRequestsTab.tsx b/products/signals/frontend/inbox/components/tabs/PullRequestsTab.tsxindex 0cce7b8cafea..53567003e348 100644--- a/products/signals/frontend/inbox/components/tabs/PullRequestsTab.tsx+++ b/products/signals/frontend/inbox/components/tabs/PullRequestsTab.tsx@@ -1,38 +1,7 @@-import { useValues } from 'kea'--import { IconPullRequest } from '@posthog/icons'--import { FEATURE_FLAGS } from 'lib/constants'-import { featureFlagLogic } from 'lib/logic/featureFlagLogic'-import { ReportCard } from '../cards/ReportCard'import { InboxWaitingForWork } from '../emptyState/InboxWaitingForWork'import { InboxReportList } from '../InboxReportList'-import { SelfDrivingInstallingHint } from '../SelfDrivingInstallingHint'export function PullRequestsTab(): JSX.Element {- const { featureFlags } = useValues(featureFlagLogic)- const showWaitingForWork = featureFlags[FEATURE_FLAGS.INBOX_SELF_DRIVING_EMPTY_STATE] === 'empty-state'-- return (- <InboxReportList- tabKey="pulls"- Card={ReportCard}- emptyState={- showWaitingForWork- ? { content: <InboxWaitingForWork /> }- : {- icon: <IconPullRequest className="text-2xl" />,- title: 'No pull requests right now',- description:- 'When an agent ships a code change, the PR draft lands here for you to review and publish.',- extra: (- <SelfDrivingInstallingHint>- Pull requests will be opened as soon as live data comes in.- </SelfDrivingInstallingHint>- ),- }- }- />- )+ return <InboxReportList tabKey="pulls" Card={ReportCard} emptyState={{ content: <InboxWaitingForWork /> }} />}diff --git a/products/signals/frontend/inbox/components/tabs/ReportsTab.test.tsx b/products/signals/frontend/inbox/components/tabs/ReportsTab.test.tsxindex a7f5ed3bd656..7acb4407e6c5 100644--- a/products/signals/frontend/inbox/components/tabs/ReportsTab.test.tsx+++ b/products/signals/frontend/inbox/components/tabs/ReportsTab.test.tsx@@ -28,7 +28,6 @@ jest.mock('../cards/ReportCard', () => ({jest.mock('../shell/InboxReportFilters', () => ({ InboxReportFilters: () => null }))jest.mock('../shell/InboxScopeFilter', () => ({ InboxScopeFilter: () => null }))jest.mock('../shell/InboxBulkSelectionBar', () => ({ InboxBulkSelectionBar: () => null }))-jest.mock('../SelfDrivingInstallingHint', () => ({ SelfDrivingInstallingHint: () => null }))interface SectionCountStub {match: (params: URLSearchParams) => boolean@@ -52,6 +51,8 @@ const ONLY_NOT_ACTIONABLE: SectionCountStub[] = [function mockReportCounts(stubs: SectionCountStub[]): void {useMocks({get: {+ '/api/projects/:team_id/signals/source_configs': { results: [] },+ '/api/projects/:team_id/signals/scout/configs': [],'/api/projects/:team_id/signals/reports/available_reviewers': {},'/api/projects/:team_id/signals/reports/': ({ request }) => {const params = new URL(request.url).searchParams@@ -144,9 +145,13 @@ describe('ReportsTab', () => {// The empty verdict must cover every state the current user can see, not only the counted// ones: a staff user on a project whose reports are all judged not actionable still has work- // to review, so "nothing yet" would be wrong for them and right for everyone else.+ // to review, so the waiting state would be wrong for them and right for everyone else.it.each([- { name: 'staff is not told "nothing yet" when only Not actionable has reports', isStaff: true, empty: false },+ {+ name: 'staff does not see the waiting state when only Not actionable has reports',+ isStaff: true,+ empty: false,+ },{ name: 'non-staff sees the empty state for the same project', isStaff: false, empty: true },])('$name', async ({ isStaff, empty }) => {mockReportCounts(ONLY_NOT_ACTIONABLE)@@ -157,11 +162,11 @@ describe('ReportsTab', () => {render(<ReportsTab />)await waitForCountsToSettle()- expect(screen.queryByText('Nothing in your inbox yet') !== null).toBe(empty)+ expect(screen.queryByText('Your agents are working in the background') !== null).toBe(empty)})- // "Nothing yet" claims the project has no reports. A search or scope that matches nothing must- // not make that claim, or the user loses the way back to the full list.+ // A search or scope that matches nothing must keep the filter controls available so the user+ // can get back to the full list.it.each([{name: 'a search that matches nothing',@@ -182,7 +187,7 @@ describe('ReportsTab', () => {await waitForCountsToSettle()await waitFor(() => expect(screen.getByText(copy)).toBeInTheDocument())- expect(screen.queryByText('Nothing in your inbox yet')).toBeNull()+ expect(screen.queryByText('Your agents are working in the background')).toBeNull()})// The whole point of the flat list: one merged run over the selected states. The defaultdiff --git a/products/signals/frontend/inbox/components/tabs/ReportsTab.tsx b/products/signals/frontend/inbox/components/tabs/ReportsTab.tsxindex 90b10029eef0..3c19391c9d53 100644--- a/products/signals/frontend/inbox/components/tabs/ReportsTab.tsx+++ b/products/signals/frontend/inbox/components/tabs/ReportsTab.tsx@@ -1,12 +1,9 @@import { useMountedLogic, useValues } from 'kea'import { Fragment, JSX, memo, useCallback, useEffect, useRef } from 'react'-import { IconNotebook } from '@posthog/icons'import { LemonButton, LemonDivider } from '@posthog/lemon-ui'import { KeyboardShortcut } from 'lib/components/KeyboardShortcut/KeyboardShortcut'-import { FEATURE_FLAGS } from 'lib/constants'-import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import { urls } from 'scenes/urls'import { isRankingSortField } from '../../filterOptions'@@ -32,7 +29,6 @@ import { ReportContextMenu } from '../cards/ReportContextMenu'import { InboxWaitingForWork } from '../emptyState/InboxWaitingForWork'import { InboxMcpBanner } from '../InboxMcpBanner'import { InboxActivationPanel } from '../onboarding/InboxActivationPanel'-import { SelfDrivingInstallingHint } from '../SelfDrivingInstallingHint'import { InboxBulkSelectionBar } from '../shell/InboxBulkSelectionBar'import { InboxReportFilters } from '../shell/InboxReportFilters'import { InboxScopeFilter } from '../shell/InboxScopeFilter'@@ -192,29 +188,6 @@ const ReportRow = memo(function ReportRow({)})-/** Nothing has reached the inbox yet — the whole list is empty, not just one state. */-function ReportsEmptyState(): JSX.Element {- const { featureFlags } = useValues(featureFlagLogic)- if (featureFlags[FEATURE_FLAGS.INBOX_SELF_DRIVING_EMPTY_STATE] === 'empty-state') {- return <InboxWaitingForWork />- }- return (- <div className="mx-auto flex max-w-md flex-col items-center gap-2 py-12 text-center">- <div className="mb-1 flex h-12 w-12 items-center justify-center rounded-full bg-fill-primary text-secondary">- <IconNotebook className="text-2xl" />- </div>- <h3 className="m-0 text-base font-semibold">Nothing in your inbox yet</h3>- <p className="m-0 text-sm text-tertiary">- Agents file what they find here: reports waiting on a pull request, pull requests for you to review, and- the work already resolved.- </p>- <SelfDrivingInstallingHint>- Reports will start arriving as soon as live data comes in.- </SelfDrivingInstallingHint>- </div>- )-}-function emptyListCopy(scope: InboxScope, narrowed: boolean): string {if (narrowed) {return 'No reports match the current filters.'@@ -381,7 +354,7 @@ export function ReportsTab(): JSX.Element {{inboxIsEmpty ? (showActivation ? null : (- <ReportsEmptyState />+ <InboxWaitingForWork />)) : showFirstLoadSkeleton ? (// Hold the rows until every selected state's first page has settled: the states