Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(data-catalog): filter metrics by creator (#119796)

Sinan Kucukkoselerd885b4cff30f
diff --git a/products/data_catalog/frontend/metricsLogic.test.ts b/products/data_catalog/frontend/metricsLogic.test.ts
index ca88a275400c..138af4f5024e 100644
--- a/products/data_catalog/frontend/metricsLogic.test.ts
+++ b/products/data_catalog/frontend/metricsLogic.test.ts
@@ -1,8 +1,10 @@
import { router } from 'kea-router'
+import posthog from 'posthog-js'
import { ApiError } from 'lib/api'
import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'
import { urls } from 'scenes/urls'
+import { userLogic } from 'scenes/userLogic'
import { initKeaTests } from '~/test/init'
import { expectLogic } from '~/test/keaTestUtils'
@@ -219,6 +221,40 @@ describe('metricsLogic', () => {
expect((dataCatalogMetricsList as jest.Mock).mock.calls.map((call) => call[1].offset)).toEqual([0, 0, 100])
})
+ it('filters by creator and reports the filter change once typing settles', async () => {
+ const me = userLogic.values.user?.uuid as string
+ const mine = buildMetric({
+ id: 'metric-1',
+ name: 'mine',
+ created_by: { id: 1, uuid: me, email: '[email protected]', hedgehog_config: null },
+ })
+ const theirs = buildMetric({
+ id: 'metric-2',
+ name: 'theirs',
+ created_by: { id: 2, uuid: 'someone-else', email: '[email protected]', hedgehog_config: null },
+ })
+ logic.actions.loadMetricsSuccess([mine, theirs])
+ const capture = jest.spyOn(posthog, 'capture').mockImplementation()
+ jest.useFakeTimers({ doNotFake: ['queueMicrotask', 'nextTick'] })
+ try {
+ logic.actions.setFilters({ createdBy: me })
+ expect(logic.values.metrics).toEqual([mine])
+ expect(capture).not.toHaveBeenCalled()
+
+ await jest.advanceTimersByTimeAsync(500)
+ expect(capture).toHaveBeenCalledWith(
+ 'data catalog metrics filtered',
+ expect.objectContaining({ changed_filters: ['createdBy'], created_by: 'me', result_count: 1 })
+ )
+
+ logic.actions.setFilters({ createdBy: null })
+ expect(logic.values.metrics).toEqual([mine, theirs])
+ } finally {
+ jest.useRealTimers()
+ capture.mockRestore()
+ }
+ })
+
it('patches approved rows and reloads to reconcile skipped ones', async () => {
logic.actions.loadMetricsSuccess([
buildMetric({ id: 'metric-1', name: 'first' }),
diff --git a/products/data_catalog/frontend/metricsLogic.tsx b/products/data_catalog/frontend/metricsLogic.tsx
index 115dd8537976..e67a6a00f31d 100644
--- a/products/data_catalog/frontend/metricsLogic.tsx
+++ b/products/data_catalog/frontend/metricsLogic.tsx
@@ -1,11 +1,15 @@
-import { MakeLogicType, actions, kea, listeners, path, reducers, selectors } from 'kea'
+import { MakeLogicType, actions, connect, kea, listeners, path, reducers, selectors } from 'kea'
import { lazyLoaders, loaders } from 'kea-loaders'
import { router } from 'kea-router'
+import posthog from 'posthog-js'
import api, { ApiConfig, ApiError } from 'lib/api'
import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'
import { createFuse } from 'lib/utils/fuseSearch'
import { urls } from 'scenes/urls'
+import { userLogic } from 'scenes/userLogic'
+
+import { UserType } from '~/types'
import { metricCount } from './common'
import {
@@ -28,11 +32,13 @@ const METRICS_PAGE_SIZE = 100
export interface MetricsFilters {
search: string
status: MetricStatusFilter
+ createdBy: string | null
}
export const DEFAULT_METRICS_FILTERS: MetricsFilters = {
search: '',
status: 'all',
+ createdBy: null,
}
export type NewMetricDefinitionType = 'markdown' | 'insight' | 'sql'
@@ -86,6 +92,7 @@ function skippedMessage(skipped: DataCatalogMetricBulkSkipApi[]): string {
// Generated by kea-typegen. Update if you're an agent, ignore if you're human.
export interface metricsLogicValues {
+ user: UserType | null // userLogic
actionsInFlight: Record<string, boolean>
allMetrics: DataCatalogMetricApi[]
allMetricsLoading: boolean
@@ -231,6 +238,9 @@ export type metricsLogicType = MakeLogicType<
export const metricsLogic = kea<metricsLogicType>([
path(['products', 'data_catalog', 'frontend', 'metricsLogic']),
+ connect(() => ({
+ values: [userLogic, ['user']],
+ })),
actions({
setFilters: (filters: Partial<MetricsFilters>) => ({ filters }),
openNewMetricModal: true,
@@ -362,6 +372,11 @@ export const metricsLogic = kea<metricsLogicType>([
if (filters.status !== 'all') {
results = results.filter((metric) => metric.status === filters.status)
}
+ if (filters.createdBy) {
+ // created_by is SET_NULL on the model, so a deleted creator arrives as null despite the
+ // serializer type.
+ results = results.filter((metric) => metric.created_by?.uuid === filters.createdBy)
+ }
if (filters.search) {
const fuse = createFuse<DataCatalogMetricApi>(results, {
keys: ['name', 'display_name', 'description'],
@@ -378,6 +393,18 @@ export const metricsLogic = kea<metricsLogicType>([
],
}),
listeners(({ values, actions }) => ({
+ setFilters: async ({ filters }, breakpoint) => {
+ // The search box dispatches on every keystroke, so wait for typing to settle before reporting.
+ await breakpoint(500)
+ const { status, createdBy, search } = values.filters
+ posthog.capture('data catalog metrics filtered', {
+ changed_filters: Object.keys(filters),
+ status,
+ created_by: createdBy ? (createdBy === values.user?.uuid ? 'me' : 'other') : 'any',
+ has_search: search.length > 0,
+ result_count: values.metrics.length,
+ })
+ },
openNewMetricModal: () => actions.loadSavedInsights(),
setInsightSearch: () => actions.loadSavedInsights(),
openSqlEditorForNewMetric: () => {
diff --git a/products/data_catalog/frontend/tabs/MetricsTab.tsx b/products/data_catalog/frontend/tabs/MetricsTab.tsx
index 0448b2f8ace9..888482c0df41 100644
--- a/products/data_catalog/frontend/tabs/MetricsTab.tsx
+++ b/products/data_catalog/frontend/tabs/MetricsTab.tsx
@@ -4,6 +4,7 @@ import { useState } from 'react'
import { IconRefresh } from '@posthog/icons'
import { LemonButton, LemonDialog } from '@posthog/lemon-ui'
+import { MemberSelect } from 'lib/components/MemberSelect'
import { More } from 'lib/lemon-ui/LemonButton/More'
import { LemonInput } from 'lib/lemon-ui/LemonInput'
import { LemonMarkdown } from 'lib/lemon-ui/LemonMarkdown'
@@ -240,6 +241,13 @@ export function MetricsTab(): JSX.Element {
onChange={(search) => setFilters({ search })}
/>
<div className="flex items-center gap-2 flex-wrap">
+ <div className="flex items-center gap-2">
+ <span>Created by:</span>
+ <MemberSelect
+ value={filters.createdBy}
+ onChange={(user) => setFilters({ createdBy: user?.uuid || null })}
+ />
+ </div>
<LemonSegmentedButton
value={filters.status}
onChange={(status) => setFilters({ status })}