Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(workflows): stop the transactional tab flash and paginate metrics (#130333)

Daniel Marchukd8899d5a1ae2
diff --git a/products/workflows/frontend/Transactional/TransactionalScene.tsx b/products/workflows/frontend/Transactional/TransactionalScene.tsx
index 931fd7544be3..524ad963f07b 100644
--- a/products/workflows/frontend/Transactional/TransactionalScene.tsx
+++ b/products/workflows/frontend/Transactional/TransactionalScene.tsx
@@ -1,5 +1,6 @@
import { useValues } from 'kea'
import { router } from 'kea-router'
+import { useRef } from 'react'
import { LemonButton } from '@posthog/lemon-ui'
import { Button } from '@posthog/quill'
@@ -19,19 +20,13 @@ import { AccessControlLevel, AccessControlResourceType } from '~/types'
import { EmailSuspensionBanner } from '../EmailSuspensionBanner'
import { MessagingSetup } from '../MessagingSetup'
import { MessagingTabActions } from '../MessagingTabActions'
-import {
- MESSAGING_NAV_TAB_KEYS,
- MESSAGING_TAB_CONTENT,
- MessagingNavTabKey,
- isMessagingSetupTab,
-} from '../messagingTabs'
+import { MESSAGING_TAB_CONTENT, isMessagingSetupTab } from '../messagingTabs'
import { TransactionalEmailLog } from './log/TransactionalEmailLog'
import { TransactionalEmailMetrics } from './metrics/TransactionalEmailMetrics'
import { TransactionalEmailsTable } from './TransactionalEmailsTable'
+import { TransactionalRoute, TransactionalTab, transactionalRouteFor } from './transactionalRoute'
import { TransactionalEmailWizard } from './wizard/TransactionalEmailWizard'
-type TransactionalTab = 'transactional' | 'log' | 'metrics'
-
export const scene: SceneExport = {
component: TransactionalScene,
productKey: ProductKey.WORKFLOWS,
@@ -41,22 +36,18 @@ export function TransactionalScene(): JSX.Element {
const { location } = useValues(router)
const showTransactional = useFeatureFlag('WORKFLOWS_TRANSACTIONAL_EMAIL_API')
const todayRailNav = useFeatureFlag('TODAY_RAIL_NAV')
- // The tab routes are literal paths, so the tab is the last path segment rather than a route param.
- const lastSegment = location.pathname.split('/').pop() ?? ''
- const currentTab: MessagingNavTabKey | TransactionalTab = MESSAGING_NAV_TAB_KEYS.includes(
- lastSegment as MessagingNavTabKey
- )
- ? (lastSegment as MessagingNavTabKey)
- : lastSegment === 'log' || lastSegment === 'metrics'
- ? lastSegment
- : 'transactional'
+ // Leaving for another scene changes the URL before that scene has loaded, so this one keeps showing its last view.
+ const route = transactionalRouteFor(location.pathname)
+ const lastRoute = useRef<TransactionalRoute>(route ?? 'transactional')
+ lastRoute.current = route ?? lastRoute.current
+ const currentTab = lastRoute.current
const isTransactionalTab = currentTab === 'transactional' || currentTab === 'log' || currentTab === 'metrics'
if (!showTransactional) {
return <NotFound object="page" />
}
- if (lastSegment === 'new') {
+ if (currentTab === 'new') {
return <TransactionalEmailWizard />
}
diff --git a/products/workflows/frontend/Transactional/log/QuillTransactionalEmailLogFilters.tsx b/products/workflows/frontend/Transactional/log/QuillTransactionalEmailLogFilters.tsx
new file mode 100644
index 000000000000..241b83b5aec4
--- /dev/null
+++ b/products/workflows/frontend/Transactional/log/QuillTransactionalEmailLogFilters.tsx
@@ -0,0 +1,93 @@
+import { useActions, useValues } from 'kea'
+
+import { IconRefresh, IconSearch } from '@posthog/icons'
+import {
+ Button,
+ DropdownMenu,
+ DropdownMenuContent,
+ FilterClearItem,
+ FilterMenuTrigger,
+ FilterOption,
+ FilterRadioSubMenu,
+ InputGroup,
+ InputGroupAddon,
+ InputGroupInput,
+ InputGroupText,
+} from '@posthog/quill'
+
+import type { EmailDeliveryStatusEnumApi } from 'products/messaging/frontend/generated/api.schemas'
+
+import { TransactionalEmailLogDateFilter } from './TransactionalEmailLogDateFilter'
+import { transactionalEmailLogLogic } from './transactionalEmailLogLogic'
+
+const ANY = 'any'
+
+export function QuillTransactionalEmailLogFilters({
+ emailOptions,
+ statusOptions,
+}: {
+ emailOptions: readonly FilterOption[]
+ statusOptions: readonly FilterOption<EmailDeliveryStatusEnumApi>[]
+}): JSX.Element {
+ const { filters, pageLoading } = useValues(transactionalEmailLogLogic)
+ const { setFilters, refresh } = useActions(transactionalEmailLogLogic)
+ const menuFiltersOn = filters.workflowId !== null || filters.status !== null
+
+ return (
+ <div className="flex flex-wrap items-center gap-2">
+ <InputGroup size="sm" className="flex-1 min-w-60">
+ <InputGroupAddon align="inline-start">
+ <InputGroupText>
+ <IconSearch />
+ </InputGroupText>
+ </InputGroupAddon>
+ <InputGroupInput
+ type="search"
+ aria-label="Search by recipient or message ID"
+ placeholder="Search by recipient or message ID"
+ value={filters.search}
+ onChange={(event: React.ChangeEvent<HTMLInputElement>) =>
+ setFilters({ search: event.target.value })
+ }
+ data-attr="transactional-email-log-search"
+ />
+ </InputGroup>
+ <DropdownMenu>
+ <FilterMenuTrigger active={menuFiltersOn} dataAttr="transactional-email-log-filter-menu" />
+ <DropdownMenuContent align="start" className="min-w-64">
+ <FilterRadioSubMenu
+ label="Email"
+ options={[{ value: ANY, label: 'All emails' }, ...emailOptions]}
+ value={filters.workflowId ?? ANY}
+ defaultValue={ANY}
+ onChange={(value) => setFilters({ workflowId: value === ANY ? null : value })}
+ dataAttr="transactional-email-log-email-filter"
+ />
+ <FilterRadioSubMenu<EmailDeliveryStatusEnumApi | typeof ANY>
+ label="Status"
+ options={[{ value: ANY, label: 'Any status' }, ...statusOptions]}
+ value={filters.status ?? ANY}
+ defaultValue={ANY}
+ onChange={(value) => setFilters({ status: value === ANY ? null : value })}
+ dataAttr="transactional-email-log-status-filter"
+ />
+ <FilterClearItem
+ active={menuFiltersOn}
+ onClear={() => setFilters({ workflowId: null, status: null })}
+ dataAttr="transactional-email-log-clear-filters"
+ />
+ </DropdownMenuContent>
+ </DropdownMenu>
+ <TransactionalEmailLogDateFilter />
+ <Button
+ variant="outline"
+ loading={pageLoading}
+ onClick={() => refresh()}
+ data-attr="transactional-email-log-refresh"
+ >
+ <IconRefresh />
+ Refresh
+ </Button>
+ </div>
+ )
+}
diff --git a/products/workflows/frontend/Transactional/log/TransactionalEmailLog.tsx b/products/workflows/frontend/Transactional/log/TransactionalEmailLog.tsx
index 124150d22047..0869da9da180 100644
--- a/products/workflows/frontend/Transactional/log/TransactionalEmailLog.tsx
+++ b/products/workflows/frontend/Transactional/log/TransactionalEmailLog.tsx
@@ -4,18 +4,19 @@ import { router } from 'kea-router'
import { IconCursorClick, IconEye, IconRefresh, IconSearch } from '@posthog/icons'
import { LemonBanner, LemonButton, LemonInput, LemonSelect, LemonTag, Tooltip } from '@posthog/lemon-ui'
-import { DateFilter } from 'lib/components/DateFilter/DateFilter'
import { TZLabel } from 'lib/components/TZLabel'
+import { useFeatureFlag } from 'lib/hooks/useFeatureFlag'
import { LemonTable } from 'lib/lemon-ui/LemonTable'
import { LemonTableLink } from 'lib/lemon-ui/LemonTable/LemonTableLink'
-import { INVOCATIONS_DATE_OPTIONS } from 'scenes/hog-functions/invocations/invocationsDateOptions'
import { urls } from 'scenes/urls'
import type { TransactionalEmailLogEntryApi } from 'products/messaging/frontend/generated/api.schemas'
import { messageTemplatesLogic } from '../../TemplateLibrary/messageTemplatesLogic'
import { EMAIL_STATUS_DESCRIPTION, EMAIL_STATUS_LABEL, EMAIL_STATUS_TAG, emailReasonText } from './emailLogStatus'
-import { DEFAULT_LOG_FILTERS, LOG_RETENTION_DAYS, transactionalEmailLogLogic } from './transactionalEmailLogLogic'
+import { QuillTransactionalEmailLogFilters } from './QuillTransactionalEmailLogFilters'
+import { TransactionalEmailLogDateFilter } from './TransactionalEmailLogDateFilter'
+import { transactionalEmailLogLogic } from './transactionalEmailLogLogic'
/** Lets a long address wrap before its domain instead of mid-word. */
function EmailAddress({ address }: { address: string }): JSX.Element {
@@ -44,6 +45,7 @@ export function TransactionalEmailLog(): JSX.Element {
const { emails, pageLoading, pageFailed, filters, isFiltered, pagination } = useValues(transactionalEmailLogLogic)
const { setFilters, setPage, refresh, loadEmails } = useActions(transactionalEmailLogLogic)
const { transactionalTemplates } = useValues(messageTemplatesLogic)
+ const todayRailNav = useFeatureFlag('TODAY_RAIL_NAV')
const emailOptions = transactionalTemplates
.filter((template) => template.transactional_hog_flow_id)
@@ -54,64 +56,54 @@ export function TransactionalEmailLog(): JSX.Element {
return (
<div className="flex flex-col gap-2">
- <div className="flex flex-wrap items-center gap-2 justify-between">
- <div className="flex items-center gap-2 flex-1 min-w-60">
- <LemonInput
- type="search"
- size="small"
- placeholder="Search by recipient or message ID"
- fullWidth
- value={filters.search}
- onChange={(search) => setFilters({ search })}
- prefix={<IconSearch />}
- allowClear
- data-attr="transactional-email-log-search"
- />
+ {todayRailNav ? (
+ <QuillTransactionalEmailLogFilters emailOptions={emailOptions} statusOptions={STATUS_OPTIONS} />
+ ) : (
+ <div className="flex flex-wrap items-center gap-2 justify-between">
+ <div className="flex items-center gap-2 flex-1 min-w-60">
+ <LemonInput
+ type="search"
+ size="small"
+ placeholder="Search by recipient or message ID"
+ fullWidth
+ value={filters.search}
+ onChange={(search) => setFilters({ search })}
+ prefix={<IconSearch />}
+ allowClear
+ data-attr="transactional-email-log-search"
+ />
+ </div>
+ <div className="flex items-center gap-2 flex-wrap">
+ <LemonSelect
+ size="small"
+ dropdownMatchSelectWidth={false}
+ value={filters.workflowId}
+ onChange={(workflowId) => setFilters({ workflowId })}
+ options={[{ value: null, label: 'All emails' }, ...emailOptions]}
+ data-attr="transactional-email-log-email-filter"
+ />
+ <LemonSelect
+ size="small"
+ dropdownMatchSelectWidth={false}
+ value={filters.status}
+ onChange={(status) => setFilters({ status })}
+ options={[{ value: null, label: 'Any status' }, ...STATUS_OPTIONS]}
+ data-attr="transactional-email-log-status-filter"
+ />
+ <TransactionalEmailLogDateFilter />
+ <LemonButton
+ type="secondary"
+ size="small"
+ icon={<IconRefresh />}
+ loading={pageLoading}
+ onClick={() => refresh()}
+ data-attr="transactional-email-log-refresh"
+ >
+ Refresh
+ </LemonButton>
+ </div>
</div>
- <div className="flex items-center gap-2 flex-wrap">
- <LemonSelect
- size="small"
- dropdownMatchSelectWidth={false}
- value={filters.workflowId}
- onChange={(workflowId) => setFilters({ workflowId })}
- options={[{ value: null, label: 'All emails' }, ...emailOptions]}
- data-attr="transactional-email-log-email-filter"
- />
- <LemonSelect
- size="small"
- dropdownMatchSelectWidth={false}
- value={filters.status}
- onChange={(status) => setFilters({ status })}
- options={[{ value: null, label: 'Any status' }, ...STATUS_OPTIONS]}
- data-attr="transactional-email-log-status-filter"
- />
- <DateFilter
- size="small"
- dateFrom={filters.dateFrom}
- dateTo={filters.dateTo ?? undefined}
- onChange={(dateFrom, dateTo) =>
- setFilters({ dateFrom: dateFrom || DEFAULT_LOG_FILTERS.dateFrom, dateTo: dateTo || null })
- }
- dateOptions={INVOCATIONS_DATE_OPTIONS}
- allowTimePrecision
- allowFixedRangeWithTime
- allowedRollingDateOptions={['minutes', 'hours', 'days', 'weeks']}
- max={LOG_RETENTION_DAYS}
- use24HourFormat
- data-attr="transactional-email-log-date-filter"
- />
- <LemonButton
- type="secondary"
- size="small"
- icon={<IconRefresh />}
- loading={pageLoading}
- onClick={() => refresh()}
- data-attr="transactional-email-log-refresh"
- >
- Refresh
- </LemonButton>
- </div>
- </div>
+ )}
{pageFailed && (
<LemonBanner
type="error"
diff --git a/products/workflows/frontend/Transactional/log/TransactionalEmailLogDateFilter.tsx b/products/workflows/frontend/Transactional/log/TransactionalEmailLogDateFilter.tsx
new file mode 100644
index 000000000000..f836501f405a
--- /dev/null
+++ b/products/workflows/frontend/Transactional/log/TransactionalEmailLogDateFilter.tsx
@@ -0,0 +1,29 @@
+import { useActions, useValues } from 'kea'
+
+import { DateFilter } from 'lib/components/DateFilter/DateFilter'
+import { INVOCATIONS_DATE_OPTIONS } from 'scenes/hog-functions/invocations/invocationsDateOptions'
+
+import { DEFAULT_LOG_FILTERS, LOG_RETENTION_DAYS, transactionalEmailLogLogic } from './transactionalEmailLogLogic'
+
+export function TransactionalEmailLogDateFilter(): JSX.Element {
+ const { filters } = useValues(transactionalEmailLogLogic)
+ const { setFilters } = useActions(transactionalEmailLogLogic)
+
+ return (
+ <DateFilter
+ size="small"
+ dateFrom={filters.dateFrom}
+ dateTo={filters.dateTo ?? undefined}
+ onChange={(dateFrom, dateTo) =>
+ setFilters({ dateFrom: dateFrom || DEFAULT_LOG_FILTERS.dateFrom, dateTo: dateTo || null })
+ }
+ dateOptions={INVOCATIONS_DATE_OPTIONS}
+ allowTimePrecision
+ allowFixedRangeWithTime
+ allowedRollingDateOptions={['minutes', 'hours', 'days', 'weeks']}
+ max={LOG_RETENTION_DAYS}
+ use24HourFormat
+ data-attr="transactional-email-log-date-filter"
+ />
+ )
+}
diff --git a/products/workflows/frontend/Transactional/metrics/TransactionalEmailMetrics.tsx b/products/workflows/frontend/Transactional/metrics/TransactionalEmailMetrics.tsx
index c2ab03e2ad6d..248d140bbe8a 100644
--- a/products/workflows/frontend/Transactional/metrics/TransactionalEmailMetrics.tsx
+++ b/products/workflows/frontend/Transactional/metrics/TransactionalEmailMetrics.tsx
@@ -1,20 +1,21 @@
import { useActions, useValues } from 'kea'
-import { LemonBanner, LemonSelect } from '@posthog/lemon-ui'
+import { LemonBanner } from '@posthog/lemon-ui'
import { urls } from 'scenes/urls'
import { SceneDivider } from '~/layout/scenes/components/SceneDivider'
import { SceneSection } from '~/layout/scenes/components/SceneSection'
-import { METRICS_DATE_RANGES, transactionalEmailMetricsLogic } from './transactionalEmailMetricsLogic'
+import { TransactionalEmailMetricsDateRange } from './TransactionalEmailMetricsDateRange'
+import { transactionalEmailMetricsLogic } from './transactionalEmailMetricsLogic'
import { TransactionalEmailResults } from './TransactionalEmailResults'
import { TransactionalEmailStatsTable } from './TransactionalEmailStatsTable'
export function TransactionalEmailMetrics(): JSX.Element {
- const { hours, templateStats, templateStatsLoading, domainStats, domainStatsLoading, statsFailed } =
+ const { templateStats, templateStatsLoading, domainStats, domainStatsLoading, statsFailed } =
useValues(transactionalEmailMetricsLogic)
- const { setHours, loadTemplateStats, loadDomainStats } = useActions(transactionalEmailMetricsLogic)
+ const { loadTemplateStats, loadDomainStats } = useActions(transactionalEmailMetricsLogic)
const emptyState = statsFailed ? "The numbers couldn't load" : 'No transactional emails were sent in this period'
return (
@@ -37,17 +38,10 @@ export function TransactionalEmailMetrics(): JSX.Element {
<SceneSection
title="By email"
description="Delivered and bounced are shares of what was sent. Marked as spam, opened and clicked are shares of what was delivered."
- actions={
- <LemonSelect
- size="small"
- value={hours}
- onChange={setHours}
- options={METRICS_DATE_RANGES.map((range) => ({ value: range.value, label: range.label }))}
- data-attr="transactional-email-metrics-date-filter"
- />
- }
+ actions={<TransactionalEmailMetricsDateRange />}
>
<TransactionalEmailStatsTable
+ id="by_email"
rows={templateStats}
loading={templateStatsLoading}
groupTitle="Email"
@@ -59,6 +53,7 @@ export function TransactionalEmailMetrics(): JSX.Element {
<SceneDivider />
<SceneSection title="By sending domain" description="The same counts for each domain the emails came from.">
<TransactionalEmailStatsTable
+ id="by_domain"
rows={domainStats}
loading={domainStatsLoading}
groupTitle="Sending domain"
diff --git a/products/workflows/frontend/Transactional/metrics/TransactionalEmailMetricsDateRange.tsx b/products/workflows/frontend/Transactional/metrics/TransactionalEmailMetricsDateRange.tsx
new file mode 100644
index 000000000000..a7a4489792c5
--- /dev/null
+++ b/products/workflows/frontend/Transactional/metrics/TransactionalEmailMetricsDateRange.tsx
@@ -0,0 +1,45 @@
+import { useActions, useValues } from 'kea'
+
+import { LemonSelect } from '@posthog/lemon-ui'
+import { Button, Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@posthog/quill'
+
+import { useFeatureFlag } from 'lib/hooks/useFeatureFlag'
+
+import { METRICS_DATE_RANGES, transactionalEmailMetricsLogic } from './transactionalEmailMetricsLogic'
+
+const DATA_ATTR = 'transactional-email-metrics-date-filter'
+
+export function TransactionalEmailMetricsDateRange(): JSX.Element {
+ const { hours } = useValues(transactionalEmailMetricsLogic)
+ const { setHours } = useActions(transactionalEmailMetricsLogic)
+ const todayRailNav = useFeatureFlag('TODAY_RAIL_NAV')
+
+ if (!todayRailNav) {
+ return (
+ <LemonSelect
+ size="small"
+ value={hours}
+ onChange={setHours}
+ options={METRICS_DATE_RANGES.map((range) => ({ value: range.value, label: range.label }))}
+ data-attr={DATA_ATTR}
+ />
+ )
+ }
+
+ return (
+ <Select<number> value={hours} onValueChange={(value) => value !== null && setHours(value)}>
+ <SelectTrigger render={<Button variant="outline" left />} data-attr={DATA_ATTR}>
+ <SelectValue>
+ {(value: number) => METRICS_DATE_RANGES.find((range) => range.value === value)?.label}
+ </SelectValue>
+ </SelectTrigger>
+ <SelectContent align="end" alignItemWithTrigger={false}>
+ {METRICS_DATE_RANGES.map((range) => (
+ <SelectItem key={range.value} value={range.value}>
+ {range.label}
+ </SelectItem>
+ ))}
+ </SelectContent>
+ </Select>
+ )
+}
diff --git a/products/workflows/frontend/Transactional/metrics/TransactionalEmailStatsTable.tsx b/products/workflows/frontend/Transactional/metrics/TransactionalEmailStatsTable.tsx
index e6667d861a73..e797eaca1ad7 100644
--- a/products/workflows/frontend/Transactional/metrics/TransactionalEmailStatsTable.tsx
+++ b/products/workflows/frontend/Transactional/metrics/TransactionalEmailStatsTable.tsx
@@ -38,7 +38,11 @@ function RateCell({ row, rate }: { row: TransactionalEmailStatsRowApi; rate: Rat
)
}
+const PAGE_SIZE = 20
+
export interface TransactionalEmailStatsTableProps {
+ // Keeps the page and sort order in the URL separate for each table on the tab.
+ id: string
rows: TransactionalEmailStatsRowApi[] | null
loading: boolean
groupTitle: string
@@ -49,6 +53,7 @@ export interface TransactionalEmailStatsTableProps {
}
export function TransactionalEmailStatsTable({
+ id,
rows,
loading,
groupTitle,
@@ -58,6 +63,7 @@ export function TransactionalEmailStatsTable({
}: TransactionalEmailStatsTableProps): JSX.Element {
return (
<LemonTable<TransactionalEmailStatsRowApi>
+ id={id}
dataSource={rows ?? []}
loading={loading}
rowKey="key"
@@ -97,6 +103,7 @@ export function TransactionalEmailStatsTable({
},
]}
defaultSorting={{ columnKey: 'sent', order: -1 }}
+ pagination={{ pageSize: PAGE_SIZE, hideOnSinglePage: true }}
emptyState={emptyState}
/>
)
diff --git a/products/workflows/frontend/Transactional/transactionalRoute.test.ts b/products/workflows/frontend/Transactional/transactionalRoute.test.ts
new file mode 100644
index 000000000000..896372527e7a
--- /dev/null
+++ b/products/workflows/frontend/Transactional/transactionalRoute.test.ts
@@ -0,0 +1,17 @@
+import { TransactionalRoute, transactionalRouteFor } from './transactionalRoute'
+
+describe('transactionalRouteFor', () => {
+ test.each<[string, TransactionalRoute | null]>([
+ ['/transactional', 'transactional'],
+ ['/project/2/transactional', 'transactional'],
+ ['/project/2/transactional/log', 'log'],
+ ['/project/2/transactional/metrics', 'metrics'],
+ ['/project/2/transactional/library', 'library'],
+ ['/project/2/transactional/new', 'new'],
+ ['/project/2/transactional/log/01a1acb5-7506-0001-0f02-b0f2c0c0c108', null],
+ ['/project/2/transactional/library/templates/01a167d1-baf4-0000-256f-bb8a70449dd5', null],
+ ['/project/2/insights/abc123', null],
+ ])('%s', (pathname, expected) => {
+ expect(transactionalRouteFor(pathname)).toBe(expected)
+ })
+})
diff --git a/products/workflows/frontend/Transactional/transactionalRoute.ts b/products/workflows/frontend/Transactional/transactionalRoute.ts
new file mode 100644
index 000000000000..b79b823d55ce
--- /dev/null
+++ b/products/workflows/frontend/Transactional/transactionalRoute.ts
@@ -0,0 +1,16 @@
+import { removeProjectIdIfPresent } from 'lib/utils/kea-router'
+
+import type { MessagingNavTabKey } from '../messagingTabs'
+
+export type TransactionalTab = 'transactional' | 'log' | 'metrics'
+export type TransactionalRoute = MessagingNavTabKey | TransactionalTab | 'new'
+
+/** The view a URL opens in the Transactional scene, or null for a URL that belongs to another scene. */
+export function transactionalRouteFor(pathname: string): TransactionalRoute | null {
+ const match = removeProjectIdIfPresent(pathname).match(/^\/transactional(?:\/([^/]+))?\/?$/)
+ if (!match) {
+ return null
+ }
+ // The manifest only sends literal paths to this scene, so a single segment is always one of its views.
+ return (match[1] ?? 'transactional') as TransactionalRoute
+}