Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(taxonomic-filter): guard a missing item id when selecting event metadata (#116479)

posthog[bot]dd77d7dead8c
diff --git a/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.test.ts b/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.test.ts
index b06507354c8a..d1a53344319b 100644
--- a/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.test.ts
+++ b/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.test.ts
@@ -183,14 +183,20 @@ describe('taxonomicPropertyFilterLogic', () => {
)
})
- it('creates EventMetadata filter with label from item name', () => {
- selectAndExpect(
- TaxonomicFilterGroupType.EventMetadata,
- '$group_0',
- PropertyFilterType.EventMetadata,
- { type: PropertyFilterType.EventMetadata, key: '$group_0', label: 'Organization' },
- { id: '$group_0', name: 'Organization' }
+ it.each([
+ ['an item with an id', '$group_0', { id: '$group_0', name: 'Organization' }, { label: 'Organization' }],
+ ['an item without an id', '$group_0', { name: 'Organization' }, { label: 'Organization' }],
+ ['a non-group item without an id', 'distinct_id', { name: 'distinct_id' }, {}],
+ ['no item', 'distinct_id', undefined, {}],
+ ])('creates EventMetadata filter from %s', (_, key, item, expectedLabel) => {
+ const group = logic.values.taxonomicGroups.find((g) => g.type === TaxonomicFilterGroupType.EventMetadata)!
+ logic.actions.openDropdown()
+ logic.actions.selectItem(group, key, PropertyFilterType.EventMetadata, item)
+ expect(setFilterSpy).toHaveBeenCalledWith(
+ 0,
+ expect.objectContaining({ type: PropertyFilterType.EventMetadata, key, ...expectedLabel })
)
+ expect(logic.values.dropdownOpen).toBe(false)
})
it('closes the dropdown after selecting an item', () => {
diff --git a/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.ts b/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.ts
index 1e054b06679a..1742e86df22f 100644
--- a/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.ts
+++ b/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.ts
@@ -235,7 +235,11 @@ export const taxonomicPropertyFilterLogic = kea<taxonomicPropertyFilterLogicType
featureFilter.label = item.key
}
- if (propertyType === PropertyFilterType.EventMetadata && item.id.startsWith('$group_')) {
+ if (
+ propertyType === PropertyFilterType.EventMetadata &&
+ item?.name &&
+ String(item.id ?? propertyKey).startsWith('$group_')
+ ) {
const eventMetadataFilter = filter as EventMetadataPropertyFilter
eventMetadataFilter.label = item.name
}
diff --git a/frontend/src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx b/frontend/src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx
index 7d341f94c75c..7bde40be0eeb 100644
--- a/frontend/src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx
+++ b/frontend/src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx
@@ -2745,7 +2745,7 @@ export const taxonomicFilterLogic = kea<taxonomicFilterLogicType>([
const isPropertyFilterLogicGroup =
PROPERTY_TAXONOMIC_GROUP_TYPES.has(sourceGroupType) ||
SHORTCUT_TO_PROPERTY_FILTER_GROUP_TYPES.has(sourceGroupType) ||
- sourceGroupType.startsWith(TaxonomicFilterGroupType.GroupsPrefix)
+ sourceGroupType?.startsWith(TaxonomicFilterGroupType.GroupsPrefix)
const recordHereNow = props.selectingKeyOnly || hasCompletePropertyFilter || !isPropertyFilterLogicGroup
if (recordHereNow && !isQuickFilterItem(item)) {