Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(today): keep numbers in analytics searches and add a clear button (#120329)

Mike Warrene0a636ec8d7c
diff --git a/frontend/src/scenes/analytics/AnalyticsListFilters.tsx b/frontend/src/scenes/analytics/AnalyticsListFilters.tsx
index 790a203610eb..5cd2c4d76dc0 100644
--- a/frontend/src/scenes/analytics/AnalyticsListFilters.tsx
+++ b/frontend/src/scenes/analytics/AnalyticsListFilters.tsx
@@ -1,15 +1,7 @@
import { useActions, useValues } from 'kea'
-import { IconSearch, IconTrends } from '@posthog/icons'
-import {
- Button,
- InputGroup,
- InputGroupAddon,
- InputGroupInput,
- InputGroupText,
- ToggleGroup,
- ToggleGroupItem,
-} from '@posthog/quill'
+import { IconTrends } from '@posthog/icons'
+import { Button, ToggleGroup, ToggleGroupItem } from '@posthog/quill'
import { fullName } from 'lib/utils/strings'
import { membersLogic } from 'scenes/organization/membersLogic'
@@ -20,6 +12,7 @@ import { tagsModel } from '~/models/tagsModel'
import { AnalyticsFilterOption, AnalyticsFilterPicker } from './AnalyticsFilterPicker'
import { analyticsListLogic } from './analyticsListLogic'
import { AnalyticsOwnerAvatar } from './AnalyticsOwner'
+import { AnalyticsSearchInput } from './AnalyticsSearchInput'
import { AnalyticsTypeIcon } from './AnalyticsTypeIcon'
import { ANALYTICS_TYPES, AnalyticsTypeFilter } from './analyticsUtils'
@@ -41,21 +34,13 @@ export function AnalyticsListFilters(): JSX.Element {
return (
<div className="flex flex-wrap items-center gap-2">
- <InputGroup className="h-8 w-56 max-w-full">
- <InputGroupAddon align="inline-start">
- <InputGroupText>
- <IconSearch />
- </InputGroupText>
- </InputGroupAddon>
- <InputGroupInput
- type="search"
- aria-label="Search analytics"
- placeholder="Search"
- value={searchInput}
- onChange={(event: React.ChangeEvent<HTMLInputElement>) => setSearchInput(event.target.value)}
- data-attr="analytics-list-search"
- />
- </InputGroup>
+ <AnalyticsSearchInput
+ value={searchInput}
+ onChange={setSearchInput}
+ label="Search analytics"
+ placeholder="Search"
+ dataAttr="analytics-list-search"
+ />
<ToggleGroup
size="lg"
variant="default"
diff --git a/frontend/src/scenes/analytics/AnalyticsSearchInput.tsx b/frontend/src/scenes/analytics/AnalyticsSearchInput.tsx
new file mode 100644
index 000000000000..58b19ee5263f
--- /dev/null
+++ b/frontend/src/scenes/analytics/AnalyticsSearchInput.tsx
@@ -0,0 +1,65 @@
+import { useRef } from 'react'
+
+import { IconSearch, IconX } from '@posthog/icons'
+import { InputGroup, InputGroupAddon, InputGroupButton, InputGroupInput, InputGroupText } from '@posthog/quill'
+
+/** The search field of the Analytics pages, with a clear button once there is text, like the chat search. */
+export function AnalyticsSearchInput({
+ value,
+ onChange,
+ label,
+ placeholder,
+ dataAttr,
+}: {
+ value: string
+ onChange: (value: string) => void
+ label: string
+ placeholder: string
+ dataAttr: string
+}): JSX.Element {
+ const inputRef = useRef<HTMLInputElement>(null)
+ // The clear button unmounts once the field empties, which would drop focus to the page mid-search.
+ const clear = (): void => {
+ onChange('')
+ inputRef.current?.focus()
+ }
+ return (
+ <InputGroup className="h-8 w-56 max-w-full">
+ <InputGroupAddon align="inline-start">
+ <InputGroupText>
+ <IconSearch />
+ </InputGroupText>
+ </InputGroupAddon>
+ <InputGroupInput
+ ref={inputRef}
+ type="search"
+ aria-label={label}
+ placeholder={placeholder}
+ value={value}
+ onChange={(event: React.ChangeEvent<HTMLInputElement>) => onChange(event.target.value)}
+ onKeyDown={(event: React.KeyboardEvent<HTMLInputElement>) => {
+ if (event.key === 'Escape' && value !== '') {
+ event.preventDefault()
+ event.stopPropagation()
+ clear()
+ }
+ }}
+ // The browser's own clear button would sit next to this one.
+ className="[&::-webkit-search-cancel-button]:hidden"
+ data-attr={dataAttr}
+ />
+ {value !== '' && (
+ <InputGroupAddon align="inline-end">
+ <InputGroupButton
+ size="icon-xs"
+ aria-label="Clear search"
+ onClick={clear}
+ data-attr={`${dataAttr}-clear`}
+ >
+ <IconX />
+ </InputGroupButton>
+ </InputGroupAddon>
+ )}
+ </InputGroup>
+ )
+}
diff --git a/frontend/src/scenes/analytics/AnalyticsSpaces.tsx b/frontend/src/scenes/analytics/AnalyticsSpaces.tsx
index bcb5b1e475c6..d8e5f51b5c73 100644
--- a/frontend/src/scenes/analytics/AnalyticsSpaces.tsx
+++ b/frontend/src/scenes/analytics/AnalyticsSpaces.tsx
@@ -9,10 +9,6 @@ import {
EmptyHeader,
EmptyMedia,
EmptyTitle,
- InputGroup,
- InputGroupAddon,
- InputGroupInput,
- InputGroupText,
Item,
ItemActions,
ItemContent,
@@ -40,6 +36,7 @@ import { todayAnalyticsLogic } from '~/layout/today/todayAnalyticsLogic'
import { TodayAnalyticsNewFolderDialog } from '~/layout/today/TodayAnalyticsNewFolderDialog'
import { AnalyticsCreateModals } from './AnalyticsCreateModals'
+import { AnalyticsSearchInput } from './AnalyticsSearchInput'
import { AnalyticsSpaceGlyph } from './AnalyticsSpaceGlyph'
import { AnalyticsSpace, analyticsSpacesLogic } from './analyticsSpacesLogic'
import { AnalyticsTypeIcon } from './AnalyticsTypeIcon'
@@ -194,21 +191,13 @@ function AnalyticsSpacesContent(): JSX.Element {
</Empty>
) : (
<>
- <InputGroup className="h-8 w-56 max-w-full">
- <InputGroupAddon align="inline-start">
- <InputGroupText>
- <IconSearch />
- </InputGroupText>
- </InputGroupAddon>
- <InputGroupInput
- type="search"
- aria-label="Search collections"
- placeholder="Search collections"
- value={search}
- onChange={(event: React.ChangeEvent<HTMLInputElement>) => setSearch(event.target.value)}
- data-attr="analytics-spaces-search"
- />
- </InputGroup>
+ <AnalyticsSearchInput
+ value={search}
+ onChange={setSearch}
+ label="Search collections"
+ placeholder="Search collections"
+ dataAttr="analytics-spaces-search"
+ />
{visibleSpaces.length ? (
<ItemGroup className="flex flex-col gap-2 pb-8">
{visibleSpaces.map((space) => (
diff --git a/frontend/src/scenes/analytics/analyticsListLogic.test.ts b/frontend/src/scenes/analytics/analyticsListLogic.test.ts
index 6075ad2fc68c..722aed5cb7a3 100644
--- a/frontend/src/scenes/analytics/analyticsListLogic.test.ts
+++ b/frontend/src/scenes/analytics/analyticsListLogic.test.ts
@@ -108,4 +108,18 @@ describe('analyticsListLogic', () => {
expect(query.createdByMe).toBe(true)
expect(logic.values.feedQuery).toBe(query)
})
+
+ it.each([
+ ['a number', { search: '4' }, { search: '4' }],
+ ['a boolean word', { search: 'true' }, { search: 'true' }],
+ ['text shaped like a list', { search: '[draft]' }, { search: '[draft]' }],
+ ['a collection named with a number', { folder: '2024' }, { folder: '2024' }],
+ ])('reads %s back from the URL as the text that was typed', async (_, params, expected) => {
+ const logic = analyticsListLogic()
+ logic.mount()
+ router.actions.push(urls.analyticsList(params))
+ await expectLogic(logic).toFinishAllListeners()
+
+ expect(logic.values.filters).toMatchObject(expected)
+ })
})
diff --git a/frontend/src/scenes/analytics/analyticsListLogic.ts b/frontend/src/scenes/analytics/analyticsListLogic.ts
index f73829c8d0e6..78f37f4ad376 100644
--- a/frontend/src/scenes/analytics/analyticsListLogic.ts
+++ b/frontend/src/scenes/analytics/analyticsListLogic.ts
@@ -88,6 +88,11 @@ function stringList(value: unknown): string[] {
return Array.isArray(value) ? value.filter((item): item is string => typeof item === 'string') : []
}
+/** The router reads a value that looks like a number or a boolean as one, so text goes back to a string. */
+function urlParamToString(value: unknown): string {
+ return `${value ?? ''}`
+}
+
export function analyticsListFiltersFromUrl(params: Record<string, any>): AnalyticsListFilters {
const type = typeof params.type === 'string' && isAnalyticsType(params.type) ? params.type : 'all'
const tags = Array.isArray(params.tags)
@@ -95,9 +100,9 @@ export function analyticsListFiltersFromUrl(params: Record<string, any>): Analyt
: []
return {
type,
- search: typeof params.search === 'string' ? params.search : '',
+ search: urlParamToString(params.search),
createdBy: stringList(params.createdBy),
- folder: typeof params.folder === 'string' ? params.folder : null,
+ folder: params.folder === undefined || params.folder === null ? null : urlParamToString(params.folder),
tags,
}
}