Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(data-modeling): add materialization status search (#122251)

Jovan Sakovice0e897964c02
diff --git a/docs/internal/sql-editor-schema-tree.md b/docs/internal/sql-editor-schema-tree.md
index ade0dcdf5355..2c61bad50fbd 100644
--- a/docs/internal/sql-editor-schema-tree.md
+++ b/docs/internal/sql-editor-schema-tree.md
@@ -45,11 +45,11 @@ After that request, catalog reloads also restore complete fields for consumers o
Schema mutations refresh previously hydrated or pending tables, as well as expanded nodes.
Saved-query lists expose metadata only; refreshing them preserves the query and columns already fetched for an open editor tab.
-In PostHog Warehouse, the **…** menu beside sidebar search filters materialized views by their latest run status: **Failed**, **Running**, or **Completed**.
-Select multiple statuses to include views matching any of them. **Failed** includes views paused after repeated failures.
-Matching views retain their folders and expandable columns. The menu button highlights while a status filter is active.
-These filters combine with sidebar search and do not apply to direct connections.
-**Clear filters** or deselecting every status restores the full tree. Locating a table also clears the status filters so the requested table can appear.
+In PostHog Warehouse, sidebar search accepts `status:failed`, `status:running`, and `status:completed` to filter materialized views by their latest run status.
+The Models tab accepts the same status tokens and combines them with its name and lineage search syntax.
+The funnel menu beside search inserts and removes the same tokens. Select multiple statuses to include views matching any of them. **Failed** includes views paused after repeated failures.
+Status tokens combine with a name search, and matching views retain their folders and expandable columns. The funnel button highlights while a status filter is active.
+Status filters do not apply to direct connections. **Clear filters**, removing every status token, or locating a table restores the unfiltered tree.
## Saved-query writes
diff --git a/frontend/src/lib/components/SearchAutocomplete/SearchAutocomplete.test.tsx b/frontend/src/lib/components/SearchAutocomplete/SearchAutocomplete.test.tsx
new file mode 100644
index 000000000000..cf18676c2f78
--- /dev/null
+++ b/frontend/src/lib/components/SearchAutocomplete/SearchAutocomplete.test.tsx
@@ -0,0 +1,21 @@
+import { fireEvent, render, screen } from '@testing-library/react'
+
+import { SearchAutocomplete } from './SearchAutocomplete'
+
+describe('SearchAutocomplete', () => {
+ it('forwards keyboard events while suggestions are open', () => {
+ const onKeyDown = jest.fn((event: React.KeyboardEvent<HTMLInputElement>) => event.preventDefault())
+ render(
+ <SearchAutocomplete
+ searchData={[[{ label: 'status', value: 'status' }, [{ label: 'Failed', value: 'failed' }]]]}
+ onKeyDown={onKeyDown}
+ />
+ )
+
+ const input = screen.getByLabelText('Search input')
+ fireEvent.change(input, { target: { value: 's' } })
+ fireEvent.keyDown(input, { key: 'ArrowDown' })
+
+ expect(onKeyDown).toHaveBeenCalledWith(expect.objectContaining({ key: 'ArrowDown' }))
+ })
+})
diff --git a/frontend/src/lib/components/SearchAutocomplete/SearchAutocomplete.tsx b/frontend/src/lib/components/SearchAutocomplete/SearchAutocomplete.tsx
index 876a2bd9596b..f35559c2b2d5 100644
--- a/frontend/src/lib/components/SearchAutocomplete/SearchAutocomplete.tsx
+++ b/frontend/src/lib/components/SearchAutocomplete/SearchAutocomplete.tsx
@@ -207,8 +207,8 @@ export const SearchAutocomplete = forwardRef<HTMLDivElement, SearchAutocompleteP
}
const handleKeydown = (e: React.KeyboardEvent<HTMLInputElement>): void => {
- if (!open || suggestions.length === 0) {
- onKeyDown?.(e)
+ onKeyDown?.(e)
+ if (e.defaultPrevented || !open || suggestions.length === 0) {
return
}
diff --git a/frontend/src/scenes/data-warehouse/editor/sidebar/DatabaseSearchField.tsx b/frontend/src/scenes/data-warehouse/editor/sidebar/DatabaseSearchField.tsx
index 203e0b35a8b9..9cc3cf4817c6 100644
--- a/frontend/src/scenes/data-warehouse/editor/sidebar/DatabaseSearchField.tsx
+++ b/frontend/src/scenes/data-warehouse/editor/sidebar/DatabaseSearchField.tsx
@@ -1,6 +1,6 @@
import { useActions, useValues } from 'kea'
-import { IconEllipsis } from '@posthog/icons'
+import { IconFilter } from '@posthog/icons'
import { LemonButton, LemonCheckbox, LemonMenu } from '@posthog/lemon-ui'
import { SearchAutocomplete } from 'lib/components/SearchAutocomplete/SearchAutocomplete'
@@ -9,6 +9,17 @@ import { MATERIALIZATION_STATUS_FILTER_OPTIONS } from 'products/data_warehouse/f
import { queryDatabaseLogic } from './queryDatabaseLogic'
+const MATERIALIZATION_STATUS_SEARCH_DATA = [
+ [
+ { label: 'status', value: 'status', hint: 'Materialization status', icon: <IconFilter /> },
+ MATERIALIZATION_STATUS_FILTER_OPTIONS.map((status) => ({
+ label: status,
+ value: status.toLowerCase(),
+ })),
+ 'Filter materialized views by their latest run',
+ ],
+] satisfies React.ComponentProps<typeof SearchAutocomplete>['searchData']
+
interface TreeSearchFieldProps {
placeholder?: string
}
@@ -34,8 +45,8 @@ export function DatabaseSearchField({ placeholder }: TreeSearchFieldProps): JSX.
<div className="flex-1 min-w-0">
<SearchAutocomplete
inputPlaceholder={placeholder}
- includeNegation
defaultValue={searchTerm}
+ searchData={connectionId ? undefined : MATERIALIZATION_STATUS_SEARCH_DATA}
onKeyDown={(e) => handleKeyDown(e)}
onClear={() => clearSearch()}
onChange={(value) => setSearchTerm(value)}
@@ -82,11 +93,11 @@ export function DatabaseSearchField({ placeholder }: TreeSearchFieldProps): JSX.
]}
>
<LemonButton
- icon={<IconEllipsis />}
+ icon={<IconFilter />}
size="small"
active={materializationStatusFilters.length > 0}
- tooltip="Filter tables and views"
- aria-label="Filter tables and views"
+ tooltip="Filter materialized views"
+ aria-label="Filter materialized views"
data-attr="sql-editor-table-filters-menu"
/>
</LemonMenu>
diff --git a/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.test.ts b/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.test.ts
index 0f9b852351b5..8a9e698932b7 100644
--- a/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.test.ts
+++ b/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.test.ts
@@ -1,4 +1,4 @@
-import { getColumnInsertText, getSidebarAddJoinSourceTableName } from './QueryDatabase'
+import { getColumnInsertText, getQueryDatabaseTreeData, getSidebarAddJoinSourceTableName } from './QueryDatabase'
describe('QueryDatabase', () => {
describe('getColumnInsertText', () => {
@@ -49,4 +49,29 @@ describe('QueryDatabase', () => {
expect(getSidebarAddJoinSourceTableName(recordType, itemName, tableName)).toEqual(expected)
})
})
+
+ describe('getQueryDatabaseTreeData', () => {
+ const displayedTreeData = [{ id: 'views', name: 'Views' }]
+ const extraTreeSections = [
+ {
+ id: 'dataframes',
+ name: 'Dataframes',
+ children: [
+ { id: 'orders', name: 'orders' },
+ { id: 'revenue', name: 'revenue' },
+ ],
+ },
+ ]
+
+ test.each([
+ ['', ['orders', 'revenue', 'Views']],
+ ['orders', ['orders', 'Views']],
+ ])('keeps matching embedded sections for search %p', (searchText, expectedNames) => {
+ const treeData = getQueryDatabaseTreeData(displayedTreeData, extraTreeSections, searchText)
+
+ expect(treeData.flatMap((item) => item.children?.map((child) => child.name) ?? item.name)).toEqual(
+ expectedNames
+ )
+ })
+ })
})
diff --git a/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.tsx b/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.tsx
index 0c15b2e350be..29eb0a4c6405 100644
--- a/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.tsx
+++ b/frontend/src/scenes/data-warehouse/editor/sidebar/QueryDatabase.tsx
@@ -118,6 +118,18 @@ const filterTreeSections = (sections: TreeDataItem[], searchTerm: string): TreeD
})
}
+export const getQueryDatabaseTreeData = (
+ displayedTreeData: TreeDataItem[],
+ extraTreeSections: TreeDataItem[] | undefined,
+ searchText: string
+): TreeDataItem[] => {
+ if (!extraTreeSections?.length) {
+ return displayedTreeData
+ }
+
+ return [...filterTreeSections(extraTreeSections, searchText), ...displayedTreeData]
+}
+
export const QueryDatabase = ({
virtualizationScrollContainerRef,
extraTreeSections,
@@ -132,7 +144,7 @@ export const QueryDatabase = ({
extraTreeSections?: TreeDataItem[]
}): JSX.Element => {
const {
- searchTerm,
+ searchText,
joinsByFieldName,
editingDraftId,
displayedTreeData,
@@ -392,24 +404,21 @@ export const QueryDatabase = ({
}, [treeRef, setTreeRef])
const treeData = useMemo(() => {
- if (!extraTreeSections?.length) {
- return displayedTreeData
- }
// Filtered here rather than by the caller: the tree swaps in its own filtered data while
// searching, so an unfiltered section would sit above the results still listing
// everything — and keeping the search term on this side means an embedder doesn't have to
// mount this logic just to read it.
- return [...filterTreeSections(extraTreeSections, searchTerm), ...displayedTreeData]
- }, [extraTreeSections, displayedTreeData, searchTerm])
+ return getQueryDatabaseTreeData(displayedTreeData, extraTreeSections, searchText)
+ }, [extraTreeSections, displayedTreeData, searchText])
const tree = (
<LemonTree
ref={treeRef}
data={treeData}
- enableDragAndDrop={!searchTerm}
- isItemDraggable={(item) => !searchTerm && item.record?.type === 'view' && item.record?.isSavedQuery}
+ enableDragAndDrop={!searchText}
+ isItemDraggable={(item) => !searchText && item.record?.type === 'view' && item.record?.isSavedQuery}
isItemDroppable={(item) =>
- !searchTerm &&
+ !searchText &&
((item.record?.type === 'folder' && item.record?.folderType === 'view-folder') ||
item.record?.type === 'views')
}
@@ -428,7 +437,7 @@ export const QueryDatabase = ({
}}
expandedItemIds={expandedItemIds}
onSetExpandedItemIds={
- searchTerm ? setExpandedSearchFolders : (folderIds) => setExpandedFolders(folderIds, connectionId)
+ searchText ? setExpandedSearchFolders : (folderIds) => setExpandedFolders(folderIds, connectionId)
}
onFolderClick={(folder, isExpanded) => {
if (folder) {
@@ -509,10 +518,10 @@ export const QueryDatabase = ({
{item.record?.type === 'view' && item.record.isSavedQuery ? (
<MaterializationStatusIcon view={item.record.view} />
) : null}
- {hasMatches && searchTerm ? (
+ {hasMatches && searchText ? (
<SearchHighlightMultiple
string={itemLabel}
- substring={searchTerm}
+ substring={searchText}
className={cn(isColumn && 'font-mono text-xs')}
/>
) : (
diff --git a/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.test.ts b/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.test.ts
index c7a56651cc25..15fc70b0989f 100644
--- a/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.test.ts
+++ b/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.test.ts
@@ -580,7 +580,7 @@ describe('queryDatabaseLogic', () => {
logic.unmount()
})
- it('combines materialization statuses with search and clears them when locating a table', async () => {
+ it('combines status search tokens with names and clears them when locating a table', async () => {
initKeaTests()
const logic = queryDatabaseLogic()
logic.mount()
@@ -601,16 +601,25 @@ describe('queryDatabaseLogic', () => {
})) as unknown as DataWarehouseSavedQuery[]
)
+ await expectLogic(logic, () => logic.actions.setSearchTerm('status:f')).toNotHaveDispatchedActions([
+ 'ensureAllTableFields',
+ ])
+ logic.actions.clearSearch()
+
logic.actions.toggleMaterializationStatusFilter('Failed')
+ expect(logic.values.searchTerm).toEqual('status:failed')
+ expect(logic.values.searchText).toEqual('')
expect(logic.values.displayedTreeData.map((item) => item.name)).toEqual(['Views'])
expect(logic.values.displayedTreeData[0].children!.map((item) => item.name)).toEqual([
'orders_daily',
'revenue_daily',
])
- logic.actions.setSearchTerm('orders')
+ logic.actions.setSearchTerm('orders status:failed')
+ expect(logic.values.searchText).toEqual('orders')
expect(logic.values.displayedTreeData[0].children!.map((item) => item.name)).toEqual(['orders_daily'])
logic.actions.toggleMaterializationStatusFilter('Completed')
+ expect(logic.values.searchTerm).toEqual('orders status:failed status:completed')
expect(logic.values.displayedTreeData[0].children!.map((item) => item.name)).toEqual([
'orders_daily',
'orders_weekly',
@@ -619,11 +628,12 @@ describe('queryDatabaseLogic', () => {
expect(logic.values.displayedTreeData[0].children!.map((item) => item.name)).toEqual(['orders_weekly'])
logic.actions.toggleMaterializationStatusFilter('Completed')
expect(logic.values.materializationStatusFilters).toEqual([])
+ expect(logic.values.searchTerm).toEqual('orders')
logic.actions.toggleMaterializationStatusFilter('Failed')
- logic.actions.setSearchTerm('orders_weekly')
+ logic.actions.setSearchTerm('orders_weekly status:failed')
expect(logic.values.displayedTreeData).toEqual([])
logic.actions.clearSearch()
- logic.actions.clearMaterializationStatusFilters()
+ expect(logic.values.materializationStatusFilters).toEqual([])
expect(logic.values.displayedTreeData.find((item) => item.name === 'Views')!.children).toHaveLength(3)
logic.actions.toggleMaterializationStatusFilter('Failed')
@@ -1036,9 +1046,27 @@ describe('queryDatabaseLogic', () => {
)
})
+ it('treats status syntax as literal search text', () => {
+ databaseTableListLogic.findMounted()?.actions.loadDatabaseSuccess({
+ tables: {
+ 'public.accounts': {
+ id: 'accounts',
+ name: 'public.accounts',
+ type: 'data_warehouse',
+ fields: {},
+ },
+ },
+ joins: [],
+ } as any)
+ logic.actions.setSearchTerm('status:failed')
+
+ expect(logic.values.searchText).toEqual('status:failed')
+ expect(logic.values.materializationStatusFilters).toEqual([])
+ expect(logic.values.displayedTreeData).toEqual([])
+ })
+
it.each(['source-id', MANAGED_TRINO_SCHEMA_SCOPE])('hides unrelated folders for schema scope %s', (scope) => {
databaseTableListLogic.findMounted()?.actions.setConnection(scope)
- logic.actions.toggleMaterializationStatusFilter('Failed')
featureFlagLogic.actions.setFeatureFlags([FEATURE_FLAGS.EDITOR_DRAFTS], {
[FEATURE_FLAGS.EDITOR_DRAFTS]: true,
})
diff --git a/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.tsx b/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.tsx
index 8bd51607e81d..f469dab6f9c5 100644
--- a/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.tsx
+++ b/frontend/src/scenes/data-warehouse/editor/sidebar/queryDatabaseLogic.tsx
@@ -62,8 +62,12 @@ import {
resolveFieldTraverserTarget,
} from 'products/data_warehouse/frontend/shared/fieldTraversal'
import {
+ clearMaterializationStatusSearchTokens,
+ databaseSearchNeedsFieldHydration,
filterMaterializedViewsByStatus,
MaterializationStatusFilter,
+ parseDatabaseSearch,
+ toggleMaterializationStatusSearchToken,
} from 'products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus'
import {
connectionSelectorLogic,
@@ -1766,6 +1770,7 @@ export interface queryDatabaseLogicValues {
relevantSavedQueryFolders: [DataWarehouseSavedQueryFolder, FuseSearchMatch[] | null][]
relevantSystemTables: [DatabaseSchemaTable, FuseSearchMatch[] | null][]
searchTerm: string
+ searchText: string
searchTreeData: TreeDataItem[]
searchTreeMatches: SearchTreeMatches
searchTreeSourceContext: SearchTreeSourceContext
@@ -2060,6 +2065,8 @@ export interface queryDatabaseLogicActions {
// Generated by kea-typegen. Update if you're an agent, ignore if you're human.
export interface queryDatabaseLogicMeta {
__keaTypeGenInternalSelectorTypes: {
+ searchText: (searchTerm: string, connectionId: string | null) => string
+ materializationStatusFilters: (searchTerm: string, connectionId: string | null) => MaterializationStatusFilter[]
hasNonPosthogSources: (dataWarehouseTables: DatabaseSchemaDataWarehouseTable[]) => boolean
sidebarPosthogTables: (
posthogTables: DatabaseSchemaTable[],
@@ -2067,23 +2074,23 @@ export interface queryDatabaseLogicMeta {
) => DatabaseSchemaTable[]
relevantPosthogTables: (
sidebarPosthogTables: DatabaseSchemaTable[],
- searchTerm: string
+ searchText: string
) => [DatabaseSchemaTable, FuseSearchMatch[] | null][]
relevantSystemTables: (
systemTables: DatabaseSchemaTable[],
- searchTerm: string
+ searchText: string
) => [DatabaseSchemaTable, FuseSearchMatch[] | null][]
relevantDataWarehouseTables: (
dataWarehouseTables: DatabaseSchemaDataWarehouseTable[],
- searchTerm: string
+ searchText: string
) => [DatabaseSchemaDataWarehouseTable, FuseSearchMatch[] | null][]
relevantSavedQueries: (
effectiveDataWarehouseSavedQueries: DataWarehouseSavedQuerySummary[],
- searchTerm: string
+ searchText: string
) => [DataWarehouseSavedQuerySummary, FuseSearchMatch[] | null][]
relevantSavedQueryFolders: (
dataWarehouseSavedQueryFolders: DataWarehouseSavedQueryFolder[],
- searchTerm: string
+ searchText: string
) => [DataWarehouseSavedQueryFolder, FuseSearchMatch[] | null][]
effectiveDataWarehouseSavedQueries: (
dataWarehouseSavedQueries: DataWarehouseSavedQuerySummary[],
@@ -2091,20 +2098,20 @@ export interface queryDatabaseLogicMeta {
) => DataWarehouseSavedQuerySummary[]
relevantManagedViews: (
managedViews: DatabaseSchemaManagedViewTable[],
- searchTerm: string
+ searchText: string
) => [DatabaseSchemaManagedViewTable, FuseSearchMatch[] | null][]
relevantDrafts: (
drafts: DataWarehouseSavedQueryDraft[],
- searchTerm: string
+ searchText: string
) => [DataWarehouseSavedQueryDraft, FuseSearchMatch[] | null][]
relevantEndpointTables: (
latestEndpointTables: DatabaseSchemaEndpointTable[],
- searchTerm: string
+ searchText: string
) => [DatabaseSchemaEndpointTable, FuseSearchMatch[] | null][]
hogqlMetrics: (allMetrics: DataCatalogMetricApi[]) => DataCatalogMetricApi[]
relevantMetrics: (
hogqlMetrics: DataCatalogMetricApi[],
- searchTerm: string
+ searchText: string
) => [DataCatalogMetricApi, FuseSearchMatch[] | null][]
selectedDirectSource: (
connectionOptions: ExternalDataSourceConnectionOptionApi[] | null,
@@ -2133,7 +2140,7 @@ export interface queryDatabaseLogicMeta {
searchTreeData: (
searchTreeSourceContext: SearchTreeSourceContext,
searchTreeMatches: SearchTreeMatches,
- searchTerm: string,
+ searchText: string,
featureFlags: FeatureFlagsSet,
expandedSearchFolders: string[],
materializingViewIds: string[],
@@ -2169,7 +2176,7 @@ export interface queryDatabaseLogicMeta {
metricsLoadFailed: boolean
) => TreeDataItem[]
displayedTreeData: (
- searchTerm: string,
+ searchText: string,
searchTreeData: TreeDataItem[],
treeData: TreeDataItem[],
connectionId: string | null,
@@ -2180,7 +2187,7 @@ export interface queryDatabaseLogicMeta {
materializationStatusFilters: ('Completed' | 'Failed' | 'Running')[]
) => TreeDataItem[]
activeExpandedFolderIds: (
- searchTerm: string,
+ searchText: string,
expandedSearchFolders: string[],
expandedFolders: string[]
) => string[]
@@ -2407,20 +2414,15 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
},
],
- materializationStatusFilters: [
- [] as MaterializationStatusFilter[],
- {
- toggleMaterializationStatusFilter: (state, { status }) =>
- state.includes(status) ? state.filter((value) => value !== status) : [...state, status],
- clearMaterializationStatusFilters: () => [],
- locateTable: () => [],
- },
- ],
searchTerm: [
'',
{
setSearchTerm: (_, { searchTerm }) => searchTerm,
clearSearch: () => '',
+ toggleMaterializationStatusFilter: (searchTerm, { status }) =>
+ toggleMaterializationStatusSearchToken(searchTerm, status),
+ clearMaterializationStatusFilters: (searchTerm) => clearMaterializationStatusSearchTokens(searchTerm),
+ locateTable: (searchTerm) => clearMaterializationStatusSearchTokens(searchTerm),
},
],
propertyDefinitionLists: [
@@ -2711,6 +2713,18 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
],
})),
selectors(({ actions, cache }) => ({
+ searchText: [
+ (s) => [s.searchTerm, s.connectionId],
+ (searchTerm: string, connectionId: string | null): string =>
+ shouldUseDirectConnectionTree(connectionId) ? searchTerm : parseDatabaseSearch(searchTerm).searchText,
+ ],
+ materializationStatusFilters: [
+ (s) => [s.searchTerm, s.connectionId],
+ (searchTerm: string, connectionId: string | null): MaterializationStatusFilter[] =>
+ shouldUseDirectConnectionTree(connectionId)
+ ? []
+ : parseDatabaseSearch(searchTerm).materializationStatusFilters,
+ ],
hasNonPosthogSources: [
(s) => [s.dataWarehouseTables],
(dataWarehouseTables: DatabaseSchemaDataWarehouseTable[]): boolean => {
@@ -2730,70 +2744,70 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
],
],
relevantPosthogTables: [
- (s) => [s.sidebarPosthogTables, s.searchTerm],
+ (s) => [s.sidebarPosthogTables, s.searchText],
(
posthogTables: DatabaseSchemaTable[],
- searchTerm: string
+ searchText: string
): [DatabaseSchemaTable, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return posthogTablesFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return posthogTables.map((table) => [table, null])
},
],
relevantSystemTables: [
- (s) => [s.systemTables, s.searchTerm],
+ (s) => [s.systemTables, s.searchText],
(
systemTables: DatabaseSchemaTable[],
- searchTerm: string
+ searchText: string
): [DatabaseSchemaTable, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return systemTablesFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return systemTables.map((table) => [table, null])
},
],
relevantDataWarehouseTables: [
- (s) => [s.dataWarehouseTables, s.searchTerm],
+ (s) => [s.dataWarehouseTables, s.searchText],
(
dataWarehouseTables: DatabaseSchemaDataWarehouseTable[],
- searchTerm: string
+ searchText: string
): [DatabaseSchemaDataWarehouseTable, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return dataWarehouseTablesFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return dataWarehouseTables.map((table) => [table, null])
},
],
relevantSavedQueries: [
- (s) => [s.effectiveDataWarehouseSavedQueries, s.searchTerm],
+ (s) => [s.effectiveDataWarehouseSavedQueries, s.searchText],
(
dataWarehouseSavedQueries: DataWarehouseSavedQuerySummary[],
- searchTerm: string
+ searchText: string
): [DataWarehouseSavedQuerySummary, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return savedQueriesFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return (dataWarehouseSavedQueries ?? []).map((query) => [query, null])
},
],
relevantSavedQueryFolders: [
- (s) => [s.dataWarehouseSavedQueryFolders, s.searchTerm],
+ (s) => [s.dataWarehouseSavedQueryFolders, s.searchText],
(
dataWarehouseSavedQueryFolders: DataWarehouseSavedQueryFolder[],
- searchTerm: string
+ searchText: string
): [DataWarehouseSavedQueryFolder, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return savedQueryFoldersFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return (dataWarehouseSavedQueryFolders ?? []).map((folder) => [folder, null])
@@ -2815,42 +2829,42 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
),
],
relevantManagedViews: [
- (s) => [s.managedViews, s.searchTerm],
+ (s) => [s.managedViews, s.searchText],
(
managedViews: DatabaseSchemaManagedViewTable[],
- searchTerm: string
+ searchText: string
): [DatabaseSchemaManagedViewTable, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return managedViewsFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return managedViews.map((view) => [view, null])
},
],
relevantDrafts: [
- (s) => [s.drafts, s.searchTerm],
+ (s) => [s.drafts, s.searchText],
(
drafts: DataWarehouseSavedQueryDraft[],
- searchTerm: string
+ searchText: string
): [DataWarehouseSavedQueryDraft, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return draftsFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return drafts.map((draft) => [draft, null])
},
],
relevantEndpointTables: [
- (s) => [s.latestEndpointTables, s.searchTerm],
+ (s) => [s.latestEndpointTables, s.searchText],
(
latestEndpointTables: DatabaseSchemaEndpointTable[],
- searchTerm: string
+ searchText: string
): [DatabaseSchemaEndpointTable, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return endpointsFuse
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return latestEndpointTables.map((table) => [table, null])
@@ -2864,14 +2878,14 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
.sort((a, b) => a.name.localeCompare(b.name)),
],
relevantMetrics: [
- (s) => [s.hogqlMetrics, s.searchTerm],
+ (s) => [s.hogqlMetrics, s.searchText],
(
hogqlMetrics: DataCatalogMetricApi[],
- searchTerm: string
+ searchText: string
): [DataCatalogMetricApi, FuseSearchMatch[] | null][] => {
- if (searchTerm) {
+ if (searchText) {
return createFuse<DataCatalogMetricApi>(hogqlMetrics, FUSE_OPTIONS)
- .search(searchTerm)
+ .search(searchText)
.map((result) => [result.item, result.matches as FuseSearchMatch[]])
}
return hogqlMetrics.map((metric) => [metric, null])
@@ -2952,7 +2966,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
(s) => [
s.searchTreeSourceContext,
s.searchTreeMatches,
- s.searchTerm,
+ s.searchText,
s.featureFlags,
s.expandedSearchFolders,
s.materializingViewIds,
@@ -2961,13 +2975,13 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
(
searchTreeSourceContext: SearchTreeSourceContext,
searchTreeMatches: SearchTreeMatches,
- searchTerm: string,
+ searchText: string,
featureFlags: FeatureFlagsSet,
expandedSearchFolders: string[],
materializingViewIds: string[],
propertyDefinitionLists: Record<string, SidebarPropertyDefinitionList>
): TreeDataItem[] => {
- if (!searchTerm) {
+ if (!searchText) {
return []
}
@@ -3156,8 +3170,8 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
const expandedIdSet = new Set(expandedSearchFolders)
const missingRequiredExpansion = expandedIds.some((id) => !expandedIdSet.has(id))
- if (missingRequiredExpansion && cache.lastAutoExpandedSearchTerm !== searchTerm) {
- cache.lastAutoExpandedSearchTerm = searchTerm
+ if (missingRequiredExpansion && cache.lastAutoExpandedSearchTerm !== searchText) {
+ cache.lastAutoExpandedSearchTerm = searchText
// Auto-expand only parent folders, not the matching nodes themselves.
setTimeout(() => {
actions.setExpandedSearchFolders(
@@ -3504,7 +3518,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
],
displayedTreeData: [
(s) => [
- s.searchTerm,
+ s.searchText,
s.searchTreeData,
s.treeData,
s.connectionId,
@@ -3515,7 +3529,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
s.materializationStatusFilters,
],
(
- searchTerm: string,
+ searchText: string,
searchTreeData: TreeDataItem[],
treeData: TreeDataItem[],
connectionId: string | null,
@@ -3525,7 +3539,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
allTablesMap: Record<string, DatabaseSchemaTable>,
materializationStatusFilters: MaterializationStatusFilter[]
): TreeDataItem[] => {
- const sourceData = searchTerm ? searchTreeData : treeData
+ const sourceData = searchText ? searchTreeData : treeData
if (!shouldUseDirectConnectionTree(connectionId)) {
return filterMaterializedViewsByStatus(sourceData, materializationStatusFilters)
@@ -3572,11 +3586,11 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
}
return [
- ...groupDirectConnectionTableNodesBySchema(flattenedTables, !!searchTerm, defaultSchemaName),
+ ...groupDirectConnectionTableNodesBySchema(flattenedTables, !!searchText, defaultSchemaName),
...(flattenedViews.length > 0
? [
{
- id: searchTerm ? 'search-views' : 'views',
+ id: searchText ? 'search-views' : 'views',
name: 'Views',
type: 'node' as const,
icon: <IconDatabase />,
@@ -3589,9 +3603,9 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
},
],
activeExpandedFolderIds: [
- (s) => [s.searchTerm, s.expandedSearchFolders, s.expandedFolders],
- (searchTerm: string, expandedSearchFolders: string[], expandedFolders: string[]): string[] => {
- return searchTerm ? expandedSearchFolders : expandedFolders
+ (s) => [s.searchText, s.expandedSearchFolders, s.expandedFolders],
+ (searchText: string, expandedSearchFolders: string[], expandedFolders: string[]): string[] => {
+ return searchText ? expandedSearchFolders : expandedFolders
},
],
expandedFolders: [
@@ -3723,7 +3737,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
})),
listeners(({ actions, values }) => ({
toggleFolderOpen: ({ folderId, isExpanded }) => {
- const expandedFolders = values.searchTerm ? values.expandedSearchFolders : values.expandedFolders
+ const expandedFolders = values.searchText ? values.expandedSearchFolders : values.expandedFolders
if (!isExpanded) {
const request = getUnloadedPropertyDefinitionRequest(
@@ -3737,7 +3751,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
}
if (isExpanded) {
- if (values.searchTerm) {
+ if (values.searchText) {
actions.setExpandedSearchFolders(expandedFolders.filter((f) => f !== folderId))
} else {
actions.setExpandedFolders(
@@ -3746,7 +3760,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
)
}
} else {
- if (values.searchTerm) {
+ if (values.searchText) {
actions.setExpandedSearchFolders([...expandedFolders, folderId])
} else {
actions.setExpandedFolders([...expandedFolders, folderId], values.connectionId)
@@ -3770,7 +3784,11 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
},
setSearchTerm: ({ searchTerm }) => {
// Search matches on column names too, which a lazy-loaded schema doesn't have yet.
- if (searchTerm) {
+ if (
+ shouldUseDirectConnectionTree(values.connectionId)
+ ? Boolean(searchTerm.trim())
+ : databaseSearchNeedsFieldHydration(searchTerm)
+ ) {
actions.ensureAllTableFields()
}
},
@@ -3805,7 +3823,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
// Hydrate fields for every visible "Loading..." placeholder. Covers expansion restored from
// persisted state and nodes that were expanded before the shallow schema arrived; the
// hydrate action itself dedupes tables that are already loading or settled.
- const expanded = new Set(values.searchTerm ? values.expandedSearchFolders : values.expandedFolders)
+ const expanded = new Set(values.searchText ? values.expandedSearchFolders : values.expandedFolders)
const pendingTableNames = new Set<string>()
const collect = (nodes: TreeDataItem[]): void => {
for (const node of nodes) {
@@ -3824,7 +3842,7 @@ export const queryDatabaseLogic = kea<queryDatabaseLogicType>([
actions.hydrateTableFields(Array.from(pendingTableNames))
}
- if (values.searchTerm || !shouldUseDirectConnectionTree(values.connectionId)) {
+ if (values.searchText || !shouldUseDirectConnectionTree(values.connectionId)) {
return
}
diff --git a/products/data_modeling/frontend/ViewsTab.tsx b/products/data_modeling/frontend/ViewsTab.tsx
index a0cf6c8f0e88..feced2344b0e 100644
--- a/products/data_modeling/frontend/ViewsTab.tsx
+++ b/products/data_modeling/frontend/ViewsTab.tsx
@@ -23,7 +23,7 @@ import { TableCertificationTag } from 'products/data_warehouse/frontend/shared/c
import { endpointModelUrl, parseEndpointModelName } from './endpointModelName'
import { NodeSuspensionApi } from './generated/api.schemas'
import { statusBackgroundClass } from './lineage/nodeStyles'
-import { SEARCH_SYNTAX_HELP } from './lineage/SearchSyntaxHelp'
+import { MODELS_SEARCH_SYNTAX_HELP } from './lineage/SearchSyntaxHelp'
import { StatusTag } from './lineage/StatusTag'
import { PAGE_SIZE, ViewTypeFilter, viewsTabLogic } from './viewsTabLogic'
@@ -308,13 +308,13 @@ export function ViewsTab({ getViewUrl, suspensionByViewId }: ViewsTabProps = {})
<LemonInput
type="search"
size="small"
- placeholder="Search, or +name for upstream"
+ placeholder="Search, +name, or status:failed"
value={searchTerm}
onChange={setSearchTerm}
className="w-72"
data-attr="views-search"
/>
- <Tooltip title={SEARCH_SYNTAX_HELP}>
+ <Tooltip title={MODELS_SEARCH_SYNTAX_HELP}>
<IconInfo className="text-base text-secondary" />
</Tooltip>
<LemonSelect
diff --git a/products/data_modeling/frontend/lineage/SearchSyntaxHelp.tsx b/products/data_modeling/frontend/lineage/SearchSyntaxHelp.tsx
index 01053bb5651d..633ba67d0ff1 100644
--- a/products/data_modeling/frontend/lineage/SearchSyntaxHelp.tsx
+++ b/products/data_modeling/frontend/lineage/SearchSyntaxHelp.tsx
@@ -12,17 +12,30 @@ const SEARCH_SYNTAX: { syntax: string; meaning: string }[] = [
* Tooltips paint an inverted surface, so the chips borrow the surrounding foreground rather than
* a themed background token, which would resolve to the tooltip's own color and disappear.
*/
-export const SEARCH_SYNTAX_HELP = (
- <div className="flex flex-col gap-2 max-w-72">
- <p className="m-0">Type a name to match models.</p>
- <p className="m-0">Add a plus to follow lineage:</p>
- <div className="grid grid-cols-[auto_1fr] gap-x-2 gap-y-1 items-baseline">
- {SEARCH_SYNTAX.map(({ syntax, meaning }) => (
- <Fragment key={syntax}>
- <code className="rounded border border-current/40 px-1 text-xs whitespace-nowrap">{syntax}</code>
- <span>{meaning}</span>
- </Fragment>
- ))}
+function SearchSyntaxHelp({ includeStatus = false }: { includeStatus?: boolean }): JSX.Element {
+ return (
+ <div className="flex flex-col gap-2 max-w-72">
+ <p className="m-0">Type a name to match models.</p>
+ <p className="m-0">Add a plus to follow lineage:</p>
+ <div className="grid grid-cols-[auto_1fr] gap-x-2 gap-y-1 items-baseline">
+ {SEARCH_SYNTAX.map(({ syntax, meaning }) => (
+ <Fragment key={syntax}>
+ <code className="rounded border border-current/40 px-1 text-xs whitespace-nowrap">
+ {syntax}
+ </code>
+ <span>{meaning}</span>
+ </Fragment>
+ ))}
+ </div>
+ {includeStatus && (
+ <p className="m-0">
+ Add <code>status:failed</code>, <code>status:running</code>, or <code>status:completed</code> to
+ filter by materialization status.
+ </p>
+ )}
</div>
- </div>
-)
+ )
+}
+
+export const SEARCH_SYNTAX_HELP = <SearchSyntaxHelp />
+export const MODELS_SEARCH_SYNTAX_HELP = <SearchSyntaxHelp includeStatus />
diff --git a/products/data_modeling/frontend/viewsTabLogic.test.ts b/products/data_modeling/frontend/viewsTabLogic.test.ts
index 0250f486e8d2..67fd48678b7e 100644
--- a/products/data_modeling/frontend/viewsTabLogic.test.ts
+++ b/products/data_modeling/frontend/viewsTabLogic.test.ts
@@ -12,8 +12,15 @@ import { lineageDataLogic } from 'products/data_modeling/frontend/lineage/lineag
import { PAGE_SIZE, viewsTabLogic } from './viewsTabLogic'
-function buildView(id: string, isMaterialized: boolean): Record<string, unknown> {
- return { id, name: id, columns: [], is_materialized: isMaterialized, created_at: '2024-01-01T00:00:00Z' }
+function buildView(id: string, isMaterialized: boolean, status?: string): Record<string, unknown> {
+ return {
+ id,
+ name: id,
+ columns: [],
+ is_materialized: isMaterialized,
+ status,
+ created_at: '2024-01-01T00:00:00Z',
+ }
}
describe('viewsTabLogic', () => {
@@ -23,7 +30,9 @@ describe('viewsTabLogic', () => {
beforeEach(async () => {
runHistoryRequests = []
const views = [
- ...Array.from({ length: PAGE_SIZE + 1 }, (_, i) => buildView(`mat-${i}`, true)),
+ ...Array.from({ length: PAGE_SIZE + 1 }, (_, i) =>
+ buildView(`mat-${i}`, true, i === 1 ? 'Running' : i === 10 ? 'Failed' : 'Completed')
+ ),
buildView('plain-a', false),
buildView('plain-b', false),
]
@@ -63,12 +72,12 @@ describe('viewsTabLogic', () => {
expect(logic.values.filteredViews.map((view) => view.id)).toEqual(['plain-a', 'plain-b'])
})
- it('search and type filter compose', async () => {
+ it('search, status, and type filters compose', async () => {
logic.actions.setTypeFilter('materialized')
- logic.actions.setSearchTerm('mat-1')
+ logic.actions.setSearchTerm('mat-1 status:failed')
await expectLogic(logic).toFinishAllListeners()
- expect(logic.values.filteredViews.map((view) => view.id)).toEqual(['mat-1', 'mat-10'])
+ expect(logic.values.filteredViews.map((view) => view.id)).toEqual(['mat-10'])
})
it('keeps name matches visible while lineage data reloads', () => {
diff --git a/products/data_modeling/frontend/viewsTabLogic.ts b/products/data_modeling/frontend/viewsTabLogic.ts
index c301199e2c81..f49d08909cef 100644
--- a/products/data_modeling/frontend/viewsTabLogic.ts
+++ b/products/data_modeling/frontend/viewsTabLogic.ts
@@ -18,6 +18,12 @@ import type {
} from '~/queries/schema/schema-general'
import { DataModelingEdge, DataModelingNode, DataWarehouseSavedQueryRunHistory } from '~/types'
+import {
+ matchesMaterializationStatus,
+ MaterializationStatusFilter,
+ parseDatabaseSearch,
+} from 'products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus'
+
import { lineageDataLogic } from './lineage/lineageDataLogic'
import { ParsedLineageSearch, nodeIdsForLineageSearch, parseLineageSearch } from './lineage/lineageSearch'
@@ -41,10 +47,12 @@ export interface viewsTabLogicValues {
enrichedViews: DataWarehouseSavedQuerySummary[]
filteredViews: DataWarehouseSavedQuerySummary[]
lineageNames: Set<string> | null
+ materializationStatusFilters: MaterializationStatusFilter[]
parsedSearch: ParsedLineageSearch
runHistoryMap: Record<string, DataWarehouseSavedQueryRunHistory[]>
runHistoryMapLoading: boolean
searchTerm: string
+ searchText: string
typeFilter: ViewTypeFilter
viewsLoading: boolean
visibleViews: DataWarehouseSavedQuerySummary[]
@@ -130,7 +138,9 @@ export interface viewsTabLogicMeta {
) => DataWarehouseSavedQuerySummary[]
filteredViews: (
enrichedViews: DataWarehouseSavedQuerySummary[],
- searchTerm: string,
+ parsedSearch: ParsedLineageSearch,
+ lineageNames: Set<string> | null,
+ materializationStatusFilters: MaterializationStatusFilter[],
typeFilter: ViewTypeFilter
) => DataWarehouseSavedQuerySummary[]
visibleViews: (
@@ -258,7 +268,13 @@ export const viewsTabLogic = kea<viewsTabLogicType>([
run_history: query.is_materialized ? runHistoryMap[query.id] : undefined,
})),
],
- parsedSearch: [(s) => [s.searchTerm], (searchTerm: string) => parseLineageSearch(searchTerm)],
+ searchText: [(s) => [s.searchTerm], (searchTerm: string): string => parseDatabaseSearch(searchTerm).searchText],
+ materializationStatusFilters: [
+ (s) => [s.searchTerm],
+ (searchTerm: string): MaterializationStatusFilter[] =>
+ parseDatabaseSearch(searchTerm).materializationStatusFilters,
+ ],
+ parsedSearch: [(s) => [s.searchText], (searchText: string) => parseLineageSearch(searchText)],
// Lineage names the rows to keep; the graph keys on node id, this table on view name.
lineageNames: [
@@ -279,11 +295,12 @@ export const viewsTabLogic = kea<viewsTabLogicType>([
],
filteredViews: [
- (s) => [s.enrichedViews, s.parsedSearch, s.lineageNames, s.typeFilter],
+ (s) => [s.enrichedViews, s.parsedSearch, s.lineageNames, s.materializationStatusFilters, s.typeFilter],
(
views: DataWarehouseSavedQuerySummary[],
parsedSearch: ParsedLineageSearch,
lineageNames: Set<string> | null,
+ materializationStatusFilters: MaterializationStatusFilter[],
typeFilter: ViewTypeFilter
): DataWarehouseSavedQuerySummary[] => {
const term = parsedSearch.term.toLowerCase()
@@ -294,6 +311,9 @@ export const viewsTabLogic = kea<viewsTabLogicType>([
if (typeFilter === 'view' && view.is_materialized) {
return false
}
+ if (!matchesMaterializationStatus(view, materializationStatusFilters)) {
+ return false
+ }
if (lineageNames) {
return lineageNames.has(view.name)
}
diff --git a/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.test.ts b/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.test.ts
index df48acf1267c..defc5356aba4 100644
--- a/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.test.ts
+++ b/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.test.ts
@@ -1,8 +1,57 @@
import type { TreeDataItem } from 'lib/lemon-ui/LemonTree/LemonTree'
-import { filterMaterializedViewsByStatus, MaterializationStatusFilter } from './filterMaterializedViewsByStatus'
+import {
+ clearMaterializationStatusSearchTokens,
+ databaseSearchNeedsFieldHydration,
+ filterMaterializedViewsByStatus,
+ MaterializationStatusFilter,
+ parseDatabaseSearch,
+ toggleMaterializationStatusSearchToken,
+} from './filterMaterializedViewsByStatus'
describe('filterMaterializedViewsByStatus', () => {
+ it.each([
+ ['orders', { searchText: 'orders', materializationStatusFilters: [] }],
+ ['status:failed', { searchText: '', materializationStatusFilters: ['Failed'] }],
+ [
+ 'orders STATUS:RUNNING status:failed status:running',
+ { searchText: 'orders', materializationStatusFilters: ['Running', 'Failed'] },
+ ],
+ ['status:unknown orders', { searchText: 'status:unknown orders', materializationStatusFilters: [] }],
+ ])('parses database search %p', (searchTerm, expected) => {
+ expect(parseDatabaseSearch(searchTerm)).toEqual(expected)
+ })
+
+ it('keeps menu changes and typed status tokens in the same search value', () => {
+ const withFailed = toggleMaterializationStatusSearchToken('orders', 'Failed')
+ const withBoth = toggleMaterializationStatusSearchToken(withFailed, 'Running')
+
+ expect(withFailed).toEqual('orders status:failed')
+ expect(withBoth).toEqual('orders status:failed status:running')
+ expect(toggleMaterializationStatusSearchToken(withBoth, 'Failed')).toEqual('orders status:running')
+ expect(clearMaterializationStatusSearchTokens(withBoth)).toEqual('orders')
+ expect(toggleMaterializationStatusSearchToken('status:failed orders', 'Running')).toEqual(
+ 'status:failed orders status:running'
+ )
+ expect(toggleMaterializationStatusSearchToken('orders status:failed revenue', 'Failed')).toEqual(
+ 'orders revenue'
+ )
+ expect(clearMaterializationStatusSearchTokens('status:failed orders status:running')).toEqual('orders')
+ })
+
+ it.each([
+ ['', false],
+ ['s', false],
+ ['status:', false],
+ ['status:f', false],
+ ['status:failed', false],
+ ['orders status:f', true],
+ ['status:unknown', true],
+ ['orders', true],
+ ])('checks whether %p needs full field hydration', (searchTerm, expected) => {
+ expect(databaseSearchNeedsFieldHydration(searchTerm)).toBe(expected)
+ })
+
it.each<{ statuses: MaterializationStatusFilter[]; expected: string[] }>([
{ statuses: [], expected: ['failed', 'running', 'completed', 'plain'] },
{ statuses: ['Running'], expected: ['running'] },
diff --git a/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.ts b/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.ts
index bcec33b853f2..63fcba2e26f6 100644
--- a/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.ts
+++ b/products/data_warehouse/frontend/shared/filterMaterializedViewsByStatus.ts
@@ -3,6 +3,101 @@ import type { TreeDataItem } from 'lib/lemon-ui/LemonTree/LemonTree'
export const MATERIALIZATION_STATUS_FILTER_OPTIONS = ['Failed', 'Running', 'Completed'] as const
export type MaterializationStatusFilter = (typeof MATERIALIZATION_STATUS_FILTER_OPTIONS)[number]
+export interface ParsedDatabaseSearch {
+ searchText: string
+ materializationStatusFilters: MaterializationStatusFilter[]
+}
+
+const MATERIALIZATION_STATUS_BY_TOKEN = new Map(
+ MATERIALIZATION_STATUS_FILTER_OPTIONS.map((status) => [status.toLowerCase(), status])
+)
+const MATERIALIZATION_STATUS_TOKEN_PATTERN = /^status:(failed|running|completed)$/i
+const MATERIALIZATION_STATUS_TOKENS = MATERIALIZATION_STATUS_FILTER_OPTIONS.map(
+ (status) => `status:${status.toLowerCase()}`
+)
+
+const tokenizeDatabaseSearch = (searchTerm: string): string[] => searchTerm.trim().split(/\s+/).filter(Boolean)
+
+export function parseDatabaseSearch(searchTerm: string): ParsedDatabaseSearch {
+ const materializationStatusFilters: MaterializationStatusFilter[] = []
+ const searchTokens: string[] = []
+
+ for (const token of tokenizeDatabaseSearch(searchTerm)) {
+ const statusToken = token.match(MATERIALIZATION_STATUS_TOKEN_PATTERN)?.[1].toLowerCase()
+ const status = statusToken ? MATERIALIZATION_STATUS_BY_TOKEN.get(statusToken) : undefined
+
+ if (status) {
+ if (!materializationStatusFilters.includes(status)) {
+ materializationStatusFilters.push(status)
+ }
+ } else {
+ searchTokens.push(token)
+ }
+ }
+
+ return {
+ searchText: searchTokens.join(' '),
+ materializationStatusFilters,
+ }
+}
+
+export function databaseSearchNeedsFieldHydration(searchTerm: string): boolean {
+ return tokenizeDatabaseSearch(searchTerm).some(
+ (token) => !MATERIALIZATION_STATUS_TOKENS.some((statusToken) => statusToken.startsWith(token.toLowerCase()))
+ )
+}
+
+function removeMaterializationStatusSearchTokens(searchTerm: string, status?: MaterializationStatusFilter): string {
+ const tokenMatches = [...searchTerm.matchAll(/\S+/g)].filter((match) => {
+ const parsedStatus = match[0].match(MATERIALIZATION_STATUS_TOKEN_PATTERN)?.[1].toLowerCase()
+ return parsedStatus && (!status || parsedStatus === status.toLowerCase())
+ })
+ let result = searchTerm
+
+ for (const match of tokenMatches.reverse()) {
+ let start = match.index
+ let end = start + match[0].length
+
+ if (start === 0) {
+ while (end < result.length && /\s/.test(result[end])) {
+ end++
+ }
+ } else {
+ while (start > 0 && /\s/.test(result[start - 1])) {
+ start--
+ }
+ }
+
+ result = result.slice(0, start) + result.slice(end)
+ }
+
+ return result
+}
+
+export function toggleMaterializationStatusSearchToken(
+ searchTerm: string,
+ status: MaterializationStatusFilter
+): string {
+ const { materializationStatusFilters } = parseDatabaseSearch(searchTerm)
+ if (materializationStatusFilters.includes(status)) {
+ return removeMaterializationStatusSearchTokens(searchTerm, status)
+ }
+
+ const separator = searchTerm && !/\s$/.test(searchTerm) ? ' ' : ''
+ return `${searchTerm}${separator}status:${status.toLowerCase()}`
+}
+
+export function clearMaterializationStatusSearchTokens(searchTerm: string): string {
+ return removeMaterializationStatusSearchTokens(searchTerm)
+}
+
+export function matchesMaterializationStatus(
+ view: { is_materialized?: boolean; status?: string | null },
+ statuses: MaterializationStatusFilter[]
+): boolean {
+ return statuses.length === 0 || Boolean(view.is_materialized && statuses.some((status) => view.status === status))
+}
+
export function filterMaterializedViewsByStatus(
items: TreeDataItem[],
statuses: MaterializationStatusFilter[]
@@ -13,7 +108,7 @@ export function filterMaterializedViewsByStatus(
return items.flatMap((item) => {
if (item.record?.type === 'view') {
- return item.record.view?.is_materialized && statuses.includes(item.record.view.status) ? [item] : []
+ return item.record.view && matchesMaterializationStatus(item.record.view, statuses) ? [item] : []
}
if (item.type === 'loading-indicator') {