Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(slack-app): keep slack runs on only models it supports (#125730)

Jonathan Mielooe38c2fcec83d
diff --git a/products/slack_app/backend/services/model_catalogue.py b/products/slack_app/backend/services/model_catalogue.py
index e55ce9562bd7..1e628245901a 100644
--- a/products/slack_app/backend/services/model_catalogue.py
+++ b/products/slack_app/backend/services/model_catalogue.py
@@ -24,8 +24,9 @@ from products.tasks.backend.facade.model_catalogue import (
filter_unsupported_effort,
group_by_runtime,
label_for,
+ model_allowed_by_product_pin,
normalize_model_id,
- offered_model_choices,
+ offered_model_choices as catalog_offered_model_choices,
runtime_adapter_for,
)
@@ -41,7 +42,15 @@ def available_model_choices() -> tuple[ModelChoice, ...]:
Wider than what the App Home picker offers: a mention naming a retired model still
resolves to it, because a person who asks for one by name is not choosing from a list.
"""
- return catalog_model_choices()
+ return tuple(
+ choice for choice in catalog_model_choices() if model_allowed_by_product_pin("slack_app", choice.model)
+ )
+
+
+def offered_model_choices() -> tuple[ModelChoice, ...]:
+ return tuple(
+ choice for choice in catalog_offered_model_choices() if model_allowed_by_product_pin("slack_app", choice.model)
+ )
def describe_run_model(model: str | None, reasoning_effort: str | None) -> str:
diff --git a/products/slack_app/backend/services/run_preferences.py b/products/slack_app/backend/services/run_preferences.py
index 09c1585332cb..0197f509e57f 100644
--- a/products/slack_app/backend/services/run_preferences.py
+++ b/products/slack_app/backend/services/run_preferences.py
@@ -28,6 +28,7 @@ from products.slack_app.backend.services.model_catalogue import (
ModelChoice,
available_model_choices,
filter_unsupported_effort,
+ normalize_model_id,
runtime_adapter_for,
)
from products.slack_app.backend.services.slack_settings import AIPreferences
@@ -59,6 +60,8 @@ def _central_run_default(team_id: int, user_id: int | None) -> ResolvedAIRunConf
resolved = ai_run_defaults.resolve_ai_run_defaults(team_id, user_id)
if resolved.runtime != ai_run_defaults.ACP or not resolved.model:
return None
+ if find_model_choice(resolved.model, available_model_choices()) is None:
+ return None
return resolved
@@ -226,8 +229,8 @@ def find_model_choice(model: str | None, choices: tuple[ModelChoice, ...]) -> Mo
"""Match a requested model id against the catalogue, case-insensitively."""
if not model:
return None
- normalized = model.strip().lower()
- return next((c for c in choices if c.model.lower() == normalized), None)
+ normalized = normalize_model_id(model)
+ return next((c for c in choices if normalize_model_id(c.model) == normalized), None)
__all__ = [
diff --git a/products/slack_app/backend/tests/services/test_run_preferences.py b/products/slack_app/backend/tests/services/test_run_preferences.py
index b60620b77925..480f5d7cfc06 100644
--- a/products/slack_app/backend/tests/services/test_run_preferences.py
+++ b/products/slack_app/backend/tests/services/test_run_preferences.py
@@ -16,6 +16,7 @@ from products.slack_app.backend.services.run_preferences import (
resolve_live_run_override,
resolve_run_preferences,
)
+from products.slack_app.backend.services.slack_app_home import get_picker_choices
from products.slack_app.backend.services.slack_settings import AIPreferences
# Real model ids: the resolver validates efforts against the tasks catalogue (the
@@ -217,9 +218,15 @@ class TestAvailableModelChoices:
choices = available_model_choices()
models = {c.model for c in choices}
- assert {"claude-sonnet-5", "gpt-5.6-sol", "gpt-6.1-sol", "zai-org/glm-5.3"} <= models
+ assert {"claude-sonnet-5", "gpt-5.6-sol", "gpt-6.1-sol", "moonshotai/kimi-k3"} <= models
+ assert not {"deepseek-ai/deepseek-v4.1-flash-1017-fast", "zai-org/glm-5.3"} & models
assert all(c.label and c.runtime_adapter for c in choices)
+ def test_the_picker_offers_only_models_the_slack_pin_admits(self):
+ picker_models = {model.value for adapter in get_picker_choices() for model in adapter.models}
+ assert picker_models
+ assert picker_models <= {c.model for c in available_model_choices()}
+
class TestCentralRunDefault:
def _resolved(self, **kwargs):
@@ -227,8 +234,13 @@ class TestCentralRunDefault:
return ResolvedAIRunConfig(**kwargs)
- def test_an_acp_default_is_carried_through(self):
- resolved = self._resolved(runtime="acp", runtime_adapter="claude", model="claude-fable-5", source="team")
+ @pytest.mark.parametrize(
+ "runtime_adapter, model",
+ [("claude", "claude-fable-5"), ("codex", "openai/gpt-6-sol")],
+ ids=["a_catalog_id", "a_provider_qualified_id"],
+ )
+ def test_an_acp_default_is_carried_through(self, runtime_adapter, model):
+ resolved = self._resolved(runtime="acp", runtime_adapter=runtime_adapter, model=model, source="team")
with patch(
"products.tasks.backend.facade.ai_run_defaults.resolve_ai_run_defaults",
return_value=resolved,
@@ -237,8 +249,8 @@ class TestCentralRunDefault:
@pytest.mark.parametrize(
"runtime, model",
- [("pi", "gpt-5.6-terra"), ("acp", None)],
- ids=["a_pi_default_slack_cannot_run", "a_default_with_no_model"],
+ [("pi", "gpt-5.6-terra"), ("acp", None), ("acp", "deepseek-ai/deepseek-v4.1-flash-1017-fast")],
+ ids=["a_pi_default_slack_cannot_run", "a_default_with_no_model", "a_model_outside_the_slack_gateway_pin"],
)
def test_a_default_slack_cannot_use_falls_back_to_its_own_floor(self, runtime, model):
with patch(
diff --git a/products/tasks/backend/facade/model_catalogue.py b/products/tasks/backend/facade/model_catalogue.py
index 59817ac99062..067df2c461a2 100644
--- a/products/tasks/backend/facade/model_catalogue.py
+++ b/products/tasks/backend/facade/model_catalogue.py
@@ -7,6 +7,7 @@ picker and model-override classifier) import from here rather than reaching into
`logic/services/`.
"""
+from products.tasks.backend.logic.services.gateway_model_pin import model_allowed_by_product_pin
from products.tasks.backend.logic.services.model_catalogue import (
COST_BASELINE_MODEL,
REASONING_EFFORT_DISPLAY_NAMES,
@@ -41,6 +42,7 @@ __all__ = [
"filter_unsupported_effort",
"group_by_runtime",
"label_for",
+ "model_allowed_by_product_pin",
"normalize_model_id",
"offered_model_choices",
"runtime_adapter_for",