Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(quill-charts): cut per-mousemove work on chart hover (#125205)

Sam Penningtone75410e75149
diff --git a/packages/quill/packages/charts/src/charts/LineChart/LineChart.test.tsx b/packages/quill/packages/charts/src/charts/LineChart/LineChart.test.tsx
index 96cc8ffc2ef7..929ad901c5a3 100644
--- a/packages/quill/packages/charts/src/charts/LineChart/LineChart.test.tsx
+++ b/packages/quill/packages/charts/src/charts/LineChart/LineChart.test.tsx
@@ -275,6 +275,17 @@ describe('LineChart', () => {
expect(tooltip.seriesData).toHaveLength(SERIES.length)
})
+ it('shows new values when the series change under the hovered index', async () => {
+ const { chart, rerender } = renderChart(<LineChart series={SERIES} labels={LABELS} theme={THEME} />)
+ chart.hoverAtIndex(1)
+ await chart.waitForTooltip()
+ const updated: Series[] = SERIES.map((s) => ({ ...s, data: s.data.map((v) => v * 10) }))
+ rerender(<LineChart series={updated} labels={LABELS} theme={THEME} />)
+ chart.hoverAtIndex(1)
+ const tooltip = await chart.waitForTooltip()
+ expect(tooltip.seriesData.map((d) => d.value)).toEqual([200, 150])
+ })
+
it('pins the tooltip on click when tooltip.pinnable is true', async () => {
const { chart } = renderChart(
<LineChart series={SERIES} labels={LABELS} theme={THEME} config={{ tooltip: { pinnable: true } }} />
diff --git a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyColumnLabels.tsx b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyColumnLabels.tsx
index 3cc73d9f3891..c2c6d1f64545 100644
--- a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyColumnLabels.tsx
+++ b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyColumnLabels.tsx
@@ -53,7 +53,11 @@ export interface SankeyColumnLabelsProps {
/** Column headers over each node column. The first and last headers align to the outer node edge
* instead of centering, so they stay inside the chart. Extra labels beyond the column count are
* dropped, so a fixed stage list stays valid when the data has fewer stages. */
-export function SankeyColumnLabels({ labels, color, trailingRoom = 0 }: SankeyColumnLabelsProps): React.ReactElement {
+export const SankeyColumnLabels = React.memo(function SankeyColumnLabels({
+ labels,
+ color,
+ trailingRoom = 0,
+}: SankeyColumnLabelsProps): React.ReactElement {
const { layout } = useSankeyLayout()
const lastColumn = layout.columnCount - 1
// Each header owns the span halfway to its neighbors' node centers, so neighbors cannot run together.
@@ -98,4 +102,4 @@ export function SankeyColumnLabels({ labels, color, trailingRoom = 0 }: SankeyCo
})}
</>
)
-}
+})
diff --git a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyNodeLabels.tsx b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyNodeLabels.tsx
index 12d496b935c1..1037e1de6649 100644
--- a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyNodeLabels.tsx
+++ b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyNodeLabels.tsx
@@ -31,7 +31,10 @@ export interface SankeyNodeLabelsProps {
/** Draws the labels `sankeyLabelBoxes` placed. The chart's hit test reads the same boxes, so the
* pointer passes through a label to the chart and hovering it shows its node's tooltip. */
-export function SankeyNodeLabels({ boxes, color }: SankeyNodeLabelsProps): React.ReactElement {
+export const SankeyNodeLabels = React.memo(function SankeyNodeLabels({
+ boxes,
+ color,
+}: SankeyNodeLabelsProps): React.ReactElement {
return (
<>
{boxes.map((box) => (
@@ -50,4 +53,4 @@ export function SankeyNodeLabels({ boxes, color }: SankeyNodeLabelsProps): React
))}
</>
)
-}
+})
diff --git a/packages/quill/packages/charts/src/charts/ScatterChart/ScatterChart.tsx b/packages/quill/packages/charts/src/charts/ScatterChart/ScatterChart.tsx
index 1e673e3b1085..df0ec3c3ec1a 100644
--- a/packages/quill/packages/charts/src/charts/ScatterChart/ScatterChart.tsx
+++ b/packages/quill/packages/charts/src/charts/ScatterChart/ScatterChart.tsx
@@ -186,7 +186,7 @@ function ScatterChartInner<Meta = unknown>({
)
const drawHover = useCallback(({ ctx, scales, hoverIndex, hoverProgress, theme: drawTheme }: ChartDrawArgs) => {
- const position = readScatterLayout(scales)?.positions.find((p) => p.index === hoverIndex)
+ const position = readScatterLayout(scales)?.positionByIndex[hoverIndex]
if (!position) {
return false
}
diff --git a/packages/quill/packages/charts/src/charts/ScatterChart/scatter-layout.ts b/packages/quill/packages/charts/src/charts/ScatterChart/scatter-layout.ts
index d5ff8a4fc5d8..821b001d80a7 100644
--- a/packages/quill/packages/charts/src/charts/ScatterChart/scatter-layout.ts
+++ b/packages/quill/packages/charts/src/charts/ScatterChart/scatter-layout.ts
@@ -26,6 +26,8 @@ export interface ScatterLayout {
yScale: D3YScale
/** Visible, drawable points in ascending x-pixel order, which the hit test binary-searches. */
positions: ScatterPointPosition[]
+ /** `positions` keyed by point index, so hover finds its marker without a scan. */
+ positionByIndex: (ScatterPointPosition | undefined)[]
/** Canvas-ready series colors by series index, for per-series chrome (the best-fit line) that has
* to match the legend rather than whichever override a marker happens to carry. */
seriesColors: string[]
@@ -89,7 +91,7 @@ export function createScatterScales({
const [yLow, yHigh] = domainBounds(yScale)
const positions: ScatterPointPosition[] = []
- const xByIndex = new Array<number | undefined>(points.length)
+ const positionByIndex = new Array<ScatterPointPosition | undefined>(points.length)
let maxRadius = 0
for (let i = 0; i < points.length; i++) {
const point = points[i]
@@ -104,11 +106,10 @@ export function createScatterScales({
if (!isFinite(x) || !isFinite(y)) {
continue
}
- xByIndex[i] = x
const style = seriesStyles[point.seriesIndex]
const radius = point.radius ?? style?.pointRadius ?? defaultPointRadius
maxRadius = Math.max(maxRadius, radius)
- positions.push({
+ const position: ScatterPointPosition = {
index: i,
seriesIndex: point.seriesIndex,
x,
@@ -117,11 +118,13 @@ export function createScatterScales({
// Canvas can't resolve `var(--…)`, which a consumer color may still be.
color: resolveCssColor(point.color ?? coloredSeries[point.seriesIndex]?.color ?? fallbackColor),
shape: style?.shape ?? 'circle',
- })
+ }
+ positions.push(position)
+ positionByIndex[i] = position
}
return {
- x: (label: string) => xByIndex[Number(label)],
+ x: (label: string) => positionByIndex[Number(label)]?.x,
y: (value: number) => yScale(value),
yTicks: () => yScale.ticks?.(yTickCount) ?? [],
_private: {
@@ -129,6 +132,7 @@ export function createScatterScales({
xScale,
yScale,
positions,
+ positionByIndex,
seriesColors: coloredSeries.map((series) => resolveCssColor(series.color ?? fallbackColor)),
xTicks: resolveXTicks(xScale, xTickCount, xTickFormatter),
maxRadius,
diff --git a/packages/quill/packages/charts/src/charts/TimeSeriesComboChart/TimeSeriesComboChart.tsx b/packages/quill/packages/charts/src/charts/TimeSeriesComboChart/TimeSeriesComboChart.tsx
index 1fe2b04f08ba..0e1c55bcb2e5 100644
--- a/packages/quill/packages/charts/src/charts/TimeSeriesComboChart/TimeSeriesComboChart.tsx
+++ b/packages/quill/packages/charts/src/charts/TimeSeriesComboChart/TimeSeriesComboChart.tsx
@@ -1,4 +1,4 @@
-import React from 'react'
+import React, { useMemo } from 'react'
import { ChartLegend } from '../../components/Legend/ChartLegend'
import type {
@@ -124,7 +124,11 @@ export function TimeSeriesComboChart<Meta = unknown>({
} = useTimeSeries(series, labels, theme, { xAxis, yAxis, valueLabels, legend })
const timeSeriesTooltipConfig = useTimeSeriesTooltipConfig(tooltipConfig, xAxis, labels)
- const { referenceLines, valueDomain } = useGoalLines(goalLines, chartSeries)
+ const { referenceLines, valueDomain: goalLineDomain } = useGoalLines(goalLines, chartSeries)
+ const valueDomain = useMemo(
+ () => mergeValueDomains(config?.valueDomain, goalLineDomain),
+ [config?.valueDomain, goalLineDomain]
+ )
const trendSeries = useTrendLineSeries(visibleSeries, trendLines)
@@ -149,7 +153,7 @@ export function TimeSeriesComboChart<Meta = unknown>({
barCornerRadius,
bandPadding,
tooltip: timeSeriesTooltipConfig,
- valueDomain: mergeValueDomains(config?.valueDomain, valueDomain),
+ valueDomain,
yAxes,
}
diff --git a/packages/quill/packages/charts/src/core/canvas-renderer.ts b/packages/quill/packages/charts/src/core/canvas-renderer.ts
index 9fcc40530544..80d5f04d21ca 100644
--- a/packages/quill/packages/charts/src/core/canvas-renderer.ts
+++ b/packages/quill/packages/charts/src/core/canvas-renderer.ts
@@ -436,6 +436,10 @@ function getHatchPattern(ctx: CanvasRenderingContext2D, color: string): CanvasPa
if (scale !== 1 && typeof pattern.setTransform === 'function' && typeof DOMMatrix === 'function') {
pattern.setTransform(new DOMMatrix([1 / scale, 0, 0, 1 / scale, 0, 0]))
}
+ // Per-bar colors and each browser zoom level add a key, so evict the oldest past a cap.
+ if (hatchPatternCache.size >= 64) {
+ hatchPatternCache.delete(hatchPatternCache.keys().next().value!)
+ }
hatchPatternCache.set(key, pattern)
return pattern
}
diff --git a/packages/quill/packages/charts/src/core/hooks/useChartInteraction.ts b/packages/quill/packages/charts/src/core/hooks/useChartInteraction.ts
index 9e3c6cfcf48e..4453c61ae0d3 100644
--- a/packages/quill/packages/charts/src/core/hooks/useChartInteraction.ts
+++ b/packages/quill/packages/charts/src/core/hooks/useChartInteraction.ts
@@ -12,6 +12,7 @@ import {
import { defaultResolveValue } from '../types'
import type {
AreaSelectData,
+ BandSlot,
ChartDimensions,
ChartScales,
DateRangeZoomData,
@@ -252,13 +253,20 @@ export function useChartInteraction<Meta = unknown>({
[scales, dimensions, interactionAxis, labelPositions, resolveHoverIndex]
)
- const buildCtxAt = useCallback(
- (index: number, position: { x: number; y: number }): TooltipContext<Meta> | null => {
+ // Rows depend only on the index and the bar slot, so a move inside one band reuses them
+ // instead of walking every series. The memo deps drop the cache when the rows go stale.
+ const buildCtxAt = useMemo(() => {
+ let last: { ctx: TooltipContext<Meta>; slot: BandSlot | undefined } | null = null
+ return (index: number, position: { x: number; y: number }): TooltipContext<Meta> | null => {
if (!scales) {
return null
}
const canvasBounds = canvasRef.current?.getBoundingClientRect() ?? new DOMRect()
- return buildTooltipContext(
+ const slot = scales.bandSlotAtCursor?.(labels[index], position)
+ if (last && last.ctx.dataIndex === index && last.slot?.x === slot?.x && last.slot?.width === slot?.width) {
+ return { ...last.ctx, hoverPosition: position, canvasBounds }
+ }
+ const ctx = buildTooltipContext(
index,
series,
labels,
@@ -272,21 +280,22 @@ export function useChartInteraction<Meta = unknown>({
effectivePositionResolve,
resolveBottomValue,
scales.extent?.(labels[index]),
- scales.bandSlotAtCursor?.(labels[index], position)
+ slot
)
- },
- [
- scales,
- series,
- labels,
- labelToCoord,
- canvasRef,
- resolveValue,
- interactionAxis,
- effectivePositionResolve,
- resolveBottomValue,
- ]
- )
+ last = ctx ? { ctx, slot } : null
+ return ctx
+ }
+ }, [
+ scales,
+ series,
+ labels,
+ labelToCoord,
+ canvasRef,
+ resolveValue,
+ interactionAxis,
+ effectivePositionResolve,
+ resolveBottomValue,
+ ])
const onMouseMove = useCallback(
(e: React.MouseEvent<HTMLDivElement>) => {
diff --git a/packages/quill/packages/charts/src/overlays/AxisTitles.tsx b/packages/quill/packages/charts/src/overlays/AxisTitles.tsx
index 3ea55a58c047..893a1a126a6f 100644
--- a/packages/quill/packages/charts/src/overlays/AxisTitles.tsx
+++ b/packages/quill/packages/charts/src/overlays/AxisTitles.tsx
@@ -47,7 +47,7 @@ interface YTitle {
label: string
}
-export function AxisTitles({
+export const AxisTitles = React.memo(function AxisTitles({
xAxisLabel,
yAxisLabel,
hideXAxis,
@@ -138,4 +138,4 @@ export function AxisTitles({
))}
</svg>
)
-}
+})