:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(aio): feedback mode in the trace view (#124370)
Carlos Marchale75e4b5c55fa
diff --git a/frontend/snapshots.yml b/frontend/snapshots.ymlindex 75ac4a633d7b..75e8232fa187 100644--- a/frontend/snapshots.yml+++ b/frontend/snapshots.yml@@ -9402,6 +9402,34 @@ snapshots:hash: v1.k794b7964.18a5cfad31942328a434365883c65172a0f3f7a756f2916ac0726f92fca74cf7.jvxXbglsX6UmEjzYyVSB1iLfJsbPYbqecXm3ObDGd-Uscenes-app-ai-observability-trace-view-evals-chip--some-failed--light:hash: v1.k794b7964.f6f244cf98f06733927cd0a5ee7d7904908c6489b4583e71d0e445f5b6c30397.SbII8dL5ykXeviCDXpciR9TWuevdn0XLgEzEU3PejDM+ scenes-app-ai-observability-trace-view-feedback--empty--dark:+ hash: v1.k794b7964.7fcd6990cb4124d3c2102fdf9a61729a7147140dd202705dcc13d148340a6aae.K6Y6bMLOoabdYZYDhkpEgdaWMIKc8bxHYqARMBjcJsg+ scenes-app-ai-observability-trace-view-feedback--empty--light:+ hash: v1.k794b7964.1a5e59c324cf81fcaa6ca778eb489f6c873ab83cef4eebe79b2404dc7ade7bff.QkZ2cNKAkwNU5zYhWlqYB4ev6HG9zI5oBp7nzYZ7wbg+ scenes-app-ai-observability-trace-view-feedback--focused-on-a-step--dark:+ hash: v1.k794b7964.ccf120a9d03e413fbd5e98441fe4c4ccc12223da1923981b43717bfdb3132227.xXmxciFfHeD25MoC3s_b7W-W_6iMvjW1RgYbWkIRknw+ scenes-app-ai-observability-trace-view-feedback--focused-on-a-step--light:+ hash: v1.k794b7964.81aca80e1a006e4fff1d5dc7fe5204dc44eb78189d5afe8dc8ec9961f4908ed6.bD9_IN2ef91Ivy1baRiMrCaJC19dvJE8aK3qwzdPX2w+ scenes-app-ai-observability-trace-view-feedback--load-error--dark:+ hash: v1.k794b7964.301dadafb29717ba88b66710be34615cc9e67a4beccd43eef4334f8792ff8323.SzHj1myUJ4kvyfqH6IK8kqrEUTOhYQVXrkx2MBiNAGI+ scenes-app-ai-observability-trace-view-feedback--load-error--light:+ hash: v1.k794b7964.519e57591ccefe1731d772b1c4f15475e1fa15dc5389f96fc6339b2a7da76ebc.e9xUnqnS9SyL0wG1UTxUkQ-7L2-0TWnQgUjcxpSYwBo+ scenes-app-ai-observability-trace-view-feedback--loading--dark:+ hash: v1.k794b7964.0471eb1b8722d32740334f9710ec2aca109e23c647d3f1d81b52b3e6409b8f93.iemk01BDubuVYff8z6ptDbkveQ0Vawv6FKeXTwzXQWQ+ scenes-app-ai-observability-trace-view-feedback--loading--light:+ hash: v1.k794b7964.21d886cdffe610104020c41adba7daed122c2558b46c64f3db996310820a92a5.Kgd6p3D4p6GKOXi1u6wCVFfNxiinZZKyqXFS7o--x14+ scenes-app-ai-observability-trace-view-feedback--narrow--dark:+ hash: v1.k794b7964.407140f0509c3f0f44cfccebeb90073405fb276b49f5e68bbe01e453de2e51b8.awZbgmLAyB0Lj58ifmDYcfThU0faXTmmrMsaZkmhQMw+ scenes-app-ai-observability-trace-view-feedback--narrow--light:+ hash: v1.k794b7964.c196f001ea7d126b256b1e773a12b4804486b5b9467a74c9cd90bc928f03953c.dkmJGOz-kuZFaNJat6eo9aN7nfSpyo_jHxIgNUgnYo4+ scenes-app-ai-observability-trace-view-feedback--scores-and-text--dark:+ hash: v1.k794b7964.42534f604afe39beb23e4c09f89d84809bc98e4f2b59fedb79e5a31144f8c500.2i0dy5bXglrLz9xRUb8jss1TSydnGhnJeWRoGNn6uac+ scenes-app-ai-observability-trace-view-feedback--scores-and-text--light:+ hash: v1.k794b7964.23f60c51ffb9d41d8ab5d03d9f30c9e62768250379833fd1c6196d00ab108f8f.8NoTmsvyC58bzmjEpT9XUJioQgw6Jb_fNvrRy_8kaEU+ scenes-app-ai-observability-trace-view-feedback--scores-only--dark:+ hash: v1.k794b7964.b070900020433ca79a06ea06e9d662e53127c9eac7bb8f9db7d56b0965f20615.u7YGWkBWd6FhUE3YrpBUW6vQXiCoSMApTE9jWdTkvis+ scenes-app-ai-observability-trace-view-feedback--scores-only--light:+ hash: v1.k794b7964.96177e830cd7e7306e202523e1fc27a44436de5e7956ce78836c02e4c8be708f.BYDlsBquGF3TY13KOFeLtmIIfPaVhmoXhqqOYgA1FFgscenes-app-ai-observability-trace-view-input-and-output--empty-object--dark:hash: v1.k794b7964.6ed3f97001d8b595545a78f37627d3e09c188a3dcd782c8ab3389c65cbd4210f.2U9W7fXNr-OZRXfkmXy1ICFu5-dSKZUsMMWOtbf4PWwscenes-app-ai-observability-trace-view-input-and-output--empty-object--light:@@ -9570,6 +9598,10 @@ snapshots:hash: v1.k794b7964.c8738b258fcc296e359dd79434a649f7db699a8e4962261f71a015b09384574e.h3AQS336jkEfDQaxuGRGG5ULNxBK8J63SAMLz2dNx6wscenes-app-ai-observability-trace-view-node-detail--with-error--light:hash: v1.k794b7964.501e82359c3f544a1c71848d3aec9ae003cb67b73adc58a8763ff92c69917dbb.Ia-6XmopuYjE7La38FGhkUEEA0c55yavYiFjtTWWGYc+ scenes-app-ai-observability-trace-view-node-detail--with-feedback--dark:+ hash: v1.k794b7964.5e1f9f34b96c460316c366abe05fd140dfff757f817c984a6aaa3f1a3a4ed6c6.x7QIn55nkut1zoUc4yjHRJIz22K6snegMSzeftorN4A+ scenes-app-ai-observability-trace-view-node-detail--with-feedback--light:+ hash: v1.k794b7964.81c3fa1409381d3ef0d6af5af351d6d44f777df68bef9e7b3c59c25990ff1c48.mFdzdRPNLRPF4cDUL0sgLzl1ty0fBmVXWu_oHpOlYuMscenes-app-ai-observability-trace-view-node-kind-glyph--all-kinds--dark:hash: v1.k794b7964.d092355849e660b2450465e4eeaf6e78e7d435f22117ba6b9c7d831cbbe8e278.K9O8_ysBelMXcyNmH-O56K6JW4EVlEhGPXPFAgFbKJIscenes-app-ai-observability-trace-view-node-kind-glyph--all-kinds--light:@@ -9731,9 +9763,13 @@ snapshots:scenes-app-ai-observability-trace-view-trace-header--narrow--light:hash: v1.k794b7964.9fca5efe3c2de8d82b73848a8d53c57cc8beb108f927b4243c83f5e16e6814db.dlDT_i8yO4AuXDskXau5HcG0BzAI_n0LYfiX8aENnIwscenes-app-ai-observability-trace-view-trace-mode-tabs--default--dark:- hash: v1.k794b7964.c127014e07f56d9cc05464accffc054cd7fc158ecc05f68412286c1c68e52920.imWl_iWrNCNM_tSkxLW8WzC_8FKPDXmWuK1Jq2Bjopk+ hash: v1.k794b7964.438ee912f36d4f19ccec0b12f645b823068e4a5103daef99effe519602b07c07.757Ls8z7uxMrtEqvXV0u69Mo0onygkWWCfZvys0zLw0scenes-app-ai-observability-trace-view-trace-mode-tabs--default--light:- hash: v1.k794b7964.8c463d9853989ca1f4963cbe4537d059ab1bb411e924a2419a3005c7575bf7be.fWN4UhPWA9QTC39P0SQDKe4A3iqksw4pTrbvrWEQ_zk+ hash: v1.k794b7964.54c1b3ab8dd9be82c932db5549273e0e1b965c836dd94a9133ca2081ce4a3b62._OBbr2_5y_8rTzynpmGPowTINrY-uE0zu6PahDPwk18+ scenes-app-ai-observability-trace-view-trace-mode-tabs--with-feedback-count--dark:+ hash: v1.k794b7964.4d6f84c870fe9b3fb3648dfe92a798a76849f7c97b0ee2e1558b30866e8ed274.fOeyVQsBh9OfZRZnRzhoUQ9pnnoJrW0OBNvyBldR5Lo+ scenes-app-ai-observability-trace-view-trace-mode-tabs--with-feedback-count--light:+ hash: v1.k794b7964.7cc0c8d5f26b9f7ded485d8b5366a5496b5cb0104742ad305af8ac1194cbe070.-LKvyqtdXXL8XDIkB2alL1uqfXpXTrKaKCkPvAZNBCAscenes-app-ai-observability-trace-view-trace-split-view--narrow--dark:hash: v1.k794b7964.7e4eef01f6f5dca0671db52b44959fdc401a61dec4d72ca3730a7276033c73ee.NS9WNST2qDaBnvQacs6Lnro9dedItLwYX7M40RNgJxoscenes-app-ai-observability-trace-view-trace-split-view--narrow--light:@@ -9766,6 +9802,10 @@ snapshots:hash: v1.k794b7964.b0dd60321acfc66eff4b4fe61c0123016d6ef51e83d18e1a33989d71056cf4c4.rhGXCqb0ZHRrzjcvMjSYO0_vKIrG0vZRA9yacMU9g4Ascenes-app-ai-observability-trace-view-trace-summary-bar--short-id--light:hash: v1.k794b7964.bbfc40a18f0a11428e95c34e2783676e785e9e7730f88d7efb397ad11b954fad.A7axwdw43M17lj8qq6VSnmn7SyIXVP2oOIQzdvKA9m8+ scenes-app-ai-observability-trace-view-trace-summary-bar--with-feedback--dark:+ hash: v1.k794b7964.4ee4b41df55c5bc9f386036bb5c7bf684ca90215cb9046f62375c4d8eb2defd4.Xu2hxbSf7Oc5ztiyAnhnTkeZCdhT-YnBK5mMKOAfG8E+ scenes-app-ai-observability-trace-view-trace-summary-bar--with-feedback--light:+ hash: v1.k794b7964.5d0c02950560590edad3e1fa8b3f99e6902fcc985b851da597d44ced4d939463.kPdKrZlopeUVOoWVRCWlKfALaCfeYakSfKN7pHJY9U4scenes-app-ai-observability-trace-view-trace-summary-bar--with-git-branch--dark:hash: v1.k794b7964.f48c22bbab5113e9ef6290dad04daae1285be7f8932d41fa8ace16ace664e502.oxJblySth_77826dzwFkmd_PGo7EfwpvdJx8GlFzrgwscenes-app-ai-observability-trace-view-trace-summary-bar--with-git-branch--light:@@ -9814,14 +9854,22 @@ snapshots:hash: v1.k794b7964.48fb8bc8543f07dec17a1068f04fcc7b8920848ebdab86c2a6bf7c71d60baea1._LgDFVdSsH5dQaz7oMJOzhbhjI4xJn8CPNdJ96gYANsscenes-app-ai-observability-trace-view-trace-tree--with-eval-markers--light:hash: v1.k794b7964.67d9d4a7acfd72574651a76ff2ef9d1fb83aef6e385c8bb15d96ab30145b75e5.qN7CWxyPOS0zm3V-jTe_Gr-8o5RYlGYsz3SH-dkoRDI+ scenes-app-ai-observability-trace-view-trace-tree--with-feedback-markers--dark:+ hash: v1.k794b7964.c6cd54aabda6eef28a4514347459d2a599b0e381940dbba7d2a59e1ccdcc532d.7Ae1tlm2Y3ZYceOrhcnzv7Oga1YutazxEoehY1zMZco+ scenes-app-ai-observability-trace-view-trace-tree--with-feedback-markers--light:+ hash: v1.k794b7964.391466dbd7a7552e5e08a538864c400041ad512e957dbe68d845d99b74753dd5.HI6rvM5LIg8SjUwVEnIQNRRXlcfIP6B8Kw9qQ6ExqWEscenes-app-ai-observability-trace-view-trace-view--error-trace--dark:- hash: v1.k794b7964.599c9445609ed72cf749ae7528396a1311f0e2521b7e0ed0e426ddc9fc03c38e.wUYbcoLv-KCwJ9NoJJrBxE6sV_Fc_4IIpFGHrEboKqw+ hash: v1.k794b7964.a497ad504c6a9d0d425173914797467cb239bd4a2bb2cc25afb26c81eea3cdfd.1XmbemnPvJjwGHM3Jev1TAMsYMNdyx6ykWGU2d-qq2kscenes-app-ai-observability-trace-view-trace-view--error-trace--light:- hash: v1.k794b7964.a8da7581409840f7f4368331b0a911e731e52c12fb934c5e1543ae961122ed46.YID83KnbvF5cCoIbYi1NorMl3faoHi_kY0xBFWIisPU+ hash: v1.k794b7964.bf3111e7a39fc9d9c9dd2acaeb3e0a6dd264005eaf7630e02f83e76f0b31c6c4.mILO7jkQuM6lNdlXFNhncF9TyaT5CuSfze_ookKOiz4+ scenes-app-ai-observability-trace-view-trace-view--feedback-mode--dark:+ hash: v1.k794b7964.df4d60c2a4558c739f9658ba5ba5a85d1b6988925f88210eb8973c2f72a96c9d.i7rmESrElWpU9f6K3xEfiWUCq2LmGVcGzGXrNEhvtXY+ scenes-app-ai-observability-trace-view-trace-view--feedback-mode--light:+ hash: v1.k794b7964.4008b7bc041e33d6457038242a83d34e06aa0064f52e08241bc4a40112c71cbd.3inRKhCjXf4qBLuXls4GrocWk1OxTlSJbTSCOtgyH7wscenes-app-ai-observability-trace-view-trace-view--generation-selected--dark:- hash: v1.k794b7964.7989c9e77bd8136fb9b1bfce2872dbb0b78b9c4526c2c510ed14f0c6b4e59739.PNe_2hniIB34Cw36gqucK4sxQo-4sPpMSECQCuvg_jA+ hash: v1.k794b7964.d31bb379f48e59e75e81826b08e59e01c8729349348209e37312494cc2f520f3.SD-1JnMC8iAmFz0cQLskows96wdUBctK7pFjw0EHCvMscenes-app-ai-observability-trace-view-trace-view--generation-selected--light:- hash: v1.k794b7964.8da284aa3fd303a7f99554b18ed2a7e20481e9d4efcfc7ce714ace0ba65295dc.8w5YNLKTmiDU3Sk0zwmlJj9Bkx1A92iwtf48Ivz6r3U+ hash: v1.k794b7964.fc6b37f9158f52ff43c7142d59fee905ab0a4659407c4c4132ec3638c46f9b7a.xpXaY2gW6gZy2l7hLObvHItbSUwnaJ-D2uj3W5ZNaOsscenes-app-ai-observability-trace-view-trace-view--load-error--dark:hash: v1.k794b7964.c4e963947f61276470d35e280b1b69130365cde0f3153efba7bfbab805e496de.B2FhLvOWBsI-x3axjIDbfrTFGaYKLtFR32l7sn4SCfIscenes-app-ai-observability-trace-view-trace-view--load-error--light:@@ -9839,33 +9887,33 @@ snapshots:scenes-app-ai-observability-trace-view-trace-view--narrow-with-evals--light:hash: v1.k794b7964.6129305fc216488d475d85c4a37d01d76114c241395233fc6e34d7bedb73c7cd.hkKR3Hq1HrBBKZk0aYwMNNZYk9fKt7e5D_36eoqSXcsscenes-app-ai-observability-trace-view-trace-view--sample-anthropic-thinking-tool-use--dark:- hash: v1.k794b7964.3cbdff3426f3edcae67c7b64ceeefc0474e8f0b387dc1df11e74210699e10b44.MMJUyQiF4E9QeDIwor3PcTmupz4n8OqGR-FHHuic5V0+ hash: v1.k794b7964.ee72ae95c2c0db21361b7924fb3f7db28af93dae0f3773ad4530f847f95fc20c.1m0893IlRbuhUW5V-caBPubusOcO8QdDfOSfYt_iA5kscenes-app-ai-observability-trace-view-trace-view--sample-anthropic-thinking-tool-use--light:- hash: v1.k794b7964.590a6eaff8315f61e7014dec10e6b76ad62e2276bd6b192a62752c9df92f38e7.Tx9-RxKj-RoPdf-KYfQQSu1g-oVRmwL8cLuk6C3jmLs+ hash: v1.k794b7964.7ee3bf3f1ad3306cba6efbdad71d55f02761c6139fbb0839be3ef48c5bdfb34b.JWoFgw07MQS9JAi_ceD1x4gn-lM1bf0CezHkgfA-Rckscenes-app-ai-observability-trace-view-trace-view--sample-claude-code-session--dark:- hash: v1.k794b7964.4f299bbc25de783c019e346e13b7dff0bbdcb9c0afa384424502246d2200cb11.oFJCtJ9GaMcq36FXdtSfTqxktwXT4L9qgdNpYq1KFcs+ hash: v1.k794b7964.7332d2582d615adc68bf0e1b431d3d1ee7727b8c8654ce28623c2aa7dc48268e.GYwTYWhFOA2EgCJsA5wleu7fC9S6kYGijO6WaqQAAcAscenes-app-ai-observability-trace-view-trace-view--sample-claude-code-session--light:- hash: v1.k794b7964.667b0b5bf607288437fc42d6b2a87e12749e5e5431694034af87a030165f5382.5L9pc3B4k-1h1ORigHPuxnBoVMjWkKM2_mwC1NAxvEI+ hash: v1.k794b7964.ee7f3c380b3642b4445628db77cd1342df292d96dfcd3de3d94b1c57d69b462a.eNjZlu6UFymTA1HiXx6wEDA5Xm0Rb30TkDKzYLRT9y0scenes-app-ai-observability-trace-view-trace-view--sample-lang-chain-image-error--dark:- hash: v1.k794b7964.9438d2ccbef1be8ae87db81123cae1184342c55c811a3a06c4e76e903e3c980e.U8liqolfJijqkndiT5N8vO7_QuU9Fb7u63C6eLRlHco+ hash: v1.k794b7964.43676b281ec34e4cf3de7bf8693142fbe554d98f1916d3bd3f3b4fdfd3b9dca3.cVg0LIpxpsiy2dVNQ9JcTJCi9B8GZavkxr3KcRpmvaIscenes-app-ai-observability-trace-view-trace-view--sample-lang-chain-image-error--light:- hash: v1.k794b7964.c4e68e4bc073acfd3526b31c9a6c30af8227b383cfe9c64c869a9085e2f21366.OW-LgHY5e0KMPR6d3J8lqdrhnjUBljeLruIIU4--5o8+ hash: v1.k794b7964.cfa4fd02700d5ae8e2bcee75d612bd4c6a7009d1b4c1911f21f4811d9d877edb.EzB7CHpR82W6mfKKalYuFQFQxXUyD4NntHnVZS8Na84scenes-app-ai-observability-trace-view-trace-view--sample-open-ai-agents-with-evals--dark:- hash: v1.k794b7964.3b6cfa51d04e12c148f1da5f58a5e9f8f275a6c4e5b21d2ffd7882724e69212a.E-hiUUQTSRTbhyFBtQ84ROVaZPwc9Y8aiMf9a3PWHck+ hash: v1.k794b7964.12ceafac55ab053f2a43ab3af2abca0ac62b79e37ab465f0cf37b9d268d202e1.ov5yj7FtQgb_CDCZi8LFNuYw3nKC8UhjcvsBINT6Cukscenes-app-ai-observability-trace-view-trace-view--sample-open-ai-agents-with-evals--light:- hash: v1.k794b7964.da0833b682042c272451cdc1b879b3c355db96c7a1a08f4d7d932e5651a5045d.sfjWlM4sh7jLKWwOn6_6uANHQHh7pQzJHu1-JCor8Ro+ hash: v1.k794b7964.0defbf16466852328781c98a0b1bad727292512e3d6ef94a34ef89a7cc7af7c8.YxnGetMJ8rP0TaFE_BGBDK33bYPoEi7QBgsYACaJnRsscenes-app-ai-observability-trace-view-trace-view--span-selected--dark:- hash: v1.k794b7964.a627385c064141e6dcc1c4982b480253e078f86dadf70ed946b2053e6582eb3e.LqyOLP_eIAZNH0bQ6WAyzn-RWqWFqzv2HOutDpa8ziI+ hash: v1.k794b7964.d9030839e09f00adf85247243f7c3ed464c5dc92eeb24e07a236589f60f2aff5.M6PfoGn5kB0EJlPjKm5_iU-V2qMAT6e3bM_F5hX2wJIscenes-app-ai-observability-trace-view-trace-view--span-selected--light:- hash: v1.k794b7964.4ea31459d2d9e900d92ddbd3e9da8ae1b5f3ea0628d11164c83f7bcd888a7f56.e2V0WEspClwP7l0Culkfh-XzRnZxsEDxs2BOuVfvxjI+ hash: v1.k794b7964.05f4b072801f0c443750fe53ec66bd1f7a6eefd15e1121655fa1732be4cd3c58.WKTd4i-my01kKpC88NqaEooMvQP-vhP648etK3hgGoUscenes-app-ai-observability-trace-view-trace-view--thread-mode--dark:- hash: v1.k794b7964.0acba892f985205101410c7bb58d2456a042d725f0f9502ab56ddc089523b136.uZVgX0z8V5BNDPDqFzrkKq74B_KYx6RK4vk-qAYkExw+ hash: v1.k794b7964.43cfa1c38de8c8dfb0601316dd27d9a12db42ffdc489ada0684c9809d8f9b293.oepw24gCbLpLfQjK0n9jQLFd72siJy2qGprpScEZYzYscenes-app-ai-observability-trace-view-trace-view--thread-mode--light:- hash: v1.k794b7964.d6ff099b8cea000fa7e023a88144ab469da1c25db023ea5109a3891e4e4057d2._lPiHxUc9NbaPT_2V4hII9vj7InrIT8M83NHjTXEC2M+ hash: v1.k794b7964.254a76b3961b4a28cd1c15be3bc9cf8989295f9f6d9e58338bf340861b6b7fec.lTdceUiLj8nb2_4WWO2L0MwSy21HOJwI8X8PL9TGwx8scenes-app-ai-observability-trace-view-trace-view--timeline-mode--dark:- hash: v1.k794b7964.70302b15caaea759a5d9db2ae961f99b0ad7213e975e226aee93c0c359315510.zf3TUMVc-R1rm5IyKav2tNPs54xcTB98Dvm2mGeWEjw+ hash: v1.k794b7964.4fd30876a3d5b8cc1e4921f0b39f33bbcb4d5021bd731b5eda45a0d3c02ecfbe.z5SMZqbcY9IUJswh9a7w-CQNRFB9P8OFX4fSCbc63Hsscenes-app-ai-observability-trace-view-trace-view--timeline-mode--light:- hash: v1.k794b7964.efb8b37e950b518d97cd742ef44b75d249ac94d327c5a2965d4a7697ec60c01e._j6psG-8_2R2QiOtYdPV4doYlMJNoP5LsmxS5A7OCFw+ hash: v1.k794b7964.0a2c243cc6f5c31c0dd4816a6f8cf298b41afdafc4c448662b684d5a8db71510.AODbw-4YTpZAEfwCt2zFT8isU_e0WrbxGUXq6ukMF50scenes-app-ai-observability-trace-view-trace-view-switch--on-new-view--dark:hash: v1.k794b7964.705e0647746424a98de2bbf79737ac43b3f60b57ae45b8f0e5d0cb5f01226aad.vSallcE6n-MHVAkWEOsfs2D1X--pp40NBjawl5otiOkscenes-app-ai-observability-trace-view-trace-view-switch--on-new-view--light:diff --git a/frontend/src/initKea.ts b/frontend/src/initKea.tsindex 7bc782546093..7b74f709ca70 100644--- a/frontend/src/initKea.ts+++ b/frontend/src/initKea.ts@@ -137,6 +137,7 @@ const ERROR_FILTER_ALLOW_LIST_BY_LOGIC_PATH: Record<string, string> = {updateProviderKey: 'products.ai_observability.settings.llmProviderKeysLogic',deleteProviderKey: 'products.ai_observability.settings.llmProviderKeysLogic',loadEvaluationResults: 'products.ai_observability.frontend.redesign.trace.traceViewLogic', // The trace view's Evals tab shows the error+ loadTraceFeedback: 'products.ai_observability.frontend.redesign.trace.traceFeedbackLogic', // The trace view's Feedback mode shows the error// The trace view's Summary mode shows the errorloadSummary: 'products.ai_observability.frontend.redesign.trace.traceSummaryLogic',requestSummary: 'products.ai_observability.frontend.redesign.trace.traceSummaryLogic',diff --git a/products/ai_observability/backend/facade/api.py b/products/ai_observability/backend/facade/api.pyindex 2ed63c2d42cc..6f51e3d5f944 100644--- a/products/ai_observability/backend/facade/api.py+++ b/products/ai_observability/backend/facade/api.py@@ -20,6 +20,7 @@ from ..logic.traces.evaluation_result import EvaluationResultfrom ..logic.traces.evaluation_result_queries import load_evaluation_results, load_output_configsfrom ..logic.traces.evaluation_summary import EvaluationSummaryfrom ..logic.traces.events_fallback import fallback_window+from ..logic.traces.feedback import FeedbackText, Score, TraceFeedbackfrom ..logic.traces.git import GitReffrom ..logic.traces.node import NodeEventfrom ..logic.traces.summary import (@@ -36,7 +37,7 @@ from ..logic.traces.summary_generation import generate_summaryfrom ..logic.traces.summary_store import fail_abandoned_summary, request_summary, viewer_summaryfrom ..logic.traces.timeline import TimelineRowfrom ..logic.traces.trace import Trace-from ..logic.traces.trace_queries import load_trace, load_trace_node, load_trace_root+from ..logic.traces.trace_queries import load_trace, load_trace_feedback_rows, load_trace_node, load_trace_rootfrom ..logic.traces.tree import TreeNodefrom ..logic.traces.usage import Usagefrom ..temporal.trace_summary_client import start_trace_summary@@ -243,6 +244,32 @@ def _to_evaluation_result(result: EvaluationResult) -> contracts.TraceEvaluation)+def get_trace_feedback(+ team: Team, user: User | None, trace_id: str, timestamp_hint: datetime | None+) -> contracts.TraceFeedback:+ """End-user feedback on a trace. An unknown trace has none."""+ feedback = TraceFeedback(trace_id, load_trace_feedback_rows(team, user, trace_id, timestamp_hint))+ scores = [_to_feedback_score(score) for score in feedback.scores]+ responses = [_to_feedback_text(text) for text in feedback.texts]+ return contracts.TraceFeedback(+ scores=scores,+ responses=responses,+ summary=contracts.TraceFeedbackSummary(total=len(scores) + len(responses)),+ )+++def _to_feedback_score(score: Score) -> contracts.TraceFeedbackScore:+ return contracts.TraceFeedbackScore(+ id=score.id, name=score.name, value=score.value, node_id=score.node_id, timestamp=score.timestamp+ )+++def _to_feedback_text(text: FeedbackText) -> contracts.TraceFeedbackText:+ return contracts.TraceFeedbackText(+ kind="text", id=text.id, text=text.text, node_id=text.node_id, timestamp=text.timestamp+ )++def _to_evaluation_summary(summary: EvaluationSummary) -> contracts.TraceEvaluationSummary:return contracts.TraceEvaluationSummary(passed=summary.passed,diff --git a/products/ai_observability/backend/facade/contracts.py b/products/ai_observability/backend/facade/contracts.pyindex b1e3166d8352..85fbee9b547f 100644--- a/products/ai_observability/backend/facade/contracts.py+++ b/products/ai_observability/backend/facade/contracts.py@@ -169,6 +169,38 @@ class TraceEvaluationResults(Contract):summary: TraceEvaluationSummary+class TraceFeedbackScore(Contract):+ id: str+ name: str | None+ value: str = Field(+ description="The score as text: a string as sent, any other value as compact JSON, such as 0, false or 4.5."+ )+ node_id: str = Field(+ description="The tree node the score targets: the step's event uuid, or the trace id for a trace-level score."+ )+ timestamp: datetime+++class TraceFeedbackText(Contract):+ kind: Literal["text"]+ id: str+ text: str+ node_id: str = Field(+ description="The tree node the feedback targets: the step's event uuid, or the trace id for trace-level feedback."+ )+ timestamp: datetime+++class TraceFeedbackSummary(Contract):+ total: int = Field(description="Scores plus responses.")+++class TraceFeedback(Contract):+ scores: list[TraceFeedbackScore] = Field(description="Oldest first.")+ responses: list[TraceFeedbackText] = Field(description="What users said, oldest first.")+ summary: TraceFeedbackSummary++TraceSummaryStatus = Literal["pending", "ready", "failed"]TraceSummaryFailureReason = Literal["trace_not_found", "too_large", "timeout", "provider_error", "not_approved", "access_changed", "error"diff --git a/products/ai_observability/backend/logic/traces/event.py b/products/ai_observability/backend/logic/traces/event.pyindex c76d5ac1c3f5..741ae833c62b 100644--- a/products/ai_observability/backend/logic/traces/event.py+++ b/products/ai_observability/backend/logic/traces/event.py@@ -6,8 +6,6 @@ from ...facade.contracts import TraceNodeKindfrom .trace_queries import TraceEventRowfrom .usage import Usage-ANNOTATION_EVENTS = frozenset({"$ai_feedback", "$ai_metric"})-def kind_of_event(event_name: str) -> TraceNodeKind:match event_name:@@ -46,10 +44,6 @@ class TraceEvent:def is_trace_event(self) -> bool:return self.row.event == "$ai_trace"- @property- def is_annotation(self) -> bool:- return self.row.event in ANNOTATION_EVENTS-@propertydef has_error(self) -> bool:return self.row.is_error or self.row.error_is_truthydiff --git a/products/ai_observability/backend/logic/traces/feedback.py b/products/ai_observability/backend/logic/traces/feedback.pynew file mode 100644index 000000000000..6d352558ec7e--- /dev/null+++ b/products/ai_observability/backend/logic/traces/feedback.py@@ -0,0 +1,67 @@+import json+from collections.abc import Sequence+from datetime import datetime++from posthog.dataclasses import frozen++from .node_ids import NodeIdResolver, NodeIds+from .trace_queries import FEEDBACK_EVENT, METRIC_EVENT, NODE_EVENT_NAMES, FeedbackEventRow+++def present_value(raw_json: str) -> str | None:+ """A sent value as text, or None when the value is missing, null or an empty string. 0 and false are present."""+ if not raw_json:+ return None+ try:+ value = json.loads(raw_json)+ except ValueError:+ return None+ if value is None or value == "":+ return None+ if isinstance(value, str):+ return value+ return json.dumps(value, separators=(",", ":"))+++@frozen+class Score:+ id: str+ name: str | None+ value: str+ node_id: str+ timestamp: datetime+++@frozen+class FeedbackText:+ id: str+ text: str+ node_id: str+ timestamp: datetime+++class TraceFeedback:+ def __init__(self, trace_id: str, rows: Sequence[FeedbackEventRow]) -> None:+ ordered = sorted(rows, key=lambda row: row.timestamp)+ steps = NodeIdResolver(+ NodeIds(uuid=row.uuid, generation_id=row.generation_id, span_id=row.span_id)+ for row in ordered+ if row.event in NODE_EVENT_NAMES+ )++ def target(row: FeedbackEventRow) -> str:+ if row.parent_id is None or row.parent_id == trace_id:+ return trace_id+ return steps.resolve(row.parent_id) or trace_id++ scores: list[Score] = []+ texts: list[FeedbackText] = []+ for row in ordered:+ if row.event == METRIC_EVENT and (value := present_value(row.metric_value_json)) is not None:+ scores.append(+ Score(id=row.uuid, name=row.metric_name, value=value, node_id=target(row), timestamp=row.timestamp)+ )+ elif row.event == FEEDBACK_EVENT and (text := present_value(row.feedback_text_json)) is not None:+ texts.append(FeedbackText(id=row.uuid, text=text, node_id=target(row), timestamp=row.timestamp))+ self.scores = tuple(scores)+ self.texts = tuple(texts)diff --git a/products/ai_observability/backend/logic/traces/node_ids.py b/products/ai_observability/backend/logic/traces/node_ids.pynew file mode 100644index 000000000000..14b784acb1aa--- /dev/null+++ b/products/ai_observability/backend/logic/traces/node_ids.py@@ -0,0 +1,33 @@+from collections.abc import Iterable++from posthog.dataclasses import frozen+++@frozen+class NodeIds:+ uuid: str+ generation_id: str | None+ span_id: str | None+++class NodeIdResolver:+ """Resolves the ids SDKs send for a step (its event uuid, generation id or span id) to its event uuid."""++ def __init__(self, nodes: Iterable[NodeIds]) -> None:+ self._uuids: set[str] = set()+ self._aliases: dict[str, str] = {}+ for node in nodes:+ self._uuids.add(node.uuid)+ for alias in (node.generation_id, node.span_id):+ if alias and alias != node.uuid:+ self._aliases.setdefault(alias, node.uuid)++ @property+ def aliases(self) -> dict[str, str]:+ """Each generation and span id that differs from its step's uuid, mapped to that uuid. The first step wins."""+ return dict(self._aliases)++ def resolve(self, node_id: str) -> str | None:+ if node_id in self._uuids:+ return node_id+ return self._aliases.get(node_id)diff --git a/products/ai_observability/backend/logic/traces/summary_generation.py b/products/ai_observability/backend/logic/traces/summary_generation.pyindex c413ac318ff7..e3f618d5f801 100644--- a/products/ai_observability/backend/logic/traces/summary_generation.py+++ b/products/ai_observability/backend/logic/traces/summary_generation.py@@ -135,7 +135,7 @@ def _generate(run: _Run, *, final_attempt: bool) -> TraceSummaryRun:return run.failed("trace_not_found")trace = Trace(job.trace_id, loaded.rows, loaded.person)root = load_trace_root(team, requester, job.trace_id, trace.created_at)- step_ids = [event.id for event in trace.events if not event.is_trace_event and not event.is_annotation]+ step_ids = [event.id for event in trace.events if not event.is_trace_event]steps = load_trace_nodes(team, requester, job.trace_id, step_ids, trace.created_at)# Each read applies the restrictions in force when it runs. A change during the reads could put content under# an entry whose viewers may not read it.diff --git a/products/ai_observability/backend/logic/traces/trace.py b/products/ai_observability/backend/logic/traces/trace.pyindex 8eb0fdb96655..33a59104b7d9 100644--- a/products/ai_observability/backend/logic/traces/trace.py+++ b/products/ai_observability/backend/logic/traces/trace.py@@ -4,6 +4,7 @@ from functools import cached_propertyfrom .event import TraceEventfrom .git import GitRef+from .node_ids import NodeIdResolver, NodeIdsfrom .thread import pick_user_visible_generationfrom .timeline import Timelinefrom .trace_queries import PersonRow, TraceEventRow@@ -77,14 +78,11 @@ class Trace:@cached_propertydef node_ids_by_alias(self) -> dict[str, str]:- aliases: dict[str, str] = {}- for event in self.events:- if event.is_annotation or event.is_trace_event:- continue- for alias in (event.row.generation_id, event.row.span_id):- if alias and alias != event.id:- aliases.setdefault(alias, event.id)- return aliases+ return NodeIdResolver(+ NodeIds(uuid=event.id, generation_id=event.row.generation_id, span_id=event.row.span_id)+ for event in self.events+ if not event.is_trace_event+ ).aliases@cached_propertydef git(self) -> GitRef | None:diff --git a/products/ai_observability/backend/logic/traces/trace_queries.py b/products/ai_observability/backend/logic/traces/trace_queries.pyindex aeadaaff5a65..ee45ff372a68 100644--- a/products/ai_observability/backend/logic/traces/trace_queries.py+++ b/products/ai_observability/backend/logic/traces/trace_queries.py@@ -21,8 +21,8 @@ from posthog.models import Team, Userfrom .events_fallback import FallbackWindow, events_filter, fallback_window, unhinted_windowfrom .person import trace_distinct_id-TRACE_EVENT_NAMES = ("$ai_trace", "$ai_span", "$ai_generation", "$ai_embedding", "$ai_metric", "$ai_feedback")NODE_EVENT_NAMES = ("$ai_span", "$ai_generation", "$ai_embedding")+TRACE_EVENT_NAMES = ("$ai_trace", *NODE_EVENT_NAMES)_HEAVY_COLUMNS = ("input", "output", "output_choices", "input_state", "output_state", "tools")_NODE_COLUMNS = ("uuid", "event", "timestamp", "properties", *_HEAVY_COLUMNS)# The largest result HogQL returns; without an explicit limit it returns 100 rows.@@ -137,10 +137,10 @@ _SELECTED: dict[str, ast.Expr] = {}-def _select() -> list[ast.Expr]:+def _select(selected: dict[str, ast.Expr] = _SELECTED) -> list[ast.Expr]:return [expr if isinstance(expr, ast.Field) and expr.chain == [alias] else ast.Alias(alias=alias, expr=expr)- for alias, expr in _SELECTED.items()+ for alias, expr in selected.items()]@@ -235,6 +235,8 @@ def _read(user: User | None,trace_id: str,window: FallbackWindow | None,+ *,+ event_names: Sequence[str] = TRACE_EVENT_NAMES,) -> list[Sequence[Any]]:tag_queries(name=name)response = query_ai_events(@@ -246,7 +248,7 @@ def _read(fall_back_to_events=True,fallback_placeholders={"filter_conditions": events_filter(- trace_filter=_trace_filter(trace_id), event_filter=_event_in(TRACE_EVENT_NAMES), window=window+ trace_filter=_trace_filter(trace_id), event_filter=_event_in(event_names), window=window)},posthog_tables_only=True,@@ -357,14 +359,17 @@ def _read_trace(timestamp_hint: datetime | None,*,widen_unhinted: bool,+ event_names: Sequence[str] = TRACE_EVENT_NAMES,) -> list[Sequence[Any]]:if timestamp_hint is not None:- return _read(name, build_query(), team, user, trace_id, fallback_window(timestamp_hint))- results = _read(name, build_query(), team, user, trace_id, None)+ return _read(+ name, build_query(), team, user, trace_id, fallback_window(timestamp_hint), event_names=event_names+ )+ results = _read(name, build_query(), team, user, trace_id, None, event_names=event_names)if results or not widen_unhinted:return resultslogger.warning("ai_trace_unhinted_events_fallback", team_id=team.pk, trace_id_length=len(trace_id), read=name)- return _read(name, build_query(), team, user, trace_id, unhinted_window())+ return _read(name, build_query(), team, user, trace_id, unhinted_window(), event_names=event_names)def load_trace(team: Team, user: User | None, trace_id: str, timestamp_hint: datetime | None) -> LoadedTrace:@@ -424,3 +429,110 @@ def load_trace_root(team: Team, user: User | None, trace_id: str, timestamp_hintreturn TraceRootLookup(trace_event=_trace_node_row(results[0]), trace_found=True)# Most traces have no $ai_trace event, so the existence check reads light columns instead of a step's payload.return TraceRootLookup(trace_event=None, trace_found=bool(read("ai_trace_exists", _trace_exists_query)))+++METRIC_EVENT = "$ai_metric"+FEEDBACK_EVENT = "$ai_feedback"+FEEDBACK_EVENT_NAMES = (METRIC_EVENT, FEEDBACK_EVENT)+++@frozen+class FeedbackEventRow:+ uuid: str+ event: str+ timestamp: datetime+ parent_id: str | None+ span_id: str | None+ generation_id: str | None+ metric_name: str | None+ metric_value_json: str+ feedback_text_json: str+++_FEEDBACK_SELECTED: dict[str, ast.Expr] = {+ **{+ column: ast.Field(chain=[column])+ for column in ("uuid", "event", "timestamp", "parent_id", "span_id", "generation_id")+ },+ "metric_name": ast.Field(chain=["properties", "$ai_metric_name"]),+ # The raw JSON keeps the value's type, so a 0 or false score stays apart from a missing one.+ "metric_value_json": _raw_property("$ai_metric_value"),+ "feedback_text_json": _raw_property("$ai_feedback_text"),+}+++def _feedback_rows_query(selection: ast.Expr) -> ast.SelectQuery:+ return ast.SelectQuery(+ select=_select(_FEEDBACK_SELECTED),+ select_from=_ai_events(),+ where=ast.And(exprs=[selection, _filter_conditions()]),+ order_by=[ast.OrderExpr(expr=ast.Field(chain=["timestamp"]), order="ASC")],+ limit_by=ast.LimitByExpr(n=ast.Constant(value=1), exprs=[ast.Field(chain=["uuid"])]),+ limit=ast.Constant(value=MAX_TRACE_EVENTS),+ )+++def _feedback_event_row(values: Sequence[Any]) -> FeedbackEventRow:+ raw = dict(zip(_FEEDBACK_SELECTED, values))+ return FeedbackEventRow(+ uuid=str(raw["uuid"]),+ event=str(raw["event"]),+ timestamp=raw["timestamp"],+ parent_id=read_text(raw["parent_id"]),+ span_id=read_text(raw["span_id"]),+ generation_id=read_text(raw["generation_id"]),+ metric_name=read_text(raw["metric_name"]),+ metric_value_json=raw["metric_value_json"] or "",+ feedback_text_json=raw["feedback_text_json"] or "",+ )+++def _column_in(column: str, values: Sequence[str]) -> ast.Expr:+ return ast.CompareOperation(+ op=ast.CompareOperationOp.In,+ left=ast.Field(chain=[column]),+ right=ast.Tuple(exprs=[ast.Constant(value=value) for value in values]),+ )+++def _steps_named(node_ids: Sequence[str]) -> ast.Expr:+ uuids = [uuid for node_id in node_ids if (uuid := canonical_uuid(node_id))]+ return ast.Or(+ exprs=[+ _column_in("span_id", node_ids),+ _column_in("generation_id", node_ids),+ *([_column_in("uuid", uuids)] if uuids else []),+ ]+ )+++def load_trace_feedback_rows(+ team: Team, user: User | None, trace_id: str, timestamp_hint: datetime | None+) -> tuple[FeedbackEventRow, ...]:+ """The trace's feedback and metric events, then the steps their parent ids name, so each entry finds its target.++ Most traces have no feedback, so the steps are read only when an entry names one."""++ def read(name: str, selection: ast.Expr, event_names: Sequence[str]) -> list[FeedbackEventRow]:+ results = _read_trace(+ name,+ lambda: _feedback_rows_query(selection),+ team,+ user,+ trace_id,+ timestamp_hint,+ widen_unhinted=False,+ event_names=event_names,+ )+ return [_feedback_event_row(values) for values in results]++ feedback = read("ai_trace_feedback_rows", _event_in(FEEDBACK_EVENT_NAMES), FEEDBACK_EVENT_NAMES)+ parent_ids = sorted({row.parent_id for row in feedback if row.parent_id and row.parent_id != trace_id})+ if not parent_ids:+ return tuple(feedback)+ steps = read(+ "ai_trace_feedback_targets",+ ast.And(exprs=[_event_in(NODE_EVENT_NAMES), _steps_named(parent_ids)]),+ NODE_EVENT_NAMES,+ )+ return (*feedback, *steps)diff --git a/products/ai_observability/backend/logic/traces/tree.py b/products/ai_observability/backend/logic/traces/tree.pyindex 3ee87877e4b1..512616e49002 100644--- a/products/ai_observability/backend/logic/traces/tree.py+++ b/products/ai_observability/backend/logic/traces/tree.py@@ -40,7 +40,7 @@ class TreeNode:def build_tree(events: Sequence[TraceEvent], trace_id: str) -> tuple[TreeNode, ...]:- nodes = [event for event in events if not event.is_annotation and not event.is_trace_event]+ nodes = [event for event in events if not event.is_trace_event]known_keys = {event.node_key for event in nodes}def order(event: TraceEvent) -> tuple[datetime, float]:diff --git a/products/ai_observability/backend/presentation/views.py b/products/ai_observability/backend/presentation/views.pyindex db97ee0238b2..e201a2219360 100644--- a/products/ai_observability/backend/presentation/views.py+++ b/products/ai_observability/backend/presentation/views.py@@ -62,7 +62,7 @@ class TraceSummaryRequestSerializer(serializers.Serializer):class TraceViewSet(TeamAndOrgViewSetMixin, viewsets.ViewSet):scope_object = "llm_analytics"- scope_object_read_actions = ["retrieve", "node", "evaluations", "summary"]+ scope_object_read_actions = ["retrieve", "node", "evaluations", "feedback", "summary"]scope_object_write_actions = ["request_summary"]# Traces are project-wide data, so a grant on a single llm_analytics object must not open them.requires_resource_level_access = True@@ -144,6 +144,26 @@ class TraceViewSet(TeamAndOrgViewSetMixin, viewsets.ViewSet):results = self._read(request, lambda user, _hint: api.get_trace_evaluation_results(self.team, user, trace_id))return Response(results.model_dump(mode="json", by_alias=True))+ @validated_request(+ query_serializer=TraceQuerySerializer,+ parameters=[TRACE_ID_PARAMETER],+ responses={+ 200: OpenApiResponse(response=contracts.TraceFeedback),+ 400: OpenApiResponse(description="The timestamp hint or the encoded trace id is malformed."),+ 429: THROTTLED_RESPONSE,+ },+ operation_id="ai_observability_traces_feedback_retrieve",+ )+ @action(detail=True, methods=["GET"], url_path="feedback")+ def feedback(self, request: ValidatedRequest, pk: str, **kwargs: Any) -> Response:+ """End-user feedback on a trace: the scores and the comments its feedback events carry, each with the step it targets."""+ try:+ trace_id = decode_trace_id_segment(pk)+ except MalformedTraceIdSegmentError:+ return Response({"detail": "Malformed encoded trace id."}, status=status.HTTP_400_BAD_REQUEST)+ feedback = self._read(request, lambda user, hint: api.get_trace_feedback(self.team, user, trace_id, hint))+ return Response(feedback.model_dump(mode="json", by_alias=True))+def get_throttles(self) -> list[BaseThrottle]:# Shares the legacy summary endpoint's scopes, so a user has one summarization budget. Reads poll, so only# requests spend it.diff --git a/products/ai_observability/backend/tests/logic/traces/rows.py b/products/ai_observability/backend/tests/logic/traces/rows.pyindex e90e9bf3fd01..dd898bd3e335 100644--- a/products/ai_observability/backend/tests/logic/traces/rows.py+++ b/products/ai_observability/backend/tests/logic/traces/rows.py@@ -5,7 +5,7 @@ from typing import Anyfrom posthog.models import Teamfrom products.ai_observability.backend.logic.traces.evaluation_result_queries import EvaluationResultRow-from products.ai_observability.backend.logic.traces.trace_queries import TraceEventRow+from products.ai_observability.backend.logic.traces.trace_queries import FeedbackEventRow, TraceEventRowT0 = datetime(2026, 9, 1, 10, 0, 0, tzinfo=UTC)EVALUATION_ID = "0192f2a4-5c1e-7000-8000-000000000e01"@@ -40,6 +40,21 @@ def make_row(**overrides: Any) -> TraceEventRow:return TraceEventRow(**{**fields, **overrides})+def make_feedback_row(**overrides: Any) -> FeedbackEventRow:+ fields: dict[str, Any] = {+ "uuid": "event-1",+ "event": "$ai_metric",+ "timestamp": T0,+ "parent_id": None,+ "span_id": None,+ "generation_id": None,+ "metric_name": None,+ "metric_value_json": "",+ "feedback_text_json": "",+ }+ return FeedbackEventRow(**{**fields, **overrides})++def make_evaluation_result_row(**overrides: Any) -> EvaluationResultRow:fields: dict[str, Any] = {"uuid": "result-1",diff --git a/products/ai_observability/backend/tests/logic/traces/test_feedback.py b/products/ai_observability/backend/tests/logic/traces/test_feedback.pynew file mode 100644index 000000000000..1f91a9cb9809--- /dev/null+++ b/products/ai_observability/backend/tests/logic/traces/test_feedback.py@@ -0,0 +1,70 @@+from datetime import timedelta++from parameterized import parameterized++from products.ai_observability.backend.logic.traces.feedback import TraceFeedback, present_value++from .rows import T0, make_feedback_row++STEPS = [+ make_feedback_row(uuid="e0", event="$ai_span", span_id="span-a"),+ make_feedback_row(uuid="e1", event="$ai_generation", generation_id="gen-a", span_id="span-b"),+]+++ [+ ("zero", "0", "0"),+ ("false", "false", "false"),+ ("a number", "4.5", "4.5"),+ ("a string", '"helpful"', "helpful"),+ ("a string that reads zero", '"0"', "0"),+ ("an object", '{"a": 1}', '{"a":1}'),+ ("a missing key", "", None),+ ("null", "null", None),+ ("an empty string", '""', None),+ ]+)+def test_present_value(_name: str, raw: str, expected: str | None) -> None:+ assert present_value(raw) == expected+++def test_orders_entries_and_drops_empty_ones() -> None:+ rows = [+ make_feedback_row(+ uuid="m2", metric_name="resolved", metric_value_json="false", timestamp=T0 + timedelta(minutes=1)+ ),+ make_feedback_row(uuid="m1", metric_name="helpfulness", metric_value_json="0", timestamp=T0),+ make_feedback_row(uuid="m3", metric_name="tone", metric_value_json='""', timestamp=T0 + timedelta(minutes=2)),+ make_feedback_row(uuid="f1", event="$ai_feedback", feedback_text_json='""'),+ ]++ feedback = TraceFeedback("trace-1", rows)++ assert [(score.name, score.value) for score in feedback.scores] == [("helpfulness", "0"), ("resolved", "false")]+ assert feedback.texts == ()+++ [+ ("the step's event uuid", "e1", "e1"),+ ("the step's generation id", "gen-a", "e1"),+ ("the trace id", "trace-1", "trace-1"),+ ("an id no step carries", "trace-event-span", "trace-1"),+ ("no parent", None, "trace-1"),+ ]+)+def test_entry_targets(_name: str, parent_id: str | None, node_id: str) -> None:+ feedback = TraceFeedback(+ "trace-1",+ [+ *STEPS,+ make_feedback_row(uuid="m1", parent_id=parent_id, metric_name="helpfulness", metric_value_json="4"),+ make_feedback_row(+ uuid="f1", event="$ai_feedback", parent_id=parent_id, feedback_text_json='"Too long, but correct."'+ ),+ ],+ )++ assert [score.node_id for score in feedback.scores] == [node_id]+ assert [(text.text, text.node_id) for text in feedback.texts] == [("Too long, but correct.", node_id)]diff --git a/products/ai_observability/backend/tests/logic/traces/test_node_ids.py b/products/ai_observability/backend/tests/logic/traces/test_node_ids.pynew file mode 100644index 000000000000..91d4cfada858--- /dev/null+++ b/products/ai_observability/backend/tests/logic/traces/test_node_ids.py@@ -0,0 +1,22 @@+from parameterized import parameterized++from products.ai_observability.backend.logic.traces.node_ids import NodeIdResolver, NodeIds+++ [+ ("an event uuid", "e1", "e1"),+ ("a generation id", "gen-a", "e1"),+ ("a span id", "span-a", "e0"),+ ("an unknown id", "nope", None),+ ]+)+def test_resolve(_name: str, node_id: str, expected: str | None) -> None:+ resolver = NodeIdResolver(+ [+ NodeIds(uuid="e0", generation_id=None, span_id="span-a"),+ NodeIds(uuid="e1", generation_id="gen-a", span_id="span-b"),+ ]+ )++ assert resolver.resolve(node_id) == expecteddiff --git a/products/ai_observability/backend/tests/logic/traces/test_trace.py b/products/ai_observability/backend/tests/logic/traces/test_trace.pyindex d84faca6c538..88402b9d6103 100644--- a/products/ai_observability/backend/tests/logic/traces/test_trace.py+++ b/products/ai_observability/backend/tests/logic/traces/test_trace.py@@ -115,7 +115,7 @@ def test_person_label(_name: str, person: PersonRow | None, expected: str | None],"e0",),- ("a trace without nodes falls back to the root", [{"event": "$ai_feedback"}], "trace-1"),+ ("a trace without nodes falls back to the root", [], "trace-1"),])def test_default_node_id(_name: str, rows: list[dict[str, Any]], expected: str) -> None:@@ -128,7 +128,6 @@ def test_node_ids_by_alias_map_sdk_ids_of_tree_nodes_to_their_uuids() -> None:{"event": "$ai_generation", "generation_id": "gen-a", "parent_id": "span-a"},{"event": "$ai_generation", "generation_id": "gen-a"},{"event": "$ai_span", "span_id": "e3"},- {"event": "$ai_feedback", "span_id": "feedback-a"},{"event": "$ai_trace", "span_id": "trace-a"},).node_ids_by_aliasdiff --git a/products/ai_observability/backend/tests/logic/traces/test_trace_queries.py b/products/ai_observability/backend/tests/logic/traces/test_trace_queries.pyindex f4e16b4d69ea..bf35f47a69c4 100644--- a/products/ai_observability/backend/tests/logic/traces/test_trace_queries.py+++ b/products/ai_observability/backend/tests/logic/traces/test_trace_queries.py@@ -15,6 +15,7 @@ from products.ai_observability.backend.logic.traces.trace_queries import (TraceRootLookup,is_truthy_json,load_trace,+ load_trace_feedback_rows,load_trace_node,load_trace_root,)@@ -147,6 +148,85 @@ class TestLoadTrace(TraceEventsMixin, ClickhouseTestMixin, BaseTest):assert person is not None and (person.distinct_id, person.email) == ("user-1", "[email protected]")+ def test_reads_no_feedback_or_metric_events(self) -> None:+ bulk_create_ai_events(+ [+ self._event(+ "00000000-0000-0000-0000-000000000001",+ event="$ai_feedback",+ timestamp=T0 - timedelta(seconds=1),+ properties={"$ai_feedback_text": "Too long, but correct."},+ ),+ self._event(+ "00000000-0000-0000-0000-000000000002",+ event="$ai_metric",+ properties={"$ai_metric_name": "helpfulness", "$ai_metric_value": 0},+ ),+ self._event("00000000-0000-0000-0000-000000000003", timestamp=T0 + timedelta(seconds=1)),+ ]+ )++ rows = load_trace(self.team, None, "trace-1", None).rows++ assert [row.event for row in rows] == ["$ai_span"]+++class TestLoadTraceFeedbackRows(TraceEventsMixin, ClickhouseTestMixin, BaseTest):+ def test_reads_feedback_of_this_trace_and_only_the_steps_it_targets(self) -> None:+ self._ingest(+ "00000000-0000-0000-0000-000000000001",+ {"$ai_metric_name": "helpfulness", "$ai_metric_value": 0, "$ai_parent_id": "span-a"},+ event="$ai_metric",+ )+ self._ingest(+ "00000000-0000-0000-0000-000000000002",+ {"$ai_metric_name": "helpfulness", "$ai_metric_value": "0", "$ai_parent_id": "gen-a"},+ event="$ai_metric",+ )+ self._ingest(+ "00000000-0000-0000-0000-000000000003",+ {"$ai_feedback_text": "Too long, but correct."},+ event="$ai_feedback",+ )+ self._ingest("00000000-0000-0000-0000-000000000004", {"$ai_generation_id": "gen-a"}, event="$ai_generation")+ self._ingest("00000000-0000-0000-0000-000000000005", {}, event="$ai_trace")+ self._ingest("00000000-0000-0000-0000-000000000007", {"$ai_span_id": "span-a"})+ self._ingest("00000000-0000-0000-0000-000000000010", {"$ai_span_id": "span-untargeted"})+ self._ingest(+ "00000000-0000-0000-0000-000000000008",+ {"$ai_metric_value": 2, "$ai_parent_id": "00000000-0000-0000-0000-000000000009"},+ event="$ai_metric",+ )+ self._ingest("00000000-0000-0000-0000-000000000009", {})+ self._ingest(+ "00000000-0000-0000-0000-000000000006",+ {"$ai_trace_id": "other", "$ai_metric_value": 1},+ event="$ai_metric",+ )++ rows = load_trace_feedback_rows(self.team, None, "trace-1", None)++ assert sorted(+ (row.uuid, row.event, row.parent_id, row.generation_id, row.metric_name, row.metric_value_json)+ for row in rows+ ) == [+ ("00000000-0000-0000-0000-000000000001", "$ai_metric", "span-a", None, "helpfulness", "0"),+ ("00000000-0000-0000-0000-000000000002", "$ai_metric", "gen-a", None, "helpfulness", '"0"'),+ ("00000000-0000-0000-0000-000000000003", "$ai_feedback", None, None, None, ""),+ ("00000000-0000-0000-0000-000000000004", "$ai_generation", None, "gen-a", None, ""),+ ("00000000-0000-0000-0000-000000000007", "$ai_span", None, None, None, ""),+ (+ "00000000-0000-0000-0000-000000000008",+ "$ai_metric",+ "00000000-0000-0000-0000-000000000009",+ None,+ None,+ "2",+ ),+ ("00000000-0000-0000-0000-000000000009", "$ai_span", None, None, None, ""),+ ]+ assert [row.feedback_text_json for row in rows if row.event == "$ai_feedback"] == ['"Too long, but correct."']+NODE = "00000000-0000-0000-0000-000000000001"TRACE_EVENT = "00000000-0000-0000-0000-000000000002"@@ -270,6 +350,22 @@ class TestEventsFallback(TraceEventsMixin, ClickhouseTestMixin, BaseTest):assert row is not None and row.properties["$ai_span_name"] == "old"assert root.trace_event is not None and root.trace_event.uuid == TRACE_EVENT+ @parameterized.expand([("with a hint", T0, 1), ("without a hint", None, 0)])+ def test_feedback_falls_back_to_events_only_with_a_hint(+ self, _name: str, timestamp_hint: datetime | None, expected: int+ ) -> None:+ bulk_create_events(+ [+ self._event(+ NODE, event="$ai_metric", properties={"$ai_metric_name": "helpfulness", "$ai_metric_value": 0}+ )+ ]+ )++ rows = load_trace_feedback_rows(self.team, None, "trace-1", timestamp_hint)++ assert [(row.metric_name, row.metric_value_json) for row in rows] == [("helpfulness", "0")] * expected+def test_node_and_root_without_a_hint_never_scan_events(self) -> None:bulk_create_events([self._event(NODE), self._event(TRACE_EVENT, event="$ai_trace")])diff --git a/products/ai_observability/backend/tests/logic/traces/test_tree.py b/products/ai_observability/backend/tests/logic/traces/test_tree.pyindex df79a0e26925..08921865fa40 100644--- a/products/ai_observability/backend/tests/logic/traces/test_tree.py+++ b/products/ai_observability/backend/tests/logic/traces/test_tree.py@@ -44,12 +44,10 @@ def test_promotes_orphans_to_roots_including_children_of_the_trace_event_span()assert shape(tree) == [("orphan", [("grandchild", [])])]-def test_excludes_feedback_metric_and_trace_events() -> None:+def test_excludes_the_trace_event() -> None:tree = build_tree(events({"uuid": "span"},- {"uuid": "feedback", "event": "$ai_feedback"},- {"uuid": "metric", "event": "$ai_metric"},{"uuid": "trace-event", "event": "$ai_trace", "parent_id": None},),"trace-1",diff --git a/products/ai_observability/backend/tests/test_trace_views.py b/products/ai_observability/backend/tests/test_trace_views.pyindex cd73af7546e2..57fcbd2059da 100644--- a/products/ai_observability/backend/tests/test_trace_views.py+++ b/products/ai_observability/backend/tests/test_trace_views.py@@ -30,6 +30,8 @@ T0 = datetime(2026, 9, 1, 10, 0, tzinfo=UTC)GENERATION = "00000000-0000-0000-0000-000000000001"TRACE_EVENT = "00000000-0000-0000-0000-000000000002"EVALUATION_RESULT = "00000000-0000-0000-0000-000000000003"+SCORE = "00000000-0000-0000-0000-000000000004"+FEEDBACK = "00000000-0000-0000-0000-000000000005"QUESTION = [{"role": "user", "content": "Why did my invoice go up?"}]ANSWER = [{"role": "assistant", "content": "Two seats were added."}]@@ -339,6 +341,83 @@ class TestTraceEvaluationsView(ClickhouseTestMixin, APIBaseTest):assert (result["reasoning"], result["outcome"]) == (None, "pass")+def _create_feedback(team: Team) -> None:+ def event(uuid: str, name: str, properties: dict[str, object]) -> dict[str, object]:+ return {+ "event": name,+ "event_uuid": uuid,+ "distinct_id": "user-1",+ "team": team,+ "timestamp": T0 + timedelta(minutes=1),+ "properties": {"$ai_trace_id": "trace-1", **properties},+ }++ _create_trace(team)+ bulk_create_ai_events(+ [+ event(+ SCORE,+ "$ai_metric",+ {"$ai_metric_name": "helpfulness", "$ai_metric_value": 0, "$ai_parent_id": GENERATION},+ ),+ event(FEEDBACK, "$ai_feedback", {"$ai_feedback_text": "Too long, but correct."}),+ ]+ )+++class TestTraceFeedbackView(ClickhouseTestMixin, APIBaseTest):+ def _url(self, segment: str) -> str:+ return f"/api/projects/{self.team.id}/ai_observability/traces/{segment}/feedback/"++ def test_returns_the_feedback_in_camel_case(self) -> None:+ _create_feedback(self.team)++ response = self.client.get(self._url(_encode("trace-1")))++ assert response.status_code == 200+ body = response.json()+ assert [score | {"timestamp": None} for score in body["scores"]] == [+ {"id": SCORE, "name": "helpfulness", "value": "0", "nodeId": GENERATION, "timestamp": None}+ ]+ assert [(item["kind"], item["text"], item["nodeId"]) for item in body["responses"]] == [+ ("text", "Too long, but correct.", "trace-1")+ ]+ assert body["summary"]["total"] == 2++ def test_an_unknown_trace_has_no_feedback(self) -> None:+ response = self.client.get(self._url(_encode("trace-2")))++ assert response.status_code == 200+ assert (response.json()["scores"], response.json()["responses"], response.json()["summary"]["total"]) == (+ [],+ [],+ 0,+ )++ def test_rejects_an_unencoded_trace_id(self) -> None:+ assert self.client.get(self._url("trace-1")).status_code == 400++ def test_masks_feedback_the_viewer_may_not_read(self) -> None:+ self.organization.available_product_features = [+ {"key": AvailableFeature.PROPERTY_ACCESS_CONTROL, "name": AvailableFeature.PROPERTY_ACCESS_CONTROL}+ ]+ self.organization.save()+ definition = PropertyDefinition.objects.create(+ team=self.team, name="$ai_feedback_text", property_type="String", type=PropertyDefinition.Type.EVENT+ )+ PropertyAccessControl.objects.create(+ team=self.team,+ property_definition=definition,+ organization_member=self.organization_membership,+ access_level=PropertyAccessLevel.NONE.value,+ )+ _create_feedback(self.team)++ body = self.client.get(self._url(_encode("trace-1"))).json()++ assert (len(body["scores"]), body["responses"]) == (1, [])++class TestTraceViewSetResourceLevelAccess(ClickhouseTestMixin, APIBaseTest):def test_a_grant_on_one_object_does_not_open_traces(self) -> None:self.organization.available_product_features = [diff --git a/products/ai_observability/frontend/generated/api.schemas.ts b/products/ai_observability/frontend/generated/api.schemas.tsindex 5b02e6e5f5be..3d3ad96b2d8c 100644--- a/products/ai_observability/frontend/generated/api.schemas.ts+++ b/products/ai_observability/frontend/generated/api.schemas.ts@@ -1490,6 +1490,38 @@ export interface TraceEvaluationResultsApi {summary: TraceEvaluationSummaryApi}+export interface TraceFeedbackScoreApi {+ id: string+ name: string | null+ /** The score as text: a string as sent, any other value as compact JSON, such as 0, false or 4.5. */+ value: string+ /** The tree node the score targets: the step's event uuid, or the trace id for a trace-level score. */+ nodeId: string+ timestamp: string+}++export interface TraceFeedbackTextApi {+ kind: 'text'+ id: string+ text: string+ /** The tree node the feedback targets: the step's event uuid, or the trace id for trace-level feedback. */+ nodeId: string+ timestamp: string+}++export interface TraceFeedbackSummaryApi {+ /** Scores plus responses. */+ total: number+}++export interface TraceFeedbackApi {+ /** Oldest first. */+ scores: TraceFeedbackScoreApi[]+ /** What users said, oldest first. */+ responses: TraceFeedbackTextApi[]+ summary: TraceFeedbackSummaryApi+}+export interface TraceNodeMetadataApi {provider: string | nulltemperature: number | null@@ -5571,6 +5603,13 @@ export type AiObservabilityTracesRetrieveParams = {timestamp_hint?: string}+export type AiObservabilityTracesFeedbackRetrieveParams = {+ /**+ * When the trace happened, as carried by links into it. Lets a trace older than the AI events retention load from the shared events table.+ */+ timestamp_hint?: string+}+export type AiObservabilityTracesNodesRetrieveParams = {/*** When the trace happened, as carried by links into it. Lets a trace older than the AI events retention load from the shared events table.diff --git a/products/ai_observability/frontend/generated/api.ts b/products/ai_observability/frontend/generated/api.tsindex 29d70a5d6436..7d350ef52549 100644--- a/products/ai_observability/frontend/generated/api.ts+++ b/products/ai_observability/frontend/generated/api.ts@@ -16,6 +16,7 @@ import type {AiObservabilityOfflineExperimentsResultCellsRetrieveParams,AiObservabilityOfflineExperimentsScorerSummariesListParams,AiObservabilityOfflineScorersHistoryListParams,+ AiObservabilityTracesFeedbackRetrieveParams,AiObservabilityTracesNodesRetrieveParams,AiObservabilityTracesRetrieveParams,AiObservabilityTracesSummaryCreateParams,@@ -151,6 +152,7 @@ import type {TextReprResponseApi,TraceApi,TraceEvaluationResultsApi,+ TraceFeedbackApi,TraceNodeDetailApi,TraceReviewApi,TraceReviewCreateApi,@@ -704,6 +706,41 @@ export const aiObservabilityTracesEvaluationsRetrieve = async (})}+export const getAiObservabilityTracesFeedbackRetrieveUrl = (+ projectId: string,+ id: string,+ params?: AiObservabilityTracesFeedbackRetrieveParams+) => {+ const normalizedParams = new URLSearchParams()++ Object.entries(params || {}).forEach(([key, value]) => {+ if (value !== undefined) {+ normalizedParams.append(key, value === null ? 'null' : String(value))+ }+ })++ const stringifiedParams = normalizedParams.toString()++ return stringifiedParams.length > 0+ ? `/api/projects/${projectId}/ai_observability/traces/${id}/feedback/?${stringifiedParams}`+ : `/api/projects/${projectId}/ai_observability/traces/${id}/feedback/`+}++/**+ * End-user feedback on a trace: the scores and the comments its feedback events carry, each with the step it targets.+ */+export const aiObservabilityTracesFeedbackRetrieve = async (+ projectId: string,+ id: string,+ params?: AiObservabilityTracesFeedbackRetrieveParams,+ options?: RequestInit+): Promise<TraceFeedbackApi> => {+ return apiMutator<TraceFeedbackApi>(getAiObservabilityTracesFeedbackRetrieveUrl(projectId, id, params), {+ ...options,+ method: 'GET',+ })+}+export const getAiObservabilityTracesNodesRetrieveUrl = (projectId: string,id: string,diff --git a/products/ai_observability/frontend/redesign/trace/TraceScene.tsx b/products/ai_observability/frontend/redesign/trace/TraceScene.tsxindex ccd4973e7348..bb68da99c55b 100644--- a/products/ai_observability/frontend/redesign/trace/TraceScene.tsx+++ b/products/ai_observability/frontend/redesign/trace/TraceScene.tsx@@ -4,7 +4,7 @@ import { aiObservabilityTraceLogic } from '../../aiObservabilityTraceLogic'import { SaveToDatasetButton } from '../../datasets/SaveToDatasetButton'import { traceViewAdapterLogic, traceViewAdapterLogicValues } from './adapter/traceViewAdapterLogic'import { TraceView, TraceViewProps, TraceViewReadyProps } from './components/TraceView'-import { NodeDetailTab, SummaryItemKind, TraceMode } from './types'+import { FeedbackEntry, NodeDetailTab, SummaryItemKind, TraceMode } from './types'type ReadyValues = Pick<traceViewAdapterLogicValues,@@ -26,6 +26,11 @@ type ReadyValues = Pick<| 'summaryRequesting'| 'summaryRequestError'| 'summaryConsentGiven'+ | 'feedbackChip'+ | 'feedbackCount'+ | 'feedbackCountByNodeId'+ | 'feedbackMode'+ | 'selectedStepFeedback'>interface ReadyActions {@@ -40,6 +45,8 @@ interface ReadyActions {regenerateSummary: () => voidloadSummary: () => voidsummaryStepClicked: (nodeId: string, kind: SummaryItemKind) => void+ showFeedback: (nodeId: string | null, entry: FeedbackEntry) => void+ retryTraceFeedback: () => void}function toReadyProps(values: ReadyValues, actions: ReadyActions): TraceViewReadyProps | null {@@ -51,6 +58,9 @@ function toReadyProps(values: ReadyValues, actions: ReadyActions): TraceViewReadsummary: {...values.summary,evals: values.evalsChip ? { chip: values.evalsChip, onClick: actions.showFailingEvals } : null,+ feedback: values.feedbackChip+ ? { chip: values.feedbackChip, onClick: () => actions.showFeedback(null, 'chip') }+ : null,git: values.gitBranch,},mode: values.mode,@@ -67,6 +77,12 @@ function toReadyProps(values: ReadyValues, actions: ReadyActions): TraceViewReadonTabChange: actions.setDetailTab,onViewInThread: values.canViewInThread ? actions.viewInThread : null,actions: values.datasetItemSource ? <SaveToDatasetButton {...values.datasetItemSource} /> : null,+ stepFeedback: values.selectedStepFeedback+ ? {+ feedback: values.selectedStepFeedback,+ onOpen: () => actions.showFeedback(values.selectedNodeId, 'step'),+ }+ : null,}: null,thread: values.thread,@@ -82,6 +98,10 @@ function toReadyProps(values: ReadyValues, actions: ReadyActions): TraceViewReadonReload: actions.loadSummary,onSelectStep: actions.summaryStepClicked,},+ feedbackMode: values.feedbackMode,+ onRetryFeedback: actions.retryTraceFeedback,+ feedbackCount: values.feedbackCount,+ feedbackCountByNodeId: values.feedbackCountByNodeId,}}@@ -111,6 +131,11 @@ export function TraceScene(): JSX.Element {summaryRequesting,summaryRequestError,summaryConsentGiven,+ feedbackChip,+ feedbackCount,+ feedbackCountByNodeId,+ feedbackMode,+ selectedStepFeedback,} = useValues(logic)const actions = useActions(logic)@@ -136,6 +161,11 @@ export function TraceScene(): JSX.Element {summaryRequesting,summaryRequestError,summaryConsentGiven,+ feedbackChip,+ feedbackCount,+ feedbackCountByNodeId,+ feedbackMode,+ selectedStepFeedback,},actions)diff --git a/products/ai_observability/frontend/redesign/trace/adapter/testFixtures.ts b/products/ai_observability/frontend/redesign/trace/adapter/testFixtures.tsindex a58568c5470e..1355a4147337 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/testFixtures.ts+++ b/products/ai_observability/frontend/redesign/trace/adapter/testFixtures.ts@@ -4,6 +4,9 @@ import type {TraceApi,TraceEvaluationResultApi,TraceEvaluationResultsApi,+ TraceFeedbackApi,+ TraceFeedbackScoreApi,+ TraceFeedbackTextApi,TraceNodeApi,TraceNodeDetailApi,TraceNodeIOKeysApi,@@ -143,6 +146,34 @@ export function makeEvaluationResult(overrides: Partial<TraceEvaluationResultApi}}+export function makeFeedbackScore(overrides: Partial<TraceFeedbackScoreApi> = {}): TraceFeedbackScoreApi {+ return {+ id: 'score-1',+ name: 'helpfulness',+ value: '0',+ nodeId: 'gen-1',+ timestamp: '2026-09-01T10:16:00Z',+ ...overrides,+ }+}++export function makeFeedbackText(overrides: Partial<TraceFeedbackTextApi> = {}): TraceFeedbackTextApi {+ return {+ kind: 'text',+ id: 'text-1',+ text: 'Too long, but correct.',+ nodeId: 'trace-1',+ timestamp: '2026-09-01T10:17:00Z',+ ...overrides,+ }+}++export function makeFeedback(overrides: Partial<TraceFeedbackApi> = {}): TraceFeedbackApi {+ const scores = overrides.scores ?? [makeFeedbackScore()]+ const responses = overrides.responses ?? [makeFeedbackText()]+ return { scores, responses, summary: { total: scores.length + responses.length }, ...overrides }+}+export function makeEvaluationResults(overrides: Partial<TraceEvaluationResultsApi> = {}): TraceEvaluationResultsApi {return { results: [], summary: { passed: 0, failed: 0, unrated: 0, nodes: [] }, ...overrides }}diff --git a/products/ai_observability/frontend/redesign/trace/adapter/toEvalResults.ts b/products/ai_observability/frontend/redesign/trace/adapter/toEvalResults.tsindex f30ddb6c6280..1aa2f8157b90 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/toEvalResults.ts+++ b/products/ai_observability/frontend/redesign/trace/adapter/toEvalResults.ts@@ -2,7 +2,7 @@ import { urls } from 'scenes/urls'import type { TraceEvaluationResultApi, TraceNodeApi } from '../../../generated/api.schemas'import { EvalResult, EvalTarget } from '../types'-import { flattenTree } from './toTraceTree'+import { nodeLabels } from './toTraceTree'export interface EvalResultsContext {/** Every node of the trace, root first, to name what each result targets. */@@ -10,21 +10,6 @@ export interface EvalResultsContext {viewedNodeId: string}-// Two steps can share a name, such as two calls to the same model, so repeated names get their position.-function nodeLabels(tree: TraceNodeApi[]): Map<string, string> {- const nodes = flattenTree(tree)- const totals = new Map<string, number>()- nodes.forEach((node) => totals.set(node.name, (totals.get(node.name) ?? 0) + 1))- const seen = new Map<string, number>()- return new Map(- nodes.map((node) => {- const position = (seen.get(node.name) ?? 0) + 1- seen.set(node.name, position)- return [node.id, (totals.get(node.name) ?? 0) > 1 ? `${node.name} #${position}` : node.name]- })- )-}-function targetOf(result: TraceEvaluationResultApi,labels: Map<string, string>,diff --git a/products/ai_observability/frontend/redesign/trace/adapter/toFeedback.test.ts b/products/ai_observability/frontend/redesign/trace/adapter/toFeedback.test.tsnew file mode 100644index 000000000000..39af5593b0f6--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/adapter/toFeedback.test.ts@@ -0,0 +1,67 @@+import { makeFeedback, makeFeedbackScore, makeFeedbackText, makeTraceResource } from './testFixtures'+import { stepFeedbackOf, toFeedbackChip, toFeedbackMode, toStepFeedback } from './toFeedback'++describe('toFeedback', () => {+ test.each([+ ['some', 3, { total: 3 }],+ ['none', 0, null],+ ])('toFeedbackChip with %s feedback', (_name, total, expected) => {+ expect(toFeedbackChip({ total })).toEqual(expected)+ })++ test.each(['trace-1', 'constructor', '__proto__'])(+ 'toStepFeedback puts each entry on its step and trace-level entries on the root %s',+ (traceId) => {+ const score = makeFeedbackScore({ nodeId: 'gen-1' })+ const traceScore = makeFeedbackScore({ id: 'score-2', nodeId: traceId })+ const feedback = makeFeedback({+ scores: [score, traceScore],+ responses: [makeFeedbackText({ nodeId: 'gen-1' }), makeFeedbackText({ id: 'text-2', nodeId: traceId })],+ })++ expect({ ...toStepFeedback(feedback) }).toEqual({+ 'gen-1': { scores: [score], textCount: 1 },+ [traceId]: { scores: [traceScore], textCount: 1 },+ })+ }+ )++ test.each(['trace-1', 'constructor', '__proto__'])(+ 'stepFeedbackOf finds the root %s only when it has feedback',+ (traceId) => {+ const traceScore = makeFeedbackScore({ nodeId: traceId })+ const withFeedback = toStepFeedback(makeFeedback({ scores: [traceScore], responses: [] }))++ expect(stepFeedbackOf({}, traceId)).toBeNull()+ expect(stepFeedbackOf(withFeedback, traceId)).toEqual({ scores: [traceScore], textCount: 0 })+ }+ )++ test('toFeedbackMode names each step and keeps the root and an unknown step as trace-level', () => {+ const feedback = makeFeedback({+ scores: [makeFeedbackScore({ nodeId: 'gen-1' }), makeFeedbackScore({ id: 'score-2', nodeId: 'gone' })],+ responses: [makeFeedbackText({ nodeId: 'trace-1' })],+ })++ const mode = toFeedbackMode({ feedback, tree: makeTraceResource().tree, traceId: 'trace-1', focusNodeId: null })++ expect(mode.scores.map((row) => row.step)).toEqual([{ id: 'gen-1', name: 'gen-1' }, null])+ expect(mode.responses.map((item) => item.step)).toEqual([null])+ })++ test.each([+ ['a step', 'gen-1', [true, false], [false]],+ ['the root, which holds the trace-level entries', 'trace-1', [false, true], [true]],+ ['nothing', null, [false, false], [false]],+ ])('toFeedbackMode focuses the entries of %s', (_name, focusNodeId, scoresFocused, responsesFocused) => {+ const feedback = makeFeedback({+ scores: [makeFeedbackScore({ nodeId: 'gen-1' }), makeFeedbackScore({ id: 'score-2', nodeId: 'trace-1' })],+ responses: [makeFeedbackText({ nodeId: 'trace-1' })],+ })++ const mode = toFeedbackMode({ feedback, tree: makeTraceResource().tree, traceId: 'trace-1', focusNodeId })++ expect(mode.scores.map((row) => row.focused)).toEqual(scoresFocused)+ expect(mode.responses.map((item) => item.focused)).toEqual(responsesFocused)+ })+})diff --git a/products/ai_observability/frontend/redesign/trace/adapter/toFeedback.ts b/products/ai_observability/frontend/redesign/trace/adapter/toFeedback.tsnew file mode 100644index 000000000000..cc7c8ef2e426--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/adapter/toFeedback.ts@@ -0,0 +1,54 @@+import type { TraceFeedbackApi, TraceFeedbackSummaryApi, TraceNodeApi } from '../../../generated/api.schemas'+import { FeedbackChipData, FeedbackModeState, FeedbackPlacement, StepFeedback } from '../types'+import { nodeLabels } from './toTraceTree'++export function toFeedbackChip(summary: TraceFeedbackSummaryApi): FeedbackChipData | null {+ return summary.total > 0 ? { total: summary.total } : null+}++/** Trace-level entries sit on the root, whose id is the trace id. */+export function toStepFeedback(feedback: TraceFeedbackApi): Record<string, StepFeedback> {+ // The root's key is the trace id, which is free-form, so a prototype key such as `constructor` must not resolve.+ const byStep: Record<string, StepFeedback> = Object.create(null)+ const entry = (nodeId: string): StepFeedback => (byStep[nodeId] ??= { scores: [], textCount: 0 })+ for (const score of feedback.scores) {+ entry(score.nodeId).scores.push(score)+ }+ for (const response of feedback.responses) {+ entry(response.nodeId).textCount += 1+ }+ return byStep+}++export function stepFeedbackOf(stepFeedback: Record<string, StepFeedback>, nodeId: string): StepFeedback | null {+ return Object.hasOwn(stepFeedback, nodeId) ? stepFeedback[nodeId] : null+}++export interface FeedbackModeArgs {+ feedback: TraceFeedbackApi+ tree: TraceNodeApi[]+ traceId: string+ /** The step the mode was opened from, the trace id for the root. */+ focusNodeId: string | null+}++export function toFeedbackMode({+ feedback,+ tree,+ traceId,+ focusNodeId,+}: FeedbackModeArgs): Extract<FeedbackModeState, { status: 'ready' }> {+ const labels = nodeLabels(tree)+ const placement = (nodeId: string): FeedbackPlacement => {+ const name = nodeId !== traceId ? labels.get(nodeId) : undefined+ return {+ step: name !== undefined ? { id: nodeId, name } : null,+ focused: nodeId === focusNodeId,+ }+ }+ return {+ status: 'ready',+ scores: feedback.scores.map((score) => ({ ...score, ...placement(score.nodeId) })),+ responses: feedback.responses.map((response) => ({ ...response, ...placement(response.nodeId) })),+ }+}diff --git a/products/ai_observability/frontend/redesign/trace/adapter/toTraceTree.ts b/products/ai_observability/frontend/redesign/trace/adapter/toTraceTree.tsindex 46a959bcec69..48f5b4c35763 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/toTraceTree.ts+++ b/products/ai_observability/frontend/redesign/trace/adapter/toTraceTree.ts@@ -17,3 +17,18 @@ export function findTreeNode(nodes: TraceNodeApi[], id: string): TraceNodeApi |export function flattenTree(nodes: TraceNodeApi[]): TraceNodeApi[] {return nodes.flatMap((node) => [node, ...flattenTree(node.children)])}++// Two steps can share a name, such as two calls to the same model, so repeated names get their position.+export function nodeLabels(tree: TraceNodeApi[]): Map<string, string> {+ const nodes = flattenTree(tree)+ const totals = new Map<string, number>()+ nodes.forEach((node) => totals.set(node.name, (totals.get(node.name) ?? 0) + 1))+ const seen = new Map<string, number>()+ return new Map(+ nodes.map((node) => {+ const position = (seen.get(node.name) ?? 0) + 1+ seen.set(node.name, position)+ return [node.id, (totals.get(node.name) ?? 0) > 1 ? `${node.name} #${position}` : node.name]+ })+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsx b/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsxindex 711daa8a0857..ea2d4e3b0dc1 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsx+++ b/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsx@@ -16,6 +16,9 @@ import {makeEvaluationResult,makeEvaluationResults,makeEvent,+ makeFeedback,+ makeFeedbackScore,+ makeFeedbackText,makeNodeDetail,makeTrace,makeTraceResource,@@ -33,6 +36,7 @@ jest.mock('../../../utils', () => ({const TRACE_URL = '/api/projects/:team_id/ai_observability/traces/:id/'const NODE_URL = '/api/projects/:team_id/ai_observability/traces/:id/nodes/:node_id/'const EVALUATIONS_URL = '/api/projects/:team_id/ai_observability/traces/:id/evaluations/'+const FEEDBACK_URL = '/api/projects/:team_id/ai_observability/traces/:id/feedback/'const DATASETS_URL = '/api/projects/:team_id/datasets/'const SUMMARY_URL = '/api/projects/:team_id/ai_observability/traces/:id/summary/'const answeredGeneration = makeNodeDetail({@@ -52,6 +56,7 @@ const nodeMock = {},}const evaluationsMock = { [EVALUATIONS_URL]: () => [200, makeEvaluationResults()] }+const feedbackMock = { [FEEDBACK_URL]: () => [200, makeFeedback({ scores: [], responses: [] })] }const generation = makeEvent({id: 'gen-1',@@ -91,6 +96,7 @@ describe('TraceScene', () => {[DATASETS_URL]: () => [200, { count: 0, results: [] }],...nodeMock,...evaluationsMock,+ ...feedbackMock,},})})@@ -202,11 +208,46 @@ describe('TraceScene', () => {expect(await findByText('Two seats were added.')).toBeTruthy()expect(queryByText('Add to dataset') !== null).toBe(enabled)})++ it('opens the feedback from the header chip and the step chips, and links each entry to its step', async () => {+ useMocks({+ get: {+ [FEEDBACK_URL]: () => [+ 200,+ makeFeedback({+ scores: [makeFeedbackScore({ name: 'helpfulness', value: '0', nodeId: 'gen-1' })],+ responses: [makeFeedbackText({ text: 'Too long, but correct.', nodeId: 'trace-1' })],+ }),+ ],+ },+ })+ const { container, findByText, getByText } = renderNewView()++ fireEvent.click(await findByText('Feedback 2', { selector: 'button *' }))+ expect(await findByText('Too long, but correct.')).toBeTruthy()++ fireEvent.click(getByText('gen-1', { selector: '[data-attr="trace-view-feedback-step-link"]' }))+ await waitFor(() =>+ expect(+ container.querySelector('[data-attr="trace-view-tree-node"][aria-current="true"]')?.textContent+ ).toContain('gen-1')+ )++ fireEvent.click(await findByText('helpfulness 0'))+ expect(await findByText('What users said')).toBeTruthy()+ })})describe('behind the flag gate', () => {beforeEach(() => {- useMocks({ get: { [TRACE_URL]: () => [200, makeTraceResource()], ...nodeMock, ...evaluationsMock } })+ useMocks({+ get: {+ [TRACE_URL]: () => [200, makeTraceResource()],+ ...nodeMock,+ ...evaluationsMock,+ ...feedbackMock,+ },+ })})async function renderTraceRoute(flagEnabled: boolean): Promise<ReturnType<typeof render>> {diff --git a/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.test.ts b/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.test.tsindex bdf77b89f1a3..537681b42f61 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.test.ts+++ b/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.test.ts@@ -5,6 +5,7 @@ import posthog from 'posthog-js'import { urls } from 'scenes/urls'+import { resumeKeaLoadersErrors, silenceKeaLoadersErrors } from '~/initKea'import { useMocks } from '~/mocks/jest'import { performQuery } from '~/queries/query'import { initKeaTests } from '~/test/init'@@ -12,7 +13,7 @@ import { initKeaTests } from '~/test/init'import { aiObservabilityTraceLogic } from '../../../aiObservabilityTraceLogic'import type { TraceApi, TraceEvaluationResultsApi } from '../../../generated/api.schemas'import { traceSummaryLogic } from '../traceSummaryLogic'-import { decodeIdSegment, makeEvaluationResults, makeNodeDetail, makeTraceResource } from './testFixtures'+import { decodeIdSegment, makeEvaluationResults, makeFeedback, makeNodeDetail, makeTraceResource } from './testFixtures'import { traceViewAdapterLogic } from './traceViewAdapterLogic'jest.mock('~/queries/query', () => ({ ...jest.requireActual('~/queries/query'), performQuery: jest.fn() }))@@ -20,6 +21,7 @@ jest.mock('~/queries/query', () => ({ ...jest.requireActual('~/queries/query'),const TRACE_URL = '/api/projects/:team_id/ai_observability/traces/:id/'const NODE_URL = '/api/projects/:team_id/ai_observability/traces/:id/nodes/:node_id/'const EVALUATIONS_URL = '/api/projects/:team_id/ai_observability/traces/:id/evaluations/'+const FEEDBACK_URL = '/api/projects/:team_id/ai_observability/traces/:id/feedback/'const SUMMARY_URL = '/api/projects/:team_id/ai_observability/traces/:id/summary/'const answeredGeneration = makeNodeDetail({@@ -37,6 +39,7 @@ describe('traceViewAdapterLogic', () => {let traceGate: Promise<void>let nodeRequests: string[]let failingNodeId: string | null+ let feedbackStatus: numberlet summaryRequests: numberlet evaluations: TraceEvaluationResultsApi@@ -51,6 +54,7 @@ describe('traceViewAdapterLogic', () => {traceGate = Promise.resolve()nodeRequests = []failingNodeId = null+ feedbackStatus = 200summaryRequests = 0evaluations = makeEvaluationResults()useMocks({@@ -67,6 +71,8 @@ describe('traceViewAdapterLogic', () => {return [200, traceResource]},[EVALUATIONS_URL]: () => [200, evaluations],+ [FEEDBACK_URL]: () =>+ feedbackStatus === 200 ? [200, makeFeedback()] : [feedbackStatus, { detail: 'Server error.' }],[NODE_URL]: ({ params }) => {const nodeId = decodeIdSegment(String(params.node_id))nodeRequests.push(nodeId)@@ -89,6 +95,7 @@ describe('traceViewAdapterLogic', () => {})afterEach(() => {+ resumeKeaLoadersErrors()logic.unmount()jest.restoreAllMocks()})@@ -263,6 +270,46 @@ describe('traceViewAdapterLogic', () => {await expectLogic(logic, () => logic.actions.selectNode(nodeId)).toMatchValues({ canViewInThread: expected })})+ it('showFeedback opens the Feedback mode focused on the step, reports where it came from and keeps both on a click of its tab', async () => {+ const capture = jest.spyOn(posthog, 'capture')+ mountAt()+ await expectLogic(logic).toFinishAllListeners()+ logic.actions.setMode('thread')++ await expectLogic(logic, () => logic.actions.showFeedback('gen-1', 'step')).toMatchValues({+ mode: 'feedback',+ feedbackFocusNodeId: 'gen-1',+ feedbackChip: { total: 2 },+ feedbackCountByNodeId: { 'gen-1': 1, 'trace-1': 1 },+ })+ expect(capture).toHaveBeenCalledWith('llma trace view feedback viewed', {+ entry: 'step',+ scores: 1,+ responses: 1,+ })++ await expectLogic(logic, () => logic.actions.setMode('feedback')).toMatchValues({+ mode: 'feedback',+ feedbackFocusNodeId: 'gen-1',+ })+ expect(capture.mock.calls.filter(([event]) => event === 'llma trace view feedback viewed')).toHaveLength(1)+ })++ it('has no chip, no counts and an error mode after the feedback read fails', async () => {+ silenceKeaLoadersErrors()+ feedbackStatus = 500+ mountAt()++ await expectLogic(logic)+ .toFinishAllListeners()+ .toMatchValues({+ status: 'ready',+ feedbackChip: null,+ feedbackCountByNodeId: {},+ feedbackMode: { status: 'error' },+ })+ })+it('the Summary mode reads the summary on open, and a step link leaves it for that step in spans', async () => {const capture = jest.spyOn(posthog, 'capture')mountAt()@@ -280,6 +327,19 @@ describe('traceViewAdapterLogic', () => {expect(capture).toHaveBeenCalledWith('llma trace view summary step clicked', { kind: 'bullet' })})+ it('leaving the Summary mode for the Feedback mode closes the summary', async () => {+ mountAt()+ await expectLogic(logic).toFinishAllListeners()+ const summary = traceSummaryLogic({ traceId: 'trace-1' })++ logic.actions.setMode('summary')+ await expectLogic(summary).toDispatchActions([summary.actionCreators.openSummary('tab'), 'loadSummarySuccess'])+ logic.actions.showFeedback(null, 'chip')++ expect(logic.values.mode).toBe('feedback')+ await expectLogic(summary).toDispatchActions(['closeSummary']).toMatchValues({ isOpen: false })+ })+it('a trace-level summary link opens the Summary mode without requesting a summary', async () => {mountAt({ tab: 'summary' })const summary = traceSummaryLogic({ traceId: 'trace-1' })diff --git a/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.ts b/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.tsindex 813905818b36..7be1a3965540 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.ts+++ b/products/ai_observability/frontend/redesign/trace/adapter/traceViewAdapterLogic.ts@@ -13,21 +13,27 @@ import type { SaveToDatasetButtonProps } from '../../../datasets/SaveToDatasetBuimport type {TraceApi,TraceEvaluationResultsApi,+ TraceFeedbackApi,TraceNodeApi,TraceTimelineRowApi,} from '../../../generated/api.schemas'import { GitBranchChipProps } from '../components/GitBranchChip'import { TraceHeaderProps } from '../components/TraceHeader'import { TraceSummaryBarProps } from '../components/TraceSummaryBar'+import { traceFeedbackLogic } from '../traceFeedbackLogic'import { traceSummaryLogic } from '../traceSummaryLogic'import { TraceViewStatus, traceViewLogic } from '../traceViewLogic'import {ConversationState,EvalRollupOutcome,EvalsChipData,+ FeedbackChipData,+ FeedbackEntry,+ FeedbackModeState,LabeledLink,NodeDetailTab,NodeLoad,+ StepFeedback,SummaryItemKind,SummaryModeState,SummaryRequestError,@@ -35,6 +41,7 @@ import {} from '../types'import { toDatasetItemSource } from './toDatasetItemSource'import { firstFailingNodeId, toEvalOutcomesByNode, toEvalsChip } from './toEvalSummary'+import { stepFeedbackOf, toFeedbackChip, toFeedbackMode, toStepFeedback } from './toFeedback'import { toBackLink, toHeader } from './toHeader'import { NodeDetailData, toNodeDetail } from './toNodeDetail'import { toThread } from './toThread'@@ -57,6 +64,8 @@ export interface traceViewAdapterLogicValues {featureFlags: FeatureFlagsSet // featureFlagLogicsearchParams: Record<string, any> // routercurrentTeamId: number | null // teamLogic+ traceFeedback: TraceFeedbackApi | null // traceFeedbackLogic+ traceFeedbackFailed: boolean // traceFeedbackLogicsummaryRequestError: SummaryRequestError | null // traceSummaryLogicsummaryRequesting: boolean // traceSummaryLogicsummaryState: SummaryModeState // traceSummaryLogic@@ -87,12 +96,19 @@ export interface traceViewAdapterLogicValues {detailTab: NodeDetailTabevalOutcomesByNode: Record<string, EvalRollupOutcome>evalsChip: EvalsChipData | null+ feedbackChip: FeedbackChipData | null+ feedbackCount: number | null+ feedbackCountByNodeId: Record<string, number>+ feedbackFocusNodeId: string | null+ feedbackMode: FeedbackModeStategitBranch: GitBranchChipProps | nullheader: TraceHeaderPropsmode: TraceModeselectedNodeId: stringselectedNodeLoad: NodeLoad+ selectedStepFeedback: StepFeedback | nullselectedTreeNode: TraceNodeApi | null+ stepFeedback: Record<string, StepFeedback>thread: ConversationStatethreadNodeLoad: NodeLoad | null}@@ -109,6 +125,9 @@ export interface traceViewAdapterLogicActions {setEventId: (eventId: string | null) => {eventId: string | null} // aiObservabilityTraceLogic+ retryTraceFeedback: () => {+ value: true+ } // traceFeedbackLogiccloseSummary: () => {value: true} // traceSummaryLogic@@ -157,6 +176,13 @@ export interface traceViewAdapterLogicActions {showFailingEvals: () => {value: true}+ showFeedback: (+ nodeId: string | null,+ entry: FeedbackEntry+ ) => {+ entry: FeedbackEntry+ nodeId: string | null+ }summarize: () => {value: true}@@ -226,6 +252,21 @@ export interface traceViewAdapterLogicMeta {evalOutcomesByNode: (evaluationResults: TraceEvaluationResultsApi | null) => Record<string, EvalRollupOutcome>gitBranch: (trace: TraceApi | null) => GitBranchChipProps | nullcanViewInThread: (selectedNodeId: string, threadNodeIds: string[], traceId: string) => boolean+ feedbackChip: (traceFeedback: TraceFeedbackApi | null) => FeedbackChipData | null+ feedbackCount: (traceFeedback: TraceFeedbackApi | null) => number | null+ stepFeedback: (traceFeedback: TraceFeedbackApi | null) => Record<string, StepFeedback>+ feedbackCountByNodeId: (stepFeedback: Record<string, StepFeedback>) => Record<string, number>+ selectedStepFeedback: (+ stepFeedback: Record<string, StepFeedback>,+ selectedNodeId: string+ ) => StepFeedback | null+ feedbackMode: (+ traceFeedback: TraceFeedbackApi | null,+ traceFeedbackFailed: boolean,+ tree: TraceNodeApi[],+ feedbackFocusNodeId: string | null,+ traceId: string+ ) => FeedbackModeState}}@@ -274,6 +315,8 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([['searchParams'],featureFlagLogic,['featureFlags'],+ traceFeedbackLogic({ traceId: props.traceId, timestampHint: props.timestampHint }),+ ['traceFeedback', 'traceFeedbackFailed'],traceSummaryLogic({ traceId: props.traceId }),['state as summaryState', 'requesting as summaryRequesting', 'requestError as summaryRequestError'],aiConsentLogic,@@ -284,6 +327,8 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([['setEventId', 'loadNeighbors'],traceViewLogic({ traceId: props.traceId, timestampHint: props.timestampHint }),['loadNode', 'loadTraceSuccess'],+ traceFeedbackLogic({ traceId: props.traceId, timestampHint: props.timestampHint }),+ ['retryTraceFeedback'],traceSummaryLogic({ traceId: props.traceId }),['openSummary', 'closeSummary', 'requestSummary', 'loadSummary'],],@@ -296,6 +341,7 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([viewInThread: true,prefetchNode: (id: string) => ({ id }),showFailingEvals: true,+ showFeedback: (nodeId: string | null, entry: FeedbackEntry) => ({ nodeId, entry }),openSummaryFromLink: true,summarize: true,regenerateSummary: true,@@ -308,10 +354,20 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([setMode: (_, { mode }) => mode,selectAndShowSpans: () => 'spans',viewInThread: () => 'thread',+ showFeedback: () => 'feedback',openSummaryFromLink: () => 'summary',},],detailTab: ['messages' as NodeDetailTab, { setDetailTab: (_, { tab }) => tab }],+ feedbackFocusNodeId: [+ null as string | null,+ {+ showFeedback: (_, { nodeId }) => nodeId,+ setMode: (focusNodeId, { mode }) => (mode === 'feedback' ? focusNodeId : null),+ selectAndShowSpans: () => null,+ viewInThread: () => null,+ },+ ],}),selectors({selectedNodeId: [@@ -460,6 +516,47 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([(selectedNodeId: string, threadNodeIds: string[], traceId: string): boolean =>selectedNodeId === traceId || threadNodeIds.includes(selectedNodeId),],+ feedbackChip: [+ (s) => [s.traceFeedback],+ (feedback: TraceFeedbackApi | null): FeedbackChipData | null =>+ feedback ? toFeedbackChip(feedback.summary) : null,+ ],+ feedbackCount: [+ (s) => [s.traceFeedback],+ (feedback: TraceFeedbackApi | null): number | null => feedback?.summary.total ?? null,+ ],+ stepFeedback: [+ (s) => [s.traceFeedback],+ (feedback: TraceFeedbackApi | null): Record<string, StepFeedback> =>+ feedback ? toStepFeedback(feedback) : {},+ ],+ feedbackCountByNodeId: [+ (s) => [s.stepFeedback],+ (stepFeedback: Record<string, StepFeedback>): Record<string, number> =>+ Object.fromEntries(+ Object.entries(stepFeedback).map(([nodeId, step]) => [nodeId, step.scores.length + step.textCount])+ ),+ ],+ selectedStepFeedback: [+ (s) => [s.stepFeedback, s.selectedNodeId],+ (stepFeedback: Record<string, StepFeedback>, selectedNodeId: string): StepFeedback | null =>+ stepFeedbackOf(stepFeedback, selectedNodeId),+ ],+ feedbackMode: [+ (s, p) => [s.traceFeedback, s.traceFeedbackFailed, s.tree, s.feedbackFocusNodeId, p.traceId],+ (+ feedback: TraceFeedbackApi | null,+ failed: boolean,+ tree: TraceNodeApi[],+ focusNodeId: string | null,+ traceId: string+ ): FeedbackModeState => {+ if (failed) {+ return { status: 'error' }+ }+ return feedback ? toFeedbackMode({ feedback, tree, traceId, focusNodeId }) : { status: 'loading' }+ },+ ],}),listeners(({ actions, values, selectors, props }) => {// The click's read starts before the selection moves, so the selectedNodeId subscription's navigation read@@ -469,6 +566,13 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([actions.loadNode(id, 'selection')actions.setEventId(id)}+ const captureFeedbackViewed = (entry: FeedbackEntry | 'tab'): void => {+ posthog.capture('llma trace view feedback viewed', {+ entry,+ scores: values.traceFeedback?.scores.length ?? null,+ responses: values.traceFeedback?.responses.length ?? null,+ })+ }const syncSummary = (previousMode: TraceMode): void => {const wasOpen = previousMode === 'summary'if (values.mode === 'summary' && !wasOpen) {@@ -481,7 +585,6 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([actions.requestSummary({ regenerate, timestampHint: values.createdAt })}return {- setMode: (_, __, ___, previousState) => syncSummary(selectors.mode(previousState)),viewInThread: (_, __, ___, previousState) => syncSummary(selectors.mode(previousState)),selectNode: select,selectAndShowSpans: (payload, __, ___, previousState) => {@@ -511,6 +614,17 @@ export const traceViewAdapterLogic = kea<traceViewAdapterLogicType>([actions.selectAndShowSpans(firstFailingNodeId(values.tree, values.evalOutcomesByNode) ?? props.traceId)actions.setDetailTab('evals')},+ showFeedback: ({ entry }, __, ___, previousState) => {+ captureFeedbackViewed(entry)+ syncSummary(selectors.mode(previousState))+ },+ setMode: ({ mode }, __, ___, previousState) => {+ const previousMode = selectors.mode(previousState)+ syncSummary(previousMode)+ if (mode === 'feedback' && previousMode !== 'feedback') {+ captureFeedbackViewed('tab')+ }+ },}}),subscriptions(({ actions }) => ({diff --git a/products/ai_observability/frontend/redesign/trace/components/ErrorCallout.tsx b/products/ai_observability/frontend/redesign/trace/components/ErrorCallout.tsxindex 6ec3886cfc79..4be65494c7ce 100644--- a/products/ai_observability/frontend/redesign/trace/components/ErrorCallout.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/ErrorCallout.tsx@@ -2,11 +2,12 @@ import { LemonBanner } from '@posthog/lemon-ui'export interface ErrorCalloutProps {message: string+ onRetry?: () => void}-export function ErrorCallout({ message }: ErrorCalloutProps): JSX.Element {+export function ErrorCallout({ message, onRetry }: ErrorCalloutProps): JSX.Element {return (- <LemonBanner type="error">+ <LemonBanner type="error" action={onRetry ? { children: 'Try again', onClick: onRetry } : undefined}><span className="font-mono text-sm whitespace-pre-wrap break-words">{message}</span></LemonBanner>)diff --git a/products/ai_observability/frontend/redesign/trace/components/EvalResultRow.tsx b/products/ai_observability/frontend/redesign/trace/components/EvalResultRow.tsxindex 5f5c586edb9a..673399ab00de 100644--- a/products/ai_observability/frontend/redesign/trace/components/EvalResultRow.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/EvalResultRow.tsx@@ -1,9 +1,8 @@import { LemonTag, Link } from '@posthog/lemon-ui'-import { TZLabel } from 'lib/components/TZLabel'-import { EvalResult } from '../types'import { EvalOutcomeTag } from './EvalOutcomeTag'+import { ShortTimestamp } from './ShortTimestamp'export interface EvalResultRowProps {result: EvalResult@@ -44,7 +43,7 @@ export function EvalResultRow({ result, onSelectNode }: EvalResultRowProps): JSX{target.label}</Link>) : null}- <TZLabel time={result.timestamp} timestampStyle="absolute" formatDate="MMM D," formatTime="HH:mm" />+ <ShortTimestamp time={result.timestamp} /></span></div>{result.reasoning ? <p className="m-0 text-secondary text-xs">{result.reasoning}</p> : null}diff --git a/products/ai_observability/frontend/redesign/trace/components/FeedbackChip.tsx b/products/ai_observability/frontend/redesign/trace/components/FeedbackChip.tsxnew file mode 100644index 000000000000..906f5bc5e44a--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/FeedbackChip.tsx@@ -0,0 +1,24 @@+import { IconMessage } from '@posthog/icons'+import { LemonButton } from '@posthog/lemon-ui'++import { FeedbackChipData } from '../types'++export interface FeedbackChipProps {+ chip: FeedbackChipData+ onClick: () => void+}++export function FeedbackChip({ chip, onClick }: FeedbackChipProps): JSX.Element {+ return (+ <LemonButton+ size="xsmall"+ type="secondary"+ icon={<IconMessage />}+ onClick={onClick}+ tooltip="Show the feedback on this trace"+ data-attr="trace-view-feedback-chip"+ >+ {`Feedback ${chip.total}`}+ </LemonButton>+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/FeedbackEmptyState.tsx b/products/ai_observability/frontend/redesign/trace/components/FeedbackEmptyState.tsxnew file mode 100644index 000000000000..7b294afdd649--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/FeedbackEmptyState.tsx@@ -0,0 +1,16 @@+import { Link } from '@posthog/lemon-ui'++const FEEDBACK_DOCS_URL = 'https://posthog.com/docs/ai-observability/collect-user-feedback'++export function FeedbackEmptyState(): JSX.Element {+ return (+ <div className="flex flex-col gap-1">+ <p className="m-0 text-secondary">+ No feedback on this trace yet. Feedback shows here when your code sends scores or comments for it.+ </p>+ <Link to={FEEDBACK_DOCS_URL} target="_blank" data-attr="trace-view-feedback-docs-link">+ Send feedback from your code+ </Link>+ </div>+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/FeedbackMarker.tsx b/products/ai_observability/frontend/redesign/trace/components/FeedbackMarker.tsxnew file mode 100644index 000000000000..275af3e8a9d2--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/FeedbackMarker.tsx@@ -0,0 +1,19 @@+import { IconMessage } from '@posthog/icons'++export interface FeedbackMarkerProps {+ count: number+}++export function FeedbackMarker({ count }: FeedbackMarkerProps): JSX.Element {+ return (+ <span+ className="flex shrink-0 items-center gap-0.5 text-xs font-normal text-secondary"+ role="img"+ aria-label={`Feedback: ${count}`}+ title={`Feedback: ${count}`}+ >+ <IconMessage />+ <span>{count}</span>+ </span>+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/FeedbackScoresTable.tsx b/products/ai_observability/frontend/redesign/trace/components/FeedbackScoresTable.tsxnew file mode 100644index 000000000000..576e0f44fd74--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/FeedbackScoresTable.tsx@@ -0,0 +1,51 @@+import { LemonTable } from '@posthog/lemon-ui'++import { FeedbackScoreRow } from '../types'+import { FeedbackStepLink } from './FeedbackStepLink'+import { scrollIntoNearest } from './scrollIntoNearest'+import { ShortTimestamp } from './ShortTimestamp'++export interface FeedbackScoresTableProps {+ scores: FeedbackScoreRow[]+ onSelectStep: (nodeId: string) => void+ /** The row to bring into view, the first one of the step the mode was opened from. */+ scrollTargetId: string | null+}++export function FeedbackScoresTable({ scores, onSelectStep, scrollTargetId }: FeedbackScoresTableProps): JSX.Element {+ return (+ <LemonTable<FeedbackScoreRow>+ dataSource={scores}+ rowKey="id"+ size="small"+ rowStatus={(row) => (row.focused ? 'highlighted' : null)}+ onRow={(row) => (row.id === scrollTargetId ? { ref: scrollIntoNearest } : {})}+ columns={[+ {+ title: 'Score',+ key: 'name',+ render: (_, row) => (+ <span className={row.name ? 'font-semibold' : 'text-secondary'}>+ {row.name ?? 'Unnamed score'}+ </span>+ ),+ },+ {+ title: 'Value',+ key: 'value',+ render: (_, row) => <span className="break-all font-mono">{row.value}</span>,+ },+ {+ title: 'Step',+ key: 'step',+ render: (_, row) => <FeedbackStepLink step={row.step} onSelectStep={onSelectStep} />,+ },+ {+ title: 'Time',+ key: 'timestamp',+ render: (_, row) => <ShortTimestamp time={row.timestamp} />,+ },+ ]}+ />+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/FeedbackStepLink.tsx b/products/ai_observability/frontend/redesign/trace/components/FeedbackStepLink.tsxnew file mode 100644index 000000000000..60a3a23dfd2b--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/FeedbackStepLink.tsx@@ -0,0 +1,24 @@+import { Link } from '@posthog/lemon-ui'++import { FeedbackStep } from '../types'++export interface FeedbackStepLinkProps {+ step: FeedbackStep | null+ onSelectStep: (nodeId: string) => void+}++export function FeedbackStepLink({ step, onSelectStep }: FeedbackStepLinkProps): JSX.Element {+ if (!step) {+ return <span className="text-secondary">Whole trace</span>+ }+ return (+ <Link+ onClick={() => onSelectStep(step.id)}+ className="max-w-60 truncate font-mono"+ title={`Show ${step.name}`}+ data-attr="trace-view-feedback-step-link"+ >+ {step.name}+ </Link>+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/FeedbackTextCard.tsx b/products/ai_observability/frontend/redesign/trace/components/FeedbackTextCard.tsxnew file mode 100644index 000000000000..1c0ef06c0daf--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/FeedbackTextCard.tsx@@ -0,0 +1,28 @@+import { cn } from 'lib/utils/css-classes'++import { FeedbackResponseItem } from '../types'+import { FeedbackStepLink } from './FeedbackStepLink'+import { scrollIntoNearest } from './scrollIntoNearest'+import { ShortTimestamp } from './ShortTimestamp'++export interface FeedbackTextCardProps {+ item: FeedbackResponseItem+ onSelectStep: (nodeId: string) => void+ /** Brings the card into view when it mounts. */+ isScrollTarget: boolean+}++export function FeedbackTextCard({ item, onSelectStep, isScrollTarget }: FeedbackTextCardProps): JSX.Element {+ return (+ <li+ ref={isScrollTarget ? scrollIntoNearest : undefined}+ className={cn('flex flex-col gap-1 px-3 py-2', item.focused && 'bg-accent-highlight-secondary')}+ >+ <div className="flex flex-wrap items-center justify-end gap-x-2 gap-y-1 text-xs text-secondary">+ <FeedbackStepLink step={item.step} onSelectStep={onSelectStep} />+ <ShortTimestamp time={item.timestamp} />+ </div>+ <p className="m-0 whitespace-pre-wrap break-words text-sm">{item.text}</p>+ </li>+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/NodeDetail.stories.tsx b/products/ai_observability/frontend/redesign/trace/components/NodeDetail.stories.tsxindex 66b2a228aeb5..15f935cc5998 100644--- a/products/ai_observability/frontend/redesign/trace/components/NodeDetail.stories.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/NodeDetail.stories.tsx@@ -11,6 +11,7 @@ import {FIXTURE_GENERATION_OUTPUT,FIXTURE_GENERATION_PROPERTIES,FIXTURE_SPAN_PROPERTIES,+ FIXTURE_STEP_FEEDBACK,FIXTURE_TREE,withWidth,} from '../storyFixtures'@@ -118,3 +119,7 @@ export const FailedGenerationWithImage: Story = {onSelectNode: () => {},},}+export const WithFeedback: Story = {+ args: { ...base, stepFeedback: { feedback: FIXTURE_STEP_FEEDBACK, onOpen: () => {} } },+ decorators: [withWidth(520)],+}diff --git a/products/ai_observability/frontend/redesign/trace/components/NodeDetail.tsx b/products/ai_observability/frontend/redesign/trace/components/NodeDetail.tsxindex cc1f49a452ab..b199d439c429 100644--- a/products/ai_observability/frontend/redesign/trace/components/NodeDetail.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/NodeDetail.tsx@@ -10,6 +10,7 @@ import { NodeDetailHeader } from './NodeDetailHeader'import { NodeMessagesTab } from './NodeMessagesTab'import { NodePropertyList } from './NodePropertyList'import { NodeRawTab } from './NodeRawTab'+import { StepFeedbackChipsProps } from './StepFeedbackChips'export interface NodeDetailProps {node: TraceNodeApi@@ -23,12 +24,13 @@ export interface NodeDetailProps {onViewInThread: (() => void) | nullonSelectNode: (nodeId: string) => voidactions?: ReactNode+ stepFeedback?: StepFeedbackChipsProps | null}export function NodeDetail(props: NodeDetailProps): JSX.Element {return (<div className="flex min-w-0 flex-col gap-2">- <NodeDetailHeader node={props.node} actions={props.actions} />+ <NodeDetailHeader node={props.node} actions={props.actions} stepFeedback={props.stepFeedback} /><LemonTabs<NodeDetailTab>size="small"activeKey={props.tab}diff --git a/products/ai_observability/frontend/redesign/trace/components/NodeDetailHeader.tsx b/products/ai_observability/frontend/redesign/trace/components/NodeDetailHeader.tsxindex 89dc0baae7b4..76b4288feb3e 100644--- a/products/ai_observability/frontend/redesign/trace/components/NodeDetailHeader.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/NodeDetailHeader.tsx@@ -5,13 +5,15 @@ import { LemonTag } from '@posthog/lemon-ui'import type { TraceNodeApi } from '../../../generated/api.schemas'import { NodeKindGlyph } from './NodeKindGlyph'import { NodeStatChips } from './NodeStatChips'+import { StepFeedbackChips, StepFeedbackChipsProps } from './StepFeedbackChips'export interface NodeDetailHeaderProps {node: TraceNodeApiactions?: ReactNode+ stepFeedback?: StepFeedbackChipsProps | null}-export function NodeDetailHeader({ node, actions }: NodeDetailHeaderProps): JSX.Element {+export function NodeDetailHeader({ node, actions, stepFeedback = null }: NodeDetailHeaderProps): JSX.Element {return (<header className="flex flex-col gap-1.5"><div className="flex items-center gap-2 min-w-0">@@ -27,6 +29,7 @@ export function NodeDetailHeader({ node, actions }: NodeDetailHeaderProps): JSX.</LemonTag>) : null}{node.hasError ? <LemonTag type="danger">Error</LemonTag> : null}+ {stepFeedback ? <StepFeedbackChips {...stepFeedback} /> : null}</div></header>)diff --git a/products/ai_observability/frontend/redesign/trace/components/ShortTimestamp.tsx b/products/ai_observability/frontend/redesign/trace/components/ShortTimestamp.tsxnew file mode 100644index 000000000000..2ba398ce051a--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/ShortTimestamp.tsx@@ -0,0 +1,9 @@+import { TZLabel } from 'lib/components/TZLabel'++export interface ShortTimestampProps {+ time: string+}++export function ShortTimestamp({ time }: ShortTimestampProps): JSX.Element {+ return <TZLabel time={time} timestampStyle="absolute" formatDate="MMM D," formatTime="HH:mm" />+}diff --git a/products/ai_observability/frontend/redesign/trace/components/StepFeedbackChips.tsx b/products/ai_observability/frontend/redesign/trace/components/StepFeedbackChips.tsxnew file mode 100644index 000000000000..728d2662dbe7--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/StepFeedbackChips.tsx@@ -0,0 +1,55 @@+import { IconMessage } from '@posthog/icons'+import { LemonButton } from '@posthog/lemon-ui'++import { StepFeedback } from '../types'++const SHOWN_SCORES = 3++export interface StepFeedbackChipsProps {+ feedback: StepFeedback+ onOpen: () => void+}++export function StepFeedbackChips({ feedback, onOpen }: StepFeedbackChipsProps): JSX.Element {+ const shown = feedback.scores.slice(0, SHOWN_SCORES)+ const hidden = feedback.scores.length - shown.length+ return (+ <>+ {shown.map((score) => (+ <LemonButton+ key={score.id}+ size="xsmall"+ type="secondary"+ onClick={onOpen}+ tooltip="Show this score in the feedback"+ data-attr="trace-view-feedback-step-chip"+ >+ <span className="max-w-48 truncate font-mono">{`${score.name ?? 'Unnamed score'} ${score.value}`}</span>+ </LemonButton>+ ))}+ {hidden > 0 ? (+ <LemonButton+ size="xsmall"+ type="secondary"+ onClick={onOpen}+ tooltip="Show all scores in the feedback"+ data-attr="trace-view-feedback-step-chip"+ >+ {`+${hidden}`}+ </LemonButton>+ ) : null}+ {feedback.textCount > 0 ? (+ <LemonButton+ size="xsmall"+ type="secondary"+ icon={<IconMessage />}+ onClick={onOpen}+ tooltip="Show what users said"+ data-attr="trace-view-feedback-step-chip"+ >+ {`Feedback ${feedback.textCount}`}+ </LemonButton>+ ) : null}+ </>+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceFeedbackView.stories.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceFeedbackView.stories.tsxnew file mode 100644index 000000000000..50d98f16b178--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/TraceFeedbackView.stories.tsx@@ -0,0 +1,31 @@+import type { Meta, StoryObj } from '@storybook/react'++import { FIXTURE_FEEDBACK_MODE, withWidth } from '../storyFixtures'+import { TraceFeedbackView } from './TraceFeedbackView'++const unfocused = {+ ...FIXTURE_FEEDBACK_MODE,+ scores: FIXTURE_FEEDBACK_MODE.scores.map((row) => ({ ...row, focused: false })),+ responses: FIXTURE_FEEDBACK_MODE.responses.map((item) => ({ ...item, focused: false })),+}++const meta: Meta<typeof TraceFeedbackView> = {+ title: 'Scenes-App/AI observability/Trace view/Feedback',+ component: TraceFeedbackView,+ args: { onSelectStep: () => {} },+ decorators: [withWidth(960)],+}+export default meta++type Story = StoryObj<typeof TraceFeedbackView>++export const ScoresAndText: Story = { args: { state: unfocused } }+export const FocusedOnAStep: Story = { args: { state: FIXTURE_FEEDBACK_MODE } }+export const ScoresOnly: Story = { args: { state: { ...unfocused, responses: [] } } }+export const Narrow: Story = { args: { state: FIXTURE_FEEDBACK_MODE }, decorators: [withWidth(520)] }+export const Empty: Story = { args: { state: { status: 'ready', scores: [], responses: [] } } }+export const Loading: Story = {+ args: { state: { status: 'loading' } },+ parameters: { testOptions: { waitForLoadersToDisappear: false } },+}+export const LoadError: Story = { args: { state: { status: 'error' } } }diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceFeedbackView.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceFeedbackView.tsxnew file mode 100644index 000000000000..8cda0168b233--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/TraceFeedbackView.tsx@@ -0,0 +1,62 @@+import { LemonSkeleton } from '@posthog/lemon-ui'++import { FeedbackModeState } from '../types'+import { ErrorCallout } from './ErrorCallout'+import { FeedbackEmptyState } from './FeedbackEmptyState'+import { FeedbackScoresTable } from './FeedbackScoresTable'+import { FeedbackTextCard } from './FeedbackTextCard'++export interface TraceFeedbackViewProps {+ state: FeedbackModeState+ onSelectStep: (nodeId: string) => void+ onRetry?: () => void+}++function firstFocusedEntryId(state: FeedbackModeState): string | null {+ if (state.status !== 'ready') {+ return null+ }+ return [...state.scores, ...state.responses].find((entry) => entry.focused)?.id ?? null+}++export function TraceFeedbackView({ state, onSelectStep, onRetry }: TraceFeedbackViewProps): JSX.Element {+ const scrollTargetId = firstFocusedEntryId(state)+ if (state.status === 'loading') {+ return <LemonSkeleton repeat={3} className="h-8" />+ }+ if (state.status === 'error') {+ return <ErrorCallout message="Feedback couldn't load." onRetry={onRetry} />+ }+ if (state.scores.length === 0 && state.responses.length === 0) {+ return <FeedbackEmptyState />+ }+ return (+ <div className="flex flex-col gap-4" data-attr="trace-view-feedback">+ {state.scores.length > 0 ? (+ <section className="flex flex-col gap-2">+ <h3 className="m-0 text-sm font-semibold">Scores</h3>+ <FeedbackScoresTable+ scores={state.scores}+ onSelectStep={onSelectStep}+ scrollTargetId={scrollTargetId}+ />+ </section>+ ) : null}+ {state.responses.length > 0 ? (+ <section className="flex flex-col gap-2">+ <h3 className="m-0 text-sm font-semibold">What users said</h3>+ <ul className="m-0 list-none divide-y divide-primary rounded border border-primary bg-surface-primary p-0">+ {state.responses.map((item) => (+ <FeedbackTextCard+ key={item.id}+ item={item}+ onSelectStep={onSelectStep}+ isScrollTarget={item.id === scrollTargetId}+ />+ ))}+ </ul>+ </section>+ ) : null}+ </div>+ )+}diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.stories.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.stories.tsxindex 5cc0b88b42df..ff81ed65a392 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.stories.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.stories.tsx@@ -4,9 +4,9 @@ import { useState } from 'react'import { TraceMode } from '../types'import { TraceModeTabs } from './TraceModeTabs'-function Stateful(): JSX.Element {+function Stateful({ feedbackCount = null }: { feedbackCount?: number | null }): JSX.Element {const [mode, setMode] = useState<TraceMode>('spans')- return <TraceModeTabs mode={mode} onModeChange={setMode} />+ return <TraceModeTabs mode={mode} onModeChange={setMode} feedbackCount={feedbackCount} />}const meta: Meta<typeof Stateful> = {@@ -16,3 +16,4 @@ const meta: Meta<typeof Stateful> = {export default metaexport const Default: StoryObj<typeof Stateful> = {}+export const WithFeedbackCount: StoryObj<typeof Stateful> = { args: { feedbackCount: 6 } }diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.tsxindex 5bf1dcf68c9b..927917f0e7b8 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceModeTabs.tsx@@ -5,9 +5,11 @@ import { TraceMode } from '../types'export interface TraceModeTabsProps {mode: TraceModeonModeChange: (mode: TraceMode) => void+ /** Null until the feedback has loaded. */+ feedbackCount?: number | null}-export function TraceModeTabs({ mode, onModeChange }: TraceModeTabsProps): JSX.Element {+export function TraceModeTabs({ mode, onModeChange, feedbackCount = null }: TraceModeTabsProps): JSX.Element {return (<LemonTabs<TraceMode>activeKey={mode}@@ -18,6 +20,11 @@ export function TraceModeTabs({ mode, onModeChange }: TraceModeTabsProps): JSX.E{ key: 'thread', label: 'Thread', 'data-attr': 'trace-view-mode-thread' },{ key: 'timeline', label: 'Timeline', 'data-attr': 'trace-view-mode-timeline' },{ key: 'summary', label: 'Summary', 'data-attr': 'trace-view-mode-summary' },+ {+ key: 'feedback',+ label: feedbackCount ? `Feedback ${feedbackCount}` : 'Feedback',+ 'data-attr': 'trace-view-mode-feedback',+ },]}/>)diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceSplitView.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceSplitView.tsxindex aa8b99b4c87c..a2369d7c023b 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceSplitView.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceSplitView.tsx@@ -10,6 +10,7 @@ export interface TraceSplitViewProps {onPrefetchNode: (id: string) => voiddetail: Omit<NodeDetailProps, 'onSelectNode'> | nullevalOutcomes: Record<string, EvalRollupOutcome>+ feedbackCountByNodeId?: Record<string, number>}export function TraceSplitView({@@ -19,6 +20,7 @@ export function TraceSplitView({onPrefetchNode,detail,evalOutcomes,+ feedbackCountByNodeId,}: TraceSplitViewProps): JSX.Element {return (<div className="@container">@@ -30,6 +32,7 @@ export function TraceSplitView({onSelectNode={onSelectNode}onPrefetchNode={onPrefetchNode}evalOutcomes={evalOutcomes}+ feedbackCountByNodeId={feedbackCountByNodeId}/></aside><div className="min-w-0 flex-1 @3xl:sticky @3xl:top-[var(--scene-title-section-height,50px)] @3xl:max-h-[calc(100vh-var(--scene-title-section-height,50px))] @3xl:overflow-y-auto">diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.stories.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.stories.tsxindex 3ddd01f9445d..5eca7bb94ffc 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.stories.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.stories.tsx@@ -25,6 +25,10 @@ export const Anonymous: Story = { ...wide, args: { person: null } }export const ShortId: Story = { ...wide, args: { traceId: 'notes-run-42' } }export const LongSlugId: Story = { ...wide, args: { traceId: 'support-chat-session-2026-09-01-weekly-billing-review' } }export const Narrow: Story = { decorators: [withWidth(420)] }+export const WithFeedback: Story = {+ args: { feedback: { chip: { total: 6 }, onClick: () => {} } },+ decorators: [withWidth(420)],+}export const WithGitBranch: Story = {...wide,diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.tsxindex 5e7c6489761b..7d1077f20e9d 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceSummaryBar.tsx@@ -5,6 +5,7 @@ import { TZLabel } from 'lib/components/TZLabel'import type { TraceNodeStatsApi } from '../../../generated/api.schemas'import { LabeledLink } from '../types'import { EvalsChip, EvalsChipProps } from './EvalsChip'+import { FeedbackChip, FeedbackChipProps } from './FeedbackChip'import { GitBranchChip, GitBranchChipProps } from './GitBranchChip'import { NodeStatsLine } from './NodeStatsLine'import { PersonChip } from './PersonChip'@@ -16,6 +17,7 @@ export interface TraceSummaryBarProps {person: LabeledLink | nulltotals: TraceNodeStatsApievals?: EvalsChipProps | null+ feedback?: FeedbackChipProps | nullgit?: GitBranchChipProps | null}@@ -25,6 +27,7 @@ export function TraceSummaryBar({person,totals,evals = null,+ feedback = null,git = null,}: TraceSummaryBarProps): JSX.Element {return (@@ -42,6 +45,7 @@ export function TraceSummaryBar({</LemonTag>{person ? <PersonChip person={person} /> : null}{evals ? <EvalsChip {...evals} /> : null}+ {feedback ? <FeedbackChip {...feedback} /> : null}{git ? <GitBranchChip {...git} /> : null}</div><NodeStatsLine stats={totals} className="@2xl:ml-auto" />diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceTree.stories.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceTree.stories.tsxindex 435eded0aa29..018b09f3b98a 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceTree.stories.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceTree.stories.tsx@@ -11,10 +11,12 @@ function Stateful({nodes,initialSelectedId = 'gen-answer',evalOutcomes = {},+ feedbackCountByNodeId,}: {nodes: TraceNodeApi[]initialSelectedId?: stringevalOutcomes?: Record<string, EvalRollupOutcome>+ feedbackCountByNodeId?: Record<string, number>}): JSX.Element {const [selected, setSelected] = useState<string | null>(initialSelectedId)return (@@ -24,6 +26,7 @@ function Stateful({onSelectNode={setSelected}onPrefetchNode={() => {}}evalOutcomes={evalOutcomes}+ feedbackCountByNodeId={feedbackCountByNodeId}/>)}@@ -58,3 +61,6 @@ export const WithError: Story = {],},}+export const WithFeedbackMarkers: Story = {+ args: { nodes: FIXTURE_TREE, feedbackCountByNodeId: { 'trace-1': 3, 'gen-answer': 12, 'span-search': 1 } },+}diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceTree.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceTree.tsxindex b85dc7ce010a..733da42deacb 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceTree.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceTree.tsx@@ -8,6 +8,7 @@ export interface TraceTreeProps {onSelectNode: (id: string) => voidonPrefetchNode: (id: string) => voidevalOutcomes: Record<string, EvalRollupOutcome>+ feedbackCountByNodeId?: Record<string, number>}export function TraceTree({@@ -16,6 +17,7 @@ export function TraceTree({onSelectNode,onPrefetchNode,evalOutcomes,+ feedbackCountByNodeId,}: TraceTreeProps): JSX.Element {return (<ul aria-label="Trace steps" className="m-0 list-none rounded border border-primary bg-surface-primary p-1">@@ -28,6 +30,7 @@ export function TraceTree({onSelectNode={onSelectNode}onPrefetchNode={onPrefetchNode}evalOutcomes={evalOutcomes}+ feedbackCountByNodeId={feedbackCountByNodeId}/>))}</ul>diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceTreeRow.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceTreeRow.tsxindex 4f2838562ca0..ee4c538ffc8d 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceTreeRow.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceTreeRow.tsx@@ -5,6 +5,7 @@ import { cn } from 'lib/utils/css-classes'import type { TraceNodeApi } from '../../../generated/api.schemas'import { EvalRollupOutcome } from '../types'import { EvalOutcomeMarker } from './EvalOutcomeMarker'+import { FeedbackMarker } from './FeedbackMarker'import { NodeKindGlyph } from './NodeKindGlyph'import { NodeStatsLine } from './NodeStatsLine'@@ -15,6 +16,8 @@ export interface TraceTreeRowProps {onSelectNode: (id: string) => voidonPrefetchNode: (id: string) => voidevalOutcomes: Record<string, EvalRollupOutcome>+ /** Feedback entries per step id, trace-level ones on the root. */+ feedbackCountByNodeId?: Record<string, number>}export function TraceTreeRow({@@ -24,10 +27,13 @@ export function TraceTreeRow({onSelectNode,onPrefetchNode,evalOutcomes,+ feedbackCountByNodeId,}: TraceTreeRowProps): JSX.Element {const isSelected = node.id === selectedNodeId// Node ids come from free-form trace ids, so a name like "constructor" would read an inherited property.const evalOutcome = Object.hasOwn(evalOutcomes, node.id) ? evalOutcomes[node.id] : null+ const feedbackCount =+ feedbackCountByNodeId && Object.hasOwn(feedbackCountByNodeId, node.id) ? feedbackCountByNodeId[node.id] : 0return (<li><button@@ -56,6 +62,7 @@ export function TraceTreeRow({<span className="truncate">{node.name}</span>{node.hasError ? <IconWarning className="shrink-0" role="img" aria-label="Error" /> : null}{evalOutcome ? <EvalOutcomeMarker outcome={evalOutcome} /> : null}+ {feedbackCount > 0 ? <FeedbackMarker count={feedbackCount} /> : null}</span><NodeStatsLine stats={node.stats} model={node.model} compact /></span>@@ -71,6 +78,7 @@ export function TraceTreeRow({onSelectNode={onSelectNode}onPrefetchNode={onPrefetchNode}evalOutcomes={evalOutcomes}+ feedbackCountByNodeId={feedbackCountByNodeId}/>))}</ul>diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceView.stories.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceView.stories.tsxindex f69627cd0b23..a805550e3b06 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceView.stories.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceView.stories.tsx@@ -7,7 +7,14 @@ import { claudeCodePluginSession } from '../sampleFixtures/claudeCodePluginSessiimport { langchainCerebrasImageError } from '../sampleFixtures/langchainCerebrasImageError'import { openaiAgentsWithEvals } from '../sampleFixtures/openaiAgentsWithEvals'import { SampleTraceFixture } from '../sampleFixtures/sampleTraceFixture'-import { FIXTURE_EVAL_OUTCOMES, FIXTURE_EVALS_CHIP, FIXTURE_SUMMARY, FIXTURE_TRACE, withWidth } from '../storyFixtures'+import {+ FIXTURE_EVAL_OUTCOMES,+ FIXTURE_EVALS_CHIP,+ FIXTURE_FEEDBACK_MODE,+ FIXTURE_SUMMARY,+ FIXTURE_TRACE,+ withWidth,+} from '../storyFixtures'import { EvalRollupOutcome, EvalsChipData, NodeDetailTab, TraceMode } from '../types'import { TraceView } from './TraceView'@@ -97,6 +104,9 @@ function Playground({ fixture, initialMode, initialNodeId, evals, evalOutcomes =onReload: () => {},onSelectStep: selectAndShowSpans,}}+ feedbackMode={FIXTURE_FEEDBACK_MODE}+ feedbackCount={FIXTURE_FEEDBACK_MODE.scores.length + FIXTURE_FEEDBACK_MODE.responses.length}+ feedbackCountByNodeId={{ 'trace-1': 3, 'gen-answer': 3 }}/>)}@@ -117,6 +127,7 @@ export const GenerationSelected: Story = { args: { fixture: FIXTURE_TRACE, initiexport const ErrorTrace: Story = { args: { fixture: FIXTURE_ERROR_TRACE, initialMode: 'spans' } }export const ThreadMode: Story = { args: { fixture: FIXTURE_TRACE, initialMode: 'thread' } }export const TimelineMode: Story = { args: { fixture: FIXTURE_TRACE, initialMode: 'timeline' } }+export const FeedbackMode: Story = { args: { fixture: FIXTURE_TRACE, initialMode: 'feedback' } }export const Narrow: Story = {args: { fixture: FIXTURE_TRACE, initialMode: 'spans' },decorators: [withWidth(520)],diff --git a/products/ai_observability/frontend/redesign/trace/components/TraceView.tsx b/products/ai_observability/frontend/redesign/trace/components/TraceView.tsxindex 911c9c2e413a..2a9daca9cd52 100644--- a/products/ai_observability/frontend/redesign/trace/components/TraceView.tsx+++ b/products/ai_observability/frontend/redesign/trace/components/TraceView.tsx@@ -1,8 +1,9 @@import type { TraceNodeApi, TraceTimelineRowApi } from '../../../generated/api.schemas'-import { ConversationState, EvalRollupOutcome, LabeledLink, TraceMode } from '../types'+import { ConversationState, EvalRollupOutcome, FeedbackModeState, LabeledLink, TraceMode } from '../types'import { NodeDetailProps } from './NodeDetail'import { SummaryModeView, SummaryModeViewProps } from './SummaryModeView'import { Thread } from './Thread'+import { TraceFeedbackView } from './TraceFeedbackView'import { TraceHeader, TraceHeaderProps } from './TraceHeader'import { TraceModeTabs } from './TraceModeTabs'import { TraceSplitView } from './TraceSplitView'@@ -26,8 +27,16 @@ export interface TraceViewReadyProps {timeline: { rows: TraceTimelineRowApi[]; totalMs: number }evalOutcomes: Record<string, EvalRollupOutcome>summaryMode: SummaryModeViewProps+ feedbackMode?: FeedbackModeState+ onRetryFeedback?: () => void+ /** Null until the feedback has loaded. */+ feedbackCount?: number | null+ /** Feedback entries per step id, trace-level ones on the root. */+ feedbackCountByNodeId?: Record<string, number>}+const FEEDBACK_LOADING: FeedbackModeState = { status: 'loading' }+export type TraceViewProps =| { status: 'loading' }| { status: 'error'; errorMessage: string; backLink: LabeledLink }@@ -44,7 +53,7 @@ export function TraceView(props: TraceViewProps): JSX.Element {<div className="flex flex-col gap-3"><TraceHeader {...props.header} /><TraceSummaryBar {...props.summary} />- <TraceModeTabs mode={props.mode} onModeChange={props.onModeChange} />+ <TraceModeTabs mode={props.mode} onModeChange={props.onModeChange} feedbackCount={props.feedbackCount} />{props.mode === 'spans' ? (<TraceSplitViewtree={props.tree}@@ -53,11 +62,18 @@ export function TraceView(props: TraceViewProps): JSX.Element {onPrefetchNode={props.onPrefetchNode}detail={props.detail}evalOutcomes={props.evalOutcomes}+ feedbackCountByNodeId={props.feedbackCountByNodeId}/>) : props.mode === 'thread' ? (<Thread conversation={props.thread} onSelectMessage={props.onSelectFromView} />) : props.mode === 'summary' ? (<SummaryModeView {...props.summaryMode} />+ ) : props.mode === 'feedback' ? (+ <TraceFeedbackView+ state={props.feedbackMode ?? FEEDBACK_LOADING}+ onSelectStep={props.onSelectFromView}+ onRetry={props.onRetryFeedback}+ />) : (<TraceTimelinerows={props.timeline.rows}diff --git a/products/ai_observability/frontend/redesign/trace/components/scrollIntoNearest.ts b/products/ai_observability/frontend/redesign/trace/components/scrollIntoNearest.tsnew file mode 100644index 000000000000..9b21ed3b9009--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/components/scrollIntoNearest.ts@@ -0,0 +1,4 @@+/** A callback ref that brings its element into view when the element mounts. */+export function scrollIntoNearest(element: HTMLElement | null): void {+ element?.scrollIntoView({ block: 'nearest' })+}diff --git a/products/ai_observability/frontend/redesign/trace/storyFixtures.tsx b/products/ai_observability/frontend/redesign/trace/storyFixtures.tsxindex 28f30e74440e..11b7a6f57379 100644--- a/products/ai_observability/frontend/redesign/trace/storyFixtures.tsx+++ b/products/ai_observability/frontend/redesign/trace/storyFixtures.tsx@@ -1,6 +1,7 @@import type { Decorator } from '@storybook/react'import type {+ TraceFeedbackScoreApi,TraceNodeApi,TraceNodeStatsApi,TraceSummaryContentApi,@@ -12,8 +13,10 @@ import {EvalResult,EvalRollupOutcome,EvalsChipData,+ FeedbackModeState,MessagePart,NodeProperties,+ StepFeedback,ThreadMessage,} from './types'@@ -405,6 +408,57 @@ export const FIXTURE_TRACE: SampleTraceFixture = {timeline: { rows: FIXTURE_TIMELINE_ROWS, totalMs: 2310 },}+const feedbackScore = (id: string, name: string | null, value: string, minute: number): TraceFeedbackScoreApi => ({+ id,+ name,+ value,+ nodeId: 'gen-answer',+ timestamp: `2026-09-01T10:${minute}:00Z`,+})++export const FIXTURE_STEP_FEEDBACK: StepFeedback = {+ scores: [+ feedbackScore('score-helpful', 'helpfulness', '0', 16),+ feedbackScore('score-resolved', 'resolved', 'false', 17),+ feedbackScore('score-tone', 'tone', '4.5', 18),+ feedbackScore('score-latency', 'latency_ok', 'true', 19),+ feedbackScore('score-unnamed', null, '{"stars":3}', 20),+ ],+ textCount: 1,+}++const answerStep = { id: 'gen-answer', name: 'draft-answer' }++export const FIXTURE_FEEDBACK_MODE: Extract<FeedbackModeState, { status: 'ready' }> = {+ status: 'ready',+ scores: [+ { ...feedbackScore('score-helpful', 'helpfulness', '0', 16), step: answerStep, focused: true },+ { ...feedbackScore('score-resolved', 'resolved', 'false', 17), step: answerStep, focused: true },+ { ...feedbackScore('score-csat', 'csat', '4', 21), nodeId: 'trace-1', step: null, focused: false },+ { ...feedbackScore('score-unnamed', null, '{"stars":3}', 22), nodeId: 'trace-1', step: null, focused: false },+ ],+ responses: [+ {+ kind: 'text',+ id: 'text-long',+ text: 'Too long, but correct.',+ nodeId: 'trace-1',+ timestamp: '2026-09-01T10:23:00Z',+ step: null,+ focused: false,+ },+ {+ kind: 'text',+ id: 'text-step',+ text: 'The second paragraph repeats the first one. Shorter answers would help when I am on my phone.',+ nodeId: 'gen-answer',+ timestamp: '2026-09-01T10:24:00Z',+ step: answerStep,+ focused: true,+ },+ ],+}+export const FIXTURE_SUMMARY: TraceSummaryContentApi = {title: 'Billing question answered from invoice history',bullets: [diff --git a/products/ai_observability/frontend/redesign/trace/traceFeedbackLogic.test.ts b/products/ai_observability/frontend/redesign/trace/traceFeedbackLogic.test.tsnew file mode 100644index 000000000000..0dfaeed5be91--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/traceFeedbackLogic.test.ts@@ -0,0 +1,93 @@+import { expectLogic } from 'kea-test-utils'++import { resumeKeaLoadersErrors, silenceKeaLoadersErrors } from '~/initKea'+import { useMocks } from '~/mocks/jest'+import { initKeaTests } from '~/test/init'++import { makeFeedback, makeTraceResource } from './adapter/testFixtures'+import { traceFeedbackLogic } from './traceFeedbackLogic'+import { traceViewLogic } from './traceViewLogic'++const TRACE_URL = '/api/projects/:team_id/ai_observability/traces/:id/'+const EVALUATIONS_URL = '/api/projects/:team_id/ai_observability/traces/:id/evaluations/'+const FEEDBACK_URL = '/api/projects/:team_id/ai_observability/traces/:id/feedback/'++describe('traceFeedbackLogic', () => {+ let feedbackHints: (string | null)[] = []+ let traceGate: Promise<void> = Promise.resolve()+ let feedbackStatus = 200++ beforeEach(() => {+ feedbackHints = []+ traceGate = Promise.resolve()+ feedbackStatus = 200+ useMocks({+ get: {+ [TRACE_URL]: async () => {+ await traceGate+ return [200, makeTraceResource({ createdAt: '2026-09-01T10:15:00Z' })]+ },+ [EVALUATIONS_URL]: () => [200, { results: [] }],+ [FEEDBACK_URL]: ({ request }) => {+ feedbackHints.push(new URL(request.url).searchParams.get('timestamp_hint'))+ return feedbackStatus === 200 ? [200, makeFeedback()] : [feedbackStatus, { detail: 'nope' }]+ },+ },+ })+ initKeaTests()+ })++ afterEach(() => {+ resumeKeaLoadersErrors()+ })++ function mount(timestampHint: string | null): ReturnType<typeof traceFeedbackLogic.build> {+ traceViewLogic({ traceId: 'trace-1', timestampHint }).mount()+ const logic = traceFeedbackLogic({ traceId: 'trace-1', timestampHint })+ logic.mount()+ return logic+ }++ it('loads on mount with the link timestamp, before the trace arrives', async () => {+ traceGate = new Promise(() => {})+ const logic = mount('2026-08-31T00:00:00Z')++ await expectLogic(logic).toDispatchActions(['loadTraceFeedbackSuccess'])++ expect(feedbackHints).toEqual(['2026-08-31T00:00:00Z'])+ expect(logic.values.traceFeedback).toEqual(makeFeedback())+ })++ it('without a link timestamp, loads once the trace arrives with its timestamp', async () => {+ let releaseTrace = (): void => {}+ traceGate = new Promise((resolve) => {+ releaseTrace = resolve+ })+ const logic = mount(null)+ expect(logic.values.traceFeedbackLoading).toBe(false)++ releaseTrace()++ await expectLogic(logic).toDispatchActions(['loadTraceFeedbackSuccess'])+ expect(feedbackHints).toEqual(['2026-09-01T10:15:00Z'])+ })++ test.each([+ ['the link timestamp', '2026-08-31T00:00:00Z', '2026-08-31T00:00:00Z'],+ ["the trace's timestamp", null, '2026-09-01T10:15:00Z'],+ ])('marks a failed read, keeps no feedback, and retries with %s', async (_name, timestampHint, expectedHint) => {+ silenceKeaLoadersErrors()+ feedbackStatus = 500+ const logic = mount(timestampHint)++ await expectLogic(logic)+ .toDispatchActions(['loadTraceFeedbackFailure'])+ .toMatchValues({ traceFeedback: null, traceFeedbackFailed: true })++ feedbackStatus = 200+ await expectLogic(logic, () => logic.actions.retryTraceFeedback())+ .toDispatchActions(['loadTraceFeedbackSuccess'])+ .toMatchValues({ traceFeedback: makeFeedback(), traceFeedbackFailed: false })+ expect(feedbackHints).toEqual([expectedHint, expectedHint])+ })+})diff --git a/products/ai_observability/frontend/redesign/trace/traceFeedbackLogic.ts b/products/ai_observability/frontend/redesign/trace/traceFeedbackLogic.tsnew file mode 100644index 000000000000..9a432f5ea52c--- /dev/null+++ b/products/ai_observability/frontend/redesign/trace/traceFeedbackLogic.ts@@ -0,0 +1,118 @@+import { MakeLogicType, actions, afterMount, connect, kea, key, listeners, path, props, reducers } from 'kea'+import { loaders } from 'kea-loaders'++import { ApiConfig } from 'lib/api'++import { aiObservabilityTracesFeedbackRetrieve } from '../../generated/api'+import type { TraceFeedbackApi } from '../../generated/api.schemas'+import { encodeTraceIdSegment } from './traceIdSegment'+import { traceViewLogic } from './traceViewLogic'++export interface TraceFeedbackLogicProps {+ traceId: string+ timestampHint: string | null+}++// Generated by kea-typegen. Update if you're an agent, ignore if you're human.+export interface traceFeedbackLogicValues {+ createdAt: string | null // traceViewLogic+ traceFeedback: TraceFeedbackApi | null+ traceFeedbackFailed: boolean+ traceFeedbackLoading: boolean+}++// Generated by kea-typegen. Update if you're an agent, ignore if you're human.+export interface traceFeedbackLogicActions {+ loadTraceSuccess: (+ trace: import('../../generated/api.schemas').TraceApi,+ payload?: any+ ) => {+ payload?: any+ trace: import('../../generated/api.schemas').TraceApi+ } // traceViewLogic+ loadTraceFeedback: (timestampHint: string) => string+ loadTraceFeedbackFailure: (+ error: string,+ errorObject?: any+ ) => {+ error: string+ errorObject?: any+ }+ loadTraceFeedbackSuccess: (+ traceFeedback: TraceFeedbackApi,+ payload?: string+ ) => {+ traceFeedback: TraceFeedbackApi+ payload?: string+ }+ retryTraceFeedback: () => {+ value: true+ }+}++// Generated by kea-typegen. Update if you're an agent, ignore if you're human.+export interface traceFeedbackLogicMeta {+ key: string+}++export type traceFeedbackLogicType = MakeLogicType<+ traceFeedbackLogicValues,+ traceFeedbackLogicActions,+ TraceFeedbackLogicProps,+ traceFeedbackLogicMeta+>++export const traceFeedbackLogic = kea<traceFeedbackLogicType>([+ props({} as TraceFeedbackLogicProps),+ key((props) => props.traceId),+ path((key) => ['products', 'ai_observability', 'frontend', 'redesign', 'trace', 'traceFeedbackLogic', key]),+ connect((props: TraceFeedbackLogicProps) => ({+ values: [traceViewLogic({ traceId: props.traceId, timestampHint: props.timestampHint }), ['createdAt']],+ actions: [traceViewLogic({ traceId: props.traceId, timestampHint: props.timestampHint }), ['loadTraceSuccess']],+ })),+ actions({+ retryTraceFeedback: true,+ }),+ loaders(({ props }) => ({+ traceFeedback: [+ null as TraceFeedbackApi | null,+ {+ loadTraceFeedback: async (timestampHint: string): Promise<TraceFeedbackApi> =>+ await aiObservabilityTracesFeedbackRetrieve(+ String(ApiConfig.getCurrentProjectId()),+ encodeTraceIdSegment(props.traceId),+ { timestamp_hint: timestampHint }+ ),+ },+ ],+ })),+ reducers({+ traceFeedbackFailed: [+ false,+ {+ loadTraceFeedback: () => false,+ loadTraceFeedbackFailure: () => true,+ },+ ],+ }),+ listeners(({ actions, props, values }) => ({+ // Without a hint the backend reads ai_events only, so a trace past the ai_events retention would show no+ // feedback. Without a link timestamp, the read waits for the trace's own.+ loadTraceSuccess: ({ trace }) => {+ if (!props.timestampHint) {+ actions.loadTraceFeedback(trace.createdAt)+ }+ },+ retryTraceFeedback: () => {+ const timestampHint = props.timestampHint ?? values.createdAt+ if (timestampHint) {+ actions.loadTraceFeedback(timestampHint)+ }+ },+ })),+ afterMount(({ actions, props }) => {+ if (props.timestampHint) {+ actions.loadTraceFeedback(props.timestampHint)+ }+ }),+])diff --git a/products/ai_observability/frontend/redesign/trace/types.ts b/products/ai_observability/frontend/redesign/trace/types.tsindex c45339b484fd..d8fdd1129952 100644--- a/products/ai_observability/frontend/redesign/trace/types.ts+++ b/products/ai_observability/frontend/redesign/trace/types.ts@@ -1,5 +1,7 @@import type {TraceEvaluationResultOutcomeEnumApi,+ TraceFeedbackScoreApi,+ TraceFeedbackTextApi,TraceNodeApi,TraceNodeDetailApi,TraceNodeEvaluationRollupOutcomeEnumApi,@@ -8,7 +10,7 @@ import type {export type TraceNodeKind = TraceNodeApi['kind']-export type TraceMode = 'spans' | 'thread' | 'timeline' | 'summary'+export type TraceMode = 'spans' | 'thread' | 'timeline' | 'summary' | 'feedback'export type TraceViewChoice = 'new' | 'legacy'@@ -138,3 +140,38 @@ export type SummaryModeState =| { status: 'ready'; summary: TraceSummaryContentApi }| { status: 'failed'; message: string; retryable: boolean }| { status: 'error' }++/** Where a person opened the Feedback mode from, other than its tab. */+export type FeedbackEntry = 'chip' | 'step'++export interface FeedbackStep {+ id: string+ name: string+}++/**+ * `step` is null for feedback on the whole trace, and for a step the tree does not hold. `focused` marks the entries+ * of the step the Feedback mode was opened from.+ */+export interface FeedbackPlacement {+ step: FeedbackStep | null+ focused: boolean+}++export type FeedbackScoreRow = TraceFeedbackScoreApi & FeedbackPlacement++export type FeedbackResponseItem = TraceFeedbackTextApi & FeedbackPlacement++export type FeedbackModeState =+ | { status: 'loading' }+ | { status: 'error' }+ | { status: 'ready'; scores: FeedbackScoreRow[]; responses: FeedbackResponseItem[] }++export interface FeedbackChipData {+ total: number+}++export interface StepFeedback {+ scores: TraceFeedbackScoreApi[]+ textCount: number+}diff --git a/services/mcp/src/api/generated.ts b/services/mcp/src/api/generated.tsindex 059d0b097d96..022a9a062b05 100644--- a/services/mcp/src/api/generated.ts+++ b/services/mcp/src/api/generated.ts@@ -121512,6 +121512,38 @@ export namespace Schemas {summary: TraceEvaluationSummary;}+ export interface TraceFeedbackScore {+ id: string;+ name: string | null;+ /** The score as text: a string as sent, any other value as compact JSON, such as 0, false or 4.5. */+ value: string;+ /** The tree node the score targets: the step's event uuid, or the trace id for a trace-level score. */+ nodeId: string;+ timestamp: string;+ }++ export interface TraceFeedbackText {+ kind: 'text';+ id: string;+ text: string;+ /** The tree node the feedback targets: the step's event uuid, or the trace id for trace-level feedback. */+ nodeId: string;+ timestamp: string;+ }++ export interface TraceFeedbackSummary {+ /** Scores plus responses. */+ total: number;+ }++ export interface TraceFeedback {+ /** Oldest first. */+ scores: TraceFeedbackScore[];+ /** What users said, oldest first. */+ responses: TraceFeedbackText[];+ summary: TraceFeedbackSummary;+ }+export interface TraceNodeMetadata {provider: string | null;temperature: number | null;@@ -130023,6 +130055,13 @@ export namespace Schemas {timestamp_hint?: string;};+ export type AiObservabilityTracesFeedbackRetrieveParams = {+ /**+ * When the trace happened, as carried by links into it. Lets a trace older than the AI events retention load from the shared events table.+ */+ timestamp_hint?: string;+ };+export type AiObservabilityTracesNodesRetrieveParams = {/*** When the trace happened, as carried by links into it. Lets a trace older than the AI events retention load from the shared events table.