Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(managed-warehouse): pass the org to the hogtower database-name check (#125015)

Eric Duonge77fda79696c
diff --git a/products/managed_warehouse/backend/presentation/hogtower.py b/products/managed_warehouse/backend/presentation/hogtower.py
index eafc112008d4..d3c0993792e9 100644
--- a/products/managed_warehouse/backend/presentation/hogtower.py
+++ b/products/managed_warehouse/backend/presentation/hogtower.py
@@ -218,11 +218,16 @@ def _reset_password(call: _Call) -> TranslatedResponse:
def _check_name(call: _Call) -> TranslatedResponse:
- """v1 GET /database-name/check?name= -> v2 GET /database-names/:name."""
+ """v1 GET /database-name/check?name= -> v2 GET /database-names/:name?org_id=.
+
+ hogtower reserves a name for the org whose warehouse carried it, and without org_id it
+ answers for a new org: the asking org's own earlier names would read as taken.
+ """
name = (call.params or {}).get("name")
if not name:
return _bad_request("name query parameter is required")
- resp = call.send("GET", f"/database-names/{quote(str(name), safe='')}")
+ params = {"org_id": call.org_id} if call.org_id else None
+ resp = call.send("GET", f"/database-names/{quote(str(name), safe='')}", params=params)
if resp.ok and isinstance(resp.body, dict) and not resp.body.get("reason"):
# v1 omits an empty reason.
resp.body.pop("reason", None)
diff --git a/products/managed_warehouse/backend/tests/test_hogtower.py b/products/managed_warehouse/backend/tests/test_hogtower.py
index e01a1033ae0c..5fae196c2776 100644
--- a/products/managed_warehouse/backend/tests/test_hogtower.py
+++ b/products/managed_warehouse/backend/tests/test_hogtower.py
@@ -294,6 +294,16 @@ class TestWarehouseRoutes:
assert (out.status_code, out.json()) == (200, {"name": "acme", "available": True})
+ @_routes({("GET", "/database-names/acme"): (200, {"name": "acme", "available": True, "reason": ""})})
+ @pytest.mark.parametrize("org_id, params", [(ORG, {"org_id": ORG}), ("", None)])
+ def test_check_name_asks_for_the_calling_org(
+ self, fake: FakeHogtower, org_id: str, params: dict[str, str] | None
+ ) -> None:
+ # hogtower treats a name the org's own warehouses carried as free only when told the org.
+ hogtower.request("GET", org_id, "database-name/check", params={"name": "acme"})
+
+ assert fake.calls[0]["params"] == params
+
@_routes(
{
("GET", f"{W}/monitoring/snapshot"): (200, {"sessions": 1}),
@@ -507,6 +517,7 @@ class TestViewsUseHogtower:
resp = managed_warehouse.check_name(ORG, "acme")
assert (resp.status_code, resp.data) == (200, {"name": "acme", "available": False})
+ assert fake.calls[0]["params"] == {"org_id": ORG}
@_routes(
{