Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(inbox): distinguish manual resolutions from dismissals (#117669)

Georgiy Tarasove8ce9c48e007
diff --git a/docs/internal/inbox-ranking-training.md b/docs/internal/inbox-ranking-training.md
index ca15f9d4e04b..00fff397c559 100644
--- a/docs/internal/inbox-ranking-training.md
+++ b/docs/internal/inbox-ranking-training.md
@@ -13,6 +13,7 @@ The label comes from the snapshot `horizon_days` later, including outcomes alrea
The families train only the heads the inbox reads: `open`, `action` and `fixed`.
The dataset still snapshots the label columns of other outcomes, so a head can come back without a labels backfill.
+Manual resolutions with reason `no_action_needed` count as reasoned resolutions for the `action` head but do not count toward the `fixed` head. They record that the report was accepted without claiming an implementation or a PR merge.
The examples asset records `reports_missing_birth_snapshot` for observed reports born inside the lookback whose birth-day partition is missing.
These reports produce no birth-grain example; reports born before the lookback do not contribute to this count.
diff --git a/docs/internal/signals-pr-lifecycle.md b/docs/internal/signals-pr-lifecycle.md
index 93155d6b22c8..66114896818c 100644
--- a/docs/internal/signals-pr-lifecycle.md
+++ b/docs/internal/signals-pr-lifecycle.md
@@ -3,6 +3,9 @@
A report completes after all linked implementation PRs are closed or merged.
At least one merged PR resolves the report; otherwise all closed PRs suppress it.
+A person can resolve a report by recording a manual implementation or a useful finding that needs no action. Feedback from the state API, Slack, PR closures, report merges, refunds, and plan rollups saves its verdict so the activity log distinguishes resolutions from dismissals even after later state changes. Feedback predating recorded verdicts uses a neutral activity label.
+The `no_action_needed` reason requires a resolved state. It leaves the report resolved, cancels its open follow-up checks, and is excluded from fixed outcomes in inbox ranking. Manual resolution closes an open implementation PR; the resulting GitHub close event preserves the resolved report status.
+
Monitoring means implementation is complete and outcome verification is pending. Resolved means the report is finished. The organization-level `signals-report-monitoring` gate requires explicit enablement, including in local development, and treats missing definitions or evaluation failures as disabled.
A Monitoring period begins with an explicit, timezone-aware implementation-complete timestamp supplied by the server. Merge-driven entry can use the linked PR's recorded `merged_at`, even when its webhook arrives later. The lifecycle never substitutes receipt time for a missing implementation timestamp. Repeated entry preserves the original period; archive and restore preserve it too. Reopening implementation clears the start so a later implementation creates a new period. Resolving after verification keeps the implementation timestamp for history.
diff --git a/frontend/snapshots.yml b/frontend/snapshots.yml
index aa92fbb883d0..54997972c0ed 100644
--- a/frontend/snapshots.yml
+++ b/frontend/snapshots.yml
@@ -11639,9 +11639,9 @@ snapshots:
scenes-app-inbox-focused-setup--treatment-reminder--light:
hash: v1.k794b7964.41b6bcc6d2de7d68b9bf72f1a3a248c326c44dea7905d7bcc1161ad09526d7e9.4E0B-L1wRoXtjDuhdRe2-x8CwfacDBMUa4hrUNBQbig
scenes-app-inbox-hotkeyradio--with-selection--dark:
- hash: v1.k794b7964.ee23fd931ed2324fdc42cbb44bb06176f40e1e47d5c03f9118ccc0f5f013201b.BmJiKZm5EO6qY8tSt5oSll_wmMMWh7IJ0dqN_bSQwa8
+ hash: v1.k794b7964.096221ba2a8740bc3f146596ab7d2e9576a9634b42608a196af46696de44024b.Aa_uyyUpzKzR72cUKsxLQJvhEiP0VxyLDoYjQgAa-mo
scenes-app-inbox-hotkeyradio--with-selection--light:
- hash: v1.k794b7964.3e50641442cc87cebfb5e0380042c05c0e5f15e238011e5aab24f8e69da5ea8e.IarzlyKga2lc-4CZ8UpBjuU1D_75I4SRnyKDESA9drk
+ hash: v1.k794b7964.b33f3d0a7456ea8e8dc412a08edd39d375f5cbfe508986fcc3add5190ccf2841.34SlHTQlR87Vqw5S3O9_k7v8sXrshNONFUqpF1Z97X0
scenes-app-inbox-implementbutton--choices--dark:
hash: v1.k794b7964.04e3f5a9e20f0032cff25e7878e16328871b41813d2a4e3064e731f91d3b876c.hVFY_MWjWZDX4fr9y2vacAy3wHZuNHwp5cYjveu_KfE
scenes-app-inbox-implementbutton--choices--light:
@@ -14902,6 +14902,10 @@ snapshots:
hash: v1.k794b7964.f723b2160bdf85cd5a827fa3dac4c281d75950f47555cdef7fc01f2ef689dfc6.wAOg7AG2Pf4mYO8EjKdD8lFlC1Ulv4MhkXIEMkzfCrg
scenes-app-signals-artefactloglist--replacement-lifecycle--light:
hash: v1.k794b7964.bb6f3f49907d13832cfad4b4c2c5ca3793bb4b29ab9bfcdda58a3abb848996a6.IjmVg1UPLdiV6r2dZcxKXAqYdiY6qBiuRiVeIqhd_hY
+ scenes-app-signals-artefactloglist--report-verdicts--dark:
+ hash: v1.k794b7964.e83b5beef6e337264ba02e44e08dec0b89ae0b055f58462e75f628682efb45cb.27b8MBKf1ZGxDx_4njLGUb6cqLKeIjuutlNiHJpVHig
+ scenes-app-signals-artefactloglist--report-verdicts--light:
+ hash: v1.k794b7964.2700c0aee71780b7938fdf212bb2d9f6010a0781da41c3d7bb9b5ad647d14f97.op16fkIw6utBe_-1aQLa3cCPSI395xX649Lc0OtOMUA
scenes-app-signals-artefactloglist--revision-limit--dark:
hash: v1.k794b7964.d9e475caa06b8c102d144f5a714e26addf9fdfe71d0b5008a4d09448142d60d7.KrLa7tfvjyW7kx7jRx7f8a2uctJrVoOP47m2TBccgrc
scenes-app-signals-artefactloglist--revision-limit--light:
diff --git a/frontend/src/lib/lemon-ui/LemonDialog/LemonDialog.test.tsx b/frontend/src/lib/lemon-ui/LemonDialog/LemonDialog.test.tsx
index 42a14e3c26f7..bb481101bd0a 100644
--- a/frontend/src/lib/lemon-ui/LemonDialog/LemonDialog.test.tsx
+++ b/frontend/src/lib/lemon-ui/LemonDialog/LemonDialog.test.tsx
@@ -1,6 +1,6 @@
import '@testing-library/jest-dom'
-import { cleanup, render, screen, waitFor, waitForElementToBeRemoved } from '@testing-library/react'
+import { act, cleanup, render, screen, waitFor, waitForElementToBeRemoved } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import posthog from 'posthog-js'
@@ -10,7 +10,7 @@ import { LemonInput } from 'lib/lemon-ui/LemonInput/LemonInput'
import { initKeaTests } from '~/test/init'
-import { LemonFormDialog } from './LemonDialog'
+import { LemonDialog, LemonFormDialog } from './LemonDialog'
describe('LemonFormDialog', () => {
let captureException: jest.SpyInstance
@@ -95,4 +95,21 @@ describe('LemonFormDialog', () => {
expect(onSubmit).toHaveBeenCalled()
expect(captureException).not.toHaveBeenCalled()
})
+
+ it.each(['Cancel', 'Submit'])('calls the imperative form close callback after %s', async (button) => {
+ const onAfterClose = jest.fn()
+ act(() => {
+ LemonDialog.openForm({
+ title: 'Test dialog',
+ initialValues: {},
+ onSubmit: jest.fn(),
+ onAfterClose,
+ })
+ })
+
+ await userEvent.click(screen.getByText(button))
+
+ await waitFor(() => expect(onAfterClose).toHaveBeenCalledTimes(1))
+ expect(screen.queryByText('Test dialog')).not.toBeInTheDocument()
+ })
})
diff --git a/frontend/src/scenes/project-homepage/today/todayVerdictLogic.test.ts b/frontend/src/scenes/project-homepage/today/todayVerdictLogic.test.ts
index b72080433d8f..f72e5d3134b3 100644
--- a/frontend/src/scenes/project-homepage/today/todayVerdictLogic.test.ts
+++ b/frontend/src/scenes/project-homepage/today/todayVerdictLogic.test.ts
@@ -1,17 +1,66 @@
+import { waitFor } from '@testing-library/react'
import { expectLogic } from 'kea-test-utils'
import { useMocks } from '~/mocks/jest'
import { initKeaTests } from '~/test/init'
+import { openDismissReportDialog } from 'products/signals/frontend/inbox/components/shell/DismissReportDialog'
+import { openResolveReportDialog } from 'products/signals/frontend/inbox/components/shell/ResolveReportDialog'
+
import { todayVerdictLogic } from './todayVerdictLogic'
+jest.mock('products/signals/frontend/inbox/components/shell/ResolveReportDialog', () => ({
+ openResolveReportDialog: jest.fn(),
+}))
+jest.mock('products/signals/frontend/inbox/components/shell/DismissReportDialog', () => ({
+ openDismissReportDialog: jest.fn(),
+}))
+
describe('todayVerdictLogic', () => {
+ beforeEach(() => {
+ jest.clearAllMocks()
+ })
+
+ it.each(['resolve', 'dismiss'] as const)('opens one %s dialog per report until it closes', (verdict) => {
+ initKeaTests()
+ const logic = todayVerdictLogic()
+ logic.mount()
+ const target = { reportId: 'a', title: 'Signup form rejects emails', hasOpenPullRequest: false }
+ const openDialog = verdict === 'resolve' ? openResolveReportDialog : openDismissReportDialog
+ const otherDialog = verdict === 'resolve' ? openDismissReportDialog : openResolveReportDialog
+
+ logic.actions.requestReportVerdict(target, verdict, 'briefing')
+ logic.actions.requestReportVerdict(target, verdict, 'briefing')
+ logic.actions.requestReportVerdict(target, verdict === 'resolve' ? 'dismiss' : 'resolve', 'report_page')
+ expect(openDialog).toHaveBeenCalledTimes(1)
+ expect(otherDialog).not.toHaveBeenCalled()
+
+ logic.actions.requestReportVerdict({ ...target, reportId: 'b' }, verdict, 'briefing')
+ expect(openDialog).toHaveBeenCalledTimes(2)
+
+ jest.mocked(openDialog).mock.calls[0][0].onAfterClose?.()
+ logic.actions.requestReportVerdict(target, verdict, 'briefing')
+ expect(openDialog).toHaveBeenCalledTimes(3)
+ })
+
it.each([
['keeps a verdict the API accepts', 200, { a: 'done' }],
['takes back a verdict the API refuses', 409, {}],
])('%s', async (_, status, finalOverrides) => {
+ const stateBodies: unknown[] = []
+ let releaseResponse: () => void = () => undefined
+ const responseReady = new Promise<void>((resolve) => {
+ releaseResponse = resolve
+ })
+ let responseStatus = status
useMocks({
- post: { '/api/projects/:team_id/signals/reports/:id/state/': () => [status, { detail: 'Refused.' }] },
+ post: {
+ '/api/projects/:team_id/signals/reports/:id/state/': async ({ request }) => {
+ stateBodies.push(await request.json())
+ await responseReady
+ return [responseStatus, { detail: 'Refused.' }]
+ },
+ },
})
initKeaTests()
const logic = todayVerdictLogic()
@@ -22,8 +71,30 @@ describe('todayVerdictLogic', () => {
'resolve',
'briefing'
)
- expect(logic.values.reportStateOverrides).toEqual({ a: 'done' })
+ expect(logic.values.reportStateOverrides).toEqual({})
+ expect(stateBodies).toEqual([])
+ const dialog = jest.mocked(openResolveReportDialog).mock.calls.at(-1)![0]
+ const submitted = Promise.resolve(dialog.onConfirm({ reason: 'no_action_needed', note: 'Reviewed' })).catch(
+ () => undefined
+ )
+ const duplicate = Promise.resolve(dialog.onConfirm({ reason: 'no_action_needed', note: 'Reviewed' })).catch(
+ () => undefined
+ )
+ await waitFor(() => expect(stateBodies).toHaveLength(1))
+ releaseResponse()
await expectLogic(logic).toFinishAllListeners().toMatchValues({ reportStateOverrides: finalOverrides })
+ await Promise.all([submitted, duplicate])
+ expect(stateBodies).toEqual([
+ { state: 'resolved', dismissal_reason: 'no_action_needed', dismissal_note: 'Reviewed' },
+ ])
+
+ responseStatus = 200
+ const repeated = Promise.resolve(dialog.onConfirm({ reason: 'no_action_needed', note: 'Reviewed' }))
+ await expectLogic(logic)
+ .toFinishAllListeners()
+ .toMatchValues({ reportStateOverrides: { a: 'done' } })
+ await repeated
+ expect(stateBodies).toHaveLength(status === 200 ? 1 : 2)
})
})
diff --git a/frontend/src/scenes/project-homepage/today/todayVerdictLogic.ts b/frontend/src/scenes/project-homepage/today/todayVerdictLogic.ts
index e2069385c3cd..5ad054fc6594 100644
--- a/frontend/src/scenes/project-homepage/today/todayVerdictLogic.ts
+++ b/frontend/src/scenes/project-homepage/today/todayVerdictLogic.ts
@@ -2,7 +2,6 @@ import { MakeLogicType, actions, connect, kea, listeners, path, reducers } from
import posthog from 'posthog-js'
import { ApiError } from 'lib/api'
-import { LemonDialog } from 'lib/lemon-ui/LemonDialog'
import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'
import { teamLogic } from 'scenes/teamLogic'
@@ -38,10 +37,6 @@ interface TodayReportVerdictCopy {
success: string
successClosingPullRequest: string
failure: string
- confirmTitle: string
- confirmLabel: string
- reasonTitle: string
- reasonDescription: string
}
const VERDICTS: Record<TodayReportVerdict, TodayReportVerdictCopy> = {
@@ -51,10 +46,6 @@ const VERDICTS: Record<TodayReportVerdict, TodayReportVerdictCopy> = {
success: 'Report resolved',
successClosingPullRequest: 'Report resolved. Its pull request is closing.',
failure: 'Couldn’t resolve the report. Try again, or resolve it from the Inbox.',
- confirmTitle: 'Resolve this report?',
- confirmLabel: 'Resolve and close PR',
- reasonTitle: 'Why did you resolve this report?',
- reasonDescription: 'The reason is saved on the report.',
},
dismiss: {
apiState: 'suppressed',
@@ -62,11 +53,6 @@ const VERDICTS: Record<TodayReportVerdict, TodayReportVerdictCopy> = {
success: 'Report dismissed',
successClosingPullRequest: 'Report dismissed. Its pull request is closing.',
failure: 'Couldn’t dismiss the report. Try again, or dismiss it from the Inbox.',
- confirmTitle: 'Dismiss this report?',
- confirmLabel: 'Dismiss and close PR',
- reasonTitle: 'Why did you dismiss this report?',
- reasonDescription:
- 'The reason is saved on the report. The agent that filed it reads your note on its next run.',
},
}
@@ -74,17 +60,11 @@ const VERDICTS: Record<TodayReportVerdict, TodayReportVerdictCopy> = {
export interface todayVerdictLogicValues {
currentProjectId: number | string // teamLogic
reportStateOverrides: Record<string, TodayReportState>
+ reportVerdictDialogsOpen: Record<string, boolean>
}
// Generated by kea-typegen. Update if you're an agent, ignore if you're human.
export interface todayVerdictLogicActions {
- addReportVerdictReason: (
- target: TodayReportVerdictTarget,
- verdict: TodayReportVerdict
- ) => {
- target: TodayReportVerdictTarget
- verdict: TodayReportVerdict
- }
requestReportVerdict: (
target: TodayReportVerdictTarget,
verdict: TodayReportVerdict,
@@ -97,12 +77,23 @@ export interface todayVerdictLogicActions {
setReportVerdict: (
target: TodayReportVerdictTarget,
verdict: TodayReportVerdict,
- surface: TodayReportVerdictSurface
+ surface: TodayReportVerdictSurface,
+ feedback?: Omit<SignalReportStateRequestApi, 'state'>,
+ onComplete?: (error?: unknown) => void
) => {
+ feedback: Omit<SignalReportStateRequestApi, 'state'> | undefined
+ onComplete: ((error?: unknown) => void) | undefined
surface: TodayReportVerdictSurface
target: TodayReportVerdictTarget
verdict: TodayReportVerdict
}
+ setReportVerdictDialogOpen: (
+ reportId: string,
+ open: boolean
+ ) => {
+ open: boolean
+ reportId: string
+ }
setReportVerdictFailure: (reportId: string) => {
reportId: string
}
@@ -116,6 +107,7 @@ export const todayVerdictLogic = kea<todayVerdictLogicType>([
values: [teamLogic, ['currentProjectId']],
})),
actions({
+ setReportVerdictDialogOpen: (reportId: string, open: boolean) => ({ reportId, open }),
requestReportVerdict: (
target: TodayReportVerdictTarget,
verdict: TodayReportVerdict,
@@ -124,15 +116,25 @@ export const todayVerdictLogic = kea<todayVerdictLogicType>([
setReportVerdict: (
target: TodayReportVerdictTarget,
verdict: TodayReportVerdict,
- surface: TodayReportVerdictSurface
- ) => ({ target, verdict, surface }),
+ surface: TodayReportVerdictSurface,
+ feedback?: Omit<SignalReportStateRequestApi, 'state'>,
+ onComplete?: (error?: unknown) => void
+ ) => ({ target, verdict, surface, feedback, onComplete }),
setReportVerdictFailure: (reportId: string) => ({ reportId }),
- addReportVerdictReason: (target: TodayReportVerdictTarget, verdict: TodayReportVerdict) => ({
- target,
- verdict,
- }),
}),
reducers({
+ reportVerdictDialogsOpen: [
+ {} as Record<string, boolean>,
+ {
+ setReportVerdictDialogOpen: (dialogs, { reportId, open }) => {
+ if (open) {
+ return { ...dialogs, [reportId]: true }
+ }
+ const { [reportId]: _, ...rest } = dialogs
+ return rest
+ },
+ },
+ ],
// A verdict shows at once on the home and the report page. The next report load
// gives the same state from the server, and a failed request takes the verdict back.
reportStateOverrides: [
@@ -151,34 +153,62 @@ export const todayVerdictLogic = kea<todayVerdictLogicType>([
}),
listeners(({ actions, values }) => ({
requestReportVerdict: ({ target, verdict, surface }) => {
- if (values.reportStateOverrides[target.reportId]) {
+ if (values.reportStateOverrides[target.reportId] || values.reportVerdictDialogsOpen[target.reportId]) {
return
}
- if (!target.hasOpenPullRequest) {
- actions.setReportVerdict(target, verdict, surface)
- return
+ actions.setReportVerdictDialogOpen(target.reportId, true)
+ const onAfterClose = (): void => actions.setReportVerdictDialogOpen(target.reportId, false)
+ let submission: Promise<void> | undefined
+ const saveVerdict = (feedback: Omit<SignalReportStateRequestApi, 'state'>): Promise<void> => {
+ if (!submission) {
+ submission = new Promise<void>((resolve, reject) => {
+ actions.setReportVerdict(target, verdict, surface, feedback, (error) => {
+ if (error) {
+ reject(error)
+ } else {
+ resolve()
+ }
+ })
+ }).catch((error) => {
+ submission = undefined
+ throw error
+ })
+ }
+ return submission
+ }
+ if (verdict === 'resolve') {
+ openResolveReportDialog({
+ reportTitle: target.title,
+ hasOpenPr: target.hasOpenPullRequest,
+ submitDataAttr: 'today-report-resolve-confirm',
+ onAfterClose,
+ onConfirm: ({ reason, note }) =>
+ saveVerdict({
+ dismissal_reason: reason,
+ ...(note ? { dismissal_note: note } : {}),
+ }),
+ })
+ } else {
+ openDismissReportDialog({
+ reportTitle: target.title,
+ hasOpenPr: target.hasOpenPullRequest,
+ submitDataAttr: 'today-report-dismiss-confirm',
+ onAfterClose,
+ onConfirm: (dismissal) => saveVerdict(suppressDismissalPayload(dismissal)),
+ })
}
- const copy = VERDICTS[verdict]
- LemonDialog.open({
- title: copy.confirmTitle,
- description: 'This also closes the open pull request for this report.',
- primaryButton: {
- children: copy.confirmLabel,
- onClick: () => actions.setReportVerdict(target, verdict, surface),
- 'data-attr': `today-report-${verdict}-confirm`,
- },
- secondaryButton: { children: 'Cancel' },
- })
},
- setReportVerdict: async ({ target, verdict, surface }) => {
+ setReportVerdict: async ({ target, verdict, surface, feedback, onComplete }) => {
const copy = VERDICTS[verdict]
try {
await signalsReportsStateCreate(String(values.currentProjectId), target.reportId, {
+ ...feedback,
state: copy.apiState,
})
} catch (error) {
actions.setReportVerdictFailure(target.reportId)
lemonToast.error((error instanceof ApiError && error.detail) || copy.failure)
+ onComplete?.(error)
return
}
// pinned: analytics event name and properties. Renaming them breaks dashboards.
@@ -192,58 +222,21 @@ export const todayVerdictLogic = kea<todayVerdictLogicType>([
reportId: target.reportId,
actionType: verdict,
todaySurface: surface,
- extra: { closed_pull_request: target.hasOpenPullRequest },
- })
- // A reason is optional, so the verdict is one click and the reason is one more.
- lemonToast.success(target.hasOpenPullRequest ? copy.successClosingPullRequest : copy.success, {
- button: { label: 'Add a reason', action: () => actions.addReportVerdictReason(target, verdict) },
+ extra: {
+ closed_pull_request: target.hasOpenPullRequest,
+ ...(feedback?.dismissal_reason ? { dismissal_reason: feedback.dismissal_reason } : {}),
+ },
})
- },
- addReportVerdictReason: ({ target, verdict }) => {
- const copy = VERDICTS[verdict]
- const dialogCopy = {
- title: copy.reasonTitle,
- description: copy.reasonDescription,
- submitLabel: 'Save reason',
- }
- // The state API takes the verdict the report already has and only saves the reason with it.
- const saveReason = async (body: SignalReportStateRequestApi): Promise<void> => {
- try {
- await signalsReportsStateCreate(String(values.currentProjectId), target.reportId, body)
- } catch (error) {
- lemonToast.error(
- (error instanceof ApiError && error.detail) || 'Couldn’t save the reason. Try again.'
- )
- // The dialog stays open, so the reason and the note are kept for the next try.
- throw error
- }
+ if (feedback?.dismissal_reason) {
// pinned: analytics event name and properties. Renaming them breaks dashboards.
posthog.capture('today report reason added', {
verdict,
- reason: body.dismissal_reason,
- has_note: !!body.dismissal_note,
- })
- lemonToast.success('Reason saved')
- }
- if (verdict === 'resolve') {
- openResolveReportDialog({
- reportTitle: target.title,
- copy: dialogCopy,
- onConfirm: ({ reason, note }) =>
- saveReason({
- state: copy.apiState,
- dismissal_reason: reason,
- ...(note ? { dismissal_note: note } : {}),
- }),
- })
- } else {
- openDismissReportDialog({
- reportTitle: target.title,
- copy: dialogCopy,
- onConfirm: (dismissal) =>
- saveReason({ state: copy.apiState, ...suppressDismissalPayload(dismissal) }),
+ reason: feedback.dismissal_reason,
+ has_note: !!feedback.dismissal_note,
})
}
+ lemonToast.success(target.hasOpenPullRequest ? copy.successClosingPullRequest : copy.success)
+ onComplete?.()
},
})),
])
diff --git a/products/signals/backend/artefact_schemas.py b/products/signals/backend/artefact_schemas.py
index e977bb852920..c06196f73a58 100644
--- a/products/signals/backend/artefact_schemas.py
+++ b/products/signals/backend/artefact_schemas.py
@@ -490,12 +490,16 @@ DISMISSAL_IDENTITY_MAX_LENGTH = 128
class Dismissal(BaseModel):
- """Content schema for a `dismissal` artefact: feedback captured when a report is dismissed/snoozed.
+ """Feedback records retain their verdict because the report can change state later.
The user fields predate row-level attribution and are kept for compatibility with existing
rows and readers; new rows also carry attribution on the artefact row itself.
"""
+ state: Literal["resolved", "suppressed", "potential"] | None = Field(
+ default=None,
+ description="Report verdict when this feedback was recorded. Null on legacy feedback with no recorded verdict.",
+ )
reason: str | None = Field(
default=None, max_length=DISMISSAL_REASON_MAX_LENGTH, description="Caller-owned dismissal reason code."
)
diff --git a/products/signals/backend/plan_rollup.py b/products/signals/backend/plan_rollup.py
index 92df1c103662..27d4f33d0aec 100644
--- a/products/signals/backend/plan_rollup.py
+++ b/products/signals/backend/plan_rollup.py
@@ -156,7 +156,7 @@ def _close_parent(
SignalReportArtefact.append_dismissal(
team_id=parent.team_id,
report_id=str(parent.id),
- content=Dismissal(),
+ content=Dismissal(state="suppressed"),
attribution=ArtefactAttribution.system(),
)
return True
diff --git a/products/signals/backend/report_actions.py b/products/signals/backend/report_actions.py
index 0053fa6e1cd3..a049aff69d03 100644
--- a/products/signals/backend/report_actions.py
+++ b/products/signals/backend/report_actions.py
@@ -59,7 +59,7 @@ def suppress_report_from_slack(
SignalReportArtefact.append_dismissal(
team_id=team_id,
report_id=str(report.id),
- content=Dismissal(reason="slack_dismiss", slack_user_id=slack_user_id),
+ content=Dismissal(state="suppressed", reason="slack_dismiss", slack_user_id=slack_user_id),
attribution=attribution,
)
# The linked implementation PR is closed by the post_save receiver on suppression or snooze
diff --git a/products/signals/backend/report_assignments.py b/products/signals/backend/report_assignments.py
index d7c2c52a3e8a..4c64ac8d3ff2 100644
--- a/products/signals/backend/report_assignments.py
+++ b/products/signals/backend/report_assignments.py
@@ -344,7 +344,7 @@ def _apply_pr_report_state(report: SignalReport, pr_state: str | None) -> None:
SignalReportArtefact.append_dismissal(
team_id=report.team_id,
report_id=str(report.id),
- content=Dismissal(),
+ content=Dismissal(state="suppressed"),
attribution=ArtefactAttribution.system(),
)
diff --git a/products/signals/backend/report_merge.py b/products/signals/backend/report_merge.py
index 73d6310b5150..74f6f81ba611 100644
--- a/products/signals/backend/report_merge.py
+++ b/products/signals/backend/report_merge.py
@@ -322,6 +322,7 @@ def _dismiss_as_merged(
team_id=source.team_id,
report_id=str(source.id),
content=Dismissal(
+ state="suppressed",
reason=MERGE_DISMISSAL_REASON,
note=f"{note} {reason}" if reason else note,
user_id=attribution.user_id,
diff --git a/products/signals/backend/test/test_dismissal_pr_close.py b/products/signals/backend/test/test_dismissal_pr_close.py
index 07edd6cc04a6..9120d06bff7e 100644
--- a/products/signals/backend/test/test_dismissal_pr_close.py
+++ b/products/signals/backend/test/test_dismissal_pr_close.py
@@ -203,6 +203,11 @@ class TestClosePrWhenReportDismissed(BaseTest):
report.refresh_from_db()
assert report.status == SignalReport.Status.SUPPRESSED
assert fixed_dismissal_at(report) is None
+ feedback = SignalReportArtefact.latest_content(
+ team_id=self.team.id, report_id=str(report.id), model=Dismissal
+ )
+ assert feedback is not None
+ assert feedback.state == "suppressed"
def test_unrelated_save_of_suppressed_report_does_not_enqueue(self):
report = self._create_report(report_status=SignalReport.Status.SUPPRESSED)
diff --git a/products/signals/backend/test/test_plan_rollup.py b/products/signals/backend/test/test_plan_rollup.py
index 16c8a674869c..dbee061e3be0 100644
--- a/products/signals/backend/test/test_plan_rollup.py
+++ b/products/signals/backend/test/test_plan_rollup.py
@@ -9,7 +9,7 @@ from django.utils import timezone
from parameterized import parameterized
-from products.signals.backend.artefact_schemas import PullRequestLink, ReportLink
+from products.signals.backend.artefact_schemas import Dismissal, PullRequestLink, ReportLink
from products.signals.backend.enums import ReportLinkKind, SignalSourceProduct
from products.signals.backend.models import (
ArtefactAttribution,
@@ -96,6 +96,12 @@ class TestPlanRollup(BaseTest):
parent.refresh_from_db()
assert parent.status == expected
+ if expected == SignalReport.Status.SUPPRESSED:
+ feedback = SignalReportArtefact.latest_content(
+ team_id=self.team.id, report_id=str(parent.id), model=Dismissal
+ )
+ assert feedback is not None
+ assert feedback.state == "suppressed"
def test_a_plan_stays_open_while_any_step_is(self):
parent = self._report("plan")
diff --git a/products/signals/backend/test/test_refunds.py b/products/signals/backend/test/test_refunds.py
index a209cf4586cb..31f58be876c7 100644
--- a/products/signals/backend/test/test_refunds.py
+++ b/products/signals/backend/test/test_refunds.py
@@ -105,6 +105,7 @@ class TestSignalReportRefundAPI(APIBaseTest):
dismissal = SignalReportArtefact.objects.get(report=report, type=SignalReportArtefact.ArtefactType.DISMISSAL)
content = json.loads(dismissal.content)
+ assert content["state"] == "suppressed"
assert content["reason"] == "refunded"
assert content["note"] == "does not fix the bug"
@@ -244,9 +245,8 @@ class TestSignalReportRefundAPI(APIBaseTest):
report.refresh_from_db()
assert report.status == expected_status
# The permanent marker lands regardless of whether the status changed.
- assert SignalReportArtefact.objects.filter(
- report=report, type=SignalReportArtefact.ArtefactType.DISMISSAL
- ).exists()
+ dismissal = SignalReportArtefact.objects.get(report=report, type=SignalReportArtefact.ArtefactType.DISMISSAL)
+ assert json.loads(dismissal.content)["state"] == expected_status
@time_machine.travel(_NOW, tick=False)
def test_invalid_reason_is_rejected(self, _flag):
diff --git a/products/signals/backend/test/test_report_checks.py b/products/signals/backend/test/test_report_checks.py
index ce8127e1238c..0e4dc1e9c66b 100644
--- a/products/signals/backend/test/test_report_checks.py
+++ b/products/signals/backend/test/test_report_checks.py
@@ -2977,6 +2977,25 @@ class TestPendingChecks(APIBaseTest):
assert check.status == check_status
assert check.measurement_start_at is None
+ @parameterized.expand(
+ [
+ ("fixed_outside_posthog", SignalReportCheck.Status.ACTIVE),
+ ("no_action_needed", SignalReportCheck.Status.CANCELLED),
+ ]
+ )
+ def test_manual_resolution_only_verifies_an_implemented_fix(self, reason: str, expected_status: str) -> None:
+ check = self._pending()
+ with self.captureOnCommitCallbacks(execute=True):
+ response = self.client.post(
+ f"/api/projects/{self.team.id}/signals/reports/{self.report.id}/state/",
+ {"state": "resolved", "dismissal_reason": reason},
+ )
+ assert response.status_code == status.HTTP_200_OK, response.json()
+ check.refresh_from_db()
+ self.report.refresh_from_db()
+ assert self.report.status == SignalReport.Status.RESOLVED
+ assert check.status == expected_status
+
def test_a_pending_check_is_never_due_while_its_report_is_unresolved(self) -> None:
self._pending()
diff --git a/products/signals/backend/test/test_signal_report_actions.py b/products/signals/backend/test/test_signal_report_actions.py
index 717ef5dea138..d58ec7bb5c78 100644
--- a/products/signals/backend/test/test_signal_report_actions.py
+++ b/products/signals/backend/test/test_signal_report_actions.py
@@ -1,4 +1,4 @@
-from posthog.test.base import APIBaseTest
+from posthog.test.base import APIBaseTest, BaseTest
from unittest.mock import MagicMock, patch
from django.apps import apps
@@ -10,7 +10,33 @@ from rest_framework import status
from posthog.models.personal_api_key import PersonalAPIKey, hash_key_value
from posthog.models.utils import generate_random_token_personal
-from products.signals.backend.models import SignalReport, SignalReportAction, SignalScoutConfig, SignalScoutRun
+from products.signals.backend.artefact_schemas import Dismissal
+from products.signals.backend.models import (
+ SignalReport,
+ SignalReportAction,
+ SignalReportArtefact,
+ SignalScoutConfig,
+ SignalScoutRun,
+)
+from products.signals.backend.report_actions import suppress_report_from_slack
+
+
+class TestSignalReportSlackActions(BaseTest):
+ def test_slack_dismissal_records_its_verdict_once(self) -> None:
+ report = SignalReport.objects.create(team=self.team, status=SignalReport.Status.READY, title="A report")
+
+ for _ in range(2):
+ assert suppress_report_from_slack(
+ self.team.id, str(report.id), slack_user_id="slack-user-1", user_id=self.user.id
+ )
+
+ report.refresh_from_db()
+ assert report.status == SignalReport.Status.SUPPRESSED
+ dismissal = SignalReportArtefact.objects.get(report=report, type=SignalReportArtefact.ArtefactType.DISMISSAL)
+ feedback = Dismissal.model_validate_json(dismissal.content)
+ assert feedback.state == "suppressed"
+ assert feedback.reason == "slack_dismiss"
+ assert feedback.slack_user_id == "slack-user-1"
class TestSignalReportViewedEndpoint(APIBaseTest):
diff --git a/products/signals/backend/test/test_signal_report_api.py b/products/signals/backend/test/test_signal_report_api.py
index d5134bf45f19..0ef2b66cbaa7 100644
--- a/products/signals/backend/test/test_signal_report_api.py
+++ b/products/signals/backend/test/test_signal_report_api.py
@@ -86,6 +86,7 @@ from products.signals.backend.test.report_metric_test_fixtures import trends_met
from products.signals.backend.throttles import ReportMetricRefreshThrottle
from products.signals.backend.views import (
PR_CI_STATUS_MAX_REPORTS,
+ SignalReportStateRequestSerializer,
SignalReportViewSet,
classify_report_list_client,
parse_pr_ci_status_report_ids,
@@ -139,6 +140,15 @@ def _seen_event(team: Team, name: str, *, days_ago: int) -> None:
)
+class TestSignalReportStateRequest(SimpleTestCase):
+ @parameterized.expand([("resolved", True), ("suppressed", False), ("potential", False)])
+ def test_no_action_needed_requires_resolution(self, target: str, valid: bool) -> None:
+ serializer = SignalReportStateRequestSerializer(data={"state": target, "dismissal_reason": "no_action_needed"})
+ assert serializer.is_valid() == valid
+ if not valid:
+ assert "dismissal_reason" in serializer.errors
+
+
class TestReportListClientClassification(SimpleTestCase):
@parameterized.expand(
[
@@ -3036,6 +3046,13 @@ class TestSignalReportSuppressionAPI(APIBaseTest):
"already_fixed",
"shipped a fix by hand",
),
+ (
+ "resolve_no_action_needed",
+ {"state": "resolved", "dismissal_reason": "no_action_needed", "dismissal_note": "Reviewed the finding"},
+ SignalReport.Status.RESOLVED,
+ "no_action_needed",
+ "Reviewed the finding",
+ ),
]
)
def test_state_transition_with_dismissal(self, _name, body, expected_final_status, expected_reason, expected_note):
@@ -3057,6 +3074,7 @@ class TestSignalReportSuppressionAPI(APIBaseTest):
)
assert len(artefacts) == 1
content = json.loads(artefacts[0].content)
+ assert content["state"] == body["state"]
assert content["reason"] == expected_reason
assert content["note"] == expected_note
assert content["user_id"] == self.user.id
@@ -3071,6 +3089,11 @@ class TestSignalReportSuppressionAPI(APIBaseTest):
"fixed_outside_posthog",
),
("resolve_pr_merged", {"state": "resolved", "dismissal_reason": "pr_merged"}, "pr_merged"),
+ (
+ "resolve_no_action_needed",
+ {"state": "resolved", "dismissal_reason": "no_action_needed"},
+ "no_action_needed",
+ ),
# A resolve carrying no feedback must not pick a reason up from anywhere.
("resolve_without_reason", {"state": "resolved"}, None),
]
@@ -3729,7 +3752,9 @@ class TestSignalReportMergeAPI(APIBaseTest):
"same support ticket",
)
dismissal = SignalReportArtefact.objects.get(report_id=source.id, type="dismissal")
- assert Dismissal.model_validate_json(dismissal.content).reason == MERGE_DISMISSAL_REASON
+ feedback = Dismissal.model_validate_json(dismissal.content)
+ assert feedback.reason == MERGE_DISMISSAL_REASON
+ assert feedback.state == "suppressed"
def test_merge_moves_the_pull_request_so_the_dismissal_leaves_it_open(self):
survivor = self._report()
diff --git a/products/signals/backend/views.py b/products/signals/backend/views.py
index edf18f3a7abf..2638fa849069 100644
--- a/products/signals/backend/views.py
+++ b/products/signals/backend/views.py
@@ -4,7 +4,7 @@ import uuid
from collections.abc import Callable, Iterable, Sequence
from datetime import UTC, timedelta
from functools import cached_property, partial
-from typing import Any, cast
+from typing import Any, Literal, cast
from django.conf import settings
from django.contrib.postgres.fields import ArrayField
@@ -696,6 +696,7 @@ SIGNAL_REPORT_DISMISSAL_REASON_CHOICES = [
("wontfix_intentional", "Won't fix - intentional behavior"),
("wontfix_irrelevant", "Won't fix - issue is real but insignificant"),
("fixed_outside_posthog", "Fixed outside PostHog"),
+ ("no_action_needed", "No action needed"),
("pr_merged", "PR was merged"),
("other", "Something else…"),
]
@@ -703,11 +704,12 @@ SIGNAL_REPORT_DISMISSAL_REASON_CHOICES = [
_DISMISSAL_REASON_HELP_TEXT = (
"Optional canonical reason code recorded with the transition. Must be one of: already_fixed, "
"report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, "
- "fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a "
+ "fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a "
"labelled chip rather than a raw code. When the work this report asked for is done, the honest "
"transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), "
"'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), "
- "or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing "
+ "or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with "
+ "state='resolved' when the report was useful but needs no implementation. A report that failed in processing "
"resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three "
"codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked "
"to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. "
@@ -813,6 +815,8 @@ class SignalReportStateRequestSerializer(serializers.Serializer):
return value
def validate(self, attrs: dict) -> dict:
+ if attrs.get("dismissal_reason") == "no_action_needed" and attrs.get("state") != SignalReportState.RESOLVED:
+ raise serializers.ValidationError({"dismissal_reason": "No action needed requires state 'resolved'."})
if (
attrs.get("state") == SignalReportState.POTENTIAL
and attrs.get("dismissal_reason") in FIXED_DISMISSAL_REASONS
@@ -3704,6 +3708,11 @@ class SignalReportViewSet(
writes_dismissal_feedback = target in ("suppressed", "potential", "resolved") and bool(
dismissal_reason or dismissal_note
)
+ feedback_state = (
+ None
+ if report.status == SignalReport.Status.SUPPRESSED and target == "potential"
+ else cast(Literal["resolved", "suppressed", "potential"], target)
+ )
if not already_holds_verdict:
try:
@@ -3767,6 +3776,7 @@ class SignalReportViewSet(
team_id=self.team.id,
report_id=str(report.id),
content=Dismissal(
+ state=feedback_state,
reason=dismissal_reason,
note=dismissal_note,
selected_repository=selected_repository,
@@ -3776,6 +3786,11 @@ class SignalReportViewSet(
),
attribution=self._request_attribution(),
)
+ if target_status == SignalReport.Status.RESOLVED and dismissal_reason == "no_action_needed":
+ for check in SignalReportCheck.objects.for_team(self.team.id).filter(
+ report_id=report.id, status__in=SignalReportCheck.OPEN_STATUSES
+ ):
+ cancel_check(check, reason="stopped_by_person", attribution=self._request_attribution())
if is_wrong_repo:
self._apply_wrong_repo_selection(report, corrected_repository)
# The wrong-repo path just wrote a new repo_selection artefact; drop the
@@ -4038,6 +4053,7 @@ class SignalReportViewSet(
team_id=self.team.id,
report_id=str(report.id),
content=Dismissal(
+ state="resolved" if resolved_via_merged_pr else "suppressed",
reason="refunded",
note=note or None,
user_id=user.id if user.is_authenticated else None,
diff --git a/products/signals/dags/inbox_ranking/common.py b/products/signals/dags/inbox_ranking/common.py
index 87dfbdee6ac9..5334b9fa00d2 100644
--- a/products/signals/dags/inbox_ranking/common.py
+++ b/products/signals/dags/inbox_ranking/common.py
@@ -38,8 +38,9 @@ LABELS_EPOCH = "2026-04-01T00:00:00+00:00"
# head predicts). already_fixed and wontfix_irrelevant are deliberately not here. Shared by the
# labels SQL (cumulative count) and the head definition.
WRONG_DISMISSAL_REASONS = ("analysis_wrong", "report_unclear", "wontfix_intentional")
-# The resolve button used as a dismissal: the report was resolved, but the problem was not fixed.
+# A report can be resolved without an implemented fix, so these reasons do not label a fix.
NOT_FIXED_RESOLUTION_REASONS = (
+ "no_action_needed",
"analysis_wrong",
"wontfix_intentional",
"wontfix_irrelevant",
diff --git a/products/signals/dags/inbox_ranking/tests/test_dataset.py b/products/signals/dags/inbox_ranking/tests/test_dataset.py
index a7ed4bebb658..02dee62dc33c 100644
--- a/products/signals/dags/inbox_ranking/tests/test_dataset.py
+++ b/products/signals/dags/inbox_ranking/tests/test_dataset.py
@@ -886,6 +886,8 @@ class TestStatusStream(ClickhouseTestMixin, BaseTest):
("reasonless_resolve", "ready", "resolved", None, 1),
("already_fixed_dismissal", "ready", "suppressed", "already_fixed", 1),
("analysis_wrong_resolve", "ready", "resolved", "analysis_wrong", 0),
+ ("no_action_needed_resolve", "ready", "resolved", "no_action_needed", 0),
+ ("manual_fix_resolve", "ready", "resolved", "fixed_outside_posthog", 1),
("other_dismissal", "ready", "suppressed", "other", 0),
]
)
diff --git a/products/signals/frontend/generated/api.schemas.ts b/products/signals/frontend/generated/api.schemas.ts
index bda495608c62..7686292e0d55 100644
--- a/products/signals/frontend/generated/api.schemas.ts
+++ b/products/signals/frontend/generated/api.schemas.ts
@@ -3179,6 +3179,7 @@ export const SignalReportStateEnumApi = {
* * `wontfix_intentional` - Won't fix - intentional behavior
* * `wontfix_irrelevant` - Won't fix - issue is real but insignificant
* * `fixed_outside_posthog` - Fixed outside PostHog
+ * * `no_action_needed` - No action needed
* * `pr_merged` - PR was merged
* * `other` - Something else…
*/
@@ -3192,6 +3193,7 @@ export const DismissalReasonEnumApi = {
WontfixIntentional: 'wontfix_intentional',
WontfixIrrelevant: 'wontfix_irrelevant',
FixedOutsidePosthog: 'fixed_outside_posthog',
+ NoActionNeeded: 'no_action_needed',
PrMerged: 'pr_merged',
Other: 'other',
} as const
@@ -3203,7 +3205,7 @@ export interface SignalReportStateRequestApi {
* * `potential` - potential
* * `resolved` - resolved */
state: SignalReportStateEnumApi
- /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
+ /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
*
* * `already_fixed` - Already fixed
* * `report_unclear` - Report is unclear to me
@@ -3212,6 +3214,7 @@ export interface SignalReportStateRequestApi {
* * `wontfix_intentional` - Won't fix - intentional behavior
* * `wontfix_irrelevant` - Won't fix - issue is real but insignificant
* * `fixed_outside_posthog` - Fixed outside PostHog
+ * * `no_action_needed` - No action needed
* * `pr_merged` - PR was merged
* * `other` - Something else… */
dismissal_reason?: DismissalReasonEnumApi
@@ -3747,7 +3750,7 @@ export interface SignalReportBulkStateRequestApi {
* * `potential` - potential
* * `resolved` - resolved */
state: SignalReportStateEnumApi
- /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
+ /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
*
* * `already_fixed` - Already fixed
* * `report_unclear` - Report is unclear to me
@@ -3756,6 +3759,7 @@ export interface SignalReportBulkStateRequestApi {
* * `wontfix_intentional` - Won't fix - intentional behavior
* * `wontfix_irrelevant` - Won't fix - issue is real but insignificant
* * `fixed_outside_posthog` - Fixed outside PostHog
+ * * `no_action_needed` - No action needed
* * `pr_merged` - PR was merged
* * `other` - Something else… */
dismissal_reason?: DismissalReasonEnumApi
diff --git a/products/signals/frontend/generated/api.zod.ts b/products/signals/frontend/generated/api.zod.ts
index 618f53deef2b..911ab7b2d541 100644
--- a/products/signals/frontend/generated/api.zod.ts
+++ b/products/signals/frontend/generated/api.zod.ts
@@ -835,15 +835,16 @@ export const SignalsReportsStateCreateBody = /* @__PURE__ */ zod.object({
'wontfix_intentional',
'wontfix_irrelevant',
'fixed_outside_posthog',
+ 'no_action_needed',
'pr_merged',
'other',
])
.describe(
- "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
)
.optional()
.describe(
- "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
),
dismissal_note: zod
.string()
@@ -1075,15 +1076,16 @@ export const SignalsReportsBulkStateCreateBody = /* @__PURE__ */ zod.object({
'wontfix_intentional',
'wontfix_irrelevant',
'fixed_outside_posthog',
+ 'no_action_needed',
'pr_merged',
'other',
])
.describe(
- "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
)
.optional()
.describe(
- "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
),
dismissal_note: zod
.string()
diff --git a/products/signals/frontend/inbox/components/cards/ReportContextMenu.test.tsx b/products/signals/frontend/inbox/components/cards/ReportContextMenu.test.tsx
index 4241638d7f7f..0c1bed5f111d 100644
--- a/products/signals/frontend/inbox/components/cards/ReportContextMenu.test.tsx
+++ b/products/signals/frontend/inbox/components/cards/ReportContextMenu.test.tsx
@@ -134,8 +134,8 @@ describe('ReportContextMenu', () => {
it.each([
{
submenu: 'Resolve',
- reason: 'PR was merged',
- body: { state: 'resolved', dismissal_reason: 'pr_merged' },
+ reason: 'No action needed',
+ body: { state: 'resolved', dismissal_reason: 'no_action_needed' },
},
{
submenu: 'Resolve',
diff --git a/products/signals/frontend/inbox/components/detail/ArtefactLogList.stories.tsx b/products/signals/frontend/inbox/components/detail/ArtefactLogList.stories.tsx
index 1bc7d4e2f1e7..bb243c94e006 100644
--- a/products/signals/frontend/inbox/components/detail/ArtefactLogList.stories.tsx
+++ b/products/signals/frontend/inbox/components/detail/ArtefactLogList.stories.tsx
@@ -423,3 +423,46 @@ export const MonitoringObservations: Story = {
),
],
}
+
+export const ReportVerdicts: Story = {
+ args: {
+ artefacts: [
+ {
+ id: 'resolved-manually',
+ type: 'dismissal',
+ created_at: '2026-09-17T09:00:00Z',
+ content: {
+ state: 'resolved',
+ reason: 'fixed_outside_posthog',
+ note: 'Implemented the change in the request handler.',
+ },
+ },
+ {
+ id: 'resolved-no-action',
+ type: 'dismissal',
+ created_at: '2026-09-17T08:00:00Z',
+ content: {
+ state: 'resolved',
+ reason: 'no_action_needed',
+ note: 'Useful context. No implementation is needed.',
+ },
+ },
+ {
+ id: 'dismissed',
+ type: 'dismissal',
+ created_at: '2026-09-17T07:00:00Z',
+ content: {
+ state: 'suppressed',
+ reason: 'analysis_wrong',
+ note: 'The finding describes an unreachable code path.',
+ },
+ },
+ {
+ id: 'legacy-feedback',
+ type: 'dismissal',
+ created_at: '2026-09-17T06:00:00Z',
+ content: { reason: 'already_fixed' },
+ },
+ ],
+ },
+}
diff --git a/products/signals/frontend/inbox/components/detail/ArtefactLogList.test.tsx b/products/signals/frontend/inbox/components/detail/ArtefactLogList.test.tsx
index 1eeb1c952e1a..2fc7fa89efb7 100644
--- a/products/signals/frontend/inbox/components/detail/ArtefactLogList.test.tsx
+++ b/products/signals/frontend/inbox/components/detail/ArtefactLogList.test.tsx
@@ -20,6 +20,18 @@ describe('ArtefactLogList', () => {
cleanup()
})
+ it.each([
+ ['resolved', 'already_fixed', 'Report resolved', 'Already fixed'],
+ ['resolved', 'no_action_needed', 'Report resolved', 'No action needed'],
+ ['suppressed', 'already_fixed', 'Report dismissed', 'Already fixed'],
+ ['potential', 'other', 'Report snoozed', 'Something else…'],
+ [undefined, 'already_fixed', 'Report feedback added', 'Already fixed'],
+ ])('labels feedback by its recorded verdict %s and reason %s', (state, reason, title, reasonLabel) => {
+ render(<ArtefactLogList reportId="report-1" artefacts={[makeArtefact({ state, reason }, 'dismissal')]} />)
+ expect(screen.getByText(title)).toBeInTheDocument()
+ expect(screen.getByText(reasonLabel)).toBeInTheDocument()
+ })
+
it.each([
['a replacement recommendation', true, undefined, 'Replacement recommended'],
['a kept PR', false, undefined, 'Still the right fix'],
diff --git a/products/signals/frontend/inbox/components/detail/ArtefactLogList.tsx b/products/signals/frontend/inbox/components/detail/ArtefactLogList.tsx
index cfb1a56b7ae1..0ff5110aacd7 100644
--- a/products/signals/frontend/inbox/components/detail/ArtefactLogList.tsx
+++ b/products/signals/frontend/inbox/components/detail/ArtefactLogList.tsx
@@ -2,6 +2,7 @@ import { type ComponentType, Fragment, useState } from 'react'
import {
IconActivity,
+ IconCheckCircle,
IconHide,
IconCode,
IconComment,
@@ -39,6 +40,7 @@ import type { SignalReportPullRequestApi } from 'products/signals/frontend/gener
import { INBOX_RANKING_SCORES, PRIORITY_TAG_TYPE, rankingScoreForHead } from '../../filterOptions'
import { SignalCard } from '../../SignalCard'
import { EnrichedReviewer, SignalReportActionability, SignalReportPriority, SignalReportArtefact } from '../../types'
+import { dismissalReasonLabel } from '../../utils/dismissalReasons'
import { SignalReportActionabilityBadge } from '../badges/SignalReportActionabilityBadge'
import { formatRankingLift, formatRankingProbability } from '../cards/rankingFormat'
import { RankingLiftBar } from '../cards/RankingLiftBar'
@@ -176,7 +178,7 @@ const ARTEFACT_MARKER: Record<string, ComponentType<{ className?: string }>> = {
}
function dismissReasonLabel(reason: string): string {
- return DISMISS_REASON_LABELS[reason] ?? prettify(reason)
+ return DISMISS_REASON_LABELS[reason] ?? dismissalReasonLabel(reason) ?? prettify(reason)
}
/** A short relevance / context note above a code block. */
@@ -908,7 +910,10 @@ function ArtefactRow({
renderArtefactBody({ reportId, artefact, knownTasks, knownPullRequests })
)
const bodyHasOwnCard = artefact.type === 'signal_finding' || artefact.type === 'commit'
- const MarkerIcon = ARTEFACT_MARKER[artefact.type] ?? IconActivity
+ const MarkerIcon =
+ artefact.type === 'dismissal' && (artefact.content as DismissalContent).state === 'resolved'
+ ? IconCheckCircle
+ : (ARTEFACT_MARKER[artefact.type] ?? IconActivity)
return (
<div className="relative flex gap-3 pb-4 last:pb-0">
diff --git a/products/signals/frontend/inbox/components/detail/artefactTypes.ts b/products/signals/frontend/inbox/components/detail/artefactTypes.ts
index ce344d54c659..09f3f03c805a 100644
--- a/products/signals/frontend/inbox/components/detail/artefactTypes.ts
+++ b/products/signals/frontend/inbox/components/detail/artefactTypes.ts
@@ -56,6 +56,7 @@ export interface SignalFindingContent {
}
export interface DismissalContent {
+ state?: 'resolved' | 'suppressed' | 'potential' | null
reason?: string
note?: string
}
@@ -351,7 +352,7 @@ export const ARTEFACT_TYPE_LABELS: Record<string, string> = {
signal_finding: 'Signal investigated',
suggested_reviewers: 'Reviewers suggested',
repo_selection: 'Repo selected',
- dismissal: 'Report dismissed',
+ dismissal: 'Report feedback added',
video_segment: 'Video segment',
title_change: 'Title edited',
summary_change: 'Summary edited',
diff --git a/products/signals/frontend/inbox/components/detail/prActivityPresentation.ts b/products/signals/frontend/inbox/components/detail/prActivityPresentation.ts
index d92fa069c678..02cd8bd45dcd 100644
--- a/products/signals/frontend/inbox/components/detail/prActivityPresentation.ts
+++ b/products/signals/frontend/inbox/components/detail/prActivityPresentation.ts
@@ -2,6 +2,7 @@ import type { SignalReportArtefact } from '../../types'
import { parsePrUrlParts } from '../../utils/reportPresentation'
import {
artefactTypeLabel,
+ DismissalContent,
ImplementationDecisionContent,
ImplementationHandoverContent,
ImplementationReplacementContent,
@@ -14,6 +15,16 @@ function prReference(url: string): string {
export function prActivityTitle(artefact: SignalReportArtefact): string {
switch (artefact.type) {
+ case 'dismissal': {
+ const state = (artefact.content as DismissalContent).state
+ return state === 'resolved'
+ ? 'Report resolved'
+ : state === 'suppressed'
+ ? 'Report dismissed'
+ : state === 'potential'
+ ? 'Report snoozed'
+ : 'Report feedback added'
+ }
case 'pull_request': {
const url = typeof artefact.content.url === 'string' ? artefact.content.url : ''
return `${prReference(url)} linked`
diff --git a/products/signals/frontend/inbox/components/shell/DismissReportDialog.tsx b/products/signals/frontend/inbox/components/shell/DismissReportDialog.tsx
index 3b8ffa97f41c..66878f652abf 100644
--- a/products/signals/frontend/inbox/components/shell/DismissReportDialog.tsx
+++ b/products/signals/frontend/inbox/components/shell/DismissReportDialog.tsx
@@ -14,6 +14,8 @@ interface OpenDismissReportDialogParams {
selectedCount?: number
/** Whether the report has an implementation PR that is still open. Dismissing closes it, so the copy says so. */
hasOpenPr?: boolean
+ submitDataAttr?: string
+ onAfterClose?: () => void
/** Show a digit keycap on each reason and let 1..9 pick it. On for triage mode, where the whole flow is keyboard-driven. */
hotkeys?: boolean
/** Preselect this reason. The context menu's "Something else…" opens the dialog with it set,
@@ -42,6 +44,8 @@ export function openDismissReportDialog({
reportTitle,
selectedCount,
hasOpenPr = false,
+ submitDataAttr,
+ onAfterClose,
hotkeys = false,
initialReason,
copy,
@@ -62,7 +66,12 @@ export function openDismissReportDialog({
hasOpenPr ? ' The pull request opened for this report is closed.' : ''
}`
+ const primaryButtonProps = {
+ children: copy?.submitLabel ?? 'Dismiss & teach the agent',
+ 'data-attr': submitDataAttr,
+ }
LemonDialog.openForm({
+ onAfterClose,
title: copy?.title ?? title,
description: copy?.description ?? description,
maxWidth: '36rem',
@@ -105,7 +114,7 @@ export function openDismissReportDialog({
errors: {
reason: (reason) => (!reason ? "You haven't picked a reason" : undefined),
},
- primaryButtonProps: { children: copy?.submitLabel ?? 'Dismiss & teach the agent' },
+ primaryButtonProps,
shouldAwaitSubmit: true,
onSubmit: async ({ reason, note, correctedRepository }) => {
if (!reason) {
diff --git a/products/signals/frontend/inbox/components/shell/ResolveReportDialog.tsx b/products/signals/frontend/inbox/components/shell/ResolveReportDialog.tsx
index 38d69fa6e912..e6373fa2bcd8 100644
--- a/products/signals/frontend/inbox/components/shell/ResolveReportDialog.tsx
+++ b/products/signals/frontend/inbox/components/shell/ResolveReportDialog.tsx
@@ -18,6 +18,8 @@ interface OpenResolveReportDialogParams {
selectedCount?: number
/** Whether the report has an implementation PR that is still open. Resolving closes it, so the copy says so. */
hasOpenPr?: boolean
+ submitDataAttr?: string
+ onAfterClose?: () => void
/** Show a digit keycap on each reason and let 1..9 pick it. On for triage mode, where the whole flow is keyboard-driven. */
hotkeys?: boolean
/** Preselect this reason. The context menu's "Something else…" opens the dialog with it set,
@@ -46,6 +48,8 @@ export function openResolveReportDialog({
reportTitle,
selectedCount,
hasOpenPr = false,
+ submitDataAttr,
+ onAfterClose,
hotkeys = false,
initialReason,
copy,
@@ -59,12 +63,18 @@ export function openResolveReportDialog({
? `Resolve ${selectedCount} ${isPlural ? 'reports' : 'report'}?`
: `Resolve report "${reportTitle?.trim() ? reportTitle : 'Untitled report'}"?`
const description = isPlural
- ? 'These reports are marked as done. If an issue comes back, you get a new report linked to the old one. Any open pull request for these reports is closed.'
- : `This marks the report as done. If the issue comes back, you get a new report linked to this one.${
- hasOpenPr ? ' The pull request opened for this report is closed.' : ''
+ ? `Mark these useful reports as done. If an issue comes back, you get a new report linked to the old one.${hasOpenPr ? ' Any open pull request for these reports will be closed.' : ''}`
+ : `This marks a useful report as done. If the issue comes back, you get a new report linked to this one.${
+ hasOpenPr ? ' The pull request opened for this report will be closed.' : ''
}`
+ const primaryButtonProps = {
+ children:
+ copy?.submitLabel ?? (hasOpenPr ? 'Resolve and close PR' : isPlural ? 'Resolve reports' : 'Resolve report'),
+ 'data-attr': submitDataAttr,
+ }
LemonDialog.openForm({
+ onAfterClose,
title: copy?.title ?? title,
description: copy?.description ?? description,
maxWidth: '36rem',
@@ -72,7 +82,7 @@ export function openResolveReportDialog({
initialValues: { reason: initialReason ?? null, note: '' },
content: (
<div className="flex flex-col gap-3">
- <LemonField name="reason" label="Reason">
+ <LemonField name="reason" label="How was this report handled?">
{({ value, onChange }) =>
hotkeys ? (
<HotkeyRadio value={value} onChange={onChange} options={RESOLVE_REASON_OPTIONS} />
@@ -81,11 +91,7 @@ export function openResolveReportDialog({
)
}
</LemonField>
- <LemonField
- name="note"
- label="Note"
- info="Optional. A link to the fix helps anyone who reads this report later."
- >
+ <LemonField name="note" label="Details (optional)" info="Add context or a link to the implementation.">
<LemonTextArea
// stopPropagation keeps Enter in this multi-line note from reaching the dialog
// form and resolving the report (and closing its PR) mid-sentence.
@@ -93,7 +99,7 @@ export function openResolveReportDialog({
// With the reason already chosen, the note is the only thing left to type.
// Never focus otherwise: the hotkey flow reads digits as reason picks.
autoFocus={initialReason != null}
- placeholder="Link to the pull request or commit, or what fixed it."
+ placeholder="Add context or a link to the implementation"
maxLength={4000}
minRows={3}
maxRows={8}
@@ -104,7 +110,7 @@ export function openResolveReportDialog({
errors: {
reason: (reason) => (!reason ? "You haven't picked a reason" : undefined),
},
- primaryButtonProps: { children: copy?.submitLabel ?? (isPlural ? 'Resolve reports' : 'Resolve report') },
+ primaryButtonProps,
shouldAwaitSubmit: true,
onSubmit: async ({ reason, note }) => {
if (!reason) {
diff --git a/products/signals/frontend/inbox/logics/inboxBulkActionsLogic.ts b/products/signals/frontend/inbox/logics/inboxBulkActionsLogic.ts
index 969572ac5f2b..d6e58b6933f8 100644
--- a/products/signals/frontend/inbox/logics/inboxBulkActionsLogic.ts
+++ b/products/signals/frontend/inbox/logics/inboxBulkActionsLogic.ts
@@ -63,7 +63,7 @@ export interface inboxBulkActionsLogicActions {
note: string
) => {
note: string
- reason: 'already_fixed' | 'fixed_outside_posthog' | 'other' | 'pr_merged'
+ reason: ResolveReasonValue
}
bulkResolveFailure: () => {
value: true
diff --git a/products/signals/frontend/inbox/logics/inboxTriageLogic.ts b/products/signals/frontend/inbox/logics/inboxTriageLogic.ts
index 41e1183a9e96..36c3880ca830 100644
--- a/products/signals/frontend/inbox/logics/inboxTriageLogic.ts
+++ b/products/signals/frontend/inbox/logics/inboxTriageLogic.ts
@@ -118,11 +118,11 @@ export interface inboxTriageLogicActions {
} // reportListLogic
resolveReport: (
reportId: string,
- reason: 'already_fixed' | 'fixed_outside_posthog' | 'other' | 'pr_merged',
+ reason: import('../utils/dismissalReasons').ResolveReasonValue,
note: string
) => {
note: string
- reason: 'already_fixed' | 'fixed_outside_posthog' | 'other' | 'pr_merged'
+ reason: import('../utils/dismissalReasons').ResolveReasonValue
reportId: string
} // reportListLogic
unassignMe: (
diff --git a/products/signals/frontend/inbox/logics/reportListLogic.ts b/products/signals/frontend/inbox/logics/reportListLogic.ts
index 68a0527d1f2f..82cf6af302fa 100644
--- a/products/signals/frontend/inbox/logics/reportListLogic.ts
+++ b/products/signals/frontend/inbox/logics/reportListLogic.ts
@@ -325,7 +325,7 @@ export interface reportListLogicActions {
note: string
) => {
note: string
- reason: 'already_fixed' | 'fixed_outside_posthog' | 'other' | 'pr_merged'
+ reason: ResolveReasonValue
reportId: string
}
restoreReport: (
diff --git a/products/signals/frontend/inbox/utils/dismissalReasons.ts b/products/signals/frontend/inbox/utils/dismissalReasons.ts
index 40c9dc7c9e3a..a53c3c72d293 100644
--- a/products/signals/frontend/inbox/utils/dismissalReasons.ts
+++ b/products/signals/frontend/inbox/utils/dismissalReasons.ts
@@ -23,8 +23,8 @@ export const DISMISSAL_REASON_OPTIONS = [
* joining this one — so the choice no longer decides whether the issue can come back.
*/
export const RESOLVE_REASON_OPTIONS = [
- { value: 'fixed_outside_posthog', label: 'Fixed outside PostHog' },
- { value: 'pr_merged', label: 'PR was merged' },
+ { value: 'fixed_outside_posthog', label: 'Implemented manually' },
+ { value: 'no_action_needed', label: 'No action needed' },
{ value: 'already_fixed', label: 'Was already fixed before this report' },
{ value: 'other', label: 'Something else…' },
] as const
@@ -32,8 +32,8 @@ export const RESOLVE_REASON_OPTIONS = [
/** Persisted dismiss reason (values match {@link DISMISSAL_REASON_OPTIONS}). */
export type DismissalReasonValue = (typeof DISMISSAL_REASON_OPTIONS)[number]['value']
-/** Persisted resolve reason (values match {@link RESOLVE_REASON_OPTIONS}). */
-export type ResolveReasonValue = (typeof RESOLVE_REASON_OPTIONS)[number]['value']
+/** Persisted feedback can include reasons that are no longer selectable in the dialog. */
+export type ResolveReasonValue = (typeof RESOLVE_REASON_OPTIONS)[number]['value'] | 'pr_merged'
/**
* Whether a persisted reason describes a resolve rather than a dismissal. A resolved row only shows
@@ -41,7 +41,12 @@ export type ResolveReasonValue = (typeof RESOLVE_REASON_OPTIONS)[number]['value'
* its old dismiss reason, and showing that on finished work would mislabel it.
*/
export function isResolveReason(value: string | null | undefined): boolean {
- return value === 'fixed_outside_posthog' || value === 'pr_merged' || value === 'already_fixed'
+ return (
+ value === 'fixed_outside_posthog' ||
+ value === 'no_action_needed' ||
+ value === 'pr_merged' ||
+ value === 'already_fixed'
+ )
}
/** Feedback captured by the dismiss dialog and forwarded to the report state API. */
@@ -79,6 +84,7 @@ export function suppressDismissalPayload(dismissal: DismissalFeedback): {
// refund action, which dismisses the report as part of the refund. `merged` is written by the
// report merge action, which archives each duplicate it folds into the surviving report.
const EXTRA_DISMISSAL_REASON_LABELS: Record<string, string> = {
+ pr_merged: 'PR already merged',
refunded: 'Refunded',
merged: 'Merged into another report',
}
diff --git a/services/mcp/src/api/generated.ts b/services/mcp/src/api/generated.ts
index 63f29d38c50e..759785b86ee4 100644
--- a/services/mcp/src/api/generated.ts
+++ b/services/mcp/src/api/generated.ts
@@ -37939,6 +37939,7 @@ export namespace Schemas {
* * `wontfix_intentional` - Won't fix - intentional behavior
* * `wontfix_irrelevant` - Won't fix - issue is real but insignificant
* * `fixed_outside_posthog` - Fixed outside PostHog
+ * * `no_action_needed` - No action needed
* * `pr_merged` - PR was merged
* * `other` - Something else…
*/
@@ -37953,6 +37954,7 @@ export namespace Schemas {
WontfixIntentional: 'wontfix_intentional',
WontfixIrrelevant: 'wontfix_irrelevant',
FixedOutsidePosthog: 'fixed_outside_posthog',
+ NoActionNeeded: 'no_action_needed',
PrMerged: 'pr_merged',
Other: 'other',
} as const;
@@ -103820,7 +103822,7 @@ export namespace Schemas {
* * `potential` - potential
* * `resolved` - resolved */
state: SignalReportStateEnum;
- /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
+ /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
*
* * `already_fixed` - Already fixed
* * `report_unclear` - Report is unclear to me
@@ -103829,6 +103831,7 @@ export namespace Schemas {
* * `wontfix_intentional` - Won't fix - intentional behavior
* * `wontfix_irrelevant` - Won't fix - issue is real but insignificant
* * `fixed_outside_posthog` - Fixed outside PostHog
+ * * `no_action_needed` - No action needed
* * `pr_merged` - PR was merged
* * `other` - Something else… */
dismissal_reason?: DismissalReasonEnum;
@@ -104167,7 +104170,7 @@ export namespace Schemas {
* * `potential` - potential
* * `resolved` - resolved */
state: SignalReportStateEnum;
- /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
+ /** Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.
*
* * `already_fixed` - Already fixed
* * `report_unclear` - Report is unclear to me
@@ -104176,6 +104179,7 @@ export namespace Schemas {
* * `wontfix_intentional` - Won't fix - intentional behavior
* * `wontfix_irrelevant` - Won't fix - issue is real but insignificant
* * `fixed_outside_posthog` - Fixed outside PostHog
+ * * `no_action_needed` - No action needed
* * `pr_merged` - PR was merged
* * `other` - Something else… */
dismissal_reason?: DismissalReasonEnum;
diff --git a/services/mcp/src/generated/signals/api.ts b/services/mcp/src/generated/signals/api.ts
index d66d590effcd..86f059f0d11a 100644
--- a/services/mcp/src/generated/signals/api.ts
+++ b/services/mcp/src/generated/signals/api.ts
@@ -577,15 +577,16 @@ export const SignalsReportsStateCreateBody = () => zod.object({
'wontfix_intentional',
'wontfix_irrelevant',
'fixed_outside_posthog',
+ 'no_action_needed',
'pr_merged',
'other',
])
.describe(
- "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
)
.optional()
.describe(
- "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
),
dismissal_note: zod
.string()
@@ -979,15 +980,16 @@ export const SignalsReportsBulkStateCreateBody = () => zod.object({
'wontfix_intentional',
'wontfix_irrelevant',
'fixed_outside_posthog',
+ 'no_action_needed',
'pr_merged',
'other',
])
.describe(
- "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
)
.optional()
.describe(
- "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
+ "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_\*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n\* `already_fixed` - Already fixed\n\* `report_unclear` - Report is unclear to me\n\* `analysis_wrong` - Agent's analysis is wrong\n\* `wrong_repo` - Agent picked the wrong repository\n\* `wontfix_intentional` - Won't fix - intentional behavior\n\* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n\* `fixed_outside_posthog` - Fixed outside PostHog\n\* `no_action_needed` - No action needed\n\* `pr_merged` - PR was merged\n\* `other` - Something else…"
),
dismissal_note: zod
.string()
diff --git a/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-bulk-set-state.json b/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-bulk-set-state.json
index 92c5f46f06c8..960e8471ef20 100644
--- a/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-bulk-set-state.json
+++ b/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-bulk-set-state.json
@@ -13,7 +13,7 @@
"type": "string"
},
"dismissal_reason": {
- "description": "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n* `already_fixed` - Already fixed\n* `report_unclear` - Report is unclear to me\n* `analysis_wrong` - Agent's analysis is wrong\n* `wrong_repo` - Agent picked the wrong repository\n* `wontfix_intentional` - Won't fix - intentional behavior\n* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n* `fixed_outside_posthog` - Fixed outside PostHog\n* `pr_merged` - PR was merged\n* `other` - Something else…",
+ "description": "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n* `already_fixed` - Already fixed\n* `report_unclear` - Report is unclear to me\n* `analysis_wrong` - Agent's analysis is wrong\n* `wrong_repo` - Agent picked the wrong repository\n* `wontfix_intentional` - Won't fix - intentional behavior\n* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n* `fixed_outside_posthog` - Fixed outside PostHog\n* `no_action_needed` - No action needed\n* `pr_merged` - PR was merged\n* `other` - Something else…",
"enum": [
"already_fixed",
"report_unclear",
@@ -22,6 +22,7 @@
"wontfix_intentional",
"wontfix_irrelevant",
"fixed_outside_posthog",
+ "no_action_needed",
"pr_merged",
"other"
],
diff --git a/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-set-state.json b/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-set-state.json
index 06051219ccf1..6a0eaa80a55b 100644
--- a/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-set-state.json
+++ b/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-reports-set-state.json
@@ -13,7 +13,7 @@
"type": "string"
},
"dismissal_reason": {
- "description": "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n* `already_fixed` - Already fixed\n* `report_unclear` - Report is unclear to me\n* `analysis_wrong` - Agent's analysis is wrong\n* `wrong_repo` - Agent picked the wrong repository\n* `wontfix_intentional` - Won't fix - intentional behavior\n* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n* `fixed_outside_posthog` - Fixed outside PostHog\n* `pr_merged` - PR was merged\n* `other` - Something else…",
+ "description": "Optional canonical reason code recorded with the transition. Must be one of: already_fixed, report_unclear, analysis_wrong, wrong_repo, wontfix_intentional, wontfix_irrelevant, fixed_outside_posthog, no_action_needed, pr_merged, other — these match the inbox UI so the rationale renders as a labelled chip rather than a raw code. When the work this report asked for is done, the honest transition is state='resolved' with 'fixed_outside_posthog' (the fix landed without a pull request), 'pr_merged' (a pull request with the fix was merged but did not resolve the report on its own), or 'already_fixed' (it was fixed before the report was filed). Use 'no_action_needed' with state='resolved' when the report was useful but needs no implementation. A report that failed in processing resolves too, so a fix that landed is recorded as a fix rather than as a dismissal. These three codes claim the issue is gone, so a later signal about the same issue starts a fresh report linked to this one. Fixed reason codes require state='suppressed' or state='resolved', not 'potential'. The dismissal codes (report_unclear, analysis_wrong, wrong_repo, wontfix_*) go with state='suppressed' and absorb later signals silently. Use 'wrong_repo' when the agent picked the wrong repository for this report, ideally with corrected_repository naming the right one. Use 'other' together with a dismissal_note for anything that doesn't fit a code.\n\n* `already_fixed` - Already fixed\n* `report_unclear` - Report is unclear to me\n* `analysis_wrong` - Agent's analysis is wrong\n* `wrong_repo` - Agent picked the wrong repository\n* `wontfix_intentional` - Won't fix - intentional behavior\n* `wontfix_irrelevant` - Won't fix - issue is real but insignificant\n* `fixed_outside_posthog` - Fixed outside PostHog\n* `no_action_needed` - No action needed\n* `pr_merged` - PR was merged\n* `other` - Something else…",
"enum": [
"already_fixed",
"report_unclear",
@@ -22,6 +22,7 @@
"wontfix_intentional",
"wontfix_irrelevant",
"fixed_outside_posthog",
+ "no_action_needed",
"pr_merged",
"other"
],