Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(inbox): attribute onboarding experiment exposures (#120057)

Georgiy Tarasoveb19d002a644
diff --git a/products/signals/backend/facade/onboarding.py b/products/signals/backend/facade/onboarding.py
index 40f27ced95cc..3fe40c694f42 100644
--- a/products/signals/backend/facade/onboarding.py
+++ b/products/signals/backend/facade/onboarding.py
@@ -7,9 +7,7 @@ from django.db import transaction
from django.db.models import F
from django.utils import timezone
-import posthoganalytics
-
-from posthog.event_usage import groups
+from posthog.event_usage import report_user_action
from posthog.models.team.extensions import get_or_create_team_extension
from posthog.models.team.team import Team
from posthog.models.user import User
@@ -224,21 +222,23 @@ class InboxOnboarding:
if status in ("pending", "failed"):
launch_inbox_onboarding_job.delay(self.team_id, job)
- def _capture(self, user: User, event: str, properties: dict[str, object]) -> None:
- posthoganalytics.capture(
- distinct_id=str(user.distinct_id),
- event=event,
- groups=groups(team=self.team),
- properties=properties,
- )
-
def _report_completion(self, user: User, config: SignalTeamConfig) -> None:
- self._capture(
- user, "self-driving onboarding completed", InboxOnboardingAnalytics.completion_properties(config, user)
+ report_user_action(
+ user,
+ "self-driving onboarding completed",
+ InboxOnboardingAnalytics.completion_properties(config, user),
+ team=self.team,
+ organization=self.team.organization,
)
def _report_exposure(self, user: User, config: SignalTeamConfig) -> None:
- self._capture(user, "self-driving onboarding exposed", InboxOnboardingAnalytics.properties(config, user))
+ report_user_action(
+ user,
+ "self-driving onboarding exposed",
+ InboxOnboardingAnalytics.properties(config, user),
+ team=self.team,
+ organization=self.team.organization,
+ )
if (config.onboarding or {}).get("variant") == "control":
from products.signals.backend.tasks import (
reconcile_inbox_onboarding, # noqa: PLC0415 - avoid task imports during API initialization
diff --git a/products/signals/backend/onboarding_analytics.py b/products/signals/backend/onboarding_analytics.py
index 9c4a8fe4b8c9..f841022c1e8d 100644
--- a/products/signals/backend/onboarding_analytics.py
+++ b/products/signals/backend/onboarding_analytics.py
@@ -35,6 +35,7 @@ class InboxOnboardingAnalytics:
return {
"project_id": config.team_id,
"variant": variant,
+ "$feature/inbox-ui-onboarding": variant,
"flow_version": "ui-first-v1",
"inbox_client": "cloud",
"setup_mode": "quick"
diff --git a/products/signals/backend/test/test_inbox_onboarding.py b/products/signals/backend/test/test_inbox_onboarding.py
index 52bb285aaa75..017a61d70ae7 100644
--- a/products/signals/backend/test/test_inbox_onboarding.py
+++ b/products/signals/backend/test/test_inbox_onboarding.py
@@ -79,7 +79,7 @@ class TestInboxOnboarding(APIBaseTest):
@parameterized.expand([("control",), ("test-ui",), ("test-github",)])
def test_exposure_is_sticky_and_queued_once(self, variant: str) -> None:
with (
- patch("products.signals.backend.facade.onboarding.posthoganalytics.capture") as capture,
+ patch("posthog.event_usage.posthoganalytics.capture") as capture,
patch(
"products.signals.backend.onboarding_analytics.posthoganalytics.feature_enabled", return_value=True
) as flag,
@@ -95,7 +95,11 @@ class TestInboxOnboarding(APIBaseTest):
assert second.json()["variant"] == variant
assert capture.call_count == 1
assert capture.call_args.kwargs["properties"]["variant"] == variant
+ assert capture.call_args.kwargs["properties"]["$feature/inbox-ui-onboarding"] == variant
assert capture.call_args.kwargs["properties"]["self_driving_ubp"] is True
+ assert capture.call_args.kwargs["properties"]["$set_once"] == {"email": self.user.email}
+ assert capture.call_args.kwargs["groups"]["project"] == str(self.team.uuid)
+ assert capture.call_args.kwargs["groups"]["organization"] == str(self.organization.id)
assert flag.call_args.args == ("self-driving-ubp", str(self.user.distinct_id))
assert flag.call_args.kwargs["groups"]["organization"] == str(self.organization.id)
if variant == "control":
@@ -213,7 +217,7 @@ class TestInboxOnboarding(APIBaseTest):
"products.signals.backend.onboarding_completion.InboxOnboardingReconciler.has_repository",
return_value=object(),
),
- patch("products.signals.backend.facade.onboarding.posthoganalytics.capture") as capture,
+ patch("posthog.event_usage.posthoganalytics.capture") as capture,
patch(
"products.signals.backend.onboarding_analytics.posthoganalytics.feature_enabled",
return_value=not automatic_implementation,
@@ -240,7 +244,9 @@ class TestInboxOnboarding(APIBaseTest):
assert config.onboarding["activated_by"] == self.user.id
assert capture.call_args.kwargs["properties"]["variant"] == variant
assert capture.call_args.kwargs["properties"] == {
+ "$set_once": {"email": self.user.email},
"variant": variant,
+ "$feature/inbox-ui-onboarding": variant,
"project_id": self.team.id,
"flow_version": "ui-first-v1",
"inbox_client": "cloud",