:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(workflows): list only broadcasts under broadcasts and offer to move one-email workflows (#120583)
Daniel Marchukeb2e9aea8622
diff --git a/products/workflows/frontend/Broadcasts/BroadcastsTable.tsx b/products/workflows/frontend/Broadcasts/BroadcastsTable.tsxindex f127145fc4a4..eb1c9216340e 100644--- a/products/workflows/frontend/Broadcasts/BroadcastsTable.tsx+++ b/products/workflows/frontend/Broadcasts/BroadcastsTable.tsx@@ -1,6 +1,6 @@import { useActions, useValues } from 'kea'-import { LemonInput, LemonSelect, LemonTag, Tooltip } from '@posthog/lemon-ui'+import { LemonInput, LemonSelect, Tooltip } from '@posthog/lemon-ui'import { MemberSelect } from 'lib/components/MemberSelect'import { LemonButton } from 'lib/lemon-ui/LemonButton'@@ -15,13 +15,7 @@ import type { HogFlowMinimalApi } from 'products/workflows/frontend/generated/apimport { archiveDisabledReason, manageDisabledReason } from './broadcastLifecycle'import { BroadcastsEmptyState } from './BroadcastsEmptyState'-import {- BROADCASTS_PAGE_SIZE,- BroadcastsStatusFilter,- broadcastsLogic,- getBroadcastStatus,- isEligibleWorkflow,-} from './broadcastsLogic'+import { BROADCASTS_PAGE_SIZE, BroadcastsStatusFilter, broadcastsLogic, getBroadcastStatus } from './broadcastsLogic'import { BroadcastStatusTag } from './BroadcastStatusTag'const METRIC_COLUMNS: { title: string; metricName: string }[] = [@@ -60,15 +54,6 @@ export function BroadcastsTable(): JSX.Element {description={item.description}/>)}- {isEligibleWorkflow(item) && (- <LemonTag- type="muted"- data-attr="broadcast-workflow-tag"- title="A workflow with a batch trigger and one email, shown here as a broadcast."- >- Workflow- </LemonTag>- )}</div>),},diff --git a/products/workflows/frontend/Broadcasts/broadcastsLogic.ts b/products/workflows/frontend/Broadcasts/broadcastsLogic.tsindex 3b9e29caff59..6d59ac71140d 100644--- a/products/workflows/frontend/Broadcasts/broadcastsLogic.ts+++ b/products/workflows/frontend/Broadcasts/broadcastsLogic.ts@@ -17,7 +17,6 @@ import { hogFlowsBatchJobsList, hogFlowsList, hogFlowsSchedulesList } from 'prodimport type {HogFlowApi,HogFlowBatchJobApi,- HogFlowMinimalApi,HogFlowScheduleApi,PaginatedHogFlowMinimalListApi,} from 'products/workflows/frontend/generated/api.schemas'@@ -132,10 +131,6 @@ export function canMoveToDraft()}-export function isEligibleWorkflow(flow: Pick<HogFlowMinimalApi, 'origin_product'>): boolean {- return flow.origin_product !== 'broadcasts'-}-export function getBroadcastStatus(broadcast: { status?: string | null; origin_product?: string | null },details: BroadcastRowDetails | undefined@@ -299,9 +294,8 @@ export const broadcastsLogic = kea<broadcastsLogicType>([}const requested = values.filtersconst response = await hogFlowsList(String(values.currentProjectId), {- // Broadcasts plus the ordinary workflows already shaped like one (a batch- // trigger and a single email), so existing sends show up here too.- broadcast_eligible: true,+ // Only broadcasts. A workflow shaped like one stays under workflows until someone moves it.+ type: 'broadcast',search: values.filters.search || undefined,broadcast_status: values.filters.status !== 'all' ? values.filters.status : undefined,created_by: values.filters.createdBy || undefined,diff --git a/products/workflows/frontend/Workflows/WorkflowBroadcastMoveBanner.tsx b/products/workflows/frontend/Workflows/WorkflowBroadcastMoveBanner.tsxnew file mode 100644index 000000000000..4abebae50d2b--- /dev/null+++ b/products/workflows/frontend/Workflows/WorkflowBroadcastMoveBanner.tsx@@ -0,0 +1,74 @@+import { useActions, useValues } from 'kea'+import posthog from 'posthog-js'+import { useEffect } from 'react'++import { LemonBanner, LemonDialog } from '@posthog/lemon-ui'++import { lemonBannerLogic } from 'lib/lemon-ui/LemonBanner/lemonBannerLogic'+import { getAccessControlDisabledReason } from 'lib/utils/accessControlUtils'++import { AccessControlLevel, AccessControlResourceType } from '~/types'++import { canMoveToBroadcasts, workflowBroadcastMoveLogic } from './workflowBroadcastMoveLogic'+import { workflowLogic } from './workflowLogic'++export function WorkflowBroadcastMoveBanner({ id }: { id: string }): JSX.Element | null {+ const { originalWorkflow, hasUnsavedChanges, workflowUserAccessLevel } = useValues(workflowLogic)+ const { moving } = useValues(workflowBroadcastMoveLogic({ id }))+ const { moveToBroadcasts } = useActions(workflowBroadcastMoveLogic({ id }))+ const show = canMoveToBroadcasts(originalWorkflow)+ const dismissKey = `workflow-broadcast-move-${id}`+ const { isDismissed } = useValues(lemonBannerLogic({ dismissKey }))++ useEffect(() => {+ if (show && !isDismissed) {+ posthog.capture('workflow broadcast move suggestion shown', { workflow_id: id })+ }+ }, [show, isDismissed, id])++ if (!show) {+ return null+ }++ const disabledReason =+ getAccessControlDisabledReason(+ AccessControlResourceType.Workflow,+ AccessControlLevel.Editor,+ workflowUserAccessLevel ?? undefined+ ) ?? (hasUnsavedChanges ? 'Save your changes first' : undefined)++ return (+ <div className="shrink-0" data-attr="workflow-broadcast-move-banner">+ <LemonBanner+ type="info"+ dismissKey={dismissKey}+ onClose={() => posthog.capture('workflow broadcast move suggestion dismissed', { workflow_id: id })}+ action={{+ children: 'Move to broadcasts',+ loading: moving,+ disabledReason,+ 'data-attr': 'workflow-broadcast-move',+ onClick: () =>+ LemonDialog.open({+ title: 'Move this workflow to broadcasts?',+ description:+ 'It keeps its runs and metrics, opens in the broadcast editor and leaves the Workflows list. You can still open it in the workflow editor to add steps. This cannot be undone.',+ primaryButton: {+ children: 'Move to broadcasts',+ type: 'primary',+ 'data-attr': 'workflow-broadcast-move-confirm',+ onClick: () => {+ posthog.capture('workflow broadcast move clicked', { workflow_id: id })+ moveToBroadcasts()+ },+ },+ secondaryButton: { children: 'Cancel' },+ }),+ }}+ >+ This workflow sends one email to a batch audience, which is a broadcast. Move it to broadcasts to track+ its deliveries, opens and clicks in the broadcast overview.+ </LemonBanner>+ </div>+ )+}diff --git a/products/workflows/frontend/Workflows/WorkflowScene.tsx b/products/workflows/frontend/Workflows/WorkflowScene.tsxindex 8728967f3467..176723f78f3d 100644--- a/products/workflows/frontend/Workflows/WorkflowScene.tsx+++ b/products/workflows/frontend/Workflows/WorkflowScene.tsx@@ -45,6 +45,7 @@ import {} from './workflowAgentContext'import { WorkflowAiEmailDraftStatus } from './WorkflowAiEmailDraftStatus'import { WorkflowAssets } from './WorkflowAssets'+import { WorkflowBroadcastMoveBanner } from './WorkflowBroadcastMoveBanner'import { WorkflowEmailPauseBanner } from './WorkflowEmailPauseBanner'import { WorkflowInvocations } from './WorkflowInvocations'import { WorkflowLogicProps, workflowLogic } from './workflowLogic'@@ -251,6 +252,7 @@ export function WorkflowScene(props: WorkflowSceneLogicProps): JSX.Element {<BindLogic logic={workflowLogic} props={workflowProps}><WorkflowSceneHeader {...props} headerInWorkflowBar={headerInWorkflowBar} /><WorkflowEmailPauseBanner />+ {isSavedWorkflow && <WorkflowBroadcastMoveBanner id={props.id!} />}{!isSavedWorkflow && <WorkflowAiEmailDraftStatus {...workflowProps} />}{suggestionsAvailable && isSavedWorkflow && <WorkflowSuggestionsNotice id={props.id!} />}{/* Only show Logs and Metrics tabs if the workflow has already been created */}diff --git a/products/workflows/frontend/Workflows/workflowBroadcastMoveLogic.test.ts b/products/workflows/frontend/Workflows/workflowBroadcastMoveLogic.test.tsnew file mode 100644index 000000000000..372dd6e102ee--- /dev/null+++ b/products/workflows/frontend/Workflows/workflowBroadcastMoveLogic.test.ts@@ -0,0 +1,54 @@+import { HogFlow } from './hogflows/types'+import { canMoveToBroadcasts } from './workflowBroadcastMoveLogic'++const step = (id: string, type: string, config: Record<string, any>): HogFlow['actions'][number] =>+ ({ id, type, name: id, description: '', created_at: 0, updated_at: 0, config }) as HogFlow['actions'][number]++const trigger = step('trigger_node', 'trigger', { type: 'batch', filters: {} })+const email = step('email_node', 'function_email', { template_id: 'template-email', inputs: {} })+const secondEmail = step('email_node_2', 'function_email', { template_id: 'template-email', inputs: {} })+const exit = step('exit_node', 'exit', { reason: 'Default exit' })++const oneEmailFlow = {+ id: 'flow',+ name: 'Flow',+ status: 'draft',+ exit_condition: 'exit_only_at_end',+ origin_product: null,+ draft: null,+ actions: [trigger, email, exit],+ edges: [+ { from: 'trigger_node', to: 'email_node', type: 'continue' },+ { from: 'email_node', to: 'exit_node', type: 'continue' },+ ],+} as unknown as HogFlow++describe('canMoveToBroadcasts', () => {+ it.each([+ ['a workflow that sends one email to a batch audience', {}, true],+ ['a broadcast already', { origin_product: 'broadcasts' }, false],+ ['a loop', { origin_product: 'loops' }, false],+ ['an archived workflow', { status: 'archived' }, false],+ ['a workflow with a staged draft', { draft: { name: 'Next' } }, false],+ ['a workflow that exits on a condition', { exit_condition: 'exit_on_conversion' }, false],+ [+ 'a workflow with a second email',+ {+ actions: [trigger, email, secondEmail, exit],+ edges: [+ { from: 'trigger_node', to: 'email_node', type: 'continue' },+ { from: 'email_node', to: 'email_node_2', type: 'continue' },+ { from: 'email_node_2', to: 'exit_node', type: 'continue' },+ ],+ },+ false,+ ],+ [+ 'an event-triggered workflow',+ { actions: [step('trigger_node', 'trigger', { type: 'event', filters: {} }), email, exit] },+ false,+ ],+ ])('%s', (_name, overrides, expected) => {+ expect(canMoveToBroadcasts({ ...oneEmailFlow, ...overrides } as HogFlow)).toBe(expected)+ })+})diff --git a/products/workflows/frontend/Workflows/workflowBroadcastMoveLogic.ts b/products/workflows/frontend/Workflows/workflowBroadcastMoveLogic.tsnew file mode 100644index 000000000000..a3949f89df9c--- /dev/null+++ b/products/workflows/frontend/Workflows/workflowBroadcastMoveLogic.ts@@ -0,0 +1,90 @@+import { MakeLogicType, actions, kea, key, listeners, path, props, reducers } from 'kea'+import { router } from 'kea-router'+import posthog from 'posthog-js'++import { ApiConfig } from 'lib/api'+import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'+import { urls } from 'scenes/urls'++import { hogFlowsConvertToBroadcast } from 'products/workflows/frontend/generated/api'++import { canEditInWizard, isBroadcastShaped } from '../Broadcasts/broadcastsLogic'+import { HogFlow } from './hogflows/types'++/** Mirrors is_convertible_to_broadcast on the server, which still checks on the move. */+export function canMoveToBroadcasts(workflow: HogFlow | null): boolean {+ return (+ !!workflow &&+ !workflow.origin_product &&+ workflow.status !== 'archived' &&+ workflow.exit_condition === 'exit_only_at_end' &&+ !workflow.draft &&+ isBroadcastShaped(workflow.actions) &&+ canEditInWizard(workflow.actions, workflow.edges)+ )+}++export interface WorkflowBroadcastMoveLogicProps {+ id: string+}++// Generated by kea-typegen. Update if you're an agent, ignore if you're human.+export interface workflowBroadcastMoveLogicValues {+ moving: boolean+}++// Generated by kea-typegen. Update if you're an agent, ignore if you're human.+export interface workflowBroadcastMoveLogicActions {+ moveToBroadcasts: () => {+ value: true+ }+ moveToBroadcastsFailure: () => {+ value: true+ }+}++// Generated by kea-typegen. Update if you're an agent, ignore if you're human.+export interface workflowBroadcastMoveLogicMeta {+ key: string+}++export type workflowBroadcastMoveLogicType = MakeLogicType<+ workflowBroadcastMoveLogicValues,+ workflowBroadcastMoveLogicActions,+ WorkflowBroadcastMoveLogicProps,+ workflowBroadcastMoveLogicMeta+>++export const workflowBroadcastMoveLogic = kea<workflowBroadcastMoveLogicType>([+ path((key) => ['products', 'workflows', 'frontend', 'Workflows', 'workflowBroadcastMoveLogic', key]),+ props({} as WorkflowBroadcastMoveLogicProps),+ key((props) => props.id),+ actions({+ moveToBroadcasts: true,+ moveToBroadcastsFailure: true,+ }),+ reducers({+ moving: [+ false,+ {+ moveToBroadcasts: () => true,+ moveToBroadcastsFailure: () => false,+ },+ ],+ }),+ listeners(({ actions, props }) => ({+ moveToBroadcasts: async () => {+ try {+ await hogFlowsConvertToBroadcast(String(ApiConfig.getCurrentTeamId()), props.id)+ } catch {+ posthog.capture('workflow broadcast move failed', { workflow_id: props.id })+ lemonToast.error("Couldn't move this workflow to broadcasts. Reload the page and try again.")+ actions.moveToBroadcastsFailure()+ return+ }+ posthog.capture('workflow broadcast move completed', { workflow_id: props.id })+ lemonToast.success('Moved to broadcasts')+ router.actions.push(urls.broadcast(props.id))+ },+ })),+])