Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

refactor(experiments): route ee callers through the facade (#125882)

Andersec3cf695494f
diff --git a/ee/hogai/context/experiment/context.py b/ee/hogai/context/experiment/context.py
index 3f5730a575cf..ddce33077710 100644
--- a/ee/hogai/context/experiment/context.py
+++ b/ee/hogai/context/experiment/context.py
@@ -1,11 +1,10 @@
from posthog.schema import MaxExperimentMetricResult
from posthog.models import Team
-from posthog.sync import database_sync_to_async
-from products.experiments.backend.facade.contracts import MAX_METRICS_TO_SUMMARIZE
-from products.experiments.backend.hogql_queries.utils import get_experiment_stats_method
-from products.experiments.backend.models.experiment import Experiment
+from products.access_control.backend.facade.contracts import ObjectAccessRef
+from products.experiments.backend.facade.api import aget_experiment_assistant_context
+from products.experiments.backend.facade.contracts import MAX_METRICS_TO_SUMMARIZE, ExperimentAssistantContext
from .prompts import (
EXPERIMENT_CONCLUSION_COMMENT_TEMPLATE,
@@ -35,20 +34,20 @@ class ExperimentContext:
self._experiment_id = experiment_id
self._feature_flag_key = feature_flag_key
- async def aget_experiment(self) -> Experiment | None:
+ async def aget_experiment(self) -> ExperimentAssistantContext | None:
"""Fetch the experiment from the database."""
- try:
- if self._experiment_id is not None:
- return await Experiment.objects.select_related("feature_flag").aget(
- id=self._experiment_id, team=self._team, deleted=False
- )
- elif self._feature_flag_key is not None:
- return await Experiment.objects.select_related("feature_flag").aget(
- feature_flag__key=self._feature_flag_key, team=self._team, deleted=False
- )
- return None
- except Experiment.DoesNotExist:
- return None
+ return await aget_experiment_assistant_context(
+ self._team.id, experiment_id=self._experiment_id, feature_flag_key=self._feature_flag_key
+ )
+
+ @staticmethod
+ def object_access_ref(experiment: ExperimentAssistantContext) -> ObjectAccessRef:
+ return ObjectAccessRef(
+ resource="experiment",
+ id=str(experiment.id),
+ team_id=experiment.team_id,
+ created_by_id=experiment.created_by_id,
+ )
def get_not_found_message(self) -> str:
"""Return a formatted not found message."""
@@ -57,17 +56,16 @@ class ExperimentContext:
)
return EXPERIMENT_NOT_FOUND_TEMPLATE.format(identifier=identifier)
- def _get_experiment_status(self, experiment: Experiment) -> str:
+ def _get_experiment_status(self, experiment: ExperimentAssistantContext) -> str:
"""Determine the experiment status."""
- if experiment.is_draft:
+ if experiment.start_date is None:
return "Draft"
elif not experiment.end_date:
return "Running"
else:
return "Completed"
- @database_sync_to_async
- def format_experiment(self, experiment: Experiment) -> str:
+ def format_experiment(self, experiment: ExperimentAssistantContext) -> str:
"""Format experiment data for AI consumption."""
dates_section = ""
if experiment.start_date or experiment.end_date:
@@ -91,17 +89,15 @@ class ExperimentContext:
)
variants_section = ""
- if experiment.variants:
- variants_list = "\n".join(
- f"- {key}: {variant.get('name', key)}" for key, variant in experiment.variants.items()
- )
+ if experiment.variant_names:
+ variants_list = "\n".join(f"- {key}: {name}" for key, name in experiment.variant_names.items())
variants_section = EXPERIMENT_VARIANTS_TEMPLATE.format(variants_list=variants_list)
feature_flag_variants_section = ""
- flag_variants = experiment.feature_flag.variants if experiment.feature_flag else []
+ flag_variants = experiment.feature_flag_variants
if flag_variants:
variants_list = "\n".join(
- f"- {v.get('key', 'unknown')}: {v.get('rollout_percentage', 0)}%" for v in flag_variants
+ f"- {v.key if v.key is not None else 'unknown'}: {v.rollout_percentage}%" for v in flag_variants
)
feature_flag_variants_section = EXPERIMENT_FEATURE_FLAG_VARIANTS_TEMPLATE.format(
variants_list=variants_list
@@ -111,20 +107,19 @@ class ExperimentContext:
experiment_name=experiment.name,
experiment_id=experiment.id,
experiment_description=experiment.description or "No description",
- feature_flag_key=experiment.feature_flag.key,
+ feature_flag_key=experiment.feature_flag_key,
experiment_type=experiment.type or "product",
experiment_status=self._get_experiment_status(experiment),
dates_section=dates_section,
conclusion_section=conclusion_section,
variants_section=variants_section,
feature_flag_variants_section=feature_flag_variants_section,
- experiment_created_at=experiment.created_at.isoformat() if experiment.created_at else "Unknown",
+ experiment_created_at=experiment.created_at.isoformat(),
).strip()
- @database_sync_to_async
def format_experiment_results_data(
self,
- experiment: Experiment,
+ experiment: ExperimentAssistantContext,
exposures: dict[str, float] | None = None,
primary_metrics_results: list[MaxExperimentMetricResult] | None = None,
secondary_metrics_results: list[MaxExperimentMetricResult] | None = None,
@@ -132,9 +127,9 @@ class ExperimentContext:
"""Format experiment results data including metrics for AI analysis."""
lines: list[str] = []
- stats_method = get_experiment_stats_method(experiment)
+ stats_method = experiment.stats_method
- variants = [v.get("key") for v in experiment.feature_flag.variants if v.get("key")]
+ variants = [v.key for v in experiment.feature_flag_variants if v.key]
lines.append(f"## Experiment: {experiment.name}")
lines.append(f"**ID:** {experiment.id}")
@@ -228,4 +223,4 @@ class ExperimentContext:
if experiment is None:
return self.get_not_found_message()
- return await self.format_experiment(experiment)
+ return self.format_experiment(experiment)
diff --git a/ee/hogai/core/agent_modes/presets/flags.py b/ee/hogai/core/agent_modes/presets/flags.py
index f3c233a77f6d..29a6ed430b1f 100644
--- a/ee/hogai/core/agent_modes/presets/flags.py
+++ b/ee/hogai/core/agent_modes/presets/flags.py
@@ -2,7 +2,7 @@ from typing import TYPE_CHECKING
from posthog.schema import AgentMode
-from products.experiments.backend.max_tools import CreateExperimentTool, ExperimentSummaryTool
+from products.experiments.backend.facade.max_tools import CreateExperimentTool, ExperimentSummaryTool
from products.feature_flags.backend.max_tools import CreateFeatureFlagTool
from ee.hogai.chat_agent.executables import ChatAgentPlanExecutable, ChatAgentPlanToolsExecutable
diff --git a/ee/hogai/tool.py b/ee/hogai/tool.py
index 1526299b0ea3..dcc5d6435f6a 100644
--- a/ee/hogai/tool.py
+++ b/ee/hogai/tool.py
@@ -19,6 +19,7 @@ from posthog.models import Team, User
from posthog.scopes import APIScopeObject
from posthog.sync import database_sync_to_async
+from products.access_control.backend.facade.contracts import ObjectAccessRef
from products.access_control.backend.facade.user_access_control import AccessControlLevel, UserAccessControl
from ee.hogai.context.context import AssistantContextManager
@@ -345,16 +346,22 @@ class MaxTool(AssistantContextMixin, AssistantDispatcherMixin, BaseTool):
Raises MaxToolAccessDeniedError if user lacks required access.
Args:
- obj: The model instance to check access for (Insight, Dashboard, etc.)
+ obj: The model instance to check access for (Insight, Dashboard, etc.), or an ObjectAccessRef for an
+ object that a facade returns as a contract
required_level: Minimum access level required ("viewer", "editor", etc.)
resource: Resource name for error message. If None, derived from model._meta.model_name.
action: Verb for error message ("read", "edit", "delete")
"""
- has_access = await database_sync_to_async(self.user_access_control.check_access_level_for_object)(
- obj, required_level
- )
+ if isinstance(obj, ObjectAccessRef):
+ has_access = await database_sync_to_async(self.user_access_control.check_access_level_for_ref)(
+ obj, required_level
+ )
+ else:
+ has_access = await database_sync_to_async(self.user_access_control.check_access_level_for_object)(
+ obj, required_level
+ )
if not has_access:
- resource_name = resource or obj._meta.model_name
+ resource_name = resource or (obj.resource if isinstance(obj, ObjectAccessRef) else obj._meta.model_name)
raise MaxToolAccessDeniedError(resource_name, required_level, action=action)
async def _check_dangerous_operation(self, kwargs: dict[str, Any]) -> tuple[str, Any] | None:
diff --git a/ee/hogai/tools/read_data/test/test_tool.py b/ee/hogai/tools/read_data/test/test_tool.py
index 54bda81973d9..7dbf951a1358 100644
--- a/ee/hogai/tools/read_data/test/test_tool.py
+++ b/ee/hogai/tools/read_data/test/test_tool.py
@@ -24,6 +24,7 @@ from posthog.constants import AvailableFeature
from posthog.models import OrganizationMembership, PropertyDefinition
from posthog.models.scoping import team_scope
+from products.access_control.backend.facade.contracts import ObjectAccessRef
from products.access_control.backend.models.access_control import AccessControl
from products.access_control.backend.models.property_access_control import PropertyAccessControl
from products.access_control.backend.property_access_control import PropertyAccessLevel
@@ -38,7 +39,7 @@ from products.data_modeling.backend.facade.models import (
DataWarehouseSavedQuery,
DataWarehouseSavedQueryColumnAnnotation,
)
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.testing import acreate_experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from products.product_analytics.backend.facade.models import Insight
from products.surveys.backend.models import Survey
@@ -1425,11 +1426,11 @@ class TestReadDataTool(BaseTest):
},
)
- experiment = await Experiment.objects.acreate(
- team=self.team,
+ experiment_id = await acreate_experiment(
+ team_id=self.team.id,
+ feature_flag_id=flag.id,
name="Test Experiment",
description="An A/B test experiment",
- feature_flag=flag,
parameters={
"feature_flag_variants": [
{"key": "control", "rollout_percentage": 50},
@@ -1450,7 +1451,7 @@ class TestReadDataTool(BaseTest):
context_manager=context_manager,
)
- result, artifact = await tool._arun_impl({"kind": "experiment", "id": experiment.id})
+ result, artifact = await tool._arun_impl({"kind": "experiment", "id": experiment_id})
assert "Test Experiment" in result
assert "An A/B test experiment" in result
@@ -1469,11 +1470,11 @@ class TestReadDataTool(BaseTest):
filters={},
)
- await Experiment.objects.acreate(
- team=self.team,
+ await acreate_experiment(
+ team_id=self.team.id,
+ feature_flag_id=flag.id,
name="Another Experiment",
description="Second A/B test",
- feature_flag=flag,
)
state = AssistantState(messages=[], root_tool_call_id=str(uuid4()))
@@ -1767,8 +1768,8 @@ class TestReadDataTool(BaseTest):
async def test_read_experiment_denied_when_user_lacks_object_access(self):
flag = await FeatureFlag.objects.acreate(team=self.team, key="exp-flag", name="Exp Flag", created_by=self.user)
- experiment = await Experiment.objects.acreate(
- team=self.team, name="Secret Experiment", feature_flag=flag, created_by=self.user
+ experiment_id = await acreate_experiment(
+ team_id=self.team.id, feature_flag_id=flag.id, name="Secret Experiment", created_by_id=self.user.id
)
user = MagicMock()
@@ -1782,19 +1783,24 @@ class TestReadDataTool(BaseTest):
)
with patch.object(tool, "user_access_control") as mock_uac:
- mock_uac.check_access_level_for_object.return_value = False
+ mock_uac.check_access_level_for_ref.return_value = False
with pytest.raises(MaxToolAccessDeniedError):
- await tool._arun_impl({"kind": "experiment", "id": experiment.id})
+ await tool._arun_impl({"kind": "experiment", "id": experiment_id})
- mock_uac.check_access_level_for_object.assert_called_once()
+ mock_uac.check_access_level_for_ref.assert_called_once_with(
+ ObjectAccessRef(
+ resource="experiment", id=str(experiment_id), team_id=self.team.id, created_by_id=self.user.id
+ ),
+ "viewer",
+ )
async def test_read_experiment_allowed_when_user_has_object_access(self):
flag = await FeatureFlag.objects.acreate(
team=self.team, key="allowed-exp-flag", name="Allowed Exp Flag", created_by=self.user
)
- experiment = await Experiment.objects.acreate(
- team=self.team, name="Allowed Experiment", feature_flag=flag, created_by=self.user
+ experiment_id = await acreate_experiment(
+ team_id=self.team.id, feature_flag_id=flag.id, name="Allowed Experiment", created_by_id=self.user.id
)
user = MagicMock()
@@ -1808,12 +1814,12 @@ class TestReadDataTool(BaseTest):
)
with patch.object(tool, "user_access_control") as mock_uac:
- mock_uac.check_access_level_for_object.return_value = True
+ mock_uac.check_access_level_for_ref.return_value = True
- result, artifact = await tool._arun_impl({"kind": "experiment", "id": experiment.id})
+ result, artifact = await tool._arun_impl({"kind": "experiment", "id": experiment_id})
assert "Allowed Experiment" in result
- mock_uac.check_access_level_for_object.assert_called_once()
+ mock_uac.check_access_level_for_ref.assert_called_once()
async def test_read_activity_log_delegates_to_activity_log_context(self):
state = AssistantState(messages=[], root_tool_call_id=str(uuid4()))
diff --git a/ee/hogai/tools/read_data/tool.py b/ee/hogai/tools/read_data/tool.py
index 85a84c1f09ab..032fe2879272 100644
--- a/ee/hogai/tools/read_data/tool.py
+++ b/ee/hogai/tools/read_data/tool.py
@@ -882,8 +882,10 @@ class ReadDataTool(HogQLDatabaseMixin, MaxTool):
if experiment is None:
raise MaxToolRetryableError(context.get_not_found_message())
- await self.check_object_access(experiment, "viewer", resource="experiment", action="read")
- return await context.format_experiment(experiment)
+ await self.check_object_access(
+ context.object_access_ref(experiment), "viewer", resource="experiment", action="read"
+ )
+ return context.format_experiment(experiment)
async def _read_account(self, account_id: str | None, external_id: str | None) -> str:
if account_id is None and external_id is None:
diff --git a/ee/vercel/integration.py b/ee/vercel/integration.py
index 0db984aee87c..967e6fdd6a90 100644
--- a/ee/vercel/integration.py
+++ b/ee/vercel/integration.py
@@ -3,7 +3,7 @@ import hmac
import hashlib
from collections.abc import Callable
from dataclasses import asdict, dataclass, field
-from typing import Any, Literal, Union
+from typing import Any, Literal
from urllib.parse import quote, urlencode
from django.conf import settings
@@ -37,7 +37,8 @@ from posthog.models.user import User
from posthog.schema_enums import ProductIntentContext, ProductKey
from posthog.utils import absolute_uri
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.api import get_experiment_team_id
+from products.experiments.backend.facade.contracts import ExperimentChanged
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from products.security.backend.facade.api import REFUSAL_CODE as SECURITY_REFUSAL_CODE
@@ -137,9 +138,15 @@ class VercelSetupResult:
resource_id: str
-@dataclass
+def _get_feature_flag_team_id(flag_id: int) -> int | None:
+ # nosemgrep: idor-lookup-without-team (the SSO redirect checks the user's membership in the returned team)
+ return FeatureFlag.objects.filter(pk=flag_id).values_list("team_id", flat=True).first()
+
+
+@frozen
class SSOExperimentationConfig:
- model: Union[type[FeatureFlag], type[Experiment]]
+ # The team of the item with this id, or None when there is no such item.
+ get_team_id: Callable[[int], int | None]
url_template: str
@@ -175,11 +182,11 @@ class VercelIntegration:
# this could be handled in the frontend instead.
SSO_EXPERIMENTATION_CONFIG: dict[str, SSOExperimentationConfig] = {
"flag": SSOExperimentationConfig(
- model=FeatureFlag,
+ get_team_id=_get_feature_flag_team_id,
url_template="/project/{team_id}/feature-flags/{item_pk}",
),
"experiment": SSOExperimentationConfig(
- model=Experiment,
+ get_team_id=get_experiment_team_id,
url_template="/project/{team_id}/experiments/{item_pk}",
),
}
@@ -885,22 +892,22 @@ class VercelIntegration:
)
@staticmethod
- def sync_experiment_to_vercel(experiment: Experiment, created: bool) -> None:
- vercel_item = VercelIntegration._convert_experiment_to_vercel_item(experiment, created)
+ def sync_experiment_to_vercel(team: Team, experiment: ExperimentChanged) -> None:
+ vercel_item = VercelIntegration._convert_experiment_to_vercel_item(experiment)
VercelIntegration._sync_item_to_vercel(
- team=experiment.team,
+ team=team,
item_type="experiment",
- item_pk=experiment.pk,
+ item_pk=experiment.experiment_id,
vercel_item=vercel_item,
- created=created,
+ created=experiment.created,
)
@staticmethod
- def delete_experiment_from_vercel(experiment: Experiment) -> None:
+ def delete_experiment_from_vercel(team: Team, experiment_id: int) -> None:
VercelIntegration._delete_item_from_vercel(
- team=experiment.team,
+ team=team,
item_type="experiment",
- item_id=VercelIntegration._get_vercel_item_id("experiment", experiment.pk),
+ item_id=VercelIntegration._get_vercel_item_id("experiment", experiment_id),
)
@staticmethod
@@ -918,11 +925,14 @@ class VercelIntegration:
}
@staticmethod
- def _convert_experiment_to_vercel_item(experiment: Experiment, created: bool) -> dict:
+ def _convert_experiment_to_vercel_item(experiment: ExperimentChanged) -> dict:
+ experiment_id = experiment.experiment_id
return {
- **({"id": VercelIntegration._get_vercel_item_id("experiment", experiment.pk)} if created else {}),
- "slug": slugify(experiment.name) or f"experiment-{experiment.pk}",
- "origin": absolute_uri(f"/project/{experiment.team.id}/experiments/{experiment.pk}"),
+ **(
+ {"id": VercelIntegration._get_vercel_item_id("experiment", experiment_id)} if experiment.created else {}
+ ),
+ "slug": slugify(experiment.name) or f"experiment-{experiment_id}",
+ "origin": absolute_uri(f"/project/{experiment.team_id}/experiments/{experiment_id}"),
"category": "experiment",
"name": experiment.name,
"description": experiment.description or "",
@@ -1338,16 +1348,15 @@ class VercelIntegration:
if not config:
return None
- model_class = config.model
- item = model_class.objects.filter(pk=item_pk).first()
- if not item:
+ team_id = config.get_team_id(item_pk)
+ if team_id is None:
return None
# Sanity check to ensure the user has access to the item's team
- if not user.teams.filter(pk=item.team.pk).exists():
+ if not user.teams.filter(pk=team_id).exists():
return None
- return config.url_template.format(team_id=item.team.id, item_pk=item.pk)
+ return config.url_template.format(team_id=team_id, item_pk=item_pk)
@staticmethod
def _parse_sso_item_id(item_id: str) -> tuple[str | None, int | None]:
diff --git a/ee/vercel/receivers.py b/ee/vercel/receivers.py
index bb9f335abe38..33ac2e4770a8 100644
--- a/ee/vercel/receivers.py
+++ b/ee/vercel/receivers.py
@@ -2,7 +2,7 @@
Wired from ``EnterpriseConfig.ready()``. Kept apart from ``ee.vercel.integration`` so that
django.setup() does not import that module (and everything it reaches) in every process just
-to connect four receivers; the integration is imported when a receiver actually fires.
+to connect three receivers; the integration is imported when a receiver actually fires.
"""
from typing import Any
@@ -10,7 +10,10 @@ from typing import Any
from django.db.models.signals import post_delete, post_save
from django.dispatch import receiver
-from products.experiments.backend.models.experiment import Experiment
+from posthog.models.team import Team
+
+from products.experiments.backend.facade.change_signals import connect_experiment_changed
+from products.experiments.backend.facade.contracts import ExperimentChanged
from products.feature_flags.backend.models.feature_flag import FeatureFlag
@@ -54,41 +57,29 @@ def delete_resource_experimentation_item(sender: Any, instance: FeatureFlag, **k
)
-@receiver(post_save, sender=Experiment)
-def sync_experiment_experimentation_item(sender: Any, instance: Experiment, created: bool, **kwargs: Any) -> None:
+def sync_experiment_experimentation_item(sender: Any, change: ExperimentChanged, **kwargs: Any) -> None:
from ee.vercel.integration import ( # noqa: PLC0415 — keeps the heavy dep off the import path
VercelIntegration,
_safe_vercel_sync,
)
- if instance.deleted:
+ team = Team.objects.get(id=change.team_id)
+ # A soft delete and a hard delete both arrive with `deleted` set, and both remove the item from Vercel.
+ if change.deleted:
_safe_vercel_sync(
"delete experiment from Vercel",
- instance.pk,
- instance.team,
- lambda: VercelIntegration.delete_experiment_from_vercel(instance),
+ change.experiment_id,
+ team,
+ lambda: VercelIntegration.delete_experiment_from_vercel(team, change.experiment_id),
is_delete=True,
)
else:
_safe_vercel_sync(
"sync experiment to Vercel",
- instance.pk,
- instance.team,
- lambda: VercelIntegration.sync_experiment_to_vercel(instance, created),
+ change.experiment_id,
+ team,
+ lambda: VercelIntegration.sync_experiment_to_vercel(team, change),
)
-@receiver(post_delete, sender=Experiment)
-def delete_experiment_experimentation_item(sender: Any, instance: Experiment, **kwargs: Any) -> None:
- from ee.vercel.integration import ( # noqa: PLC0415 — keeps the heavy dep off the import path
- VercelIntegration,
- _safe_vercel_sync,
- )
-
- _safe_vercel_sync(
- "delete experiment from Vercel",
- instance.pk,
- instance.team,
- lambda: VercelIntegration.delete_experiment_from_vercel(instance),
- is_delete=True,
- )
+connect_experiment_changed(sync_experiment_experimentation_item, dispatch_uid="ee.vercel.sync_experiment")
diff --git a/ee/vercel/test/test_integration.py b/ee/vercel/test/test_integration.py
index a0f62d90814e..11af96a76a26 100644
--- a/ee/vercel/test/test_integration.py
+++ b/ee/vercel/test/test_integration.py
@@ -1,3 +1,4 @@
+from datetime import UTC, datetime
from typing import Any
from urllib.parse import parse_qs, urlparse
@@ -26,8 +27,10 @@ from posthog.models.organization_provisioning import OrganizationProvisioning
from posthog.models.team import Team
from posthog.models.user import User
from posthog.models.webauthn_credential import WebauthnCredential
+from posthog.utils import absolute_uri
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.contracts import ExperimentChanged
+from products.experiments.backend.facade.testing import create_experiment, delete_experiment, update_experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from ee.api.vercel.types import VercelUserClaims
@@ -69,16 +72,6 @@ class TestVercelIntegration(TestCase):
deleted=archived,
)
- def make_experiment(self, team, name, description, archived):
- ff = FeatureFlag.objects.create(team=team, key="exp-flag")
- return Experiment.objects.create(
- team=team,
- name=name,
- description=description,
- archived=archived,
- feature_flag=ff,
- )
-
def assert_vercel_item(
self, item, result, category, is_archived, slug=None, expected_name=None, expected_description=None
):
@@ -1008,54 +1001,48 @@ class TestVercelIntegration(TestCase):
@parameterized.expand(
[
- (
- "flag",
- "make_feature_flag",
- VercelIntegration._convert_feature_flag_to_vercel_item,
- "flag",
- "test_flag",
- "Test Feature Flag",
- False,
- "test-flag",
- ),
- (
- "flag_deleted",
- "make_feature_flag",
- VercelIntegration._convert_feature_flag_to_vercel_item,
- "flag",
- "deleted_flag",
- "Deleted Flag",
- True,
- "deleted-flag",
- ),
- (
- "experiment",
- "make_experiment",
- VercelIntegration._convert_experiment_to_vercel_item,
- "experiment",
- "Test Experiment",
- "A test experiment",
- False,
- "test-experiment",
- ),
- (
- "experiment_archived",
- "make_experiment",
- VercelIntegration._convert_experiment_to_vercel_item,
- "experiment",
- "Archived Experiment",
- "",
- True,
- "archived-experiment",
- ),
+ ("flag", "test_flag", "Test Feature Flag", False, "test-flag"),
+ ("flag_deleted", "deleted_flag", "Deleted Flag", True, "deleted-flag"),
]
)
- def test_convert_to_vercel_item(self, _, factory_name, converter, category, name, desc, archived, expected_slug):
+ def test_convert_feature_flag_to_vercel_item(self, _, name, desc, archived, expected_slug):
team, _ = self.make_team_with_vercel(self.organization, self.user)
- factory = getattr(self, factory_name)
- item = factory(team, name, desc, archived)
- result = converter(item, created=True)
- self.assert_vercel_item(item, result, category, archived, expected_slug, name, desc)
+ item = self.make_feature_flag(team, name, desc, archived)
+ result = VercelIntegration._convert_feature_flag_to_vercel_item(item, created=True)
+ self.assert_vercel_item(item, result, "flag", archived, expected_slug, name, desc)
+
+ @parameterized.expand(
+ [
+ ("created", True, False, False, {"id": "experiment_7", "isArchived": False}),
+ ("archived", False, True, False, {"isArchived": True}),
+ ("deleted", False, False, True, {"isArchived": True}),
+ ]
+ )
+ def test_convert_experiment_to_vercel_item(
+ self, _name: str, created: bool, archived: bool, deleted: bool, expected_fields: dict[str, Any]
+ ) -> None:
+ change = ExperimentChanged(
+ team_id=3,
+ experiment_id=7,
+ created=created,
+ deleted=deleted,
+ name="Checkout Test",
+ description=None,
+ archived=archived,
+ created_at=datetime(2026, 9, 1, tzinfo=UTC),
+ updated_at=datetime(2026, 9, 2, 12, tzinfo=UTC),
+ )
+
+ assert VercelIntegration._convert_experiment_to_vercel_item(change) == {
+ **expected_fields,
+ "slug": "checkout-test",
+ "origin": absolute_uri("/project/3/experiments/7"),
+ "category": "experiment",
+ "name": "Checkout Test",
+ "description": "",
+ "createdAt": 1788220800000,
+ "updatedAt": 1788350400000,
+ }
@parameterized.expand(
[
@@ -1158,25 +1145,22 @@ class TestVercelIntegration(TestCase):
mock_sync.assert_called_once_with(feature_flag, False)
+ @parameterized.expand([("soft_delete", False), ("hard_delete", True)])
@patch("ee.vercel.integration.VercelIntegration.delete_experiment_from_vercel")
- def test_experiment_post_save_signal_deletes_when_marked_deleted(self, mock_delete):
- """Test that post_save signal triggers deletion when experiment is marked as deleted=True"""
+ def test_experiment_delete_removes_the_item_from_vercel(self, _name, hard_delete, mock_delete):
team, _ = self.make_team_with_vercel(self.organization, self.user)
feature_flag = FeatureFlag.objects.create(team=team, key="exp-flag")
- experiment = Experiment.objects.create(
- team=team,
- name="test_experiment",
- feature_flag=feature_flag,
- deleted=False,
- )
+ experiment_id = create_experiment(team_id=team.id, feature_flag_id=feature_flag.id, name="test_experiment")
mock_delete.reset_mock()
- experiment.deleted = True
- experiment.save()
+ if hard_delete:
+ delete_experiment(team_id=team.id, experiment_id=experiment_id)
+ else:
+ update_experiment(team_id=team.id, experiment_id=experiment_id, deleted=True)
- mock_delete.assert_called_once_with(experiment)
+ mock_delete.assert_called_once_with(team, experiment_id)
@patch("ee.vercel.integration.VercelIntegration.sync_experiment_to_vercel")
def test_experiment_post_save_signal_syncs_when_not_deleted(self, mock_sync):
@@ -1185,20 +1169,28 @@ class TestVercelIntegration(TestCase):
feature_flag = FeatureFlag.objects.create(team=team, key="exp-flag")
- experiment = Experiment.objects.create(
- team=team,
- name="test_experiment",
- feature_flag=feature_flag,
- deleted=False,
- )
+ experiment_id = create_experiment(team_id=team.id, feature_flag_id=feature_flag.id, name="test_experiment")
- mock_sync.assert_called_with(experiment, True)
+ mock_sync.assert_called_with(team, mock.ANY)
+ assert mock_sync.call_args.args[1].created is True
mock_sync.reset_mock()
- experiment.name = "Updated Test Experiment"
- experiment.save()
+ update_experiment(team_id=team.id, experiment_id=experiment_id, name="Updated Test Experiment")
+
+ mock_sync.assert_called_once_with(team, mock.ANY)
+ change = mock_sync.call_args.args[1]
+ assert (change.experiment_id, change.created, change.name) == (experiment_id, False, "Updated Test Experiment")
+
+ @parameterized.expand([("member", True), ("not_a_member", False)])
+ def test_sso_redirect_url_for_an_experiment(self, _name, is_member):
+ organization = self.organization if is_member else Organization.objects.create(name="Other Org")
+ team = Team.objects.create(organization=organization, name="Experiment Team")
+ feature_flag = FeatureFlag.objects.create(team=team, key="exp-flag")
+ experiment_id = create_experiment(team_id=team.id, feature_flag_id=feature_flag.id)
+
+ url = VercelIntegration._get_sso_experimentation_url(f"experiment_{experiment_id}", self.user)
- mock_sync.assert_called_once_with(experiment, False)
+ assert url == (f"/project/{team.id}/experiments/{experiment_id}" if is_member else None)
@parameterized.expand(
[
diff --git a/posthog/test/repo_invariants/dataclass_frozen_baseline.txt b/posthog/test/repo_invariants/dataclass_frozen_baseline.txt
index 1ffcf812c1c2..e5ee15496956 100644
--- a/posthog/test/repo_invariants/dataclass_frozen_baseline.txt
+++ b/posthog/test/repo_invariants/dataclass_frozen_baseline.txt
@@ -1386,6 +1386,7 @@
5 products/managed_warehouse/backend/temporal/ducklake_copy_data_modeling_workflow.py
5 products/notebooks/backend/kernel_runtime.py
5 products/tasks/backend/temporal/execute_sandbox/workflow.py
+6 ee/vercel/integration.py
6 posthog/dags/deletes.py
6 posthog/hogql/base.py
6 posthog/hogql/scripts/build_grammar_strategies.py
@@ -1408,7 +1409,6 @@
7 products/skills/backend/api/skill_services.py
7 products/web_analytics/backend/temporal/digest_notification/types.py
7 products/web_analytics/backend/temporal/weekly_digest/types.py
-8 ee/vercel/integration.py
8 posthog/temporal/ai_observability/evaluation_clustering/activities.py
8 posthog/temporal/delete_teams/types.py
8 products/signals/backend/temporal/signal_queries.py
diff --git a/posthog/test/repo_invariants/setup_receivers_baseline.txt b/posthog/test/repo_invariants/setup_receivers_baseline.txt
index 3799128632c5..46d24b28acb0 100644
--- a/posthog/test/repo_invariants/setup_receivers_baseline.txt
+++ b/posthog/test/repo_invariants/setup_receivers_baseline.txt
@@ -3,6 +3,7 @@
# UPDATE_SETUP_RECEIVERS_BASELINE=1 pytest posthog/test/repo_invariants/test_startup_import_budget.py -k receivers_match
# A receiver disappearing from this set means it connects in NO process (silent audit/cache loss):
# restore its AppConfig.ready() wiring instead of deleting the line.
+experiment_changed:ee.vercel.receivers.sync_experiment_experimentation_item
model_activity:posthog.models.activity_logging.signal_handlers.handle_identity_provider_config_change
model_activity:posthog.models.activity_logging.signal_handlers.handle_oauth_application_scopes_change
model_activity:posthog.models.activity_logging.signal_handlers.handle_organization_change
@@ -62,7 +63,6 @@ model_activity:products.tracing.backend.activity_logging.handle_traces_retention
model_activity:products.warehouse_sources.backend.activity_logging.handle_external_data_schema_change
model_activity:products.warehouse_sources.backend.activity_logging.handle_external_data_source_change
model_activity:products.warehouse_suggestions.backend.activity_logging.handle_warehouse_suggestion_activity
-post_delete:ee.vercel.receivers.delete_experiment_experimentation_item
post_delete:ee.vercel.receivers.delete_resource_experimentation_item
post_delete:posthog.caching.organization_serializer_cache._connect_invalidation.<locals>.receiver_fn
post_delete:posthog.models.event_ingestion_restriction_config.delete_redis_cache_with_config
@@ -139,7 +139,6 @@ post_init:posthog.storage.gateway_credential_signal_handlers._snapshot_secret_ke
post_init:posthog.storage.gateway_credential_signal_handlers._snapshot_user
post_init:posthog.storage.team_llm_gateway_policy_signal_handlers._snapshot_loaded_state
post_save:ee.models.license.license_saved
-post_save:ee.vercel.receivers.sync_experiment_experimentation_item
post_save:ee.vercel.receivers.sync_feature_flag_experimentation_item
post_save:posthog.caching.organization_serializer_cache._connect_invalidation.<locals>.receiver_fn
post_save:posthog.models.activity_logging.activity_log.activity_log_created
diff --git a/posthog/test/repo_invariants/test_startup_import_budget.py b/posthog/test/repo_invariants/test_startup_import_budget.py
index cd9ab161db6f..d200d3dd4f86 100644
--- a/posthog/test/repo_invariants/test_startup_import_budget.py
+++ b/posthog/test/repo_invariants/test_startup_import_budget.py
@@ -145,6 +145,7 @@ def test_all_models_register_at_app_population_not_via_router() -> None:
# alerts, ee, and posthog core); this guards against new viewset-only receivers sneaking back in.
_ROUTER_RECEIVER_DIFF = """
import os
+import sys
import weakref
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "posthog.settings")
@@ -155,14 +156,21 @@ from django.contrib.auth import signals as auth_signals
from django.db.models import signals
from posthog.models.signals import model_activity_signal
+# Looked up instead of imported: an import here would connect the experiments save receivers before `before`, so the
+# diff would miss them if only the router imported their module.
+experiment_changed = sys.modules["products.experiments.backend.facade.change_signals"].experiment_changed
+
_SIGNALS = ["pre_save", "post_save", "pre_delete", "post_delete", "m2m_changed", "pre_init", "post_init"]
# model_activity_signal is PostHog's custom audit-log signal, not a django.db.models one. Its
# `handle_*_change` receivers live in viewset modules, so they are exactly the kind that the eager
# router used to wire as a side effect — include it or this whole class of regression is invisible.
# Auth signals are included for parity with the setup-receivers baseline: an auth receiver wired
# only via a viewset import would otherwise slip past both guards.
+# experiment_changed is the experiments facade's hook for experiment saves and deletes. Its receivers take the place
+# of model-signal receivers on the experiment model, so they need the same guard.
_CUSTOM_SIGNALS = {
"model_activity": model_activity_signal,
+ "experiment_changed": experiment_changed,
"user_logged_in": auth_signals.user_logged_in,
"user_logged_out": auth_signals.user_logged_out,
"user_login_failed": auth_signals.user_login_failed,
@@ -234,6 +242,7 @@ _RECEIVERS_BASELINE = Path(__file__).parent / "setup_receivers_baseline.txt"
_SETUP_RECEIVERS_CAPTURE = """
import os
+import sys
import weakref
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "posthog.settings")
@@ -251,6 +260,9 @@ _SIGNALS = {
}
_SIGNALS |= {name: getattr(auth_signals, name) for name in ("user_logged_in", "user_logged_out", "user_login_failed")}
_SIGNALS["model_activity"] = model_activity_signal
+# Looked up instead of imported: an import here would connect the experiments save receivers itself, which would hide
+# a dropped import from an AppConfig.ready().
+_SIGNALS["experiment_changed"] = sys.modules["products.experiments.backend.facade.change_signals"].experiment_changed
out = set()
for signal_name, signal in _SIGNALS.items():
diff --git a/products/experiments/backend/facade/api.py b/products/experiments/backend/facade/api.py
index 236757e7edf0..58b4a6158d62 100644
--- a/products/experiments/backend/facade/api.py
+++ b/products/experiments/backend/facade/api.py
@@ -40,6 +40,7 @@ from products.experiments.backend.hogql_queries.exposure_query_logic import (
normalize_to_exposure_criteria,
resolve_default_exposure_event,
)
+from products.experiments.backend.hogql_queries.utils import get_experiment_stats_method
from products.experiments.backend.metric_calculation.config import (
build_primary_calculation_configs,
calculation_metric_name,
@@ -62,7 +63,9 @@ from .contracts import (
DigestLaunchedExperiment,
EndedExperiment,
Experiment,
+ ExperimentAssistantContext,
ExperimentDetectableEffectCheckpoint,
+ ExperimentFlagVariantSplit,
ExperimentHealth,
ExperimentHealthReaderAccess,
ExperimentRunningTimeOutlook,
@@ -326,6 +329,60 @@ def count_enrolled_people(*, team: Team, user: User, flag_keys: list[str]) -> di
return enrolled_people_by_flag(team, user, flag_keys)
+def _to_assistant_context(experiment: ExperimentModel) -> ExperimentAssistantContext:
+ flag = experiment.feature_flag
+ return ExperimentAssistantContext(
+ id=experiment.id,
+ team_id=experiment.team_id,
+ created_by_id=experiment.created_by_id,
+ name=experiment.name,
+ description=experiment.description,
+ type=experiment.type,
+ start_date=experiment.start_date,
+ end_date=experiment.end_date,
+ created_at=experiment.created_at,
+ conclusion=experiment.conclusion,
+ conclusion_comment=experiment.conclusion_comment,
+ stats_method=get_experiment_stats_method(experiment),
+ variant_names={key: variant.get("name", key) for key, variant in (experiment.variants or {}).items()},
+ feature_flag_key=flag.key,
+ feature_flag_variants=tuple(
+ ExperimentFlagVariantSplit(key=variant.get("key"), rollout_percentage=variant.get("rollout_percentage", 0))
+ for variant in flag.variants
+ ),
+ )
+
+
+async def aget_experiment_assistant_context(
+ team_id: int, *, experiment_id: int | None = None, feature_flag_key: str | None = None
+) -> ExperimentAssistantContext | None:
+ """The experiment with `experiment_id`, or else the experiment on the flag with `feature_flag_key`. None when
+ neither is given, or when no experiment of the team matches. Only rows whose `deleted` is false match, so a row
+ whose `deleted` is NULL does not."""
+ # `team=` matches the id exactly, so the result's `team_id` is always `team_id`, which an object access check of
+ # the caller's team requires. RootTeamQuerySet rewrites a `team_id=` filter to the project's root team.
+ experiments = ExperimentModel.objects.select_related("feature_flag").filter(team=team_id, deleted=False)
+ try:
+ if experiment_id is not None:
+ experiment = await experiments.aget(id=experiment_id)
+ elif feature_flag_key is not None:
+ experiment = await experiments.aget(feature_flag__key=feature_flag_key)
+ else:
+ return None
+ except ExperimentModel.DoesNotExist:
+ return None
+ return _to_assistant_context(experiment)
+
+
+def get_experiment_team_id(experiment_id: int) -> int | None:
+ """The team of the experiment with this id, deleted experiments included. None when no experiment has the id.
+
+ The lookup is not scoped to a team, so the caller must check that the user may see the returned team."""
+ # The Vercel SSO redirect has no team yet. It checks the user's membership in the returned team.
+ # nosemgrep: idor-lookup-without-team
+ return ExperimentModel.objects.filter(pk=experiment_id).values_list("team_id", flat=True).first()
+
+
def team_has_launched_experiments(team_id: int) -> bool:
"""Whether the team has a running or stopped experiment, deleted and archived ones included. Experiments are saved
on the project's root team, so pass that team's id."""
diff --git a/products/experiments/backend/facade/contracts.py b/products/experiments/backend/facade/contracts.py
index d604c05035f8..3bd1c62cf55b 100644
--- a/products/experiments/backend/facade/contracts.py
+++ b/products/experiments/backend/facade/contracts.py
@@ -9,7 +9,7 @@ from collections.abc import Mapping
from dataclasses import dataclass, field
from datetime import datetime
from decimal import Decimal
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, Literal
from posthog.dataclasses import frozen
from posthog.enums import LabeledStrEnum
@@ -159,6 +159,41 @@ class ExperimentPromptContext:
primary_metric_names: tuple[str, ...]
+@frozen
+class ExperimentFlagVariantSplit:
+ """One variant of the experiment's flag and its share of the rollout, as the flag stores them."""
+
+ # None when the stored variant has no key.
+ key: str | None
+ # As stored, so a whole number stays an int and a prompt prints `50%`, not `50.0%`. 0 when the variant has none.
+ rollout_percentage: float
+
+
+@frozen
+class ExperimentAssistantContext:
+ """What PostHog AI reads to describe an experiment and its results."""
+
+ id: int
+ # With `id`, the fields that an object access check reads.
+ team_id: int
+ created_by_id: int | None
+ name: str
+ description: str | None
+ type: str | None
+ start_date: datetime | None
+ end_date: datetime | None
+ created_at: datetime
+ conclusion: str | None
+ conclusion_comment: str | None
+ stats_method: Literal["bayesian", "frequentist"]
+ # Variant names by key from the experiment's own variants field, which web experiments write. A variant without a
+ # name maps to its key.
+ variant_names: Mapping[str, str]
+ feature_flag_key: str
+ # Every variant of the flag, in the flag's order. Excluded variants are not removed.
+ feature_flag_variants: tuple[ExperimentFlagVariantSplit, ...]
+
+
@frozen
class SessionAttribution:
"""One person's attribution in an experiment's exposed population, as the analysis buckets it."""
diff --git a/products/experiments/backend/max_tools.py b/products/experiments/backend/max_tools.py
index e5b9da1ca79c..41c3a5f5ebcb 100644
--- a/products/experiments/backend/max_tools.py
+++ b/products/experiments/backend/max_tools.py
@@ -10,7 +10,7 @@ from posthog.sync import database_sync_to_async
from products.experiments.backend.experiment_service import ExperimentService
from products.experiments.backend.experiment_summary_data_service import ExperimentSummaryDataService
-from products.experiments.backend.hogql_queries.utils import get_experiment_stats_method
+from products.experiments.backend.facade.contracts import ExperimentAssistantContext
from products.experiments.backend.models.experiment import Experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag, experiment_eligibility_error
@@ -260,7 +260,9 @@ class ExperimentSummaryTool(MaxTool):
return f"Experiment {experiment_id} not found", {"error": "not_found"}
# Before the metric queries run, so a denied user costs no ClickHouse work
- await self.check_object_access(experiment, "viewer", resource="experiment", action="read")
+ await self.check_object_access(
+ experiment_context.object_access_ref(experiment), "viewer", resource="experiment", action="read"
+ )
data_service = ExperimentSummaryDataService(self._team, self._user)
@@ -271,7 +273,7 @@ class ExperimentSummaryTool(MaxTool):
summary_context = summary_data.context
- formatted_data = await experiment_context.format_experiment_results_data(
+ formatted_data = experiment_context.format_experiment_results_data(
experiment,
exposures=summary_context.exposures,
primary_metrics_results=summary_context.primary_metrics_results,
@@ -295,19 +297,18 @@ class ExperimentSummaryTool(MaxTool):
def _build_result(
self,
- experiment: Experiment,
+ experiment: ExperimentAssistantContext,
formatted_data: str,
primary_metrics: list,
secondary_metrics: list,
) -> tuple[str, dict[str, Any]]:
"""Build the final result tuple with artifact metadata."""
- stats_method = get_experiment_stats_method(experiment)
- variants = [v.get("key") for v in experiment.feature_flag.variants if v.get("key")]
+ variants = [v.key for v in experiment.feature_flag_variants if v.key]
return formatted_data, {
"experiment_id": experiment.id,
"experiment_name": experiment.name,
- "stats_method": stats_method,
+ "stats_method": experiment.stats_method,
"variants": variants,
"has_results": bool(primary_metrics or secondary_metrics),
}
diff --git a/products/experiments/backend/test/test_facade.py b/products/experiments/backend/test/test_facade.py
index 56513e6947af..d9f424882d76 100644
--- a/products/experiments/backend/test/test_facade.py
+++ b/products/experiments/backend/test/test_facade.py
@@ -20,6 +20,7 @@ from unittest.mock import MagicMock, patch
from django.utils import timezone
+from asgiref.sync import async_to_sync
from parameterized import parameterized
from posthog.models.organization import Organization
@@ -36,7 +37,9 @@ from products.experiments.backend.facade.contracts import (
DigestCompletedExperiment,
DigestLaunchedExperiment,
EndedExperiment,
+ ExperimentAssistantContext,
ExperimentChanged,
+ ExperimentFlagVariantSplit,
ExperimentValidationError,
LinkedExperiment,
StoredPrimaryResult,
@@ -494,6 +497,97 @@ class TestTeamHasLaunchedExperiments(BaseTest):
assert api.team_has_launched_experiments(self.team.id) is expected
+class TestExperimentAssistantContext(BaseTest):
+ def _create_experiment(self, team: Team, *, deleted: bool = False) -> Experiment:
+ flag = FeatureFlag.objects.create(
+ team=team,
+ key="checkout",
+ created_by=self.user,
+ filters={
+ "multivariate": {
+ "variants": [
+ {"key": "control", "rollout_percentage": 50},
+ {"key": "test", "rollout_percentage": 50},
+ ]
+ }
+ },
+ )
+ return Experiment.objects.create(
+ team=team,
+ name="Checkout test",
+ description="Does the new checkout convert better?",
+ feature_flag=flag,
+ created_by=self.user,
+ start_date=datetime(2026, 9, 1, tzinfo=UTC),
+ conclusion="won",
+ variants={"control": {"name": "Old checkout"}, "test": {}},
+ stats_config={"method": "frequentist"},
+ deleted=deleted,
+ )
+
+ @parameterized.expand([("by_id", True), ("by_flag_key", False)])
+ def test_reads_the_experiment_with_its_flag(self, _name: str, by_id: bool) -> None:
+ experiment = self._create_experiment(self.team)
+
+ context = async_to_sync(api.aget_experiment_assistant_context)(
+ self.team.id,
+ experiment_id=experiment.id if by_id else None,
+ feature_flag_key=None if by_id else "checkout",
+ )
+
+ assert context == ExperimentAssistantContext(
+ id=experiment.id,
+ team_id=self.team.id,
+ created_by_id=self.user.id,
+ name="Checkout test",
+ description="Does the new checkout convert better?",
+ type="product",
+ start_date=datetime(2026, 9, 1, tzinfo=UTC),
+ end_date=None,
+ created_at=experiment.created_at,
+ conclusion="won",
+ conclusion_comment=None,
+ stats_method="frequentist",
+ variant_names={"control": "Old checkout", "test": "test"},
+ feature_flag_key="checkout",
+ feature_flag_variants=(
+ ExperimentFlagVariantSplit(key="control", rollout_percentage=50),
+ ExperimentFlagVariantSplit(key="test", rollout_percentage=50),
+ ),
+ )
+
+ @parameterized.expand(
+ [
+ ("deleted", "own", "own", True),
+ ("another_team", "other", "own", False),
+ # Experiments save on the project's root team. An environment's id must not match them, because the
+ # caller checks object access against its own team.
+ ("environment_of_the_project", "own", "environment", False),
+ ]
+ )
+ def test_does_not_read(self, _name: str, experiment_team: str, lookup_team: str, deleted: bool) -> None:
+ teams = {
+ "own": self.team,
+ "other": Team.objects.create(organization=self.organization, name="Other"),
+ "environment": Team.objects.create(organization=self.organization, name="Env", parent_team=self.team),
+ }
+ experiment = self._create_experiment(teams[experiment_team], deleted=deleted)
+ aget_context = async_to_sync(api.aget_experiment_assistant_context)
+
+ assert aget_context(teams[lookup_team].id, experiment_id=experiment.id) is None
+ assert aget_context(teams[lookup_team].id, feature_flag_key="checkout") is None
+
+
+class TestGetExperimentTeamId(BaseTest):
+ def test_reads_the_team_of_any_experiment_including_a_deleted_one(self) -> None:
+ other_team = Team.objects.create(organization=Organization.objects.create(name="Other"), name="Other")
+ flag = FeatureFlag.objects.create(team=other_team, key="experiment-flag")
+ experiment = Experiment.objects.create(team=other_team, name="Experiment", feature_flag=flag, deleted=True)
+
+ assert api.get_experiment_team_id(experiment.id) == other_team.id
+ assert api.get_experiment_team_id(-1) is None
+
+
class TestExperimentFlagIds(BaseTest):
@parameterized.expand(
[
diff --git a/products/experiments/backend/test/test_max_tools.py b/products/experiments/backend/test/test_max_tools.py
index ff928d171abc..ef7c48c1e578 100644
--- a/products/experiments/backend/test/test_max_tools.py
+++ b/products/experiments/backend/test/test_max_tools.py
@@ -728,7 +728,7 @@ class TestExperimentSummaryTool(APIBaseTest):
# Denied before any metric queries run
tool = self._create_tool({})
with patch.object(tool, "user_access_control") as mock_uac:
- mock_uac.check_access_level_for_object.return_value = False
+ mock_uac.check_access_level_for_ref.return_value = False
with self.assertRaises(MaxToolAccessDeniedError):
await tool._arun_impl(experiment_id=experiment.id)
diff --git a/tach.toml b/tach.toml
index bffb116ff9ac..a306c3a7111b 100644
--- a/tach.toml
+++ b/tach.toml
@@ -1349,7 +1349,6 @@ expose = [
"backend\\.experiment_service.*",
"backend\\.hogql_queries.*",
"backend\\.llm_metric_templates.*",
- "backend\\.max_tools.*",
"backend\\.metric_utils.*",
"backend\\.models.*",
"stats\\..*",