Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(replay): keep quill menu item keys unique (#127857)

Hayne Ryuee08542274e6
diff --git a/frontend/src/scenes/session-recordings/playlist/QuillMenuItems.tsx b/frontend/src/scenes/session-recordings/playlist/QuillMenuItems.tsx
index 64e8b68fbdab..a190f579e8c0 100644
--- a/frontend/src/scenes/session-recordings/playlist/QuillMenuItems.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/QuillMenuItems.tsx
@@ -42,10 +42,8 @@ function isNode(item: MenuEntry): item is LemonMenuItemNode {
}
function itemKey(item: LemonMenuItem, index: number): string {
- if (isCustom(item)) {
- return String(item.key ?? index)
- }
- return String(item.key ?? item['data-attr'] ?? (typeof item.label === 'string' ? item.label : index))
+ // Items in one menu often share a data-attr, so the index keeps keys and radio values unique.
+ return `${index}-${String(item.key ?? (isCustom(item) ? '' : (item['data-attr'] ?? item.label)))}`
}
/** Renders Lemon menu item definitions as quill dropdown menu content, so the Lemon and quill menus share one list. */