Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

refactor(experiments): seed core tests through the facade (#125901)

Andersf286be1de942
diff --git a/posthog/api/file_system/test/test_file_system.py b/posthog/api/file_system/test/test_file_system.py
index d77ba3f9736f..c3d870f68366 100644
--- a/posthog/api/file_system/test/test_file_system.py
+++ b/posthog/api/file_system/test/test_file_system.py
@@ -42,7 +42,7 @@ from products.cdp.backend.models.hog_functions.hog_function import HogFunction,
from products.cohorts.backend.models.cohort import Cohort
from products.dashboards.backend.models.dashboard import Dashboard
from products.early_access_features.backend.models import EarlyAccessFeature
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.testing import create_experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from products.notebooks.backend.models import Notebook
from products.product_analytics.backend.facade.models import Insight
@@ -509,7 +509,7 @@ class TestFileSystemAPI(APIBaseTest):
"""
# Create 5 objects
ff = FeatureFlag.objects.create(team=self.team, key="Beta Feature", created_by=self.user)
- Experiment.objects.create(team=self.team, name="Experiment #1", created_by=self.user, feature_flag=ff)
+ create_experiment(team_id=self.team.id, name="Experiment #1", created_by_id=self.user.id, feature_flag_id=ff.id)
Dashboard.objects.create(team=self.team, name="User Dashboard", created_by=self.user)
Insight.objects.create(team=self.team, saved=True, name="Marketing Insight", created_by=self.user)
Notebook.objects.create(team=self.team, title="Data Exploration", created_by=self.user)
@@ -528,7 +528,9 @@ class TestFileSystemAPI(APIBaseTest):
Ensure that the 'type' query parameter filters creation to a single type.
"""
flag = FeatureFlag.objects.create(team=self.team, key="Only Flag", created_by=self.user)
- Experiment.objects.create(team=self.team, name="Experiment #1", feature_flag=flag, created_by=self.user)
+ create_experiment(
+ team_id=self.team.id, name="Experiment #1", feature_flag_id=flag.id, created_by_id=self.user.id
+ )
FileSystem.objects.all().delete()
# Filter for feature_flag only => creates 1 new 'leaf' item
@@ -2697,19 +2699,19 @@ class TestDestroyRepairsLeftoverHogFunctions(APIBaseTest):
def _prepare_experiment_case(self):
feature_flag = FeatureFlag.objects.create(team=self.team, key="exp-flag", created_by=self.user)
- experiment = Experiment.objects.create(
- team=self.team,
+ experiment_id = create_experiment(
+ team_id=self.team.id,
name="Experiment",
- feature_flag=feature_flag,
- created_by=self.user,
+ feature_flag_id=feature_flag.id,
+ created_by_id=self.user.id,
)
fs_entry = self._ensure_file_system_entry(
- file_type="experiment", ref=str(experiment.id), fallback_name=str(experiment.id)
+ file_type="experiment", ref=str(experiment_id), fallback_name=str(experiment_id)
)
return {
"fs_entry": fs_entry,
- "item_id": str(experiment.id),
- "ref": str(experiment.id),
+ "item_id": str(experiment_id),
+ "ref": str(experiment_id),
"path": fs_entry.path,
}
diff --git a/posthog/api/test/test_file_system.py b/posthog/api/test/test_file_system.py
index 32c6af8cab15..cc2fad1a640b 100644
--- a/posthog/api/test/test_file_system.py
+++ b/posthog/api/test/test_file_system.py
@@ -29,7 +29,7 @@ from products.cdp.backend.models.hog_functions.hog_function import HogFunction,
from products.cohorts.backend.models.cohort import Cohort
from products.dashboards.backend.models.dashboard import Dashboard
from products.early_access_features.backend.models import EarlyAccessFeature
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.testing import create_experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from products.notebooks.backend.models import Notebook
from products.product_analytics.backend.facade.models import Insight
@@ -52,23 +52,25 @@ def _create_feature_flag_case(testcase: "TestFileSystemViewSetLogging"):
return flag, url
-def _create_enterprise_experiment_case(testcase: "TestFileSystemViewSetLogging"):
- if not settings.EE_AVAILABLE:
- raise unittest.SkipTest("Enterprise features unavailable")
+def _feature_flag_view_target(testcase: APIBaseTest) -> tuple[str, str]:
+ flag = FeatureFlag.objects.create(team=testcase.team, key=f"test-flag-{uuid4().hex}", created_by=testcase.user)
+ representation = flag.get_file_system_representation()
+ return representation.type, str(representation.ref)
+
+
+def _experiment_view_target(testcase: APIBaseTest) -> tuple[str, str]:
flag = FeatureFlag.objects.create(
team=testcase.team,
key=f"exp-{uuid4().hex}",
created_by=testcase.user,
)
- experiment = Experiment.objects.create(
- team=testcase.team,
+ experiment_id = create_experiment(
+ team_id=testcase.team.id,
name="File system experiment",
- feature_flag=flag,
- created_by=testcase.user,
- type=Experiment.ExperimentType.PRODUCT,
+ feature_flag_id=flag.id,
+ created_by_id=testcase.user.id,
)
- url = f"/api/projects/{testcase.project.id}/experiments/{experiment.id}/"
- return experiment, url
+ return "experiment", str(experiment_id)
@dataclass(frozen=True)
@@ -130,19 +132,18 @@ FILE_SYSTEM_ACTIVITY_CASES: list[tuple[str, FileSystemActivityCase]] = [
FileSystemActivityCase(
type_string="experiment",
scope="Experiment",
- create_instance=lambda test: Experiment.objects.create(
- team=test.team,
+ create_instance=lambda test: create_experiment(
+ team_id=test.team.id,
name="File system experiment",
- feature_flag=FeatureFlag.objects.create(
+ feature_flag_id=FeatureFlag.objects.create(
team=test.team,
key=f"exp-ff-{uuid4().hex}",
created_by=test.user,
- ),
- created_by=test.user,
- type=Experiment.ExperimentType.PRODUCT,
+ ).id,
+ created_by_id=test.user.id,
),
- ref_getter=lambda instance: str(instance.id),
- item_id_getter=lambda instance: str(instance.id),
+ ref_getter=str,
+ item_id_getter=str,
),
),
(
@@ -531,29 +532,28 @@ class TestFileSystemLogViewEndpoint(APIBaseTest):
@parameterized.expand(
[
- ("feature_flag", _create_feature_flag_case, False),
- ("experiment", _create_enterprise_experiment_case, True),
+ ("feature_flag", _feature_flag_view_target, False),
+ ("experiment", _experiment_view_target, True),
]
)
- def test_log_view_endpoint_creates_entry(self, _name: str, setup_case, requires_ee: bool) -> None:
+ def test_log_view_endpoint_creates_entry(self, _name: str, view_target, requires_ee: bool) -> None:
if requires_ee and not settings.EE_AVAILABLE:
raise unittest.SkipTest("Enterprise features unavailable")
FileSystemViewLog.objects.all().delete()
- obj, _ = setup_case(self)
- representation = obj.get_file_system_representation()
+ file_type, ref = view_target(self)
response = self.client.post(
f"/api/environments/{self.team.id}/file_system/log_view/",
- {"type": representation.type, "ref": str(representation.ref)},
+ {"type": file_type, "ref": ref},
)
assert response.status_code == status.HTTP_204_NO_CONTENT
log_entry = FileSystemViewLog.objects.get()
- assert log_entry.type == representation.type
- assert log_entry.ref == str(representation.ref)
+ assert log_entry.type == file_type
+ assert log_entry.ref == ref
def test_log_view_endpoint_rejects_impersonated_session(self) -> None:
FileSystemViewLog.objects.all().delete()
diff --git a/posthog/hogql/database/schema/test/test_system_tables.py b/posthog/hogql/database/schema/test/test_system_tables.py
index efa347ca1f56..2b7a56373b6d 100644
--- a/posthog/hogql/database/schema/test/test_system_tables.py
+++ b/posthog/hogql/database/schema/test/test_system_tables.py
@@ -94,7 +94,7 @@ from products.error_tracking.backend.facade.testing import (
create_suppression_rule,
create_symbol_set,
)
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.testing import create_experiment
from products.exports.backend.models.exported_asset import ExportedAsset
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from products.logs.backend.models import LogsAlertConfiguration, LogsView
@@ -615,9 +615,9 @@ def _create_hog_function(team: Team, label: str) -> HogFunction:
)
-def _create_experiment(team: Team, label: str) -> Experiment:
+def _create_experiment(team: Team, label: str) -> int:
flag = FeatureFlag.objects.create(team=team, key=f"flag_for_exp_{label}")
- return Experiment.objects.create(team=team, name=f"experiment_{label}", feature_flag=flag)
+ return create_experiment(team_id=team.id, name=f"experiment_{label}", feature_flag_id=flag.id)
def _create_export(team: Team, label: str) -> ExportedAsset:
diff --git a/posthog/models/file_system/test/test_file_system.py b/posthog/models/file_system/test/test_file_system.py
index eaea382d93ec..ba67153dd189 100644
--- a/posthog/models/file_system/test/test_file_system.py
+++ b/posthog/models/file_system/test/test_file_system.py
@@ -17,7 +17,7 @@ from posthog.models.file_system.file_system import (
from posthog.models.file_system.unfiled_file_saver import save_unfiled_files
from products.dashboards.backend.models.dashboard import Dashboard
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.testing import create_experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from products.notebooks.backend.models import Notebook
from products.product_analytics.backend.facade.models import Insight
@@ -46,7 +46,7 @@ class TestFileSystemModel(TestCase):
"""
# Create some objects
ff = FeatureFlag.objects.create(team=self.team, key="Beta Feature", created_by=self.user)
- Experiment.objects.create(team=self.team, name="Experiment #1", created_by=self.user, feature_flag=ff)
+ create_experiment(team_id=self.team.id, name="Experiment #1", created_by_id=self.user.id, feature_flag_id=ff.id)
Dashboard.objects.create(team=self.team, name="Main Dashboard", created_by=self.user)
Insight.objects.create(team=self.team, name="Traffic Insight", created_by=self.user, saved=True)
Notebook.objects.create(team=self.team, title="Data Exploration", created_by=self.user)
@@ -95,7 +95,7 @@ class TestFileSystemModel(TestCase):
experiments should create FileSystem rows.
"""
ff = FeatureFlag.objects.create(team=self.team, key="Some Flag", created_by=self.user)
- Experiment.objects.create(team=self.team, name="Experiment #1", created_by=self.user, feature_flag=ff)
+ create_experiment(team_id=self.team.id, name="Experiment #1", created_by_id=self.user.id, feature_flag_id=ff.id)
FileSystem.objects.all().delete()
created = save_unfiled_files(self.team, self.user)
self.assertEqual(len(created), 2) # 1 FeatureFlag, 1 Experiment
diff --git a/posthog/models/file_system/test/test_file_system_mixin.py b/posthog/models/file_system/test/test_file_system_mixin.py
index 9f697423a514..d1faeb4915ce 100644
--- a/posthog/models/file_system/test/test_file_system_mixin.py
+++ b/posthog/models/file_system/test/test_file_system_mixin.py
@@ -4,7 +4,7 @@ from posthog.models import FileSystem, Organization, Team, User
from posthog.models.file_system.file_system_view_log import FileSystemViewLog
from products.dashboards.backend.models.dashboard import Dashboard
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.testing import create_experiment, update_experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag
from products.notebooks.backend.models import Notebook
from products.product_analytics.backend.facade.models import Insight
@@ -85,16 +85,17 @@ class TestFileSystemSyncMixin(TestCase):
(If your model doesn't have a 'deleted' field, this just ensures it's created.)
"""
ff = FeatureFlag.objects.create(team=self.team, key="Beta Feature", created_by=self.user)
- exp = Experiment.objects.create(team=self.team, name="Exp #1", created_by=self.user, feature_flag=ff)
- fs_entry = FileSystem.objects.filter(team=self.team, type="experiment", ref=str(exp.id)).first()
+ experiment_id = create_experiment(
+ team_id=self.team.id, name="Exp #1", created_by_id=self.user.id, feature_flag_id=ff.id
+ )
+ fs_entry = FileSystem.objects.filter(team=self.team, type="experiment", ref=str(experiment_id)).first()
assert fs_entry is not None
self.assertEqual(fs_entry.path, "Unfiled/Experiments/Exp #1")
self.assertEqual(fs_entry.shortcut, False)
# If we manually add a field `deleted=True` (if it existed),
# the DSL says ignore. We'll simulate that:
- exp.name = "Exp #1 Updated"
- exp.save()
+ update_experiment(team_id=self.team.id, experiment_id=experiment_id, name="Exp #1 Updated")
# Should remain in the FileSystem
fs_entry.refresh_from_db()
diff --git a/posthog/session_recordings/test/test_session_recording_playlist.py b/posthog/session_recordings/test/test_session_recording_playlist.py
index d3f48fe5c6aa..888804012d0d 100644
--- a/posthog/session_recordings/test/test_session_recording_playlist.py
+++ b/posthog/session_recordings/test/test_session_recording_playlist.py
@@ -49,7 +49,7 @@ from posthog.settings import (
)
from products.access_control.backend.models.access_control import AccessControl
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.facade.testing import create_experiment
from products.feature_flags.backend.models.feature_flag import FeatureFlag
TEST_BUCKET = "test_storage_bucket-ee.TestSessionRecordingPlaylist"
@@ -425,7 +425,7 @@ class TestSessionRecordingPlaylist(APIBaseTest, QueryMatchingTest):
assert response.status_code == status.HTTP_404_NOT_FOUND
assert SessionRecordingPlaylistViewed.objects.count() == 0
- def _create_denied_experiment_and_viewer(self) -> tuple[Experiment, User]:
+ def _create_denied_experiment_and_viewer(self) -> tuple[int, User]:
self.organization.available_product_features = [
{"key": AvailableFeature.ACCESS_CONTROL, "name": AvailableFeature.ACCESS_CONTROL}
]
@@ -433,22 +433,20 @@ class TestSessionRecordingPlaylist(APIBaseTest, QueryMatchingTest):
flag = FeatureFlag.objects.create(
team=self.team, key="playlist-exposure-flag", created_by=self.user, filters={}
)
- experiment = Experiment.objects.create(
- team=self.team,
+ experiment_id = create_experiment(
+ team_id=self.team.id,
name="playlist exposure experiment",
- feature_flag=flag,
- created_by=self.user,
- exposure_criteria={},
- metrics=[],
+ feature_flag_id=flag.id,
+ created_by_id=self.user.id,
)
AccessControl.objects.create(
- team=self.team, resource="experiment", resource_id=str(experiment.pk), access_level="none"
+ team=self.team, resource="experiment", resource_id=str(experiment_id), access_level="none"
)
- return experiment, self._create_user("[email protected]")
+ return experiment_id, self._create_user("[email protected]")
def test_rejects_saving_filters_that_reference_an_experiment_the_saver_cannot_view(self) -> None:
- experiment, denied_user = self._create_denied_experiment_and_viewer()
- exposure_filters = {"date_from": "-30d", "experiment_exposure": {"experiment_id": experiment.id}}
+ experiment_id, denied_user = self._create_denied_experiment_and_viewer()
+ exposure_filters = {"date_from": "-30d", "experiment_exposure": {"experiment_id": experiment_id}}
self.client.force_login(denied_user)
plain_playlist = self._create_playlist({"type": "filters", "filters": {"date_from": "-30d"}})
@@ -469,13 +467,13 @@ class TestSessionRecordingPlaylist(APIBaseTest, QueryMatchingTest):
def test_saves_filters_that_reference_an_experiment_the_saver_can_view(self) -> None:
# The experiment's creator keeps viewer access despite the team-wide "none", so the
# save-time check must let their save through.
- experiment, _ = self._create_denied_experiment_and_viewer()
+ experiment_id, _ = self._create_denied_experiment_and_viewer()
self._create_playlist(
{
"name": "exposed sessions",
"type": "filters",
- "filters": {"date_from": "-30d", "experiment_exposure": {"experiment_id": experiment.id}},
+ "filters": {"date_from": "-30d", "experiment_exposure": {"experiment_id": experiment_id}},
}
)