:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(replay): guard Intl.Segmenter in emoji comment check (#122408)
posthog[bot]f2dfea4fd7ae
diff --git a/frontend/src/scenes/session-recordings/utils.test.ts b/frontend/src/scenes/session-recordings/utils.test.tsindex d7669656b275..678ab0f80e02 100644--- a/frontend/src/scenes/session-recordings/utils.test.ts+++ b/frontend/src/scenes/session-recordings/utils.test.ts@@ -23,6 +23,26 @@ describe('session recording utils', () => {})})+ it('checks emoji without Intl.Segmenter', async () => {+ const intl = Intl as { Segmenter?: typeof Intl.Segmenter }+ const segmenter = intl.Segmenter+ try {+ delete intl.Segmenter+ jest.resetModules()+ const { isSingleEmoji: withoutSegmenter } = await import('scenes/session-recordings/utils')++ for (const emoji of [...defaultQuickEmojis, '👍🏽', '👨👩👧👦', '🇬🇧']) {+ expect(withoutSegmenter(emoji)).toBe(true)+ expect(withoutSegmenter(`${emoji}${emoji}`)).toBe(false)+ }+ expect(withoutSegmenter('a')).toBe(false)+ expect(withoutSegmenter('👍a')).toBe(false)+ } finally {+ intl.Segmenter = segmenter+ jest.resetModules()+ }+ })+describe('filtersFromUniversalFilterGroups', () => {it.each([[diff --git a/frontend/src/scenes/session-recordings/utils.ts b/frontend/src/scenes/session-recordings/utils.tsindex 57218254e23b..016f71dc885a 100644--- a/frontend/src/scenes/session-recordings/utils.ts+++ b/frontend/src/scenes/session-recordings/utils.ts@@ -90,8 +90,25 @@ export const getMaskingConfigFromLevel = (level: SessionRecordingMaskingLevel):return { maskTextSelector: undefined, maskAllInputs: true, blockSelector: undefined }}+let segmenter: Intl.Segmenter | null | undefined++/** Older browsers (e.g. Firefox before 125) have no `Intl.Segmenter`, so build it on first use and only if it exists. */+function graphemeSegmenter(): Intl.Segmenter | null {+ if (segmenter === undefined) {+ segmenter = typeof Intl.Segmenter === 'function' ? new Intl.Segmenter('und', { granularity: 'grapheme' }) : null+ }+ return segmenter+}+export function isSingleEmoji(s: string): boolean {- const graphemes = Array.from(new Intl.Segmenter('und', { granularity: 'grapheme' }).segment(s))+ const segments = graphemeSegmenter()+ if (!segments) {+ // Without a segmenter, a single emoji is a string that one emoji sequence matches in full.+ const matches = s.match(emojiRegex())+ return matches?.length === 1 && matches[0] === s+ }++ const graphemes = Array.from(segments.segment(s))if (graphemes.length !== 1) {return false}