Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(slack_app): remind people once when their slack onboarding stalls (#129897)

Vojta Bartošf5deb67745e3
diff --git a/products/slack_app/backend/logic/onboarding/card.py b/products/slack_app/backend/logic/onboarding/card.py
index 3c8210746205..030fbc6f3fa7 100644
--- a/products/slack_app/backend/logic/onboarding/card.py
+++ b/products/slack_app/backend/logic/onboarding/card.py
@@ -26,6 +26,7 @@ from products.slack_app.backend.temporal.types import (
SETUP_STARTED_EVENT = "slack app onboarding started"
STEP_SHOWN_EVENT = "slack app onboarding step shown"
SETUP_COMPLETED_EVENT = "slack app onboarding completed"
+REMINDED_EVENT = "slack app onboarding reminded"
StepStatus = Literal["done", "already_set", "not_needed", "skipped", "pending"]
@@ -261,6 +262,28 @@ def _forget_deleted_message(
request_onboarding(integration, slack_user_id, may_start=False)
+def remind_onboarding(integration: WorkspaceIntegration, slack_user_id: str) -> None:
+ """Posts at most one reminder per person, as a reply that mentions them, so Slack notifies them."""
+ slack_workspace_id = integration.integration_id
+ state = resolve_onboarding(slack_workspace_id, slack_user_id)
+ if state is None or state.completed or state.reminded_at or state.channel is None or state.root_ts is None:
+ return
+ ctx = OnboardingContext(integration=integration, slack_user_id=slack_user_id)
+ checked = _check_planned(ctx, state.planned, state.step_ts, state.skipped)
+ current = _current(checked)
+ if current is None or not current.shown:
+ return
+ text = (
+ f"<@{slack_user_id}> Your PostHog setup is waiting at step {current.number} of {len(checked)}, "
+ f"{current.step.title}. Pick it up above when you have a minute, or skip the steps you don't need."
+ )
+ SlackIntegration(integration).client.chat_postMessage(
+ channel=state.channel, thread_ts=state.root_ts, text=text, blocks=[section_block(text)]
+ )
+ update_onboarding(slack_workspace_id, slack_user_id, reminded=True)
+ capture_slack_event(integration, REMINDED_EVENT, slack_user_id=slack_user_id, step=current.step.key)
+
+
def edit_onboarding_message(
integration: WorkspaceIntegration, slack_user_id: str, message: SlackAppOnboardingMessage
) -> None:
diff --git a/products/slack_app/backend/services/slack_settings.py b/products/slack_app/backend/services/slack_settings.py
index 3b10adece227..fb79257bf671 100644
--- a/products/slack_app/backend/services/slack_settings.py
+++ b/products/slack_app/backend/services/slack_settings.py
@@ -211,6 +211,7 @@ class OnboardingState:
skipped: tuple[str, ...]
started_at: str | None
completed_at: str | None
+ reminded_at: str | None
completed_reason: OnboardingCompletedReason | None
@property
@@ -237,6 +238,7 @@ def parse_onboarding(stored: object) -> OnboardingState | None:
skipped=_keys(stored.get("skipped")),
started_at=stored.get("started_at") or None,
completed_at=stored.get("completed_at") or None,
+ reminded_at=stored.get("reminded_at") or None,
completed_reason=reason if reason in ("finished", "nothing_to_set_up") else None,
)
@@ -269,6 +271,7 @@ def update_onboarding(
skip_step: str | None = None,
forget_step: str | None = None,
reset_thread: bool = False,
+ reminded: bool = False,
completed_reason: OnboardingCompletedReason | None = None,
) -> None:
"""``root`` is (channel, ts) and ``step_ts`` is (step key, ts). The row lock stops a skip click and a
@@ -302,6 +305,8 @@ def update_onboarding(
# Skips stay, so a new thread does not ask again for what the person turned down.
for field in ("channel", "root_ts", "root_status", "planned", "step_ts", "summarized"):
card.pop(field, None)
+ if reminded:
+ card.setdefault("reminded_at", now)
if completed_reason is not None:
card["completed_at"], card["completed_reason"] = now, completed_reason
row.onboarding = card
diff --git a/products/slack_app/backend/temporal/__init__.py b/products/slack_app/backend/temporal/__init__.py
index bcdb08f52f84..682b5b43665d 100644
--- a/products/slack_app/backend/temporal/__init__.py
+++ b/products/slack_app/backend/temporal/__init__.py
@@ -39,6 +39,7 @@ from products.slack_app.backend.temporal.activities import (
posthog_code_thread_has_task_activity,
prepare_slack_unfurl_charts_activity,
process_slack_app_fork_thread_activity,
+ remind_slack_app_onboarding_activity,
request_untagged_followup_confirmation_activity,
request_untagged_question_confirmation_activity,
resolve_posthog_code_slack_command_user_activity,
@@ -92,6 +93,7 @@ SLACK_APP_ACTIVITIES = [
edit_slack_app_onboarding_message_activity,
plan_slack_app_onboarding_activity,
post_slack_app_onboarding_message_activity,
+ remind_slack_app_onboarding_activity,
run_posthog_slack_inbox_onboarding_activity,
prepare_slack_unfurl_charts_activity,
post_slack_unfurl_charts_activity,
@@ -148,6 +150,7 @@ __all__ = [
"edit_slack_app_onboarding_message_activity",
"plan_slack_app_onboarding_activity",
"post_slack_app_onboarding_message_activity",
+ "remind_slack_app_onboarding_activity",
"run_posthog_slack_inbox_onboarding_activity",
"post_slack_unfurl_charts_activity",
"prepare_slack_unfurl_charts_activity",
diff --git a/products/slack_app/backend/temporal/activities/__init__.py b/products/slack_app/backend/temporal/activities/__init__.py
index 8a3975eca832..05959f20cc55 100644
--- a/products/slack_app/backend/temporal/activities/__init__.py
+++ b/products/slack_app/backend/temporal/activities/__init__.py
@@ -40,6 +40,7 @@ from products.slack_app.backend.temporal.activities.slack_app_onboarding import
edit_slack_app_onboarding_message_activity,
plan_slack_app_onboarding_activity,
post_slack_app_onboarding_message_activity,
+ remind_slack_app_onboarding_activity,
)
from products.slack_app.backend.temporal.activities.task_creation import (
create_posthog_code_task_for_repo_activity,
@@ -99,6 +100,7 @@ __all__ = [
"edit_slack_app_onboarding_message_activity",
"plan_slack_app_onboarding_activity",
"post_slack_app_onboarding_message_activity",
+ "remind_slack_app_onboarding_activity",
"run_posthog_slack_inbox_onboarding_activity",
"post_slack_unfurl_charts_activity",
"prepare_slack_unfurl_charts_activity",
diff --git a/products/slack_app/backend/temporal/activities/slack_app_onboarding.py b/products/slack_app/backend/temporal/activities/slack_app_onboarding.py
index 28fb71beb2a1..32ea1dda2333 100644
--- a/products/slack_app/backend/temporal/activities/slack_app_onboarding.py
+++ b/products/slack_app/backend/temporal/activities/slack_app_onboarding.py
@@ -44,6 +44,15 @@ def post_slack_app_onboarding_message_activity(inputs: SlackAppOnboardingMessage
post_onboarding_message(integration, inputs.setup.slack_user_id, inputs.message)
+def remind_slack_app_onboarding_activity(inputs: SlackAppOnboardingInputs) -> None:
+ from products.slack_app.backend.logic.onboarding.card import remind_onboarding
+
+ integration = _integration(inputs)
+ if integration is not None:
+ remind_onboarding(integration, inputs.slack_user_id)
+
+
@activity.defn
def edit_slack_app_onboarding_message_activity(inputs: SlackAppOnboardingMessageInputs) -> None:
from products.slack_app.backend.logic.onboarding.card import edit_onboarding_message
diff --git a/products/slack_app/backend/temporal/slack_app_onboarding.py b/products/slack_app/backend/temporal/slack_app_onboarding.py
index 2991356317c3..976b44e784c8 100644
--- a/products/slack_app/backend/temporal/slack_app_onboarding.py
+++ b/products/slack_app/backend/temporal/slack_app_onboarding.py
@@ -12,10 +12,13 @@ from products.slack_app.backend.temporal.activities.slack_app_onboarding import
edit_slack_app_onboarding_message_activity,
plan_slack_app_onboarding_activity,
post_slack_app_onboarding_message_activity,
+ remind_slack_app_onboarding_activity,
)
from products.slack_app.backend.temporal.types import SlackAppOnboardingInputs, SlackAppOnboardingMessageInputs
SLACK_APP_ONBOARDING_IDLE_TIMEOUT = timedelta(days=7)
+# One nudge after a quiet day. The run then waits the full idle timeout again before it ends.
+SLACK_APP_ONBOARDING_REMINDER_DELAY = timedelta(days=1)
SLACK_APP_ONBOARDING_ACTIVITY_TIMEOUT = timedelta(seconds=60)
# Two plans cover a refresh (the top message, then the first step under it); the third is headroom.
SLACK_APP_ONBOARDING_MAX_PLANS_PER_REFRESH = 3
@@ -41,6 +44,7 @@ class SlackAppOnboardingWorkflow(PostHogWorkflow):
def __init__(self, inputs: SlackAppOnboardingInputs) -> None:
# The first render needs no signal. Set here and not in run(), because buffered signals run first.
self._render_requested = True
+ self._may_remind = True
@workflow.signal
async def refresh(self) -> None:
@@ -78,18 +82,39 @@ class SlackAppOnboardingWorkflow(PostHogWorkflow):
return plan.finished
return False
+ async def _remind(self, inputs: SlackAppOnboardingInputs) -> None:
+ try:
+ await workflow.execute_activity(
+ remind_slack_app_onboarding_activity,
+ inputs,
+ start_to_close_timeout=SLACK_APP_ONBOARDING_ACTIVITY_TIMEOUT,
+ retry_policy=_ONE_ATTEMPT,
+ summary="remind",
+ )
+ except ActivityError:
+ workflow.logger.warning("slack_app_onboarding_remind_failed", extra={"slack_user_id": inputs.slack_user_id})
+
@workflow.run
async def run(self, inputs: SlackAppOnboardingInputs) -> None:
if inputs.start_delay_seconds > 0:
await workflow.sleep(timedelta(seconds=inputs.start_delay_seconds))
while True:
try:
- await workflow.wait_condition(lambda: self._render_requested, timeout=SLACK_APP_ONBOARDING_IDLE_TIMEOUT)
+ await workflow.wait_condition(
+ lambda: self._render_requested,
+ timeout=SLACK_APP_ONBOARDING_REMINDER_DELAY
+ if self._may_remind
+ else SLACK_APP_ONBOARDING_IDLE_TIMEOUT,
+ )
except TimeoutError:
# A refresh that lands between the timeout and the return must not be dropped.
await workflow.wait_condition(workflow.all_handlers_finished)
if self._render_requested:
continue
+ if self._may_remind:
+ self._may_remind = False
+ await self._remind(inputs)
+ continue
return
self._render_requested = False
diff --git a/products/slack_app/backend/temporal/tests/test_slack_app_onboarding_workflow.py b/products/slack_app/backend/temporal/tests/test_slack_app_onboarding_workflow.py
index 516f114d4ee6..95c6bdb51a23 100644
--- a/products/slack_app/backend/temporal/tests/test_slack_app_onboarding_workflow.py
+++ b/products/slack_app/backend/temporal/tests/test_slack_app_onboarding_workflow.py
@@ -71,7 +71,11 @@ class _Slack:
self.failing_posts -= 1
raise ApplicationError("slack down")
- return [plan, edit, post]
+ @activity.defn(name="remind_slack_app_onboarding_activity")
+ async def remind(_: SlackAppOnboardingInputs) -> None:
+ self.calls.append("remind")
+
+ return [plan, edit, post, remind]
@pytest.fixture
@@ -142,8 +146,8 @@ async def _run(
[FIRST_STEP_PLAN],
0,
0,
- ["plan", "post:step"],
- id="without a refresh for a week the run ends",
+ ["plan", "post:step", "remind"],
+ id="without a refresh it reminds once after a day, then ends",
),
],
)
@@ -183,6 +187,6 @@ async def test_a_delayed_start_waits_before_its_first_plan(env: WorkflowEnvironm
started_at = await env.get_current_time()
summaries = await _run(env, slack, refreshes=0, inputs=delayed)
- assert slack.calls == ["plan", "post:step"]
- assert summaries == ["plan", "post model: show step"]
+ assert slack.calls == ["plan", "post:step", "remind"]
+ assert summaries == ["plan", "post model: show step", "remind"]
assert await env.get_current_time() - started_at >= timedelta(seconds=300)
diff --git a/products/slack_app/backend/tests/logic/onboarding/test_thread.py b/products/slack_app/backend/tests/logic/onboarding/test_thread.py
index 2ad1310d4093..158151f7ba1f 100644
--- a/products/slack_app/backend/tests/logic/onboarding/test_thread.py
+++ b/products/slack_app/backend/tests/logic/onboarding/test_thread.py
@@ -17,6 +17,7 @@ from products.slack_app.backend.logic.onboarding.card import (
edit_onboarding_message,
plan_onboarding,
post_onboarding_message,
+ remind_onboarding,
)
from products.slack_app.backend.logic.onboarding.interactivity import (
handle_onboarding_action,
@@ -400,6 +401,26 @@ def test_a_step_set_elsewhere_keeps_its_number_and_shows_as_checked_in_the_threa
assert "▰▰▱ 2/3 done" in edits["100.1"]
+def test_a_stalled_thread_gets_one_reminder_that_names_the_waiting_step(
+ org_team_user, link_user, slack_client: MagicMock, capture: MagicMock
+) -> None:
+ _, team, user = org_team_user
+ integration = _install(team)
+ _refresh(integration)
+ link_user(user)
+ _refresh(integration)
+ posts_before = slack_client.chat_postMessage.call_count
+
+ remind_onboarding(integration, SLACK_USER_ID)
+ remind_onboarding(integration, SLACK_USER_ID)
+
+ assert slack_client.chat_postMessage.call_count == posts_before + 1
+ reminder = _posts(slack_client)[-1]
+ assert reminder["thread_ts"] == "100.1"
+ assert reminder["text"].startswith(f"<@{SLACK_USER_ID}> Your PostHog setup is waiting at step 2 of 3, Your model.")
+
+
@pytest.mark.django_db
def test_a_deleted_top_message_starts_a_new_thread(
org_team_user, link_user, slack_client: MagicMock, capture: MagicMock