:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(mcp): omit default reviewer outcome from edit requests (#122121)
posthog[bot]fd1fb8c995a8
diff --git a/docs/internal/signals-pr-lifecycle.md b/docs/internal/signals-pr-lifecycle.mdindex 333272b68789..5e40ea45bc1a 100644--- a/docs/internal/signals-pr-lifecycle.md+++ b/docs/internal/signals-pr-lifecycle.md@@ -294,6 +294,8 @@ Clients can send explicit `targets` with an add/remove action while retaining aProtected reports reject full replacements without state; older Desktop/mobile clients must update before rollout.Automatic results distinguish `selected`, `no_suitable_owner`, and `lookup_failed`.+Generated clients omit `reviewer_outcome` unless the caller supplies it; the backend treats an omitted outcome as `selected` only while processing reviewer state.+This keeps unrelated report edits compatible while the MCP server and API deploy separately.A deliberate empty result clears automatic recipients but retains pins and confirmed lists.Failed lookup or wholly invalid selection retains valid current recipients.Accepted recipients must be active members with project access.diff --git a/products/signals/backend/scout_harness/views.py b/products/signals/backend/scout_harness/views.pyindex 3c1c029af401..9f711cf09ee8 100644--- a/products/signals/backend/scout_harness/views.py+++ b/products/signals/backend/scout_harness/views.py@@ -1426,7 +1426,7 @@ class SignalScoutRunViewSet(TeamAndOrgViewSetMixin, viewsets.GenericViewSet):proposal = ReviewerProposal(expected_state=ReviewerState.model_validate(data["expected_reviewers"]),source="scout_edit",- outcome=data["reviewer_outcome"],+ outcome=data.get("reviewer_outcome", "selected"),retry_reason=data.get("reviewer_retry_reason"),)result = edit_report_sync(diff --git a/products/signals/backend/serializers.py b/products/signals/backend/serializers.pyindex 79769891ae46..f72c10ed9d89 100644--- a/products/signals/backend/serializers.py+++ b/products/signals/backend/serializers.py@@ -1277,8 +1277,11 @@ class ReviewerProposalSerializer(serializers.Serializer):)reviewer_outcome = serializers.ChoiceField(choices=ReviewerSelectionOutcome.choices,- default="selected",- help_text="A successful selection, a deliberate empty result, or an unavailable lookup.",+ required=False,+ help_text=(+ "A successful selection, a deliberate empty result, or an unavailable lookup. "+ "Defaults to selected when omitted."+ ),)reviewer_retry_reason = serializers.CharField(required=False, max_length=500, help_text="Reason the reviewer lookup failed."diff --git a/products/signals/backend/test/test_scout_report_api.py b/products/signals/backend/test/test_scout_report_api.pyindex 8fbb5bc76b14..e307eb0871f6 100644--- a/products/signals/backend/test/test_scout_report_api.py+++ b/products/signals/backend/test/test_scout_report_api.py@@ -665,11 +665,11 @@ class TestScoutReportAPI(APIBaseTest):judge_mock.assert_not_awaited()embed_mock.assert_not_called()- @parameterized.expand([("corroboration_only",), ("supersedes_implementation",)])- def test_an_omitted_edit_flag_stays_out_of_the_request_body(self, field: str) -> None:- # A DRF default renders as a default on the generated client, which sends an explicit `false`- # for a flag the caller omitted. The validator below rejects a field it does not declare, so a- # client deployed ahead of this endpoint would fail every edit, not only a supersede request.+ @parameterized.expand([("corroboration_only",), ("supersedes_implementation",), ("reviewer_outcome",)])+ def test_an_omitted_edit_field_stays_out_of_the_request_body(self, field: str) -> None:+ # A DRF default becomes a generated-client default, which sends a value the caller omitted.+ # An older endpoint rejects fields it does not declare, so a client deployed ahead of the API+ # would fail every edit instead of only requests that use the new field.serializer = EditReportRequestSerializer(data={"report_id": str(uuid4())})assert serializer.is_valid(), serializer.errorsassert field not in serializer.validated_datadiff --git a/products/signals/backend/views.py b/products/signals/backend/views.pyindex 9affd0737fed..f4dfccf08471 100644--- a/products/signals/backend/views.py+++ b/products/signals/backend/views.py@@ -5943,6 +5943,7 @@ class SignalReportArtefactViewSet(if isinstance(parsed_content, SuggestedReviewers):try:expected = request.validated_data.get("expected_reviewers")+ reviewer_outcome = request.validated_data.get("reviewer_outcome", "selected")with transaction.atomic():SignalReport.objects.select_for_update().get(team_id=self.team.id, id=report_id)previous = ReviewerRules.read_for_report(@@ -5955,13 +5956,13 @@ class SignalReportArtefactViewSet(attribution=attribution,reviewer_proposal=ReviewerProposal(expected_state=ReviewerState.model_validate(expected),- outcome=request.validated_data["reviewer_outcome"],+ outcome=reviewer_outcome,retry_reason=request.validated_data.get("reviewer_retry_reason"),)if expected is not Noneelse None,reviewer_edit=ReviewerEdit(action="replace", expected_state=expected)- if attribution.kind == "user" and request.validated_data["reviewer_outcome"] == "selected"+ if attribution.kind == "user" and reviewer_outcome == "selected"else None,claim_id=str(claim_id) if claim_id else None,)diff --git a/products/signals/frontend/generated/api.schemas.ts b/products/signals/frontend/generated/api.schemas.tsindex 9653ea7a254b..15dd3ffb8ee0 100644--- a/products/signals/frontend/generated/api.schemas.ts+++ b/products/signals/frontend/generated/api.schemas.ts@@ -4517,7 +4517,7 @@ export const ReviewerSelectionOutcomeEnumApi = {export interface SignalReportArtefactLogCreateApi {/** Report reviewer_assignment.state read before selection began. Required when reviewer corrections are enabled. */expected_reviewers?: ReviewerStateApi- /** A successful selection, a deliberate empty result, or an unavailable lookup.+ /** A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.** * `selected` - Selected* * `no_suitable_owner` - No suitable owner@@ -8387,7 +8387,7 @@ export const ActionabilityEnumApi = {export interface EditReportRequestApi {/** Report reviewer_assignment.state read before selection began. Required when reviewer corrections are enabled. */expected_reviewers?: ReviewerStateApi- /** A successful selection, a deliberate empty result, or an unavailable lookup.+ /** A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.** * `selected` - Selected* * `no_suitable_owner` - No suitable ownerdiff --git a/products/signals/frontend/generated/api.zod.ts b/products/signals/frontend/generated/api.zod.tsindex 6db3eb8d9340..3d58e1b182fe 100644--- a/products/signals/frontend/generated/api.zod.ts+++ b/products/signals/frontend/generated/api.zod.ts@@ -1066,7 +1066,6 @@ export const SignalsReportsStateCreateBody = /* @__PURE__ */ zod.object({* Append an artefact to a report (see artefact_type for the writable types). Everything is append-only: log entries (code reference, commit, task run, note) accumulate, while status types (safety / actionability / priority judgments, repo selection, suggested reviewers, channel assignments) are latest-wins — appending a new version supersedes the previous one as the report's canonical status. Content is validated against the type's schema.* @summary Append an artefact to a report*/-export const signalsReportArtefactsCreateBodyReviewerOutcomeDefault = `selected`export const signalsReportArtefactsCreateBodyReviewerRetryReasonMax = 500export const SignalsReportArtefactsCreateBody = /* @__PURE__ */ zod@@ -1091,9 +1090,9 @@ export const SignalsReportArtefactsCreateBody = /* @__PURE__ */ zod.describe('\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed')- .default(signalsReportArtefactsCreateBodyReviewerOutcomeDefault)+ .optional().describe(- 'A successful selection, a deliberate empty result, or an unavailable lookup.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'+ 'A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'),reviewer_retry_reason: zod.string()@@ -2507,7 +2506,6 @@ export const SignalsScoutRecordCheckResultBody = /* @__PURE__ */ zod* Rewrite a report's title/summary, append a note or fresh evidence, set its suggested reviewers, and/or point it at another repository. Can target ANY of the project's inbox reports, not just scout-authored ones — so the edit is attributed to this scout. Reviewers and repository are how you rescue a report that surfaced routed to no one or against the wrong codebase: each replaces what the report holds and re-runs autostart, so a report that was missing a qualifying reviewer or a repository can open a draft PR. The response carries the repository the report holds after the edit, and the call fails when a repository it named did not land. Set `actionability` and/or `priority` (each with its explanation) when new evidence changed your judgment: each replaces the report's decision and re-runs autostart, without changing the report's inbox status. `tags` replaces the report's slug tags, and an omitted `tags` keeps them. Title/summary edits are best-effort: the pipeline may later re-research them. Set `supersedes_implementation` alongside a rewrite when the fix changed. Verified automated predecessor PRs close only after the replacement completes with verified open PRs.* @summary Edit an existing report for a run*/-export const signalsScoutEditReportBodyReviewerOutcomeDefault = `selected`export const signalsScoutEditReportBodyReviewerRetryReasonMax = 500export const signalsScoutEditReportBodyTitleMax = 300@@ -2582,9 +2580,9 @@ export const SignalsScoutEditReportBody = /* @__PURE__ */ zod.describe('\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed')- .default(signalsScoutEditReportBodyReviewerOutcomeDefault)+ .optional().describe(- 'A successful selection, a deliberate empty result, or an unavailable lookup.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'+ 'A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'),reviewer_retry_reason: zod.string()diff --git a/services/mcp/src/api/generated.ts b/services/mcp/src/api/generated.tsindex fea4fc0b0df7..d1213a08b97d 100644--- a/services/mcp/src/api/generated.ts+++ b/services/mcp/src/api/generated.ts@@ -39988,7 +39988,7 @@ export namespace Schemas {export interface EditReportRequest {/** Report reviewer_assignment.state read before selection began. Required when reviewer corrections are enabled. */expected_reviewers?: ReviewerState;- /** A successful selection, a deliberate empty result, or an unavailable lookup.+ /** A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.** * `selected` - Selected* * `no_suitable_owner` - No suitable owner@@ -106851,7 +106851,7 @@ export namespace Schemas {export interface SignalReportArtefactLogCreate {/** Report reviewer_assignment.state read before selection began. Required when reviewer corrections are enabled. */expected_reviewers?: ReviewerState;- /** A successful selection, a deliberate empty result, or an unavailable lookup.+ /** A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.** * `selected` - Selected* * `no_suitable_owner` - No suitable ownerdiff --git a/services/mcp/src/generated/signals/api.ts b/services/mcp/src/generated/signals/api.tsindex ce187adbec12..3ac31568d6d6 100644--- a/services/mcp/src/generated/signals/api.ts+++ b/services/mcp/src/generated/signals/api.ts@@ -832,7 +832,6 @@ export const SignalsReportArtefactsCreateHeader = () => zod.object({),})-export const signalsReportArtefactsCreateBodyReviewerOutcomeDefault = `selected`export const signalsReportArtefactsCreateBodyReviewerRetryReasonMax = 500export const SignalsReportArtefactsCreateBody = () => zod@@ -857,9 +856,9 @@ export const SignalsReportArtefactsCreateBody = () => zod.describe('\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed')- .default(signalsReportArtefactsCreateBodyReviewerOutcomeDefault)+ .optional().describe(- 'A successful selection, a deliberate empty result, or an unavailable lookup.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'+ 'A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'),reviewer_retry_reason: zod.string()@@ -2787,7 +2786,6 @@ export const SignalsScoutEditReportParams = () => zod.object({run_id: zod.string().describe('UUID of the `SignalScoutRun` bridge row.'),})-export const signalsScoutEditReportBodyReviewerOutcomeDefault = `selected`export const signalsScoutEditReportBodyReviewerRetryReasonMax = 500export const signalsScoutEditReportBodyTitleMax = 300@@ -2862,9 +2860,9 @@ export const SignalsScoutEditReportBody = () => zod.describe('\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed')- .default(signalsScoutEditReportBodyReviewerOutcomeDefault)+ .optional().describe(- 'A successful selection, a deliberate empty result, or an unavailable lookup.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'+ 'A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.\n\n\* `selected` - Selected\n\* `no_suitable_owner` - No suitable owner\n\* `lookup_failed` - Lookup failed'),reviewer_retry_reason: zod.string()diff --git a/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-report-artefacts-create.json b/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-report-artefacts-create.jsonindex 6657d427bb80..ce22c8c497a0 100644--- a/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-report-artefacts-create.json+++ b/services/mcp/tests/unit/__snapshots__/tool-schemas/inbox-report-artefacts-create.json@@ -46,8 +46,7 @@"type": "string"},"reviewer_outcome": {- "default": "selected",- "description": "A successful selection, a deliberate empty result, or an unavailable lookup.\n\n* `selected` - Selected\n* `no_suitable_owner` - No suitable owner\n* `lookup_failed` - Lookup failed",+ "description": "A successful selection, a deliberate empty result, or an unavailable lookup. Defaults to selected when omitted.\n\n* `selected` - Selected\n* `no_suitable_owner` - No suitable owner\n* `lookup_failed` - Lookup failed","enum": ["selected", "no_suitable_owner", "lookup_failed"],"type": "string"},diff --git a/services/mcp/tests/unit/signals-edit-handler.test.ts b/services/mcp/tests/unit/signals-edit-handler.test.tsindex 6c6448f6f601..df28cd3a4a9b 100644--- a/services/mcp/tests/unit/signals-edit-handler.test.ts+++ b/services/mcp/tests/unit/signals-edit-handler.test.ts@@ -4,6 +4,31 @@ import { GENERATED_TOOLS } from '@/tools/generated/signals'import type { Context } from '@/tools/types'describe('signals-scout-edit-report handler', () => {+ const toolNames = ['scout-edit-report', 'signals-scout-edit-report'] as const+ const ordinaryEdits = [+ { append_note: 'Checked again' },+ { append_evidence: [{ description: 'A second signal supports this finding.', source_id: 'observation-2' }] },+ {+ actionability: 'requires_human_input' as const,+ actionability_explanation: 'A project member must confirm the desired behavior.',+ },+ ]++ it.each(toolNames.flatMap((toolName) => ordinaryEdits.map((edit) => ({ toolName, edit }))))(+ '$toolName forwards an ordinary edit without reviewer fields: $edit',+ async ({ toolName, edit }) => {+ const request = vi.fn().mockResolvedValue({ report_id: 'report-1' })+ const context = {+ api: { request, getProjectBaseUrl: vi.fn().mockReturnValue('https://us.posthog.com/project/42') },+ stateManager: { getProjectId: vi.fn().mockResolvedValue('42') },+ } as unknown as Context+ const tool = GENERATED_TOOLS[toolName]!()+ const input = { run_id: 'run-1', report_id: 'report-1', ...edit }+ await tool.handler(context, tool.schema.parse(input))+ expect(request.mock.calls[0]![0].body).toEqual({ report_id: 'report-1', ...edit })+ }+ )+it.each([{},{ corroboration_only: false, supersedes_implementation: false },@@ -18,10 +43,32 @@ describe('signals-scout-edit-report handler', () => {const input = { run_id: 'run-1', report_id: 'report-1', append_note: 'Checked again', ...flags }await tool.handler(context, tool.schema.parse(input))expect(request.mock.calls[0]![0].body).toEqual({- reviewer_outcome: 'selected',report_id: 'report-1',append_note: 'Checked again',...flags,})})++ it.each(toolNames)('%s preserves an explicit reviewer proposal', async (toolName) => {+ const request = vi.fn().mockResolvedValue({ report_id: 'report-1' })+ const context = {+ api: { request, getProjectBaseUrl: vi.fn().mockReturnValue('https://us.posthog.com/project/42') },+ stateManager: { getProjectId: vi.fn().mockResolvedValue('42') },+ } as unknown as Context+ const tool = GENERATED_TOOLS[toolName]!()+ const input = {+ run_id: 'run-1',+ report_id: 'report-1',+ suggested_reviewers: [{ github_login: 'reviewer', reason: 'Owns the affected surface.' }],+ expected_reviewers: { reviewers_id: null, corrections_id: null },+ reviewer_outcome: 'selected' as const,+ }+ await tool.handler(context, tool.schema.parse(input))+ expect(request.mock.calls[0]![0].body).toEqual({+ report_id: 'report-1',+ suggested_reviewers: input.suggested_reviewers,+ expected_reviewers: input.expected_reviewers,+ reviewer_outcome: 'selected',+ })+ })})