Skip to content

πŸ“¨ The ultimate agentic social media scheduling tool πŸ€–

fix(tags): always restore dropdown closability after edit/delete modals

Gilad Resisi1f7e1b6b40eb
diff --git a/apps/frontend/src/components/launches/tags.component.tsx b/apps/frontend/src/components/launches/tags.component.tsx
index 073cbc5bb..c306186b4 100644
--- a/apps/frontend/src/components/launches/tags.component.tsx
+++ b/apps/frontend/src/components/launches/tags.component.tsx
@@ -110,44 +110,48 @@ export const TagsComponentInner: FC<{
async (tag: any, e: React.MouseEvent) => {
setAllowClose(false);
e.stopPropagation();
- const val: string | undefined = await new Promise((resolve) => {
- modals.openModal({
- title: t('edit_tag', 'Edit Tag'),
- onClose: () => resolve(undefined),
- children: (close) => (
- <ShowModal
- tag={tag.name}
- color={tag.color}
- id={tag.id}
- close={close}
- resolve={resolve}
- />
- ),
+ try {
+ const val: string | undefined = await new Promise((resolve) => {
+ modals.openModal({
+ title: t('edit_tag', 'Edit Tag'),
+ onClose: () => resolve(undefined),
+ children: (close) => (
+ <ShowModal
+ tag={tag.name}
+ color={tag.color}
+ id={tag.id}
+ close={close}
+ resolve={resolve}
+ />
+ ),
+ });
});
- });
- const newValues = await mutate();
+ const newValues = await mutate();
- if (val) {
- const updated = newValues.tags.find((p: any) => p.id === tag.id);
- if (updated && tagValue.find((a) => a.id === tag.id)) {
- const modify = tagValue.map((a) => (a.id === tag.id ? updated : a));
- setTagValue(modify);
- onChange({
- target: {
- value: modify.map((p: any) => ({
- label: p.name,
- value: p.name,
- })),
- name,
- },
- });
+ if (val) {
+ const updated = newValues.tags.find((p: any) => p.id === tag.id);
+ if (updated && tagValue.find((a) => a.id === tag.id)) {
+ const modify = tagValue.map((a) =>
+ a.id === tag.id ? updated : a
+ );
+ setTagValue(modify);
+ onChange({
+ target: {
+ value: modify.map((p: any) => ({
+ label: p.name,
+ value: p.name,
+ })),
+ name,
+ },
+ });
+ }
}
+ } finally {
+ setTimeout(() => {
+ setAllowClose(true);
+ }, 500);
}
-
- setTimeout(() => {
- setAllowClose(true);
- }, 500);
},
[tagValue, name, onChange, mutate, modals, t]
);
@@ -156,50 +160,49 @@ export const TagsComponentInner: FC<{
async (tag: any, e: React.MouseEvent) => {
setAllowClose(false);
e.stopPropagation();
- const confirmed: boolean = await new Promise((resolve) => {
- modals.openModal({
- title: t('delete_tag', 'Delete Tag'),
- children: (close) => (
- <ConfirmDeleteModal
- tagName={tag.name}
- close={close}
- resolve={resolve}
- />
- ),
+ try {
+ const confirmed: boolean = await new Promise((resolve) => {
+ modals.openModal({
+ title: t('delete_tag', 'Delete Tag'),
+ children: (close) => (
+ <ConfirmDeleteModal
+ tagName={tag.name}
+ close={close}
+ resolve={resolve}
+ />
+ ),
+ });
});
- });
- if (!confirmed) {
- setTimeout(() => {
- setAllowClose(true);
- }, 500);
- return;
- }
-
- await fetch(`/posts/tags/${tag.id}`, {
- method: 'DELETE',
- });
+ if (!confirmed) {
+ return;
+ }
- // Remove the tag from current selection if it was selected
- const modify = tagValue.filter((a) => a.id !== tag.id);
- if (modify.length !== tagValue.length) {
- setTagValue(modify);
- onChange({
- target: {
- value: modify.map((p: any) => ({
- label: p.name,
- value: p.name,
- })),
- name,
- },
+ await fetch(`/posts/tags/${tag.id}`, {
+ method: 'DELETE',
});
- }
- await mutate();
+ // Remove the tag from current selection if it was selected
+ const modify = tagValue.filter((a) => a.id !== tag.id);
+ if (modify.length !== tagValue.length) {
+ setTagValue(modify);
+ onChange({
+ target: {
+ value: modify.map((p: any) => ({
+ label: p.name,
+ value: p.name,
+ })),
+ name,
+ },
+ });
+ }
- setTimeout(() => {
- setAllowClose(true);
- }, 500);
+ await mutate();
+ } finally {
+ setTimeout(() => {
+ setAllowClose(true);
+ }, 500);
+ }
},
[tagValue, name, onChange, mutate, fetch, modals, t]
);