Skip to content

πŸ“¨ The ultimate agentic social media scheduling tool πŸ€–

fix(auth): only follow a returnUrl on this app after signing in

Nevo David9a88959839f9
diff --git a/apps/frontend/src/app/(app)/auth/return.url.component.tsx b/apps/frontend/src/app/(app)/auth/return.url.component.tsx
index 16ed2ae1b..872e9f522 100644
--- a/apps/frontend/src/app/(app)/auth/return.url.component.tsx
+++ b/apps/frontend/src/app/(app)/auth/return.url.component.tsx
@@ -2,12 +2,31 @@
import { useSearchParams } from 'next/navigation';
import { FC, useCallback, useEffect } from 'react';
+
+// Only an address on this app, so signing in can never send someone to
+// another site or run a javascript: URL
+const sameOriginUrl = (url: string | null) => {
+ if (!url) {
+ return null;
+ }
+ try {
+ const parsed = new URL(url);
+ return parsed.origin === window.location.origin &&
+ parsed.protocol === window.location.protocol
+ ? parsed.toString()
+ : null;
+ } catch {
+ return null;
+ }
+};
+
const ReturnUrlComponent: FC = () => {
const params = useSearchParams();
const url = params.get('returnUrl');
useEffect(() => {
- if (url?.indexOf?.('http')! > -1) {
- localStorage.setItem('returnUrl', url!);
+ const returnUrl = sameOriginUrl(url);
+ if (returnUrl) {
+ localStorage.setItem('returnUrl', returnUrl);
}
}, [url]);
return null;
@@ -17,7 +36,8 @@ export const useReturnUrl = () => {
getAndClear: useCallback(() => {
const data = localStorage.getItem('returnUrl');
localStorage.removeItem('returnUrl');
- return data;
+ // also on read: localStorage can hold a value saved before this check
+ return sameOriginUrl(data);
}, []),
};
};