Skip to content

πŸ“¨ The ultimate agentic social media scheduling tool πŸ€–

fix(clipping): never give a draft claim back, draft one channel at a time

Nevo Davidc7405ff9c8d5
diff --git a/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.repository.ts b/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.repository.ts
index b6df74176..a7e044f91 100644
--- a/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.repository.ts
+++ b/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.repository.ts
@@ -288,7 +288,7 @@ export class ClippingRepository {
mediaId?: string;
path?: string;
thumbnail?: string;
- draftedAt?: Date | null;
+ draftedAt?: Date;
}
) {
return this._clippingClip.model.clippingClip.update({
diff --git a/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.service.ts b/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.service.ts
index eaf44edaf..60c517482 100644
--- a/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.service.ts
+++ b/libraries/nestjs-libraries/src/database/prisma/clipping/clipping.service.ts
@@ -939,54 +939,64 @@ export class ClippingService {
continue;
}
- // claimed before the draft exists: a retry, or an attempt that timed out
- // and is still running, skips the clip instead of drafting it a second time
+ const nextTime = await this._postsService.findFreeDateTime(
+ clipping.organizationId
+ );
+
+ // Claimed before any draft exists and never given back: a retry, or an
+ // attempt that timed out and is still running, skips the clip. Giving the
+ // claim back after a failure would draft again the channels that already
+ // got theirs, and a missing draft costs less than a double one: the clip
+ // is in the media library either way
if (!(await this._clippingRepository.claimClipDraft(clip.id))) {
continue;
}
- try {
- const nextTime = await this._postsService.findFreeDateTime(
- clipping.organizationId
- );
-
- await this._postsService.createPost(
- clipping.organizationId,
- {
- date: nextTime + 'Z',
- order: makeId(10),
- shortLink: false,
- type: 'draft',
- tags: [],
- posts: integrations.map((integration) => ({
- settings: {
- __type: integration!.providerIdentifier as any,
- },
- group: makeId(10),
- integration: { id: integration!.id },
- value: [
+ // one channel at a time, so a channel that fails does not take the rest along
+ for (const integration of integrations) {
+ try {
+ await this._postsService.createPost(
+ clipping.organizationId,
+ {
+ date: nextTime + 'Z',
+ order: makeId(10),
+ shortLink: false,
+ type: 'draft',
+ tags: [],
+ posts: [
{
- id: makeId(10),
- delay: 0,
- content: clip.content,
- image: [
+ settings: {
+ __type: integration!.providerIdentifier as any,
+ },
+ group: makeId(10),
+ integration: { id: integration!.id },
+ value: [
{
- id: clip.mediaId || makeId(10),
- path: clip.path!,
- ...(clip.thumbnail ? { thumbnail: clip.thumbnail } : {}),
+ id: makeId(10),
+ delay: 0,
+ content: clip.content,
+ image: [
+ {
+ id: clip.mediaId || makeId(10),
+ path: clip.path!,
+ ...(clip.thumbnail
+ ? { thumbnail: clip.thumbnail }
+ : {}),
+ },
+ ],
},
],
},
],
- })),
- },
- 'UNKNOWN'
- );
- } catch (err) {
- await this._clippingRepository.updateClip(clip.id, {
- draftedAt: null,
- });
- throw err;
+ },
+ 'UNKNOWN'
+ );
+ } catch (err) {
+ console.error(
+ `Could not draft clip ${clip.id} on channel ${integration!.id}:`,
+ err
+ );
+ }
}
}
}