Skip to content

AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He

fix(quick): read the deck language and theme fonts from the roster's first page

Max Freedom Pollard05ad6264403f
diff --git a/skills/ppt-master/scripts/svg_quality/checker.py b/skills/ppt-master/scripts/svg_quality/checker.py
index 541f7fe0..699faa96 100644
--- a/skills/ppt-master/scripts/svg_quality/checker.py
+++ b/skills/ppt-master/scripts/svg_quality/checker.py
@@ -1314,9 +1314,7 @@ class SVGQualityChecker:
if (
self.quick_generate
- and svg_path.name == sorted(
- p.name for p in svg_path.parent.glob('*.svg')
- )[0]
+ and svg_path.name == discover_slide_svgs(svg_path.parent)[0].name
and not (
root.get('lang')
or root.get('{http://www.w3.org/XML/1998/namespace}lang')
diff --git a/skills/ppt-master/scripts/svg_to_pptx/drawingml/theme_fonts.py b/skills/ppt-master/scripts/svg_to_pptx/drawingml/theme_fonts.py
index d53431d0..319ed536 100644
--- a/skills/ppt-master/scripts/svg_to_pptx/drawingml/theme_fonts.py
+++ b/skills/ppt-master/scripts/svg_to_pptx/drawingml/theme_fonts.py
@@ -10,6 +10,7 @@ from pathlib import Path
from xml.etree import ElementTree as ET
from language_tags import language_base, language_uses_rtl
+from slide_roster import discover_slide_svgs
from .utils import _explicit_language_script, font_px_to_hpt, parse_font_family
@@ -215,7 +216,7 @@ def load_theme_font_spec_from_pages(
The page root's ``font-family`` is the minor (body) face; the family of
the largest text on the page is the major (title) face.
"""
- pages = sorted((project_path / "svg_output").glob("*.svg"))
+ pages = discover_slide_svgs(project_path / "svg_output")
if not pages:
return None
try:
diff --git a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/cli.py b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/cli.py
index 62961b29..181ad6b9 100644
--- a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/cli.py
+++ b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/cli.py
@@ -68,6 +68,7 @@ from pptx_workspace import ( # noqa: E402
source_pptx_path,
workspace_resource_specs,
)
+from slide_roster import discover_slide_svgs # noqa: E402
configure_utf8_stdio()
@@ -1641,7 +1642,7 @@ def _svg_root_language(project_path: Path) -> str | None:
Quick has no lock; its pages carry the deck language on the root
``<svg lang="...">`` instead.
"""
- pages = sorted((project_path / 'svg_output').glob('*.svg'))
+ pages = discover_slide_svgs(project_path / 'svg_output')
for page in pages[:1]:
try:
with open(str(page), 'rb') as page_file:
diff --git a/skills/ppt-master/scripts/tests/test_slide_roster_first_page.py b/skills/ppt-master/scripts/tests/test_slide_roster_first_page.py
new file mode 100644
index 00000000..389458b4
--- /dev/null
+++ b/skills/ppt-master/scripts/tests/test_slide_roster_first_page.py
@@ -0,0 +1,99 @@
+#!/usr/bin/env python3
+"""The first-page probes read the roster's page 1, not the lexically first file."""
+
+from __future__ import annotations
+
+import sys
+import tempfile
+import unittest
+from pathlib import Path
+
+SCRIPTS_DIR = Path(__file__).resolve().parents[1]
+if str(SCRIPTS_DIR) not in sys.path:
+ sys.path.insert(0, str(SCRIPTS_DIR))
+
+from svg_quality.checker import SVGQualityChecker # noqa: E402
+from svg_to_pptx.drawingml.theme_fonts import load_theme_font_spec_from_pages # noqa: E402
+from svg_to_pptx.pptx_package.cli import _declared_primary_language # noqa: E402
+
+NO_DECK_LANGUAGE = "Quick roster declares no deck language"
+
+
+def _page(title_family: str, body_family: str, language: str = "") -> str:
+ """One Quick page: root font-family is the body face, the 72px text the title face."""
+ language_attribute = f' lang="{language}"' if language else ""
+ return (
+ '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1280 720"'
+ f'{language_attribute} font-family="{body_family}">'
+ f'<text x="80" y="260" font-family="{title_family}" font-size="72">経営戦略</text>'
+ '<text x="80" y="360" font-size="24">年度計画</text></svg>\n'
+ )
+
+
+def _build_roster(pages_dir: Path, width: int, cover_language: str = "ja-JP") -> None:
+ """Write pages 1 to 10, numbered with ``width`` digits, the cover carrying the deck language."""
+ pages_dir.mkdir(parents=True, exist_ok=True)
+ (pages_dir / f"{1:0{width}d}_cover.svg").write_text(
+ _page("Cover Title", "Cover Body", cover_language), encoding="utf-8"
+ )
+ for number in range(2, 10):
+ (pages_dir / f"{number:0{width}d}_body.svg").write_text(
+ _page("Body Title", "Body Font"), encoding="utf-8"
+ )
+ (pages_dir / f"{10:0{width}d}_end.svg").write_text(
+ _page("End Title", "End Body"), encoding="utf-8"
+ )
+
+
+class UnpaddedRosterTests(unittest.TestCase):
+ """``10_end.svg`` sorts before ``1_cover.svg`` by name but is still page 10."""
+
+ def setUp(self) -> None:
+ temporary = tempfile.TemporaryDirectory()
+ self.addCleanup(temporary.cleanup)
+ self.project = Path(temporary.name)
+ self.pages = self.project / "svg_output"
+ _build_roster(self.pages, width=1)
+
+ def test_deck_language_comes_from_the_cover(self) -> None:
+ self.assertEqual(_declared_primary_language(self.project), "ja-JP")
+
+ def test_theme_fonts_come_from_the_cover(self) -> None:
+ spec = load_theme_font_spec_from_pages(self.project, "ja-JP")
+ self.assertIsNotNone(spec)
+ self.assertEqual(spec.major_family, "Cover Title")
+ self.assertEqual(spec.minor_family, "Cover Body")
+
+ def test_the_deck_language_advisory_lands_on_the_cover(self) -> None:
+ _build_roster(self.pages, width=1, cover_language="")
+ checker = SVGQualityChecker(quick_generate=True)
+ cover = checker.check_file(str(self.pages / "1_cover.svg"))
+ last = checker.check_file(str(self.pages / "10_end.svg"))
+ self.assertTrue(any(NO_DECK_LANGUAGE in text for text in cover["warnings"]))
+ self.assertFalse(any(NO_DECK_LANGUAGE in text for text in last["warnings"]))
+
+
+class PaddedRosterTests(unittest.TestCase):
+ """A zero-padded roster already agreed with name order and must not move."""
+
+ def setUp(self) -> None:
+ temporary = tempfile.TemporaryDirectory()
+ self.addCleanup(temporary.cleanup)
+ self.project = Path(temporary.name)
+ self.pages = self.project / "svg_output"
+ _build_roster(self.pages, width=2)
+
+ def test_deck_language_and_theme_fonts_still_come_from_the_cover(self) -> None:
+ self.assertEqual(_declared_primary_language(self.project), "ja-JP")
+ spec = load_theme_font_spec_from_pages(self.project, "ja-JP")
+ self.assertIsNotNone(spec)
+ self.assertEqual(spec.major_family, "Cover Title")
+ self.assertEqual(spec.minor_family, "Cover Body")
+
+ def test_the_deck_language_advisory_lands_on_the_cover(self) -> None:
+ _build_roster(self.pages, width=2, cover_language="")
+ checker = SVGQualityChecker(quick_generate=True)
+ cover = checker.check_file(str(self.pages / "01_cover.svg"))
+ last = checker.check_file(str(self.pages / "10_end.svg"))
+ self.assertTrue(any(NO_DECK_LANGUAGE in text for text in cover["warnings"]))
+ self.assertFalse(any(NO_DECK_LANGUAGE in text for text in last["warnings"]))