Skip to content

AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He

fix(pptx-effects): round native effect alpha

hugohe32375d741d291
diff --git a/skills/ppt-master/scripts/svg_to_pptx/drawingml/styles.py b/skills/ppt-master/scripts/svg_to_pptx/drawingml/styles.py
index 5bcacdb8..495193b3 100644
--- a/skills/ppt-master/scripts/svg_to_pptx/drawingml/styles.py
+++ b/skills/ppt-master/scripts/svg_to_pptx/drawingml/styles.py
@@ -726,7 +726,7 @@ def build_shadow_xml(
# composite (different blending path). Scale by 0.75 to match the SVG
# preview after blur has been corrected to 2.0× σ.
opacity_multiplier = 1.0 if opacity is None else opacity
- alpha_val = int(p['opacity'] * opacity_multiplier * 75000)
+ alpha_val = int(round(p['opacity'] * opacity_multiplier * 75000))
algn = _infer_shadow_alignment(dx, dy)
return f'''<a:effectLst>
@@ -751,7 +751,7 @@ def build_glow_xml(
p = _parse_filter_params(filter_elem)
rad = px_to_emu(p['std_dev'])
opacity_multiplier = 1.0 if opacity is None else opacity
- alpha_val = int(p['opacity'] * opacity_multiplier * 100000)
+ alpha_val = int(round(p['opacity'] * opacity_multiplier * 100000))
return f'''<a:effectLst>
<a:glow rad="{rad}">
diff --git a/skills/ppt-master/scripts/test_svg_quality_checker.py b/skills/ppt-master/scripts/test_svg_quality_checker.py
index 11558525..9efeedc9 100644
--- a/skills/ppt-master/scripts/test_svg_quality_checker.py
+++ b/skills/ppt-master/scripts/test_svg_quality_checker.py
@@ -2412,12 +2412,36 @@ class SVGQualityCheckerCompatibilityTests(unittest.TestCase):
self.assertIn('<a:outerShdw blurRad="1" dist="100"', tiny_outer_xml)
self.assertNotIn('<a:glow', tiny_outer_xml)
+ low_alpha_outer = effect_result(
+ f'<a:effectLst xmlns:a="{dml}"><a:outerShdw '
+ 'blurRad="9525" dist="9525" dir="0">'
+ '<a:srgbClr val="000000"><a:alpha val="1"/>'
+ '</a:srgbClr></a:outerShdw></a:effectLst>'
+ )
+ self.assertIn(
+ '<a:alpha val="1"/>',
+ round_trip_supported(low_alpha_outer),
+ )
+
tiny_glow = effect_result(
f'<a:effectLst xmlns:a="{dml}"><a:glow rad="1">'
'<a:srgbClr val="000000"/></a:glow></a:effectLst>'
)
self.assertIn('<a:glow rad="1">', round_trip_supported(tiny_glow))
+ for alpha in (0, 1, 2, 3, 7, 13, 29, 12345, 50001, 99999, 100000):
+ with self.subTest(glow_alpha=alpha):
+ alpha_glow = effect_result(
+ f'<a:effectLst xmlns:a="{dml}"><a:glow rad="9525">'
+ '<a:srgbClr val="000000">'
+ f'<a:alpha val="{alpha}"/></a:srgbClr>'
+ '</a:glow></a:effectLst>'
+ )
+ self.assertIn(
+ f'<a:alpha val="{alpha}"/>',
+ round_trip_supported(alpha_glow),
+ )
+
marked_svg = '''<svg xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 1280 720">
<rect x="80" y="80" width="300" height="180" fill="#FFFFFF"