Skip to content

AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He

fix(template-preserve): match omitted placeholder index as zero

hugohe3408de62fe8a3
diff --git a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_structure.py b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_structure.py
index b26a1b96..1203a61c 100644
--- a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_structure.py
+++ b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_structure.py
@@ -224,6 +224,11 @@ class NativePlaceholderSpec:
idx: int | None
geometry: tuple[float, float, float, float] | None = None
+ @property
+ def effective_idx(self) -> int:
+ """Return the OOXML index after applying the omitted-value default."""
+ return self.idx if self.idx is not None else 0
+
@dataclass(frozen=True)
class NativeLayoutSpec:
@@ -2744,7 +2749,7 @@ def match_native_placeholders(
continue
if (
item.placeholder_idx is not None
- and candidate.idx != item.placeholder_idx
+ and candidate.effective_idx != item.placeholder_idx
):
continue
candidate_index = index
diff --git a/skills/ppt-master/scripts/test_svg_quality_checker.py b/skills/ppt-master/scripts/test_svg_quality_checker.py
index 7e366bbc..8a4cc1a0 100644
--- a/skills/ppt-master/scripts/test_svg_quality_checker.py
+++ b/skills/ppt-master/scripts/test_svg_quality_checker.py
@@ -84,8 +84,13 @@ from svg_to_pptx.native_objects import (
stamp_native_fallback_baseline,
)
from svg_to_pptx.pptx_package.template_structure import (
+ NativeLayoutSpec,
+ NativePlaceholderSpec,
+ TemplateElementSpec,
+ TemplateSlideSpec,
TemplateStructureError,
_validate_placeholder_carrier,
+ match_native_placeholders,
parse_template_slide,
)
from svg_to_pptx.use_expander import UseExpansionError, expand_local_use_references
@@ -4611,6 +4616,48 @@ class SVGQualityCheckerCompatibilityTests(unittest.TestCase):
1,
)
+ def test_native_placeholder_match_uses_effective_zero_index(self):
+ def slide_spec(idx: int) -> TemplateSlideSpec:
+ element = TemplateElementSpec(
+ element_id='title-slot',
+ order=1,
+ tag='g',
+ placeholder='title',
+ placeholder_idx=idx,
+ )
+ return TemplateSlideSpec(
+ slide_num=1,
+ svg_path=Path('01_cover.svg'),
+ master_key='master',
+ master_name='Master',
+ layout_key='layout',
+ layout_name='Layout',
+ elements=(element,),
+ )
+
+ source_placeholder = NativePlaceholderSpec(
+ semantic_role='title',
+ placeholder_type='title',
+ idx=None,
+ )
+ layout = NativeLayoutSpec(
+ key='layout',
+ name='Layout',
+ package_part='ppt/slideLayouts/slideLayout1.xml',
+ master_key='master',
+ placeholders=(source_placeholder,),
+ )
+
+ matches = match_native_placeholders(slide_spec(0), layout)
+ self.assertEqual(matches[0][1], source_placeholder)
+ self.assertIsNone(source_placeholder.idx)
+ self.assertEqual(source_placeholder.effective_idx, 0)
+ with self.assertRaisesRegex(
+ TemplateStructureError,
+ 'title idx=1.*has no compatible source placeholder',
+ ):
+ match_native_placeholders(slide_spec(1), layout)
+
def test_stale_compact_preset_is_not_a_structured_atom_or_carrier(self):
fragment = render_preset_shape_fragment(
'diamond',