Skip to content

AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He

fix(pptx-to-svg): reject endpoints on no-fill lines

hugohe34d44294c9183
diff --git a/skills/ppt-master/references/shared-standards.md b/skills/ppt-master/references/shared-standards.md
index ed86317c..3b848ace 100644
--- a/skills/ppt-master/references/shared-standards.md
+++ b/skills/ppt-master/references/shared-standards.md
@@ -186,7 +186,9 @@ import instead of being normalized to `med`.
Each imported line contains at most one direct, empty `a:headEnd` and one direct,
empty `a:tailEnd`, carrying only optional `type`, `w`, and `len`. Omitted `type`
means `none`; an explicitly empty token, duplicate endpoint, unknown attribute,
-or child payload stops import instead of being ignored.
+or child payload stops import instead of being ignored. A non-`none` endpoint
+also requires a visible resolved line paint; a `noFill` line/end combination
+stops import instead of producing a project-invalid invisible marker.
---
diff --git a/skills/ppt-master/scripts/pptx_to_svg/ln_to_svg.py b/skills/ppt-master/scripts/pptx_to_svg/ln_to_svg.py
index 03eaf2ea..25efde2a 100644
--- a/skills/ppt-master/scripts/pptx_to_svg/ln_to_svg.py
+++ b/skills/ppt-master/scripts/pptx_to_svg/ln_to_svg.py
@@ -314,6 +314,10 @@ def _build_arrow_marker(
)
if typ is None or typ == "none":
return None, ""
+ if stroke_color.strip().lower() == "none":
+ raise ValueError(
+ "DrawingML line end requires a visible line paint"
+ )
mw = SIZE_BUCKET[l_b]
mh = SIZE_BUCKET[w_b]
diff --git a/skills/ppt-master/scripts/test_svg_quality_checker.py b/skills/ppt-master/scripts/test_svg_quality_checker.py
index 2b95fb5e..1af583aa 100644
--- a/skills/ppt-master/scripts/test_svg_quality_checker.py
+++ b/skills/ppt-master/scripts/test_svg_quality_checker.py
@@ -2675,6 +2675,21 @@ class SVGQualityCheckerCompatibilityTests(unittest.TestCase):
</p:spPr>''')
self.assertEqual(resolve_stroke(omitted_type, None).attrs, {})
+ def test_native_line_end_requires_visible_line_paint(self):
+ sp_pr = ET.fromstring('''
+<p:spPr xmlns:p="http://schemas.openxmlformats.org/presentationml/2006/main"
+ xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main">
+ <a:ln>
+ <a:noFill/>
+ <a:tailEnd type="triangle"/>
+ </a:ln>
+</p:spPr>''')
+ with self.assertRaisesRegex(
+ ValueError,
+ 'DrawingML line end requires a visible line paint',
+ ):
+ resolve_stroke(sp_pr, None)
+
def test_unknown_native_line_end_size_is_rejected_on_import(self):
for attribute, dimension in (("w", "width"), ("len", "length")):
with self.subTest(attribute=attribute):