Skip to content

AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He

fix(pptx-layouts): isolate cloned master package identity

hugohe35aacdf6cdb5b
diff --git a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/builder.py b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/builder.py
index 7e7df18e..00a9fcec 100644
--- a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/builder.py
+++ b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/builder.py
@@ -115,6 +115,10 @@ SLIDE_LAYOUT_REL_TYPE = (
SLIDE_MASTER_REL_TYPE = (
"http://schemas.openxmlformats.org/officeDocument/2006/relationships/slideMaster"
)
+THEME_REL_TYPE = (
+ "http://schemas.openxmlformats.org/officeDocument/2006/relationships/theme"
+)
+THEME_CONTENT_TYPE = "application/vnd.openxmlformats-officedocument.theme+xml"
PML_NS = "http://schemas.openxmlformats.org/presentationml/2006/main"
DML_NS = "http://schemas.openxmlformats.org/drawingml/2006/main"
REL_NS = "http://schemas.openxmlformats.org/officeDocument/2006/relationships"
@@ -801,6 +805,7 @@ def _create_custom_layout(
base_layout_path = extract_dir / base_layout_part
tree = ET.parse(base_layout_path)
root = tree.getroot()
+ _reseed_p14_creation_id(root)
root.set("type", "cust")
root.set("preserve", "1")
root.set("showMasterSp", "1" if show_master_shapes else "0")
@@ -897,6 +902,22 @@ def _set_master_picker_name(master_path: Path, master_name: str) -> None:
_write_xml_tree(master_path, tree)
+def _reseed_p14_creation_id(root: ET.Element) -> None:
+ """Give a cloned Slide/Master/Layout part a fresh PowerPoint creation id."""
+ c_sld = root.find(f"{{{PML_NS}}}cSld")
+ if c_sld is None:
+ return
+ creation_ids = c_sld.findall(
+ f"{{{PML_NS}}}extLst/{{{PML_NS}}}ext/"
+ f"{{{P14_NS}}}creationId"
+ )
+ for creation_id in creation_ids:
+ value = 0
+ while value == 0:
+ value = uuid.uuid4().int & OOXML_UINT32_MAX
+ creation_id.set("val", str(value))
+
+
def _next_master_part_number(extract_dir: Path) -> int:
numbers = [
int(match.group(1))
@@ -906,6 +927,103 @@ def _next_master_part_number(extract_dir: Path) -> int:
return max(numbers, default=0) + 1
+def _next_theme_part_number(extract_dir: Path) -> int:
+ numbers = [
+ int(match.group(1))
+ for path in (extract_dir / "ppt" / "theme").glob("theme*.xml")
+ if (match := re.fullmatch(r"theme(\d+)\.xml", path.name))
+ ]
+ return max(numbers, default=0) + 1
+
+
+def _clone_master_theme(
+ extract_dir: Path,
+ source_master_part: str,
+ master_part: str,
+ master_name: str,
+) -> str:
+ """Give a cloned Slide Master its own Theme package part."""
+ source_master_rels = _relationships_path_for_part(
+ extract_dir,
+ source_master_part,
+ )
+ theme_targets = [
+ attrs["Target"]
+ for attrs in _read_relationships(source_master_rels).values()
+ if attrs.get("Type") == THEME_REL_TYPE and attrs.get("Target")
+ ]
+ if len(theme_targets) != 1:
+ raise RuntimeError(
+ "Source Slide Master must have one Theme relationship: "
+ f"{source_master_part}"
+ )
+ source_theme_part = _resolve_package_target(
+ source_master_part,
+ theme_targets[0],
+ )
+ source_theme_path = extract_dir / source_theme_part
+ if not source_theme_path.exists():
+ raise RuntimeError(
+ f"Slide Master Theme part is missing: {source_theme_part}"
+ )
+
+ theme_num = _next_theme_part_number(extract_dir)
+ theme_part = f"ppt/theme/theme{theme_num}.xml"
+ theme_path = extract_dir / theme_part
+ shutil.copyfile(source_theme_path, theme_path)
+ theme_tree = ET.parse(theme_path)
+ theme_tree.getroot().set("name", f"{master_name} Theme")
+ _write_xml_tree(theme_path, theme_tree)
+
+ source_theme_rels = _relationships_path_for_part(
+ extract_dir,
+ source_theme_part,
+ )
+ if source_theme_rels.exists():
+ theme_rels = _relationships_path_for_part(extract_dir, theme_part)
+ theme_rels.parent.mkdir(parents=True, exist_ok=True)
+ shutil.copyfile(source_theme_rels, theme_rels)
+
+ master_rels = _relationships_path_for_part(extract_dir, master_part)
+ theme_relationships = [
+ (rel_id, attrs)
+ for rel_id, attrs in _read_relationships(master_rels).items()
+ if attrs.get("Type") == THEME_REL_TYPE
+ ]
+ if len(theme_relationships) != 1:
+ raise RuntimeError(
+ f"Cloned Slide Master must have one Theme relationship: {master_part}"
+ )
+ theme_rel_id, _attrs = theme_relationships[0]
+ theme_target = posixpath.relpath(theme_part, posixpath.dirname(master_part))
+ rels_content = master_rels.read_text(encoding="utf-8")
+ theme_rel_pattern = re.compile(
+ rf'(<Relationship\b[^>]*\bId="{re.escape(theme_rel_id)}"'
+ rf'[^>]*\bTarget=")[^"]*(")'
+ )
+ rels_content, replaced = theme_rel_pattern.subn(
+ rf"\g<1>{theme_target}\g<2>",
+ rels_content,
+ count=1,
+ )
+ if replaced != 1:
+ raise RuntimeError(
+ f"Could not retarget cloned Slide Master Theme: {master_part}"
+ )
+ master_rels.write_text(rels_content, encoding="utf-8")
+
+ content_types_path = extract_dir / "[Content_Types].xml"
+ content_types_path.write_text(
+ _add_content_type_override(
+ content_types_path.read_text(encoding="utf-8"),
+ theme_part,
+ THEME_CONTENT_TYPE,
+ ),
+ encoding="utf-8",
+ )
+ return theme_part
+
+
def _clone_structured_master(
extract_dir: Path,
source_master_part: str,
@@ -920,6 +1038,7 @@ def _clone_structured_master(
tree = ET.parse(master_path)
root = tree.getroot()
+ _reseed_p14_creation_id(root)
c_sld = root.find(f"{{{PML_NS}}}cSld")
if c_sld is None:
raise RuntimeError(f"Slide master has no p:cSld: {source_master_part}")
@@ -940,6 +1059,12 @@ def _clone_structured_master(
for rel_id, attrs in tuple(_read_relationships(master_rels).items()):
if attrs.get("Type") == SLIDE_LAYOUT_REL_TYPE:
_remove_relationship(master_rels, rel_id)
+ _clone_master_theme(
+ extract_dir,
+ source_master_part,
+ master_part,
+ master_name,
+ )
presentation_rels = extract_dir / "ppt" / "_rels" / "presentation.xml.rels"
relationship_target = posixpath.relpath(master_part, "ppt")
diff --git a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_validation.py b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_validation.py
index f7499ac3..c6e1db89 100644
--- a/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_validation.py
+++ b/skills/ppt-master/scripts/svg_to_pptx/pptx_package/template_validation.py
@@ -49,6 +49,7 @@ from .template_structure import (
PML_NS = "http://schemas.openxmlformats.org/presentationml/2006/main"
DML_NS = "http://schemas.openxmlformats.org/drawingml/2006/main"
REL_NS = "http://schemas.openxmlformats.org/officeDocument/2006/relationships"
+P14_NS = "http://schemas.microsoft.com/office/powerpoint/2010/main"
SLIDE_LAYOUT_REL_TYPE = (
"http://schemas.openxmlformats.org/officeDocument/2006/relationships/slideLayout"
)
@@ -58,6 +59,9 @@ SLIDE_REL_TYPE = (
SLIDE_MASTER_REL_TYPE = (
"http://schemas.openxmlformats.org/officeDocument/2006/relationships/slideMaster"
)
+THEME_REL_TYPE = (
+ "http://schemas.openxmlformats.org/officeDocument/2006/relationships/theme"
+)
SLIDE_LAYOUT_CONTENT_TYPE = (
"application/vnd.openxmlformats-officedocument.presentationml.slideLayout+xml"
)
@@ -156,6 +160,51 @@ class _PackageReader:
return result
+def _validate_unique_creation_ids(
+ reader: _PackageReader,
+ parts: set[str],
+) -> None:
+ """Reject cloned PowerPoint parts that retain the same p14:creationId."""
+ owners: dict[int, str] = {}
+ for part in sorted(parts):
+ root = reader.xml(part)
+ if root is None:
+ continue
+ c_sld = root.find(f"{{{PML_NS}}}cSld")
+ if c_sld is None:
+ continue
+ seen_in_part: set[int] = set()
+ for creation_id in c_sld.findall(
+ f"{{{PML_NS}}}extLst/{{{PML_NS}}}ext/"
+ f"{{{P14_NS}}}creationId"
+ ):
+ raw_value = creation_id.get("val")
+ try:
+ value = int(raw_value or "")
+ except ValueError:
+ reader.errors.append(
+ f"{part} has invalid p14:creationId value {raw_value!r}"
+ )
+ continue
+ if value < 0 or value > OOXML_UINT32_MAX:
+ reader.errors.append(
+ f"{part} p14:creationId {value} is outside OOXML UInt32"
+ )
+ continue
+ if value in seen_in_part:
+ reader.errors.append(
+ f"{part} repeats p14:creationId {value}"
+ )
+ continue
+ seen_in_part.add(value)
+ previous_owner = owners.setdefault(value, part)
+ if previous_owner != part:
+ reader.errors.append(
+ f"p14:creationId {value} is shared by "
+ f"{previous_owner} and {part}"
+ )
+
+
def _top_level_shape_names(
root: ET.Element,
context: str,
@@ -759,6 +808,39 @@ def _validate_presentation_master_registration(
)
+def _validate_master_theme_ownership(
+ reader: _PackageReader,
+ master_parts: set[str],
+) -> None:
+ """Require a separate Theme part for every structured Slide Master."""
+ owners: dict[str, str] = {}
+ for master_part in sorted(master_parts):
+ resolved = _single_relationship_target(
+ reader,
+ master_part,
+ THEME_REL_TYPE,
+ f"Master {master_part}",
+ )
+ if resolved is None:
+ continue
+ _relationship, theme_part = resolved
+ if not (
+ theme_part.startswith("ppt/theme/")
+ and theme_part.endswith(".xml")
+ ):
+ reader.errors.append(
+ f"Master {master_part} targets non-Theme part {theme_part}"
+ )
+ continue
+ reader.xml(theme_part)
+ previous_owner = owners.setdefault(theme_part, master_part)
+ if previous_owner != master_part:
+ reader.errors.append(
+ f"Theme {theme_part} is shared by structured Masters "
+ f"{previous_owner} and {master_part}"
+ )
+
+
def _validate_presentation_slide_registration(
reader: _PackageReader,
slide_parts: set[str],
@@ -1373,8 +1455,13 @@ def validate_pptx_template_package(
errors,
"Master",
)
+ _validate_unique_creation_ids(
+ reader,
+ expected_slide_parts | expected_layout_parts | used_master_parts,
+ )
_validate_presentation_slide_registration(reader, expected_slide_parts)
_validate_presentation_master_registration(reader, used_master_parts)
+ _validate_master_theme_ownership(reader, used_master_parts)
except (OSError, zipfile.BadZipFile) as exc:
raise ValueError(f"cannot read template PPTX package {path}: {exc}") from exc