Skip to content

AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He

fix(svg-to-pptx): reject bounding-box filter coordinates

hugohe38200343a80fa
diff --git a/skills/ppt-master/references/shared-standards.md b/skills/ppt-master/references/shared-standards.md
index d42ec23c..90f637e6 100644
--- a/skills/ppt-master/references/shared-standards.md
+++ b/skills/ppt-master/references/shared-standards.md
@@ -762,6 +762,7 @@ Filters are native-effect metadata, not a general pixel-filter surface.
| Accepted helpers | `feOffset`, `feFlood`, `feComposite`, `feMerge`, `feMergeNode`, `feComponentTransfer`, linear `feFuncA` |
| Alpha transfer | Linear `feFuncA` maps multiplicative `slope` only; `intercept` is unsupported |
| Blur sampling | `feGaussianBlur edgeMode` is unsupported; native effects do not expose the SVG edge-sampling modes |
+| Primitive coordinates | Omit `primitiveUnits` or use `userSpaceOnUse`; `objectBoundingBox` coordinates are unsupported |
| Numeric values | Finite unitless values; non-negative `stdDeviation`; finite `dx` / `dy`; `feFuncA slope` within `0..1`; mapped glow `rad = stdDeviation × 9525`, shadow `blurRad = stdDeviation × 2 × 9525`, and shadow `dist = hypot(dx,dy) × 9525` must round into DrawingML `0..27273042316900` |
| Classification | Meaningful non-zero offset → one outer shadow; zero/no offset → one glow |
| Fidelity | `Approximate`; one filter becomes one DrawingML effect |
diff --git a/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.py b/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.py
index 4e33e353..3cef7d2d 100644
--- a/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.py
+++ b/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.py
@@ -1927,6 +1927,12 @@ def parse_project_filter_params(
filter_elem: ET.Element,
) -> dict[str, float | str | bool]:
"""Extract the shared native shadow/glow parameters from one filter."""
+ primitive_units = filter_elem.get('primitiveUnits')
+ if primitive_units not in (None, 'userSpaceOnUse'):
+ raise ValueError(
+ 'filter primitiveUnits must be userSpaceOnUse when explicit; '
+ f'got {primitive_units!r}'
+ )
std_dev: float | None = None
dx = 0.0
dy = 0.0
@@ -2132,6 +2138,13 @@ def project_filter_errors(root: ET.Element) -> list[str]:
for filter_id, filter_elem in filters_by_id.items():
label = f'filter #{filter_id}'
parameters_are_valid = True
+ primitive_units = filter_elem.get('primitiveUnits')
+ if primitive_units not in (None, 'userSpaceOnUse'):
+ parameters_are_valid = False
+ errors.add(
+ f'{label} primitiveUnits must be userSpaceOnUse when '
+ f'explicit; got {primitive_units!r}'
+ )
primitives = [
_svg_element_tag(descendant) or str(descendant.tag)
for descendant in filter_elem.iter()
diff --git a/skills/ppt-master/scripts/test_svg_quality_checker.py b/skills/ppt-master/scripts/test_svg_quality_checker.py
index ced57f7a..dd6b259b 100644
--- a/skills/ppt-master/scripts/test_svg_quality_checker.py
+++ b/skills/ppt-master/scripts/test_svg_quality_checker.py
@@ -2599,6 +2599,33 @@ class SVGQualityCheckerCompatibilityTests(unittest.TestCase):
'invalid project filter',
)
+ def test_filter_rejects_object_bounding_box_primitive_units(self):
+ self._assert_checker_and_exporter_reject(
+ '''<svg xmlns="http://www.w3.org/2000/svg"
+ viewBox="0 0 1280 720">
+ <defs>
+ <filter id="effect" primitiveUnits="objectBoundingBox">
+ <feGaussianBlur stdDeviation="0.1"/>
+ <feFlood flood-color="#000000" flood-opacity="0.4"/>
+ </filter>
+ </defs>
+ <rect x="80" y="80" width="300" height="180"
+ fill="#FFFFFF" filter="url(#effect)"/>
+</svg>''',
+ 'primitiveUnits must be userSpaceOnUse',
+ 'invalid project filter',
+ )
+
+ user_space = ET.fromstring('''<svg xmlns="http://www.w3.org/2000/svg">
+ <defs>
+ <filter id="effect" primitiveUnits="userSpaceOnUse">
+ <feGaussianBlur stdDeviation="6"/>
+ <feFlood flood-color="#000000" flood-opacity="0.4"/>
+ </filter>
+ </defs>
+</svg>''')
+ self.assertEqual(project_filter_errors(user_space), [])
+
def test_filter_flood_opacity_must_be_explicit(self):
cases = (
(