AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He
fix(pptx-effects): allow validated preset preview filters
hugohe3c7dd5860e249
diff --git a/skills/ppt-master/references/shared-standards.md b/skills/ppt-master/references/shared-standards.mdindex 3bb6ec7f..04f49bcb 100644--- a/skills/ppt-master/references/shared-standards.md+++ b/skills/ppt-master/references/shared-standards.md@@ -271,7 +271,7 @@ attributes, and no separate source-payload opt-in marker exists.| `data-pptx-prst` | Preset carrier and logical `<g>` | One of the locked 187 DrawingML `ST_ShapeType` values. || `data-pptx-av-*` | Preset carrier and logical `<g>` | Preserve the complete validated DrawingML adjustment formula, including non-`val` formulas. || `data-pptx-part="geometry"` | One hidden carrier path | The single native export authority for frame, base fill/line/effect, preset/custom geometry, and object identity. |-| `data-pptx-part="geometry-preview"` / `geometry-detail` | Visible preview group/paths | Render the preset's independent path fill/stroke layers. These elements are never emitted as duplicate PowerPoint shapes. |+| `data-pptx-part="geometry-preview"` / `geometry-detail` | Visible preview group/paths | Render the preset's independent path fill/stroke layers. A hash-locked preview group may mirror the carrier's one filter so a multi-path preset renders one aggregate imported effect; these elements are never emitted as duplicate PowerPoint shapes. || `data-pptx-preview-sha256` | Logical preset `<g>` and carrier | Detect edits to visible preset paths or paint. A stale preview fails quality check/export instead of silently restoring old native metadata. || `data-pptx-geometry-kind="custom"` + `data-pptx-custgeom` | Custom-geometry carrier | Preserve the validated original `a:custGeom` subtree. If the visible path hash is unchanged, export restores formulas, handles, connection sites, text rectangle, and path list exactly; edited paths compile from current SVG geometry. || `data-pptx-start/end-shape-id/site` | Connector logical `<g>` and carrier | Restore `a:stCxn` / `a:endCxn` after scoped shape-id allocation. A connector may retain one zero frame axis; it must not be expanded from visible stroke or marker bounds. |@@ -763,6 +763,11 @@ Native export does not preserve filter-region, `in/in2/result`, merge order, orcomposite topology. Other primitives, multiple independent effects, filters on`<image>` / `<tspan>` / `<g>` / unsupported targets are forbidden; apply theeffect to supported objects or use explicit layers.+The sole `<g filter>` exception is the hash-locked+`data-pptx-part="geometry-preview"` transport in §1.4: it must be a direct child+of an imported preset object and reference the same filter as that object's one+hidden geometry carrier. The preview is render-only and never becomes a second+PowerPoint object; this exception does not authorize filters on ordinary groups.The quality checker and exporter preflight enforce the same definition,reference, primitive, target, and numeric-value contract; malformed values arenever replaced by effect defaults during native export.diff --git a/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.py b/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.pyindex 90a58237..4e88de1d 100644--- a/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.py+++ b/skills/ppt-master/scripts/svg_to_pptx/drawingml/utils.py@@ -14,7 +14,11 @@ from collections import Counterfrom collections.abc import Iteratorfrom xml.etree import ElementTree as ET-from pptx_shapes import validate_ooxml_xfrm+from pptx_shapes import (+ resolve_preset_preview_hash,+ svg_preset_preview_fingerprint,+ validate_ooxml_xfrm,+)from .context import AffineMatrix, ConvertContext, IDENTITY_MATRIX@@ -1927,6 +1931,11 @@ def project_filter_errors(root: ET.Element) -> list[str]:if _svg_element_tag(elem) == 'filter'}errors: set[str] = set()+ parents = {+ child: parent+ for parent in root.iter()+ for child in parent+ }for elem in root.iter():tag = (_svg_element_tag(elem) or str(elem.tag)).lower()@@ -1941,7 +1950,10 @@ def project_filter_errors(root: ET.Element) -> list[str]:raw_filter = elem.get('filter')if raw_filter is None:continue- if tag not in PROJECT_FILTER_PUBLIC_TARGETS:+ if (+ tag not in PROJECT_FILTER_PUBLIC_TARGETS+ and not _is_imported_preset_preview_filter_target(elem, parents)+ ):errors.add(f'{label} cannot use filter; supported native targets are ''rect, circle, path, and text'@@ -2032,6 +2044,76 @@ def project_filter_errors(root: ET.Element) -> list[str]:return sorted(errors)+def _is_imported_preset_preview_filter_target(+ elem: ET.Element,+ parents: dict[ET.Element, ET.Element],+) -> bool:+ """Recognize the render-only aggregate filter on an imported preset.++ DrawingML presets can contain several visible path layers but own one+ shape-level effect. The lossless importer therefore keeps the native+ filter on the hidden geometry carrier and mirrors the same reference onto+ its hash-locked preview group. The preview group is never exported as a+ separate PowerPoint object; ordinary authored ``<g filter>`` remains+ outside the project contract.+ """+ if (+ _svg_element_tag(elem) != 'g'+ or elem.get('data-pptx-part') != 'geometry-preview'+ ):+ return False+ parent = parents.get(elem)+ if (+ parent is None+ or _svg_element_tag(parent) != 'g'+ or parent.get('data-pptx-object') not in {'shape', 'connector'}+ or not parent.get('data-pptx-prst')+ or not parent.get('data-pptx-frame')+ ):+ return False+ previews = [+ child+ for child in parent+ if child.get('data-pptx-part') == 'geometry-preview'+ ]+ if len(previews) != 1 or previews[0] is not elem:+ return False+ preview_children = list(elem)+ if not preview_children or any(+ _svg_element_tag(child) != 'path'+ or child.get('data-pptx-part') != 'geometry-detail'+ or len(child) != 0+ for child in preview_children+ ):+ return False+ carriers = [+ child+ for child in parent+ if child.get('data-pptx-part') == 'geometry'+ ]+ if len(carriers) != 1:+ return False+ carrier = carriers[0]+ if not (+ _svg_element_tag(carrier) == 'path'+ and carrier.get('visibility') == 'hidden'+ and carrier.get('pointer-events') == 'none'+ and carrier.get('data-pptx-object') == parent.get('data-pptx-object')+ and carrier.get('data-pptx-prst') == parent.get('data-pptx-prst')+ and carrier.get('data-pptx-frame') == parent.get('data-pptx-frame')+ and carrier.get('filter') == elem.get('filter')+ ):+ return False+ try:+ expected_hash = resolve_preset_preview_hash(parent)+ except ValueError:+ return False+ return (+ expected_hash is not None+ and svg_preset_preview_fingerprint(parent) == expected_hash+ )++def parse_hex_color(color_str: str) -> str | None:"""Parse SVG color values to ``RRGGBB``, ignoring any alpha channel."""if color_str and color_str.strip().lower() == 'transparent':diff --git a/skills/ppt-master/scripts/test_svg_quality_checker.py b/skills/ppt-master/scripts/test_svg_quality_checker.pyindex 6bb4c619..9208a6cf 100644--- a/skills/ppt-master/scripts/test_svg_quality_checker.py+++ b/skills/ppt-master/scripts/test_svg_quality_checker.py@@ -27,6 +27,7 @@ from svg_quality_checker import SVGQualityCheckerfrom pptx_shapes import (CONNECTOR_PRESET_TYPES,get_preset_registry,+ svg_preset_preview_fingerprint,svg_text_fingerprint,)from pptx_to_svg.preset_authoring import (@@ -35,6 +36,8 @@ from pptx_to_svg.preset_authoring import (validate_authored_preset_tree,)from pptx_to_svg.emu_units import Xfrm+from pptx_to_svg.preset_registry_to_svg import render_preset_geometry+from pptx_to_svg.preset_svg_markup import serialize_preset_layersfrom pptx_to_svg.converter import ConvertOptions, convert_pptx_to_svgfrom pptx_to_svg.ooxml_loader import parse_ooxml_booleanfrom pptx_to_svg.txbody_to_svg import convert_txbody, convert_vertical_txbody@@ -60,6 +63,7 @@ from svg_to_pptx.drawingml.elements import parse_project_nested_svg_cropfrom svg_to_pptx.drawingml.utils import (estimate_text_width,parse_inline_style,+ project_filter_errors,split_project_text_clusters,)from svg_to_pptx.native_objects import (@@ -1931,6 +1935,147 @@ class SVGQualityCheckerCompatibilityTests(unittest.TestCase):'invalid project filter',)+ def test_imported_preset_preview_may_mirror_carrier_filter(self):+ rendered = render_preset_geometry(+ 'cube',+ Xfrm(x=100, y=120, w=300, h=160),+ )+ semantic_attrs = {+ 'data-pptx-object': 'shape',+ 'data-pptx-shape-id': '2',+ 'data-pptx-shape-scope': 'slide',+ 'data-pptx-frame': '100 120 300 160',+ 'data-pptx-prst': 'cube',+ }+ markup = serialize_preset_layers(+ rendered.paths,+ semantic_attrs,+ {+ 'fill': '#FFFFFF',+ 'stroke': 'none',+ 'filter': 'url(#shadow)',+ },+ )+ svg = f'''<svg xmlns="http://www.w3.org/2000/svg"+ viewBox="0 0 1280 720">+ <defs>+ <filter id="shadow">+ <feDropShadow dx="0" dy="4" stdDeviation="6"+ flood-color="#000000" flood-opacity="0.2"/>+ </filter>+ </defs>+ <g id="imported-cube" data-pptx-object="shape"+ data-pptx-shape-id="2" data-pptx-shape-scope="slide"+ data-pptx-frame="100 120 300 160" data-pptx-prst="cube"+ data-pptx-preview-sha256="{markup.preview_hash}">+ {markup.markup}+ </g>+</svg>'''+ root = ET.fromstring(svg)+ self.assertEqual(project_filter_errors(root), [])++ with tempfile.TemporaryDirectory() as tmp_dir:+ svg_path = Path(tmp_dir) / 'imported-effect.svg'+ svg_path.write_text(svg, encoding='utf-8')+ with contextlib.redirect_stdout(io.StringIO()):+ checker_result = SVGQualityChecker().check_file(str(svg_path))+ self.assertEqual(checker_result['errors'], [])+ slide_xml, *_rest = convert_svg_to_slide_shapes(svg_path)+ self.assertEqual(slide_xml.count('<p:sp>'), 1)+ self.assertNotIn('<p:grpSp>', slide_xml)+ self.assertEqual(slide_xml.count('<a:outerShdw'), 1)++ preview = next(+ elem+ for elem in root.iter()+ if elem.get('data-pptx-part') == 'geometry-preview'+ )+ preview.set('filter', 'url(#different)')+ self.assertTrue(any(+ '<g> cannot use filter' in error+ for error in project_filter_errors(root)+ ))++ def imported_parts(+ document: ET.Element,+ ) -> tuple[ET.Element, ET.Element, ET.Element]:+ logical = next(+ elem+ for elem in document.iter()+ if elem.get('id') == 'imported-cube'+ )+ native_carrier = next(+ elem+ for elem in logical+ if elem.get('data-pptx-part') == 'geometry'+ )+ visible_preview = next(+ elem+ for elem in logical+ if elem.get('data-pptx-part') == 'geometry-preview'+ )+ return logical, native_carrier, visible_preview++ def refresh_preview_hash(+ logical: ET.Element,+ native_carrier: ET.Element,+ ) -> None:+ digest = svg_preset_preview_fingerprint(logical)+ logical.set('data-pptx-preview-sha256', digest)+ native_carrier.set('data-pptx-preview-sha256', digest)++ foreign_child_root = ET.fromstring(svg)+ logical, carrier, visible_preview = imported_parts(foreign_child_root)+ ET.SubElement(visible_preview, '{http://www.w3.org/2000/svg}rect', {+ 'x': '100',+ 'y': '120',+ 'width': '10',+ 'height': '10',+ })+ refresh_preview_hash(logical, carrier)+ self.assertTrue(any(+ '<g> cannot use filter' in error+ for error in project_filter_errors(foreign_child_root)+ ))++ duplicate_preview_root = ET.fromstring(svg)+ logical, carrier, visible_preview = imported_parts(duplicate_preview_root)+ logical.append(ET.fromstring(ET.tostring(visible_preview)))+ refresh_preview_hash(logical, carrier)+ self.assertTrue(any(+ '<g> cannot use filter' in error+ for error in project_filter_errors(duplicate_preview_root)+ ))++ stale_root = ET.fromstring(svg)+ logical, carrier, _visible_preview = imported_parts(stale_root)+ logical.set('data-pptx-preview-sha256', '0' * 64)+ carrier.set('data-pptx-preview-sha256', '0' * 64)+ self.assertTrue(any(+ '<g> cannot use filter' in error+ for error in project_filter_errors(stale_root)+ ))++ mismatched_carrier_root = ET.fromstring(svg)+ _logical, carrier, _visible_preview = imported_parts(+ mismatched_carrier_root+ )+ carrier.set('data-pptx-prst', 'rect')+ self.assertTrue(any(+ '<g> cannot use filter' in error+ for error in project_filter_errors(mismatched_carrier_root)+ ))++ ordinary = ET.fromstring('''<svg xmlns="http://www.w3.org/2000/svg">+ <defs><filter id="shadow"><feDropShadow dx="0" dy="4"+ stdDeviation="6"/></filter></defs>+ <g filter="url(#shadow)"><rect x="0" y="0" width="10" height="10"/></g>+</svg>''')+ self.assertTrue(any(+ '<g> cannot use filter' in error+ for error in project_filter_errors(ordinary)+ ))+def test_missing_paint_reference_blocks_checker_and_exporter(self):self._assert_checker_and_exporter_reject('''<svg xmlns="http://www.w3.org/2000/svg"