Skip to content

AI turns documents or topics into real, native PowerPoint decks—with native shapes, transitions and animations, data-backed charts and tables on demand, audio narration from speaker notes, and support for your own .pptx templates. · by Hugo He

fix(pptx-to-svg): require explicit glow radius

hugohe3cbba61d94eee
diff --git a/skills/ppt-master/scripts/pptx_to_svg/effect_to_svg.py b/skills/ppt-master/scripts/pptx_to_svg/effect_to_svg.py
index c8d045ea..8945e8c0 100644
--- a/skills/ppt-master/scripts/pptx_to_svg/effect_to_svg.py
+++ b/skills/ppt-master/scripts/pptx_to_svg/effect_to_svg.py
@@ -350,6 +350,8 @@ def _outer_shadow(
def _glow(elem: ET.Element, palette: ColorPalette | None) -> str:
+ if elem.get("rad") is None:
+ raise ValueError("missing-rad")
rad = _blur_radius(elem, "rad")
color, alpha = _color_alpha(elem, palette)
# svg_to_pptx maps stdDeviation directly back to a:glow@rad.
diff --git a/skills/ppt-master/scripts/test_svg_quality_checker.py b/skills/ppt-master/scripts/test_svg_quality_checker.py
index e9022150..15274bfb 100644
--- a/skills/ppt-master/scripts/test_svg_quality_checker.py
+++ b/skills/ppt-master/scripts/test_svg_quality_checker.py
@@ -2617,6 +2617,13 @@ class SVGQualityCheckerCompatibilityTests(unittest.TestCase):
self.assertIn('stdDeviation="10"', glow_def)
self.assertNotIn('feMorphology', glow_def)
+ zero_glow = effect_result(f'''<a:effectLst xmlns:a="{dml}">
+ <a:glow rad="0"><a:srgbClr val="2563EB"/></a:glow>
+</a:effectLst>''')
+ self.assertIsNotNone(zero_glow.filter_id)
+ self.assertEqual(dict(zero_glow.metadata), {})
+ self.assertIn('stdDeviation="0"', ''.join(zero_glow.defs))
+
high_saturation = effect_result(f'''<a:effectLst xmlns:a="{dml}">
<a:glow rad="95250"><a:srgbClr val="2563EB">
<a:satMod val="175000"/>
@@ -2701,6 +2708,14 @@ class SVGQualityCheckerCompatibilityTests(unittest.TestCase):
f'<a:effectLst xmlns:a="{dml}"><a:outerShdw '
'dist="38100"/></a:effectLst>'
), 'missing-color'),
+ 'missing glow radius': ((
+ f'<a:effectLst xmlns:a="{dml}"><a:glow>'
+ '<a:srgbClr val="000000"/></a:glow></a:effectLst>'
+ ), 'missing-rad'),
+ 'empty glow radius': ((
+ f'<a:effectLst xmlns:a="{dml}"><a:glow rad="">'
+ '<a:srgbClr val="000000"/></a:glow></a:effectLst>'
+ ), "rad=''"),
'invalid srgb color': ((
f'<a:effectLst xmlns:a="{dml}"><a:outerShdw '
'dist="38100"><a:srgbClr val="bogus"/>'